While the FAL tests were already streamlined and simplified a lot,
the ResourceStorageTest class is still a mixture of functional and
unit test that involves heavy set up code and still does not mock
dependencies properly.
This test class needs a rewrite and a clean separation of units
together with a number of working functional tests to be of any use.
For now, all tests that rely on initialized database are skipped and
marked as TODO.

Change-Id: I3191c809c50f4f19ab91b9a5b5f2f3ebc3fa47ff
Resolves: #56940
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28424
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

The hook was introduced and deprecated when
simulatestatic was moved to TER for 6.0.

Furthermore the old wapversion.lib files are
not part of the Core anymore, hence we can remove
some more overhead.

Resolves: #56491
Releases: 6.2
Change-Id: Ib9c05895eed3539ac9e540b39d720038c5cacedb
Reviewed-on: https://review.typo3.org/27991
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Change-Id: Idad4b11894ee6e09e0b8eca9a057c7a776925a70
Resolves: #56939
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28423
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

During bootstrapping in index_ts.php there is a check
for an existing be_typo_user cookie which enables
TimeTracking. The simple static getter triggers the loading
and parsing of BackendUserAuthentication and
AbstractUserAuthentication which are both pretty fat classes
and have an impact upon eID calls and frontend calls.

This patch inlines the cookie name retrieval and defers thus
the loading of the fat classes.

Resolves: #56316
Releases: 6.2
Change-Id: I5ce5cf92095dcb8820fb0e548e16e38a99f4f12e
Reviewed-on: https://review.typo3.org/28418
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

With the switch to mysqli object it is now possible to fully mock
and check the final database calls in DatabaseConnectionTest, the
test table can be removed after refactoring the tests.

Change-Id: I60e33f6af5b4be8111a21469d12e38843650e7c4
Resolves: #56938
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28422
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Tests of the Typo3DatabaseBackend are refactored to not depend on
initialized $GLOBALS['TYPO3_DB'] anymore, queries and quoting is
now performed to a mock object. Next to a better separation this
has the advantage of a nice speedup executing those tests.

Change-Id: I8fc23fec56a50e48f74422eac3ee4a07ed3669b9
Resolves: #56937
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28420
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Fixes different headers and columns paddings for .t3-table
and the former .typo3-dblist. Also fixes .row-header link
hover style where text links went black and dark gray.

Resolves: #56926
Releases: 6.2
Change-Id: I0e93ccc315f4740b87be7656df1d54cd40272be7
Reviewed-on: https://review.typo3.org/28406
Reviewed-by: Marcin Sągol
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Unit tests reveal some warnings which are caused by incomplete
mocking. They all belong to $GLOBALS['LANG']

Change-Id: Ic2adda9984a530b82e259c1d8931015996f167ba
Resolves: #56700
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28407
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

After cache clearing we can run in the situation that 2 processes will
rebuild the ClassLoader cache which will lead to a non useable cache,
which produces fatals. As the data is generated more than once the load
of the server increases per request while ClassLoader cache is build.

The implemented Locking will stop this issue. Every process waits till
the first is ready and then looks if data was generated and stops re-
generating the cache.

Resolves: #55099
Releases: 6.2
Change-Id: I109821b9c37ec99c5ec5dbc5bcef6223d1d0d153
Reviewed-on: https://review.typo3.org/28156
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

After the removal of GLOBALS initialisation the extension raises
warnings in unittests.

Change-Id: I450932b1de1852302e4ae9861b250c5721f6032e
Resolves: #56930
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28412
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik

Code cleanup for locker and fix of semaphore locking.
It is now possible to reuse a semaphore.

Resolves: #40420
Releases: 6.2
Change-Id: I843aca1f9fa3d070ce0a508a27d3c433725991fa
Reviewed-on: https://review.typo3.org/28159
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik

Since the refactoring of the publicURL Feature and the possibility to
link to files via jump-scripts the generation of publicUrls for files
in storage zero is broken due to the fact that every relative base-path
for this URL is appended with a slash.

If the base-path has been empty (like for storage 0), appending a slash
makes it absolute.

This patch changes the behaviour to only append a slash on non-empty
paths.

Releases: 6.2
Resolves: #56927
Change-Id: I14e8bae0b64ed8dc537a5edbf57d9dce6ddf0932
Reviewed-on: https://review.typo3.org/28395
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

The submodule "Localization Overview" of Web > Info is missing
language labels. These labels are requested from the wrong localization file.

This patch fixes this by changing the label calls to a different file.

Change-Id: Id6aaddf3e9bb88da30bb5008b875279b0b07daa5
Resolves: #56767
Releases: 6.2
Reviewed-on: https://review.typo3.org/28260
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Change-Id: I1daabdbb0e39badb3575f6cea9fd1d4bd1e95ba3
Resolves: #56913
Releases: 6.2
Reviewed-on: https://review.typo3.org/28389
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

The system will only generate a thumbnail for IRRE records if the
related file object is an image file.

Additionally the UID of the file reference will be used as alternative
text and as title for the thumbnail so that it behaves like the icon
that is used for non-image files.

Resolves: #56274
Releases: 6.2
Change-Id: Ibe6530368434c384d5b7cca93e81b656c8c56383
Reviewed-on: https://review.typo3.org/27844
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

The test class contains only one test, but to execute this,
it depends on many classes which are not all properly mocked and a
nightmare to maintain. Additionally the test has nothing
to do with the execution of tasks, so subject scope is not met.

To keep test maintenance a doable task this test class in removed.

Change-Id: I97ac02040cb6dc711dcc300fb84c15c6785736e2
Resolves: #56924
Relates: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28401
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

This patch changes the Content-Disposition header so it is also
send when $asDownload isn't set with value inline and the filename
is between quotes.

Resolves: #56923
Releases: 6.2
Change-Id: Ic47c7d3743e7bac73936d20addbc61193e6fd49c
Reviewed-on: https://review.typo3.org/28399
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

To avoid conflicts with normalize.css, we remove the normalization done by
ExtJS, which is loaded after the normalize.css now.

Resolves: #56418
Releases: 6.2
Change-Id: I8a5b633244c5074755d478d0497b8f438ef86b65
Reviewed-on: https://review.typo3.org/28069
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Frans Saris
Tested-by: Frans Saris

Make sure RootlineUtility::enrichWithRelationFields() respects
the setting of $TCA[$table]['ctrl']['enablecolumns']['disabled'] when
fetching foreign data for the rootline.

Otherwise hidden relations from sys_file_reference are added to the
rootline and cause exceptions in the frontend, instead of being ignored.

Resolves: #56150
Releases: 6.2, 6.1
Change-Id: I21917fec1407a10818058da8ea879b0bb39441a4
Reviewed-on: https://review.typo3.org/28277
Tested-by: Wouter Wolters
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Release PreparedStatementTest from an active DB connection. The
quote tests are refactored a bit to find out in one specific test
if it is done for parameters.

Change-Id: I37853cd49368c2b23d0c2d6926fc806618674279
Resolves: #56922
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28398
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Test files and class naming is adapted to subject class names in
ext:core Log/Writer and the DatabaseWriterTests are rewritten to
not depend on initialized database connection anymore.

Change-Id: Ifff4e5a064018bb5b0db3bf9eeb1b9232adfb262
Resolves: #56921
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28396
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Some tests still rely on initialized $GLOBALS['TYPO3_DB']. The patch
handles some easy cases in ext:core.

Change-Id: I5b720154035cc5f8b156a9358806673daaf9c9ec
Resolves: #56918
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28394
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

The JavaScript in the RTE element browser is now initialized at the
end of the initialization process to make sure that all required
class variables (like $this->act) are initialized.

Resolves: #56860
Releases: 6.2
Change-Id: I39d3223921c5b17cffb31d98d62f02fa46663d27
Reviewed-on: https://review.typo3.org/28338
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Change-Id: I4bd6ff219c3232211106e968fce45ee3f2dd674a
Resolves: #56914
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28390
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Mock deterimenRootline to suppress calling database stuff
in dependencies.

Change-Id: I54938f9e20d52eda568c6520fa7bd72ec19b61e2
Resolves: #56912
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28388
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

ext:backend test getNodesSetsIsMountPointField() works on getNode()
of PageTree DataProvider. The method has tons of dependencies that
are sometimes even static, and the method is recursive. It is very
hard to test properly and the current test is still not mocking
completly. The test is removed for now since it does not give us
much benefit and is hard to maintain in current state, the subject
method should be covered by tests again if it was refactored.

Change-Id: I344c584b4d6e3868471f4857a08223be3a5d03e4
Resolves: #56907
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28384
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The workspace modify test "changeElementSorting" is failing
in the frontend for the TCA types "select" and "group".

The reason is, that the move placeholder is not selected
via the "uidInList" TypoScript property and thus removed
in PageRepository::versionOL().

To avoid that, "uidInList" gets extended to look-up
move placeholders if versioning preview is enabled.

Resolves: #56782
Releases: 6.2
Change-Id: Ifae30527bead02b38888f326de2615f6bfe35f5b
Reviewed-on: https://review.typo3.org/28278
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Thorsten Kahler
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Do not call __construct of subject.

Change-Id: I7b936efde9220c847b0a6278ea0d5b3606203e17
Resolves: #56894
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28374
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Unittests reveal some warnings which are caused by incomplete mocking.

Change-Id: I42089bb6c9016187d83382a2fa10450310993a84
Resolves: #56700
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28370
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The checkbox "Include Access Lists" in the be_groups just produces extra
clicks and extra reloads. If you don't need those information in the
current group, just don't look at the tab.

Change-Id: I300f711944e76e4366472cf99011e1b193224239
Resolves: #56893
Releases: 6.2
Reviewed-on: https://review.typo3.org/28373
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

If the FunctionalTestCaseBootstrapUtility::removeInstance() tries to
delete an existing symlink to a folder, the function unlink() is used.
This leads to a warning on Windows systems because unlink can only
delete files and symlinks to files.
This patch adds a rmdir() call for symlinks which works for Windows
system as well.

Resolves: #56892
Releases: 6.2
Change-Id: I2de757daea89a65a0a631c7592287e16218c1452
Reviewed-on: https://review.typo3.org/28371
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

* Improves the structure
* Removes useless if
* Retrieves the cacheManager only once

Resolves: #56879
Releases: 6.2
Change-Id: Id96a3c74a58a9ebb9eb16aa55f87791afcba6a66
Reviewed-on: https://review.typo3.org/28351
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Remove dependencies in BackendUtilityTest with better mocking and
introduce static:: instead of self:: in BackendUtility for late
static binding.
The flexForm test for getExcludeFields() is separated to an own
test and an array duplication bug confusing array key and value
in getExcludeFields() is fixed along the way.

Change-Id: If242bab64075aee5050dfc77317e54dcb2f5e25d
Resolves: #56854
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28331
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Use a table with the according styles instead of
the old bgColor4/6 classes

Resolves: #56870
Releases: 6.2
Change-Id: I272f13f3c77a8b174d6a62524ed7a0afa6da90cc
Reviewed-on: https://review.typo3.org/28346
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

* Move modAccess check to constructor
* Move isLoaded check to constructor
* Remove check if extbase is loaded
* Replace $TYPO3_CONF_VARS to $GLOBALS['TYPO3_CONF_VARS']

Resolves: #56831
Releases: 6.2
Change-Id: Ib824d34219bc1afb646fbaf70b572b6bd3a55a47
Reviewed-on: https://review.typo3.org/28308
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

* Remove deprecated calls to require_once
* Restore license header
* Remove empty TODO file

Resolves: #56832
Releases: 6.2
Change-Id: I291f5469638659d64e9df181017d1588f27317e1
Reviewed-on: https://review.typo3.org/28309
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Resolves: #56838
Releases: 6.2
Change-Id: Iac44b90bc96529458a2e452e47cb5548600464b0
Reviewed-on: https://review.typo3.org/28315
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Resolves: #56834
Releases: 6.2
Change-Id: Iec646bbae646bb85479f9f19c438e6aa9283e0dd
Reviewed-on: https://review.typo3.org/28311
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Resolves: #56837
Releases: 6.2
Change-Id: Ieec0e8f532abd8fab0444e137c31424f1a69b67e
Reviewed-on: https://review.typo3.org/28314
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

* Remove deprecated require_once call

Resolves: #56835
Releases: 6.2
Change-Id: I7d79b4c9947c5f3da82c66a4dbb0e3d2e0fd9284
Reviewed-on: https://review.typo3.org/28313
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind