Change-Id: Ie76570ebce5ea227a947132180e8555c79fbcc48
Resolves: #27173
Reviewed-on: http://review.typo3.org/2494
Reviewed-by: Mario Rimann
Tested-by: Mario Rimann
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

In case of parse errors in an ext_emconf.php file, the error message
has been suppressed because of an @include(). Nevertheless, the EM
stops working with a blank page (without any error log entry).

Removing the @ shows the warning so that it easier for the user to
identify the erroneous extension.

Change-Id: I971da980ace41d91dc99f466f1eb137bb0a46add
Resolves: #17506
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/2503
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Steffen Kamper
Tested-by: Steffen Kamper
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

This fix changes the used compare function for
t3lib_div::naturalKeySortRecursive() from strcasecmp to strnatcasecmp.
This ensures >natural< sorting especially in conjunction with
numbers in strings.

Change-Id: Ia9cd9a36da2bc0b6111a025e73b5bf8d26319c08
Resolves: #26485
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1787
Reviewed-by: Markus Klein
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

Show correct record title in backend module using t3lib_BEfunc::getRecordTitle()
in template.php and beuser module.

Change-Id: I07bb88509f37a3218d89149a71705054ed75985d
Resolves: #27100
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2409
Reviewed-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Andy Grunwald
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

When creating multiple new pages through the functions => wizard, and you'll create the pages you always get a JS question if you really want to do this. This is poor usability and stops the workflow because by that time, everyone should know what he's/she's doing. Additionally, this behaviour is very-"Windows"-like and is not really done in the same way on many other spots of the CMS.

Change-Id: I3990af110785f06b431ad1bdb8d93147397fbf4a
Resolves: #27104
Reviewed-on: http://review.typo3.org/2415
Reviewed-by: Patrick Rodacker
Tested-by: Patrick Rodacker
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Reviewed-by: Björn Pedersen
Reviewed-by: Andy Grunwald
Tested-by: Andy Grunwald
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Layout configuration of FORM fields with type LABEL is taken from type
CHECK when no stdWrap options are defined.
Thanks to Alexander Claes for this fix.

Change-Id: I260afc718acaa027a8b2c2636d6c366459e55691
Resolves: #26867
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2191
Reviewed-by: Christopher 
Tested-by: Christopher 
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Change-Id: I0de40afe0c1253bef8194ce99675a6cd3895e5de
Resolves: #26914
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/2299
Reviewed-by: Oliver Klee
Reviewed-by: Björn Pedersen
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Andy Grunwald
Tested-by: Andy Grunwald
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

After moving from PHP4 to PHP5 constructors fatal PHP error occurs because core still calling PHP4 constructors.

Change-Id: I5633413553431d85955282b2e1b9ef869aa8b7c2
Resolves: #27001
Related: #26505
Releases: 4.6
Reviewed-on: http://review.typo3.org/2331
Reviewed-by: Oliver Klee
Reviewed-by: Patrick Rodacker
Tested-by: Patrick Rodacker
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Change-Id: I6472d853b71aff2bde27ce054fec275f7c68fa95
Resolves: #27152
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/2488
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

The 'Status Legend' in the Scheduler backend module does not use
<img title="" /> tags. Only <img alt=""> tags.
This patch writes the value from alt=""-Tag to title="" tag.

Thanks to Qitec for the original patch.

Change-Id: I401e3a129d8ef1dd7ea8c9d1130d1ed5ed1f6339
Resolves: #25661
Releases: 4.6
Reviewed-on: http://review.typo3.org/2446
Reviewed-by: Andy Grunwald
Tested-by: Andy Grunwald
Reviewed-by: Francois Suter
Tested-by: Francois Suter

Except to a database structure change of the experimental PDO backend all
changes are backwards compatible for existing extensions usages if the
current API is not misused.

Notable changes:
- A new "context" variable for backends constructors was introduced. In v4 it
  is always set to "production" in production environment and to "Testing" for
  unit tests. Other than that it is unused and was ported to keep v4 and
  FLOW3 in sync.
- File backend now uses different directories for a code and data caches.
- Files created by the file backend have a .php suffix for code caches.
- In file backend, FLOW3 removed the cacheDirectory() method. It is kept
  for v4 to enable us to have cache directories outside of the document root.
- File backend unit tests use vfs (virtual file system). This way no more
  files are created by unit tests in the file system that must be cleaned up.
- t3lib_cache_Manager has a new method injectCacheFactory(), used by
  t3lib_cache_Factory. t3lib_cache, tslib_fe and init.php reflect this change.
- t3lib_cache_Factory calls initializeObject() of frontends and backends if the
  method exists. Some __construct() calls are moved to this method.
- Some code and unit tests now use name spacing for global objects.
- t3lib_cache_Manager has new protected methods to call all configured caches
  on flushCaches() and flushCachesByTag().
- Pdo backend changed its database structure and uses a "context" field instead
  of "scope" now.
- Lots of minor variable renamings, comment changes and annotation fixes.

Change-Id: Ib1be85fbbe0cb198201fb09bbdb9f9e42c097d35
Resolves: #26263
Reviewed-on: http://review.typo3.org/1722
Reviewed-by: Björn Pedersen
Tested-by: Björn Pedersen
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

t3lib_sqlparser::compileWhereClause iterates over the where subparts. It is called from
DBAL when running DBAL in native (MySQL) mode.

It does however resets its output string whenever the subpart is either FIND_IN_SET or
IFNULL. This causes the queries built by Extbase to fail.

Change-Id: Iea3d6f02cc9b8151f9fd6454f393ff6089567a03
Fixes: #25488
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1458
Reviewed-by: Stefan Neufeind
Reviewed-by: Georg Schönweger
Tested-by: Georg Schönweger
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Change-Id: I10a9814366e69dfdbf87e8ab404ab4d2ce02f4c3
Resolves: #26483
Reviewed-on: http://review.typo3.org/1813
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Reviewed-by: Christopher 
Tested-by: Christopher 
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

The meta charset tag is not fully compatible with html5.
Remove the namespace to avoid the validator warning.

Change-Id: I8275b677e5394f59dbd1efc65ced93f57149ebae
Resolves: #24212
Reviewed-on: http://review.typo3.org/2280
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

t3lib_extFileFunc has a lot of deeply nested conditions. These
conditions make understanding the code really hard.

Most of the else-branches only contain a log call, so it helps a lot to
invert the conditions, move the log call inside the if-branch and add a
break statement afterwards. The else branch can then be removed to
streamline the code.

Change-Id: Ic900fe3294142ebc89be4c3d420bb729a24d5452
Resolves: #24218
Reviewed-on: http://review.typo3.org/1087
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Stefan Neufeind

Class tslib_feUserAuth contains TER specific code. This issue is about
to remove this piece of code.

In specific this is EXT:commerce related code which has been
introduced with the TYPO3 Core Session Fixation Security Fix.

Whether fixed or not in commerce, Core should not fix code for
TER listed extensions. However, as commerce list currently very active
it should be possible for the contributors to fix problems if still
existing.

Change-Id: I2dae9c6f5fa24ce11f43ebd612523a00101e2990
Resolves: #27027
Reviewed-on: http://review.typo3.org/2364
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

PHP_SCRIPT, PHP_SCRIPT_INT and PHP_SCRIPT_EXT objects are old
TypoScript content objects which really shouldn't be used anymore.
Mark them as deprecated.

Change-Id: I6f17728e6202291ba5594fa9e1af8d05112acfe8
Resolves: #26936
Releases: 4.6
Reviewed-on: http://review.typo3.org/2269
Reviewed-by: Xavier Perseguers
Reviewed-by: Christopher 
Tested-by: Christopher 
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Francois Suter
Tested-by: Francois Suter

Although extbase urges to use Tx_ as prefix for class name, this prefix
is not accepted in all places of the core.

Change-Id: Icb46d875fdf66eaf6f51367cf3ef5030c07a4128
Resolves: #22594
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/1609
Tested-by: Philipp Gampe
Reviewed-by: Kay Strobach
Tested-by: Kay Strobach
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Jigal van Hemert

Thanks to Christian Hennecke.

Change-Id: Ie3a6b285e3a1d79f71baa975e836a447c3449681
Resolves: #26724
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2220
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

The global TCA definition is empty in some upgrade wizards.
This was caused by a general clean-up to remove PHP global
statements that did not seem to be required anymore. However,
if PHP files get included inside a method or function accessing
$TCA did not happen in a global context.

Change-Id: I17df6b3caeda0ff2b5a7399c457ccebc57627882
Resolves: #26515
Reviewed-on: http://review.typo3.org/1809
Reviewed-by: Steffen Gebert
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Change-Id: Ib9458084608ef938ab28a961d24a69cc29b7c45b
Reviewed-on: http://review.typo3.org/2111
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Constant TYPO3_URL_DONATE is defined twice. Once with
the old, simulate static URL, and once with the new, current
URL.

Change-Id: If7d2ead0e86ac93d18251db38a7c226af5903355
Resolves: #26781
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2094
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Due to a syntax error, stdWrap for the target attribute of
the click-to-enlarge image link is broken. (Nobrainer)

Change-Id: Ie107fe9d4ddcfe04d341755834c049487e205c2d
Resolves: #26757
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2079
Reviewed-by: Björn Pedersen
Reviewed-by: Stefano Kowalke
Tested-by: Stefano Kowalke
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Change-Id: I2c120b64734eafd24fa848f9728edb2ebd572a97
Reviewed-on: http://review.typo3.org/2062
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team

Change-Id: I42a88d82c1f1e252946f15d0ae53e037fe3ddfb1
Reviewed-on: http://review.typo3.org/2061
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team

This reverts commit be13ba38.

Change-Id: I1f16e8bd6d5853fd0153cea8f8d128dff4e289e2
Reviewed-on: http://review.typo3.org/2059
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Change-Id: I56b4964444f4320fd76be3473e97a9e076b1fc41
Reviewed-on: http://review.typo3.org/2057
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team

This reverts commit 2512e832.

Change-Id: Ie706762dcd844984c0031f01813f2c71f98da20d
Reviewed-on: http://review.typo3.org/2056
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Change-Id: I952e21e466288b77fba172e0561004b4bec26f39
Reviewed-on: http://review.typo3.org/2055
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team

This reverts commit fab9e662.

Change-Id: I7fd68d23f6b259171b7af337281f76b8a187e2f3
Reviewed-on: http://review.typo3.org/2054
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Change-Id: I8a466e03172f2bbd2fd1fe6c79f4d40efa3da028
Reviewed-on: http://review.typo3.org/2053
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team

IM4 and IM5 support has been deprecated and is scheduled for
removal in TYPO3 4.6. Default empty setting for im_version_5
meant IM4. It should now reflect v6 instead.

Change-Id: Idcebd41d9cf6059ea61363a8965fef9d526e9d00
Resolves: #24146
Reviewed-on: http://review.typo3.org/2049
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

IM4 and IM5 support has been deprecated and is scheduled for
removal in TYPO3 4.6.

Change-Id: Ib7610a3666e764e32c854fb04b5d80ef3030dad3
Resolves: #24146
Reviewed-on: http://review.typo3.org/1989
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Using the new PHP5 constructors (__construct) instead of PHP4 variants.

Change-Id: Iab19b1be570cde143dacbbe244aedaf2dd8ce1a6
Resolves: #26505
Releases: 4.6
Reviewed-on: http://review.typo3.org/1797
Reviewed-by: Stefan Neufeind
Reviewed-by: Oliver Klee
Tested-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Change-Id: Iaae5e6978096de060a1253f14de01b763048645c
Resolves: #26738
Releases: 4.2, 4.3, 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/2016
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

These parts are not working with IRRE in workspaces:
Removing children in TCEforms
Removing children in the list view
Reverting changes in the workspace module

Change-Id: I91313235e57c193e7103d065c02d2005ef74ab86
Resolves: #25352
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1195
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Variable $codeLines should be initialized prior to being used
in a concatenation within the loop.

Change-Id: Ife0b44b937a33040f46402492a5ede6e99d39668
Resolves: #26622
Releases: 4.6
Reviewed-on: http://review.typo3.org/1927
Reviewed-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Affected projects: version, workspaces

Change-Id: Ic0229c0a25e450d4aae96843965bd7629780cce8
Reviewed-on: http://review.typo3.org/1981
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Part 2/2

Change-Id: If78cf29e57c7ab560082826cbc395ad35fad0097
Resolves: #26581
Reviewed-on: http://review.typo3.org/1948
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Part 1/2

Change-Id: I13ba0ff933510e5ee83fc719fb87933555ac3e70
Resolves: #26581
Reviewed-on: http://review.typo3.org/1947
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Stefan Neufeind