- Aug 25, 2012
-
-
Tymoteusz Motylewski authored
Fixes wrong class names in Extbase scheduler. Change-Id: I5117f8caebfda9249499ac57c88019846c80886e Related: #40095 Fixes: #40156 Release: 6.0 Reviewed-on: http://review.typo3.org/14058 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Aug 24, 2012
-
-
Christian Kuhn authored
Make phpunit backend module for extbase tests load again Change-Id: Ib3e05e343d2f34185c52727f16ede1331332b7ca Resolves: #40135 Related: #40095 Releases: 6.0 Reviewed-on: http://review.typo3.org/14046 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Thomas Maroschik authored
Change-Id: Ib6475e5aed3633672c30a855edbf6c71b938510c Resolves: #40119 Related: #40095 Releases: 6.0 Reviewed-on: http://review.typo3.org/14034 Reviewed-by: Thomas Maroschik Tested-by: Thomas Maroschik Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Oct 17, 2012
-
-
Thomas Maroschik authored
Change-Id: I403aee9d244a65e51547b21dac3b1228ffd3478e
-
Thomas Maroschik authored
Change-Id: I916ad5a3a24864a52e945aeb66e6f997b8e6fabd
-
Thomas Maroschik authored
Change-Id: Iaae73adcbba323ed5ca903e38f0b2f2e06f497e7
-
- Aug 20, 2012
-
-
Christian Kuhn authored
Since the rootline refactoring a test case fails. Solution is to only call the rootline in backend mode if page id is not 0. This additionally saves some cycles in backend context. Change-Id: I224ae2655b06dfb1f239b06d6ac2cbb89206a7a8 Resolves: #39997 Related: #39352 Releases: 6.0 Reviewed-on: http://review.typo3.org/13966 Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Aug 19, 2012
-
-
Oliver Hader authored
Warning: This feature is marked as experimental! It is a quick shot to get a basic connection between extbase and FAL. We added the code to see if it works out, but it is also possible that we decide to throw it away completly and substitute it with something different later on. Be aware of this if you use the models and type converters in your code! Since the file abstraction layer (FAL) has been introduced during the development of TYPO3 6.0, it is also required to have an automized and fluent way to access those abstract files via Extbase. Since the FAL models cannot completely and directly be used as Extbase Domain object, simple wrapping objects are defined to access the concrete objects. The patch adds the basic models for this. Furthermore additional type converter classes are added for those models. The patch contains an additional base test case that is able to create a test database and feed it with fixture data, it is also marked as experimental. Change-Id: I537d32377ddd891627af2c163af252c48554d003 Resolves: #39926 Releases: 6.0 Reviewed-on: http://review.typo3.org/13885 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Aug 17, 2012
-
-
dkd-egerer Sascha Egerer authored
The transformToObject function in the property mapper checks for an existing record if an identity is given. If no record could be found an exception should be thrown. But the exception will never be thrown due to a wrong condition. The condition checks for FALSE but NULL is given. The Exception does also not exist. Change-Id: If6ac4d3275718cabab9c94904dad264472630c18 Fixes: #39876 Releases: 1.3, 1.4, 4.7, 6.0 Reviewed-on: http://review.typo3.org/13842 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Markus Günther authored
To improve the test coverage we should have unit tests for the frontend user group model in extbase. Change-Id: I8e1005e9178161f2ba41b2277a7d993b8448eba9 Resolves: #39848 Release: 6.0 Reviewed-on: http://review.typo3.org/13809 Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Markus Günther authored
To improve the test coverage we should have unit tests for the frontend user model in extbase. Change-Id: I975db656f7e7a3dcc2704923f4878acb0505fa49 Resolves: #39849 Release: 6.0 Reviewed-on: http://review.typo3.org/13846 Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Oliver Hader authored
The SignalSlotDispatcher has a connect() and dispatch() method. The connect() method usually might be used in ext_localconf.php to register accordant slots - however, the SignalSlotDispatcher relies on a fully initialized ObjectManager that also relies on a fully initialized Caching Framework. Since the Caches are not ready yet in ext_localconf.php the whole thing will fail. This patch removes the dependency of the ObjectManager injecting itself to the SignalSlotDispatcher by explicitely calling the initializeObject() method at a later point. The SignalSlotDispatcher can then be used like this: t3lib_div::makeInstance('Tx_Extbase_SignalSlot_Dispatcher') ->connect('Tx_MyClass', 'MySignal', 'Slot', 'slotMethod'); Change-Id: Ib0122a341865c334448f23a46bc8841c4817fdf7 Fixes: #39174 Releases: 4.7, 6.0 Reviewed-on: http://review.typo3.org/12989 Reviewed-by: Daniel Lorenz Reviewed-by: Jacob Rasmussen Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
Extbase reflection cache calls not existing methods. This can happen for example if a class is refactored and an injectMethod has been dropped. Change-Id: I30071b53f300ef340d6c882ed40f0f67fb86c440 Fixes: #39892 Related: #39174 Releases: 6.0, 4.7 Reviewed-on: http://review.typo3.org/13864 Reviewed-by: Oliver Hader Tested-by: Oliver Hader Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Aug 15, 2012
-
-
Kevin Ulrich Moschallski authored
Adds content of $_FILES to the request parameters. Use FLOW3 untangleFilesArray method to set the array, as suggested by Bastian Waidelich. Note that file properties must be arrays not strings. Thanks to Kevin Ulrich Moschallski for the patch. Thanks to Tymoteusz Motylewski for the unittest. Change-Id: Ib851c6412afc0291520e61613ad439e34e0603bd Fixes: #34528 Releases: 6.0 Reviewed-on: http://review.typo3.org/9379 Reviewed-by: Tymoteusz Motylewski Tested-by: Tymoteusz Motylewski Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes Reviewed-by: Ingo Pfennigstorf Tested-by: Ingo Pfennigstorf Reviewed-by: Markus Günther Tested-by: Markus Günther Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- Aug 14, 2012
-
-
Markus Günther authored
This patch delivers an backend usergroup model and repository. Change-Id: Ie0da23ee0160a928f74726ceec5b243348a331ef Resolves: #39332 Releases: 6.0 Reviewed-on: http://review.typo3.org/13626 Reviewed-by: Mattias Nilsson Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Markus Günther authored
Actually we have a backend user model in extbase and a backend usergroup is in progress. For these models we need a seperate file mount model. This patch includes the model and the repository with the typoscript mapping on the datebase table. Change-Id: Id0b4a1ad168ba189940282222bf4e08b6441a3bf Resolves: #39323 Releases: 6.0 Reviewed-on: http://review.typo3.org/13429 Reviewed-by: Ingo Pfennigstorf Tested-by: Ingo Pfennigstorf Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Jochen Rau authored
At the moment it's only possible to select either only visible (non-hidden, matching start-/stop-time) or all (even deleted) records. To ensure a consistent handling in sync with TYPO3 Core behavior, it's necessary to select disabled but not deleted records in the backend. This also effects findByUid() via the Typo3QuerySettings and allows to write to disabled records in BE context. * deprecates respectEnableFields in QuerySettingsInterface * introduces ignoreEnableFields in QuerySettingsInterface * introduces enableFieldsToBeIgnored in QuerySettingsInterface * introduces includeDeleted in QuerySettingsInterface * introduces feature flag ignoreAllEnableFieldsInBe to control default behavior * select disabled but not deleted records in BE context Fixes: #29501 Fixes: #8483 Change-Id: I11beb3b83589ad91d72d05116488408fff8d9e75 Releases: 6.0 Reviewed-on: http://review.typo3.org/8773 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Nicole Cordes authored
When selecting items in a language other than default one, the relations (e.g. for IRRE) can not be resolved correctly. This fix adds the current language if handling is enabled for the chosen table. Besides it corrects the ordering of items as it selects all possible ones. For correct overlay the origin is fetched before. Change-Id: Ibcfe83314c0f2fff54348d9ffab97cd7546779ca Resolves: #32072 Resolves: #32216 Releases: 6.0 Reviewed-on: http://review.typo3.org/10188 Reviewed-by: Jochen Rau Tested-by: Jochen Rau Reviewed-by: Stefan Neufeind Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Aug 13, 2012
-
-
Markus Günther authored
The actuall email validator uses a regex to validate email addresses. The TYPO3 core offers a method in t3lib_div to validate email addresses. This patch replace the regex with t3lib_div::validEmail() Change-Id: I8157a61b8f056d0a60510ec3a7ba9dcb182cb0e5 Releases: 6.0, 4.7 Resolves: #6970 FLOW3 issue: #39714 Reviewed-on: http://review.typo3.org/13550 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel Reviewed-by: Ingo Pfennigstorf Tested-by: Ingo Pfennigstorf Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Aug 09, 2012
-
-
Thomas Maroschik authored
When your dealing with entities, that not necessarily have their hasOne nested entities set then the DataMapper returns an empty array instead of null. In my opinion, an empty array makes no sense here, because there is no hasMany relation here. * Removed the unused $columnMap from DataMapper::fetchRelated * Added $columnMap in DataMapper::fetchRelatedEager * Check if the property has a RELATION_HAS_ONE and return null instead of an empty array then Change-Id: I0c766d9579cbb464bbae292b194f8df7e8c4a9e9 Fixes: #25708 Releases: 6.0, 4.7 Reviewed-on: http://review.typo3.org/1404 Reviewed-by: Tymoteusz Motylewski Tested-by: Tymoteusz Motylewski Reviewed-by: Stefan Neufeind Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Markus Günther Tested-by: Markus Günther
-
- Aug 05, 2012
-
-
Ingo Pfennigstorf authored
This makes exception 1316104317 more expressive and includes the extension- and pluginname in the exception message. Change-Id: Ia4787748487e32cd112327616992914bbf8bc736 Fixes: #33903 Releases: 6.0, 4.7, 4.6 Reviewed-on: http://review.typo3.org/12945 Reviewed-by: Tymoteusz Motylewski Reviewed-by: Oliver Klee Reviewed-by: Markus Günther Tested-by: Markus Günther Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
- Aug 02, 2012
-
-
Fabien Udriot authored
For extension developer's sake, it is convenient to provide a domain model along with a repository. Both are relying on Extbase. Change-Id: I7260a57dcc742f217f0ddfe19470673bc91532c9 Resolves: #38719 Releases: 6.0 Reviewed-on: http://review.typo3.org/12793 Reviewed-by: Oliver Klee Tested-by: Oliver Klee Reviewed-by: Fabien Udriot Tested-by: Fabien Udriot Reviewed-by: Sebastian Michaelsen Reviewed-by: Jochen Rau Reviewed-by: Georg Ringer Tested-by: Georg Ringer Reviewed-by: Mattias Nilsson Tested-by: Mattias Nilsson Reviewed-by: Markus Günther Tested-by: Markus Günther Reviewed-by: Ingo Pfennigstorf Tested-by: Ingo Pfennigstorf
-
Markus Günther authored
In the new backend user model the property lastlogin was not consistently in the spelling. Sometimes is it used as lastloginDateAndTime and in the methods it is used in correct lowerCamelCase lastLoginDateAndTime. This patch defines the property as lastLoginDateAndTime. Change-Id: I00e5fd98bcd82e333a6fc9a91f3fe497f2a09d12 Fixes: #39460 Releases: 6.0 Reviewed-on: http://review.typo3.org/13422 Reviewed-by: Georg Ringer Reviewed-by: Wouter Wolters Reviewed-by: Mattias Nilsson Tested-by: Mattias Nilsson Reviewed-by: Ingo Pfennigstorf Tested-by: Ingo Pfennigstorf
-
- Aug 01, 2012
-
-
Markus Günther authored
Some extensions in the TYPO3 backend use backend users. The belog and the beuser module are based on extbase and it will be useful if not every extension has to implement an own backendUser model. This patch adds a backend user model to extbase. Change-Id: I84e8ea528c5f91151369f59db6a00acb0174544b Resolves: #39145 Releases: 6.0 Reviewed-on: http://review.typo3.org/12981 Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes Reviewed-by: Oliver Klee Tested-by: Oliver Klee Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Jul 30, 2012
-
-
Alexander Schnitzler authored
Changed expected type of assign-param 'value' from object to mixed Change-Id: Ica8e8bd6f7971220da4a3a0fe0c8ca262560374c Fixes: #39385 Releases: 1.3,1.4,4.7,6.0 Reviewed-on: http://review.typo3.org/13347 Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs
-
- Jul 21, 2012
-
-
Felix Oertel authored
Typolink generates absolute uris with a leading slash. When prefixing this with the base uri, we have to make sure, there is just one slash in result. To prevent these situations we also trigger the UriBuilder itself to generate an absolute path. Thanks to Chetan Thapliyal. Change-Id: Iae8755514fbdfc4eb27a5a6eab620e55144d912e Fixes: #33788 Releases: 6.0, 4.7 Reviewed-on: http://review.typo3.org/8860 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel Reviewed-by: Daniel Lorenz Tested-by: Daniel Lorenz Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Markus Günther authored
In the class Tx_Extbase_Utility_Extension is the public method configureModule and it seems that the author of the method forget the static keyword. The method is used as a static method everywhere but it is not declared as static. This patch only set the method to static. Change-Id: I4ba19f3b0ff763dffd4109a65933623b79e85b45 Fixes: #37922 Releases: 6.0, 4.7 Reviewed-on: http://review.typo3.org/12938 Reviewed-by: Tymoteusz Motylewski Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Daniel Pötzinger authored
XDEBUG Profiler shows time saving possibilities in Tx_Extbase_Persistence_Storage_Typo3DbBackend->addEnableFieldsStatement (use of db->admin_get_fields) and Tx_Extbase_Persistence_Mapper_DataMapFactory->buildDataMap Caches should be added here. Also to be able to inject the cacheManager the Container needs a small fix Change-Id: I5c2defcfaa58c6454226d1abf938b6b6796b5232 Resolves: #36074 Releases: 6.0 Reviewed-on: http://review.typo3.org/10498 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Felix Oertel Tested-by: Felix Oertel
-
Markus Günther authored
The Tx_Extbase_Persistence_Mapper_DataMapper uses the objectContainer (Tx_Extbase_Object_Container_Container) for creating an empty object without calling the construct. The problem is that except the objectManager no one should use the objectContainer. So this patch adds a wrapper class to the object manager communicates with the objectContainer. Change-Id: I2a2f9d68c0ac0c14a47723ea901c974b7ccc6c5e Resolves: #13816 Release: 6.0 Reviewed-on: http://review.typo3.org/12973 Reviewed-by: Felix Oertel Tested-by: Felix Oertel
-
Daniel Pötzinger authored
The Container Classes Cache call is very expensive - and when using a database backend, this is even slowing down compared to a NullBackend. One reason is that for every cache request the cache is called 3 times: 1 time has and 2 times get. This can be avoided and be reduced to one get call - which reduces request time by 10-20% for a bigger Extbase request. Change-Id: I43a0ebf7e0bfd067f3e48c0e7c27f12660b4cb7c Resolves: #36008 Releases: 1.3, 1.4, 4.7, 6.0 Reviewed-on: http://review.typo3.org/10438 Reviewed-by: Daniel Lorenz Tested-by: Daniel Lorenz Reviewed-by: Schmidt Timo Tested-by: Schmidt Timo Reviewed-by: Tymoteusz Motylewski Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Ingo Pfennigstorf authored
The Extbase README file now contains links to the current documentation and api documentation Change-Id: I9f2d32f2d060cebc5a7865170f62d269ab8517e6 Fixes: #36020 Releases: 6.0, 4.7, 1.4 Reviewed-on: http://review.typo3.org/12943 Reviewed-by: Oliver Klee Reviewed-by: Tymoteusz Motylewski Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Tobias Liebig authored
The current request is needed in Tx_Extbase_MVC_Web_Response to distinguish between a cached or a non-cached request in addAdditionalHeaderData() as the PageRenderer does not support USER_INTs currently. This works fine is the ActionController is called with a Web_Response, but causes an fatal error if a Cli_Response is in charge. This fix and the $request member in Web_Response should be removed, once the PageRenderer is fixed for USER_INTs. For now, this patch fixes a fatal error in the fluid unit tests. Change-Id: I56fabc3a51ce2c5192ab4488c817b938ed8797ca Fixes: #36751 Releases: 6.0 Reviewed-on: http://review.typo3.org/12401 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel Reviewed-by: Daniel Lorenz Tested-by: Daniel Lorenz Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Ingo Pfennigstorf authored
This corrects the whitespaces in if statements for Extbase. Change-Id: Ie2266202ca819b78d23d7e28cb6c359cf691eee0 Fixes: #37805 Releases: 6.0 Reviewed-on: http://review.typo3.org/12957 Reviewed-by: Felix Oertel Tested-by: Felix Oertel
-
- Jul 20, 2012
-
-
Nicole Cordes authored
This is a backport of the fix done in FLOW3. The corresponding FLOW3 ticket is #30493 With this fix the last argument may use the equals sign (=) again to separate between argument name and value. Besides writing an additional test case which reproduces the issue, the other test cases have been strengthened by replacing assertEquals() by assertSame(). Change-Id: I7d7fa4e5f18a73308cc564db152fd31ab3c4e478 Fixes: #36745, #35207 Relates: #30493 Releases: 6.0, 4.7, 1.4 Reviewed-on: http://review.typo3.org/10919 Tested-by: Christian Kuhn Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Christian Kuhn authored
-
Michael Klapper authored
Allow rendering of plugin content during tx_crawler call if option "Make direct requests" is enabled. Change-Id: I79f992d94924e1b069486715bfa20808cd84588e Fixes: #34691 Releases: 6.0,4.7
-
dkd-egerer Sascha Egerer authored
Localization::translate() returns an empty string instead of NULL if no translation string is found but arguments are given Change-Id: Id21ca9bc59a59d6115dc70decf2294497d871a81 Fixes: #34874 Related: #34877 Releases: 6.0, 4.7, 1.4, 1.3
-
Tobias Liebig authored
While back porting changes (#35255) a unit test broke in Validation_Validator_BeforeExtbase14_NumberRangeValidatorTest. Change-Id: I31309474866e5edae747ea420e94e65d1638758f Resolves: #38426 Releases: 6.0
-
- Jul 03, 2012
-
-
Oliver Hader authored
The Fluid TemplateCompiler uses closures to store a cached variant of the accordant Fluid node. Several calls in Fluid use serialize() and also will process those closures, which will end up in a PHP fatal error. The most obvious part is the object manager which will then try to serialize all objects - including closures - that are available in the object container. The problem can be circumvented by using accordant magic PHP methods like __sleep() and __wakeup() to ignore those properties. Change-Id: I70e78a09b2a118cc26f099063743c530f0addc72 Fixes: #32295 Related: #36820 Releases: 6.0, 4.7, 4.6
-
- Jul 01, 2012
-
-
Christian Kuhn authored
The patch for issue #35866 removed all class entries from ext_autoload and relies on the 'extbase' naming scheme autoloader to find classes. This has the side effect that classes must be requested in upper camel case, otherwise they are not found. The frontend extbase plugins are called by a TypoScript userFunc. The requested extbase core bootstrap class must therefore be used with upper camel case as well. Change-Id: I67f1a0d3025b945ec8788f031b676fa62439a2c3 Resolves: #38527 Related: #35866 Related: #37920 Releases: 6.0
-