Skip to content
Snippets Groups Projects
  1. Aug 25, 2012
  2. Aug 24, 2012
  3. Oct 17, 2012
  4. Aug 20, 2012
    • Christian Kuhn's avatar
      [BUGFIX] Failing test translateForEmptyStringKeyReturnsNull() · cec1032b
      Christian Kuhn authored
      Since the rootline refactoring a test case fails. Solution is to only
      call the rootline in backend mode if page id is not 0. This additionally
      saves some cycles in backend context.
      
      Change-Id: I224ae2655b06dfb1f239b06d6ac2cbb89206a7a8
      Resolves: #39997
      Related: #39352
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/13966
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      cec1032b
  5. Aug 19, 2012
    • Oliver Hader's avatar
      [FEATURE] Integrate basic file abstraction layer models · 8e04b3fd
      Oliver Hader authored
      Warning: This feature is marked as experimental! It is a quick shot to
      get a basic connection between extbase and FAL. We added the code to
      see if it works out, but it is also possible that we decide to throw it
      away completly and substitute it with something different later on. Be
      aware of this if you use the models and type converters in your code!
      
      Since the file abstraction layer (FAL) has been introduced during the
      development of TYPO3 6.0, it is also required to have an automized and
      fluent way to access those abstract files via Extbase. Since the FAL
      models cannot completely and directly be used as Extbase Domain object,
      simple wrapping objects are defined to access the concrete objects.
      
      The patch adds the basic models for this. Furthermore additional type
      converter classes are added for those models.
      
      The patch contains an additional base test case that is able to create
      a test database and feed it with fixture data, it is also marked as
      experimental.
      
      Change-Id: I537d32377ddd891627af2c163af252c48554d003
      Resolves: #39926
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/13885
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      8e04b3fd
  6. Aug 17, 2012
    • dkd-egerer Sascha Egerer's avatar
      [BUGFIX] Property mapper: Exception not thrown but skipped · af5688ac
      dkd-egerer Sascha Egerer authored
      The transformToObject function in the property mapper
      checks for an existing record if an identity is given.
      If no record could be found an exception should be thrown.
      But the exception will never be thrown due to a wrong
      condition. The condition checks for FALSE but NULL is
      given.
      
      The Exception does also not exist.
      
      Change-Id: If6ac4d3275718cabab9c94904dad264472630c18
      Fixes: #39876
      Releases: 1.3, 1.4, 4.7, 6.0
      Reviewed-on: http://review.typo3.org/13842
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      af5688ac
    • Markus Günther's avatar
      [TASK] Unit test for FrontendUserGroup model · d423dbb9
      Markus Günther authored
      To improve the test coverage we should have unit tests for the
      frontend user group model in extbase.
      
      Change-Id: I8e1005e9178161f2ba41b2277a7d993b8448eba9
      Resolves: #39848
      Release: 6.0
      Reviewed-on: http://review.typo3.org/13809
      Reviewed-by: Nicole Cordes
      Tested-by: Nicole Cordes
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      d423dbb9
    • Markus Günther's avatar
      [TASK] Unit test for FrontendUser model · 221cccc9
      Markus Günther authored
      To improve the test coverage we should have unit tests for the
      frontend user model in extbase.
      
      Change-Id: I975db656f7e7a3dcc2704923f4878acb0505fa49
      Resolves: #39849
      Release: 6.0
      Reviewed-on: http://review.typo3.org/13846
      Reviewed-by: Nicole Cordes
      Tested-by: Nicole Cordes
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      221cccc9
    • Oliver Hader's avatar
      [BUGFIX] ObjectManager dependencies in SignalSlot registration · 2c08ed96
      Oliver Hader authored
      The SignalSlotDispatcher has a connect() and dispatch() method.
      The connect() method usually might be used in ext_localconf.php
      to register accordant slots - however, the SignalSlotDispatcher
      relies on a fully initialized ObjectManager that also relies on
      a fully initialized Caching Framework.
      
      Since the Caches are not ready yet in ext_localconf.php the
      whole thing will fail.
      
      This patch removes the dependency of the ObjectManager
      injecting itself to the SignalSlotDispatcher by explicitely
      calling the initializeObject() method at a later point.
      
      The SignalSlotDispatcher can then be used like this:
      
      t3lib_div::makeInstance('Tx_Extbase_SignalSlot_Dispatcher')
        ->connect('Tx_MyClass', 'MySignal', 'Slot', 'slotMethod');
      
      Change-Id: Ib0122a341865c334448f23a46bc8841c4817fdf7
      Fixes: #39174
      Releases: 4.7, 6.0
      Reviewed-on: http://review.typo3.org/12989
      Reviewed-by: Daniel Lorenz
      Reviewed-by: Jacob Rasmussen
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      2c08ed96
    • Christian Kuhn's avatar
      [BUGFIX] Possible failure in dependency injection · d0d2970b
      Christian Kuhn authored
      Extbase reflection cache calls not existing methods. This can
      happen for example if a class is refactored and an injectMethod
      has been dropped.
      
      Change-Id: I30071b53f300ef340d6c882ed40f0f67fb86c440
      Fixes: #39892
      Related: #39174
      Releases: 6.0, 4.7
      Reviewed-on: http://review.typo3.org/13864
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      d0d2970b
  7. Aug 15, 2012
    • Kevin Ulrich Moschallski's avatar
      [BUGFIX] Web Request should map $_FILES into arguments · 170a279c
      Kevin Ulrich Moschallski authored
      Adds content of $_FILES to the request parameters.
      Use FLOW3 untangleFilesArray method to set the array, as suggested
      by Bastian Waidelich.
      
      Note that file properties must be arrays not strings.
      
      Thanks to Kevin Ulrich Moschallski for the patch.
      Thanks to Tymoteusz Motylewski for the unittest.
      
      Change-Id: Ib851c6412afc0291520e61613ad439e34e0603bd
      Fixes: #34528
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/9379
      Reviewed-by: Tymoteusz Motylewski
      Tested-by: Tymoteusz Motylewski
      Reviewed-by: Nicole Cordes
      Tested-by: Nicole Cordes
      Reviewed-by: Ingo Pfennigstorf
      Tested-by: Ingo Pfennigstorf
      Reviewed-by: Markus Günther
      Tested-by: Markus Günther
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      170a279c
  8. Aug 14, 2012
    • Markus Günther's avatar
      [FEATURE] Backend usergroup model and repository · 899c5d7c
      Markus Günther authored
      This patch delivers an backend usergroup model and repository.
      
      Change-Id: Ie0da23ee0160a928f74726ceec5b243348a331ef
      Resolves: #39332
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/13626
      Reviewed-by: Mattias Nilsson
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      899c5d7c
    • Markus Günther's avatar
      [FEATURE] File mount model and repository · 6dccb74a
      Markus Günther authored
      Actually we have a backend user model in extbase and a backend usergroup
      is in progress. For these models we need a seperate file mount model.
      
      This patch includes the model and the repository with the typoscript
      mapping on the datebase table.
      
      Change-Id: Id0b4a1ad168ba189940282222bf4e08b6441a3bf
      Resolves: #39323
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/13429
      Reviewed-by: Ingo Pfennigstorf
      Tested-by: Ingo Pfennigstorf
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      6dccb74a
    • Jochen Rau's avatar
      [FEATURE] Handle enable fields and deleted records settings granulary · c4b37ce9
      Jochen Rau authored
      At the moment it's only possible to select either only visible
      (non-hidden, matching start-/stop-time) or all (even deleted)
      records.
      
      To ensure a consistent handling in sync with TYPO3 Core behavior, it's
      necessary to select disabled but not deleted records in the
      backend.
      
      This also effects findByUid() via the Typo3QuerySettings and
      allows to write to disabled records in BE context.
      
      * deprecates respectEnableFields in QuerySettingsInterface
      * introduces ignoreEnableFields in QuerySettingsInterface
      * introduces enableFieldsToBeIgnored in QuerySettingsInterface
      * introduces includeDeleted in QuerySettingsInterface
      * introduces feature flag ignoreAllEnableFieldsInBe to control default behavior
      * select disabled but not deleted records in BE context
      
      Fixes: #29501
      Fixes: #8483
      Change-Id: I11beb3b83589ad91d72d05116488408fff8d9e75
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/8773
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      c4b37ce9
    • Nicole Cordes's avatar
      [FEATURE] Improved translation handling for statement generation · 432d72b1
      Nicole Cordes authored
      When selecting items in a language other than default one, the
      relations (e.g. for IRRE) can not be resolved correctly. This
      fix adds the current language if handling is enabled for the chosen
      table. Besides it corrects the ordering of items as it selects all
      possible ones. For correct overlay the origin is fetched before.
      
      Change-Id: Ibcfe83314c0f2fff54348d9ffab97cd7546779ca
      Resolves: #32072
      Resolves: #32216
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/10188
      Reviewed-by: Jochen Rau
      Tested-by: Jochen Rau
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      432d72b1
  9. Aug 13, 2012
    • Markus Günther's avatar
      [BUGFIX] email validator · 50160b41
      Markus Günther authored
      The actuall email validator uses a regex to validate email addresses.
      The TYPO3 core offers a method in t3lib_div to validate email addresses.
      This patch replace the regex with t3lib_div::validEmail()
      
      Change-Id: I8157a61b8f056d0a60510ec3a7ba9dcb182cb0e5
      Releases: 6.0, 4.7
      Resolves: #6970
      FLOW3 issue: #39714
      Reviewed-on: http://review.typo3.org/13550
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      Reviewed-by: Ingo Pfennigstorf
      Tested-by: Ingo Pfennigstorf
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      50160b41
  10. Aug 09, 2012
    • Thomas Maroschik's avatar
      [BUGFIX] DataMapper returns array on RELATION_HAS_ONE · 4f2eac09
      Thomas Maroschik authored
      When your dealing with entities, that not necessarily have
      their hasOne nested entities set then the DataMapper returns
      an empty array instead of null. In my opinion, an empty
      array makes no sense here, because there is no hasMany
      relation here.
      
      * Removed the unused $columnMap from DataMapper::fetchRelated
      * Added $columnMap in DataMapper::fetchRelatedEager
      * Check if the property has a RELATION_HAS_ONE and return null
        instead of an empty array then
      
      Change-Id: I0c766d9579cbb464bbae292b194f8df7e8c4a9e9
      Fixes: #25708
      Releases: 6.0, 4.7
      Reviewed-on: http://review.typo3.org/1404
      Reviewed-by: Tymoteusz Motylewski
      Tested-by: Tymoteusz Motylewski
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      Reviewed-by: Markus Günther
      Tested-by: Markus Günther
      4f2eac09
  11. Aug 05, 2012
  12. Aug 02, 2012
    • Fabien Udriot's avatar
      [TASK] Add Domain Model and Repository to Category · 6c527e10
      Fabien Udriot authored
      For extension developer's sake, it is convenient to provide a domain
      model along with a repository. Both are relying on Extbase.
      
      Change-Id: I7260a57dcc742f217f0ddfe19470673bc91532c9
      Resolves: #38719
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12793
      Reviewed-by: Oliver Klee
      Tested-by: Oliver Klee
      Reviewed-by: Fabien Udriot
      Tested-by: Fabien Udriot
      Reviewed-by: Sebastian Michaelsen
      Reviewed-by: Jochen Rau
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      Reviewed-by: Mattias Nilsson
      Tested-by: Mattias Nilsson
      Reviewed-by: Markus Günther
      Tested-by: Markus Günther
      Reviewed-by: Ingo Pfennigstorf
      Tested-by: Ingo Pfennigstorf
      6c527e10
    • Markus Günther's avatar
      [BUG] Fix lastlogin property to correct lowerCamelCase · b085fa68
      Markus Günther authored
      In the new backend user model the property lastlogin was not consistently
      in the spelling. Sometimes is it used as lastloginDateAndTime and in the methods
      it is used in correct lowerCamelCase lastLoginDateAndTime.
      
      This patch defines the property as lastLoginDateAndTime.
      
      Change-Id: I00e5fd98bcd82e333a6fc9a91f3fe497f2a09d12
      Fixes: #39460
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/13422
      Reviewed-by: Georg Ringer
      Reviewed-by: Wouter Wolters
      Reviewed-by: Mattias Nilsson
      Tested-by: Mattias Nilsson
      Reviewed-by: Ingo Pfennigstorf
      Tested-by: Ingo Pfennigstorf
      b085fa68
  13. Aug 01, 2012
    • Markus Günther's avatar
      [FEATURE] Add a BackendUser model · 8f03f5c6
      Markus Günther authored
      Some extensions in the TYPO3 backend use backend users. The belog and
      the beuser module are based on extbase and it will be useful if not
      every extension has to implement an own backendUser model.
      
      This patch adds a backend user model to extbase.
      
      Change-Id: I84e8ea528c5f91151369f59db6a00acb0174544b
      Resolves: #39145
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12981
      Reviewed-by: Nicole Cordes
      Tested-by: Nicole Cordes
      Reviewed-by: Oliver Klee
      Tested-by: Oliver Klee
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      8f03f5c6
  14. Jul 30, 2012
  15. Jul 21, 2012
    • Felix Oertel's avatar
      [BUGFIX] Remove additional slashes from typolink urls if prefixing · 5dfd3d34
      Felix Oertel authored
      Typolink generates absolute uris with a leading slash. When prefixing
      this with the base uri, we have to make sure, there is just one
      slash in result. To prevent these situations we also trigger the
      UriBuilder itself to generate an absolute path.
      
      Thanks to Chetan Thapliyal.
      
      Change-Id: Iae8755514fbdfc4eb27a5a6eab620e55144d912e
      Fixes: #33788
      Releases: 6.0, 4.7
      Reviewed-on: http://review.typo3.org/8860
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      Reviewed-by: Daniel Lorenz
      Tested-by: Daniel Lorenz
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      5dfd3d34
    • Markus Günther's avatar
      [BUGFIX] public function configureModule should be static · a679a0e5
      Markus Günther authored
      In the class Tx_Extbase_Utility_Extension is the public method configureModule
      and it seems that the author of the method forget the static keyword.
      The method is used as a static method everywhere but it is not declared
      as static.
      
      This patch only set the method to static.
      
      Change-Id: I4ba19f3b0ff763dffd4109a65933623b79e85b45
      Fixes: #37922
      Releases: 6.0, 4.7
      Reviewed-on: http://review.typo3.org/12938
      Reviewed-by: Tymoteusz Motylewski
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      a679a0e5
    • Daniel Pötzinger's avatar
      [FEATURE][Performance] Add caches for persistence layer · 74ed6a82
      Daniel Pötzinger authored
      XDEBUG Profiler shows time saving possibilities in
      Tx_Extbase_Persistence_Storage_Typo3DbBackend->addEnableFieldsStatement
      (use of db->admin_get_fields) and
      Tx_Extbase_Persistence_Mapper_DataMapFactory->buildDataMap
      
      Caches should be added here. Also to be able to inject the cacheManager
      the Container needs a small fix
      
      Change-Id: I5c2defcfaa58c6454226d1abf938b6b6796b5232
      Resolves: #36074
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/10498
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      Reviewed-by: Felix Oertel
      Tested-by: Felix Oertel
      74ed6a82
    • Markus Günther's avatar
      [TASK] use the objectManager to create empty domain objects · 38ba2df3
      Markus Günther authored
      The Tx_Extbase_Persistence_Mapper_DataMapper uses the objectContainer
      (Tx_Extbase_Object_Container_Container) for creating an empty object
      without calling the construct.
      
      The problem is that except the objectManager no one should use the
      objectContainer. So this patch adds a wrapper class to the object
      manager communicates with the objectContainer.
      
      Change-Id: I2a2f9d68c0ac0c14a47723ea901c974b7ccc6c5e
      Resolves: #13816
      Release: 6.0
      Reviewed-on: http://review.typo3.org/12973
      Reviewed-by: Felix Oertel
      Tested-by: Felix Oertel
      38ba2df3
    • Daniel Pötzinger's avatar
      [BUGFIX] Container calls Cache too often · 9176deaf
      Daniel Pötzinger authored
      The Container Classes Cache call is very expensive - and when
      using a database backend, this is even slowing down
      compared to a NullBackend.
      
      One reason is that for every cache request the cache is
      called 3 times: 1 time has and 2 times get.
      This can be avoided and be reduced to one get call -
      which reduces request time by 10-20% for a bigger Extbase request.
      
      Change-Id: I43a0ebf7e0bfd067f3e48c0e7c27f12660b4cb7c
      Resolves: #36008
      Releases: 1.3, 1.4, 4.7, 6.0
      Reviewed-on: http://review.typo3.org/10438
      Reviewed-by: Daniel Lorenz
      Tested-by: Daniel Lorenz
      Reviewed-by: Schmidt Timo
      Tested-by: Schmidt Timo
      Reviewed-by: Tymoteusz Motylewski
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      9176deaf
    • Ingo Pfennigstorf's avatar
      [TASK] Update Readme to point to the current documentation location · b10fb825
      Ingo Pfennigstorf authored
      The Extbase README file now contains links to the current documentation
      and api documentation
      
      Change-Id: I9f2d32f2d060cebc5a7865170f62d269ab8517e6
      Fixes: #36020
      Releases: 6.0, 4.7, 1.4
      Reviewed-on: http://review.typo3.org/12943
      Reviewed-by: Oliver Klee
      Reviewed-by: Tymoteusz Motylewski
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      b10fb825
    • Tobias Liebig's avatar
      [BUGFIX] Only set request for Web_Response · 529143ca
      Tobias Liebig authored
      The current request is needed in Tx_Extbase_MVC_Web_Response to
      distinguish between a cached or a non-cached request in
      addAdditionalHeaderData() as the PageRenderer does not support USER_INTs
      currently. This works fine is the ActionController is called with a
      Web_Response, but causes an fatal error if a Cli_Response is in charge.
      
      This fix and the $request member in Web_Response should be removed,
      once the PageRenderer is fixed for USER_INTs. For now, this patch fixes
      a fatal error in the fluid unit tests.
      
      Change-Id: I56fabc3a51ce2c5192ab4488c817b938ed8797ca
      Fixes: #36751
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12401
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      Reviewed-by: Daniel Lorenz
      Tested-by: Daniel Lorenz
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      529143ca
    • Ingo Pfennigstorf's avatar
      [TASK] Harmonize coding style of if constructs · e0652a73
      Ingo Pfennigstorf authored
      This corrects the whitespaces in if statements for Extbase.
      
      Change-Id: Ie2266202ca819b78d23d7e28cb6c359cf691eee0
      Fixes: #37805
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12957
      Reviewed-by: Felix Oertel
      Tested-by: Felix Oertel
      e0652a73
  16. Jul 20, 2012
  17. Jul 03, 2012
    • Oliver Hader's avatar
      [BUGFIX] FLUIDTEMPLATE - Serialization of 'Closure' is not allowed · 7e63fe16
      Oliver Hader authored
      The Fluid TemplateCompiler uses closures to store a cached
      variant of the accordant Fluid node. Several calls in Fluid
      use serialize() and also will process those closures, which
      will end up in a PHP fatal error.
      
      The most obvious part is the object manager which will then
      try to serialize all objects - including closures - that are
      available in the object container.
      
      The problem can be circumvented by using accordant magic PHP
      methods like __sleep() and __wakeup() to ignore those properties.
      
      Change-Id: I70e78a09b2a118cc26f099063743c530f0addc72
      Fixes: #32295
      Related: #36820
      Releases: 6.0, 4.7, 4.6
      7e63fe16
  18. Jul 01, 2012
    • Christian Kuhn's avatar
      [BUGFIX] Extbase core bootstrap not found in frontend · 8771caa1
      Christian Kuhn authored
      The patch for issue #35866 removed all class entries from ext_autoload
      and relies on the 'extbase' naming scheme autoloader to find classes.
      This has the side effect that classes must be requested in upper camel
      case, otherwise they are not found.
      
      The frontend extbase plugins are called by a TypoScript userFunc.
      The requested extbase core bootstrap class must therefore be used
      with upper camel case as well.
      
      Change-Id: I67f1a0d3025b945ec8788f031b676fa62439a2c3
      Resolves: #38527
      Related: #35866
      Related: #37920
      Releases: 6.0
      8771caa1