- May 24, 2015
-
-
Markus Klein authored
Calling the addTypoScript() method with last parameter set to 'defaultContentRendering' must not add the TypoScript twice. Resolves: #67116 Releases: master, 6.2 Change-Id: I3161c62ac0ab25369fabc3f8163e5d92356aa0ca Reviewed-on: http://review.typo3.org/39680 Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
Helmut Hummel <helmut.hummel@typo3.org> Tested-by:
Stephan Großberndt <stephan@grossberndt.de> Tested-by:
-
- May 22, 2015
-
-
Christian Kuhn authored
* Extract the AccessibleProxy to an own file to get rid of an evil eval() and make the class smarter for IDE's * Greenify as much as possible for PhpStorm Change-Id: I851e5e9832633bf2308e50d9d8bce13f6657119d Resolves: #67113 Releases: master Reviewed-on: http://review.typo3.org/39665 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Christian Kuhn authored
Using typo3conf/extTables.php for TCA overrides is bad practice. Nowadays, stuff like that should reside in an extension that uses Configuration/TCA/Overrides. The patch deprecates the according parameters and logs if an instance still has an typo3conf/extTables.php file. The functionality within lowlevel "Configuration" backend module to write overrides to this file is removed. Change-Id: I648b985de4636c6af2cfb50bf8e106c472cb0fee Releases: master Resolves: #65344 Reviewed-on: http://review.typo3.org/37235 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Christian Kuhn authored
Use Configuration/TCA instead of TCA registration in ext_tables.php Resolves: #67110 Releases: master Change-Id: I86545f3adcc58c54d74c2ae15cb7a5e1fda043ce Reviewed-on: http://review.typo3.org/39663 Reviewed-by:
Frank Nägler <typo3@naegler.net> Tested-by:
-
Sebastian Michaelsen authored
The field name is read from the wrong array key, resulting in a broken flexform. Resolves: #67105 Releases: master Change-Id: I64c7d1f2dfc6bf2338eaa1f1e4195dd5f139dbc8 Reviewed-on: http://review.typo3.org/39658 Reviewed-by:
-
- May 21, 2015
-
-
Benjamin Mack authored
Fix a bug in the recent Package Management refactoring resulting in Package instances only allowed if they contain an ext_emconf.php file. This basically disallows any third-party code installed inside Packages/ due to checking if an ext_emconf.php is present before checking for a composer file. Resolves: #67060 Releases: master Change-Id: I1bec43faafc0c073da52c3bbb1945f47f6864930 Reviewed-on: http://review.typo3.org/39632 Reviewed-by:
-
Markus Klösges authored
Thumbnails should not upscale images, therefore we check for the original size against thumbnail size. If original size is 0 (as for pdf-Files) this leads to not generating thumbnails for those files. Now checking original width/height against 0 to prevent this and generate thumbs for those files again. Resolves: #66679 Related: #66270 Releases: master, 6.2 Change-Id: I5823142a6be19e6068fea358027dc808f5fd3185 Reviewed-on: http://review.typo3.org/39077 Tested-by:
Markus Klösges <mkloesges@gmx.de> Reviewed-by:
Frans Saris <franssaris@gmail.com> Tested-by:
-
Nicole Cordes authored
If you register a module in main module "file" an error is thrown because the ModuleRunner checks page access for the variable "id". In any file module the id is a FAL identifier which can't be converted to an integer value and the check fails. This patch adds a limitation to the ModuleRunner to check page access only if the id can be interpreted as integer value. Releases: master, 6.2 Resolves: #67079 Change-Id: Iba44499b9b13172818aee48aefb01d102f810285 Reviewed-on: http://review.typo3.org/39648 Reviewed-by:
Markus Sommer <markussom@posteo.de> Tested-by:
-
Patrick Broens authored
The content object FLUIDTEMPLATE is extended with `dataProcessing`. With this setting you can add full namespace class references, which can manipulate the $data variable of the current rendered content object, like tt_content or page, before assigning this variable to the view. Change-Id: I757db37d86e1cf907de0116c3c63effc5270a3c1 Resolves: #66907 Releases: master Reviewed-on: http://review.typo3.org/39519 Reviewed-by:
Benjamin Mack <benni@typo3.org> Tested-by:
-
Benjamin Mack authored
Due to strict warnings it is not possible to use media content elements anymore and add a simple youtube video, as a fatal is thrown here. The change modifies the array check to be stricter. Resolves: #67074 Releases: master Change-Id: Ib2dfe78b39e00863b3995b7412333b0260064873 Reviewed-on: http://review.typo3.org/39645 Reviewed-by:
Sebastian Michaelsen <michaelsen@t3seo.de> Tested-by:
Cedric Ziel <cedric@cedric-ziel.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Kuhn authored
The change does not play well with a symlinked core and is reverted for now. This reverts commit e6474fe5. Change-Id: I74ddc970a20d34a4d105a91cbdd5f12486c9568b Releases: master Reverts: #67076 Reviewed-on: http://review.typo3.org/39649 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
Christian Kuhn authored
With the grunt integration a Build/ directory on repository root level was introduced. Out test infrastructure currently relies on a second Build/ folder located in typo3/sysext/core/. The patch moves all files from the core Build directory to the new global one and adapts paths. As benefit, paths are shorter and easier to find and remember now. This patch is breaking for test environments and extensions that rely on the recommended core test infrastructure for unit and functional tests. A typical test run now should look like: bin/phpunit -c Build/UnitTests.xml Change-Id: I9d87a566835f5849ce1e0e22d922d24c4b46ff31 Releases: master Resolves: #67076 Reviewed-on: http://review.typo3.org/39647 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Benjamin Mack authored
There is some leftover, never-called code in a regular TYPO3 instance regarding the old uc->classicPageEditMode option and its companion functionality in EditDocumentController->editRegularContentFromId which has been marked for deprecation. Resolves: #66905 Releases: master Change-Id: I0a428e411b9d7a0a646c7356d773a369c9397dde Reviewed-on: http://review.typo3.org/39474 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- May 20, 2015
-
-
Wouter Wolters authored
Resolves: #67065 Releases: master Change-Id: Iff8ece078dc612c362b3e291da466b29250c8cb1 Reviewed-on: http://review.typo3.org/39634 Reviewed-by:
-
Christian Weiske authored
We have to use the name and cannot rely on the identifier, since they can be random UUID values. This also fixes a wrong folder name in the paste confirm message. Change-Id: I092efdc5b666c9010717136bc063b155479eadab Resolves: #64759 Releases: master, 6.2 Reviewed-on: http://review.typo3.org/38763 Reviewed-by:
Christian Weiske <typo3@cweiske.de> Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Tested-by:
-
Andreas Allacher authored
The current behaviour for maxLevels with treeConfig is incorrect. Currently if one uses maxLevels 0, instead of only seeing the root category, one actually is presented of nodes up to level 2 (if one would specify the levels in nonSelectableLevels). With maxLevels 1 it is already up to level 3. Of course, maxLevels 0 should only display the root level, maxLevels 1 only the first child nodes. Also increased default levelMaximum to 4, in order to ensure old non configured trees are still behaving as intended. Change-Id: Ic1565e39abad01599dd67bbb05b0ce9fa7161af4 Resolves: #65304 Releases: master Reviewed-on: http://review.typo3.org/37196 Reviewed-by:
-
Benjamin Mack authored
Increase the maxitems value to 50 to allow more values for bigger sites. Releases: master Resolves: #59523 Change-Id: Ie25974844bf7ce9f0b7995169964748872eb3f1a Reviewed-on: http://review.typo3.org/39532 Reviewed-by:
-
Tymoteusz Motylewski authored
* Add getter for databaseConnection in SearchController * Add use statements Releases: master Resolves: #66998 Change-Id: I8c4e98cbf3ed0c1fb8b9d8876d6094028c2e5a49 Reviewed-on: http://review.typo3.org/39587 Reviewed-by:
-
Andreas Fernandez authored
Crop additional task information based on `titleLen`. Resolves: #67002 Releases: master Change-Id: I16b2f7106b8485989e1df2ab4958d61308a8e3c7 Reviewed-on: http://review.typo3.org/39594 Reviewed-by:
-
Markus Klein authored
* Remove (super)challenged login security levels * Make loginSecurityLevel 'normal' the new default * Change Backend login JS to use real submit event * Refine hook usage of LoginController * Remove unused code in ext:sv Note: OpenId login is broken due to hidden, but required, password field. This will be resolved with the new Backend login API. #66669 Resolves: #66997 Releases: master Change-Id: I280783588aabc78bc9bd9d1c7ee12e67bac9ed63 Reviewed-on: http://review.typo3.org/39576 Reviewed-by:
-
Morton Jonuschat authored
This is a regression fix for #54091. It has been forgotten to cast the lastQuery to a string before checking if it's empty Resolves: #67040 Related: #54091 Releases: master Change-Id: I6991cad799e686066f8205749baee4aed20a9127 Reviewed-on: http://review.typo3.org/39625 Reviewed-by:
-
- May 19, 2015
-
-
Andreas Fernandez authored
Remove the `remove()` call when the cropper modal gets closed. Resolves: #67030 Related: #66969 Releases: master Change-Id: Ibec6f8ee803ce4b4d6528367f25608cf0b38e21f Reviewed-on: http://review.typo3.org/39617 Reviewed-by:
-
Benjamin Mack authored
The PackageManager was originally backported from Flow but includes too many classes and options that the Core does not use or cannot use at all. The Package code is thus merged with only the parts needed for the TYPO3 Core, and adapted accordingly. All Flow classes are either removed or merged into the needed Package classes of the TYPO3 Core. In order to speed up the bootstrap and prepare for tight composer integration, this task needs to be sorted out first. Next step is to further cleanup code within the Package* classes themselves - things that are not called at all in the TYPO3 Core. Resolves: #67027 Releases: master Change-Id: Ia6823374afa515902e3d5237cef596a440747e3b Reviewed-on: http://review.typo3.org/39518 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>...>
-
Wouter Wolters authored
Resolves: #67029 Releases: master Change-Id: I0f92ea91875455ea0e6726b11cf07f53b468e3a6 Reviewed-on: http://review.typo3.org/39614 Reviewed-by:
-
Georg Ringer authored
A comma needs to be added in an example of f:uri.image Resolves: #66851 Releases: master, 6.2 Change-Id: Ib0a8f3d97a3f51b075b1e0e6a2208ae4c659ed6d Reviewed-on: http://review.typo3.org/39618 Reviewed-by:
-
Christian Kuhn authored
hhvm-nightly is no longer available on travi-ci and removed from the build for now. Releases: master Change-Id: I92751c17e6e2a2f55fd956ff0a9fe069edb180aa Reviewed-on: http://review.typo3.org/39615 Reviewed-by:
-
Nicole Cordes authored
Before starting any record copy process, we have to check if the destination page can handle the record type. Currently if you copy a record with IRRE references, the references are copied first but the original record isn't copied because of missing permissions. The copied IRRE elements stay and pollute the original record as the references are added to it. This patch adds a check if the destination page can handle the mother record type and starts copy process only if allowed. Resolves: #66920 Releases: master, 6.2 Change-Id: I274792b13170f37e3e799ff892ea877ba44d90a8 Reviewed-on: http://review.typo3.org/39605 Reviewed-by:
-
Benjamin Mack authored
The option png_to_gif was previously used to minimize the size of generated images. In the current web development png (with the support of all major browsers) has overtaken gif functionality. The option, which was off by default for some versions, has been removed. All calls to the actual "convert" method in GraphicalFunction have been removed, the function itself has been marked for deprecation. Resolves: #66906 Releases: master Change-Id: I1e134812f55ce8026e468b12ec12ec61e4d9d104 Reviewed-on: http://review.typo3.org/39475 Reviewed-by:
-
- May 18, 2015
-
-
Andreas Fernandez authored
Focus the tab that renders the "Login expiring" notification on click. Resolves: #67022 Releases: master Change-Id: I740d1ddaf07f58124045929f69b8b2642bc24828 Reviewed-on: http://review.typo3.org/39606 Reviewed-by:
-
Benjamin Kott authored
A problem with the autofocus chain and the autofocus attribute, prevented users on IE10+ to enter their login credentials for backend access directly after initial load. Releases: master Resolves: #67024 Change-Id: I21af4156345f610433d3f4f8d02aa1804dae2f2b Reviewed-on: http://review.typo3.org/39604 Reviewed-by:
-
Markus Klein authored
Resolves: #67013 Releases: master, 6.2 Change-Id: Ifaf0a3125ac6b5c0f9e13c2f5c3d4db94aa43ea9 Reviewed-on: http://review.typo3.org/39600 Reviewed-by:
-
Wouter Wolters authored
This patch resolves it for all FormEngine related classes. Resolves: #66635 Releases: master Change-Id: I436e8990aa3c003dd5005937a429168825b56fb5 Reviewed-on: http://review.typo3.org/39037 Reviewed-by:
-
Markus Klein authored
Reset session data timestamp when removing session data in order to assure that new session data are stored via INSERT later again. Resolves: #67007 Releases: master, 6.2 Change-Id: I181017687f9569d4e2a16ca3a970367b05cf7d52 Reviewed-on: http://review.typo3.org/39597 Reviewed-by:
Johann Carstens <johann.carstens@conlabz.de> Tested-by:
-
Christian Kuhn authored
Small follow up to fix some mostly cosmetical issues. Resolves: #67006 Releases: master Change-Id: Ie9ffab0e5bce9e8c97d87a6ff4c213e788cd1bf7 Reviewed-on: http://review.typo3.org/39598 Reviewed-by:
-
Christian Kuhn authored
Creation of container and elements instances in the FormEngine is hard coded and hard to overwrite or adapt. The patch extends the existing NodeFactory with resolver code to find an appropriate class for a given requested type. All FormEngine internal container and element requests are now routed through NodeFactory. This allows to loosen the strict dependency between TCA config "type" to an implementing class by moving the resolving code into the factory. This is done for SelectElement which is now split into multiple smaller classes - one for each display type. The NodeFactory is covered by unit tests since the resolving code will become more complex and fine grained in the future. As a side effect the patch resolves a hack in the FormDataTraverser which no longer calls internal stuff of the select element. The NodeFactory is prepared to be extended with an API for extensions to steer and overwrite default implementations. This will be added with a next patch. Change-Id: I2253a0fe3240366d0d271a3cd82119ce3dc52012 Resolves: #67006 Releases: master Reviewed-on: http://review.typo3.org/39517 Reviewed-by:
-
- May 17, 2015
-
-
Andreas Allacher authored
If one uses TypoScript condition with GP then the check is with GeneralUtility::_GP() which will means that if I have GET variables beginning with an extbase plugin-namespace and POST variables with the same plugin-namespace, e.g. GET: tx_demo_demo[action]=detail POST: tx_demo_demo[name]=Foo then GeneralUtility::_GP('tx_demo_demo'), as intended, will only return the array of the POST variables for that namespace. However, that results in the issue that if I check for the GET variable the check will fail. So for such cases there is a new TypoScript condition GPmerged which uses GeneralUtility::_GPmerged() Change-Id: I772c1c1d178b10e9293132bc41bfc36fabd53063 Resolves: #65250 Releases: master Reviewed-on: http://review.typo3.org/37157 Reviewed-by: -
Benjamin Kott authored
Releases: master Resolves: #66999 Change-Id: I3f2d9ff945021ac0a6f9aac79033ff05c0f55db4 Reviewed-on: http://review.typo3.org/39588 Reviewed-by:
Philipp Gampe <philipp.gampe@typo3.org> Tested-by:
-
Andreas Fernandez authored
The slider object bound to "renderTooltipValue" does not contain the configuration set in the DOM by data attributes. Get the element containing these attributes and us this instead. Resolves: #66991 Releases: master Change-Id: Ib8df38bc84cf9848b55995619d952b300dec0540 Reviewed-on: http://review.typo3.org/39586 Reviewed-by:
Benjamin Kott <info@bk2k.info> Tested-by:
-
- May 16, 2015
-
-
Jo Hasenau authored
Rule of thumb should be to use GeneralUtility::inList() for single checks of lists with unknown values only. Within loops it will be faster to explode the list outside the loop, then flip the array and finally use isset on the array keys within the loop. Hardcoded lists might be replaced with arrays as well. See the issue on forge for a description and some benchmarks. This will not fully resolve the issue since there will be more patches to come, since we should avoid monster patches to minimize the risk of regressions. Releases: master Resolves: #55626 Change-Id: I5a0d8ea6f71a4f8fd39587c5ec3bfcb557d4c777 Reviewed-on: http://review.typo3.org/37138 Reviewed-by:
-
Wouter Wolters authored
Resolves: #66991 Releases: master Change-Id: Ib78eab523fb6ecdba415bf4b07e15690794c2da1 Reviewed-on: http://review.typo3.org/38516 Reviewed-by:
-
