When storing a cache in page the array variable "cache_data" gets
serialized and when being retrieved from cache unserialized.

This is not necessary as de-/serialization is already performed by
the variable caching backend.

Change-Id: I9cf817123947af3f4076dabdce3c569bf41b477c
Resolves: #55493
Releases: 6.2
Reviewed-on: https://review.typo3.org/27179
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

Methods in this class are called a lot and are in need of some cleanup.
* return early
* reduce method and function calls
* update doc comments
* added tests with data provider for Method getCN

Change-Id: I5dcab647fc3da078b5f29beb57fecbf7c98bcaa5
Resolves: #55122
Releases: 6.2
Reviewed-on: https://review.typo3.org/27019
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

If there is no valid configuration or there are no sys_note on
the page at all, the Bootstrap doesn't trigger the extbase
rendering. The patch reduces the load time of the page-, info-
and list-module.

Resolves: #55375
Releases: 6.2
Change-Id: Id099c26c272abf5606ccec169bd8eb7487b51349
Reviewed-on: https://review.typo3.org/27081
Reviewed-by: Helmut Hummel
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Remove a duplicate mocking in test fileIndexStatusIsTrueIfUidIsSet()
and setUp() triggered as side effect after patch 71eb69ed.

Resolves: #53691
Releases: 6.2
Change-Id: I8ac96d9157bf946bba3c9561369f3553d459f275
Reviewed-on: https://review.typo3.org/27223
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Since the backend restructuring for TYPO3 4.2
the alt_shortcut.php file is not used any more.

We can now safely remove it.

Resolves: #55546
Releases: 6.2
Change-Id: I0ee0108c6238a28ad7b2ad0597f421a30eaf118c
Reviewed-on: https://review.typo3.org/27225
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This also fixes “IRRE - drag and drop sorting of items
not possible in Internet Explorer”.

* Added jQuery-ui and jQuery to requirejs.
* Reworked the IRRE-Header HTML and CSS.
* Sortable is done by jQuery-Ui.

Resolves: #51768
Releases: 6.2
Change-Id: Idd121617f2cd5215604747cd0f18285a73dfed49
Reviewed-on: https://review.typo3.org/27164
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

Due to all the refactorings all file-objects are created centralized.
In addition it is not possible anymore to create a file object without
an existing index record. Therefore all the fallback-logic for lazy
loading the index record can be removed from the file object.

In addition the unit tests for these parts of the file object have been
removed, too.

Releases: 6.2
Resolves: #53691
Change-Id: I0a01c12e2caaf8554a5b606b7a85d50b44e0e97c
Reviewed-on: https://review.typo3.org/27193
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

This patch adds some tests for a simple import and export
scenario for pages and a tt_content element.

Resolves: #55100
Releases: 6.2
Change-Id: Ia4b9a8990c7b757d25f18500def6ddd060426c2f
Reviewed-on: https://review.typo3.org/26907
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Locker has wrong LockState in semaphore mode, if the lock
could not be acquired.

Resolves: #52048
Releases: 6.2, 6.1, 6.0
Change-Id: Ifdc2f5d9b2a3c35a0ebef54817a56344f27ab15d
Reviewed-on: https://review.typo3.org/23854
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

If a import file has extension dependencies the user was
redirected to the old em with CMD requestInstallExtensions.
Since the new extensionmanager hasn't this functionality,
remove this magic and show the message only.

Resolves: #43709
Releases: 6.2, 6.1, 6.0
Change-Id: I161d4a24135f0d011177f2d4006e4713c71a8fcb
Reviewed-on: https://review.typo3.org/27100
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The file input fields in the ElementBrowser have the attribute
multiple so you can select multiple files. But as the name
is no array it only uploads 1 file.

This patch changes the name attribute of the file input fields
to an array and shows the flashmessages when an error occurred
during upload.

Resolves: #55497
Releases: 6.2
Change-Id: I1315e35e2ef4cfa8175f962c42f32a5a33ffc16e
Reviewed-on: https://review.typo3.org/27182
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

If you run the test from the BE module of PHPUnit together with
all/other tests it fails. This is due to the fact that the
tests checks more than it actually should.

In particular the static $enumConstants array may already contain
information from other classes, therefore the test only has to
check for existane of information for the tested class.

The patch also corrects the missing \ in the namespace part
between Type and Fixture.

Releases: 6.2
Resolves: #55270
Change-Id: I1ea6546af8013f6c9075525c5bc6f3df579ccfcc
Reviewed-on: https://review.typo3.org/27020
Reviewed-by: Stefano Kowalke
Tested-by: Stefano Kowalke
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Removed unused line that creates a fatal error.
Implemented eval in case NullBackend is set for “cache_core”
and no alias mapping is included.

Resolves: #55517
Releases: 6.2
Change-Id: Ie1d58985496c4561d8b20fedbd030ad98760becd
Reviewed-on: https://review.typo3.org/27218
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

PHP's reflection behaves differently in an edge case used in
extbase constructor injection.
The patch removes the specific check from tests and adds
documentation of this case.

Change-Id: I8ff5ce0d87a28f93ae6be0fd5778289cc9cab7aa
Resolves: #55538
Related: #52349
Releases: 6.2
Reviewed-on: https://review.typo3.org/27219
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

added unit tests.

This change adds the mocking to the new tests.

Resolves: #54131
Releases: 6.1, 6.2
Change-Id: I09abbcea6a2c6310b7a04774808aa92ab8ad1c86
Reviewed-on: https://review.typo3.org/27216
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Because of some missing mocking there are
several DB error messages when running the FileTest

This adds the missing mocking of the MetaDataRepository.

Releases: 6.2
Resolves: #51528
Change-Id: I02ccb45d315b3eee045efda96c947fb67fd71d20
Reviewed-on: https://review.typo3.org/27215
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

We now can drag & drop files in the file list to upload.
But it looks ugly and has some issues.

This change adds a progress overview as provided by the
UX team and improves the usability.
The progress is shown for files added by drag & drop but
also when you use the file picker.

We switched to the jQuery ajax function as this has
a generic event and response handler.

Resolves: #51361, #53829
Release: 6.2
Change-Id: Ifd7b189f84594149b9590bbd4058ad68e4439344
Reviewed-on: https://review.typo3.org/27064
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

Task #55319 introduced a padding for selects,
which looks ugly in Internet Explorer and Firefox.

Resolves: #55510
Related: #55319
Releases: 6.2
Change-Id: I324c5feae256e4b8329b69493dd4f8b9215cab13
Reviewed-on: https://review.typo3.org/27190
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Marcel Wieser
Tested-by: Marcel Wieser
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

Cache control headers need to be sent for IE8 and
HTTPS combination. See #16491 for more details.

Resolves: #52589
Releases: 6.2
Change-Id: I746820dbbb8ca40a9db7e474ac9aaa7ee3d2fb33
Reviewed-on: https://review.typo3.org/27217
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

CSS Styled Content delivers its TypoScript
and got a cleanup in 4.6 due to removal
of old plugins.
However, the replacement (in the default
TS from 4.6 to 6.2) has superfluous code
and is not backwards-compatible if the
layout field is used differently or not used
at all (e.g. NULL value instead of 0) for
installations that have been upgraded
since 4.0.

The patch simplifies and unifies
the default TypoScript for
tt_content.shortcut.

Releases: 6.2
Change-Id: I3ed49e265329155af683a993476ffbb13226462c
Reviewed-on: https://review.typo3.org/27211
Reviewed-by: Sebastian Dudda
Tested-by: Sebastian Dudda
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

The key should be named determineSiteRoot instead of determainSiteRoot.

Change-Id: Ia78832920ad73b76d712041e7546c578a6c4d50f
Resolves: #55534
Relates: #55180
Releases: 6.2
Reviewed-on: https://review.typo3.org/27213
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

BackendUtility::getLabelsFromItemsList() does not take
itemsProcFunc into account. This means no value is
returned when there is no matching item found.

With this change the plain db value is returned
when no matching item is found.

Resolves: #54131
Releases: 6.2, 6.1
Change-Id: Ieb04394fa104627b765f6bc05d0d5886f29099c9
Reviewed-on: https://review.typo3.org/25866
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

To detects the siteroot by querying the pages table with the
columns deleted, hidden, is_siteroot. This patch introduces
a combined index on those colums

Resolves: #55180
Releases: 6.2
Change-Id: Icae63670419cf9bc0029e2aa570cdf0108b9d62a
Reviewed-on: https://review.typo3.org/27154
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Marcin Sągol
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

Also remove one unused css style.

Change-Id: I4a8ccf3861d3e49b4fdab7d542fe2024c5f02f93
Resolves: #55482
Releases: 6.2
Reviewed-on: https://review.typo3.org/27171
Reviewed-by: Wouter Wolters
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

resolveBackPath() is run a couple hundred times per script run,
especially in the backend. As this method is only really necessary in a
few special cases (when a path really contains "../"), we can skip it
for all other paths with an early return.

The check is really weak (it will not skip the call for things like
"/some/dir..with..dots..inbetween/"), but this is ok because we just use
it to skip all *really* obvious cases while at best not missing *any*
legitimate use-case, which should be achieved with this commit.

Change-Id: I4e7fbd2076323e682fcf66bc57605f817cd3e03c
Resolves: #55519
Releases: 6.2
Reviewed-on: https://review.typo3.org/27197
Reviewed-by: Jan Helke
Tested-by: Jan Helke
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The new JavaScript encoder using json_encode also encodes the forward
slash to unicode: \u00F2.

This creates problems, since json_encode already 'escapes' the forward
slash with a backslash.

This patch removes the ecoding of the forward slash from quoteJSvalue

Unit tests have been adjusted to match the output of json_encode:
* forward slash is escaped with a backslash

Change-Id: Ibc19f69c0b68f5bbfa67a39750884dcc030f38cb
Resolves: #55499
Releases: 6.2
Reviewed-on: https://review.typo3.org/27183
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Tested-by: Daniel Siepmann
Reviewed-by: Frans Saris
Tested-by: Frans Saris

The task #52497 introduced a regression. The font-size set in body is
overridden in ext-all-notheme.css with font-size: 0px and thus needs to
be reset again in xtheme-t3skin.css.

Resolves: #55263
Related: #52497
Releases: 6.2
Change-Id: Id17d2ac9d6482c8cc54f4f5a92b3b3ef01f39d2b
Reviewed-on: https://review.typo3.org/27166
Reviewed-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

When a storage folder is not accessible for the user a exception
is displayed. Same if the folder is missing.

This patch changes the exception to
\TYPO3\CMS\Core\Resource\Exception.

The user will get a flash message and FAL tries to display the
parent folder of the restricted folder. If the folder is
missing the parent folder is displayed.

Resolves: #51762, #51319
Releases: 6.2
Change-Id: I1fb930f8c13049eeddb27521326f1d0fc8707933
Reviewed-on: https://review.typo3.org/27189
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Several changes in core broke the ajax upload handler response.
There is no error response and it tries to json_encode complete
File objects.

This changes reverts some of the "cleanup" changes fixes the
response and makes sure only the error message from current
request are used.

Resolves: #55371
Releases: 6.2, 6.1
Change-Id: Ia09f5ffd5e002b1ba50d4fafa747340462d15148
Reviewed-on: https://review.typo3.org/27080
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Analysing the SQL logs shows that there are very much queries to the
sys_file_storage even though the information is quite static. Since
there in general there are not much storages - in most cases it only
will be fileadmin/.

This change will get all storage records from database with one call
and cache this in a runtime cache. Afterwards all requests are resolved
by the static member variable of the StorageRepository. If no storage
is present the default storage is created

Resolves: #55186
Releases: 6.2
Change-Id: I066b57215ba39f7cad608cfe5e83a0f3508b2c62
Reviewed-on: https://review.typo3.org/27025
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Sebastian Fischer
Tested-by: Sebastian Fischer
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

To prevent Exceptions in the ElementBrowser resource Exceptions are
catched in two places:

The Exception is catched in the ElementBrowser itsself when the
previously selected folder is not accessible.

Additionally the Exception is cached in the getDefaultUploadFolder()
method in BackendUserAuthentication when the default folder of a
storage is not accessible.

Resolves: #55439
Releases: 6.2
Change-Id: I64848c3a88cc2cc571c0bf692101647b95666972
Reviewed-on: https://review.typo3.org/27145
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Frans Saris
Tested-by: Frans Saris

Currently a backend user can only access files within filemounts
but not the filemount directory itself.

After that fix LocalDriver::isWithin returns true, if the folder
itself is requested.

Resolves: #55416
Releases: 6.2
Change-Id: I455664359ec620c413bfc01787bda8766462fbab
Reviewed-on: https://review.typo3.org/27120
Reviewed-by: Ingo Schmitt
Tested-by: Ingo Schmitt
Reviewed-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

If a BE editor has only access to sys_language uid 2 and 3
but not 1, it is not respected in the file list module,
as the BE user can see all flags.

The attached patch filters all inaccessible translation records.

Resolves: #55012
Releases: 6.2
Change-Id: Ib5f5be40fdd09504dd08f005eb73b2fa926703cd
Reviewed-on: https://review.typo3.org/26831
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

With TYPO3 4.0 and the new CSS styled content
and the new RTE HTMLArea, some fields were still
included in the core, but disabled by default as
soon as CSS Styled Content was installed. If not
specifically activated, the fields were disabled
in the last 10 versions and are never rendered
anymore by default via CSS Styled Content.

The DB fields are:
  * text_align
  * text_face
  * text_size
  * text_color
  * text_properties

As they are not in use at all (since a long time)
the patch removes any info about these fields
without further notice or any upgrade wizard.

If somebody needs the fields, he/she needs
to create an own extension with the fields.

Releases: 6.2
Resolves: #55479
Change-Id: I77655cec0a27903a0a1df017808f9603564ef739
Reviewed-on: https://review.typo3.org/27168
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Reviewed-by: Marcin Sągol
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Make HR a single line instead of two lines.

Change-Id: I433d025eb91afc2fd35e794089f330e77d42a966
Resolves: #55486
Releases: 6.2
Reviewed-on: https://review.typo3.org/27175
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Shorten some constructs, make them easier to read
and less error-prone.

Resolves: #46400
Releases: 6.2
Change-Id: I7b0126ccfeaefdfdb89321d7287c6347d8aee050
Reviewed-on: https://review.typo3.org/19007
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

To prevent a sql error the insert query for creating sys_history
records in Datahandler must only be executed, if argument
$logId is a valid uid. This could happen, if logging in
Datahandler is disabled.

Resolves: #55472
Releases: 6.2
Change-Id: Idacced5cb0af24a6c9f34165a8d0598ae9c91998
Reviewed-on: https://review.typo3.org/27162
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

The fix for issue #54226 introduced a bug
with FileReferences as it did not implement the
change of the interface.

Resolves: #54226
Releases: 6.2
Change-Id: I9f67f3f23b96569cdfadba1505e4881103a86ccb
Reviewed-on: https://review.typo3.org/27170
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

TYPO3 checks if a redirect is needed for a domain by issuing a
select on sys_domain. In the where clause the columns redirectTo
and hidden are used. These columns have no index, thus the
select is slow.

This patch adds the combined key to the sql definition.

Resolves: #55181
Releases: 6.2
Change-Id: I7d7463e0d3e6abb53c4b0fccf205e4b1eb867878
Reviewed-on: https://review.typo3.org/27167
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

We don't have the t3lib-directory anymore.

Change-Id: Icef845e0ae1fc25a51cd01fa2452751d14b362c5
Resolves: #55433
Releases: 6.2
Reviewed-on: https://review.typo3.org/27125
Tested-by: Georg Ringer
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack