- Jul 19, 2022
-
-
Anja Leichsenring authored
These raises fix the bulk of PHP 8.2 unit test fails. We need to make webmozart/assert:^1.11.0 explicit to pin it as minimum version for PHP 8.2 composer update --prefer-lowest in nightlies. We don't strictly need the phpunit raise, but pick it as casual dev update along the way. $ composer require --dev phpunit/phpunit:^9.5.21 $ composer require --dev webmozart/assert:^1.11.0 Resolves: #97967 Releases: master, 11.5 Change-Id: I5c79a8577c5eb836566cb5c00bb6b63aa1b7ea1f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75242 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
ToGetATockenOnly authored
Releases: main, 11.5 Resolves: #97965 Change-Id: I6e03354925b4ecb9c3f72554862a01057851f48b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75237 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Sascha Egerer authored
If a page of type external link does not have a "target" defined the fallback should be used. This behavior has been changed in #96470 so the fallback is not used anymore as an empty string is also respected as a valid value but should not. Resolves: #97964 Related: #96470 Releases: main, 11.5 Change-Id: I8270aec774a342151eee47000386546e3d5ac70c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75214 Tested-by:
-
- Jul 16, 2022
-
-
Stefan Bürk authored
With #80398 support to set `tableoptions` to proper charset and collate has been added. This setting has been passed through the `doctrine/dbal` connection params and manually set to the schema config for database compare, if it has been set. The choosen key `tableoptions` however is not a valid key for `doctrine/dbal` connection params. `doctrine/dbal` ships proper PHPStan/Psalm type definitions for the param array now, and mumbles about this key. This patch transform the `tableoptions` to the proper `doctrine/dbal` `defaultTableOptions` in the `ConnectionPool`, only transporting the valid params with the connection. Places which handled the invalid `tableoptions` are changed to use `defaultTableOptions` instead. This prepares the ability to raise `doctrine/dbal` dependencies and phpstan with #97956. Full migration with configuration cleanup may be done in a dedicated patch with proper documentation of that change in v12 only. Resolves: #97961 Related: #80398 Related: #97956 Releases: main, 11.5 Change-Id: I33ddc1ae1bebb77e5d64d17e5fbc19eb0e2dc495 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75213 Tested-by:
-
Oliver Klee authored
PHPStan 1.8.1 removes some warnings. Used commands: > composer req --dev phpstan/phpstan:^1.8.1 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97959 Releases: main, 11.5 Change-Id: Ifaaf37add767f98d16b3e847447a2882c3c77ee8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75209 Tested-by:
-
Christian Kuhn authored
Patch level raise of a monorepo --dev dependency as yet another raise to unblock psr/container:^2. $ composer req --dev bnf/phpstan-psr-container:^1.0.1 Change-Id: I73da5737bfbad6dfb739f5f56732d5d283e3e372 Resolves: #97958 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75207 Tested-by:
-
Oliver Bartsch authored
Replace wrong null fallback for "width" and "height" with empty string and also cast the values before passing to GraphicalFunctions->getImageScale() which expects them to be string. Resolves: #97952 Releases: main, 11.5 Change-Id: I80174038e54ce41dfbde5e5e35339b0a7429be4e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75212 Tested-by:
-
Benni Mack authored
When AbstractContentObject is fetching ->getPageRepository() but TSFE hasn't been fully initialized yet, the Context from TSFE should be used, and not the global one. Resolves: #97951 Releases: main, 11.5 Change-Id: I99880839f5458469e7181467de6a8fb667ef9828 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75147 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Nikita Hovratov authored
Resolves: #97953 Releases: main, 11.5 Change-Id: Ie152dfdb8c08f20a835ac9a1c8cf56f1206c4fa1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75151 Tested-by:
-
Oliver Bartsch authored
Resolves: #97767 Releases: main, 11.5 Change-Id: I1c874770ad1201e22a95d0af67e7caf4b09a8aa3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75150 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- Jul 15, 2022
-
-
Georg Ringer authored
The provided width and height must be cast to a string to avoid notices. Resolves: #97911 Releases: main, 11.5 Change-Id: Ifa7428571026fbd0b0905729ea8ad699ab080bcb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75148 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Stephan Großberndt authored
This change makes sure hyphens are kept as part of a word instead of removing them. Removing them led to "casesensitive" instead of "case-sensitive" being lexed and added to the index, which in turn led to that occurrence not being found when searching for "case-sensitive". Releases: main, 11.5 Resolves: #93401 Resolves: #77644 Change-Id: I72f8d297384cea002e1ca6cb8e3b1973774199f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75146 Tested-by:
-
Andreas Fernandez authored
FontAwesome will be phased out in a short while. As a precursor patch, login providers are prepared to accept a new option `iconIdentifier` which takes any icon from the Icon Registry. To ease the migration for 3rd party extension authors, this patch is aimed to be backported to v11. To make the login view itself a bit more logical, the link to reset a user's password is now moved above the available login providers. Resolves: #97950 Releases: main, 11.5 Change-Id: I96f6026c6726cf9dbc2635484bc7ad527f70b4d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75193 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Christian Kuhn authored
Creating a version overlay of a record that has flexform sections and moving or deleting some of these sections at the same time fails in DataHandler due to a wrong uid lookup for the section command array. The patch fixes this scenario in the DataHandler flexform processing code and leaves an according explanation comment. Note this v11 backport contains the fix only and skips the functional tests that have been added with main. Resolves: #73761 Releases: main, 11.5, 10.4 Change-Id: Ib1c910c59a2ebfe9b7545cabb258f44bac2cd273 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75192 Tested-by:
-
Jochen Roth authored
Resolves: #97931 Releases: main, 11.5 Change-Id: I745bffa0c6873f6b8ff5fb15f32da4cd6538959a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75145 Tested-by:
-
- Jul 14, 2022
-
-
Oliver Klee authored
This helps static code analysis in extensions. Resolves: #97893 Releases: main, 11.5 Change-Id: Ie2eee8244438cc8d4624608ce261f5418540c672 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75144 Tested-by:
-
linawolf authored
The reference "Inside TYPO3" is not available anymore since TYPO3 8.7. The sentences are quite useless anyway. Releases: main, 11.5, 10.4 Resolves: #97913 Change-Id: I2d496726db8b22de667d230a99f7d17341fd309d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75143 Tested-by:
-
Oliver Bartsch authored
In case GU::createVersionNumberedFilename() receives a file with an absolute path, no back path should be resolved since the resolved path will always be invalid, which led to no version number got added to the filename anymore. This is now fixed by checking for the path being absolute. Resolves: #97939 Releases: main, 11.5, 10.4 Change-Id: I5bb0150fa27b8c9c1af2aa99bd8baacd55889245 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75141 Tested-by:
-
Nikita Hovratov authored
Resolves: #97938 Releases: main, 11.5 Change-Id: I711a541a9d38f7cd9ea2b1828a5353a8d1f7e0e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75140 Tested-by:
-
Nicole Cordes authored
If a record with associated inline records gets copied, the DataHandler always handles the record creation as new versions. This raises some warning when the corresponding table doesn't support workspaces. This patch prevents warnings when a corresponding irre-table cannot create any new version of a record. Resolves: #97712 Releases: main, 11.5 Change-Id: Iadcdf693f82d021eca5af1350855803ba433c37b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75139 Tested-by:
-
- Jul 13, 2022
-
-
Stefan Bürk authored
Docblock annotations with more then one space between a wildcard character `*` and the annotation start character `@` was not found. Additionally, annotation identifiers did not regonize hyphens as valid identifier character, thus cutting of e.g. PHPStan annotations. This patch now properly finds annotions with multi-space separations and annotation identifiers containing hyphens. Additionally, two phpstan specific annotations are allowed. > https://phpstan.org/writing-php-code/phpdoc-types#local-type-aliases Summarized contained tasks: > find multi-space separated annotations e.g. `* @<AnnotationIdentifier>` > properly extract full annotation identifier containing hyphens e.g. `* @annoation-identifier-with-hyphen` > add `@phpstan-type` and `@phpstan-import-type` as allowed annotation, but only on class level, and not on class-property or class-method level Resolves: #97917 Resolves: #97918 Resolves: #97919 Releases: main, 11.5, 10.4 Change-Id: Iab69ffd87d407088f1237168e19b67a8dc846c8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75137 Tested-by:
-
Andreas Fernandez authored
The NoopPasswordHash fixture is currently used in MFA provider tests only. To declutter the Tests/ directory, the fixture directory is now moved to core/Tests/Unit/Authentication/Mfa/Provider/. Resolves: #97920 Releases: main, 11.5 Change-Id: I86544bf897a26a2565278e2432831adde7154be8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75136 Tested-by:
-
- Jul 12, 2022
-
-
Andreas Fernandez authored
With the removal of datatables in #86343 the search terms used to filter tables were not stored anymore, leading to unfiltered tables after requesting pages with such again. This is found to be annoying in the extension manager when many extensions with the same prefix need to get managed. The search terms are now stored in the browser session and the local extension list is filtered again when visiting the extension manager. Resolves: #93628 Related: #86343 Releases: main, 11.5 Change-Id: Ib99e1fbf0ad420826164f8fed019c5235f8c43d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75155 Tested-by:
-
Shehfinaz Kadavil authored
The existing condition checks if opcache_invalidate and opcache_reset are disabled, the new condition also checks if the function opcache_invalidate exists. Resolves: #97826 Releases: main, 11.5 Change-Id: Ibb201946b358a592f3c5b264646d100867e5e385 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75135 Tested-by:
-
Daniel authored
Like the surrounding $conf['max'], this array index access should also be secured. Releases: main, 11.5 Resolves: #97908 Change-Id: I36ad5cf3d9eac5655e8721c8913bed43ab26377f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75134 Tested-by:
-
Andreas Fernandez authored
flatpickr always defaults to 12:00 if no other value is given, being quite inconvenient. The options `defaultHour` and `defaultMinute` are now provided to set the current time when opening flatpickr on an empty input field. Resolves: #97798 Releases: main, 11.5 Change-Id: Ic222c2ff0e3bf111c498c16dd27ecdc703909342 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75125 Tested-by:
-
Oliver Hader authored
Change-Id: I4b0d5e16384fdc6313848f6ab18bd98ce83cee91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75121 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
Change-Id: I09299dd3a23c9492b4e8be5b57bdab7ac09bb773 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75120 Tested-by:
-
Nikita Hovratov authored
This patch reverts #91148 and #97897. This change had some side effects in FlexForm value displaying outside the intended diff-view. Resolves: #97904 Related: #91148 Related: #97897 Releases: main, 11.5 Change-Id: I6d5af76dea80b457de5a690e3065ccb700b2a507 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75113 Tested-by:
-
Ralf Zimmermann authored
A new `FormRequestHandler` has been introduced as entry point which takes care of creating and rendering the actual `FormRuntime`. Independent of the current application dispatcher (either the default `FormFrontendController`, any custom Extbase controller or a TypoScript `FLUIDTEMPLATE` cObject) any processing will end up here. To ensure proper caching, it is important to separate the two main actions `render` and `perform`, which unfortunately cannot be resolved easily, especially when using custom Extbase controller actions. The term uncached refers to using cObject `USER_INT` instead of `USER`. More details about the process flow are described in `\TYPO3\CMS\Form\Core\FormRequestHandler`, introduced by this change. Resolves: #93887 Resolves: #92406 Releases: main, 11.5, 10.4 Change-Id: I0b98d39f04b6c70ea370200c53316b381019dd2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75013 Tested-by:
waldhacker <hello@waldhacker.dev> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
timobert <tobert@w-commerce.de> Tested-by:
-
Benni Mack authored
This is a precursor for several language-related Extbase bugfixes, allowing to hand over a custom LanguageAspect into PageRepository->getRecordOverlay() instead of the legacy naming conventions. Resolves: #97903 Releases: main, 11.5 Change-Id: I06f6e889bc0e9f052a79fc8f719b090bface0f77 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75114 Tested-by:
-
Frank Naegler authored
Since TYPO3 version 10.4, the custom page type is not restricted to any range of numbers. This limitation no longer exists, and any number is allowed. The ElementBrowserPageTreeView just now also respect this and allows to link to other any doktype beside: - PageRepository::DOKTYPE_RECYCLER - PageRepository::DOKTYPE_SYSFOLDER Resolves: #97626 Releases: main, 11.5, 10.4 Change-Id: Iffc3f705f74cc7516464fdb00adb456141657948 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75132 Tested-by:
-
Sybille Peters authored
Add the following information to impexp documentation: - export functionality is restricted to admin users and users for which the new User TSconfig option options.impexp.enableExportForNonAdminUser has been set - export functionality poses security risk as explained in patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/74902 - the same restrictions apply to the import functionality (which is not new but has not been documented) Resolves: #97899 Releases: main, 11.5, 10.4 Change-Id: Icb16dc97505a3bbe671357555bb786705121cb67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75070 Tested-by:
-
Oliver Bartsch authored
The rollback link for a single field change is now displayed again in the rollback view of the history module by using the correct variable in the template. Additionally, an unintended change in #91148 is resolved, which would also display the rollback link in the normal history list view. Resolves: #97901 Releases: main, 11.5 Change-Id: I2606d0585a5f1d196adab5f83340ff3033dced1c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75071 Tested-by:
-
- Jul 11, 2022
-
-
Oliver Bartsch authored
A couple of debug information, e.g. the field- and tablenames in FormEngine, are displayed depending on the user status and the debug settings. To simplify the codebase, this condition is now centralized in BackendUserAuthentication. Resolves: #97894 Releases: main, 11.5 Change-Id: I5173c48180fbf96f7408c008eeb3c71c25686d0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75069 Tested-by:
-
Oliver Bartsch authored
Since #91148, EXT:backend and EXT:workspaces depend on the "lolli42/finediff" package, which is a fork of the archived "cogpowered/finediff" package. This dependency is now declared in the corresponding composer manifests. Resolves: #97897 Related: #91148 Releases: main, 11.5 Change-Id: Ia6c53bcee4173a1f7598581c30825ee162126c9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75107 Tested-by:
-
Francois Suter authored
The LogManager tries to access $GLOBALS['TYPO3_CONF_VARS']['LOG'] without considering that it could be undefined Releases: main, 11.5 Resolves: #97888 Change-Id: I7ac2435e548e2d241fe223686595a42927ae1a60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75068 Tested-by:
-
- Jul 10, 2022
-
-
linawolf authored
The outdated links in EXT:install are improved in https://forge.typo3.org/issues/97885 Releases: main, 11.5 Resolves: #97886 Change-Id: I25979df8f9f322461ffc6d03ab9030240c2e0e8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75067 Tested-by:
-
linawolf authored
Releases: main, 11.5, 10.4 Resolves: #97885 Change-Id: Ib274d3d85f1311f100afe8e12167ebc6eaab21db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75065 Tested-by:
-
- Jul 09, 2022
-
-
Andreas Fernandez authored
The confirmation dialog when FormEngine requests an update never came up in FlexForms as the array key used in `TYPO3\CMS\Backend\Form\Behavior\ReloadOnFieldChange->toArray()` didn't match the key in the `typo3-backend-form-reload` handler in FormEngine JavaScript, which is solved in this commit. Resolves: #97804 Related: #91787 Releases: main, 11.5 Change-Id: I1b95e836408a579d1b3e075f7614d7907bf94a37 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75088 Tested-by:
-
