The array check for the configuration has been moved before
the first usage.

Change-Id: Ia1355206b2a2e7bdc1cfa9b15402abb2ef3f36d5
Resolves: #28833
Releases: 4.6
Reviewed-on: http://review.typo3.org/4215
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Beside some type hintings and indent correction there is now a check
in response for timeout with fetching translation, so the UI is not
blocked anymore if a timeout occurs.

Change-Id: I670a2df4fddab0be6b0cb05e69e009c08db5e1fa
Resolves: #28667
Reviewed-on: http://review.typo3.org/4012
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This cleans up some loose ends of the caching framework by default patch series
for 4.6: Some methods in t3lib_cache are not static and there is still a check
for isCachingFrameworkInitialized() in tcemain.

Change-Id: I5725672849db185eaa6683ee9749cc9295d4ef01
Resolves: #29171
Reviewed-on: http://review.typo3.org/4529
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

There are two classes in typo3 directory which belong to the "aboutmodules" module:
alt_intro.php
class.alt_menu_functions.inc

Move them into the extension's directory, cleanup a bit and use the module
dispatcher to call the module.

Change-Id: I2c398d985339bd1b35d15755cfec43b6e2c42eb5
Resolves: #28676
Reviewed-on: http://review.typo3.org/4021
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

There is some duplicate code in tx_saltedpasswords_sv1::authUser().
This patch removes the code, making it more readable.

Change-Id: Ie461059bcc699936774a8e41475a9cbbc98d9606
Resolves: #29157
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/3039
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

t3lib_extMgm::addService() checks that $serviceType (eg. 'auth') does not start
with a valid class prefix. While it is probably not a good idea to prefix a
service type with 'user_' or 'tx_', there is no technical reason to enforce
this. The check especially leads to problems if
TYPO3_CONF_VARS['FE']['userFuncClassPrefix'] is set to an empty string.
This patch removes the check.

Change-Id: I078078eef5147cb267483a0d8d04ab113a24f7e9
Resolves: #29165
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4525
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

These informations are important for a service:

* Extension name of a service implementation (e.g. 'saltedpasswords')
* Service type (eg. 'auth')
* Class implementing the service
  (service key, e.g. 'tx_saltedpasswords_sv1').

t3lib_extMgm::addService() registers a service in global array
$T3_SERVICES[type][key].
Additionally it registers the same service as $T3_SERVICES[key][key].

The latter registration is actually never used by any other service
method in the core and can be removed to simplify this handling.

Change-Id: I2c8c53bb763b0a41e5c2488bbcef96f7e1505c9f
Resolves: #29164
Reviewed-on: http://review.typo3.org/4522
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Resolves: #29142
Releases: 4.6

Change-Id: I5ee0161a49d22c9d29b82bebfce6a16d3f1a439d
Reviewed-on: http://review.typo3.org/4461
Reviewed-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Paths starting with a slash are absolute on Windows, too.

Change-Id: Ie34449b8fc9f5e5a203044457baa64283412cf66
Resolves: #16798
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/3712
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Solution: Avoid wrapping the a tag with span tag when style attribute
is set when rteerror attribute is also set.

Change-Id: I0f517b9f01deec05c9d31661a5fcf13f60ea0d37
Resolves: #25302
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/4351
Reviewed-by: Georg Ringer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

The extension manager tries to establish a connection to the TER
as soon as user credentials for a user are given.

This patch changes that behavior so that it is only done for
the functions that actually need a TER call.

Additionally I did some cleanup.

Change-Id: I4424f71d1b645ffdb46b3319409a48dbe00c7e70
Resolves: #28949
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4453
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Modules that extend t3lib_extobjbase currently do not show any label.
Affected are for example the function wizards like sort pages and sub modules
of the info module like info_pagetsconfig. The patch fixes this by changing
t3lib_extobjbase to look for .xlf files as well.

Change-Id: Id7faa5bb7e125b1857b07c28df561a760752e9ad
Resolves: #29134
Reviewed-on: http://review.typo3.org/4447
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

t3lib_lock can be cleaned up a bit: The constructor currently returns values
which is impossible, one error case is turned into an exception.
The constructor is additionally covered with unit tests.

Change-Id: I86b2d7e2c1329cefd6a00952c9a024fd926d5abf
Resolves: #29132
Reviewed-on: http://review.typo3.org/4444
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Setting $GLOBALS['TYPO3_CONF_VARS']['FE']['userFuncClassPrefix']
to an empty string - to allow all prefixes - does not work as
expected as the check in t3lib_div expects a valid string with
length > 0. Adjust t3lib_div::hasValidClassPrefix to also
allow empty prefix var.

Change-Id: Idbd8cf7a547d9549f1c31dadd731eda48f52fcec
Resolves: #29133
Releases: 4.6
Reviewed-on: http://review.typo3.org/4445
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This fix contains several parts:

1. alt_file_navframe.php
   changed top.TYPO3.Backend.ContentContainer.setUrl()
   to new function
   top.TYPO3.ModuleMenu.App.openInContentFrame()

   This fix solves the problem in the filemodule

2. iframepanel.js
   added small delay to ensure, that the panel is rendered with correct
   size before applying the mask (force centering of loading indicator)

3. modulemenu.js
   make tree detect changed ids

4. modulemenu.js
   refactoring of the following functions:
   - loadModuleComponents
   - openInContentFrame
   this has been done to reduce redundant code

Change-Id: Ibccd5d6880e1e957d5de232fdc8f4ad168cd16ab
Resolves: #28851
Releases: 4.6
Reviewed-on: http://review.typo3.org/4299
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Only change the object property to something different than "superchallenged"
if the configuration is not set to a "standard" security level.

Resolves: #29130
Releases: 4.6, 4.5, 4.4, 4.3

Change-Id: Ibf1194d04a7159ade9ef33701e92930f98cfb90e
Reviewed-on: http://review.typo3.org/4452
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

All other admin-modules already have this under "About modules".

Change-Id: I54cc1ee2d3505f797623b5b9708174ee3e9df50e
Resolves: #21528
Reviewed-on: http://review.typo3.org/2788
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

If a list-records-task lists more than 100 records, the singe table page turning
functionality is shown on top of the table. If you want to switch the page (or
enter a page number) nothing happens or you get elsewhere than you are supposed
to be.

This happens due to wrong link generation. The Listmodule has been refactored, but the
sys_actions Module stayed the same. Link generation was broken.

This patch fixes the issues with sys_actions and list link generation by subclassing
the localRecordList class and adopting the link generation to sys_actions needs.

Change-Id: Ie84ec59ce632dbe4a74df8236eab777b23f3bd53
Resolves: #23567
Reviewed-on: http://review.typo3.org/2992
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Increase the size of the image in show_item (launchView).
This window is displayed when a image in list or file_list is clicked.

Change-Id: I5b347a15c04b082b015d99fb2e80d486667a3398
Resolves: #28963
Releases: 4.6
Reviewed-on: http://review.typo3.org/4307
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Increase the size of thumbnails (page, list, filelist) from 54x54px to 64x64px.

Change-Id: Ia830771e2e630d1fb5e4f624220cb6504ceb98a1
Resolves: #29136
Releases: 4.6
Reviewed-on: http://review.typo3.org/4309
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Use of TYPO3.lang has been deprecated. Use TYPO3.l10n.localize() instead.

Change-Id: I68f968df3f3d105ee566987c000e3dafb97b9fe3
Resolves: #29028
Releases: 4.6
Reviewed-on: http://review.typo3.org/4388
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Issue #27985 removed the function indexes from class files and most
usage counts from method comments. This patch removes some missing matches.

Change-Id: Id53769839517e50b977cc01d7f6008beb74b5896
Resolves: #29135
Reviewed-on: http://review.typo3.org/4449
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

table cache_pages does not exist anymore and must is removed from
the default configuration of the task.

Change-Id: I328c624bc328f99a93fa895ff54a668a16099aa8
Resolves: #29131
Reviewed-on: http://review.typo3.org/4446
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

The only public API method in tx_scheduler_CronCmd_Normalize is normalize().
The patch makes all non API methods protected and uses an accessible proxy
class in unit tests to make the low level methods testable. This cleans
up the API and still gives detailed unit tests.

Change-Id: I6845d049523b68e6f57d86ad03ef0a48c453df81
Resolves: #29100
Reviewed-on: http://review.typo3.org/4421
Reviewed-by: Björn Pedersen
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Clean up some obsolete code from the garbage collection task since the
caching framework was enabled by default. Additionally fixes the
additional fields provider to find registered cache backends.

Change-Id: I242a9ccb904f9e692025336a6e302df673078050
Resolves: #28062
Reviewed-on: http://review.typo3.org/4427
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Replace hardcoded icons with t3lib_iconWorks::skinImage calls

Change-Id: I02236b36facb53222ccc8e0bfc17adf7b2ac7ae4
Resolves: #24920
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/3448
Reviewed-by: Steffen Kamper
Tested-by: Steffen Kamper
Reviewed-by: Stefan Neufeind
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

After #29029 flexforms display is broken because of the added
display:inline-block. Fix it by changing it for flexforms
back to display:block.

Change-Id: I020ad66647c1abc2958a201a61f51eaecdfdafbb
Resolves: #29126
Releases: 4.6
Reviewed-on: http://review.typo3.org/4433
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

If the temp_CACHED* files exist, but they are empty a lot of functions
produce incorrect result due to missing TCA data. Checking the fileSize
prevents the use of empty cache files.

Change-Id: I855034048eca142153badd2567fb2bf6dfbc2629
Resolves: #29075
Branches: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/4420
Reviewed-by: Björn Pedersen
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

When a TCEforms field is part of a palette, a specific span tag
is added around it. A similar span tag must be added around fields
which are not part of a palette, so that we have similar behaviors.

Change-Id: If13c130423c4839b89c7f03e015feffd8ae3bd94
Resolves: #29029
Related: #28030
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4390
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

For the redirect page field in the records for FE users and FE groups
the suggest wizard is missing.

Change-Id: I2d65f2d0215b38ed39df70ee33a0b504849bae2d
Resolves: #21723
Branches: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4411
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Recent browsers follow HTML5 standards for submitting image input
elements. The result is that the name of the image input element is
not submitted anymore, only the name with the x and y coordinates.
Checking for createExtension_x or createExtension being set makes the
button work again.

Change-Id: Id6424c44978be807c51bcdd842d11761d9aa947e
Resolves: #28455
Branches: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4405
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Tables are styled with different layouts. These are unified and follow the
standard style (list, page, …). Style was taken from db_list.
These tables are rebrushed:

* file_list: folder and file list
* Scheduler: tasks table and information table
* TS-analyzer: template overview
* Web > Info / pagetree overview
* Move element / position map

Change-Id: Ia563e49fdfc6a06c706d4004454168ee177fdc36
Resolves: #28188
Releases: 4.6
Reviewed-on: http://review.typo3.org/4318
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The patch adds the current TYPO3 version to the cache identifier.
This ensures a new cache file if upgrading TYPO3.

Change-Id: I4fa47178016925f39ff2168f65afb1ae357be556
Resolves: #28589
Reviewed-on: http://review.typo3.org/3903
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

starttime/endtime can be set different in localisations
but are (usually) not respected. This patch modifies
the behaviour inside localisations to show a readonly
value of the original starttime/endtime-values.

Change-Id: If7e32b0c8a628698115c60ec570c2526e5bb3546
Resolves: #24211
Reviewed-on: http://review.typo3.org/3984
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Björn Pedersen
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

If a thumbnail can not be created (im/gm mis-configuration or
inability to convert image format), a placeholder is rendered.
This placeholder contains text with further details.
This text is not readable, with white text on yellow background.
This patch changes: Black text on White background.

Change-Id: I3fa52b620a758caa0c864105203b314783319692
Resolves: #28962
Releases: 4.6
Reviewed-on: http://review.typo3.org/4308
Reviewed-by: Christopher 
Tested-by: Christopher 
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The recursive call in t3lib_utility_Array::filterByValueRecursive()
has a third, but unused parameter.

Change-Id: I33c61e5a4ff0a1d47452bc59bbf6d392a6cf727e
Resolves: #29098
Reviewed-on: http://review.typo3.org/4416
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This patch moves the needed table definition for a cache from the caching
framework to the install tool and the extension manager. This way the cf
tables are handled just like every other table and show up for example in
compare wizard of install tool and if an extension is installed that
registers own caches (like extbase).

Change-Id: I61e7dd1b1fbe970529810876bc7137986f9ae656
Resolves: #28973
Reviewed-on: http://review.typo3.org/4323
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Changes the two-word backend module names to be uppercased (the
first character of both words). This changes the locallang files in setup,
lowlevel and taskcenter system extensions.

Change-Id: I38842f4945dafbf395e35f9a2c1d6a5a917dd403
Resolves: #22256
Reviewed-on: http://review.typo3.org/4384
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

With issue #27983 some deprecated parts were removed but obviously too much. Although $GLOBALS['TSFE']->additionalJavascript is used throughout the core, after this issue it was never rendered anymore in the frontend.

The javascript function openPic was never added to the frontend because of this.

This patch reinstates the responsible lines which were removed for Enlarge on click

Change-Id: I8e182be8e894e49212a5a4249118b44c0e0bd954
Resolves: #29041
Releases: 4.6
Reviewed-on: http://review.typo3.org/4392
Tested-by: Soren Malling
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Some database indexes in TYPO3 tables are not optimal:
they include the sorting field in the wrong position.
MySQL will not use such index for sorting (sorting
field must always be in the end of index).

Change-Id: I9d900013ac5cabb7bdd7130ff2502674ee2c9b2a
Resolves: #21381
Reviewed-on: http://review.typo3.org/4317
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Mario Rimann
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers