- Oct 01, 2021
-
-
Oliver Bartsch authored
Previously, when a folder was empty or no files were found for a search term, the filelist still displayed the table header. This was related to the Drag&Drop functionality, which internally reads data from the table header. However it's also sufficient to just hide the table header and to show proper messages, including direct actions, e.g. "reset search" or "upload files". Therefore, also the Drag&Drop functionality is improved. The draggable area now covers the whole module, so the user does no longer have to strike a 70 pixels box. Besides, a couple of bugs in the Drag&Drop implementation are fixed: - When uploading files in "active search" mode, the file path is now properly added to the row - After all files were uploaded, the user is now able to reload the module via a notification action - Drag&Drop in FormEngine does no longer add the selector / checkbox field to the row - When dragging files in and out of the dropzone, the dropzone is now hidden again after "dragleave" (only for filelist) - The dropzone is now also hidden on "drop" (uploading the dragged files) - The dropzone is not "activated" when not in the current visible scope (e.g. in another FormEngine tab) - The checkbox is now also activated for uploaded files (without module reload) - The full sized drozone can be closed with the ESC key - JavaScript SyntaxError, triggered by a server error, such as "POST Content-Length" exceeds limit, is now properly handled Resolves: #95403 Resolves: #95421 Releases: master Change-Id: Id9de5065544aa57deaa11b8b4f9158b869a72427 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71375 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Helmut Hummel authored
When TYPO3 is installed via Composer, scheduler UI should show the correct path to the Composer installed binary. Releases: master Resolves: #94749 Change-Id: Id3b20293d3537d7143b3b17643cd245cae754b9c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70019 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Ralf Zimmermann authored
The form framework now provides Bootstrap 5 compatible templates. The markup has been completely reworked, unnecessary nesting layers have been removed and semantically more meaningful HTML tags are used. The templates were also improved in the area of accessibility. In the course of Bootstrap 5 compatibility two new breakpoints "xl" and "xxl" were added to the grid configuration. All hardcoded CSS classes in the templates have been moved to the configuration. This simplifies the integration of the frontend. The change makes it easier for integrators to make upgrades of the frontend framework. In most cases, it is now no longer necessary to override a template for changes to classes. Instead, it is only necessary to add the appropriate CSS classes to the form configuration. In order not to be breaking, by default the templates are still rendered as they used to be. To use the new Bootstrap 5 compatible templates the form rendering option `templateVariant` must be set from `version1` to `version2` in your form setup. Resolves: #86892 Resolves: #94869 Resolves: #94870 Releases: master Change-Id: I4837269beaf48d6407939ccbbf7a9a5fe2eb9521 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70884 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Andreas Steiger <typo3@andreassteiger.de> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Torben Hansen authored
The username and password fields in ext:felogin do not use required and autocomplete attributes. Both are now added in order to provide a default template which covers standard web practices. Resolves: #94679 Releases: master, 10.4 Change-Id: Id29e06525f01ee9b93e3dcf52d50a25face2e457 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70815 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Thomas Löffler <loeffler@spooner-web.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benni Mack authored
This change injects the PSR-7 Request in AbstractUserAuthentication and BackendUserAuthentication. This makes it possible to have the testing framework use PSR-7 Requests for setting up authentication, avoiding usage of $_COOKIE and other globals in the future. Resolves: #95429 Releases: master Change-Id: Ie4918c6f5250123ba994c1cef8d839a6a4cfd84e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68797 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Benjamin Franzke authored
TYPO3_REQUESTTYPE constants have been deprecated since #92947, but PageRenderer->addRequireJsConfiguration() currently needs to be scoped to BE context as the applicationType is derived from the global TYPO3_REQUEST object since #92953. This causes problems as the request object is not available during ext_localconf.php loading, and is therefore always considered to be BE – also in FE, causing RequireJS to be always loaded, if PageRenderer is configued via ext_localconf.php as possible in TYPO3 v10. Therefore currently there is no longer a "supported" way to register RequireJS configuration in ext_localconf.php. This change delays RequireJs configuration loading and merging until configuration is actually used, allowing configuration to be registered anytime and without REQUESTTYPE conditions. Also ApplicationType is evaluated on demand instead of during object construction. In TYPO3 v12 this should better be provided as an event that allows to enhance the configuration, therefore add that as todo to t3editor and rte_ckeditor which use the render-preProcess hook right now, which works for them, but not for extensions that need to register RequireJS configuration for the TYPO3 backend login screen. Releases: master Resolves: #93236 Related: #92848 Related: #92953 Related: #92947 Change-Id: I899edbb50d1c1c34854e8f98f896a5a671798386 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71395 Tested-by:
-
Oliver Bartsch authored
Resolves: #95430 Releases: master Change-Id: Ie55e52fb972c5f6a3bf44b321999c9098242bc68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71401 Tested-by:
-
Benni Mack authored
This change reduces the usages of GeneralUtility::_GP() by using the PSR-7 ServerRequestInterface input. Resolves: #95413 Releases: master Change-Id: I467c30b1dbe781b4469e131beb6a4fb68c5d90f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71383 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Benjamin Franzke authored
Avoid wrapping the request with the extbase request wrapper which enforces the availability of the extbase attribute and thus causes an InvalidArgumentException if the attribute has been removed. Now that the usecase to remove the extbase attribute is fixed via the PSR-7 standard method ->withoutAttribute('extbase'), the misleading method Request::getServerRequest() is removed as it is supposed to return the original request which it actually didn't do. This method implies that the server ("original"?) PSR-7 request will be returned, but that isn't true. Instead a cloned object with the extbase attribute but without the extbase wrapper is returned. That's counter intuitive and therefore the method is pretty useless and removed. The usecase for getServerRequest() is marginal, the Request is a ServerRequestInterface anyway, therefore it can be used and passed everywhere where ServerRequestInterface is required and would therefore only be useful to remove the extbase attribute (which was broken prior to this patch). Releases: master Resolves: #95422 Related: #94428 Change-Id: Ia543a70ecc990b044a37570a91fff427627df941 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71396 Tested-by: -
Benjamin Franzke authored
While a cloned request was returned, the extbase attribute was shared between old and new request, rendering the old and the new (cloned) request 100% equal, with*() methods need to be immutable instead. Releases: master Resolves: #95424 Related: #95095 Change-Id: I15b7946465dd60a912c7d26da72c751db3b48319 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71397 Tested-by:
-
Benni Mack authored
The internal logic to create backend links with a redirect The internal method "UriBuilder->buildUriWithRedirectFromRequest()" is removed, and a new RouteRedirect object is now added which cleans up the Routes and Parameters and does various checks in a central place. The method "UriBuilder->buildUriWithRedirect()" now needs a RedirectRoute object to build the proper URI. The BackendController also checks now properly via the RouteRedirect. Resolves: #95407 Releases: master Change-Id: I76658b446282fe6d72b5281ed19d12f91639a355 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71380 Tested-by:
-
Benjamin Tammling authored
Add tests to check: * if the button to show the closest template is working as expected * a new extension template is created when the appropriate button is used Resolves: #94552 Releases: master Change-Id: I47f549bf5f20a8cd0a1df938957bf5af98de5a3b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70535 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
With #95406, an instance of check was added to the Notification component, to prevent a TypeError in case the action is not defined. That was actually a sign of a bad usage (e.g. passing null), and therefore the action is now made optional instead. Resolves: #95420 Related: #95406 Releases: master Change-Id: I52c519817225f0a874788095a912c808528d031d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71388 Tested-by:
-
Georg Ringer authored
With #93523 parts of the template module have been refactored. Some changes are reverted because those just change the order of functionality without a true benefit and makes it hard for users who use those modules very often: * "Edit the whole template recoord" is moved to the bottom * "Create extension template" and "Go to closest page with template" are moved below instead of a grid Related: #93523 Resolves: #95338 Releases: master Change-Id: I98b1aef1daa1c7c5cf1858f4a537e85a93c9d807 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71221 Tested-by:
-
Torben Hansen authored
When an Extbase action returns a ForwardResponse, the extbase attributes of the originalRequest are overwritten, because the resulting request object is cloned from the current request which holds a reference to extbase attributes. This change ensures, that the extbase attributes remain in their original state in the originalRequest object. Resolves #95095 Releases: master Change-Id: I25d9c3451146ec06e13bc207e52dc76024892fd0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71133 Tested-by:
-
Benni Mack authored
In TYPO3 v11.0 the "getGroupsFE" Authentication chain was removed for FrontendUserAuthentication, so it is not possible for extensions to add groups to anonymous user sessions anymore. A newly introduced Event is now introduced to replace the getGroupsFE authentication subservice. Resolves: #95364 Related: #93108 Releases: master Change-Id: Ib981f4c53041f014932df5575cae79446e6fbf34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71235 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
- Sep 30, 2021
-
-
Benjamin Franzke authored
Similar to #93000 we add the symfony-to-psr-14 EventDispatcher shim to the console application in order to deliver symfony console events through the TYPO3 event dispatcher. Releases: master, 10.4 Resolves: #95218 Related: #93000 Change-Id: I30816b3e391d7181bfba18b8e8e281f8bad4fac6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71088 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Benjamin Franzke authored
Happens in case a PHP warning occurs during ext_localconf or ext_tables loading (early boot). as ConnectionPool usage is deprecated for this case since #94979. The deprecation message would then be printed to the output, as it occured inside the error handler, and is therefore not handled. This destroys json output during installtool upgrades and command line outputs. Therefore the deprecation output must be circumvented by avoiding the database connection. Releases: master Resolves: #95125 Related: #94979 Change-Id: Ice4d89daa5ba3bb1098f40e698e99c3a6575b4ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70868 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Christian Kuhn authored
initializeBackendRouter() has been obsoleted in v10 and only kept for testing-framework to catch up. TF has been updated meanwhile, method is obsolete. Change-Id: I04690cda5c75566b97cccbb18e15048403242229 Resolves: #95415 Related: #90247 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71385 Tested-by:
-
Robert Kärner authored
Multiple undefined array key warnings occurred when following a page redirect in the frontend. This is fixed by adding the necessary checks. Resolves: #95393 Releases: master Change-Id: I169cb92352c56f0f2251e977a0a5240e256f09af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71346 Tested-by:
-
Oliver Bartsch authored
Resolves: #95409 Releases: master Change-Id: Id57cc977c3f70b43a63135708bf8c055e10d9840 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71381 Tested-by:
-
Helmut Hummel authored
With Symfony DI we can simplify our code and remove workarounds previously introduced to prepare singleton objects for later injection. Releases: master Resolves: #95405 Change-Id: Ib1c5af875f6cdfafda1dac5efe70cd7e73b069c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71376 Tested-by:
-
Oliver Bartsch authored
The Notification JavaScript module previously failed to check a given action before executing it. This is now fixed with an "instance of" check. Resolves: #95406 Releases: master Change-Id: I4a620d42f822baa1a54a441281e9291af4649d29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71379 Tested-by:
-
Oliver Eglseder authored
Resolves: #95396 Releases: master, 10.4 Change-Id: Ie53a9d452297278699246d9dcd0df5c64ec63b24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71347 Tested-by:
-
Nikita Hovratov authored
Resolves: #95399 Releases: master Change-Id: I31ad3b9da832c8551a4ce189c216f16886a26504 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71349 Tested-by:
-
Benni Mack authored
This change separates between a missing CSRF token and an invalid request token in the backend redirect functionality, ensuring that the token is given (= redirect) instead of wrong (= redirect to log in page). In addition, the redirect links are now only generated if a route is not limited to POST (this was added in 11.1 later-on). Resolves: #95370 Releases: master Change-Id: I6ccb5dc00752d185b640de1be52b98cd4c5c10b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71317 Tested-by:
-
Nikita Hovratov authored
Resolves: #95397 Releases: master Change-Id: I088ca979ff75ee0c09dea2be3c9c546a24f47975 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71348 Tested-by:
-
Christian Kuhn authored
Most common use case for TCA type "group" fields is the usage of "internal_type=db". Therefore, this option is now the default value. This allows to simplify corresponding parts in FormEngine, Datahandler, etc. Furthermore are all Core TCA files adjusted and do no longer define this option for type "group". Resolves: #95384 Releases: master Change-Id: I3ab8c505e5512a2d574ed52af1b3943f0243011d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71186 Tested-by:
-
Oliver Bartsch authored
Since #92460, the PageLayoutController has to deal with the special "ALL languages" option. Therefore, a couple of checks are performed in menuConfig() to determine whether the special language should be applied to the menu or not. It's therefore necessary to move the actual menu generation after this determination. This patch also removes a duplicated call to the makeLanguageMenu() method. Additionally, the special language is only added to the language menu, in case at least one translation of the current page exists. Previously, the "available" languages were checked. This makes no sense, since they might be available, but not yet used. Resolves: #95387 Related: #92460 Releases: master Change-Id: I271c488086a7e1d439611f81d3e05019091dacbd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71342 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
- Sep 29, 2021
-
-
Georg Ringer authored
The 2nd argument for the method `renderSingleCheckboxElement` must be the number of the element of the given list. Resolves: #95371 Releases: master, 10.4 Change-Id: I53b8d4ae0310f10cd9169e14dc6584dbee1161ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71336 Tested-by:
-
Oliver Bartsch authored
The EXT:linkvalidator module specific stylesheet is removed in favor of using the bootstrap framework. Besides increased consistency this also leads to less custom classes and old fashioned styles. The JavaScript component of the module is refactored to avoid jQuery, while the code is simplified and type hinted. Additionally, some improvements to the module are done. For example, proper spacing and usage of the toggle switches. Resolves: #95381 Releases: master Change-Id: Ia05199a17a90087bbd9181a79ff7f1c2f16f2c4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71338 Tested-by:
-
Oliver Bartsch authored
In case the provider title is a locallang label key, it is now properly resolved. Resolves: #95391 Related: #95287 Releases: master Change-Id: I3b55e98a90df9ea4b081c579954097ec8eeef2a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71345 Tested-by:
-
Oliver Bartsch authored
In #95372 the errorpage.css, used for the standalone ErrorPage template, was moved from EXT:core to EXT:backend, since it had dependencies to this extension. However, it actually belongs to EXT:core. The ErrorPageController is used for both, backend and frontend. A side effect of the relocation to EXT:backend: The errorpage.css was now always loaded in the backend, overriding a couple of classes, which then led to display errors. This is now fixed by removing any dependency to EXT:backend and moving the stylesheet back to EXT:core. As a side effect, the "typo3_orange.svg" file is removed from EXT:backend and EXT:install, since it's now available in EXT:core. All places are adjusted accordingly. Resolves: #95388 Related: #95372 Releases: master Change-Id: I697aa0f98dbd989f68779690d466c7bfdce60c2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71343 Tested-by:
-
Oliver Bartsch authored
This patch cleans up the NewContentElementController, used for the "new content element wizard". All inline JavaScript is removed, in favour of a custom web component and an improved JavaScript module, handling the two modes (create content with known colPos and create content while selecting the desired colPos). Previously, the wizard was triggered by a t3js-* class. Since e.g. the fluid based page module related templates might be overridden in extension code, a fallback layer is present to still support this way of initialization in v11. Due to the necessary refactoring, some related bugs are fixed: * Accessing the wizard via the context menu now works correctly * The "saveAndClose" feature is now also respected in case the user has to choose the desired colPos * Using a custom wizard endpoint (mod.newContentElementWizard.override) does no longer initialize the TYPO3 related JavaScript, which previously led to a JavaScript TypeError * A duplicated clear "icon" in the elements filter is removed Resolves: #95277 Resolves: #95375 Resolves: #95376 Releases: master Change-Id: I6e9b260938c934222e479c1a93c69ba6f27eec4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71318 Tested-by:
-
Nikita Hovratov authored
After refactoring of the recycler templates, the table name is no longer present in the "records" variable. An additional argument for the table is now provided for the partial. Resolves: #95385 Related: #95227 Releases: master Change-Id: I29e372550b45f6ea364e2a29afbb419eb6834c93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71339 Reviewed-by:
-
- Sep 28, 2021
-
-
Simon Schaufelberger authored
While the authentication form has an autocomplete value of "one-time-code", it is missing in the setup template. Resolves: #94998 Releases: master Change-Id: I662c73a176c926c6c8be06180d1d145aef7a1517 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70760 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Stefan Bürk authored
To cover that eID requests are working, this patch adds a test extension which registers a simple responder eID script, which response with some request informations as json response. Resolves: #95362 Releases: master, 10.4 Change-Id: I6ccb1e9612ec735105cea293db98b99cc86643d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71313 Tested-by:
-
Helmut Hummel authored
Since TYPO3 core packages (extensions) are independently published and might be installed in arbitrary file locations in the near future, referencing assets in package A from a CSS file package B will likely not work. Therefore all assets that are referenced from a CSS file are now moved to the package that contains this CSS file. Also references of assets in CSS that already were located in the same package are cleaned up to not assume a hard coded path name (breaking out of Resources/Public directory). Resolves: #95372 Releases: master Change-Id: I6d7d7557d8ea7b293c81b50bc4172019a088f7b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71332 Tested-by:
-
Oliver Hader authored
Substitutes deprecated invocation of `TBE_EDITOR.fieldChanged`. Relevant processing has been duplicated from `TBE_EDITOR` to corresponding `FormEngine` event handler. Throwing a new `change` event from a `change` event handler is counterproductive and would lead to an endless loop. Resolves: #95352 Releases: master Change-Id: I61daee4457ec5d2bb36d1bcc773178c25e00cb8e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71229 Tested-by:
-
Benni Mack authored
This change adds XL and XXL breakpoints to the EXT:form FormElement definitions. Resolves: #95363 Releases: master Change-Id: I881539a183f8d803278d5c8a83e560a75b17fb06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71314 Tested-by:
-
