- Sep 08, 2015
-
-
Christian Kuhn authored
tl;dr: This patch makes FormEngine insanely flexible, extensions however should not rely on structures for now, since class names and array content will change. The patch applies a separation of concerns to the FormEngine class structure by extracting the data processing from rendering. As a main goal the render part consisting of container and element classes routed through the flexible NodeFactory only works on data created by the new FormDataCompiler class construct. This makes the FormEngine much more flexible and opens ways to not only use the render part in the context of database driven data, but on anything that is fed to it. This patch creates the main structure for this. The FormDataCompiler class returns a defined array container and elements can work on it. Data is added by single FormDataProvider, which are combined in FormDataGroups. FormDataProvider may depend on each other and a FormDataGroup "knows" its providers and calls them in a dedicated order. For instance, the "FullDatabaseRecord" FormDataGroup first calls a provider that fetches the record defined by uid and table name and a later called provider determines the given record type this record is assigned to, so another provider can then work on TCA to determine the list of record fields to be shown. The FormDataProvider used for the main FormDataGroup are defined in TYPO3_CONF_VARS, so extensions can add and remove their own providers to add or change certain data if needed. This is highly flexible and extensions are able to hook in at a specific position within the provider chain for the main data groups. This construct obsoletes the DataPreprocessor as well as several other side classes. With this patch the main architecture is created and lots of data preparation is transfered already, supported by a high unit test coverage. The FormEngine class itself is removed: The inline ajax entry point is moved to an own controller class, the getMainFields() and friends methods are substituted with FormDataCompiler / NodeFactory combinations and the data gathering is for now parked in a FormResultCompiler class. However, this process is not yet finished and lots of @todo statements are added to the code base to document open ends and to further separate the data handling from the render engine. Especially the IRRE data handling is currently still located within the render engine and makes the whole thing much more complicated than it should be. Lots of detail patches need to follow to bring this code to a level where it belongs to be. Warning: While this patch is already insanely huge touching more than 22 thousands lines of code, lots of loose ends need to be tackled and the API is not final yet. The arrays will be reduced and sharpened during the next weeks, class names may change and structures will change. Change-Id: Ief1769f478373cc26d1bf6c49114258f0dae8355 Resolves: #69568 Releases: master Reviewed-on: http://review.typo3.org/41933 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Florian Peters <fpeters1392@googlemail.com> Reviewed-by:
Mathias Schreiber <mathias.schreiber@wmdb.de> Tested-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Georg Ringer authored
Change-Id: Ia1bec5a016f3eaf7e6dfb2350f20ff13ab58c5e5 Releases: master Resolves: #69566 Reviewed-on: http://review.typo3.org/43126 Reviewed-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Nicole Cordes authored
This patch adds a check to be able to recognize arbitrary schemes which have to be skipped. Furthermore a missing sanitation is added to TYPO3\CMS\Backend\Controller\ContentElement\ElementInformationController Resolves: #68825 Releases: master, 6.2 Security-Commit: de692804837ad0ddfdff194571dc8c786c717576 Security-Bulletin: TYPO3-CORE-SA-2015-009 Change-Id: Iddd54d241776a47f634c9ac2540e6a2e31801da7 Reviewed-on: http://review.typo3.org/43122 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Frank Nägler authored
Resolves: #69599 Releases: master Change-Id: I5f7416074f643ddc4038a6b9625ba519328cf8fa Reviewed-on: http://review.typo3.org/43113 Reviewed-by:
-
Morton Jonuschat authored
Support for ``between`` has been added to the Extbase Query object. As there is no performance advantage to using BETWEEN on the DBMS side (the query optimizers converts it to `min <= expr AND expr <= max)` this method replicates the DBMS behaviour by building a logical AND condition that has the advantage of working on all DBMS. Resolves: #47812 Releases: master Change-Id: Ic3b416515eedc651faf69de1db21eab288a8ad33 Reviewed-on: http://review.typo3.org/42813 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Morton Jonuschat authored
getFirstTag() didn't take into account that strpos() returns FALSE when the needle isn't found. Resolves: #69318 Releases: master Change-Id: Ie530db9cbed92fa11199852cc0aec77024354814 Reviewed-on: http://review.typo3.org/42898 Reviewed-by:
Michael Oehlhof <typo3@oehlhof.de> Tested-by:
-
Frank Nägler authored
Resolves: #69597 Releases: master Change-Id: I7d80f2fc4e8636ed77800821fc9231f57789e831 Reviewed-on: http://review.typo3.org/43111 Reviewed-by:
-
Frank Nägler authored
Resolves: #69598 Releases: master Change-Id: I7e82fa68f8bd6fab992cdab9674cfeee16d160b7 Reviewed-on: http://review.typo3.org/43112 Reviewed-by:
-
Frank Nägler authored
Resolves: #69595 Releases: master Change-Id: I1190490dfa23cdc206f1cffbd7975ef9d668c786 Reviewed-on: http://review.typo3.org/43109 Reviewed-by:
-
Frank Nägler authored
Resolves: #69596 Releases: master Change-Id: I26ac73af5e2d863753c229b4aef3bfdc3c852456 Reviewed-on: http://review.typo3.org/43110 Reviewed-by:
-
- Sep 07, 2015
-
-
Georg Ringer authored
Even though folders are not visible in the frontend it is useful to have the backend layouts available for this page type. Change-Id: I1bab2ea98a9afa0d62ac2a10a907d634a4e59536 Resolves: #53992 Releases: master Reviewed-on: http://review.typo3.org/43107 Reviewed-by:
-
Frans Saris authored
Releases: master Resolves: #56726 Change-Id: I8f08403aca72bc9ca3f37dec6f98bf016c79a9ee Reviewed-on: http://review.typo3.org/43059 Reviewed-by:
-
Nicole Cordes authored
This patch adds "resource" as valid type information of extbase models. Resolves: #69539 Releases: master Change-Id: I4b6f8f79fcb6a4bc0b85425c4079f2e9f154da62 Reviewed-on: http://review.typo3.org/43098 Reviewed-by:
-
Ingo Pfennigstorf authored
The "save" labels can be simplified and shortened by omitting the word "document". Change-Id: Icc9f3d5c9bf0f2830cdb19cd0ff1892dc948c244 Resolves: #69581 Releases: master Reviewed-on: http://review.typo3.org/43087 Reviewed-by:
Cedric Ziel <cedric@cedric-ziel.com> Tested-by:
-
Jan Helke authored
Releases: master Resolves: #69566 Change-Id: I20563cfcbe5c09629bc9813bef797b0a133d801e Reviewed-on: http://review.typo3.org/43073 Reviewed-by:
-
Frank Nägler authored
This patch removes the SpriteManagerIconViewHelper and all usages within the core. Resolves: #69531 Releases: master Change-Id: I75e3c345973a9b51fb26cc1aeb305536e8c77d14 Reviewed-on: http://review.typo3.org/43019 Reviewed-by:
-
Benjamin Kott authored
Resolves: #69569 Releases: master Change-Id: I11e6434c9bb4007924dd309af5c6c1739222685e Reviewed-on: http://review.typo3.org/43076 Reviewed-by:
-
Jan Helke authored
Releases: master Resolves: #69567 Change-Id: I3c5e967acdcfa061b953fbfe5c713c2ce27e078a Reviewed-on: http://review.typo3.org/43074 Reviewed-by:
-
Markus Klein authored
Reconnecting in isConnected() is not necessary as the next query() will check the status and reconnect properly if required. Using ping() does not work with mysqlnd - only if mysqli.reconnect=1 is set. Setting this is bad practice since a ping() would only reconnect but not properly reinitialize the charset etc. Thus a check in Install Tool is added to make sure mysqli.reconnect is set to "0". Resolves: #69001 Resolves: #69289 Releases: master, 6.2 Change-Id: I3c2cac91e96fdee8bff113f848341856ec51829b Reviewed-on: http://review.typo3.org/42893 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de> Reviewed-by:
Helmut Hummel <helmut.hummel@typo3.org> Tested-by:
-
Frank Nägler authored
Resolves: #69587 Releases: master Change-Id: Ife2606f2c663a0b3df4bd7e140d5344043d5357d Reviewed-on: http://review.typo3.org/43090 Reviewed-by:
-
Frank Nägler authored
Resolves: #69575 Releases: master Change-Id: I62ff951816107fd9f7e656065781b29a433f4dae Reviewed-on: http://review.typo3.org/43080 Reviewed-by:
-
Frank Nägler authored
Resolves: #69576 Releases: master Change-Id: If7c7f97bbfaccec32bf06374c2333f544bc036f5 Reviewed-on: http://review.typo3.org/43081 Reviewed-by:
-
Markus Klein authored
Resolves: #69590 Releases: master Change-Id: Ia903978fa22dfb9193eb4d70188c8c5d1d8e8c12 Reviewed-on: http://review.typo3.org/43097 Reviewed-by:
-
Markus Klein authored
Resolves: #69560 Releases: master Change-Id: I7eb8e9a7a795d34fda0eacecda4c442ff5bd1d07 Reviewed-on: http://review.typo3.org/43068 Reviewed-by:
Philipp Gampe <philipp.gampe@typo3.org> Reviewed-by:
-
Nicole Cordes authored
Within the GeneralUtilityTest::sanitizeLocalUrlValidPathsDataProvider are still wrong dataset unfortunately. As on Windows systems the GeneralUtility::getIndpEnv('TYPO3_SITE_URL') results in http://D:/AbsolutePathToTypo3Installation those test were moved to an own DataProvider which makes sure the HTTP_HOST and SCRIPT_NAME are set correctly before calling GeneralUtility::getIndpEnv(). Resolves: #69584 Releases: master, 6.2 Change-Id: I42e5ab3712f82f5cadd51a478769bc5cb184243f Reviewed-on: http://review.typo3.org/43092 Reviewed-by: -
Helmut Hummel authored
The CSRF tokens for edit document and tce actions were introduced, to protect these entry scripts. Since the entry scripts are removed now and any entry point is protected with a CSRF token by default, we do not need these additional tokens any more. The helper methods can now also be deprecated and the check for the tokens is removed in the controllers. Please note that in the deprecated.php the tokens still must be checked, as third party modules still might generate URLs to the old entry scripts and we want to have this deprecated entry point still be protected. Resolves: #69562 Releases: master Change-Id: I9df443c7fcb4c7db4f7f682d3643b780480ed5de Reviewed-on: http://review.typo3.org/43069 Reviewed-by:
-
Benjamin Kott authored
Resolves: #69570 Releases: master Change-Id: Ie1a3a7cb57f740474ae678831b464c8aed69ae4a Reviewed-on: http://review.typo3.org/43077 Reviewed-by:
-
Michael Oehlhof authored
Resolves: #69559 Releases: master Change-Id: I384a9239c7ba9a31bbd19e492a73a86a4a2b6356 Reviewed-on: http://review.typo3.org/43065 Reviewed-by:
-
Michael Oehlhof authored
Resolves: #69558 Releases: master Change-Id: I587133662b69aafaf7531c386b16446bd6691ae8 Reviewed-on: http://review.typo3.org/43064 Reviewed-by:
-
Michael Oehlhof authored
Replaces IconUtility::getSpriteIcon call for the icon actions-system-shortcut-new with the new IconFactory inside the description of the shortcut drop down. Resolves: #69547 Releases: master Change-Id: I4f91b3fb6ce68764639aefe63126c097d462ef19 Reviewed-on: http://review.typo3.org/43050 Reviewed-by:
-
- Sep 06, 2015
-
-
Alexander Stehlik authored
The CategoryRegistry is stored together with the final TCA in the cache. This is needed because the registry is filled during the initial build of the TCA and not when the TCA is loaded from the cache. Resolves: #67881 Releases: master, 6.2 Change-Id: Ic7f341a1710cafbc1a1ea150e003d3d7a7b9c458 Reviewed-on: http://review.typo3.org/40845 Reviewed-by:
-
Benjamin Kott authored
Resolves: #69557 Releases: master Change-Id: I656ca487527a4c3c77401ac0da1bc7554567fe44 Reviewed-on: http://review.typo3.org/43063 Reviewed-by:
-
Benjamin Kott authored
Resolves: #69556 Releases: master Change-Id: I697aaee1db8b03adafa015e6634156b576f3c381 Reviewed-on: http://review.typo3.org/43062 Reviewed-by:
-
- Sep 05, 2015
-
-
Nicole Cordes authored
If a storage is marked as non-writeable there isn't any possibility to have an upload folder in there. So this storage should be skipped in the lookup of the default upload folder of an user. Resolves: #69303 Releases: master, 6.2 Change-Id: If53b5545a6af6aa1d333d48bb0856a5de070fd2d Reviewed-on: http://review.typo3.org/42864 Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Reviewed-by:
-
Benjamin Kott authored
Resolves: #69555 Releases: master Change-Id: I1f12490509f6b3512ad4358fd407b840db8ec3ac Reviewed-on: http://review.typo3.org/43060 Reviewed-by:
-
Benjamin Kott authored
Resolves: #69554 Releases: master Change-Id: I0564f908ecebf0e6b317b299b43e1b4d4f9af576 Reviewed-on: http://review.typo3.org/43058 Reviewed-by:
-
Frans Saris authored
Releases: master Resolves: #69543 Change-Id: I676a20fd64a13e6f04774fe2fa838c5b51d6eaf0 Reviewed-on: http://review.typo3.org/43045 Reviewed-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
Morton Jonuschat authored
MySQL only allows a limited set of characters in unquoted database names. As the database name can't be quoted for compatibility with DBAL, the name gets validated against the given restrictions. Resolves: #51093 Releases: master Change-Id: I42a0fbf0c6f724245090ad503c8198372f7359d3 Reviewed-on: http://review.typo3.org/43016 Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
-
Morton Jonuschat authored
The SQL compilers need the current database connection for properly quoting identifiers. The constructor declares them a required argument but the SQL parser didn't pass the database connection on instanciation. Resolves: #69528 Releases: master Change-Id: I8cd67bb07d954b73c1e8f1de93f208ca7a835c08 Reviewed-on: http://review.typo3.org/43017 Reviewed-by:
-
Helmut Hummel authored
The introduced DataProcessingTrait isn't exactly a good prototype for Trait usage. It incorporates functionality that isn't easily testable, it is impossible to provide different implementations as the trait is directly bound to the class with its concrete implementation. Use a composite object instead for this functionality. Resolves: #69386 Releases: master Change-Id: I39177b441abc7260465c5271bcd711d8636e1d52 Reviewed-on: http://review.typo3.org/42904 Reviewed-by:
-
