In our efforts to achieve a better interoperability
with other PHP projects, the PHP code base of the
TYPO3 Core switches to the PHP coding guideline
standard PSR-2.

See http://www.php-fig.org/psr/psr-2/ for more
information.

Resolves: #70515
Releases: master
Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5
Reviewed-on: http://review.typo3.org/43918


Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>

Most of TYPO3's PHP files have an empty line before a class' closing curly
brace. This commit adds this empty line (if it is missing) before a class'
closing curly brace.

This is not part of the TYPO3 CMS CGL but increases consistency in this
area.

This regular expression was used to add the empty lines:

Search:
(}\n)(})

Replace:
$1\n$2

Resolves: #63942
Release: master
Change-Id: Icd6547322ac8b7310956d347fd73c90bde2bbfa7
Reviewed-on: http://review.typo3.org/35527


Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

This regular expression was used to replace PHPDoc style comments
with ordinary comments:

Search:
/\*\*(\n \* This file is part of the TYPO3 CMS project.)

Replace with:
/*$1

Resolves: #63328
Releases: master
Change-Id: Ic8f11dbfefee94a19657c8fe8426c81d1cb435d8
Reviewed-on: http://review.typo3.org/35103


Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>

Use "int" or "bool" in @var notation instead of
"interger" or "boolean".

Resolves: #62571
Releases: master
Change-Id: Icc17d2a7806a4632da2c4684c57f1f6d619878a3
Reviewed-on: http://review.typo3.org/33632


Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>

* Use bool in @return
* Use int in @return
* Use bool in @param
* Use int in @param
* Remove extra tabs and spaces in @param

Resolves: #62506
Releases: master
Change-Id: I673888aa08855a1364150d0060d0f205fc1f83a2
Reviewed-on: http://review.typo3.org/33577


Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59777 for further details.

Resolves: #59777
Releases: 6.2
Change-Id: Idf5ef5a0da53dd052af54d42a115e951bc9d0e91
Reviewed-on: https://review.typo3.org/31022
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Markus Klein
Tested-by: Markus Klein

If open_basedir is restricted to files, eg. /usr/bin/gm, detection
fails in install tool. The additional is_dir() check may fail then.
The patch removes it since @is_file() covers the same checks.

Resolves: #58466
Releases: 6.2
Change-Id: I5ab6a36ccd3d283a1dc1e672f7deddc2f0ea37c4
Reviewed-on: https://review.typo3.org/29822
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Change-Id: Iaa92566c53301e49396fc9fb26b0b339c48d567b
Resolves: #52360
Releases: 6.2
Reviewed-on: https://review.typo3.org/24212
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

There are two very weird settings is GFX array that previously
decided on how "masks" are applied to images if combining
multiple images. GFX/im_negate_mask and GFX/im_imvMaskState are
also manipulated during boostrap and depend on each other.

Fiddling with those settings in ImageMagick 6 and GraphicsMagick
with its supported versions, it turns out that they are obsolete
and can be removed completly. The patch does this.

Change-Id: Ic24c877287382f9e718974a0df3577dad2eeaac9
Resolves: #52088
Releases: 6.2
Reviewed-on: https://review.typo3.org/23880
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Image Magick support for versions 4 and 5 was dropped. The setting
to differentiate combine from composite is obsolete now and composite
is used always.

Change-Id: I0fbc847167d340fd83315285745c63d53225891a
Resolves: #52011
Releases: 6.2
Reviewed-on: https://review.typo3.org/23836
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Support for Image Magick version 4 and 5 was dropped, allowed
settings for im_version_5 are "im6" and "gm". As soon as one
of this is set for im_version_5, bootstrap automatically sets
"im_no_effects" to 1. In effect, this value is *always* one, so
it is obsolete and can be removed from the system.

Change-Id: Ieb798352aebaae4943018a225518591a952a8bcb
Resolves: #52010
Releases: 6.2
Reviewed-on: https://review.typo3.org/23835
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Image Magick versions 6.7 and above need sRGB as colorspace,
otherwise images are too dark. This also works for older versions
like 6.6. Use sRGB as default is image configuration presets.

Change-Id: I7c50ee932b1335892eb228b10fc00136cfc54527
Resolves: #52017
Releases: 6.2
Reviewed-on: https://review.typo3.org/23840
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

The patch implements a "configuration system" to the install tool
that bundles several settings to enable them on click
depending on system capabilities.

A "feature" is represented by a set of configuration options that
are filled by different presets. Presets have a priority, the
best preset is the first one. Presets can be available or
not available and active or not. For example the "image handling"
feature has the presets "GraphicsMagick" and "ImageMagick 6" and
a "Custom" preset if the others do not fit.

This first patch implements "Charset conversion", "Image handling",
"Development / Production" and "Extbase object cache" settings.

During installation the available preset with highest priority
are configured.

Change-Id: I7304ef001717989720924e7ae03951eb3874adfd
Resolves: #51454
Releases: 6.2
Reviewed-on: https://review.typo3.org/23321
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn