- Mar 19, 2014
-
-
Markus Klein authored
AbstractCoreUpdate redefines the $view member to be a JsonView, but does not re-implement the parent methods that rely on $view being an AbstractView. Fix this by re-implementing the initializeHandle() method. This method can be merged with the former initializeCoreUpdate(), which wasn't called at all in most actions. Resolves: #56865 Releases: 6.2 Change-Id: I85260a0e57e915ac941569cfbdde1f96cdaec5e6 Reviewed-on: https://review.typo3.org/28393 Reviewed-by: Philipp Gampe Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 18, 2014
-
-
Marc Bastian Heinrichs authored
Resolves: #57045 Releases: 6.2 Change-Id: I439305e5143b3c51a03befc642caf66286264679 Reviewed-on: https://review.typo3.org/28496 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs
-
Oliver Hader authored
Add the copyPage() functional test for live and workspace. Resolves: #57030 Releases: 6.2 Change-Id: Id9ddea21a50c449c3f2674d704c10fefb2da12ff Reviewed-on: https://review.typo3.org/28488 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Oliver Hader authored
As a follow-up to issue #57046 (which fixed a bug in sys_file_metadata pointing to sys_file_reference as translation parent), these corrections need to be updated in the functional test assertions as well. Resolves: #57054 Releases: 6.2 Change-Id: I1a3d395fb4fcb1271d2684af38e5fc32a10463fc Reviewed-on: https://review.typo3.org/28512 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Alexander Opitz authored
Follow-up to 2268f64c If typo3temp does not exist, the Locker should throw an exception. The ClassLoader needs to catch this exception and acts upon depending on whether we are in the Installer or not. When in the Installer, locking has to be skipped completely due to missing typo3temp directory. Resolves: #57008 Releases: 6.2 Change-Id: Ic595dc97826cd94d6f173b7c681194ed754ed3e0 Reviewed-on: https://review.typo3.org/28482 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Marc Bastian Heinrichs authored
Instead of sys_file_metadata sys_file_reference was configured. Resolves: #57046 Releases: 6.2 Change-Id: I1194012cbacb0415993672338d6ac6ee0a515dc1 Reviewed-on: https://review.typo3.org/28501 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Benjamin Mack authored
As TYPO3 is loading all ext_localconf.php on each call, the existing code can be cleaned up by removing old information, putting BE-only functionality in TYPO3_MODE == 'BE' and install-tool only in Install only mode. Also, some hardcoded require_once statements are removed. Benefits are that FE does not need to load everything all the time. I haven't noticed any side-effects so far, but please test extensively. Resolves: #55593 Releases: 6.2 Change-Id: Ibc37e84cb2af05ddb6b227290330aad31037a018 Reviewed-on: https://review.typo3.org/27286 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Fabien Udriot Tested-by: Fabien Udriot Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Andreas Fernandez authored
The method analyzeFields() of DBAL's DatabaseConnection caches the table structure. The cache always uses the real table name, ignoring any mapping, which results in a RuntimeException: "Could not update BLOB >>>> no WHERE clause found!" The method now checks for a possible mapping and sets the alias as table name. Resolves: #56349 Releases: 6.2 Change-Id: I9599cebc8604103c3749bc142cd44b813f018a72 Reviewed-on: https://review.typo3.org/27874 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
Bernhard Kraft authored
Instead of iterating over the array and calling "intval" for each element the "array_map" php function gets used. Change-Id: I5ae699f9bc158eb0caebf1fc9ea8ebaa3cdd73ca Resolves: #56738 Releases: 6.2, 6.1, 6.0 Reviewed-on: https://review.typo3.org/28234 Reviewed-by: Dmitry Dulepov Tested-by: Dmitry Dulepov Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Alexander Stehlik authored
In the image rendering TypoScript configuration of css_styled_content the uid is removed from the references configuration of the FILES content object. This makes sure that the language overlay mechanism from the FILES content object is used. Resolves: #56712 Releases: 6.2 Change-Id: Iaea43ca006826facfba40a846da67704dd3154ea Reviewed-on: https://review.typo3.org/28210 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Xavier Perseguers authored
As TYPO3 is now using mysqli, prepared queries are natively supported and should be used. DBAL, however, does not yet actually use native prepared queries but falls back to standard queries by replacing placeholders and executing the underlying SQL query. Change-Id: If50da6e6d27af89e01c0439bcb9d39a85615a75d Resolves: #27372 Releases: 6.2 Reviewed-on: https://review.typo3.org/28231 Reviewed-by: Andreas Fernandez Tested-by: Andreas Fernandez Tested-by: Wouter Wolters Reviewed-by: Markus Klein Reviewed-by: Stefan Neufeind Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
Alexander Stehlik authored
When the linkvalidator detects a 403 error when doing a HEAD request to an external URL it will retry the request using the GET method. Resolves: #54513 Releases: 6.2 Change-Id: Ib36b6cbb8e981b95c348afd5a063ca4f5040de75 Reviewed-on: https://review.typo3.org/26489 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Claus Due authored
This change removes a reference to the old <tx_templavoila> nesting tag which was switched away from in TYPO3 4.7, making section objects inside sections in flexforms, use the proper array index path "title" instead of "tx_templavoila.title". Releases: 6.2 Resolves: #54503 Change-Id: I4c975cf4eed127ca90ead3d7566fbc826f5b78db Reviewed-on: https://review.typo3.org/26482 Reviewed-by: Wouter Wolters Reviewed-by: Fabien Udriot Reviewed-by: Dmitry Dulepov Tested-by: Wouter Wolters Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Marc Bastian Heinrichs authored
Add missing conflictMode 'changeName'. Releases: 6.2, 6.1, 6.0 Resolves: #57004 Change-Id: Ie5c32e96c1292dbaecc505d54240f1a7a5c720fe Reviewed-on: https://review.typo3.org/28476 Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
Oliver Hader authored
Resolves: #57014 Change-Id: Ib3a5688a111d3ce38c3672fad0a11b195839323d Reviewed-on: https://review.typo3.org/28486 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Alexander Stehlik authored
To display the session timestamps in the online Backend users list in the correct timezone the DateViewHelper will now create the DateTime object because it already takes care of the correct timezone handling. Resolves: #56985 Releases: 6.2 Change-Id: I65003c3f5505f4fe96160f917131fe13a3a53416 Reviewed-on: https://review.typo3.org/28462 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Frans Saris authored
The dimensions of a file are fetch during indexing. These values should be used as for remote files or certain filetype getimagesize() will not work or give unwanted overhead. Resolves: #56864 Releases: 6.2 Change-Id: I14ece9c0dbf414f4cb0759d3065a1c5b5782ca29 Reviewed-on: https://review.typo3.org/28404 Reviewed-by: Markus Klein Reviewed-by: Tomita Militaru Reviewed-by: Wouter Wolters Reviewed-by: Dmitry Dulepov Tested-by: Dmitry Dulepov Tested-by: Markus Klein
-
- Mar 17, 2014
-
-
Felix Oertel authored
At the moment extbase persistence is quite slow. To some degree, the query building is responsible for that. For each and every query the parseQuery() and buildQuery() methods are called. This patch introduces a query cache to store the query structure. This way a query can be reused, even when fired with different parameters. * Introduce a parameterIdentifier to the comparison In the way the extbase query object model works, it's hard to identify an object in a way which is unique and still compre- hensible. To ease this, an identifier is introduced. * Move parsing to an external QueryParser All the query parsing is now seperated from the storageBackend. The query parsing is mostly left the way it was, it should be re-profiled later. * introduce cache extbase_typo3dbbackend_queries * No more statement handling by reference Make getStatementParts() return the query and parameters in an array instead of handing down the parameters by reference. * Split up parseQuery in preparsing and real parsing with caching In every call the query has to be preparsed to determine the identifier and extract the parameters. The identifier can then be used to look up the query structure in the cache. If it is not (yet) cached, Extbase will do the real parsing which takes some more time. * Introduce useQueryCache to querySettings Like preparedStatements, caching the queries does not always make sense and will spam your cache under certain conditions. It's enabled by default and can be disabled on a per-query- basis. * Use named parameter's placeholders Instead of using "?" as parameter's placeholder and relying on the right order of parameters in the array, named place- holders are used to ensure the correct association. * Move unit tests around to fit the new queryParser Resolves: #55167 Releases: 6.2 Change-Id: I517c0500cad75cae96fd739f2ff7222db80b42a5 Reviewed-on: https://review.typo3.org/27555 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Tested-by: Philipp Gampe Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Marc Bastian Heinrichs authored
Fixes using $query->statement() without parameters. Resolves: #56915 Resolves: #55360 Releases: 6.2 Change-Id: Ia149313f5f9f719d7dba0a21a3eb39ea4f5052e8 Reviewed-on: https://review.typo3.org/28442 Reviewed-by: Markus Klein Reviewed-by: Dennis J Tested-by: Dennis J Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Philipp Gampe authored
The documentation module does not initialize the signal slot dispatcher in its ext_localconf.php, but rather reuses the already set variable from another core extension. Create the object explicitly before using it. Resolves: #57009 Releases: 6.2 Change-Id: Ifbd3199f9cef0b2d2d6dacc4569280c5e668822c Reviewed-on: https://review.typo3.org/28481 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Thomas Maroschik authored
During bootstrapping the ResourceStorage and ResourceFactory is loaded and evaluated just because of two constants containing signal names used in ext_localconf. This introduces unnecessary overhead especially in eID context. The constants have been extracted to an interface that are way faster parsed. Resolves: #56335 Releases: 6.2 Change-Id: I509593d2720c595fa7e4f1c9b5c63fd09fea724c Reviewed-on: https://review.typo3.org/28416 Reviewed-by: Wouter Wolters Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe
-
Alexander Opitz authored
After cache clearing we can run in the situation that 2 processes will rebuild the ClassLoader cache which will lead to a non useable cache, which produces fatals. As the data is generated more than once the load of the server increases per request while ClassLoader cache is build. The implemented Locking will stop this issue. Every process waits till the first is ready and then looks if data was generated and stops re- generating the cache. To-Do: Make it work also for first time installation when there is no typo3temp/ directory yet. Resolves: #55099 Releases: 6.2 Change-Id: I9c1916b5b5860e86fe19a1fc292d8ab5a196d960 Reviewed-on: https://review.typo3.org/28480 Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny
-
Marc Bastian Heinrichs authored
If an record with a field of type "group", internal_type "file" should be indexed in the ReferenceIndex an SQL error exception gets thrown. So the relation to the file isn't represented in the refindex. Thus those files are also missing in exports created with system extension impexp. This is caused by wrong array keys and incorrectly storing a file relation as DB relation since merge of FAL. Resolves: #56353 Resolves: #56352 Releases: 6.2, 6.1, 6.0 Change-Id: I78211efcb6bf3032811ef0b0e20ed7f98f9fa8fb Reviewed-on: https://review.typo3.org/27310 Tested-by: Sebastian Fischer Tested-by: Christian Zenker Reviewed-by: Wouter Wolters Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Nicole Cordes authored
This patch turns all remaining RTE module scripts (mod4, mod5, mod6) into CSRF protected wizards. Resolves: #55674 Releases: 6.2 Change-Id: I8421ff05240f6eedcaf40c805d9dd92ea7d4c30b Reviewed-on: https://review.typo3.org/28208 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Wouter Wolters authored
* Removed require_once which is deprecated. * Introduced a use-statement for GeneralUtility * Removed TYPO3_MOD_PATH * Links generated by make_seeAlso() were double htmlspecialchars encoded after security patch https://review.typo3.org/27636 Resolves: #56826 Related: #55509 Releases: 6.2 Change-Id: I8effc7c6bf9828dde4f1c69754b207864b3122ba Reviewed-on: https://review.typo3.org/28303 Reviewed-by: Stefan Neufeind Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Alexander Stehlik authored
If copying a page, all records on that page will be copied to the accordant destination page. IRRE parent-child structures are cloned along the way as well. However, if a table (that is defined a IRRE child) is processed before the accordant parent record, the parent itself will duplicate its children again. This behaviour leads to superfluous duplicates and is wrong. A check in DataHandler::copyRecord_procBasedOnFieldType() now ensures that records are only copied once during the accordant DataHander copy process. Resolves: #44795 Releases: 6.2 Change-Id: Ia1e4129432f37c0dd6bfedb5fd69394e2c244d34 Reviewed-on: https://review.typo3.org/26552 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Markus Klein authored
This reverts commit b2756fe7 A comment of Helmut Hummel was suggested, which was still missing. This change will be repushed. Releases: 6.2 Change-Id: I518af35f562350f9dde39678de52f69d58344677 Reviewed-on: https://review.typo3.org/28478 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Georg Ringer authored
To make work in hooks easier, the method should be public Resolves: #56721 Releases: 6.2 Change-Id: Ib0a0f17d5f9384a04a125ef08a079f4c272eddae Reviewed-on: https://review.typo3.org/28337 Reviewed-by: Alexander Stehlik Tested-by: Alexander Stehlik Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Marc Bastian Heinrichs authored
Since images in RTE fields are handled as relations to sys_file records adding references to the reference index for the concrete image paths are obsolete and causes trouble with impexp. Resolves: #56811 Releases: 6.2 Change-Id: I26a2531f417ff8b628b69156a3a2236c99960d5e Reviewed-on: https://review.typo3.org/28292 Reviewed-by: Stanislas Rolland Tested-by: Stanislas Rolland Reviewed-by: Fabien Udriot Tested-by: Fabien Udriot Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs
-
Alexander Opitz authored
If a package is (un)installed we need to update $GLOBALS['TYPO3_LOADED_EXT']. ExtensionManagementUtility depends on the actuality of this array. Resolves: #56978 Releases: 6.2 Change-Id: I969b84a624a6a9f74b87fdd85b9c4c3a7b49750a Reviewed-on: https://review.typo3.org/28459 Reviewed-by: Thomas Maroschik Tested-by: Thomas Maroschik Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
Daniel Siepmann authored
The errors are logged in another log file and loaded as json afterwards. Change-Id: I63458c0a4f64e6d8f4236667b6d22ff6b50aa1f3 Resolves: #51362 Releases: 6.2 Reviewed-on: https://review.typo3.org/28298 Reviewed-by: Tomita Militaru Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny Reviewed-by: Dmitry Dulepov Tested-by: Dmitry Dulepov
-
Frans Saris authored
The storages can not be ordered manualy and in list view they are by default ordered by name. But in the tree views (file module, element browser) there is no ordering set. This change sets the default ordering to name when the storageRowCache is initialised. Resolves: #56824 Releases: 6.2 Change-Id: I8e879920bc6da14156ce486b8c25b1b8820f896b Reviewed-on: https://review.typo3.org/28402 Reviewed-by: Marcin Sągol Reviewed-by: Stefan Neufeind Reviewed-by: Christoph Lehmann Tested-by: Christoph Lehmann Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
- Mar 16, 2014
-
-
Christian Kuhn authored
The patch further reduces the unit test bootstrap: ext_localconf of extensions is not loaded anymore and the cache framework is no longer initialized. A test with incommplete mocking in this area is fixed along the way. Furthermore the core exception handling is no longer initialized, so it does not depend on configuration options. A warning triggered by a unit test will now reliable let the test fail. Change-Id: I659441482a19eb6b434d520ecded6df8f5086820 Resolves: #51436 Related: #56967 Releases: 6.2 Reviewed-on: https://review.typo3.org/28449 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Felix Kopp authored
Brings last styles according to layout defined by the UX team. Resolves: #56960 Related: #26796 Releases: 6.2 Change-Id: Ie1c4bc57343555edac66362100a6ec659d953173 Reviewed-on: https://review.typo3.org/28405 Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
Lots of unit tests did inherit from extbase BaseTestCase. Meanwhile all code of this abstract was merged to ext:core UnitTestCase and with the refactoring of the core unit test boostrap the objectManager that is still in this class does not work anymore. The class is now removed, but since this is probably used in some third party extensions, it is set as class alias to ext:core UnitTestCase and marked as deprecated in a lecagy file, so IDEs hint developers about this deprecation. Change-Id: I31fb337e065aed7f03351cb04e13c68a98c93a34 Resolves: #56963 Related: #51436 Releases: 6.2 Reviewed-on: https://review.typo3.org/28445 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Christian Kuhn authored
Changes class inheritance from ext:exbase BaseTestCase to ext:core UnitTestCase in ext:extbase Change-Id: If2d2afbc05765b3ff1d8fa3fded17e6fb0eecd44 Resolves: #56961 Related: #51436 Releases: 6.2 Reviewed-on: https://review.typo3.org/28441 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Christian Kuhn authored
Changes class inheritance from ext:exbase BaseTestCase to ext:core UnitTestCase in ext:fluid Change-Id: I46667d9cb5a56f5bc29c4f2c3525c6556d5f802f Resolves: #56958 Related: #51436 Releases: 6.2 Reviewed-on: https://review.typo3.org/28440 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
Changes all extensions except extbase and fluid to extend from extbase ext:core UnitTestCase instead of ext:extbase BaseTestCase. Change-Id: Ifbb1542546f2622ece11471fd057ec469518488a Resolves: #56949 Related: #51436 Releases: 6.2 Reviewed-on: https://review.typo3.org/28434 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Ernesto Baschny authored
Follow-up to 0d69c2d9. The renamed language command controller (language:update) was introduced in 6.2, so we can simply remove the original name instead of deprecating it. This will only affect installations which are already using this task since 6.2 alpha2. Resolves: #54128 Releases: 6.2 Change-Id: Id6bb709bd30c9044c949c431aa2a595c1035c601 Reviewed-on: https://review.typo3.org/28433 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
TYPO3 Release Team authored
Change-Id: I58d0d08817eab7c2490d7dc65fad562ef436f402 Reviewed-on: https://review.typo3.org/28439 Reviewed-by: TYPO3 Release Team Tested-by: TYPO3 Release Team
-