- Jan 07, 2021
-
-
Anja Leichsenring authored
If a reqest object already is around, $request->getAttribute('normalizedParams')->getRequestUri() can be used as a drop in replacement. As a fallback $GLOBALS['TYPO3_REQUEST'] is almost always available and contains the request object. Resolves: #93178 Releases: master Change-Id: I2bb13a54e6b8705be5783042a4f67f9735c627a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67255 Tested-by:Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Christian Kuhn authored
Throw if frozen, then call ->remove() of SimpleFileBackend Resolves: #93239 Related: #92847 Releases: master Change-Id: I01fe5d79b9adc48491ece5ed360be4e94c0e53af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67359 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Christian Kuhn authored
Calling $cache->remove() on a simple file backend when the file does not exist leads to a PHP warning. Checking with file_exists() before could lead to race conditions if some other process unlinks in between. Solution is to simply suppress the unlink warning. Resolves: #92847 Releases: master, 10.4 Change-Id: I3f3f44f73b89ff76939b891e8ca78c4d79369997 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67358 Tested-by:
-
Benjamin Franzke authored
In order to strengthen TYPO3's focus on PSR standards, this change uses PSR-17 interfaces instead of the custom ResponseFactoryInterface which was added solely for extbase in #92784. The interface was added as part of the #92784 deprecation, but it actually contradicts with the ideas of interchangable PSR interfaces and therefore we strive for native PSR-17 usage, instead of wrapping PSR interfaces, now. The Extbase ActionController::htmlResponse() method – which was suggested to be used by #92784 – is kept as is (functionality wise [1]), and since the interface was injected into the ActionController using a final method, the impact of this switch is very low. Concrete implementations of PSR interfaces are always internal api, threfore also TYPO3\CMS\Core\Http\Response is switched back to be marked as internal API. Furthermore TYPO3\CMS\Core\Http\JsonResponse properties do not need to be marked internal, as the entire class is internal. [1] ActionController::htmlResponse() is adapted to avoid rewinding() the response body, as every usage/respond is actually expected to rewind or use toString(), and therefore rewind() would be called twice. Only functional tests where buggy in not calling rewind() during test assertion. Releases: master Resolves: #93237 Related: #92784 Change-Id: I59e5a190eaa1f0dd62f08db34987c6d4a72b73c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67353 Tested-by: -
Benjamin Franzke authored
SelectTreeElement makes use of $.param() without importing jquery via requireJS. Instead of adding the missing jquery import, we simply migrate to the native URLSearchParams, as it is available in all supported browsers. Furthermore we avoid decoding the datastructureidentifier json, as it is encoded to json server side. We do this, because URLSearchParams does not url encode nested objects. Resolves: #93200 Releases: master Change-Id: I0da98092da6e09d6576bbdb59112d738086be238 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67323 Tested-by:
-
Martin Kutschker authored
Colour contrast for footnote text meets WCAG 2.1 requirements. Role status for the caps-lock notice belongs to the div wrapping the image. The HTML document has a heading structure (h1 to h3). The content is placed in ARIA regions. The first form field has the autofocus (interface selector comes after password). All password fields have a caps lock status notification. The copyright notice implements the WAI-ARIA 1.1 disclosure pattern. The message after successful changing the password contains an accessible link. Resolves: #92904 Releases: master Change-Id: I67a2e61644711d20a20432b3eed4dca808ec591b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66818 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
-
- Jan 06, 2021
-
-
Andreas Fernandez authored
The FormEngine field type `selectMutlipleSideBySide` is very special, as it's a combination of four input and select fields. With the refactoring done in #87324 an issue in the validation has been introduced which caused the validation of the wrong field which contains no validation rules. This patch uses the correct field to obtain the validation rules from, now. Another issue is that values of `selectCheckBox` never have been validated as the necessary validation rules were missing. The rules are now appended to the outermost div container. In the same run, minor styling and markup changes were necessary. Resolves: #93191 Related: #87324 Releases: master, 10.4 Change-Id: I7195213a768fa4814eb3ecd81953a500c77ede5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67317 Tested-by:
-
Benjamin Franzke authored
Migrates backend UI component `Notification` to be based on `lit-html`. Resolves: #93102 Releases: master Change-Id: Ic79ff0261c75fa5e7654ff44c213784302dc1b59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67179 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Christian Kuhn authored
Adding a user to the ext:beuser 'compare' list and deleting the user afterwards, still allows to compare that user with others. Fix the repository query settings to never handle deleted users. Resolves: #93235 Releases: master, 10.4 Change-Id: I18d3eacfd6b0d19f7dca6f57d51dbc33aa2c8273 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67354 Tested-by:
-
Oliver Bartsch authored
The backend usergroup compare view requires to fetch the group data of the groups to compare. Since this operation depends on a user array, UserInformationService creates such dummy user. The dummy user array now also contains the default workspace id `-99` to prevent triggering a database update which would result in creating a sys log entry. This would fail since the user, the database update should be performed on, is the dummy user which is not fully set up. Resolves: #93233 Releases: master, 10.4 Change-Id: I61870acbab133d9f3f1b80899b50662dca2bc9bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67352 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Elias Häußler authored
Adds nonExcludeFields to backend user comparison view since it was not added to this view yet. Resolves: #93234 Releases: master Change-Id: I5a5bb072c10571e70a04bc1c7df25df1b81fefdf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67351 Tested-by:
-
Elias Häußler authored
All collapsible elements in Backend User info (TSconfig, exclude fields) can now be collapsed at first click. For this, `aria-expanded="false"` has been set. Resolves: #93232 Releases: master Change-Id: I38fb2d0054a8164be1a0514683ff89b077e15e1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67349 Tested-by:
-
Oliver Bartsch authored
With #93093 the shortcut PHP API was reworked. Since then, providing the route path as "route" argument is deprecated. This patch removes all places in the core where the argument was still being set. Resolves: #93224 Releases: master Change-Id: I4496e88f67f7e821653af31b647b1825b6cc3371 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67343 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
Benjamin Franzke authored
Adapt the fetch-configuration URL query string, to account for the backend url change in #93048, in order to use a questionmark to concatenate the query string instead of an ampersand. But allow for both, base URLs with and without question mark, as frontend context via eID would still require an ampersand for concatenation. Also fix a error callback name clash and properly propagate fetchConfiguration errors through the requirejs error handling, for requirejs errbacks to be invoked. Resolves: #93227 Related: #93048 Releases: master, 10.4 Change-Id: If843db529e19e6af2681871a2d6307d67acbea56 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67346 Tested-by:
-
Elias Häußler authored
Both links to switch Backend user (Backend toolbar item and SwitchUser view helper) are now streamlined. Resolves: #93228 Releases: master Change-Id: I5225bff74ebdd8cfcda698d43f4b7823524bf0a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67347 Tested-by:
-
Benjamin Franzke authored
* Fix 500 vs 503 error for configuration vs maintenance errors * Fix maintenance mode middleware ordering to get access to site related error handlers * Fix ErrorController unit tests to actually test for 503 and 500 error responses (contained duplicate code that didn't actually test for the non-configured state, but the devIPMask state) For 5xx status code we have two different cases right now: * configuration errors, which need to respond with 500 * maintenance mode, which is a 503 response Therefore TSFE now uses internalErrorAction() to respond with "500 Internal Server Error" when the page configuration is broken. Resolves: #93045 Related: #93032 Releases: master, 10.4 Change-Id: I60de9f7ba06d17f2e6e5c8f20c9fc10e90b4175b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67080 Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
-
Andreas Fernandez authored
When sorting elements in an IRRE container, the sorting took grandchildren into account as well, which broke the sorting in the database. With this patch, a new data attribute is added to be able to identify direct ancestors and limit sorting to these records only. Resolves: #92804 Releases: master, 10.4 Change-Id: I09876c3a8be45b060c133d758807e4df25fee0d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66933 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Guido Schmechel authored
If an integrator removes image file extensions, e.g. "gif", from $GLOBALS['TYPO3_CONF_VARS']['GFX']['imagefile_ext'] the whole image processing test in the install tool fails. That's because some tests need to run independent of the global configuration. Therefore the GraphicalFunctions class, which is used as the image processor, now features a setter. This allows EXT:install to manually define required image extensions for the tests, which should not consider the global configuration. Note: The `convertImageFormatsToJpg` test, which tries to convert every defined image file extension (based on the global configuration) to JPG, is not affected by this change. Resolves: #92958 Releases: master, 10.4 Change-Id: Ic84be73c897f497fedd6b442965edf6fb3ef88c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67344 Tested-by:
-
Martin Kutschker authored
The login logo is linked only for technical reasons of a security check. It is not meant to be used by humans but is placed prominently enough to be an accessibility issue. Remove the link around the logo and create a new one hidden from the user interface. Resolves: #93172 Releases: master, 10.4 Change-Id: Id1edc5dd0e059a8700e4bb6c0e09e3f443b6f9fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67252 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Remo Schneider authored
Added some more examples how to add fallbacks for specific metatags when they are not rendered by EXT:seo. Releases: master Resolves: #92831 Change-Id: I59fe786b7825663ab6bad77b94a2669dca6bc24b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66621 Tested-by:
-
Elias Häußler authored
With the introduction of Backend url rewrites with #93048, the generated redirect url to switch backend users was broken. The redirect url is now created from the "main" route using the UriBuilder. Resolves: #93225 Related: #93048 Releases: master Change-Id: I8ab0f9540c8b3a15789aabd947580d817d386b07 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67345 Tested-by:
-
- Jan 05, 2021
-
-
Jo Hasenau authored
This adds a new data processor which converts the XML structure of a given FlexForm field into a PHP array to be used in Fluid templates. Resolves: #89509 Releases: master Change-Id: I267defe0b26bca33f636c44edd53d695f1bcb572 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62108 Tested-by:
Jo Hasenau <info@cybercraft.de> Tested-by:
-
Eric Chavaillaz authored
The option noViewWithDokTypes is now also respected for the control panel of a single record in the listing. Resolves: #92813 Releases: master, 10.4 Change-Id: Ie6ba12bf5dd22039aee28e05585b3d3930b3faeb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66597 Tested-by:
-
Sybille Peters authored
The TSconfig of linkvalidator contains 'linktypes' which is a list of link types which should be checked (e.g. 'external','db' ...). This list of links can have 2 different formats inside internal code: ['external', 'db'] or [ 'external' => 1, 'db' => 1 ] Converting this in various places made the code hard to read and error prone. Only the first format is now used, which also makes it possible to simplify the tests. Resolves: #92715 Releases: master Change-Id: I7451f707da15a20b21b5fefe5df50ed455a5b733 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66319 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Sebastian Michaelsen authored
The language switch is never rendered for non-persisted records, so the method to create it should not be called in this sitation. Resolves: #92971 Releases: master, 10.4 Change-Id: If6d85a7bbf44a841f08d0331da3e5e0943232953 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66962 Tested-by:
-
Christian Eßl authored
The fluid based page module, introduced in v10 and the only available variant since v11, does now correctly respect the TSconfig options 'mod.web_layout.disableNewContentElementWizard' and 'mod.newContentElementWizard.override' again. Resolves: #92504 Releases: master, 10.4 Change-Id: I0a1f04e700ecaf131e735e05d6fc36c2bf313dc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66071 Tested-by:
-
- Jan 04, 2021
-
-
Oliver Bartsch authored
The context menu no longer offers the "view" option for excluded doktypes like "spacer". Resolves: #93215 Releases: master, 10.4 Change-Id: If9bdcd447c340f052ee12f83f26e4c57c637ec32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67337 Tested-by:
-
Christian Kuhn authored
Workspace delete placeholders are just a marker that a live record should be deleted in live when the delete placeholder is published. Actual field data does not matter. Those records should thus never be editable via FormEngine. With patch, FormEngine throws an exception when a delete placeholder is edited. Additionally, the module menu language selector drop down when editing a record is adapted to not link to delete placeholder workspace translations. Change-Id: Iaf73777ffb1d01e6fde5bef1eaa4e281a1b46fe1 Resolves: #88153 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67325 Tested-by:
-
Martin Kutschker authored
The words FullyScanned, PartiallyScanned and NotScanned must not have any leading or trailing characters when on the last line of an ReST file for breaking changes or deprecations. Resolves: #93208 Releases: master, 10.4 Change-Id: I4a8f0e7cf61cc885df3566e2fb4621c80d82f744 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67332 Tested-by:
-
Christian Kuhn authored
The security fix related to better hashed sessions had fallbacks to deal with existing non hashed sessions. This was for a smooth transition in security patch level releases. The patch drops these fallbacks in master. Resolves: #93140 Releases: master Change-Id: I68172fd26619d93068fc6a2490134bfb9b8a204e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67223 Tested-by:
-
Christian Kuhn authored
The patch for #93131 increased the db size of field ses_id in tables fe_sessions and be_sessions from 32 to 255 chars. The field is the tables primary key. With mysql/mariadb, if the table is created on an older db engine version that creates innodb tables with COMPACT row format using utf8_mb4 charset, the key length now exceeds the COMPACT maximum index length restrition of 767 bytes: 4*255+1 = 1021 bytes Since we don't strictly need a varchar(255), the patch reduces the field to 190, which does not collide with maximum key length restrictions: 4*190+1 = 761 bytes Change-Id: Ifc344a68a49ce0b863109cbfe8a7d27c0179c0cf Resolves: #93150 Related: #93131 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67336 Tested-by:
-
Benjamin Franzke authored
Remove jQuery dependency, avoid inline javascript and encapsulate initialization into a web component. Also use "codemirror" as import name, as that's what the npm package name is, and will eventually allow to make use of TypeScript typings. Releases: master Resolves: #93149 Change-Id: Ia85784b21a90e1986ea6ba7a915e032aa7963d92 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67185 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Andreas Fernandez authored
With #93135, selectMultipleSideBySide fields broke and didn't accept new values as both select fields share the same `data-formengine-input-name` which confuses the changed CSS selector. This patch removes the attribute from the "value provider" fields as it's not required there at all and also adapt FormEngine to not use the styling related form-select class. Resolves: #93213 Resolves: #93214 Related: #93135 Releases: master Change-Id: I2cf4ad6ff4d78072bf5474d7393ad4eb7f771070 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67335 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Andreas Fernandez authored
With Bootstrap 5, <select> fields make use of the class `form-select`. This patch aims to replace every occurrence of `form-control` used with select fields. Since Bootstrap finally brings proper styling for select boxes, the custom implementation rendering chevrons can be removed. In the same run, the `input-$size` classes are migrated to its new class names and some obsolete classes have been removed. Resolves: #93135 Releases: master Change-Id: I0044127cc380bddfbaec0b9f730123959f7288bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67247 Tested-by:
-
Torben Hansen authored
The setting $GLOBALS['TYPO3_CONF_VARS']['GFX']['colorspace'] is deprecated since TYPO3 8.0 and is now replaced with $GLOBALS['TYPO3_CONF_VARS']['GFX']['processor_colorspace'] Since the hint now is too long, a manual linebreak has been added to avoid the automatic linebreak which adds a minus char to the processor_colorspace text. Resolves: #92707 Releases: master, 10.4, 9.5 Change-Id: I5f55f01df8af47eca4d32ae8fa9c7262302bf32f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66285 Tested-by:
-
Thomas Pronold authored
Running a clean installation minimal setup throws a lot of "PHP Notice: Undefined index: " notices. This commit removes the ones from the frontend. Resolves: #91116 Releases: master, 10.4 Change-Id: I1f81150ed48ae170682d68d1169c1de2963e0021 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64238 Tested-by:
-
Sebastian Schreiber authored
There is no global variable named REQUEST_TYPE, it is called TYPO3_REQUEST. Releases: master Resolves: #93206 Related: #92947 Change-Id: I86d3c2f8306744f41cfa504f4a42490f4b8eaa6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67330 Tested-by:
-
Jörn Wagner authored
Make all the necessary changes to classes used during the first installation to run on PHP 8 Resolves: #93205 Releases: master, 10.4 Change-Id: I93f64b2848e4cea76a4f36d11d394cb09fd8301c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67227 Tested-by:
-
Benni Mack authored
Because the method (finally) is deprecated in PHP 8, all calls in TYPO3 Core are wrapped in if statements to avoid deprecation warnings. PHP 8 effectively is more secure by default, which is a good thing, but we need to consider this in our code base, which still supports PHP 7 as well. Resolves: #93204 Releases: master, 10.4 Change-Id: I18d7e76e3de5cf48cd4c3cab0d68dea4e518f674 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67329 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Jan 03, 2021
-
-
Georg Ringer authored
By defining `$hreflang` of SiteLanguage to an empty string instead of 'en-US' wrong hreflang tags are avoided in the frontend. Even though the field is set to required there are usecases where this field is not set, e.g. by changing the site configuration manually. This would have lead to hreflang tags pointing to a valid site but with a wrong hreflang information. Resolves: #92418 Releases: master Change-Id: I042c275a2b107cac48a877c7e4043f69e378347d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65888 Tested-by:
-
