- Aug 14, 2024
-
-
Oliver Hader authored
This change allows to disable CSP headers for a particular site configured in `sites/<my-site>/csp.yaml` by using the assignment `enable: false`. Resolves: #104549 Releases: main, 12.4 Change-Id: I9e17b5658610e5d47915a5e45ca6a33a870e8d76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85591 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
- Aug 13, 2024
-
-
Christian Kuhn authored
As last step for PHP 8.4 in CI, the "integration" tests switch from 8.3 to 8.4 in nightlies, while pre-merge are kept with 8.2. Resolves: #104613 Releases: main Change-Id: I8eeda8b5a24250f0776e52a889c8d1166ceb4f24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85617 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Christian Kuhn authored
The hack from #100607 is obsolete with latest versions and can be removed, the patch for 8.4 compat is kept. > composer req enshrined/svg-sanitize:^0.19.0 > composer req 'enshrined/svg-sanitize:^0.19.0' -d typo3/sysext/core --no-update Resolves: #104611 Related: #104604 Related: #103722 Related: #100607 Releases: main Change-Id: I6c9d7f38c86f8d4fdcc3bc6e534b8d4f241e974f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85615 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Thomas Hohn authored
The method BackendUserAuthentication::returnWebmounts() returns an array of strings. This triggers a type error when calling DatabaseIntegrityController::getTreeList() since this method now requires the mountpoint as an integer. In order to keep backwards compatibility a new method BackendUserAuthentication::getWebmounts() has been introduced, which returns an array of integers. Existing calls to returnWebmounts() have been replaced by calls to getWebmounts() and fixes by applying array_map(intval(...) on the result is now superfluous. A follow up issue has been created #104607 to deprecate method returnWebmounts() and to investigate if succesive calls to array_unique can be done in getWebmounts() and removed. Resolves: #104591 Related: #104607 Releases: main, 12.4 Change-Id: I78b2ac3ca891b4144c3b68fd44afb645b875fa6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85586 Reviewed-by:
-
Andreas Kienast authored
The `PreviewController` of EXT:workspaces registers some inline settings for use in JavaScript that are actually not used at all and are therefore removed now. Resolves: #104351 Releases: main Change-Id: I15c1343b95f4fd31f5c8e209bf15bfc23c199a0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85214 Tested-by:
-
Andreas Kienast authored
The JavaScript linter `eslint` is upgraded from v8 to v9. This also requires an upgrade of all `@typescript-eslint` packages. With these, some breaking changes were introduced: * `@typescript-eslint/indent` rule is migrated to `@stylistic` The formating rule `@typescript-eslint/indent` has been extracted to a new package, as `@typescript-eslint` does not want to provide rules for code asthetics anymore [1]. * `@typescript-eslint/no-unused-expressions` is enabled by default eslint detects and reports unused expressions, which is a great thing. Some of our code misused this for shortcut if/else clauses. However, chai.js (the deep down framework used for JavaScript tests) uses this syntax for assertions, therefore the lint rules have been disabled for test files. * `grunt-eslint` requires the newer "flat config" for eslint. The existing configuration has been migrated invoking the command `npx @eslint/migrate-config .eslintrc.js`. Executed commands: npm install --save-dev \ @stylistic/eslint-plugin \ @typescript-eslint/eslint-plugin@^8.0.1 \ @typescript-eslint/parser@^8.0.1 \ @typescript-eslint/typescript-estree@^8.0.1 \ eslint@^9.9.0 \ eslint-plugin-lit@^1.14.0 \ grunt-eslint@^25.0.0 npm run build [1] https://eslint.style/guide/why Resolves: #104601 Releases: main, 12.4 Change-Id: Ic492d0d1dca31b1878c0de97191edf6c33015a2c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85593 Tested-by: -
Andreas Kienast authored
The package `symfony/polyfill-php83` can be upgraded to version 1.30.0, solving deprecations regarding nullable types in PHP 8.4 environments [1]. Executed command: composer update symfony/polyfill-php83 [1] https://github.com/symfony/polyfill-php83/compare/v1.29.0...v1.30.0 Resolves: #104609 Releases: main, 12.4 Change-Id: I0c82a74cde2920d382cbdd8348978786c815c6d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85609 Reviewed-by: -
Andreas Kienast authored
The package `psy/psysh` can be upgraded to version 0.12.4, solving deprecations regarding nullable types in PHP 8.4 environments [1]. Executed command: composer update psy/psysh [1] https://github.com/bobthecow/psysh/commit/2b731c82c0e5b9b36450ce1d4a17f3010c343d91 Resolves: #104610 Releases: main, 12.4 Change-Id: I20a54c5761162f07c4019325a3d02ba09238a8af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85610 Tested-by: -
Andreas Kienast authored
This commit introduces a new component to render progress trackers. Progress trackers are bascially segmented or chunked progress bars, suitable for a chain of tasks, e.g. wizards. Important note: this component is rather experimental by now and may change in a few details. Until further notice, this component is strictly for internal use only. Resolves: #104565 Releases: main Change-Id: I4f3e588033618c178320b36f0a0ff1976718e02f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85499 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
- Aug 12, 2024
-
-
Christian Kuhn authored
Raise a few dependencies and adapt CI matrix. > composer req --dev codeception/codeception:^5.1.2 > composer req --dev codeception/module-webdriver:^4.0.2 Resolves: #104606 Releases: main Change-Id: Ic99135b7387782871686a95a645146a3496dcd20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85602 Reviewed-by:
-
Christian Kuhn authored
Activate PHP 8.4 functional tests in pre-merge and a nightly combination. Similar to unit tests with #104578, we patch another library: enshrined/svg-sanitize. A patch is pending [1], but not yet merged nor released. Codewise its trivial. Some tests need a minor adaption since XML files are created slightly differently with PHP 8.4, the change aligns the fixtures to deal with this. [1] https://github.com/darylldoyle/svg-sanitizer/pull/110 Resolves: #104604 Related: #104578 Releases: main Change-Id: I5d99275aa14d56c35894b270a7f111a50fd56ab7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85592 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Lina Wolf authored
Also apply formatting for the guides.xml Resolves: #104602 Releases: main Change-Id: I880b6f052014ec03771370dbeae0da52536018c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85596 Tested-by:
Chris Müller <typo3@brotkrueml.dev> Reviewed-by:
-
Christian Kuhn authored
sebastian/comparator:6.0.2 got a minor bugfix release changing a detail of assertEqualsCanonicalizing(). Two tests fail when this transitive dependency is raised. We slightly refactor the tests to deal with this. > composer u sebastian/comparator Resolves: #104605 Releases: main, 12.4 Change-Id: I1c7b88d438a9f0a2b596e13e960eed78f484d8bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85600 Tested-by:
-
Andreas Kienast authored
Exeucted commands: npm install --save-dev \ filesize@^10.1.4 \ flag-icons@^7.2.3 \ sharp@^0.33.4 npm run build Resolves: #104595 Releases: main, 12.4 Change-Id: Idad1107f63ec150851574d124125d5ada42d03b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85589 Reviewed-by: -
Andreas Kienast authored
Executed commands: npm install --save \ @codemirror/autocomplete@^6.18.0 \ @codemirror/commands@^6.6.0 \ @codemirror/lang-html@^6.4.9 \ @codemirror/lang-javascript@^6.2.2 \ @codemirror/lang-sql@^6.7.0 \ @codemirror/lang-xml@^6.1.0 \ @codemirror/language@^6.10.2 \ @codemirror/lint@^6.8.1 \ @codemirror/search@^6.5.6 \ @codemirror/state@^6.4.1 \ @codemirror/view@^6.32.0 \ @lezer/lr@^1.4.2 npm run build Resolves: #104594 Releases: main, 12.4 Change-Id: Ie8133aa2093513052051a63af52b3cc92424d08a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85588 Tested-by: -
Benni Mack authored
Resolves: #104584 Releases: main Change-Id: I843974be0360a7a4b610c50abc08f3f396ab8024 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85398 Reviewed-by:
-
- Aug 10, 2024
-
-
Christian Kuhn authored
idn_to_ascii() must not be called with empty string in PHP 8.4. Resolves: #104587 Related: #104513 Releases: main, 12.4, 11.5 Change-Id: I649d157cca3dadbe237e20eb440b071a1885db71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85581 Reviewed-by:
-
Christian Kuhn authored
Brings PHP 8.4 compatibility. Other branches will receive dedicated patches. > composer u typo3/testing-framework Resolves: #104586 Releases: main Change-Id: I7486847df1e9c3f054552f5705be3ebb2aa719da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85580 Tested-by:
-
Christian Kuhn authored
Wait for the drop down to be ready before clicking around on it. Resolves: #104585 Releases: main, 12.4, 11.5 Change-Id: I9fa86d99b02c74bcc0f9efebce8fc4c2f8e54af5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85576 Reviewed-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
-
Christian Kuhn authored
Similar to UnitDeprecated merge into Unit in issue #104582, we merge FunctionalDeprecated into Functional. Resolves: #104583 Related: #104582 Releases: main Change-Id: Ida2943cba0d301b8b30b019c08d49fd98aba3557 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85575 Reviewed-by:
-
- Aug 09, 2024
-
-
Garvin Hicking authored
EXT:styleguide did not contain a showcase for a overrideChildTCA configuration using both columnOverrides or columns to turn for example a "plaintext" input element to "RTE". This case is helpful to also reproduce problems with FormEngine/DataHandler, where possible RTE transformations on save might not be calculated when used as an override. The new distinct "Form engine - inline with child overrideChildTca" type has been added, and "Form engine - file" has a new field "file_6" to showcase an RTE within a type=file inline reference. Resolves: #81893 Releases: main Change-Id: Id36fff2dbb92d84882fed309e029ac465128e6ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85148 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Alexander M. Turek authored
Use Symfony DI attribute AsAlias, AutoconfigureTag, Autowire and AutowireLocator were applicable in ext:core in order to have class and service definition centralized in the class file. Resolves: #104581 Releases: main Change-Id: Id6ae2d7baabf3d4e11063defee8e37599f1120bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85481 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Christian Kuhn authored
Younger phpunit come with a happy little feature to suppress E_DEPRECATED and E_USER_DEPRECATED errors: The attribute `#[IgnoreDeprecations]` makes a test not fail when such a deprecation is triggered by the test subject, even when failOnDeprecation=true is set in phpunit XML. Using the attribute has been recommended by phpunit maintainer Sebastian Bergmann. This allows us to give up on the current strategy of moving tests that test deprecated subjects to an own directory. This simplifies maintenance, makes patches that deprecate things more easy to review, and saves some CI jobs. During 'deprecation removal phase' at the beginning of new major branches, we now simply look up usages of the attribute to see what needs to be removed. The patch takes care of 'UnitDeprecated' tests by merging them back into 'Unit' and adding the attribute. It also adapts runTests.sh to remove the `-s unitDeprecated` test suite and adapts CI. 'FunctionalDeprecated' will follow with a separate patch. Resolves: #104582 Releases: main Change-Id: I44473b04b3fe800a6fdd4032c6b2bd7682810979 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85572 Tested-by:
-
Garvin Hicking authored
Highlight site-specific routing, fix spelling error, add code snippet caption. Resolves: #104580 Releases: main Change-Id: I46527bf93fbf879e1a45e254e72e26f66c397eaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85570 Reviewed-by:
-
Simon Praetorius authored
Currently, the Area object is converted to a JSON string representation implicitly inside the TagBuilder. With newer Fluid versions, this will break because of type hints on addAttribute(). To prevent this, we convert to JSON explicitly before handling the result to TagBuilder. Resolves: #104579 Releases: main Change-Id: I3f9b232a552928f5b8e8a72506046ca3bce9d7c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85569 Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
Christian Kuhn authored
We want to go ahead with PHP 8.4 compatibility and activate unit tests using PHP 8.4 alpha 4 in CI. Dependencies triggered by unit tests are mainly ready and raised already, except firebase/php-jwt: They merged an according patch, but did not release yet [2]. We - for now - composer-patch this dependency in order to focus on PHP 8.4 support in other test suites like functionals, while being backed by green unit tests in CI already. The applied patch is the 8.4 part of firebase/php-jwt PR #572 [1], which has been squashed to dev-main by the maintainers with another commit we had to submit to greenify their CI along the way. CI pre-merge tests now unit test "locked" 8.2 and 8.4, skipping 8.3. 8.3 "locked" is added to nightly instead, along with 8.4 "max". 8.4 "min" is not added since the transitive dependencies 'symfony/string' and 'symfony/cache' are not 8.4 ready in their "min" versions. > composer config --no-plugins --no-interaction allow-plugins.cweagans/composer-patches true > composer config --no-plugins --no-interaction extra.composer-exit-on-patch-failure true > composer config --no-plugins --no-interaction extra.patches-file "Build/patches/patches.json" > composer require --dev "cweagans/composer-patches":"^1.7.3" > composer req firebase/php-jwt:^6.10.1 [1] https://github.com/firebase/php-jwt/pull/572/commits/7c7f4bce5570f9f7f18906ce0082deb4b64f68ee [2] https://github.com/firebase/php-jwt/issues/570 Resolves: #104578 Releases: main Change-Id: I5686ef100571434aad4dfd352742d15028e7b1b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85562 Tested-by:
-
Markus Klein authored
Use the class name as it should be. This only happens if you use aliasing (or similar) functionality in Services.yaml Resolves: #104563 Releases: main, 12.4 Change-Id: I471c6aa7cef09f80c39800f60e37769a1609fba3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85561 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
-
Christian Kuhn authored
Wait for the modal body iframe being there before switching to it. This is mainly an issue in v11 where the modal takes more time server side and webdriver is 'too quick' switching to it. We still sanitize all branches. Resolves: #104577 Releases: main, 12.4, 11.5 Change-Id: Ida09f1945daae3d0fb396f1e495e91ed5042454a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85567 Tested-by:
-
- Aug 08, 2024
-
-
Christian Kuhn authored
Youngest patch levels improve detection and obsolete a baseline entry. > composer req --dev phpstan/phpstan:^1.11.10 Resolves: #104575 Releases: main, 12.4 Change-Id: I8ee69c3be26da678a9ba4e0e972769e958b95b43 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85563 Tested-by:
-
Stefan Bürk authored
With #102875 Doctrine DBAL has been upgraded to the Doctrine DBAL v4 major version, which introduced additional schema normalizations along other changes that allow to drop legacy code. The code got removed with #104573, but still left ENUM and SET types in a broken state. The custom platform option transporting the ENUM or SET field values was not removed before creating a column within one normalization method. Doctrine DBAL does not know the option and throws an `Doctrine\DBAL\Schema\Exception\UnknownColumnOption` exception. This change now splits the custom platform option and delivers the new column object correctly, mitigating the Doctrine exception. Adding tests revealed that ENUM and SET types are not cross database compatible, which also affects TYPO3 v12 and is adressed by a POC fix [1]. To honor this, ENUM and SET type implementations received `@todo` comments to properly deprecate and remove these implementations in dedicated patches (with added complexity due to handling issues). [1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/85557 Resolves: #104413 Related: #104573 Related: #102875 Releases: main Change-Id: I05fd10929b94ec60e23ca4467239b4eba05926bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85558 Tested-by:
-
Stefan Bürk authored
With #102875 Doctrine DBAL has been upgraded to the `Doctrine DBAL v4` major version, keeping the column comparison from Doctrine DBAL 3. This was done by cloning the old DBAL code into the TYPO3 Core's `Comparator`, waiting for several issues with comparisons to be mitigated. A series of pre-patches now allows to remove the old code and switch to `AbstractPlatform::columnsEqual()`, using the native Doctrine DBAL v4 implementation with schema normalizations. This change now removes these `Comparator` methods: * columnsEqual() * doctrineDbalMajorThreeDiffColumn() * typo3DiffColumn() Resolves: #104573 Related: #104571 Related: #104568 Related: #104567 Related: #102875 Releases: main Change-Id: I64cd3ae10179134344f28be7dbdc791c78812475 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82789 Reviewed-by: -
Stefan Bürk authored
Doctrine DBAL 4 has been introduced with #102875. The new version required additional normalization in `ConnectionMigrator`, implemented via #104571, #104568 and #104567. This kept an intermediate method calling the new normalization chain and contained table index normalization. This change moves the index normalization into a dedicated method and adds it to the central table loop. Resolves: #104572 Related: #104571 Related: #104568 Related: #104567 Related: #102875 Releases: main Change-Id: I90146295d48e49166cd9e8f05755a5c048d33047 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85555 Tested-by:
-
Stefan Bürk authored
With #102875 Doctrine DBAL has been upgraded to the `Doctine DBAL v4` major version, keeping the column comparison from Doctrine DBAL 3 by cloning the old code into the TYPO3 Core `Comparator` until compare issues have been mitigated. Changes #104567 and #104568 already mitigated some of these comparison failures using the new method `AbstractPlatform::columnsEqual()` for compare. This change prepares the switch to Doctrine DBAL 4 by ensuring default values for DecimalTypes are normalized. This matches how MySQL/MariaDB reports them based on the scale setting. This can be tested by manually removing `columnsEqual()` from `\TYPO3\CMS\Core\Database\Schema\Comparator`, which resolves the remaining "failed" changes in the clean database schema test `CleanSchemaMigrationForAllSystemExtensionTest` Resolves: #104571 Related: #104568 Related: #104567 Related: #102875 Releases: main Change-Id: I6a09d53e5e41409ee2a3ae3736e9c8ac01fcfa65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85553 Tested-by: -
Stefan Bürk authored
The doctine/dbal integration has been raised to v4 with #102875, but still using the Doctrine DBAL v2 way for comparing columns in the extended `Comparator`. This kept some special treatments which needed to be applied on the Virtual Database Scheme AND on the actual database schema representation. This change moves the special treatment for MySQL and MariaDB on BlobType and TextType based columns regarding length comparison from the TYPO3 `Comparator` into the TYPO3 `ConnectionMigrator`, performing normalization on both schema representations now. The normalized length does not have an impact on the raw comparison anymore with the Doctrine DBAL 4 `AbstractPlatform::columnEqual()` check. It is still needed to allow Doctrine determine the correct type based on that length for the column-type SQL generation. This change is one more step towards removing the Doctrine DBAL v3 compare-handling from the `Comparator` and further changes will be streamlined to reach removal of legacy code. Resolves: #104568 Related: #102875 Releases: main Change-Id: I7094f73acb99c112ac8543c4832ec5127c7dfaf8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85552 Tested-by:
-
Christian Kuhn authored
The extbase ConfigurationManager is - even after various refactoring loops - still an anti pattern: This is a stateful singleton initialized by extbase bootstrap with state, and it can be injected into arbitrary classes. This patch still does not solve the root of this issue: It is still unclear on how to solve it. The patch however now makes the two "worker" classes stateless: Both the "concrete" implementation classes FrontendConfigurationManager and BackendConfigurationManager. This strategy bundles the ConfigurationManager flaws into one class now. The patch also moves an access to $GLOBALS['TYPO3_REQUEST'] out of __construct(), which allows us to deprecate this call with an upcoming patch. Note there is also TYPO3\CMS\Extbase\Service\ExtensionService, which is *another* stateful injectable singleton, that works on ConfigurationManager - #messDoesNotEndHere Resolves: #104514 Releases: main Change-Id: I5ef864b116fdbe285a64bdf60175fa0ad6fc780a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85384 Reviewed-by:
-
Stefan Bürk authored
If columns do not specify column `collation`/`collate` or `charset`, databases determine them using a fallback chain looking into table defaults, schema defaults and then server defaults. Reading schema information from the database retrieves these information on column level directly which makes a strict comparision impossible which Doctrine DBAL 4 wants to use and which has been disabled during the upgrade using the Doctrine DBAL 3 way. To prepare towards enabling the Doctrine DBAL 4 column compare way, this change ... * applies the connection `defaultTableOptions` to columns on the TYPO3 virtual schema for `MySQL` and `MariaDB`. * applies `collation BINARY` for `StringType`, `TextType` and `JsonType` columns for SQLite. This can be tested by removing the `columnsEqual()` method from `\TYPO3\CMS\Core\Database\Schema\Comparator`, which reduces the "failed" changes in the clean database schema test `CleanSchemaMigrationForAllSystemExtensionTest`. Except for MySQL/MariaDB where to two decimal field failures still be found and which will be addressed in dedicated patch. Resolves: #104567 Related: #102875 Releases: main Change-Id: I7e36144611a24be770c42d5c0ebdf05100e578ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85551 Reviewed-by:
-
Willi Wehmeier authored
Avoid fetching and redrawing the record overview table when the search term input field gets focussed. This prevents breaking the ui state and unwanted deselecting of rows. Resolves: #103802 Releases: main, 12.4 Change-Id: I3ff0f478e1a91a1a785f7093b26d1bf610dac921 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84176 Tested-by:
-
- Aug 07, 2024
-
-
Georg Ringer authored
Moves require statements into a custom method to avoid clashes with local variables. Resolves: #104509 Releases: main, 12.4 Change-Id: I632be874a18787cd75b0a6ff326f57a185a116be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85501 Tested-by:
-
Garvin Hicking authored
If an invalid record in `sys_be_shortcuts` is stored like this: ``` INSERT INTO sys_be_shortcuts (userid,route,arguments) VALUES (1,'record_edit','[]'); ``` then the backend cannot be accessed anymore due to PHP errors due to unguarded array key access of the "arguments" contents. This patch guards the array key access to prevent such a situation, so an invalid shortcut can be deleted from the menu. Database records like this might happen for migrated older installations. Resolves: #104496 Releases: main, 12.4, 11.5 Change-Id: I350e620eb403e53d1828cf5dedaab633ba00db55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85548 Tested-by: -
Garvin Hicking authored
As a follow-up to #104074, the directory "typo3conf" is no longer required to store the `LOCK_BACKEND` file. A new configuration option TYPO3_CONF_VARS[BE][lockBackendFile] is added alongside a distinct `BackendLocker` service class to indicate where the backend lock and unlock commands store their lockfile. By default this uses `var/lock/` for composer mode, and `config/` for legacy installations as a fallback for when the setting is empty (default). Resolves: #104126 Related: #104074 Related: #104119 Releases: main Change-Id: I1fdbd48434c2c6cfd0a6617a1be71ac21195a8e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84729 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
