- Aug 13, 2024
-
-
Oliver Hader authored
Change-Id: I75549bf18ee2714a478d832a72b8a79d01fc9f61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85606 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Aug 12, 2024
-
-
Andreas Kienast authored
Exeucted commands: npm install --save-dev \ filesize@^10.1.4 \ flag-icons@^7.2.3 \ sharp@^0.33.4 npm run build Resolves: #104595 Releases: main, 12.4 Change-Id: Idad1107f63ec150851574d124125d5ada42d03b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85598 Tested-by:core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
-
Andreas Kienast authored
Executed commands: npm install --save \ @codemirror/autocomplete@^6.18.0 \ @codemirror/commands@^6.6.0 \ @codemirror/lang-html@^6.4.9 \ @codemirror/lang-javascript@^6.2.2 \ @codemirror/lang-sql@^6.7.0 \ @codemirror/lang-xml@^6.1.0 \ @codemirror/language@^6.10.2 \ @codemirror/lint@^6.8.1 \ @codemirror/search@^6.5.6 \ @codemirror/state@^6.4.1 \ @codemirror/view@^6.32.0 \ @lezer/lr@^1.4.2 npm run build Resolves: #104594 Releases: main, 12.4 Change-Id: Ie8133aa2093513052051a63af52b3cc92424d08a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85599 Tested-by:
-
- Aug 08, 2024
-
-
Christian Kuhn authored
Youngest patch levels improve detection and obsolete a baseline entry. > composer req --dev phpstan/phpstan:^1.11.10 Resolves: #104575 Releases: main, 12.4 Change-Id: I8ee69c3be26da678a9ba4e0e972769e958b95b43 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85564 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Willi Wehmeier authored
Avoid fetching and redrawing the record overview table when the search term input field gets focussed. This prevents breaking the ui state and unwanted deselecting of rows. Resolves: #103802 Releases: main, 12.4 Change-Id: I3ff0f478e1a91a1a785f7093b26d1bf610dac921 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85559 Tested-by:
-
- Aug 06, 2024
-
-
Christian Rath-Ulrich authored
The heading structure in the "Dashboard" backend module has been updated and a hidden h1 has been added. Additionally, role attributes have been added to various elements. Resolves: #104070 Releases: main, 12.4 Change-Id: I852ae244ecc399129e99be43f3e9cd58012c9dcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85461 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Andreas Kienast authored
Executed command: npm audit fix Resolves: #104551 Releases: main, 12.4 Change-Id: I44ead5b72e8cba08da196210e4a5eb7d05a1aed4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85514 Tested-by: -
Andreas Kienast authored
The previous implementation of notification tests relied on real browser timeouts, artifically slowing down their execution (roughly 11 seconds). Sinon (the stub library we use) provides API to mock several timing functions (e.g. `setTimeout()`) which can be incorporated for most cases. There's one caveat tho: notifications are visually hidden with an animation that executes for 400 ms and get removed from DOM after that. Sinon cannot mock timings for CSS-driven animations. To workaround this, a new event is introduced that is usually triggered after animation has ended. This reduces the runtime of the affected test from ~11 seconds to ~1.2 seconds. Resolves: #104553 Releases: main, 12.4 Change-Id: Iffd662e0ce9a87332a65ca50fb5ecb17623c764f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85529 Tested-by:
-
Christian Rath-Ulrich authored
The login screen can now be scrolled and is therefore usable even at larger zoom values. In addition, the currently-focused link elements are now highlighted. Resolves: #104405 Related: #92945 Releases: main, 12.4 Change-Id: If75b051a247bdd1b41031bf6956b90dc5cfb97d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85528 Reviewed-by:
-
Andreas Nedbal authored
Since the file upload button shows the dialog directly it is not necessary to also show the dropzone behind it. This also solves the problem of the dropzone staying visible when a user decides to not upload any file and cancelling the file dialog. Resolves: #101197 Releases: main, 12.4 Change-Id: I33b8c73582c19c94927187e26bf4513d1a1d6e07 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85527 Tested-by:
-
- Aug 01, 2024
-
-
Georg Ringer authored
With the CKEditor5 unbundling in #102099, we can now ship free (GPL-2 licensed) CKEditor5 modules, that may be useful, for some installations, without the need to ship them for all installations in a big bundle. npm install --save \ @ckeditor/ckeditor5-highlight@41.4.2 \ @ckeditor/ckeditor5-language@41.4.2 \ @ckeditor/ckeditor5-mention@41.4.2 npm run build Releases: main, 12.4 Resolves: #101128 Related: #102099 Related: #99670 Change-Id: Ic7b88985c64c59c65ee8502e50d74c3206636893 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85452 Tested-by:Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Jul 25, 2024
-
-
Stefan Bürk authored
This change raises the core-testing-php84 image version to use PHP 8.4.0 alpha2. [1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/abd0b88dd70d0053359b08584d66df17540f177d Resolves: #104480 Releases: main, 12.4, 11.5 Change-Id: Ife69d5fdb82f4243547fab5998b4a1ba0123bafc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85356 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Christian Kuhn authored
phpstan "bleeding edge config" enables a feature that reduces memory usage significantly. We don't switch to "bleeding edge" per se, but enable that single toggle for now. phpstan does not do this by default since it may be breaking for existing rules, which is not a problem in our case. > rm -rf .cache/phpstan/; Build/Scripts/runTests.sh -s phpstan Before locally: 10.99 GB After locally: 5.82 GB Before CI: 15.15 GB After CI: 9.49 GB Numbers vary depending mainly on available number of CPUs: My local machine has less CPUs than CI - we *may* tune phpstan a bit further in this area, later. Resolves: #104476 Related: #104475 Releases: main, 12.4, 11.5 Change-Id: I32ca9a36b752ad52e8ac5fd433c3f929f86843af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85377 Reviewed-by:
-
Christian Kuhn authored
phpstan can be very memory hungry. Option --verbose adds a line about 'peak memory' usage to the output. Add this to get a better feeling of the memory usage. Resolves: #104475 Releases: main, 12.4, 11.5 Change-Id: I3fdaf7ddee7e003e7a8e75a508dd69161c804c8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85353 Reviewed-by:
-
- Jul 24, 2024
-
-
Andreas Kienast authored
This commit updates the package `requirejs` to version 2.3.7 to fix a prototype pollution vulnerability [1]. [1] https://github.com/requirejs/requirejs/compare/2.3.6...2.3.7 Resolves: #104459 Releases: 12.4, 11.5 Change-Id: I73a62c7e4e715954db5802d0a46d5758c407ac7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85334 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
- Jul 19, 2024
-
-
Stefan Bürk authored
Resolves: #104435 Releases: main, 12.4, 11.5 Change-Id: I5ff37f97f0d0a71420839c4d2b1bf8bde70afa7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85205 Tested-by:
-
Stefan Bürk authored
This change adds the predefined GitLab CI/CD variable `CI_JOB_ID` value to the suffix, used for containerized network and container names, with the goal to increase uniqueness in CI runs. Additionally, the value is now displayed in execution and the container cleanup notes at least the network name further information source to investage unusually container shutdowns. [1] https://docs.gitlab.com/ee/ci/variables/predefined_variables.html Resolves: #103928 Releases: main, 12.4, 11.5 Change-Id: I6cf8dddefd2b45ed6f5c8cca8aa5521319cc8c4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85301 Reviewed-by:
-
Andreas Kienast authored
Historically, FormEngine UI mangles dates from one format to another and feeds the result back to the date picker, crossing fingers nothing goes wrong. This bites hard when it comes to non-standard date formats, basically everything but `d-m-Y`. To lay the groundwork on tackling the date format issue, FormEngine now always works with ISO8601 dates internally, allowing to get rid of some helper methods. Resolves: #104309 Releases: main, 12.4 Change-Id: Iafac126f8f02b6dba6f2623f1e7790c6c6fb9bb4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85243 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
- Jul 18, 2024
-
-
Ayke Halder authored
This patch corrects the misusage of anchor elements instead of buttons for controlling sortable selects. In addition we are adding the existing labels to the buttons to support visually impaired users. Resolves: #104414 Related: #102783 Releases: main, 12.4 Change-Id: If80f62db06bda61250d09bc4727a7ec708f02757 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85282 Tested-by:
-
- Jul 15, 2024
-
-
Benjamin Franzke authored
Do not listen on the livereload port, as we do not ship the client-side[1] livereload integration anyway. This allows multiple grunt-watch (e.g. main and 12.4) to run in parallel instead of blocking each other because they try to allocate the same port. [1] https://github.com/gruntjs/grunt-contrib-watch/blob/main/docs/watch-examples.md#enabling-live-reload-in-your-html Resolves: #104390 Releases: main, 12.4, 11.5 Change-Id: I36f37178e1752015033d5b0f2746c49b2477c1a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85200 Tested-by:
-
- Jul 12, 2024
-
-
Christian Kuhn authored
PHP 8.4 linting is fine already. Let's add it to CI jobs. Resolves: #104386 Releases: main, 12.4, 11.5 Change-Id: Ie64f602aace5d816ae80ce502bdf054dde7b787a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85252 Tested-by:
-
Oliver Bartsch authored
When using boolean attributes there are two things to consider: 1. The default value must be FALSE 2. Presence of the attribute always means TRUE It's therefore not possible to have a boolean attribute, which defaults to TURE and it's also not possible to set an attribute to FALSE via its value (e.g. "0" or "false). See for reference: https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#boolean-attributes Therefore, to properly handle the "is writeable" state in the language packs module, the default is set to FALSE an the attribute only gets added (which defines the TRUE state) in case corresponding data attribute is set in the template. Resolves: #104353 Releases: main, 12.4 Change-Id: I82f440ae4fbeba405c35bbfa859804e2bc0660c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85239 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Jul 10, 2024
-
-
Andreas Kienast authored
The flatpickr integration in TYPO3 is configured to use luxon for date time formatting operations, which consumes different format tokens. This leads to the situation that aria labels generated by flatpickr are now broken. This commit changes the option `ariaDateFormat` to luxon's `DDDD` token, which renders a "localized date with full month and weekday", according to [1]. [1] https://moment.github.io/luxon/#/formatting?id=table-of-tokens Resolves: #104342 Releases: main, 12.4 Change-Id: I7902d39209ad59e0c3196db7f906b93533d7b7cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85192 Reviewed-by:
-
- Jul 09, 2024
-
-
Andreas Kienast authored
The date time picker module `@typo3/backend/date-time-picker` uses flatpickr, but wasn't aware of it due loose `any` usages. The code is modified to make use of the typings shipped with flatpickr. To solve this long-standing issue, the module identifier is changed from `flatpickr/flatpickr.min` to `flatpickr`, which requires an additional entry in the `JavaScriptModules.php` configuration, but allows to remove a module declaration. Resolves: #104338 Releases: main, 12.4 Change-Id: I3feed53627c639e21e4812855fd4ce2defe91c14 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85188 Reviewed-by:
-
Stefan Bürk authored
This change adds PHP8.4 as allowed version to the `Build/Scripts/runTests.sh` script as preparation to validate and check the Core and 3rd party libs with PHP8.4 locally. Note that unit tests already revealing deprecation and errors for 3rd party extension which can now be reported and for checked upstream updates. Resolves: #104337 Releases: main, 12.4, 11.5 Change-Id: I76d3e37b393c347173fcdbe874d6a0737fb76d33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85179 Tested-by:
-
Oliver Hader authored
Change-Id: I72e06646233894cfbd8017bef8a5620e17caf32a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85174 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Oliver Hader authored
Change-Id: I20500c48221bf14b56baef7551a423571883c6a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85173 Reviewed-by:
-
Andreas Kienast authored
This commit fixes the event binding on the "Close" action to trigger the correct actions when e.g. the icons within the buttons are clicked. Resolves: #104333 Releases: main, 12.4 Change-Id: I448c0b68de376a1b0e8517cc58c5bf2d2576b662 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85172 Tested-by:
-
- Jul 08, 2024
-
-
Georg Ringer authored
Version 7.15 officially supports TypeScript 5.5, which we use since #104189 and therefore eliminates a build-time warning. Also update TypeScript from 5.5.2 to 5.5.3, while at it. Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.15 \ @typescript-eslint/parser@^7.15 \ @typescript-eslint/typescript-estree@^7.15 \ typescript@^5.5.3 npm run build-js Resolves: #104317 Related: #104189 Releases: main, 12.4 Change-Id: Ibe242b42ecf9c5e986217a85283174220ae18bc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85151 Tested-by:
-
- Jul 02, 2024
-
-
Stefan Bürk authored
This change modifies the `php-cs-fixer` ruleset and activate two rules related to nullable types. Following options are added: 'nullable_type_declaration' => [ 'syntax' => 'question_mark', ], 'nullable_type_declaration_for_default_null_value' => true, `nullable_type_declaration` ensures to use `?<type>` declaration instead of union type `<type>|null` as a convention for properties, method and return types. For already union types the nullable is added as additional null union type `ObjectOne|ObjectInterface|null`. `nullable_type_declaration_for_default_null_value` ensures to use nullable type declarations to mitigate implicitly nullable method arguments [1] which has been already fixed with a series of dedicated changes. Used command(s): Build/Scripts/runTests.sh -s cgl [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #103751 Releases: main, 12.4, 11.5 Change-Id: Ia790a6757c5fbe9...
-
- Jul 01, 2024
-
-
Garvin Hicking authored
When multiple crop variants are defined (for example in EXT:styleguide "Form engine elements - imageManipulation" for "crop_5" with "mobile" and "desktop), the currently selected aspect ratio and the size of the cropping box was only computed based on the first crop variant. This patch uses a wrapping container for each variant and adjusts the JavaScript to operate on that context. The information for the current cropping box size is now also based on this context. Resolves: #103879 Releases: main, 12.4 Change-Id: I38e235ddb5ed5f7463a5f0931608944326097f9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84963 Tested-by:
-
Stefan Bürk authored
Apply the latest rules of php-cs-fixer for both fixer (code and header-comment) also in the `Build/Scripts` folder. The Build folder is now added to the usual php-cs-fixer execution for code and header fixer scripts to avoid code style drifitng in this folder for the future. Used command(s): Build/Scripts/runTests.sh -s cgl ; \ Build/Scripts/runTests.sh -s cglHeader Resolves: #104274 Releases: main, 12.4, 11.5 Change-Id: I7977e2254b9e271c45b840c6696cd7600ab0b1aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85035 Reviewed-by:Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Jun 28, 2024
-
-
Torben Hansen authored
With symfony property-info 7.1.2, the type resolving for collections has been hardened. https://github.com/symfony/property-info/commit/d0bbc495f11ab99a1e2cbf04699331b88b3c1293 Our extbase ObjectConverter test for collections uses an anonymous class with an ObjectStorage property. The annotation for the property as well as the native property type is however not a FQCN. So the anonymous class has no information about, what FQCN the `ObjectStorage` class is. The change adds the FQCN for the ObjectStorage in the anonymous class, which resolves the failing test, and adds a test with a non-anymous class to test short namespaces still work. Resolves: #104254 Releases: main, 12.4, 11.5 Change-Id: Idc64e2533e0bc6d2dccc9724643247772f4f5d11 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85001 Tested-by:
-
Christian Kuhn authored
Resolves: #104249 Releases: main, 12.4 Change-Id: I2e56c967ab27ddc855261ff53f654d5916f3dce6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84999 Reviewed-by:
-
Oliver Bartsch authored
Some FormEngine related JS components, e.g. the slug element rely on input and text fields to have the field name set via either the special `data-formengine-input-name` - if pointing to a hidden input field - or via the standard `name` attribute. All those FormEngine elements support the readonly state, which renders only the field with the `disabled` attribute set by omitting any JS functionality. For this use case no `name` attribute is required. However, to use them in combination with other fields, e.g. as generator field for TCA type slug, the field name is now added as `name` attribute in readonly state. Resolves: #104178 Releases: main, 12.4 Change-Id: Ibd28c563c8184078805a64aa123f86d538077180 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84959 Reviewed-by:
-
- Jun 27, 2024
-
-
Georg Ringer authored
Resolves: #104216 Releases: main, 12.4 Change-Id: Ifbd5499fe8c50661cec4ec198b479978bd839084 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84949 Tested-by:
-
- Jun 26, 2024
-
-
Georg Ringer authored
Apply the latest rules of cs-fixer also on the Build directory Resolves: #104227 Releases: main, 12.4 Change-Id: Ief38397cb0870e358caa43ca505f04fbb89a86c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84851 Tested-by:
-
- Jun 25, 2024
-
-
Stefan Bürk authored
This change modifies the `Build/Scripts/runTests.sh` dispatcher script to add new database version. Added versions: * MySQL 8.4 * MariaDB 11.2 * MariaDB 11.3 * MariaDB 11.4 Note that for TYPO3 v12 and v11 also missing versions up to these are added now. This is not a official supported version statement. [1] https://endoflife.date/mariadb [2] https://endoflife.date/mysql [3] https://endoflife.date/postgresql Resolves: #104200 Releases: main, 12.4, 11.5 Change-Id: I338a7f0973a46fb8bc6a582a5c478c4715a8000e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84894 Reviewed-by:
-
Stefan Bürk authored
This change modifies the `Build/Script/runTests.sh` command dispatcher to allow passing composer options to the `composer install` subcommand, for example Build/Scripts/runTests.sh -s composerInstall \ -- --prefer-source Note that this is already possible using the generic `-s composer` dispatcher but would resolve some user confusion. This is useful to install dependencies as git checkouts, for example when working on packages like `typo3/testing-framework` changes. Albeit the need to remove the vendor folder first is needed in case of the example. Resolves: #104186 Releases: main, 12.4, 11.5 Change-Id: Id07c90f3b6902ad8866249563eceeb2dafbc919b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84844 Tested-by:
-
- Jun 24, 2024
-
-
Marcin Sągol authored
The `typo3-backend-icon` component code contains a duplicated code fragment. This patch removes one occurrence. Resolves: #104199 Releases: main, 12.4 Change-Id: I0530f89f646c5c2fda8a170f3792a28a2c04243d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84840 Tested-by:
-
