This reverts commit de4811fc

This is not in line with the rest of the backend yet.
The "UX vision" is for after 6.2.

Change-Id: Iab8880163b0cb668237617b1260b4126b16d1cb3
Reviewed-on: https://review.typo3.org/27306
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

This reverts commit 590f76cc

This is not in line with the rest of the backend yet.
The "UX vision" is for after 6.2.

Change-Id: Iabb64ac3a278a3a3e1423283a9267aa5996343f1
Reviewed-on: https://review.typo3.org/27307
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

Removes share font from buttons. The current font does
not render adequately.

Change-Id: I8d2a998275e52fbb831abb9046f3711e82acc401
Resolves: #55624
Releases: 6.2
Reviewed-on: https://review.typo3.org/27301
Tested-by: Markus Klein
Reviewed-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

In the package dependency resolver, the method
buildDependencyGraph builds the dependency graph
first for the framework packages and afterwards
for all left packages.

The filtering if a package is a framework package
happens by comparing the package path with PATH_typo3
and a sysext folder contant. But as PATH_typo3 is
absolute and the package path from the package states
configuration is relative to PATH_site, this filter
does not work.

The patch changes the path to a relativ one.

Fixes: #55623
Releases: 6.2
Change-Id: I2f57dee433054463ebfd17aab5f76b19986c2747
Reviewed-on: https://review.typo3.org/27300
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Styles all buttons in the backend similar to UX vision paper.
Inverts buttons colors and changes font-family.

This patch does not bring styling to primary button: orange
or secondary button: silver.

Change-Id: I273e76a02083aedca4c6759948172b418e990ede
Resolves: #55592
Releases: 6.2
Reviewed-on: https://review.typo3.org/27265
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Marcin Sągol
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Unify form input fields with TCE forms input fields with
TCE forms readOnly text.

Change-Id: If17a9477bcedad33745b5e093b338472365a81cf
Resolves: #55599
Releases: 6.2
Reviewed-on: https://review.typo3.org/27269
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

Since the introduction of FAL the option to upload a file
directly in your form has disappeared.

With this change the upload posibility is back with some extras.
* progress is shown
* drag&drop of files
* multiple file upload

The options is can be disabled just like before in the
user settings and for each field in TCA.

foreign_selector_fieldTcaOverride.config.appearance.fileUploadAllowed = 0

The upload button is only shown for browsers that support
drag&drop upload. And only for FAL fields (sys_file_reference).

Resolves: #55545
Releases: 6.2
Change-Id: I4b984099095d7f66c3d37023cd6c547b2ff5d59f
Reviewed-on: https://review.typo3.org/27237
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

When loading tt_content as an inline record WITHOUT using AJAX,
some additional broken fields are rendered.

Change-Id: Ia5aaec79d0fb7c3266ea4f3a0c04d65b1af4b201
Fixes: #39048
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/12904
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Add a migration function to the SilentConfigurationUpgradeService which
takes care of migrating the old class names used for the Install Tool
Upgrade Wizard's information storage to the new (namespaced) class names.

Resolves: #54457
Releases: 6.2
Change-Id: Ib6edb9ec3a8a1dc4873eb38e9a08bc8107db31bb
Reviewed-on: https://review.typo3.org/26451
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

The EM has a lot of code related prior to
the inclusion of package management.

This change does a small cleanup in
ListUtility and calling code to make
better use of the new API.

Resolves: #55562
Releases: 6.2
Change-Id: I7aa5f5204ed3552fec617f2cd9e65dac2009486f
Reviewed-on: https://review.typo3.org/27239
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Tabmenu so far used mouseOver/mouseOut to set CSS-classes.
This is replaced with :hover functionality.

Change-Id: Ie62c017bca7bf26b1d48f1ae02ebab45090f3263
Resolves: #55600
Releases: 6.2
Reviewed-on: https://review.typo3.org/27270
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

When invalid credentials are entered in the Backend login form, various
PHP warnings are raised such as

    PHP Warning: Illegal string offset 'uid'

because $user is not an array.

Resolves: #55434
Releases: 6.2, 6.1
Change-Id: I62b85816ce04720ed9fd236965c3a6f55effd093
Reviewed-on: https://review.typo3.org/27126
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

extbase BaseTestCase extends core BaseTestCase and overrides
inject() with a duplicate. Remove dupe.

Change-Id: I96ce01c9754ce57cb5d10e9a322a8c5acb950647
Resolves: #55606
Releases: 6.2
Reviewed-on: https://review.typo3.org/27272
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The default lifetime for the cache_pagesection is not set, so the
overall default of 3600 is used. This leads to the information in there
being repeatedly generated, though it does seldom change (it only
consists of information in the rootline, TypoScript configuration,
conditions etc.). Therefore, the lifetime is increased by this patch
again to 30 days. The cache is cleared nonetheless when clearing "all
caches".

The default lifetime for this cache was unlimited prior to the
introduction of the caching framework.

Change-Id: I98b307f11779174110ea2d5d79027771b44c5098
Resolves: #39295
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/27228
Reviewed-by: Ingo Schmitt
Tested-by: Ingo Schmitt
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Oliver Klee
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

Resolves: #55603
Releases: 6.2

Change-Id: I27efb6d19f580eba455cde92dd76628f72dce536
Reviewed-on: https://review.typo3.org/27271
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Removes excessive top margin above Web>Page backend layout
cells. Brings gridCells equal heights and bottom spacing. Replaces
full white borders with adequate margins.

Change-Id: Ic5e7d3279c4facd969f171280d881b5620df4be7
Resolves: #55150
Related: #39971
Releases: 6.2
Reviewed-on: https://review.typo3.org/26936
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Integrate the definition of packages that should be activated at
first installation and packages that are required for a minimal
usable system in the package manager.

There are now three possible properties in Classes/Package.php:

* protected - Package can not be uninstalled in em.
* partOfFactoryDefault - Package is activated at first installation.
* partOfMinimalUsableSystem - Package is activated if
  PackageStates.php is missing. extensionmanager and t3skin are
  affected here, if PackageStates.php is deleted, the install tool
  will create a new one with those packages activated, so the backend
  is "usable" enough to activate further packages.

Resolves: #53988
Releases: 6.2
Change-Id: I4f5d3f0a7d3bcf332d1e8e6c29156f93bae8029c
Reviewed-on: https://review.typo3.org/27226
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Brings button style to "Download" link with download icon.

Change-Id: I4edae8b861d9c6f98f156d8b538031dd8ca8f62c
Resolves: #55597
Releases: 6.2
Reviewed-on: https://review.typo3.org/27267
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Brings an icon for download action. Icon is based on the
action-edit-upload sprite icon.

Change-Id: I4327c85c14dea3b69d8184259c5ac8729396d2e8
Resolves: #55594
Releases: 6.2
Reviewed-on: https://review.typo3.org/27266
Reviewed-by: Cedric Ziel
Tested-by: Cedric Ziel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Moves definitions to CSS/structure.
Also fixes right margin for a.t3-button.

Change-Id: Ib51e8b7e3c11e0a4cf474b6322aaeaed11c63b55
Resolves: #55588
Related: #55539
Releases: 6.2
Reviewed-on: https://review.typo3.org/27260
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

This change-set adds new functional tests for the DataHandler
to ensure the correct behaviour in the Live Workspace. The
difference to current functional tests is, that here a more
complete picture is checked in the database instead of only
particular ids and values.

The tests use a DataSet, which is basically only a CSV file
that hold the record values for required tables. These CSV
files can easily be modified by any spreadsheet application.
The "Scenario" DataSets are used to define the scenario each
test case is based on - the "Assertion" DataSets are used to
acutally assert that the correct processing was done in
the DataHandler.

Resolves: #54855
Releases: 6.2
Change-Id: I5d748cde04a70b9c158d09f9a0bd337ef809fd02
Reviewed-on: https://review.typo3.org/27188
Reviewed-by: Peter Kuehn
Tested-by: Peter Kuehn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Before FAL a default upload folder has been retrived by setting
$GLOBALS['TYPO3_CONF_VARS']['BE']['fileadminDir'] . 'user_upload'.
With FAL this even could be placed on a remote system. Furthermore
we do not won't users to fiddle around with path like that anymore.

Each Storage already provides "getDefaultFolder" meant for uploads.
But still, if there are several storages, there is no way to figure
out which storage should be the default one for uploads, if it is
legacy code or just not configurable.

This patch introduces the concept of a default storage as a flag
which can be set within the storage record. The automatic creation
of /fileadmin/ - storage will have this flag already set.

Resolves: #55177
Releases: 6.2
Change-Id: I6684670c5acb023bc26596e9a55ca84bb5c41b40
Reviewed-on: https://review.typo3.org/26945
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

Adds taller tree icons to EXT:t3skin and put them into a new
sprite category "treeline".

This allows to use these icons without breaks in line-height of 1.5em.

Icons are 30px tall due to:

- line height: 18px = 12px * 1.5em
- Padding top+bottom: 12px = 6px * 2

Change-Id: I8a295dbf55b6847e89250c9c221259386aa362e6
Resolves: #52599
Related: #52501
Related: #49592
Releases: 6.2
Reviewed-on: https://review.typo3.org/24474
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Allow the max items evaluation for checkboxes by setting the
accordant 'eval' property in the field configuration in TCA.

This makes it possible to have only e.g. 5 records that have a
checkbox set system-wide or PID-wide. If an editor
sets a another checkbox in record #6, it gets reverted
until another record was unchecked.

Parameters are "maximumRecordsChecked" and
"maximumRecordsCheckedInPid".

$tcaFieldConf = array(
'type' => 'check',
'eval' => 'maximumRecordsChecked',
'validation' => array(
 'maximumRecordsChecked' => 5
)
);

Change-Id: Ic33571fec15dcc9f83a61e2409256cce7dae8b12
Documentation: #55188
Resolves: #55187
Releases: 6.2
Reviewed-on: https://review.typo3.org/26946
Reviewed-by: Ingo Schmitt
Tested-by: Ingo Schmitt
Reviewed-by: Frans Saris
Tested-by: Frans Saris

The parameter $language in extbase's custom statement is not
used anywhere and does not make any sense in use with dbal.

Releases: 6.2
Resolves: #55580
Change-Id: I9c7edda24918b328da66872ef782a6d0e83b0fff
Reviewed-on: https://review.typo3.org/27258
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Stefano Kowalke
Tested-by: Stefano Kowalke
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel

Currently the property mapper uses the classnames found
in the the class property annotations to find the right
TypeConverter. But for class aliases this breaks as the
alias is used and not the original classname.

There was already a getClassNameForAlias call but this was
to early.

This change moves the getClassNameForAlias() call from
doMapping() to findTypeConverter().

Releases: 6.2, 6.1
Resolves: #54289
Change-Id: Ie4ab3deb3c192290db62ea06826870d2fadba8a7
Reviewed-on: https://review.typo3.org/26578
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Value "maxitems" => 1 must be added to field
`metadata` since it has a one-to-one relation.

Change-Id: Ie8771809b952e3b2aa441fcb222a6a3db301655e
Releases: 6.2
Resolves: #55411
Reviewed-on: https://review.typo3.org/27112
Reviewed-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Reviewed-by: Frans Saris
Reviewed-by: Stefan Froemken
Reviewed-by: Ingo Schmitt
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

Separate the create new record label and the foreign table title
with a colon.

Resolves: #17955
Releases: 6.2
Change-Id: I0869f53e1e5ba0b49ded81e1605494fc2b44fdb0
Reviewed-on: https://review.typo3.org/23509
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

Every time when an extension is registering an extbase
plugin (in ext_localconf.php), the call triggers some
additional TypoScript code, which is basically empty
and does some superfluous code.

The attached patch removes the code inside the
registration process in order to remove the memory
footprint and have a small impact on performance
when bootstrapping TYPO3.

On a frontend script (eID), this makes approx.
2% of the bootstrap process until TSFE kicks in.

Releases: 6.2
Resolves: #55569
Change-Id: I39b810d06be57f436a68afaa717d5ec214b8797b
Reviewed-on: https://review.typo3.org/27248
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel

This changes styles the buttons to add a new irre item like
the button to add images to a content element.

This patch also unifies button styles.

Resolves: #55539, #53218
Releases: 6.2
Change-Id: Ib07e51cfc6b6675671e1c6a2afd7bb0ebe379e1e
Reviewed-on: https://review.typo3.org/27221
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

Small CSS fix to overwrite general margin
of paragraph tags in page tree indicator bar.

Resolves: #55536
Releases: 6.2
Change-Id: I9a4766a7fbc22f6ab2506f8a12463f5695813205
Reviewed-on: https://review.typo3.org/27231
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

With TYPO3 6.0, includeLibs for classes with
Namespaces / autoloader is not needed anymore.

The patch cleans up the TypoScript of CSS Styled
Content in order to use the new namings and
the superfluous call to includeLibs.

Releases: 6.2
Resolves: #55558
Change-Id: I94558a24479f220ce0fbebb54bb2f8479085c61c
Reviewed-on: https://review.typo3.org/27234
Reviewed-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Resolves: #53564
Releases: 6.0, 6.1, 6.2
Change-Id: If7d69e4f87e368c1eef672cb68f1af92d6ae501b
Reviewed-on: https://review.typo3.org/25315
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

A TypoScript condition like
"[globalString = GP:anEmptyGetPostVarKey = ]" returns a false
value instead of the expected true value.

Fixes: #45183
Releases: 4.5,6.0, 6.1, 6.2
Change-Id: I114b702f4b5ae5f68236874325e82974a8ba6107
Reviewed-on: https://review.typo3.org/21979
Tested-by: Philipp Gampe
Reviewed-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

The module menu and its view are instantiated
on every backend call, BE AJAX call etc although
it is only needed in the backend.php file where
it instantiates itself automatically anyways.

The patch removes the call in init.php and
in the TYPO3 Bootstrap as it is not needed
anymore.

Releases: 6.2
Resolves: #55565
Change-Id: I67b6fb54380485d35c070867abf67e3ed416f004
Reviewed-on: https://review.typo3.org/27242
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

As discussed back in 2010, the value property of the TEXT content object
should have stdWrap functionality as well, if the HTML content object
is deprecated.

Today the 6.0 TSref already mentions stdWrap for value and
the HTML cObject has been removed with 6.0 as well.

This fix now finally adds the stdWrap.

Resolves: #54371
Releases: 6.2, 6.1, 6.0
Change-Id: I1b7068b3715bc9f8aa4608d5f746c16b70562f3b
Reviewed-on: https://review.typo3.org/26445
Reviewed-by: Benjamin Mack
Reviewed-by: Chris topher
Tested-by: Chris topher
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

There were several issues with the implementation
of class alias handling. Most importantly the
early instance alias cache depended on TYPO3_MODE
which in turn triggered a full class cache
initialization when this cache was missing in one
context.

Additionally eval() calls needed to be used in
certain situations and the building of the cache
files introduced additional complexity.

With this change the cache for early instances
is completely removed and replaced by a simple
setAliasFoClassName() call.

Resolves: #55559
Releases: 6.2
Change-Id: I59958419f28a4ff1d6de4add94ee611b56070068
Reviewed-on: https://review.typo3.org/27236
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
Reviewed-by: Marcin Sągol
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The Package Manager got pretty big due to the custom
dependency resolving algorithm of CMS. Further the
algorithm relied upon the presence of package objects
which might not be fully present yet during bootstrapping.

This patch extracts the dependency handling from the
Package Manager and adapts it to work only on the
package states configuration.

Resolves: #55404
Releases: 6.2
Change-Id: I00e7a3769378b48bd3f3c285ea2b3c6d824dd061
Reviewed-on: https://review.typo3.org/27101
Tested-by: Thomas Maroschik
Reviewed-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

This patch replaces most of around 1600 occurrences of
intval() and every (integer) in the whole core.
Additionally it changes GeneralUtility::intExplode to use references
and typecasting as well.
Some occurrences of strstr() together with intval() have been replaced
with strpos() as well.
And some superfluous intval calls have been removed or reduced
to a single one i.e. for protected variables or before loops.
Patch updated after Core CGL decision from 30.01.2014

Resolves: #54265
Releases: 6.2
Change-Id: Iba57ffad1f4233ffa1a9f7d3ca5bfe9d2b53f1e8
Reviewed-on: https://review.typo3.org/26740
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

The category fields are defined dynamically and added to the
extension table configuration. Since the database definitions
are created before modifying this configuration, the category
fields are not available in Functional Tests.

Resolves: #55560
Releases: 6.2
Change-Id: Ie59e544309184d475428bc298f126c2776b4b5e7
Reviewed-on: https://review.typo3.org/27238
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader