Skip to content
Snippets Groups Projects
  1. Oct 08, 2024
  2. Oct 07, 2024
  3. Oct 05, 2024
  4. Oct 01, 2024
  5. Sep 30, 2024
    • Benjamin Franzke's avatar
      [TASK] Remove E_STRICT_DEPRECATED constant · e7315d76
      Benjamin Franzke authored
      We can not deprecate a constant and use it at the same time.
      We basically traded a deprecated constant with a new deprecated
      constant. Therefore this intermediate constant (added without being
      released yet in #105155) is removed again and replaced by a plain value.
      
      It's too likely that this constant is used by 3rd party code
      (or dependencies like typo3/testing-framework), which then makes
      it hard to remove this constant again (despite being deprecated).
      
      Also defining an own constant – that looks like an official PHP
      constant – into the global space, has caused immediate confusions
      which we want to avoid by using a scalar value + comment.
      
      The reason (possible 3rd party extensions that may still trigger
      this error) why this is kept (and not just removed) is also added
      to all usages now.
      
      Releases: main, 12.4, 11.5
      Resolves: #105165
      Related: #105155
      Change-Id: Ia7526c7d5027f2d0f91cddf4fb2967ef57e9526a
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86384
      
      
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Tested-by: default avatarBenjamin Franzke <ben@bnf.dev>
      Reviewed-by: default avatarBenjamin Franzke <ben@bnf.dev>
      e7315d76
  6. Sep 29, 2024
    • Stefan Bürk's avatar
      [TASK] Mitigate `PHP 8.4.0-RC1` breaking changes · 40a8f9ac
      Stefan Bürk authored
      Note that this change addresses three different issues, which
      need to be done in one step, otherwise none of isolated patches
      would get a +1 CI verification:
      
      * Alignment for changed `$escape` parameter handling of CSV
        related methods, which must be avoided with PHP versions below
        8.4.0-beta5, but is required as of PHP 8.4.0-RC1.
      * This `$escape` issue needs to be addressed directly in
        the `typo3/testing-framework` and thus needs a raised
        dependency directly.
      * PHP 8.4.0.0-RC1 also deprecated the `E_STRICT` constant,
        which needs to be addressed directly.
      
      With [1] the `$escape` parameter for the following method calls
      
      * `str_getcsv()`
      * `fputcsv()`
      * `fgetcsv()`
      
      must be provided as a 1 character long value. Omitting and
      using the default value will emit a PHP deprecation [2] warning
      as of PHP 8.4.0-RC1, for example:
      
        str_getcsv(): the $escape parameter must be provided
        as its default value will change
      
      To mitigate this, PHP recommends following:
      
        It must be passed explicitly either positionally or
        via named arguments.
      
      This change adjusts all occurences (function calls) and ensures
      that the `$escape` parameter is explicitly provided via
      specifying all parameters up to that position and not
      using a `named arguments` approach for easier backporting.
      
      The TYPO3 testing framework also needs to be aligned to
      mitigate `fgetcsv()` issues, and is raised in the same
      step - otherwise none of these changes would get a green
      CI pipeline run.
      
      The following testing-framework updates are adjusted:
      
      * main: simple update `main` pointer
      * 12.4: Raise to tag `8.2.2`
      * 11.5: Raise to tag `6.16.10`
      
      Used command(s):
      
      > composer require --dev "typo3/testing-framework":"^6.16.10"
      
      Additionally, PHP 8.4.0-RC1 deprecated the `E_STRICT`
      constant, which now emits a E_DEPRECATED which leads to
      failed CI tests. This change introduces a core internal
      constant with the same integer value, and replaces usages
      with this constant to mitigate the E_DEPRECATION. This constant
      can then be dropped with TYPO3 v14, preventing a breaking change
      at this time. [3][4]
      
      [1] https://github.com/php/php-src/pull/15569
      [2] https://github.com/php/php-src/blob/ebee8df27ed/UPGRADING#L617-L622
      [3] https://github.com/php/php-src/blob/ebee8df27edf7/UPGRADING#L47-L49
      [4] https://github.com/php/php-src/pull/13053
      
      Resolves: #105155
      Releases: main, 12.4, 11.5
      Change-Id: Ie8b7d46eeb75ba6e32c0e8f6e7e947775083cc15
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86377
      
      
      Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
      Reviewed-by: default avatarGarvin Hicking <gh@faktor-e.de>
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
      Tested-by: default avatarGarvin Hicking <gh@faktor-e.de>
      40a8f9ac
  7. Sep 19, 2024
  8. Sep 15, 2024
  9. Sep 11, 2024
  10. Sep 10, 2024
  11. Sep 06, 2024
  12. Sep 05, 2024
  13. Sep 04, 2024
  14. Aug 27, 2024
  15. Aug 26, 2024
  16. Aug 22, 2024
  17. Aug 20, 2024
  18. Aug 14, 2024
  19. Aug 13, 2024
  20. Aug 10, 2024
  21. Aug 09, 2024
  22. Aug 07, 2024
  23. Aug 06, 2024
  24. Aug 03, 2024
  25. Jul 31, 2024
  26. Jul 29, 2024
  27. Jul 26, 2024