- Nov 12, 2022
-
-
Andreas Fernandez authored
The date-time-picker component now checks properly if the backend user's language could not get fetched from its UC by checking loose for a falsy value. Resolves: #99067 Releases: main, 11.5 Change-Id: I3ba104afde2321480099e96beff6ab77ecb126a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76568 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Andreas Fernandez authored
This patch updates `moment-timezone`, having a fixed vulnerability, along with the related `moment` library. Executed commands: yarn add \ moment@^2.29.4 \ moment-timezone@^0.5.35 grunt build Resolves: #99061 Releases: main, 11.5, 10.4 Change-Id: I36376bad194aa63dda0146c8bc0f481b932dc89d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76557 Tested-by: -
linawolf authored
Solves https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-ViewHelper/issues/50 Occurences of `:ts:` are adressed in https://forge.typo3.org/issues/99068 Resolves: #99069 Releases: main, 11.5 Change-Id: I49a42ba29017081d338bec815e3b2c5f14bf7a68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76501 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
linawolf authored
Replace `:ts:` with ``:typoscript:` in ViewHelper class comments. `:ts` does not render properly, see for example https://docs.typo3.org/other/typo3/view-helper-reference/main/en-us/typo3/fluid/latest/CObject.html Resolves: #99068 Releases: main, 11.5 Change-Id: Idfac843859a5e9054e6e48f29b19616b2b956dac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76500 Tested-by:
-
- Nov 10, 2022
-
-
Oliver Hader authored
Empty (in terms of PHP empty()) string values are shown as blank strings in the info section of the admin panel. For instance "0" is incorrectly shown as "". Resolves: #99052 Releases: main, 11.5 Change-Id: Ic330fb1874edca8b3e640e9c5793192616583ec0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76549 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Achim Fritz authored
EXT:redirects DataHandler hook to flush the redirects cache in case a redirect is modified does now also work for new redirect records by removing parts of the early return, which relied on records having a numeric uid while new records' uid is the known "NEW.*" string. Resolves: #99042 Releases: main, 11.5 Change-Id: I3624ceecaefd00c0ffce88fd656dc5d81a5b77de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76499 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Oliver Klee authored
This update makes a warning more specific. Run commands: > composer req --dev phpstan/phpstan:^1.9.2 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #99045 Releases: main, 11.5 Change-Id: I4c5af9d69e0e5b8f4b0d78efd4caa4ed79aed795 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76498 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Bastien Lutz authored
With Doctrine DBAL in TYPO3 v8, a default value for various fields were added to avoid SQL errors (nullable), setting them to their default value. However, there is a culprit. When editing e.g. be_users.file_permissions where you have selectCheckbox field with all options, it was never possible to unselect all, as the default value was then used. Through some workarounds, DataHandler now checks the modified records on the selectCheckbox type to not fall back on the default value. Resolves: #70812 Releases: main, 11.5 Change-Id: I2cd3bf87c31cd4fe5244b26eb3fe2e58e3d8755c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76497 Tested-by:
-
- Nov 09, 2022
-
-
Oliver Hader authored
Symfony's UrlMatcher takes multiple routes and returns the first match. However there might be better matches that are not considered at all. That's why a custom BestUrlMatcher is introduce, which resolves all matches for further reduction. Previously the route collection was sorted by names and identifiers, which now has been adjusted to focus on the actual matches when being compared to the current request. The fallback route (site base URI). This way, overlapping route definitions can be resolved better. Resolves: #93240 Releases: main, 11.5 Change-Id: Ib1a7361dc86ed48a474d5e55583a622df58e8939 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76513 Tested-by:
-
Benni Mack authored
The backend UI does not support handling of baseVariants for languages, however it is possible to define them in the config.yaml of a site configuration. However, when editing and saving a site, the baseVariants manually defined were removed. This has now been changed, as the baseVariants are kept when persisting the site configuration via the UI. Resolves: #93719 Releases: main, 11.5 Change-Id: I8a0b3be72ddfab46da59b3f8a69ad16121c7246b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76496 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Nov 08, 2022
-
-
Oliver Bartsch authored
Due to changes in #98960 the resolved entity name might contain slashes, which need to be quoted to prevent PHP warnings. Resolves: #99023 Related: #98960 Releases: main, 11.5 Change-Id: I75eecbdbbddc82b5b1189388413fabd7370d4229 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76495 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Oliver Bartsch authored
Generation of a slug proposal based on defined generator fields does now also work for basic select fields, which were previously not considered by the JS component, because they do not use the FormEngine specific visible / hidden field combination. Resolves: #94371 Releases: main, 11.5 Change-Id: Iedd2d17e97db8abd9cf5c4a3b476825fcd854191 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76489 Tested-by:
-
Oliver Hader authored
Change-Id: Ic61feb8ab34ac3136641780bf0ccefb720514d6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76476 Tested-by:
-
Oliver Hader authored
Change-Id: I6e3dbcfbca33453671f63d27630692b2e19572c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76475 Tested-by:
-
Stefan Bürk authored
Default language page slug usage in combination with the siteLanguage base of non-default language has been resolved and delivering the language content. This made the page accessible with multiple urls. Available and existing translated pages should be only resolved by the language slug, not the default language page slug. However, if page is not translated, using the default language slug for the resolving should be only considered and working if fallback settings are provided. Resolves: #88715 Resolves: #96010 Releases: main, 11.5 Change-Id: Id618880fe2ba26fd3b6ab50b4813968923ec5acb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76494 Tested-by:
-
Benni Mack authored
FormEngine's TreeRendering for categories utilizes the TreeDataProvider logic, which is handed over a list of available items loaded by FormEngine's AbstractItemProvider. These records have already been validated and a full record was already loaded by FormEngine at this point. The TreeDataProvider construct then fetches ALL records again, as it only works with the "IDs", but not with already loaded full rows. This makes the construct expensive. It needs a bigger overhaul. To mitigate the performance impact of bigger category trees, the patch applies a hack to suppress loading single category rows multiple times by handing them over from FormEngine to the TreeDataProvider construct. As this change is also backported to 11.5, the optimizations are only done for type=category to minimize impact for other Tree usages. Resolves: #84558 Resolves: #90398 Resolves: #97003 Resolves: #76581 Resolves: #98807 Releases: main, 11.5 Change-Id: Ief183f1673d3a17036ca5e68c62dc18a4277def1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76473 Tested-by:
-
Alexander Schnitzler authored
Due to the dependency of those objects to the DataMapper and its own dependency chain, serialization of those objects lead to error: Serialization of \Closure not allowed. To ommit this issue and to reduce the footprint of the serialization data in general, the data mapper should be omitted and reinitialized via __serialize() and __unserialize() Releases: main, 11.5 Resolves: #97190 Resolves: #92148 Change-Id: If8b78a93308eb14d40080c9cceee95754b785ba8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76492 Tested-by:
-
Benni Mack authored
Resolves: #98175 Releases: main, 11.5 Change-Id: Iccc439eafbbb1f959c8c2bc12248b7c4aa560260 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76493 Tested-by:
-
Benni Mack authored
This change adds the basic information for a type when adding a plugin as CType. When adding a plugin with "list_type" (default), then the "list" CType is used, and extension authors are able to add or remove fields easily with the API. However, when encouraging extension authors to use CType, this is currently much more boilerplate and not possible to make this more flexible. As shown, EXT:felogin and EXT:form previously used this concept manually, which does not allow to extend fields properly, but extensions with plugins as CTypes had to define them explicitly. As TYPO3 Core encourages people to use custom CTypes in favor of list_type (moving towards a unifieid Content Block concept), this change will also be available for 11.5. Resolves: #98960 Releases: main, 11.5 Change-Id: Iee5e1a35f2d99faf03081d7265c2fe6e4845397f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76465 Tested-by:
-
Georg Ringer authored
Check if a record is using a "cruser_id" field before accessing it. Resolves: #98230 Releases: 11.5 Change-Id: Ia5310aec143eee177a46b6ce4c3a376f55a078da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75627 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Nov 07, 2022
-
-
Roman Büchler authored
The typoLink_PostProc hook passed the original link text to the hook processors. In case the `linktxt` array field isn't altered in a hook processor the original link text is rendered instead of the one already available in the `lastTypoLinkResult`. As a result the typoscript configuration `config. spamProtectEmailAddresses_atSubst = (at)` isn't respected. Resolves: #98606 Releases: 11.5 Change-Id: Iba3d4faffeb425329ffaad6d2dd15341861927f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76110 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
Achim Fritz authored
Remove doktypes in page tree toolbar when not set in TCA items to prevent an undefined array key PHP 8 warning. Resolves: #99012 Releases: main, 11.5 Change-Id: I0fc98e448aca70dc85f671a68d68d63bba15a166 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76417 Tested-by:
-
Achim Fritz authored
Resolves: #99013 Releases: 11.5 Change-Id: I4f0346b5dd259fd9ad988f2b7509bad7c58253f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76453 Reviewed-by:
-
Achim Fritz authored
Prevent PHP 8.1 undefined array key for wizard items without description or without title. Resolves: #99015 Releases: main, 11.5 Change-Id: I141aa8e0003a2e3b783fb78fddf9db5e602ea40d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76416 Tested-by:
-
Oliver Bartsch authored
The width of the items in the new content element wizard is now properly defined again so that on larger screens, two columns are used and on smaller screens, all items are below each other (taking full width) again. Resolves: #99010 Releases: main, 11.5 Change-Id: I96539dbb962021530b2c29062899aff8b655710c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76457 Tested-by:
-
Oliver Bartsch authored
The "foreign_table_where" option is no longer forced by TcaPreparation for TCA type "category", which had been introduced with #94622. Resolves: #98656 Related: #94622 Releases: main, 11.5 Change-Id: I8cab56881bab042e46b2325bee80665b83423948 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76415 Tested-by:
-
- Nov 06, 2022
-
-
Benni Mack authored
This change simplifies further work on the TCA Tree logic. a) use imported names b) ensure to use int|string for Node->getId() as Core uses this for integers within e.g. sys_category c) fix some phpdoc infos d) remove an unused property e) use proper casting for integers f) use $this->lookupField instead of $this->getLookupField() when using 10000 of categories, this function call is superfluous. By using int|string, the changed code if ($node->getId() !== 0 && $node->getId() !== '0') saves 1 (!) DB query on every request. This change is meant also to be backported to v11, for this reason no changes to the types within properties are made (only type hints). Resolves: #99005 Releases: main, 11.5 Change-Id: I291cdd0925f77b0e48e224f207eb5e1b0c4fa041 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76448 Tested-by:
-
- Nov 04, 2022
-
-
Benni Mack authored
The "filter by Page ID" functionality within the page tree now also checks for the live ID ("t3ver_oid") if a page was modified. Resolves: #98444 Releases: main, 11.5 Change-Id: Ia084905d8ddf642736ea1739610db3c0a011cc5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76412 Tested-by: -
Benni Mack authored
When using TYPO3's custom link plugin for CKEditor, special tags / attributes within the link (e.g. <em>) are now kept. Previously, all custom tags were removed, as only text was taken, but if the link was added without the link plugin, the problem did not exist. Resolves: #89404 Resolves: #93457 Releases: 11.5 Change-Id: I6f7152e927a4a4437dc0b3d3561ae6a7c56adedc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76404 Tested-by:
-
Andreas Fernandez authored
Most modern operating systems allow to disable animations, also known as "reduced motion", which is a very important accessibility feature for people suffering from motion sickness. In CSS Level 5, a media query `prefers-reduced-motion` is available to check for this specific setting, if the browser can get the configuration from the operating system (looking at you, Chrome and GNOME). With Bootstrap 5, `prefers-reduced-motion` is already in place, disabling all animations caused by CSS. However, the notification component is partially animated via JavaScript and thus the media query wasn't taken into consideration and notifications were still animated. The media query is now checked on JavaScript side as well to avoid animating notifications. Resolves: #98990 Releases: main, 11.5 Change-Id: Ic6ed35fb6ccf17b1fe7cd1970858e4abe2755f84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76409 Tested-by:
-
Stefan Bürk authored
PHPStan recently added a xdebug check The TYPO3 core php testing images has xdebug installed and enabled in cli mode, which now let PHPStan display a speaking notice about this circumstance. This change simply disable xdebug for phpstan calls in runTests.sh, thus avoiding this notice. xdebug is not needed to be enabled for PHPStan executions. Resolves: #98994 Releases: main, 11.5 Change-Id: I2b390884b4ccba85e9c2638bfa815f1a138c23e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76414 Tested-by:
-
Benni Mack authored
This change now also fetches versioned records when previewing a workspace, allowing to also query the versioned records if their slug has been changed. This extends WorkspaceRestriction to have a similar behaviour as previously known from PageRepository (pre v8 times), to fetch versioned records. Resolves: #97940 Releases: main, 11.5 Change-Id: I7fe9c081d5a087bf5276510e1a915fc92b72956d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76413 Tested-by:
-
- Nov 03, 2022
-
-
Georg Ringer authored
To avoid exceptions if arguments are given but empty, an additional check is added in extbase LocalizationUtility, plus the default in f:translate is changed back to the same 'null' value as in v11. Resolves: #98924 Related: #96473 Releases: main, 11.5 Change-Id: Idd08f7b948eb504999a80a215a7ded64f3c648a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76407 Tested-by:
-
Eric Bode authored
Allow temporary setting of the live workspace for backend users that don't have permission "Edit Live (Online)". These users can now use the comparison view in the frontend and compare the live version with the workspace version. Resolves: #93097 Resolves: #98445 Releases: main, 11.5 Change-Id: I7915c5a1ca32ed25655ce227db9c88872663f942 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76272 Tested-by:
-
Oliver Klee authored
This update finds new problems and gets rid of some false positives. Run commands: > composer req --dev phpstan/phpstan:^1.9.0 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Blog article about the new release: https://phpstan.org/blog/phpstan-1-9-0-with-phpdoc-asserts-list-type Resolves: #98986 Releases: main, 11.5 Change-Id: I15516853c3a1bac80b80466fe4bae8a0f150ba68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76397 Tested-by:
-
- Nov 02, 2022
-
-
Oliver Hader authored
Invalid file names containing special characters like `<` or `>` are not correctly represented as text node. Error messages wrapped in an XML node need to be properly encoded. This was originally reported as a vulnerability, after analyzing the scenario, the TYPO3 Security Team came to the conclusion to handle it in public. It cannot be exploited directly without knowing the backend form protection token of a particular user session. Resolves: #98382 Releases: 11.5, 10.4 Change-Id: Icd73de28ef3b702b45cbc8f232b5595b6fda127b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76349 Tested-by:
-
- Oct 31, 2022
-
-
Albrecht Koehnlein authored
Avoid passing a null parameter to json_decode() which would cause a PHP deprecation Resolves: #98962 Releases: main, 11.5 Change-Id: Ib85804bfe78d1eb681ae2d7d4bcbe69c1bae0dcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76273 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- Oct 29, 2022
-
-
Wouter Wolters authored
composer req --dev phpstan/phpstan-phpunit:^1.2.2 Resolves: #98943 Releases: main, 11.5 Change-Id: Iee2f421546a7be58ada993aa5c331bb914500aad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76331 Tested-by:
-
- Oct 27, 2022
-
-
Wouter Wolters authored
> composer req --dev friendsofphp/php-cs-fixer:^3.12.0 > Build/Scripts/runTests.sh -s cgl -p 8.1 Resolves: #98938 Releases: main, 11.5 Change-Id: I42b247fa4ea51ef20e29fef855c12af1b756d558 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76303 Tested-by:
-
- Oct 26, 2022
-
-
Christian Kuhn authored
This property name is too generic as weak match and throws too many false positives. Resolves: #98926 Release: main, 11.5 Change-Id: I0d39287180bb4d53071efe30d42145a313a98ec8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76271 Tested-by:
-
