- Mar 23, 2020
-
-
Alexander Schnitzler authored
Used command: composer require friendsoftypo3/phpstan-typo3:"~0.2" --dev Releases: master Resolves: #90811 Change-Id: Ibd9ae856e8046edc67cb7610956ede92c474bf12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63846 Tested-by:TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Susanne Moog authored
The parser for foreign_table_where consists of a basic regex that did not allow the use of field functions due to its character restrictions. The character match group has been adjusted to allow the following chars additionally: ")( Resolves: #82955 Resolves: #88166 Releases: master, 9.5 Change-Id: I0fa9283d920a0aaf2bacf9168d0e35f09c3d57af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63755 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Sybille Peters authored
Lists must always be preceeded and followed by a newline. Otherwise they will not get rendered correctly. Resolves: #90805 Releases: master, 9.5, 8.7 Change-Id: I558e486ef556be41bb27873af8d0d67a448064f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63837 Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Andreas Fernandez authored
Executing a debounced event listener immediately now sets a timeout to wait until the next execution is invoked. Resolves: #90809 Releases: master Change-Id: I76622c62cacfcf82d737fd93ae5a96fa4e7485a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63843 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
Andreas Fernandez authored
Resolves: #71750 Releases: master, 9.5 Change-Id: Ifc27ee8ed4dffba36098b9e72cac6e39cc775ebd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63850 Tested-by:
-
Andreas Fernandez authored
Resolves: #86100 Releases: master, 9.5 Change-Id: Ib76a2bbd00cca4a69178049e51f6ca04325b49ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63835 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Georg Ringer authored
The code completion must differ between dots at the end and those in the middle which belong to the key. Instead of just replacing all dots, only the one at the end is used to split the TS into chunks. Resolves: #84534 Releases: master, 9.5 Change-Id: I82890b56d1a95584ddc079cc7e9c930cfaa71830 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63765 Tested-by:
-
Georg Ringer authored
If the file `ENABLE_INSTALL_TOOL` with the content `KEEP_FILE` is available, the login form must be shown instead of the template `ShowEnableInstallToolFile`. Additionally the button to lock the Install Tool is switched to a warning instead. Resolves: #85656 Releases: master, 9.5 Change-Id: I3aed824d099f23b48be0bed890935b9d244953b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63831 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Georg Ringer authored
Use event.key instead of the discouraged event.keyCode. Resolves: #87793 Releases: master, 9.5 Change-Id: Ie26c98fc9d11ed4f5adbe527afbc6ed37056d776 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63833 Tested-by:
-
- Mar 22, 2020
-
-
Susanne Moog authored
There are systems and library combinations that do not allow the usage of more than one thread to generate passwords. To ensure maximum compatibility, the number of threads is reset to its default state. If raising the number makes sense for performance reasons on systems that support it, the setting can still be overwritten by setting `$GLOBALS['TYPO3_CONF_VARS']['BE']['passwordHashing']['options']['threads']`. Resolves: #90612 Releases: master, 9.5 Change-Id: I19e883359737e6882aed40968959eadd8f74f8d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63605 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Andreas Fernandez authored
A new close button is rendered next to the "Open Documents" headline in the dropdown menu which enables to close all open documents at once. Resolves: #89053 Releases: master Change-Id: I4a1a7503cd0140210f4f78148f9dec1312d67dda Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63836 Tested-by:
-
Ivan Dharma Kartolo authored
If the clipboard contains at least one item, a paste button is rendered next to fields of type `group`. With this patch, all items of the clipboard are now pasted into the field. Resolves: #88711 Releases: master, 9.5 Change-Id: Ib8d5d9ab148e8794f54d2665d95721c10f8b7255 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63834 Tested-by:
-
Andreas Fernandez authored
Resolves: #90808 Releases: master, 9.5 Change-Id: Ie06fb7710591bfab8d8892e55bed0716505b7289 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63841 Tested-by:
-
Georg Ringer authored
System maintainers must be admin users which should be checked with a guard clause. This avoids showing the modules to editors whose id is in the list of system maintainers. Resolves: #82616 Releases: master, 9.5 Change-Id: I84cd20d2b84eaa0182c27943ffdcde005980a426 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63832 Tested-by:
-
- Mar 21, 2020
-
-
Benni Mack authored
"GeneralUtility::isRunningOnCgiServerApi()" is now deprecated in favor of "Environment::isRunningOnCgiServer()". Resolves: #90800 Releases: master Change-Id: Ib9e9e38d0e53ca00f3c58eb3255943d57cf7c0e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63680 Tested-by:
-
Marco Huber authored
Multi Select fields without any option given will be added properly to the forms __trustedProperties list and therefor no longer cause validation errors. Resolves: #90761 Releases: master, 9.5 Change-Id: I3c73ffbbd38a9a2ae24ed4b271efc1c4ce248d53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63720 Tested-by:
Marco Huber <mail@marco-huber.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Christian Eßl authored
It must not be possible to perform rename/copy/cut/delete actions on a file mount and this is already respected in the FilemountsProvider context menu and used in the filelist svg tree. However, the docheader section in the top right corner of the filelist module showed the wrong context menu for file mounts, which made it possible for editors to perform these actions. Resolves: #90677 Releases: master, 9.5 Change-Id: Iac10b18a4fa3249de9b9c29a0102b3832c933841 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63674 Tested-by:
-
Susanne Moog authored
When using the edit popup of SelectMultipleSideBySide editing is related to the items that are active and selected in the element. The old placement of the edit pencil however suggested that it should be possible to edit all (even inactive items, unrelated to the current record) elements. Whenever an editPopup is configured to be shown in a SelectMultipleSideBySide element, the edit pencil is now placed directly next to the active select items. Resolves: #90777 Releases: master Change-Id: Iac8df9dafca455adb4b18d5bca882fa2ab3bd0cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63792 Tested-by:
-
Andreas Fernandez authored
If a record gets deleted via context menu no further handling could be added as the promise returned by AjaxDataHandler is available in an encapsulated scope only. To bypass this issue, the AjaxDataHandler now optionally emits events to listen on. This patch implements event listeners for the record list and the information module of "Template tools". Resolves: #90791 Releases: master Change-Id: I0b659e695f31b2f3ab40adc17421f8b036d5aab6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63811 Tested-by:
-
Benni Mack authored
The lowlevel cleaner "missing files" detects files like "filepath/file.pdf#page-15" as missing as the "#" is considered part of the filename. A new check now properly detects this. Resolves: #84999 Releases: master, 9.5 Change-Id: Ic394f7d34e993807e932ebc3ac438f31f50dcb32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63819 Tested-by:
-
Benni Mack authored
When creating a link with TypoLink or Fluid pointing to a file, it is possible (e.g. in PDFs) to use an "anchor" (#) to point to a specific section. This is now possible like this: <f:link.typolink parameter="file:1#page-13">test</f:link.typolink> Resolves: #75213 Releases: master, 9.5 Change-Id: Ia085e6a684894613e20ebcfe5ddf5fdcc883a37e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63823 Tested-by:
-
Benni Mack authored
This happens when the content element does not exist yet, which is why this needs to be checked properly, otherwise the PHP strict typing error will stop execution of the PHP script. Resolves: #90801 Releases: master, 9.5 Change-Id: I94e5969a312ad876e9bd03b2c75b2de149ba3c61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63813 Tested-by:
-
Andreas Fernandez authored
The order in JSON objects is not defined and the browser can stringify them in an arbitrary order. Resolves: #88094 Releases: master, 9.5, 8.7 Change-Id: I6b0ef6cb4e3877aa828578ce70e35dad0779da74 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63808 Tested-by:
-
Andreas Fernandez authored
To have a better overview of which packages are actually in TYPO3 itself, matching packages have been moved into the `dependencies` section of package.json. Resolves: #88049 Releases: master, 9.5 Change-Id: Ibe41fb56df4aacbe818508afdc8a3bbb48cc43f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63822 Tested-by:
-
Alexander Schnitzler authored
With https://review.typo3.org/c/Packages/TYPO3.CMS/+/59514/ all possibilities have been taken to define which view class to use based on the format query param. As those format query params are still api and in use, the core must reintegrate the former behaviour: Instantiating a JsonView object for requests with a format query param set to 'json'. The implementation is marked as internal as the overall idea is to remove the format param in the long run. Releases: master Resolves: #90788 Change-Id: I62aaa8f44126edbe1238a5a972044f239f3362eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63438 Tested-by:
-
Oliver Eglseder authored
useDefaultLanguageRecord is documented to use the default record uid by default. The actual behaviour is the opposite. This change introduces a test and the change, that fixes the evaluation of useDefaultLanguageRecord in the code. Resolves: #87948 Releases: master, 9.5 Change-Id: I9633092089cc74e8a837bf0bfe27e6b3b8d0d229 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60297 Tested-by:
-
- Mar 20, 2020
-
-
Alexander Schnitzler authored
The extbase container provides a method isSingleton that checks if a class implements the SingletonInterface interface. It did so by creating a ClassSchema instance for the given class name which is not needed as there are more efficient ways to check for implemented interfaces that don't require the creation of a ClassSchema instance. Releases: master Resolves: #90798 Change-Id: I62a3290c2d3c100a967f5a98b3d901cd61ca0db6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63820 Reviewed-by:
-
Alexander Schnitzler authored
As there are a lot of rules that do not raise any errors with our code base, those rules up to level 8 are enabled with this patch resulting in more pre merge tests being executed as of now. Releases: master Resolves: #90795 Change-Id: I3628569c90e1e7bbf2ffde81abbef37065bd45e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63812 Tested-by:
-
Susanne Moog authored
The title property of IRRE file relations (sys_file_reference) were doubly escaped - once is enough. Resolves: #88514 Releases: master, 9.5 Change-Id: I50f5f9db70cdd1af8fb6f7e9e2de1d3eb3f3cc0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63814 Tested-by:
-
Benni Mack authored
If somebody calls www.example.com?AMDCMD_prev=abcbenni the output should never throw an exception (also if the preview entry or the cookie has expired). The cookie itself is a session-based cookie nowadays, so the expiration of the cookie is not relevant. The change lets outsiders just fall back silently to the Live version. Resolves: #18761 Releases: master, 9.5 Change-Id: I1ca1dce2a01ce01daddc6945a45960b3e9e1f4ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63818 Tested-by:
-
Andreas Fernandez authored
With `DragDrop.ajaxAction()` returning a promise now, the flag icon can get updated after dropping a content element into another language. Resolves: #90693 Releases: master Change-Id: Iff0a819e69194f0302ea97ce096500e0144704c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63799 Tested-by:
-
Andreas Fernandez authored
If PageRenderer->addRequireJsConfiguration() is consecutively called, the configuration is now properly merged by using array_merge_recursive(). The previously used ArrayUtility::mergeRecursiveWithOverrule() overrode any previously set keys of the numeric array which broke the configuration. Resolves: #89431 Releases: master, 9.5 Change-Id: I1e654c27a095db5ec88182aed1b8fe1011b37134 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63816 Tested-by:
-
Andreas Fernandez authored
The event listener for collapsing and expanding IRRE nodes is now less greedy and ignores the div containing all control buttons which makes the buttons without click event (e.g. "Edit metadata") functional again. Resolves: #90796 Releases: master Change-Id: Ie19547bc5fbf21124f4a658ffc3a28b157242d51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63817 Tested-by:
-
Alexander Schnitzler authored
This patch simply pulls out the level 2 rules into a separate configuration file which is a copy of the original level 2 configuration file of phpstan with some rules, services and parameters disabled. Also, additional configuration files are put into the Build folder and phpstan.neon has been added to the .gitattributes file. Releases: master Resolves: #90789 Change-Id: Ia3b3c30cfa57227c0607904df38add31f36be0e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63802 Tested-by:
-
Christian Bülter authored
Releases: master Resolves: #90793 Change-Id: I087f38e04d8e96c66610c1bc293d6bceb7fc1e51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63809 Tested-by:
-
Susanne Moog authored
Files that are not readable by the web server should not be returned by FAL LocalDriver as we cannot do anything with them and even the basic subsequent steps (fileinfo, indexing) will fail. Resolves: #57457 Releases: master, 9.5 Change-Id: I5314cc9ba9e49bf142b4c388feea4495b8f8e5a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63807 Reviewed-by:
-
Jacob Dreesen authored
Releases: master, 9.5 Resolves: #90779 Change-Id: If6931385b288456dc6e1d5d0e289b1132886bc77 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63766 Tested-by:
-
Andreas Fernandez authored
Define the `hideDropzone` event listener via assignment to keep the binding of `this` to the DragUploader class. Resolves: #90792 Releases: master, 9.5 Change-Id: I21c52da477349e77a52f2c6701fd75abc3b5b074 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63805 Tested-by:
-
Guido Schmechel authored
Deferred files should not be concatenated. They are now output as a single script. Resolves: #90208 Releases: master, 9.5 Change-Id: I17c84b41acd445db6ee261bade69fddd32ca7380 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63040 Tested-by:
Ghanshyam Bhava <ghanshyambhava@yahoo.com> Reviewed-by:
-
Georg Ringer authored
Partly revert #89956 to reallow category titles in extension settings which contain a space. Resolves: #90776 Releases: master Change-Id: I93358e1c10e502ba9c48402a78927e34c240215a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63764 Tested-by:
-
