- Jan 13, 2022
-
-
Christian Kuhn authored
* Use BackendTemplateView * Hand over template to render as view->render('MyTemplate') * Move shortcut templates to Toolbar sub folder * Move LiveSearch JS to Toolbar sub folder * Shortcut delete and edit are POST only * Use DI in related controllers and ToolbarItems * Declare strict_types=1 * Return and property types in PHP classes * PageRenderer JS module loading via fluid, not PHP * f:translate with full LLL: keys Change-Id: Ia8b5ecb312dd83b924955f44f53fb7b3c8415ba3 Resolves: #96519 Related: #96513 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72996 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
This is a partial refactoring of ext:lowlevel. There are some loose ends like HTML in the searchAction() and some other details. Those might be target of a bigger refactoring. However, the patch cleans up controller and view and improves separation of concerns already: * Rename mainAction() to handleRequest() * Use BackendTemplateView * Hand over template to render as view->render('MyTemplate') * Use DI in related controllers * Switch from a ServiceProvider.php to casual Services.yaml * Declare strict_types=1 * Return and property types in PHP classes * PageRenderer JS module loading via fluid, not PHP * f:translate with full LLL: keys Change-Id: I0afe0938990f145e77aedd131f366226142382f3 Resolves: #96530 Related: #96513 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73007 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Elias Häußler authored
Doctrine uses mixed type for most of their method arguments in QueryBuilder. Since TYPO3 core uses variadic arguments for some methods in the wrapping QueryBuilder, argument types have been streamlined to match the ones in the concrete QueryBuilder instance from Doctrine. Resolves: #96507 Related: #96457 Releases: main, 11.5, 10.4 Change-Id: I834240f764feac7af9fba7db0d45aaf4927abb2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72964 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
* Use BackendTemplateView and ->render('MyTemplate') * f:translate with full LLL: keys * No extbase-only f:form VH usages Resolves: #96527 Related: #96513 Releases: main Change-Id: I1679b1755454b05c3cb104ac11d1acf8410cd27d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73005 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Bartsch authored
Resolves: #91077 Releases: main Change-Id: Iac0b8433a77ef4d6f6f0d1734e84c6a35f6addb4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73008 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
Christian Kuhn authored
Configure classes in Services.yaml towards dependency injection. Also rename NoteController to NoteRenderer as it's not really a controller that handles requests, but just a renderer used as dependency in events. Controllers are usually public DI services, renderes not. Resolves: #96528 Releases: main Change-Id: Idfadc75763ad0a7a84fd572473affb9040575b54 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73006 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
This introduces a new PSR-14 event, enabling extension authors to modify the header and footer content of the page module in a flexible way, since also reordering and overwriting is possible now. This replaces the previously available hooks - $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/db_layout.php']['drawHeaderHook'] - $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/db_layout.php']['drawFooterHook'] which are now removed. Resolves: #96526 Releases: main Change-Id: I5fb3f3098394b70ecc4e5cc11c804f7125ad2a4a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73003 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Benni Mack authored
The option prefixLocalAnchors in HtmlParser was not used anymore since the removal of its main functionality in #65934 with TYPO3 v8.0, and is now removed, as it is a leftover of past functionality before site handling and proper URL generation. Resolves: #96501 Releases: main Change-Id: Ia037f02729cf731ea60e4a49174bdb0caff34c0b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72945 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Oliver Bartsch authored
To improve the workflow for editors while selecting records or folders in TCA type "group" fields, a new field configuration "entryPoints" is introduced. It can be used to define the default page / folder, which should be selected when opening the element browser. This can be configured for all or for each table individually. This configuration might be quite useful since TYPO3 systems usually use dedicated storage pages for record types nowadays. To further support site administrators, the new configuration also allows the usage of the known TCA markers and additionally is also added to FormEngine's "allowOverrideMatrix". Resolves: #91077 Releases: main Change-Id: Ie6e4e8675ff07288480bce69467805409defdc57 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72911 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
This change introduces a new PSR-14 event for manipulating menu items in a menu. The hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/tslib/class.tslib_menu.php']['filterMenuPages'] is removed, and AbstractMenuFilterPagesHookInterface deprecated. Resolves: #92508 Releases: main Change-Id: I2960e5021b2ba49e1b26e68f2bb0cbed809d60a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72955 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- Jan 12, 2022
-
-
Oliver Hader authored
Using inline JavaScript when initializing RequireJS modules in individual dashboard widgets has been deprecated. Widget implementations have to be adjusted accordingly. Basically `RequireJsModuleInterface` has to be replaced by `JavaScriptInterface` relying on `JavaScriptModuleInstruction`. Resolves: #96524 Releases: main Change-Id: I5eb74aa54aef6d4f3a9419aaa7e2d391d98ce408 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73002 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Christian Kuhn authored
Global constants TYPO3_version and TYPO3_branch have been deprecated with introduction of class \TYPO3\CMS\Core\Information\Typo3Version in v9.5.15 and are removed together with some last usages. Resolves: #96523 Related: #96107 Releases: main Change-Id: I0fd90a9f913d83a555a9744117f76d63468a1048 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73000 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Hader authored
Custom FormEngine components loading additional RequireJS modules must use corresponding JavaScriptModuleInstruction instances to declare modules and optional method invocations. Assigning scalar values to FormEngine node section 'requireJsModules' (e.g. used for arbitrary inline JavaScript callbacks) is not possible anymore and will throw a LogicException. Resolves: #96221 Related: #95200 Releases: main Change-Id: I8c487fa3914a46ae1ce2e75db0bf6a59756273d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72485 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Benni Mack authored
When the "collapse" option in the HMENU ContentObject is activated, any active page links to its actual parent page. This option was never touched since TYPO3 4.0 and stems from the time when TYPO3 still included JSMENU and GMENU_LAYERS functionalities, which is not needed anymore as more modern solutions such as MenuProcessor for Fluid are more-widespread. Resolves: #96517 Releases: main Change-Id: I7f16369efaaeb17cc9d510307df808aefedd5945 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72939 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
This patch introduces a new EXT:fluid view class "BackendTemplateView" to be used as main view for backend-related non-Extbase views. This class is the base of a new non-Extbase and non-request dependent backend view. The class is for now marked @internal and experimental since we'll probably add a factory to configure backend template overrides for any backend view later-on. A few ViewHelpers are changed to work without accessing the request if enough VH arguments are provided. This is the first patch in a series of patches that will switch from StandaloneView usages in backend controllers to this new BackendTemplateView. Basic strategy: * $view->getRequest()->setControllerExtensionName('SysNote') is removed. This is Extbase-specific and not needed nor wanted for common non-Extbase controllers. * Instantiate the View (for now with makeInstance, will be replaced with a factory later-on) * Set the needed paths via ->setTemplateRootPaths() etc. For these, we *always* use the main extension's entry templating paths, for instance 'EXT:sys_note/Resources/Private/Templates' or 'EXT:sys_note/Resources/Private/Partials'. We do *not* use sub directories here to clear up path logic. * ->assign() / ->assignMultiple() whatever is needed. * ->render('SubDirectory/TemplateName') the actual action / template, no '.html' suffix. As a demo, EXT:sys_note is adapted accordingly which hands over arguments to the above mentioned VH's in a way so these don't access the request object anymore. The sys_note code gets a couple of additional changes so the hooks can prepare request dependent arguments and set them as template variables (here: returnUrl). This patch triggers a hidden gem: Since ViewHelpers no longer receive an Extbase request, they also don't trigger Extbase magic anymore. The casual victim here is f:translate, which has already been prepared to not trigger Extbase's frontend TypoScript parsing if there is no Extbase request. This often improves backend view performance by 25% or more, depending on the amount of frontend TypoScript to parse. Further patches will adapt other core backend routes and will relate to this patch for reference. Change-Id: I4fec3ad690452a00e731c9f6928273048397dd89 Resolves: #96513 Related: #96473 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72966 Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
dev-rke authored
Fixes 'Undefined array key "crop"' exception in PHP 8.0/8.1 when rendering an image with enabled clickenlarge and defined cropVariants. Releases: main, 11.5 Resolves: #96508 Change-Id: I47dfdf4a1a8c2d5f8465e84eb93c06ed4bb292ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72965 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Bartsch authored
Instead of using multiple "fake" <option> elements with the same value `--div--`, the SelectMultipleSideBySideElement does now use proper HTML <optgroup> elements for grouping of the available options. This is in line with other select elements, e.g. the SelectSingleElement. Besides the improved HTML markup, this also improves the UI, since the <optgroup> element is non-selectable. It is also no longer considered by the filter, which previously led to confusion, especially when filtering and having the "dividers" as only options left. Resolves: #95137 Releases: main, 11.5 Change-Id: Ia51e2623217eb0c7abd6c0cd2e9c4a742686641d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72992 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
Previously, the tstemplate Object Browser would wrongly show hidden typoscript templates, if they were the first one to be found (which determined by the sorting key). The hidden flag will now only be ignored, if a hidden template is explicitly requested by its uid (using the template selector switch). Resolves: #88507 Releases: main, 11.5 Change-Id: Ibbfeb2de7f8ee79a1e343ff23f9d1064219eb344 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63516 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Jan 11, 2022
-
-
Oliver Bartsch authored
With #95387 the menu generation of the page module was moved to the end of the request handling method. However, the `makeActionMenu()` method does currently not only create the menu but does also make some sanity check, whether the currently selected `function` is actually available. If not, the `function` is reset to the default ("columns mode"). This e.g. happens when in languages mode and then switching to another domain / another site, which is single language only. This then led to the user being unable to work in "columns mode", since no action menu is generated for such sites. This is now fixed by executing the mentioned method before the content gets generated. Resolves: #96084 Related: #95387 Releases: main, 11.5 Change-Id: Iadb67ece1724b6d34a4724d7782bdd295cece642 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72971 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
The path gets htmlspecialchared with linkPageATagWrap() and before that it gets treated within getPathFromPageId() already. This change removes the double encoding. Resolves: #90935 Releases: main, 11.5 Change-Id: I7fd9c1afa4462f5d59618ca5ef760356e5d2fa0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72934 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
This change keeps the anchor when clicking on a page in the link browser. Resolves: #93893 Related: #89033 Releases: main, 11.5 Change-Id: I65a876a4fecf508b810e08116810f3cd73e30c19 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72935 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
The method cObj->getMailTo() is only used in EmailLinkBuilder and its functionality is now moved into this class, as the scope belongs to this class. Resolves: #96500 Releases: main Change-Id: Id051a5889997be7a2115a2a68e223797b5a6431c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72944 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Christian Kuhn authored
When having an extension loaded that specifies a cache without a specific backend like ext:adminpanel, the caching framework falls back to default Typo3DatabaseBackend. The scheduler task "Caching framework garbage collection" does not reflect this and renders an empty entry when no specific backend is configured. Fix this by adding the fallback to the tasks additional field provider, too. Resolves: #96504 Releases: main, 11.5 Change-Id: I985ff3b9888723986e7938238be99e45c1999064 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72961 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
NewRecordController (+ icon in doc header of list module) renders "Create a new page" on top. This is not a link and looks misplaced. It is a 'section header' for optional content that can be enabled via pageTS. mod.wizards.newRecord.pages.show.pageSelectPosition = 1 mod.wizards.newRecord.pages.show.pageInside = 1 mod.wizards.newRecord.pages.show.pageAfter = 1 When at least one of these are enabled, the header makes sense, but should be avoided otherwise. Resolves: #96505 Releases: main, 11.5 Change-Id: I6468cda44e719f268f6b59d7e61f240737da6f33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72962 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Oliver Hader authored
The change for issue #94357 introduced handling for `event/` URLs, and accidentally modified handling for `video/` URLs as well. As a result, the `video/` IDs were incorrectly resolved containing a leading slash. Resolves: #96509 Releases: main, 11.5, 10.4 Change-Id: I5623ff59dac44a699877e4e5a2e91707f72a407e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72967 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org>
-
Christian Kuhn authored
Scheduler backend module -> Add button -> add some valid information that makes the form save correctly -> "Save and new" from docheader save drop down -> boom. Resolves: #96506 Releases: main, 11.5 Change-Id: I8eacf1f5f958605f3505761a64902a71bcc0c7dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72963 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
Since modern browsers already decode this "security" measure, the option config.spamProtectEmailAddresses = ascii is removed from TYPO3 Core. Existing installations having the option set to "ascii" will now behave as this option would be set to "0" (= disabled). Resolves: #90044 Releases: main Change-Id: I7fb4266e998ce7f2555f46e6c3ea216745ca54b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72908 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Jan 10, 2022
-
-
Oliver Hader authored
When using a composer-based installation, public frontend assets such as JavaScript of stylesheet files are exposed in a dedicated `_assets/` folder. In those scenarios TypoScript settings for `config.absRefPrefix` need to be applied as well. Resolves: #96452 Releases: main, 11.5 Change-Id: I0695850be18c9c152c647883c122a0680e8e734f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72952 Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org>
-
Andreas Fernandez authored
The maintainer of the `colors` package decided to rampage and released a bonkers version, see [1] and [2], causing an implosion of the npm eco system. Albeit TYPO3 uses this as a transitive dependency only, we're going to be safe and enforce this package to version 1.4.0, the current known to-be-stable version. [1] https://github.com/Marak/colors.js/issues/285 [2] https://www.bleepingcomputer.com/news/security/dev-corrupts-npm-libs-colors-and-faker-breaking-thousands-of-apps/ Resolves: #96499 Releases: main, 11.5, 10.4 Change-Id: Ic8ad9105c9a9bc45bb2519547bb044be672db27c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72949 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Oliver Hader authored
Update to CKEditor v4.17.1 which addressed browser compatibility issues and known security vulnerabilities: https://ckeditor.com/cke4/release-notes Commands: rm -r typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib cd Build yarn add 'ckeditor4@^4.17.1' yarn build Resolves: #96494 Releases: main, 11.5, 10.4 Change-Id: I87039f5a5d1fe7488f6d4c5d0c36e90421d4c93e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72938 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Benni Mack authored
Some code in HMENU stems back from TYPO3 v3.x days, and this code aims to streamline the functionality given current functionality. HMENU now has its own sys_page object, which should be used. In addition, HMENU should fetch TSFE->id consistently across all its code base. Resolves: #96492 Releases: main, 11.5 Change-Id: I971a5958417077d51ea5c5070fc4b9ef513cd738 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72936 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benjamin Franzke authored
This change is preparatory refactoring in order to support native JavaScript modules (ESM) where a module can't be used both as classic script-src and as ES6 module providing exports at the same time (this was/is possible for AMD as implemented in #95953): `export` is an invalid keyword in non-module scripts and cannot be specified conditionally, that is very different to AMD modules where `define()` can be called conditionally. JavaScriptHandler currently has three execution modes: * If used as script-scr: Call processItems from text content for: * RequireJS configuration * Generic JavaScriptItems processing * If used as AMD module: * Generic JavaScriptItems processing JavaScriptHandler is now separated into the following three concerns: JavaScriptItemProcessor ----------------------- The previous processor "mode" is now available as streamlined JavaScriptItemProcessor module, in order to drop type invariance (it requires parsed objects instead of allowing raw json data or objects) JavaScriptItemHandler --------------------- The previous JavaScriptHandler module that processes text content and calls arbitrary hooks has been simplified to the one usecase that was actually being used: Handling JavaScriptItems by parsing the text content. The extracted JavaScriptItemProcessor is used as backend for the actual work. RequireJSConfigHandler ---------------------- The RequireJS configurator is now available as separate module, as this logic is only needed once and not by other modules. There is no need to keep that functionality in JavaScriptItemProcessor, especially as it has been hidden from AMD modules, which complicated the JavaScriptHandler. This extraction also actually allows to make use of modules in JavaScriptHandler and therefore enables the possibility to share code using JavaScriptItemProcessor. Also the code has been migrated to TypeScript. JavaScriptItemHandler and RequireJSConfigHandler do not export or import code, therefore they are usable as plain targets for script-tags. In addition the JavaScriptItemHandler is now executed asynchronously, which allows the browser to parse DOM in parallel. (synchronous mode is required for RequireJS config, but not for loading of requirejs-modules/instructions, they are asynchronous anyway). FileClipboardCest is adapted to wait more than 1 second, since the rerendering of the clipboard (a new iframe request is made) takes longer than 1 second in some test runs (not locally, but on CI) (note: the default 1 second wait timeout is configured in typo3/sysext/core/Tests/Acceptance/Application.suite.yml, but that's too less in this case). Releases: main Resolves: #96476 Related: #95953 Related: #96323 Change-Id: I48a5751cea03537344e925beba365841e0855dde Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72892 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Oliver Bartsch authored
This restores the sort link for columns with "special" label, such as "tstamp" or "crdate". Resolves: #96489 Releases: main, 11.5 Change-Id: Iae7c9d2056256df5156f6fe8773d6b18e7ba8898 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72947 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Benni Mack authored
Resolves: #96490 Releases: main Change-Id: I43218e8f99f062fc43f14e1b26d7b68d8ca5414d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72937 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Hader authored
Update to @claviska/jquery-minicolors v2.3.6 which addressed known security vulnerabilities: https://security.snyk.io/vuln/SNYK-JS-CLAVISKAJQUERYMINICOLORS-1930824 https://github.com/claviska/jquery-minicolors/releases/tag/2.3.6 Commands: cd Build yarn add '@claviska/jquery-minicolors@^2.3.6' yarn build Resolves: #96495 Releases: main, 11.5, 10.4 Change-Id: Iaafdd29dd50a18321746fb36702702302078fceb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72940 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Oliver Bartsch authored
The linkvalidator module shows the path to the page, a broken link is on. Since editors might only have access to a subtree (mount point), the corresponding parent pages should not be displayed. This is now fixed by providing the necessary permission clause to `getRecordPath` in LinkValidatorController. Resolves: #92539 Releases: main, 11.5 Change-Id: Ibdb54560561dba5d7ad932d89ff5b73fc558f5f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72905 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
Resolves: #96481 Releases: main, 11.5 Change-Id: I41eeb4ecf0b90e998875701131b2c8a35bfa3225 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72906 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
This change uses typolink in EmailViewHelper, allowing to also use typolink hooks or custom Email Link Builder to be used consistently across TYPO3 Core (e.g. using the same hooks for all email link generation in the Frontend). Resolves: #96483 Releases: main, 11.5 Change-Id: Ia573dc5a7ebb9ca7f0f0b6b35126bd789f86a627 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72897 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
During the main work of TYPO3 v9 when Site Handling was introduced, the Page Link Builder turned into a single monster-method. Now, that most bugs are solved and we have a very good test coverage for this, this change splits several functionality into smaller methods, allowing for better readability, extensibility and further refactoring. Extending PageLinkBuilder now is much easier to replace a certain part of the existing functionality (also via XCLASS). Resolves: #96484 Releases: main, 11.5 Change-Id: I231cf3c13ec15dd1ad99f710ca27ce340c0deee2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72898 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Jan 08, 2022
-
-
Stefan Frömken authored
Releases: main, 11.5 Resolves: #96488 Change-Id: I0ced03e4d551048414022214b832b3ceeb51400d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72933 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-