- Aug 23, 2018
-
-
Helmut Hummel authored
Deprecations that trigger an error in early bootstrap lead to the situation that code that is using this (mostly declared) internal API will likely fail due to these errors, as they are not caught by the regular error handling, which is initialized later on. Userland code using this API will notice the depreaction even without those errors triggered. Therefore remove those deprecations errors in most places again so that tools like TYPO3 Console will be able to stay compatible with older TYPO3 versions as well. Also protect some methods straight away and add a deprecation layer for them. Resolves: #85944 Releases: master Change-Id: I97485dfd947028cf02ff62b17b453d2f174a531a Reviewed-on: https://review.typo3.org/58003 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
andypa authored
Fixed a typo and added an example for EXT:indexed_search. Releases: master, 8.7 Resolves: #85942 Change-Id: Iffcecd753843733ef96c9e41da808a47b943405e Reviewed-on: https://review.typo3.org/58002 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Oliver Hader authored
Resolves: #85941 Releases: master Change-Id: Icbbeb31e8c905fc52523ee1c0267ac219e19c15f Reviewed-on: https://review.typo3.org/58001 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Susanne Moog authored
To better debug websites SQL logging has been added to the admin panel. SQL queries will be logged whenever the admin panel is installed and activated for the current user and request. Queries using query parameters are displayed with all occuring parameter values (grouped by the main query). To find where queries came from a short backtrace has additionally been added to the query logging. The logging itself has been implemented using the doctrine query logging functionality. Resolves: #84609 Releases: master Change-Id: I84eebc8a23d6fa15c20dc48781409d4ab03f1bb1 Reviewed-on: https://review.typo3.org/57889 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Willi Wehmeier <wwwehmeier@gmail.com> Tested-by:
-
Benni Mack authored
A new TCA type "slug" is added, which allows to generate a part of a URL which can later be used for adding URL segments to any kind of record. The new slug TCA type will be added to the pages database table separately to fill a page with the rootline "Home => Products => My Product" with "/products/my-product/details/" into the slug field when creating a subpage "Details" under "My Product". Once the slug field is added when persisting the record, changing a title (like the page title) will not modify the slug anymore, but instead this has to be modified separately. Next steps: - Add the TCA type "slug" to pages table - Introduce an upgrade wizard for that pages table - Improve FormEngine via AJAX validation of "uniqueInSite" for slugs - Implement slug resolving for pages. Resolves: #84729 Releases: master Change-Id: I079267f42308f40da71ab4765ba7e0251e79f736 Reviewed-on: https://review.typo3.org/56889 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Gerald Aistleitner authored
Changed the default value of linkText to '' instead of null to prevent strict_type throwing an error. Resolves: #85933 Releases: master, 8.7 Change-Id: I0a7567cd784360654649c11e686784ad3867858d Reviewed-on: https://review.typo3.org/57995 Tested-by:
Joerg Kummer <typo3@enobe.de> Tested-by:
-
Stefan Froemken authored
Add a white-space in front of default CSS class for buttons in field control wizards. Resolves: #85935 Releases: master, 8.7 Change-Id: Ie4889b20ba95cf96f6895d5fc2e5375c70c48cc9 Reviewed-on: https://review.typo3.org/57996 Tested-by:
-
- Aug 22, 2018
-
-
Benni Mack authored
In order to avoid usages of using PseudoSite objects directly, the following changes have been made: The main entrypoint for finding sites is now encapsulated the SiteMatcher class. * SiteMatcher->matchByPageId($pageId) which consistently checks for Sites and Pseudo Sites. This is now a singleton as it factors PseudoSiteFinder directly. * NullSite for PID=0 (which is a slim version of a PseudoSite and will stay around for longer than the PseudoSite). This marks the last part of the Site API functionality, as TYPO3 is now ready to work with the Site API in all places throughout Frontend and Backend. Resolves: #85930 Releases: master Change-Id: I5e75da22337e126a39b459388e21d7f9fe05e556 Reviewed-on: https://review.typo3.org/57992 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Christian Kuhn authored
With pseudo sites we now always have a site object in backend. The site object is needed multiple times in FormEngine, the upcoming slug handling adds another usage. The patch adds a FormEngine data provider to resolve the site object for any given page or record and adds it as 'site' to the result array. Resolves: #85927 Releases: master Change-Id: I7ebbd2e6591b54a54b6a5b56f95161b4ba6e5cee Reviewed-on: https://review.typo3.org/57990 Tested-by:
-
Daniel Goerz authored
Resolves: #85926 Releases: master,8.7 Change-Id: Iaa36ce61de922d367d285ad5f98bfef8f2ee4714 Reviewed-on: https://review.typo3.org/57988 Tested-by:
Achim Fritz <af@achimfritz.de> Reviewed-by:
-
Georg Ringer authored
Instead of rendering all languages, only the ones provided by the site module are now shown in forms of the FormEngine, in the List module, the Info->Translation Overview and the Page module. Fallbacks to pseudo sites are considered if no site configuration for a page / page tree exists. Resolves: #85164 Releases: master Change-Id: I95b394cd3a31773e62f7e2cc40197aceb97705d8 Reviewed-on: https://review.typo3.org/57672 Reviewed-by:
-
Oliver Hader authored
Current side handling functional test cases only support link resolving and rendering. The opposite part of generating links has been introduced with this change. Besides that, existing rendering tests have been extended for frontend restricted page rendering. Resolves: #85922 Releases: master Change-Id: Ie12c2883463e5560dd03e18dab3dc3a277076815 Reviewed-on: https://review.typo3.org/57923 Tested-by:
-
Oliver Hader authored
DataHandler can be invoked with an individual backend user context and will fall back to $GLOBALS['BE_USER'] in case it's not defined. In order to make use of that behavior completely this individual context has to be forwarded to all nested DataHandler instances as well. Resolves: #85920 Releases: master Change-Id: Ibcbba7d04d0967955937f838b6514a478b88d038 Reviewed-on: https://review.typo3.org/57985 Reviewed-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
-
Oliver Hader authored
The DataHandler::$suggestedInsertUids feature is currently only used for regular live records, however not for new version placeholders - which in fact are the pendant for a regular live records, with the additional binding to a specific workspace context. Resolves: #85921 Releases: master Change-Id: I320ab26be3c60983640d3c5f61338689b9068209 Reviewed-on: https://review.typo3.org/57986 Tested-by:
-
Susanne Moog authored
* adds missing timetracker->push() * removes unnecessary call to printTSlog * reuse existing variable in fixContent, to avoid notices Resolves: #85916 Releases: master Change-Id: I6e7b1f8872d1f058abc93802660ba625bbcf2d24 Reviewed-on: https://review.typo3.org/57890 Tested-by:
-
Benni Mack authored
Whenever a sys_domain or sys_language record, the information a Pseudo Site is built by, is modified, created, deleted, moved (for sys_domain only), the caches need to be flushed so they can be rebuilt. Resolves: #85919 Releases: master Change-Id: Icc6b018a15b5679b666d0050405d502f35963dbe Reviewed-on: https://review.typo3.org/57984 Tested-by:
-
Andreas Fernandez authored
The "Paste" action now does not depend on the `DragDrop` anymore. Previously, the `onDrop` event callback was called manually which is wrong in that case, as the callback does far more calculations than necessary when doing a simple paste action. In the same run, the DragDrop module has been simplified, the module now doesn't know anything about pasting content elements anymore. Resolves: #85912 Releases: master Change-Id: I3a8943e90a92c0ad4afec9e87091f9cd1878c34c Reviewed-on: https://review.typo3.org/57970 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Manuel Selbach <manuel_selbach@yahoo.de> Tested-by:
-
- Aug 21, 2018
-
-
Benni Mack authored
All pages on rootlevel or with "is-siteroot" need to have a site object as well, but populated by sys_domain (optional) and all available sys_language records. However, this information needs to be compiled within an entity called "PseudoSite". This way, the page-based routing ("slug handling") can use the functionality to detect the uniqueness of a slug within a page tree. The routing of sites is moved to a "SiteMatcher" API class, returning all found information on a request for a site, also encapsulating the Symfony/Routing component in there. This would be exactly the step where further information about a URL will then be resolved. Next steps are the usage of Sites and PseudoSites in TYPO3 Backend, allowing to only show e.g. languages that are configured, which can be done via $site->getAvailableLanguages(). Resolves: #85900 Releases: master Change-Id: Ia2d27e58f21b5c89dc67dffcbc82d6612b350988 Reviewed-on: https://review.typo3.org/57767 Tested-by: -
Aljoscha Weber authored
Replace _GP, getIndpEnv usages with request related functions. Also deprecate public access to all method except the entry point. Resolves: #84375 Releases: master Change-Id: I8050afe519dcbabfd6381c55844c81713482687e Reviewed-on: https://review.typo3.org/57329 Reviewed-by:
-
Stephan Großberndt authored
Due to some database changes during the installation process of an extension, the patch https://review.typo3.org/57486/ misses to pass the extension key instead of the enriched extension information array. Resolves: #85915 Related: #79094 Releases: master, 8.7 Change-Id: I708a99f47a2c493f68d224b9ffca4ec6c008f827 Reviewed-on: https://review.typo3.org/57979 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Helmut Hummel authored
Instead of depending on a global environment variable to set the TYPO3 environment in cli mode, we inject the mode properly from within the entry point. We now move the code to initialize the environment to SystemEnvironmentBuilder:run() where we can evaluate the request type passed to this method, to properly set cli or non cli mode. Depending on a global env to set the TYPO3 environment would require hacks, like changing the global env to properly select the cli mode (currently done in testing framework). Using an application sub context for that purpose isn't ideal either, because at best we would need to also test for magic contexts like "Production/Frontend" or "Development/Frontend" and at worst it conflicts with user defined contexts. It wouldn't be possible to define a sub context and still properly start a frontend application within this context. composer req --dev typo3/testing-framework ~4.4.1 Resolves: #85757 Releases: master Change-Id: Ia64d358e731d9ddf717497ae120acb009e0f26fa Reviewed-on: https://review.typo3.org/57816 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- Aug 20, 2018
-
-
Benni Mack authored
The legacy naming for the shorthand method "extGetLL" was moved to "getLabel" for both the edit toolbar and the EXT:feedit panel. Resolves: #85905 Releases: master Change-Id: I4fdad2127d40cc2850237311f3bc3f56c85ca394 Reviewed-on: https://review.typo3.org/57964 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Benni Mack authored
Just additional comments in TSFE. Resolves: #85906 Releases: master Change-Id: I7301370fab406bd5d9c395b7d092688d56bac9e3 Reviewed-on: https://review.typo3.org/57965 Reviewed-by:
-
Benni Mack authored
The felogin plugin implements a protected short-hand getter "getTypoScriptFrontendController" although this is never used. Resolves: #85903 Releases: master Change-Id: I0ee7e88a196739d0c3ef64bb80536f5c3372c79d Reviewed-on: https://review.typo3.org/57961 Tested-by:
-
Benni Mack authored
With TYPO3 v9.0, all simple TYPO3_MODE checks of all system extensions were removed, however EXT:rsaauth was somehow forgotten. Resolves: #85904 Releases: master Change-Id: If76b25813d323e0604a0a48596f2cd3d113f833a Reviewed-on: https://review.typo3.org/57963 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
- Aug 19, 2018
-
-
Andreas Fernandez authored
If files in a remote storage are fetched the first time by FAL, the metadata of these files is now extracted automatically, if the storage supports this feature. Resolves: #85786 Releases: master, 8.7 Change-Id: I4006ea2f39bbbbf0d6fe6a1f2adf2e79cdfbd5c5 Reviewed-on: https://review.typo3.org/57842 Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Anja authored
command used: composer require codeception/codeception:^2.4.5 Change-Id: Ie3a81ef7591d1beb7beadf06c3e009444c6d5180 Resolves: #85899 Releases: master Reviewed-on: https://review.typo3.org/57958 Tested-by:
-
Anja authored
Change-Id: I034b11478e2ac8b5d15c298d69afcc944626eb1d Resolves: #85898 Releases: master Reviewed-on: https://review.typo3.org/57957 Reviewed-by:
-
Wouter Wolters authored
Resolves: #85891 Releases: master Change-Id: Ie848059591cb69d9e6fad6c2c6275b9655e6ff87 Reviewed-on: https://review.typo3.org/57948 Tested-by:
-
- Aug 18, 2018
-
-
Benni Mack authored
Core provides various places to either retrieve the pageId of a sys_domain record, or to find out the root page ID given a request (previously domain + path). However, due to the inclusion of symfony/routing, the detection can now be handled by this new component. For this purpose, a new class LegacyDomainResolver is introduced (internal) which utilizes symfony/routing under the hood and does proper caching. This way, the following methods can be deprecated: - TypoScriptFrontendController->domainNameMatchesCurrentRequest() - TypoScriptFrontendController->getDomainDataForPid() - BackendUtility::getDomainStartPage() - BackendUtility::firstDomainRecord() This is a precursor for fetching all sys_domain data, to minimize the efforts later-on to wrap the LegacyDomainResolver into a proper Router, and also to build pseudo-sites on top. Resolves: #85892 Releases: master Change-Id: I831d33ac06f090cbe4d2a16e592549739489f99a Reviewed-on: https://review.typo3.org/57949 Tested-by:
-
Christian Kuhn authored
Admin tools -> Settings is extended by a GUI to manipulate feature toggles. Note this interface lists only core features at the moment since extensions currently have no way to extend DefaultConfigurationDescrition.yml with additional information. Resolves: #85894 Related: #83429 Releases: master Change-Id: I7ae03c87f2bf94281d4d63d2ff80c6f0460807cb Reviewed-on: https://review.typo3.org/57952 Tested-by:
-
Alexander Schnitzler authored
Instead of using generic deprecation messages like "Tagging methods with @ignorevalidation is deprecated and will be removed...", deprecation messages should contain the affected class and method/property name. Releases: master Resolves: #83255 Change-Id: I0ec1a5739c7b9eaa39e8447d19c410de27d2d3c8 Reviewed-on: https://review.typo3.org/57956 Tested-by:
-
Oliver Hader authored
Some additional tests are added and the scenario is extended with pagetrees without a site (sys_domain in use). Resolves: #85897 Releases: master Change-Id: I5c6f61c59e9383de2199dbbc687fdd0924cde1af Reviewed-on: https://review.typo3.org/57955 Tested-by:
-
Wouter Wolters authored
* Simplify FQN of QueryParser * Use correct typehint for $pageIdList, is an array and not a string * Switch if statement order to use the less expensive one first * Surround hard to read or-statement with parentheses * Directyly return result in getAvailablePageIds Resolves: #85889 Releases: master Change-Id: I93b11a4d1480767902435d392a6f6af518bac53f Reviewed-on: https://review.typo3.org/57946 Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- Aug 17, 2018
-
-
Oliver Hader authored
Parameters submitted to ThumbnailController via HTTP GET query parameters can contain arbitrary information. Thus, it has to be verified that those parameters are valid by signing them with a HMAC. Prior to that the source code was vulnerable to information disclosure as well as denial of service attacks due to unsanitized user input. A valid backend user account was required in order to make use of these flaws. Since the change which introduced this behavior was not released yet, the security fixes are handled in public without additional announcements. Resolves: #85875 Releases: master, 8.7 Change-Id: Ia53ba3756f140b0728b8fd1fb7e0527836639a6b Reviewed-on: https://review.typo3.org/57943 Tested-by:
-
Benni Mack authored
A minor issue with the wrong property when calling enabled() vs. "isEnabled()" was introduced. Resolves: #85164 Releases: master Change-Id: I99afd802db480c6c4b03263c5972867a4273020e Reviewed-on: https://review.typo3.org/57951 Reviewed-by:
-
Christian Kuhn authored
Add a couple of missing numberOfMandatoryArguments lines to the MethodCallMatcher definitions to fix the extension scanner that validates these files at runtime. Change-Id: I029d16d4d63b275c134b0483200a716111c913c2 Resolves: #85893 Releases: master Reviewed-on: https://review.typo3.org/57950 Reviewed-by:
-
Daniel Goerz authored
Resolves: #85890 Releases: master Change-Id: I73972920dbb7046e8ab7cf95577cb2f5af99c095 Reviewed-on: https://review.typo3.org/57947 Reviewed-by:
-
Wouter Wolters authored
Resolves: #85878 Releases: master Change-Id: If35be25607823ab40ad1dc91843bc60562e6752f Reviewed-on: https://review.typo3.org/57945 Tested-by:
-
Benni Mack authored
FrontendEditingController calls up DataHandler if the right get/post parameters are added. This code is specific for EXT:feedit and extracted into EXT:feedit, as FrontendEditingController is mixing concerns (rendering panels and persisting). Resolves: #85877 Releases: master Change-Id: Ib39fe8b7ddcf68fb9e93d8a08564ae7f550e95f3 Reviewed-on: https://review.typo3.org/57932 Tested-by:
-
