- Sep 12, 2023
-
-
Benni Mack authored
Change-Id: Ifbec918791cf47b39f7d9119c26e7150a98d9123 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80978 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Benni Mack authored
Change-Id: Iff5650d67aec9e2deebe013a0761481158b566e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80977 Tested-by:
-
Benjamin Franzke authored
Avoid using bootstrap modal API directly and instead use the modal infrastructure we already have in place. As a side effect jquery requirement is removed as well. Resolves: #101816 Related: #101820 Releases: main, 12.4 Change-Id: Iad441aaccbdfc9391aec0eb989c65ece457847b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80992 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
- Sep 11, 2023
-
-
Benjamin Kott authored
Use actions-sort-* icons for table sorting and use accessible elements (button/a) in sorting triggers. Resolves: #101881 Releases: main, 12.4 Change-Id: Ie6de4500bf3819ea2c9b260456d05d9baee35f23 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80949 Reviewed-by:
-
Oliver Klee authored
There is no point repeating the name of the extended class in the class PHPDoc comment. This makes creating new fixture classes less of a hassle. This is a separate change in order to make the other changes that get rid of `getMockForAbstractClass` shorter and more focused, following the "one kind of change per change" principle. Resolves: #101665 Related: #101601 Releases: main, 12.4 Change-Id: I7ee95e63149ff90c6f5817438e5b4634d04f4e93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80947 Tested-by:
-
Oliver Klee authored
`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1: https://github.com/sebastianbergmann/phpunit/issues/5241 Hence, we should replace its usages to follow best practices and avoid deprecation warnings later with PHPUnit 11. We do this by creating dedicated fixture subclasses of the affected abstract classes. Resolves: #101666 Related: #101601 Releases: main, 12.4 Change-Id: I0263ff7b0639d72ba1d4f30e3bee12276d364591 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80946 Tested-by:
-
Oliver Klee authored
`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1: https://github.com/sebastianbergmann/phpunit/issues/5241 Hence, we should replace its usages to follow best practices and avoid deprecation warnings later with PHPUnit 11. We do this by creating dedicated fixture subclasses of the affected abstract classes. Resolves: #101630 Related: #101601 Releases: main, 12.4 Change-Id: I27f526cb7ee4e1f2081c05befd3d70549dd0e2fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80945 Tested-by:
-
Oliver Klee authored
`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1: https://github.com/sebastianbergmann/phpunit/issues/5241 Hence, we should replace its usages to follow best practices and avoid deprecation warnings later with PHPUnit 11. We do this by creating dedicated fixture subclasses of the affected abstract classes. Resolves: #101661 Related: #101601 Releases: main, 12.4 Change-Id: I3b9ba4511620aebf125ff207428adc5483d47154 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80944 Reviewed-by:
-
Oliver Klee authored
`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1: https://github.com/sebastianbergmann/phpunit/issues/5241 Hence, we should replace its usages to follow best practices and avoid deprecation warnings later with PHPUnit 11. We do this by creating dedicated fixture subclasses of the affected abstract classes. Resolves: #101892 Related: #101601 Releases: main, 12.4 Change-Id: Id1977130c5e2a9bdc54fb92aea7dfc63ecf55724 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80952 Tested-by:
-
Torben Hansen authored
Currently, extbase `ConfigurationManager` is directly used in ext:felogin for the password recovery functionality. With this change, `ConfigurationManagerInterface` is used instead of `ConfigurationManager`, so DI can decide which implementation of `ConfigurationManager` should be used. Resolves: #101894 Releases: main, 12.4 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I0a09e88b3d778f3da850fbd753d5ef43cdbb9f25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80953 Reviewed-by:
-
- Sep 10, 2023
-
-
Oliver Wand authored
When performing `Build/Scripts/runTests.sh -s cglGit` with latest cs fixer version a rule dependency error is thrown. This patch exchanges the deprecation with the current recommended rule. Used command(s): > composer require --dev \ "friendsofphp/php-cs-fixer":"^3.26.1" > Build/Scripts/runTests.sh -s cgl Resolves: #101888 Releases: main, 11.5, 12.4 Change-Id: Ie139ef841c92461e116732923991c6474e888a5e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80936 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Sep 09, 2023
-
-
Benjamin Franzke authored
Add typo3/ infix as images were otherwise tried to be updated from ghcr.io/core-testing-* instead of ghcr.io/typo3/core-testing-*. Resolves: #101885 Releases: main, 12.4, 11.5 Change-Id: I4a866971158916264d21435377d43d2b843bf16d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80910 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Stefan Bürk authored
Using function imports with `use` is usually not used in the TYPO3 core. Due to an oversight in the review for #92768 this slipped in. This change uses the `self::assertCount()` instead of the import function `assertCount()` to follow current policy again. Resolves: #101884 Related: #92768 Releases: main, 12.4 Change-Id: Ia3da8eaf1c6a00f331af83fd1efd88f125e60be5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80909 Tested-by:
-
- Sep 08, 2023
-
-
André Buchmann authored
When the parent record has been set to sys_language_uid=-1, but the child record has translations, it should be displayed in the correct language. Setting the languageUid for the querySettings to -1 results in display of the default language record of the child. Resolves: #92768 Releases: main, 12.4, 11.5 Change-Id: I25bcdbb182c1b35cbc08e5f91339453b0986cdcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80907 Tested-by:
-
Stefan Bürk authored
This change uses the core LinkFactory (FE) for creating links in f:link.action and f:uri.action when not executed in an Extbase context in order to avoid booting up Extbase. To operate in without Extbase context all Extbase related arguments are required to be passed as there is no fallback for determination based on Extbase configuration. Note: This change uses the same boilerplate approach as #98474. The intention is to replace that with an universally usable Extbase URI builder in TYPO3 v13. Resolves: #101729 Related: #100758 Related: #98474 Releases: main, 12.4 Change-Id: Ib5c27c46e9420947c0347c05c299cd67badb52ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80908 Tested-by:
-
Friedemann Altrock authored
ContentObjectRenderer::getImgResource is used for the content objects IMAGE, IMG_RESOURCE, as well as GIFBUILDER to process images. When it is passed a FileReference object, it should respect the crop settings of this reference, same as when it is passed a reference UID plus the treatIdAsReference config. Resolves: #101810 Releases: main, 12.4, 11.5 Change-Id: I399106399ec283561c00fa5cf61d6c7fe2871e49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80906 Tested-by:
-
Benjamin Kott authored
In order to ease the usage of DatabaseRecordList in core, the setDisplFields() call is not needed and can be handled within the start() method directly. The method calls are thus removed from the calling code. Resolves: #101859 Releases: main, 12.4 Change-Id: Id7df77c9e5e301ea31eccced3c25f13ff9a44833 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80905 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Helmut Hummel authored
When a junction already exists on Windows, it is tried to create a symlink, because of a missing OS check. While this works as errors are ignored, it is an unnecessary filesystem call. Therefore the code is changed to only emit the appropriate filesystem operations per OS. Resolves: #101871 Related: #98434 Related: #98447 Releases: main, 12.4, 11.5 Change-Id: Ifafadceae3742da23fd1a40e5aab50074e60313c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80904 Tested-by:
-
Benni Mack authored
When an oembed provider does not send an "author_name" property, then the request fails, and there is a sys_file without a sys_file_metadata. This then results that the show info popup does not work. Resolves: #101877 Releases: main, 12.4, 11.5 Change-Id: If6ead0084664372b9133fdd544ede90aa8a0e5d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80903 Reviewed-by:
-
Elias Häußler authored
With #100663, "Before" and "After" sections for backend modules were introduced. However, the appropriate <f:render> calls were applied to the main module layout in EXT:backend only. Since EXT:info provides an overridden layout, those sections were no longer rendered, leading to invalid JavaScript and missing functionalities. This is now fixed and the appropriate <f:render> calls are added to the module layout of EXT:info as well. Resolves: #101876 Related: #100663 Releases: main, 12.4 Change-Id: I4479811e974433fa1201c7fd2c12be99bf921663 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80902 Reviewed-by:
-
- Sep 07, 2023
-
-
Julian Mair authored
With the initial upgrade to CKEditor5 in TYPO3 v12, the 'ShowBlocks' plugin was not available upstream, so this feature got lost. As of CKEditor5 v38.1.0 [1] the plugin has been reintroduced. We include the plugin now and add it to the Full RTE preset configuration by default. Executed commands: npm install --save @ckeditor/ckeditor5-show-blocks@38.1.0 grunt build [1] https://github.com/ckeditor/ckeditor5/releases/tag/v38.1.0 Resolves: #101330 Releases: main, 12.4 Change-Id: I82b4f3adbf70ed5beb101188d65a84c7e6b568f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80901 Tested-by:
-
Helmut Hummel authored
ContentObjectRenderer is now added as request attribute in certain cases. But since the signature of obtaining an attribute from a request correctly states, that the attribute can be null, consuming code should account for that and defensively fall back to defaults, when the object can not be obtained. Releases: 12.4, main Resolves: #101201 Change-Id: I3b3145794cafd8f5a8c1081e97599f9862be8b99 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80921 Tested-by:
-
Stefan Bürk authored
With #99221 the cli setup command has been introduced to setup a instance from the command line and improved with followup changes. This works pretty fine in composer mode installations. In non-composer mode installations the package state file is not created using the cli command whereas the web based installation process creates one. This change ensures that a package state file is created if none exists. If no file is found, it creates it based on default factory settings like the installer. Resolves: #101678 Related: #100719 Related: #99221 Releases: main, 12.4 Change-Id: I022c4300131d0eca82569ef0463d0c0078c53055 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80900 Tested-by:
-
Helmut Hummel authored
Only create one filesystem object, instead of always creating new ones where needed. Resolves: #101870 Releases: main, 12.4 Change-Id: I56a47f412fded7585425098f18f1d7090baf09d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80896 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Stefan Bürk authored
This change uses a slighty modified httpd (apache2) image based on alpine along with a own php-fpm image to spawn up a webserver with php-fpm in two containers as a replacement for the `php -S` webserver used prior. Modification for the apache2 (httpd) image are minimal and gives us the ability to mount the project with the exact same path in the image as from outside. Further all required apache2 modules are loaded missing the official image. Due to moving away from the php webserver we now need to adjust some configurations: * Use port 80 instead of 8000 the for acceptance and acceptanceInstall tests webserver. * Use the acceptance test instance as DocumentRoot instead of the monorepo root. * Copy several `.htaccess` files to the acceptance test instance as we now have a real apache2. * Copy the favicon.ico to the test instance instead of the monorepo root. * Ensure that created frontend SiteConfiguration no longer uses the relative test instance path. Simply use `/`. * Use only the php-fpm image for cli and webserver fpm container. Resolves: #101827 Releases: main, 12.4 Change-Id: I25367dd30963958c303bb91cea39adf4099f8718 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80917 Tested-by:
-
Kevin Appelt authored
- Short description of the function - Hint that TYPO3 sets default values - Hint that setting a value will remove the page from the XML sitemap The behaviour can be changed by the integrator/developer of cause, but the label can be changed via TCA override in that case. Resolves: #101841 Releases: main, 12.4 Change-Id: Ic74e02fa4de4aa0a6708123caa596271b7b27561 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80899 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Andreas Fernandez authored
Submitting the paging form in the record list's single table view was broken as the "View webpage" button wasn't explictly defined as a button, which in fact made it a submit button that opened the first page in the record list in a new tab. This patch does two things: * The button element is now explicitly declared being a "dumb" button * The JavaScript building the URL is simplified to use the existing URL in the form, which makes the data attribute that holds the "template" obsolete Resolves: #101540 Related: #101276 Releases: main, 12.4 Change-Id: I9184b3871452aed0b130a32a1405434e0fb9a9db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80898 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Benjamin Kott authored
Resolves: #101857 Releases: main, 12.4 Change-Id: I6ef205a00f0e6128c816e694ede60751e8d84966 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80897 Reviewed-by:
-
Andreas Fernandez authored
When triggering modals via the `.t3js-modal-trigger` class, it is now possible to configure a modal's size via the `data-size` attribute, accepting all modal sizes: * `small` * `default` * `medium` * `large` * `full` Resolves: #101867 Releases: main, 12.4 Change-Id: I3932c3b3d9ee23904077e21a7362667d831dafc7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80895 Tested-by:
-
Helmut Hummel authored
There is no downside in making the argument optional. Although the API is marked as internal, it is in use in third party code, which would break within a bugfix release. Logically the API makes total sense with the argument being optional. If the webserver type is not known or not provided, no additional file is created. Resolves: #101868 Releases: main, 12.4 Change-Id: Ie559b8685fc582681befe09ff769724f13639862 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80894 Reviewed-by:
-
Benjamin Franzke authored
The module components (like the iframe wrapper) are created asynchronously after their implementing module (e.g. <typo3-iframe-module>) is loaded. The router had a preparatory check that verified that existing module elements are reused, but missed to verifiy whether the element has been created in parallel while the module components javascript module was loaded. This happens when the module changes while the module component is loaded for the first time. That leads to a situation that the module componenent was created twice, which rendered two module frames into the backend. Also resolve a long overdue todo while at it. Resolves: #101851 Releases: main, 12.4, 11.5 Change-Id: I069f9e924d38b3abeb70c6d4e805d9c43a4f05e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80893 Tested-by:
-
Andreas Fernandez authored
This patch updates `typescript` to 5.2 and `@typescript-eslint` packages to 6.6. Updating `@typescript-eslint` revealed a broken condition in the `@typo3/backend/viewport/navigation-container` module that is now removed. Executed command: npm install --save-dev \ @typescript-eslint/eslint-plugin@^6.6.0 \ @typescript-eslint/parser@^6.6.0 \ @typescript-eslint/typescript-estree@^6.6.0 \ typescript@~5.2.2 Resolves: #101864 Releases: main, 12.4 Change-Id: I7fd1e5997b6b19124d8fcac8402db79d3fd05f6d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80890 Tested-by: -
Sybille Peters authored
The possibility to mark broken links with the `data-rte-error` attribute and styling was removed in TYPO3 v12. This is now added again to allow for linkvalidator and other extensions to mark broken links which will then be visibly styled differently when editing in the RTE. This affects only the backend. The attribute data-rte-error is removed when persisting the content to the database. The logic for adding this attribute is still in place: The linkvalidator uses the event `BrokenLinkAnalysisEvent` which is dispatched in `RteHtmlParser`. A marked broken link may look like this: ```html <a href="t3://page?uid=42" data-rte-error="External link is broken">link</a> ``` Note that the functionality got disabled with the new ckeditor in #96874 while the implementing plugin "showbrokenlinks" was removed later with #98497. The CSS is therefore restored from the state as of before #98497. Resolves: #101357 Related: #96874 Related: #98497 Releases: main, 12.4 Change-Id: I898b1de1b9bb9bf334740dc3b7ec8eb70627bed4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80892 Tested-by:
-
Georg Ringer authored
Check if a field exists before accessing it. Resolves: #101852 Releases: main, 12.4, 11.5 Change-Id: I95d227d920975b1e348c95a1069a9ddddcddc900 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80850 Tested-by:
-
Benjamin Franzke authored
With the deprecation removal of regular expressions based EXT:form validators in #101070, the set of available validators for the form element type URL became empty. (See EXT:form/Configuration/Yaml/FormElements/Url.yaml) Instead of only removing the select element from the DOM, the entire form-group is now removed, in order to also hide the corresponding <label> tag, as such a stray label tag isn't helpful for an enduser and is therefore actually even invalid HTML (as the reference to an input element is missing). Resolves: #101749 Related: #101070 Releases: main, 12.4, 11.5 Change-Id: Ib0d34e94e2c3ba109133dac64374f04f7c91329b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80730 Tested-by:
-
Benjamin Franzke authored
All in-tree .js files have been migrated to TypeScript, so it's time to add a CI check to ensure no stray build files (see #101786) or non-updated JavaScript files (e.g. #101784, #101785, #101787) are present in the git tree. Resolves: #101783 Related: #101784 Related: #101785 Related: #101786 Related: #101787 Releases: main, 12.4 Change-Id: I02aeaaeaae7fa0df634f39cb151f4316240936ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80869 Tested-by:
-
Stefan Bürk authored
This change raises the minimum version constraint for the `typo3/testing-framework` to ensure that required changes are available as preparation to backport the `apache2+php-fpm` based acceptance test execution. Used command(s): > composer require --dev typo3/testing-framework:^8.0.5 Resolves: #101863 Releases: 12.4 Change-Id: Ice125ef8fa93e84a01b3ad29ede6d6b0973f3e3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80887 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Sep 06, 2023
-
-
Benjamin Kott authored
Resolves: #101856 Releases: main, 12.4 Change-Id: I41d3c07b44b544cd88e56e137dc0fb20ca38cb18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80849 Tested-by:
-
Stefan Bürk authored
With #101739 a bug has been reported, which is not correct. This change adds functional tests to `ext:redirects` to show and cover that: * regexp redirects with a pattern not covering params but query arguments are given in the request uri and "Respect GET Parameters" has been set do not redirect. * RegExp Redirects with a pattern not covering params and no GET arguments are given in the request uri but "Respect GET Parameters" has been set redirects to the target url. Resolves: #101739 Releases: main, 12.4, 11.5 Change-Id: I023889ba6fefe5a4b06b392e02dece4b6ac517c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80848 Tested-by:
-
Stefan Bürk authored
During the migration to the specific TCA type `link` with #97159 the allowed link types for the field in the siteConfiguration->static-routes have been added incorrectly. This change re-adds the file link-type as allowed link type to that field. Resolves: #101837 Related: #97159 Releases: main, 12.4 Change-Id: Iee40a86fe115749482c2aa0faa2c887adb4d025b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80847 Reviewed-by:
-
