Skip to content
Snippets Groups Projects
  1. Jul 20, 2012
    • Francois Suter's avatar
      [BUGFIX] QT movies prefixed abusively in Media CE · 9b9c6180
      Francois Suter authored
      If some prefixes are defined (either base URL or absRefPrefix),
      the Media CE will apply such prefix to any Quicktime movie
      even if said movie is referenced by an absolute URL.
      
      Change-Id: Ibe8b24da5fdf3689d841987f45e91c750a7a002c
      Fixes: #39026
      Releases: 6.0,4.7,4.6,4.5
      Reviewed-on: http://review.typo3.org/12847
      Reviewed-by: Francois Suter
      Tested-by: Francois Suter
      9b9c6180
    • Christian Kuhn's avatar
      [!!!][TASK] Remove old XCLASS compatibility layer · 5b1ae6a8
      Christian Kuhn authored
      The XCLASS handling that was changed with #31893 allows to register
      XCLASS'es with an entry in ext_autoload. The patch introduced a
      compatibility layer to support the old registration by guessing the
      needed array key in TYPO3_CONF_VARS. This turns out to not work very
      reliable and could only be fixed with a massive organizational and
      performance overhead.
      
      Therefore, this patch now drops the complete compatibility layer, so an
      extension must be adapted to support the new scheme. This is ok, since
      extension authors maintaining extensions with XCLASS'es are aware that
      those classes already break frequently in the past, and were already
      advised to request hooks in the long run.
      
      Change-Id: I95a8bf986c94c784c69d4c4cc4a9c4645cd3fcc9
      Resolves: #39128
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12926
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      5b1ae6a8
    • Anja Leichsenring's avatar
      [TASK][CLEANUP] Remove obsolete IPv6 test condition · e2be7e11
      Anja Leichsenring authored
      The defined('AF_INET6') in the t3lib_div ipv6 related methods tests
      for availability of ipv6 support in php. This is by default enabled
      on all platforms since php 5.3.
      The fallback layer in t3lib_div did not work anyway and the unit
      tests failed in this case. This fallback layer is now removed.
      
      Change-Id: Id2618c33a3ab0d5daa7faa3fd42ec72d51974485
      Resolves: #39125
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12925
      Reviewed-by: Daniel Lorenz
      Tested-by: Daniel Lorenz
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      e2be7e11
    • Christian Kuhn's avatar
      [BUGFIX][FAL] isValidFilename() fails with broken PCRE · 4128aacb
      Christian Kuhn authored
      Some php versions like debian squeeze 5.3.3 do not have proper unicode
      support for PCRE enabled. In effect, character classes like [:alnum:]
      do not contain unicode characters. Therefore, test
      filenamesAreCorrectlyValidated with data set "filename with german
      umlauts" fails on those systems.
      
      The patch changes the according regex in t3lib_file_Driver_AbstractDriver
      to other, fully supported character classes.
      
      Change-Id: I49c9c2488536577ba77c5065e96a5ef4859e03da
      Fixes: #39123
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12924
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      Reviewed-by: Daniel Lorenz
      Tested-by: Daniel Lorenz
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      4128aacb
    • Christian Kuhn's avatar
      [BUGFIX] Send sane HTTP response in showpic on error · 16375f4e
      Christian Kuhn authored
      Currently, if showpic.php requests fail, exceptions are thrown. Those are
      usually converted to a HTTP response 500 (internal server error) by the
      production exception handler. Crawlers react on 500 by trying to index
      the resource again later.
      
      This is changed to now set specific response codes. If the paramters are
      incorrect or broken, an 410 (Gone) will be sent, informing users and
      crawlers that the resource is not available under this URL. Crawlers
      like googleBot will then stop requesting the resource.
      
      In case all parameters are ok, but the image itself is not found, a 404
      will be sent to the client. Crawlers will try to index the resource
      again only if there are still links pointing to the resource.
      
      Change-Id: I606937fa9953b88be5edf940201e0153223ae0e6
      Fixes: #39052
      Releases: 6.0, 4.7, 4.6, 4.5
      Reviewed-on: http://review.typo3.org/12867
      Reviewed-by: Mario Rimann
      Reviewed-by: Ernesto Baschny
      Tested-by: Anja Leichsenring
      Reviewed-by: Anja Leichsenring
      Reviewed-by: Marcus Krause
      Tested-by: Marcus Krause
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      16375f4e
    • Felix Kopp's avatar
      [TASK] Remove record_list icon from Page module · 40871b96
      Felix Kopp authored
      Removes the record_list icon from the docHeader in Page module.
      
      This icon links from page to list module but does not bring the
      backend to a consistent state. The module bar is e.g. not updated.
      
      The decision to remove the icon was taken at UX sprint 2012.
      
      Change-Id: I754a5840a244017986bcaca2ecd4bf16a63cb85e
      Releases: 6.0
      Resolves: #38828
      Reviewed-on: http://review.typo3.org/12911
      Reviewed-by: Marcus Schwemer
      Tested-by: Marcus Schwemer
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      40871b96
    • Helge Funk's avatar
      [!!!][TASK] New local configuration handling · 7f1fa4f9
      Helge Funk authored
      This patch removes the file typo3conf/localconf.php and introduces
      a new file called typo3conf/LocalConfiguration.php instead. The file
      returns the local overrides of the TYPO3_CONF_VARS default array,
      which is merged with the default array during bootstrap.
      
      An upgrade wizard transfers the settings from localconf to the new
      file. As an effect, the LocalConfiguration file is now fully under
      core control. There must be no additional custom code in it. If an
      instance needs such code, it can be added to a second file called
      typo3conf/AdditionalConfiguration.php, which is executed as is
      during bootstrap after LocalConfiguration was read.
      
      This enables us to store the local configuration as an array,
      exports the file with a clear schema.
      
      Furthermore, the list of loaded extensions (extList) is now stored
      as an array (extListArray). The old comma separated extList string is
      still kept for now, but core usage is adapted to use extListArray. The
      old extList string is still written and maintained, but is only kept
      for extensions for backwards compatibility.
      
      Important notes:
      - Frontend, backend, cli and install tool must still come up, even
        if the upgrade wizard was not run, yet.
      - The variables '$typo3_db_*' that where in localconf.php are now
        merged with the TYPO3_CONF_VARS. The upgrade wizard should find
        and transfer them.
      - The settings in install tool -> Basic Configuration are currently
        broken. This would have made the patch even bigger, and must be
        fixed with an additional patch.
      - It is advised to run the update wizard as soon as possible after
        this patch is merged, it will be the first wizard in the line.
      - Some follow ups for dbal and probably workspaces are still needed.
      - Currently the 1-2-3 install wizards are broken. The dummy and
        other packages need some love to adapt to the new handling.
      
      If some of the above problems are not solved until 6.0
      stabilizes, this patch needs to be reverted again.
      
      Change-Id: I3bf6a176117f501946123b921b6d2f1932627270
      Resolves: #38562
      Release: 6.0
      Reviewed-on: http://review.typo3.org/12519
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      7f1fa4f9
  2. Jul 19, 2012
  3. Jul 18, 2012
    • Benjamin Mack's avatar
      [BUG] FAL AdapterService fails with Fluid · 0cbce0c7
      Benjamin Mack authored
      FAL introduced an adapterservice to migrate certain
      fields to FAL style. The adapterservice uses type hinting
      to suggest $row of tslib_content always to be an array.
      However, when e.g. calling tslib_content from an
      extension or Fluid, it is common to have $row
      as NULL or empty, so the additional check
      is removed.
      
      Change-Id: I4b5f0231d3c8c2d9f3ec6d2f6a7a3a1b85775673
      Resolves: #38977
      Reviewed-on: http://review.typo3.org/12813
      Reviewed-by: Michael Staatz
      Tested-by: Michael Staatz
      Reviewed-by: Ingmar Schlecht
      Tested-by: Ingmar Schlecht
      0cbce0c7
  4. Jul 16, 2012
    • Oliver Hader's avatar
      [BUGFIX] FLUIDTEMPLATE - Serialization of 'Closure' is not allowed · 15d99ae6
      Oliver Hader authored
      When using FLUIDTEMPLATE and COA_INT or USER_INT on the same
      level and partials are used in the Fluid template, then there
      will be Closures. COA_INT and USER_INT are going to serialize
      the cObj, which fails when a Closure shall be processed.
      
      Since the Closures have been collected in $cObj->contentObjects
      the fix is to use a cloned version of the cObj which does not
      contain these contentObjects anymore for COA_INT and USER_INT.
      
      Change-Id: I5c1f9b01caef1df5077955bd7fa6e879e41ca854
      Fixes: #36820
      Related: #32295
      Releases: 6.0, 4.7, 4.6
      Reviewed-on: http://review.typo3.org/10979
      Reviewed-by: Susanne Moog
      Tested-by: Susanne Moog
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      15d99ae6
    • Wouter Wolters's avatar
      [TASK] Mention jQuery as external library in about section · c5d676a6
      Wouter Wolters authored
      Mention jQuery as external library, that is used in the TYPO3
      core
      
      Change-Id: Ia6c93c35d27c96d4d8b670ac94417ecf1b46e6ca
      Resolves: #38968
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12811
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      c5d676a6
  5. Jul 15, 2012
    • Ingo Renner's avatar
      [BUGFIX] $_EXTKEY not available in global scope in ext_tables.php · 4dd7a32c
      Ingo Renner authored
      Since changing the ext_tables.php handling to use the caching
      framework $_EXTKEY is not available in global scope anymore.
      
      This leads to issues when f.e. registering custom navigation
      components through t3lib_extMgm::addNavigationComponent().
      
      Explicitly setting $_EXTKEY global fixes the bug.
      
      Change-Id: Iec822eb55abdd8c471cb2e13a0d26c099db39849
      Fixes: #38964
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12807
      Reviewed-by: Mattias Nilsson
      Tested-by: Mattias Nilsson
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      4dd7a32c
  6. Jul 14, 2012
    • Ingo Renner's avatar
      [FEATURE] Add a unique request ID · b7d14353
      Ingo Renner authored
      To allow grouping of log records belonging to a certain request,
      a unique id per request is needed.
      
      Change-Id: I76e279e3ebe22fa17b1ffdf9a57c037b75680b82
      Resolves: #38954
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12792
      Reviewed-by: Fabien Udriot
      Reviewed-by: Wouter Wolters
      Reviewed-by: Marcus Schwemer
      Reviewed-by: Steffen Müller
      Tested-by: Steffen Müller
      Reviewed-by: Steffen Gebert
      Tested-by: Steffen Gebert
      b7d14353
  7. Jul 13, 2012
    • Fabien Udriot's avatar
      [FEATURE] Add categorization into the Core · b5ba81a8
      Fabien Udriot authored
      A common use case in every advanced website is to be able to
      categorize records. Besides that, there is the need to share
      categories across records. So far, each extension has to bring
      its own category implementation which is not an ideal situation.
      
      To fill the gap, we would like to introduce a new category record
      type along with an API where extension developers could register
      their own tables to be categorized. The relations will be stored
      within "mm" tables as a less time consuming approach.
      
      This patch provides:
      
      * SQL definition for "sys_category" and "sys_category_mm" with
        their TCA
      * a registration mechanism where third party extension can have
        their SQL fields + TCA generated on the fly. This is done by
        using the Extension Manager method:
      
      t3lib_extMgm::makeCategorizable(
        $extensionKey, $tableName,
        $fieldName = 'categories', $options = array()
      );
      
      Change-Id: I461252b6d5f6c6c4a4eb2c1942a66250cbb95aa9
      Resolves: #38711
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12672
      Reviewed-by: Fabien Udriot
      Tested-by: Fabien Udriot
      Reviewed-by: Marcus Schwemer
      Tested-by: Marcus Schwemer
      Reviewed-by: Dominik Mathern
      Tested-by: Dominik Mathern
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      b5ba81a8
  8. Jul 10, 2012
    • Benjamin Mack's avatar
      [FEATURE] Add signal to process public URL of file · 61892aa9
      Benjamin Mack authored
      By using the File Abstraction Layer (FAL), resources can be put
      to remote storages like Amazon S3 or WebDAV. However, in those
      cases a protected URI (containing user credentials) is used for
      uploading which shall not be accessible for any user of course.
      
      This change introduces the possibility to pre-process the public
      URL generation and allows i.e. to substitute by an alternative
      dispatcher URL.
      
      Example for registering the slot:
      $this->getSignalSlotDispatcher()->connect(
      	't3lib_file_Storage',
      	t3lib_file_Storage::SIGNAL_PreGeneratePublicUrl,
      	'Tx_MyExtension_HandlerSlot',
      	'preGeneratePublicUrl'
      );
      
      Change-Id: I9365831208dc90427aed29cff5672cc8ba5d6261
      Resolves: #38821
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12732
      Reviewed-by: Daniel Sattler
      Tested-by: Daniel Sattler
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      61892aa9
  9. Jul 09, 2012
  10. Jul 08, 2012
    • Susanne Moog's avatar
      [BUGFIX] Cannot redeclare class bigDoc: move_el.php · 798796ce
      Susanne Moog authored
      The file move_el.php first requires init.php
      and then template.php. As template.php was
      already required by the autoloader during
      initialization process this results in a
      fatal error: Cannot redeclare...
      
      The patch removes the require statement for
      template.php
      
      Change-Id: I096ecfb017f5ec78ac1be35d3bcd985d88b82a56
      Fixes: #38763
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12712
      Reviewed-by: Steffen Ritter
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      798796ce
    • Georg Ringer's avatar
      [!!!][-FEATURE] Remove resources from TypoScript records · 3c5cb4bf
      Georg Ringer authored
      This patch drops the functionality that resources (like images)
      can be uploaded and bound to TypoScript templates. This feature
      was hardly ever used and is bloated through the core.
      
      Change-Id: Ib4c0c107d10fb3dbe9b2ad02691df05709a14ae6
      Resolves: #34471
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/9322
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Felix Kopp
      Tested-by: Felix Kopp
      Reviewed-by: Susanne Moog
      Tested-by: Susanne Moog
      3c5cb4bf
    • Ingmar Schlecht's avatar
      [BUGFIX] Fix FAL update wizards · e2e83120
      Ingmar Schlecht authored
      This patch fixes the update wizards, minor issues like the
      relation count, the descriptions etc.
      
      Change-Id: I84acfedcc673064b3f7842a8409ec99bda7c7af9
      Resolves: #38749
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12705
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      e2e83120
    • Lars Peipmann's avatar
      [BUGFIX] Correct value for jQuery.noConflict = 0 · 999e4b15
      Lars Peipmann authored
      When page.javascriptLibs.jQuery.noConflict was set to 0,
      the page renderer API got "FALSE" for the parameter
      "$namespace", but it expects a string or a constant.
      
      Change-Id: Ib053d12371bace2b7b081b09f99f31a504879b08
      Resolves: #38750
      Relates: #38737
      Reviewed-on: http://review.typo3.org/12706
      Reviewed-by: Wouter Wolters
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      999e4b15
    • Benjamin Mack's avatar
      [CLEANUP] Make TCEforms sys_file header area localizable · 1e0737a0
      Benjamin Mack authored
      When editing a sys_file database record - the metadata
      of a file - the header area is not localized, and the
      CSS styles for the preview image are inline-written.
      The change cleans this up by moving the labels in
      a file and the CSS styles into the according t3skin
      CSS file.
      
      Change-Id: I177a46f210cbe90cd142f5236c33a754999d7bca
      Releases: 6.0
      Resolves: #37116
      Reviewed-on: http://review.typo3.org/11151
      Reviewed-by: Wouter Wolters
      Reviewed-by: Oliver Klee
      Reviewed-by: Ingmar Schlecht
      Tested-by: Ingmar Schlecht
      1e0737a0
    • Ingo Renner's avatar
      [FEATURE] Add hook for TSFE fetch_the_id() post processing · e67a62d0
      Ingo Renner authored
      To clean up TSFE from frontend preview code a hook is needed
      to post process the results of fetch_the_id()
      
      Change-Id: I6d8cdfb5c44d33ca67144a5a5e1ac688342f20b8
      Resolves: #38743
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12704
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      Reviewed-by: Philipp Gampe
      Reviewed-by: Ingo Renner
      Tested-by: Ingo Renner
      e67a62d0
    • Andy Grunwald's avatar
      [TASK] Fix CGL violations against ClassDocComment · bc5ebba2
      Andy Grunwald authored
      Some violations against the ClassDocComment was
      found in the UnitTests.
      
      Change-Id: I55e4c1b21635d9ff905b1d9e6685dd1498c03aca
      Fixes: #38738
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12700
      Reviewed-by: Philipp Gampe
      Reviewed-by: Oliver Klee
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      bc5ebba2
    • Andy Grunwald's avatar
      [TASK] Fix CGL violations against LogicalOperatorSpacing · bc42bf17
      Andy Grunwald authored
      In the TYPO3 core and two system extensions, there are some
      CGL violations against Squiz.WhiteSpace.LogicalOperatorSpacing.
      
      Change-Id: I63d345b5a1f9024938574467f90d4d2662abe944
      Fixes: #38740
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12701
      Reviewed-by: Oliver Klee
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      bc42bf17
    • Helmut Hummel's avatar
      [TASK] Enable default jQuery noConflict mode in page renderer · ddb455aa
      Helmut Hummel authored
      If jQuery is included with TypoScript, it is not possible to enable
      it with the default jQuery noConflict mode to just register "jQuery"
      as a global variable.
      
      Improve the page renderer to allow setting a custom namespace or to use
      the default jQuery noConflict mode.
      
      Change-Id: I83d427ed02505f4be30248234c605de901501f89
      Resolves: #38737
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12699
      Reviewed-by: Philipp Gampe
      Tested-by: Philipp Gampe
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      ddb455aa
    • Steffen Ritter's avatar
      [BUGFIX] Having tt_content:image in a palette breaks IRRE Layout · c9e19922
      Steffen Ritter authored
      Palette fields are always inline, to sit in one line aside.
      Therefore sizing is not possible. This has ugly effects on
      IRRE wildly resizing on collapse/expand.
      This does not make sense. Since image field is the only
      field within that palette (relict from pre-FAL) remove the
      wrapping palette.
      
      Change-Id: I3e92a4c8706ab613834c95c12178d6905f963704
      Releases: 6.0
      Fixes: #38741
      Reviewed-on: http://review.typo3.org/12703
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      c9e19922
    • Soren Malling's avatar
      [FEATURE] Make "Record type" icons clickable in "group=db" elements · 65a2d5e0
      Soren Malling authored
      It would make sense to make the icons describing allowed record
      type in a TCEforms element clickable.
      
      This will create a filter, showing only the clicked record type
      
      Change-Id: I02f2a21d03b7fe788039c6dfe245ace0b3bd5807
      Fixes: #666
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12696
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      65a2d5e0
    • Helmut Hummel's avatar
      [BUGFIX] Use lighter sorting icon on dark background · f53b572e
      Helmut Hummel authored
      Change f28bdc19 introduced new sorting icons for the list
      and file list module. To further improve it, use light
      arrows for the dark background in the file list module.
      
      Additionally change the naming from "sort" to "sorting"
      
      Change-Id: I5132e684ce461c61be097608f2d90f36f05528b9
      Resolves: #11127
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12692
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      f53b572e
  11. Jul 07, 2012
  12. Jul 06, 2012