- Mar 04, 2014
-
-
Stefan Froemken authored
Instead of using a slow COUNT on huge tables, we add an additional query here, which tries to get the first found record in oder to test if records exists or not. This new query is extremely fast, because it uses indexes. It only needs one huge table like sys_log in your database to see a performance boost in BE list module. Resolves: #55891 Releases: 6.2 Change-Id: I920729421bcece8af3b7cdd5f53446e5a1be5300 Reviewed-on: https://review.typo3.org/27554 Reviewed-by: Georg Ringer Tested-by: Georg Ringer Reviewed-by: Oliver Klee Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Xavier Perseguers authored
When a column is defined as a multivalued static enumeration: 'somecolumn' => array( 'exclude' => 0, 'label' => 'Some label', 'config' => array( 'type' => 'select', 'items' => array( array('Option 1', 1), array('Option 2', 2), array('Option 3', 3), array('Option 4', 4), ), 'size' => 4, 'maxitems' => 4, 'eval' => '' ), ), it is not possible to query the domain model using operation "contains": $value = 2; $query->matching( $query->contains('somecolumn', $value) ); Releases: 6.2, 6.1 Fixes: #56205 Change-Id: If898db7f355ad931d1c8b55febc2f59f19b0f38b Reviewed-on: https://review.typo3.org/27787 Reviewed-by: Alexander Opitz Reviewed-by: Wouter Wolters Reviewed-by: Stefan Froemken Tested-by: Stefan Froemken Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Alexander Opitz authored
After manipulating PHP files, which we include with "require" we should clear the opcode cache, if there is one installed. So we introduce OpcodeCacheUtility to handle the clearing of the opcode cache. Also to have a way to give feedback to the install tool which can show the quality of the opcode cache in use. It also checks if an opcode cache is enabled in the configuration, not only if the extension is installed. Use of this opcode cache clearing is added to the ConfigurationManager, PackageManager and the cache (Simple)FileBackend. Make use of this data in the SystemEnvironmentCheck. Resolves: #55252 Releases: 6.2, 6.1, 6.0 Change-Id: I881f3fbe055c9566663c2c3c238de62ae30f7149 Reviewed-on: https://review.typo3.org/27024 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Oliver Hader authored
The standard-search relies on basic form-functionality. But if EXT:form is installed, that functionality is overlaid and the result is wrong. Provide a flag so that standard-search can request to use the "basic" form-functionality, preventing EXT:form from dealing with it. Change-Id: I52cbd6cecc7222217ff766393dd37ad9d1a9aa30 Resolves: #50274 Releases: 6.2, 6.1 Reviewed-on: https://review.typo3.org/28042 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
Andreas Fernandez authored
DBAL's DatabaseConnection::INSERTquery() builds an array. The keys (fields) are mapped through quoteFieldNames(), which returns an empty string. DBAL's SqlParser tries to use $GLOBALS['TYPO3_DB'], which is not available here. Resolves: #56306 Releases: 6.2 Change-Id: I97eff8f796fcb8d530d16ff5f6111ebd5d28d5ce Reviewed-on: https://review.typo3.org/27864 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Wouter Wolters authored
Current Order: * Welcome * Important actions * System environment * Configuration Presets * Folder structure * Test setup * Upgrade Wizard * All configuration * Clean up * Logout from Install Tool New proposed order: * Important Actions * Configuration Presets * All Configuration * Upgrade Wizard * System environment * Folder Structure * Test Setup * Cleanup "Logout" is put below the menu as a link and "Welcome" is just the first screen but without any menu item for it. Resolves: #56497 Releases: 6.2 Change-Id: I20a3c363e5039b875c0aef2d23353f981dabee6b Reviewed-on: https://review.typo3.org/28002 Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny Reviewed-by: Jan Helke Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Stefan Froemken authored
After submitting an invalid form twice, extbase tries to create the related submodel instead of edit. This is because of the missing __identity part for the related submodel Resolves: #46185 Releases: 6.0, 6.1, 6.2 Change-Id: If3ec15b9eff0fc8d9a7dc682518cbfd72bb4665b Reviewed-on: https://review.typo3.org/21101 Reviewed-by: Stefan Neufeind Reviewed-by: Stefan Froemken Tested-by: Stefan Froemken Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Nicole Cordes authored
As felogin and some other extensions don't work without css_styled_content it should be enabled by default as well. This patch adds the Package class to install the extension by default. Resolves: #56292 Releases: 6.2 Change-Id: I9aad88966c0c292cdff865276dc131f358a52697 Reviewed-on: https://review.typo3.org/27858 Reviewed-by: Dmitry Dulepov Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes Reviewed-by: Christian Kuhn Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Felix Kopp authored
Brings visual illusion for :active / click state. Bugfixes :hover on <button> Resolves: #56480 Releases: 6.2 Change-Id: I08d38c50d23f5fbcf591dbd54edca34944568591 Reviewed-on: https://review.typo3.org/27983 Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
- Mar 03, 2014
-
-
Stefan Neufeind authored
PHP Warning: Illegal string offset 'usergroup' is shown when trying to login to the frontend while currently already being logged into the backend. Also the usergroup-column needs to be fetched from $this->fe_user->usergroup_column. Change-Id: Ia9772262616e9bd62e0827b0f211b8efe77ea80b Resolves: #56508 Releases: 6.2 Reviewed-on: https://review.typo3.org/28000 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
Benjamin Mack authored
If an extension used static content ID 43 (content default), it also added itself (during each runtime of ext_localconf.php) to all available content blocks. The original way is problematic as an extension that provides content templates may be included after an extension that wants to add itself after all content templates. This is now more confusing as the package manager resolves the ordering of extensions and now, CSS Styled Content gets loaded after felogin and indexed_search. To resolve this problem completely, the additional TypoScript for each "contentRenderingTemplate", a TS template that provides default content renderings, is added to one global default TypoScript and is only merged at the TemplateService class. Therefore the extension loading ordering does not matter anymore. Resolves: #55942 Resolves: #55174 Resolves: #55557 Releases: 6.2 Change-Id: Id0c983bf96a3a76fde2183c57a17066ef8fd4ac8 Reviewed-on: https://review.typo3.org/27587 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Markus Klein authored
PHP Warning: Illegal string offset is thrown in some places if an fe_user logs out. Resolves: #55696 Releases: 6.2 Change-Id: I532a27c0d2fc4b80d3a3f92da0079f4e9517d06c Reviewed-on: https://review.typo3.org/27362 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Oliver Klee Reviewed-by: Alexander Opitz Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Markus Klein authored
SearchController::compileSingleResultRow() causes double htmlspecialchars() call on $title. This patch removes the general htmlspecialchars() call since $title will be escaped in linkPage() anyway. The only place which requires escaping has the call added now. Resolves: #56262 Releases: 6.2, 6.1, 6.0 Change-Id: Ic94fe7fe7d2145fc539adcdf21faf42c33f5b32e Reviewed-on: https://review.typo3.org/27849 Reviewed-by: Stefan Neufeind Reviewed-by: Dragan Tomic Tested-by: Dragan Tomic Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Markus Klein authored
The delimiter has to be reversed for the case of limit 2, as the search is performed on the non-reversed string. Otherwise the function will yield different results for limits greater than 2. Resolves: #56405 Releases: 6.2 Change-Id: I077d38918d98fbe2e5cd153c75b115e0d95734f8 Reviewed-on: https://review.typo3.org/27926 Reviewed-by: Georg Tiefenbrunn Tested-by: Georg Tiefenbrunn Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Helmut Hummel authored
If the DataMapper shall map a 1:N relation for a property of a domain object and the element type of this property is another domain object and not a storage type, the data mapper must always fetch the related elements from persistence and cannot rely on the persistence session lookup. This is the case because the relation to the parent is set on the child side and not the other way around. The column in the parent row is useless in that case and does not hold the id of the child. We can also not rely on the persistence session because we do not know the identifier of the child until we fetched it. Resolves: #56442 Releases: 6.2, 6.1 Change-Id: Icc3ebf9b825f6380691c60839621f01ca9875e4e Reviewed-on: https://review.typo3.org/27949 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs
-
Helmut Hummel authored
The condensed mode user setting has been removed three years ago with #24585 Now also remove the leftover parts. Keep the language labels to not interfere with older versions. Resolves: #56479 Releases: 6.2 Change-Id: I8cb3ebc5aac162357ce1d343eed1031156ccd749 Reviewed-on: https://review.typo3.org/27980 Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Thomas Maroschik authored
Resolves: #53753 Releases: 6.2 Change-Id: I3acb81c71796bc84ada29e6cdf6141be07f69ca3 Reviewed-on: https://review.typo3.org/25503 Reviewed-by: Christian Opitz Reviewed-by: Fabien Udriot Tested-by: Fabien Udriot Reviewed-by: Felix Kopp Tested-by: Felix Kopp Reviewed-by: Thomas Maroschik Tested-by: Thomas Maroschik
-
- Mar 02, 2014
-
-
Helmut Hummel authored
The DataProviderTest calls BackendUtility::isRecordLocked statically. We cannot mock that call, but we can "mock" a locked record so that BackendUtility::isRecordLocked does not query the database. Resolves: #56472 Releases: 6.2 Change-Id: I268a7a900a0f2dcbf248f6a4d856354c7b1cdcd6 Reviewed-on: https://review.typo3.org/27975 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Stephan Großberndt authored
Introduces two new upgrade wizards in the Install tool. The first wizard - added as first step of the upgrade wizards - adds tables, fields and keys to comply to the database schema. When this is necessary no other wizards can be executed until these are created. The second wizard - added as last step of the upgrade wizards - changes tables, fields and keys to comply to the database schema. When other upgrade wizards are available, this one is not available to make sure they have all necessary fields. In order to make sure they are added as first and last step they are added in UpdateWizard instead of ext_localconf.php. The former "Final step" is now optional and has been renamed to "Hint". The buttons to start the update wizards from the list have been renamed from "Next" to "Execute". Resolves: #53890 Releases: 6.2 Change-Id: I866b558df3325acca3122bbd4e0c2285447fcdf3 Reviewed-on: https://review.typo3.org/27240 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 01, 2014
-
-
Helmut Hummel authored
Keeping the old wizard script would not solve the CSRF attack vector as they could still be referenced in this kind of attack. Because of that, we remove them now. This change provides a backwards compatibility layer in FormsEngine which takes care of rewriting URLs which have been referenced in TCA. Also the priority is changed in code. This means that extension authors can reference both configurations to stay compatible with older TYPO3 versions. It will however break code which link to the old scripts directly in other places. Resolves: #56454 Releases: 6.2 Change-Id: I15f5d929f16fdd53a8b87cd32440a3d6ce59b6ed Reviewed-on: https://review.typo3.org/27956 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Marc Bastian Heinrichs authored
Since optimizing the retrieval of Storages the findByStorageType() doesn't find any (also right ones) storage, because of a wrong comparison. This fixes also the localDriverStorageCache in ResourceFactory, finding a bestMatchingStorageByLocalPath in ResourceFactory, getting the right storage for a local path as fileIdentifier and creation of duplicate entries in sys_file with storage 0. Resolves: #56400 Releases: 6.2 Change-Id: I75ac357dff498f1a209d4c42896bdeddab3641ad Reviewed-on: https://review.typo3.org/27915 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Alexander Schnitzler authored
Resolves: #56436 Releases: 6.2 Change-Id: Ia789abbbdf7ab11a4ab13ea6aa195bc79ba6dc25 Reviewed-on: https://review.typo3.org/27945 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Wouter Wolters authored
There is a undefined variable $multiSelectId in FormEngine. This is introduced with #46357 Resolves: #56457 Releases: 6.2 Change-Id: I88fd4f9b36e6421b338011a1cc31c22987019dc9 Reviewed-on: https://review.typo3.org/27959 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
- Feb 28, 2014
-
-
Helmut Hummel authored
The new wizards scripts lacked a proper description. Add the description the original files had. Related: #56431 Releases: 6.2 Change-Id: I482d0a8c11d827c3e14da140d800df6d2caeefdc Reviewed-on: https://review.typo3.org/27957 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Alexander Schnitzler authored
Resolves: #56437 Releases: 6.2 Change-Id: I0eea59f46c74fe50eb2554898a9f64fa2a26a9b1 Reviewed-on: https://review.typo3.org/27951 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Alexander Schnitzler authored
Resolves: #56438 Releases: 6.2 Change-Id: Ic5a22f6ded5bf3b5d8a6442497444296a6b3bfaa Reviewed-on: https://review.typo3.org/27947 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Alexander Schnitzler authored
\TYPO3\CMS\T3editor\Hook\FileEditHook::save() requires init.php which is not necessary at all as the method itself is only called through ajax.php, which requires init.php itself anyway. Resolves: #55676 Releases: 6.2 Change-Id: Iaaf0805b73ebbb97e6689bcaa8064dc350187e66 Reviewed-on: https://review.typo3.org/27848 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Oliver Klee Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Alexander Schnitzler authored
Resolves: #56435 Releases: 6.2 Change-Id: I180929980ade8c26a6e086f2f65d2e76cbeb19cd Reviewed-on: https://review.typo3.org/27942 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Michiel Roos authored
Change-Id: Ia7db1d1b3613badc84ca3ee44ce68c154004f135 Resolves: #56080 Releases: 6.2 Reviewed-on: https://review.typo3.org/27702 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Christian Weiske authored
Extbase logged a code smell with a severity of 1320177676 instead of 1 ("notice"). Change-Id: If28c2d66713bdedb3094af22f8f7a00a504d995d Resolves: #56378 Releases: 4.7, 6.0, 6.1, 6.2 Reviewed-on: https://review.typo3.org/27895 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Oliver Klee Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Frans Saris authored
With the introduction of FAL the files and folders are objects and so there is more info than just a name/extension to determine the right icon. And with file_metadata you have the possibility to even add more info to a file (access rights etc). This patch adds a new method to the IconUtility API for generating the sprite icon for a resource. There is also a hook where other extensions can hook in and change the icon, options and overlays. Furthermore, all calls in the core are changed to IconUtility::getSpriteIconForFile where a File or Folder object was available. Resolves: #56211 Documentation: #56412 Releases: 6.2 Change-Id: Ifae61dd65d690fffd90c66568e2647ebd403bce5 Reviewed-on: https://review.typo3.org/27790 Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter Reviewed-by: Markus Klein Reviewed-by: Stefan Froemken Tested-by: Stefan Froemken Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Alexander Schnitzler authored
Resolves: #56434 Releases: 6.2 Change-Id: Ia776874ca247b11a769a1c17ee1e6ec65047ac4c Reviewed-on: https://review.typo3.org/27941 Reviewed-by: Alexander Schnitzler Tested-by: Alexander Schnitzler Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Alexander Schnitzler authored
Resolves: #56432 Releases: 6.2 Change-Id: Id78b3182ed6710a09a82ce69bd1f5b72f9e2a3e0 Reviewed-on: https://review.typo3.org/27939 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Christian Weiske authored
Adjust the @return documentation of authUser() to match the actual implementation in TYPO3\CMS\Core\Authentication\AbstractUserAuthentication Change-Id: I2d94cdfee6c58de80c7ec2be2b644b5fcd6c9a97 Resolves: #56421 Releases: 6.0, 6.1, 6.2 Reviewed-on: https://review.typo3.org/27931 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Oliver Klee Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Andre Hähnel authored
It was not possible anymore to use the "add new record" button in TCA select fields on records with pid > 0. This patch makes it work again; the redirect to the original page gets prevented when a pid is set. This was handled the same way in 4.6 and 6.1. Change-Id: Iec058818405385efdacaebf5080f339371356810 Resolves: #56248 Related: #54085 Releases: 6.2 Reviewed-on: https://review.typo3.org/27935 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Markus Klein authored
Double quotes must not be used around JS code created by GeneralUtility::quoteJSvalue() Resolves: #56406 Releases: 6.2 Change-Id: Ideff0a2ca475dad140a904a770561fa75f4019b9 Reviewed-on: https://review.typo3.org/27924 Reviewed-by: Thomas Sperling Tested-by: Thomas Sperling Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Helmut Hummel authored
The backend ajax handler that are directly registered in DefaultConfiguration.php are now CSRF protected if necessary. Resolves: #56356 Releases: 6.2 Change-Id: Ia592f7f2b51c20326600b97d2ce10a5e5fdbfde7 Reviewed-on: https://review.typo3.org/27877 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Feb 27, 2014
-
-
Helmut Hummel authored
Although the order of GET parameters in the URL does not matter, the M parameter should come first in the URL. Resolves: #56404 Releases: 6.2 Change-Id: Id79f2f55fff2430ecce8a76bbba526dc7d175b40 Reviewed-on: https://review.typo3.org/27916 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Nicole Cordes Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Helmut Hummel authored
The order of GET parameters changed, so we have to adapt the tests. Resolves: #56403 Releases: 6.2 Change-Id: I6fb8d231c71fa020677313127d453be3eab500ce Reviewed-on: https://review.typo3.org/27917 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Helmut Hummel authored
This change adds API to register Ajax ids with their handler and to get an Ajax URL for a specific AjaxID. A token check is added to the ajax.php dispatcher script. To stay backwards compatible, the token is only checked, if the AjaxId is registered not using the new API. The new API will be used by TYPO3 core in consecutive changes. Resolves: #56345 Documentation: #56347 Releases: 6.2 Change-Id: I188a9312b0f4239040e461ba09dc9c8f2b93a68b Reviewed-on: https://review.typo3.org/27873 Reviewed-by: Wouter Wolters Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-