- Apr 27, 2021
-
-
Alexander Schnitzler authored
Update phpstan to version 0.12.84 and fix new issues detected by the new version. Releases: master Resolves: #93979 Change-Id: I7546fedf79656561369008765b303cfb9af246d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68850 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Thomas Löffler authored
With multiple registered email validators, stop as soon as the first one fails. Resolves: #93890 Releases: master Change-Id: I1e9e20a57ddb5538595aa0a9dea2888d547bc78e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68879 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Benni Mack authored
Various code occurrences within the legacy tree implementations, which were marked as internal are removed (e.g. the method to evaluate a "PM" query parameter) as the functionality is not needed anymore, along with some unused properties as well, which are never evaluated anymore due to the removal of the methods. Resolves: #93990 Releases: master Change-Id: I3b8841959156f87fafed7eb58bea01770ea9dce6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68877 Tested-by:
-
Christian Kuhn authored
With the CI migration from bamboo to gitlab being finished, the bamboo test plan setup can be dropped from core. Resolves: #93994 Releases: master, 10.4, 9.5 Change-Id: I8f3d5beda8b296e268c2da5eddead6a542f5d418 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68883 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
Oliver Bartsch authored
Use a local variable instead of overwriting the options to keep the format intact when sending multi-format mails. Resolves: #93992 Releases: master, 10.4 Change-Id: Ide90bc9c7bb8f7de35b7d7c00abd5ef4cb114707 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68881 Tested-by:
Denis Mir <d.mir@communiacs.de> Tested-by:
-
- Apr 26, 2021
-
-
Torben Hansen authored
Allow 255 chars for the field "email" of a backend user in the setup module. Resolves: #93987 Releases: master, 10.4 Change-Id: I5657a8394adc8d8f252d6dd81a39168253e61982 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68874 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Guido Schmechel authored
To increase the usability, the FormManagement module now makes use of the Pagination API to limit the amount of displayed forms to 20 per page. Resolves: #89762 Releases: master Change-Id: I85883190dc1bce625abd4ce3124662aea617bbab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67513 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Oliver Bartsch authored
The status report within EXT:reports now uses the StandaloneView for rendering the status table. Resolves: #93978 Releases: master Change-Id: I75c629691b5e4dc712a377bc734ef9aacc525dcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68851 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Benjamin Franzke authored
This fixes a warning during `yarn install`, which revealed that we used an unsupported version of @popperjs/core: warning " > bootstrap@5.0.0-beta3" has incorrect peer dependency "@popperjs/core@^2.9.1". bootstrap@5.0.0-beta3 contains a peerDependency to @popperjs/core@^2.9.1 and because @types/bootstrap still depends on @popperjs/core@2.6.0, we need to be explicit about the desired @popperjs/core version. Commands executed: yarn add @popperjs/core@^2.9.1 grunt build Releases: master Resolves: #93967 Change-Id: I21fa001842ef319be49d30438d23bd6587a83639 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68843 Tested-by:Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
Richard Haeser authored
Throws an exception when a file extension is given to the image or media ViewHelpers which is not within the allowed image file extensions. Resolves: #93961 Releases: master, 10.4 Change-Id: I0e4ac3ed4e3b0073b17f917573863aa6c74ca11e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68836 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
-
- Apr 25, 2021
-
-
Anja Leichsenring authored
With doctrine/dbal 2.13.1 a new return type to executeStatement() was introduced, which needs to be taken into consideration by tests using mocked statements. Resolves: #93985 Releases: master Change-Id: Ib2b0ef3540369a94d30b26d6920502de07d9b641 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68872 Tested-by:
-
- Apr 23, 2021
-
-
Benjamin Franzke authored
Lit is the umbrella term for the next major lit-html (v2) and lit-element (v3) versions. Therefore we will refer to these components as *Lit* in TYPO3 from now on as well. These two libraries also have been migrated into a single entry point module named `lit`. It is officially described as: > The main module exports the core pieces needed for component > development: LitElement, html, css, and the most lit-html v2 and lit-element v3 are mostly compatible to the previous major versions. Main changes are * Deprecation of the `lit-element` entry point in favor of the new `lit` module * @internalProperty changed to @state * shadow css declaration via static property instead of static getter method * The CSSResult type declaration is gone * Directive (currently unused in TYPO3) API has changed Related testing framework change is: https://github.com/TYPO3/testing-framework/pull/229 Commands used: rm -rf typo3/sysext/core/Resources/Public/JavaScript/Contrib/{@lit,l...
-
Jochen Roth authored
Will hide all tooltips when scrolling in the page tree panel to avoid multiple tooltips to show up and get stuck on screen Resolves: #87496 Releases: master Change-Id: Ie4be5c0cc9df01b26c658ac02ddcfdf2a2102c77 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68839 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benjamin Franzke authored
The SvgTree markup changed in #87743 causing acceptance test failures. This wasn't discovered as gitlab-ci missed to vote negative. The text node for the page "inline mngroup" now contains additional HTML when filtering for "Group". This new markup rendered the previous xpath invalid: inline mn<tspan class="node-highlight-text">group</tspan> The xpath is now adapted to only filter for the text node. Releases: master Resolves: #93977 Related: #87743 Change-Id: Id72e6239536c52cb30912b095d720331a8a3212f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68849 Tested-by:
-
jogo authored
ObjectAccess::getPropertyPath requires its second parameter to be string, so it should not be called if the property argument is null but return null instead as the getPropertyPath method would have done in earlier versions. Resolves: #93798 Releases: master, 10.4 Change-Id: I35ff131e1819c0fbb3bc98c8dc5a0a53d799daae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68556 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benni Mack authored
This change re-adds the highlighting of filter results in the Svg Trees, which was present before in the Page Tree before it was built on SVG. Due to the nature of SVG, it is rather complicated to color the actual background of the text than the text itself (using <tspan>), but still, the highlighting is IMHO better than having no highlighting. Resolves: #87743 Releases: master, 10.4 Change-Id: Ie37173149c8f9388194e63a07ae89eb2fc774f30 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68835 Tested-by:
-
- Apr 22, 2021
-
-
Alexander Schnitzler authored
To avoid issues due to relative paths in config files, all paths are now prepended with the %currentWorkingDirectory% variable of phpstan. That way, the exact environment of config files is irrelevant. Releases: master Resolves: #93966 Change-Id: I3115b7ecca171ee2be30ac0172f772a7eec9e533 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68842 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Ralf Zimmermann authored
Since #92815 the extbase request dispatcher sets an "original request" within a subrequest in case of a "ForwardResponse". The fluid AbstractFormFieldViewHelper::hasMappingErrorOccurred() guesses that a property mapping error exists as soon as a request is a subrequest. This is determined by the fact that the current request has a original request (e.g. if a controller returns a ForwardResponse). While the determination of "property mapping error exists" based on the existence of a parent request may not be the best indicator, it seems to be fine for EXT:form for now. EXT:form makes further use of the HiddenViewHelper to set the previous page index as a value for the property "__currentPage". Since this ViewHelper always sets the respectSubmittedDataValue property to TRUE, the value is always overwritten in case a parent request exists and the "previous step" button did not longer work. This is now fixed by making the respectSubmittedDataValue property configurable via a ViewHelper argument and setting in to FALSE for the "__currentPage" field. Resolves: #93398 Releases: master Change-Id: I8d495395c91ed8bcfae4fec4d474e73279e9e4ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67590 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Benni Mack authored
This change adds a <rect> element inside the icon group for making the icon better clickable. Resolves: #87453 Resolves: #93284 Releases: master Change-Id: I17a70cc0cf6bdf466c710a3599d3ede87fda700d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68800 Tested-by:
Ayke Halder <mail@ayke-halder.de> Reviewed-by:
-
- Apr 21, 2021
-
-
Benni Mack authored
If a user enters a slug proposal, which is already taken by another page in the same site, the automatically modified slug is now shown along with the corresponding message. The actual functionality already existed, but was never used due to a Bug in the AJAX response. In addition, the label for the warning message does not have the base / slug at the very end, so sprintf() must be used AFTER htmlspecialchars(). Resolves: #93953 Releases: master, 10.4 Change-Id: I395c39788ff25fc1b8cefe78e07b609a4be36e2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68832 Tested-by:
-
Daniel Goerz authored
Releases: master Resolves: #93955 Change-Id: Idb5e338c7a1e34f1197d38d01bec5f8735509e8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68834 Tested-by:
-
- Apr 20, 2021
-
-
Daniel Goerz authored
Resolves: #93704 Releases: master Change-Id: I24067c4b705c671b87a9bbdfed30535a39528879 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68359 Tested-by:
-
Benni Mack authored
This change limits the GET request for the PersistentStorage to only "get" and "getAll", where as the others are only working for "post". Since this logic is encapsulated properly in the Persistent JavaScript API, no other parts are affected. Resolves: #93948 Releases: master Change-Id: I965ea4552671c743cabed10c4cd8ad7275532420 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68715 Tested-by:
-
Jochen Roth authored
This solves a display white text on white background for the selected size in image cropping tool panel Resolves: #93909 Releases: master Change-Id: Iaa1d62cbb208afe68556eba19b526e13c127bd29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68769 Tested-by:
-
Benni Mack authored
Various PHP classes, which were previously a specific implementation for various Link Picker / Element Browser renderings for trees are removed. In addition, the so-called "LegacyTree" is removed along with all entry points, also for the "navFrameScript" of the iframe inside the File main module. Modules who previously registered to the iFrame navigation component are now moved to the new file storage component. Since the related code was marked as internal, the files are removed without substitution. Resolves: #93944 Releases: master Change-Id: Ib42c5b32d44c8a697e250f178280f743b0d7e1da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68799 Tested-by:
-
Jochen Roth authored
Allow a user to move a folder into a folder on the same level and prevent moving a folder into its child folder. Resolves: #93954 Releases: master Change-Id: I444a87e862075ecd0a3e54ce5afd02314b1931c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68833 Tested-by:
-
- Apr 19, 2021
-
-
Benni Mack authored
The LoginProvider functionality, which was baked into the LoginController is now moved into a separate Resolver class, cleaning up the Controller class and having a dedicated, single responsibility as a separate PHP class. In addition, the Request/Response (PSR-7) functionality is now used, instead of relying on $_COOKIE. Resolves: #93947 Releases: master Change-Id: Ic94361216566ec046160053e2a93c7d6be69584a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68772 Reviewed-by:
-
Benni Mack authored
Only if a site language is enabled, it should be taken into account for redirecting. To keep the interface valid, the 1st site language is returned if no other site language is found. Resolves: #93920 Releases: master, 10.4 Change-Id: I304c845012d3d76cd230e775030ac08a8d003e6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68775 Tested-by:
-
Xavier Perseguers authored
Resolves: #93864 Releases: master, 10.4 Change-Id: I3ed1b9d33809302d46016f4a7b4f49fdbf131f01 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68717 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Oliver Bartsch authored
Since the reset password logic does not directly relate on the login step, just as MFA, it's now extracted into a dedicated class. This also allows to cover it with functional tests. Next to some code cleanup, the reset password views do now properly respect the common query parameters, like `loginProvider` or `redirect`. This helps to unify the overall authentication process UX as the user does not longer lose these parameters in some views, while they are kept in others. Resolves: #93918 Releases: master Change-Id: If7a21a1129b5289fd575ef9232c476d3c418aa36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68773 Tested-by:
-
Oliver Bartsch authored
The form to update an already existing link in the LinkBrowser used the same name and id as the form for "Additional Attributes". This now leads to a JavaScript warning being emitted. The issue is fixed by replacing the duplicated name and id attribute. Resolves: #93936 Releases: master, 10.4 Change-Id: I074f46305ff0928f7c303ed28619d79b6fdc943f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68796 Tested-by:
-
Georg Ringer authored
Deleted pages must be excluded at content element previews in the page module to avoid exceptions. Resolves: #93938 Related: #93659 Releases: master, 10.4 Change-Id: I8786a6a93eac354684542d54ca1270d58cb05530 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68798 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
- Apr 16, 2021
-
-
Nikita Hovratov authored
In case the amount of items, shown in the workspace module, does not exceed the pagination limit - default 30 - the items array was previously filled with invalid items till the limit was reached. This is now fixed by a guard clause which prematurely ends the processing (the corresponding loop) as soon as no more item exists. This guard clause is also implemented in the calculation of the start value. Usually there shouldn't be any invalid items, but as such behaviour can not always be ruled out, especially on multi-user systems, it seems reasonable to add it here, too. Resolves: #93915 Relates: #93645 Releases: master, 10.4 Change-Id: I619c9063f12c3b1d5c446f9ca1a0e35e646f90f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68779 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Oliver Bartsch authored
In #35891 a feature was introduced, which allowed to override the icon of select items via Page TSconfig. This feature however did more or less never see the LTS release, since it was almost completely removed in #67006 again. Only SelectMultipleSideBySide provided this feature until https://review.typo3.org/c/Packages/TYPO3.CMS/+/50879/. It's now restored, using the original configuration path. Resolves: #73227 Relates: #35891 Releases: master, 10.4 Change-Id: I40e243a6f62a82ddf373b59977b61d00501777fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68776 Tested-by:
-
Oliver Bartsch authored
The page module is now being reloaded when deleting a content element via the context menu. Side note: Since there are a lot of functionalities in the module, e.g. translation, it isn't sufficient to just remove the element from DOM, like it's done in recordlist. The whole module needs to be reloaded / reinitialized. Resolves: #91394 Releases: master, 10.4 Change-Id: Ibd9dc853ddb356574a0f426244decb6455f54b44 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68727 Tested-by:
-
Oliver Bartsch authored
With #90461 a new option "saveAndClose" was added to the newContentElement wizard. When opening the wizard and selecting a content type with such option set, the new element will directly be created - no FormEngine interaction - and placed at the position (colPos, sorting), the user opened the wizard. This functionality however does not work when the wizard was opened without such page context, for example via the "new record view" in the recordlist. The position must then be defined by the user explicitly in the MultiStep wizard, so no "saveAndClose" functionality is available in such cases. Resolves: #93876 Releases: master, 10.4 Change-Id: I8c7c7b632533a6f2d2bbe01a103a25ce441acf2c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68726 Tested-by:
-
Oliver Bartsch authored
Following improvements are done: * Reduce margin-top of the MFA provider title * The bottom border of card-body is changed to a top border of card-footer to prevent the border from being shown without a card-footer * A new class `card-mfa` is added to the outer card container to allow individual styling of the MFA view Additionally this also fixes the custom styling options, as these were still applied to the `panel` class, which was however replaced by `card` during the bootstrap 5 migration. Resolves: #93913 Releases: master Change-Id: I4e7ff6e30b77f71b0d5823f5202062410ebddf88 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68771 Tested-by:
-
Oliver Bartsch authored
Resolve duplicated `class` declaration which prevented the element from being recognized by the JavaScript endpoint. Add missing `form-check-label-text` class for the checkbox label text. Remove invalid `p` tags from checkbox elements description. Resolves: #93929 Releases: master Change-Id: Ice0fdd1646f27dd8d98f33c8453cfa8ae2ce3b79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68777 Tested-by:
-
Benni Mack authored
This change adds the SVG-based page tree in the record selector and the Page Link picker, replacing decade-old clumsy HTML code for generating trees. This replacement not only unifies the user experience across the navigation trees and the Element Browser / Link Pickers making the whole look + feel very consistent. It also allows to finally use all the features built in the SVG trees: * A filter across the tree built on the browser and automatic refreshing * collapse + expand and post-loading is now built with the same AJAX endpoints as the navigation components, making the general loading much faster * Temporary Mount Points now look exactly the same as in the navigation area. * Keyboard navigation * The Content Area inside the Record Selector and the Link Pickers is replaced via AJAX calls Especially the last feature makes it a breeze to use the new trees to select items much faster. All existing features, such as directly selecting a page or link to a page within the tree is added as so-called SVG-tree "actions" in the right corner when hovering, avoiding the additional "play" icon in the tree. Custom support for Element Browser "mount points" is also kept and included. The SVG tree is added to the following components: * Database Browser / Record Selector (e.g. choosing storagePid in plugins) * File Browser / Record Selector (e.g. selecting an image in the plugin) * Folder Browser / Record Selector * Link Picker for Pages / Content Elements ("link to a page") * Link Picker for Files ("link to a file") * Link Picker for Folders ("link to a folder") * Link Picker for Records (e.g. news record) All link picker functionality is available for typolink fields (e.g. tt_content.header_link) and when linking inside the Rich Text Editor. Some technical details under-the-hood: * The trees are now built as SVG tree / LIT elements * All Element Browser / Link Picker trees are named "Browsable...Tree" * The AJAX endpoints for fetching data are used * The Page Tree now uses a different configuration URL with a "?readonly=1" parameter, with the main difference to initialize EB mountpoints instead * Within the tree: The SVG tree actions is a separate container for elements on the right-hand of the tree * The GET parameter "contentOnly" represents to only load parts of the HTML (the content area) when fetching from AJAX Resolves: #73176 Resolves: #92430 Releases: master Change-Id: I5ef9534076bd6fa297b51c0ed9e90af91035be80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67687 Reviewed-by:Benjamin Franzke <bfr@qbus.de> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Oliver Bartsch authored
The panel items in the global configuration card (EXT:install) are referencing to a not defined `id` in their `data-bs-parent` attribute. This therefore lead to a JavaScript error within bootstrap and is now fixed by adding the corresponding `id` to the panel group element. Resolves: #93934 Releases: master Change-Id: Ideede21f6e72c6b7dd25ef150cecc9b96b236b45 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68794 Tested-by:
-
