- Mar 04, 2022
-
-
Nikita Hovratov authored
The new version finds some new possible bugs and removes some incorrect ones. Combined with a TF raise. Used commands: > composer req --dev phpstan/phpstan:^1.4.8 > composer req --dev typo3/testing-framework:^6.16.1 > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97097 Releases: main, 11.5 Change-Id: I97cec4c07f70b6d451ba55f9aaec7df109c36f71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73811 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
André Buchmann authored
Resolves: #97095 Releases: main, 11.5 Change-Id: I783dab0b2d16d8071a2ecd061083a580f77533b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73780 Reviewed-by:
-
Max Rösch authored
Releases: main, 11.5 Resolves: #97101 Change-Id: I45b40fd645f9a494d3ff027024b344ecee5e2d75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73779 Reviewed-by:
-
Georg Ringer authored
Cast the variable to string before handing it to preg_replace to avoid a type error. Resolves: #97088 Releases: master, 11.5 Change-Id: I60c3eb850049aec3cba7f3bade3a99849683152e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73778 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Mar 03, 2022
-
-
Christian Kuhn authored
Scenario: * Add a content element with an image in default language. * Translate the content element to some other language, this will create the image in the localized element, too. * Edit the default language element and add another image. * Edit the localized element, see the 'shadowed' new image, click "localize" button on the right. -> Red error pop up, logged warning: "Array to string conversion" in FormInlineAjaxController.php The patch fixes this, and adds two acceptance tests to have a basic coverage for the new content element wizard, the element browser inline image selection, and the localization 'synchronize' process. Change-Id: I9c930d3b7b625b96b6321c14c455d0e62f70b5dc Resolves: #97090 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73803 Tested-by:
-
André Buchmann authored
Resolves: #97087 Releases: main, 11.5 Change-Id: Ic9c20883bdca1bde52ebb21cdafb0fd4f82a0778 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73776 Tested-by:
-
- Mar 02, 2022
-
-
Oliver Bartsch authored
In case a stored page link, links to an invalid page (e.g. pid=0) or a no longer existing page, the corresponding array access must be omitted. Also the call to GU::fixed_lgd_cs should be skipped. Resolves: #97075 Releases: main, 11.5 Change-Id: I2055a2dfcde021efdd1fa8b20804595d7a40eac2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73775 Tested-by:
-
- Mar 01, 2022
-
-
Oliver Bartsch authored
The code example was not rendered, since a empty line was missing. Additionally, the title has to start with "Important:". Resolves: #97072 Related: #93635 Releases: main, 11.5 Change-Id: I85b53f8d2f89558300b6ea996e1ab1147a678a92 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73773 Tested-by:
-
Stefan Bürk authored
PHP8.1 changed the defaults for the second argument '$flags' from 'ENT_COMPAT' to 'ENT_QUOTES | ENT_SUBSTITUTE', which changes the behaviour if that argument was not specified. In general this is a good change, thus leaving it unspecified and live with the stricter default was considered as the way to go in general. However, in the specific case for rendering the ReST files of the changelog and view it in the install tool this change now displays weired and malformed documentation. To mitigate this, this patch sets explicitly the second argument to 'ENT_COMPAT | ENT_SUBSTITUTE' to restore the old behaviour but take malformed away for preparing the documentation content. See: https://github.com/php/php-src/blob/85b669e56583ee5d536168db7aaffbebe9d1aff2/UPGRADING#L166 Resolves: #97073 Releases: main, 11.5 Change-Id: I3e78ef1a218fe0f09ccbcf6f4b073cf5900d42c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73774 Tested-by:
-
Georg Ringer authored
Add a missing label to the workspace module and remove a not needed line break in a translation. Resolves: #97052 Releases: main, 11.5 Change-Id: I8a01373fde08bb249f42f9426247cbd589258731 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73755 Tested-by:
-
Stefan Bürk authored
doctrine/lexer has released a new minor version with fixed method docblocks, thus phpstan ignore pattern can now be removed again. See: https://github.com/doctrine/lexer/issues/62 > composer req doctrine/lexer:"^1.2.3" > composer req doctrine/lexer:"^1.2.3 \ --no-update -d typo3/sysext/core > Build/Scripts/runTests.sh \ -s phpstanGenerateBaseline Resolves: #97063 Related: #97055 Releases: main, 11.5 Change-Id: I5e729543c4721e7f9a17511c113139bf7908b208 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73754 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Oliver Bartsch authored
This moves some labels from the template to the locallang file, making them translatable. Resolves: #97048 Releases: main, 11.5 Change-Id: I0d02864296b98148e2f01449edc2edbe880847f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73772 Tested-by:
-
Kevin Appelt authored
Resolves: #97008 Releases: main, 11.5 Change-Id: I00e34e4d43d1babd085435d096af773876480e49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73737 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Feb 27, 2022
-
-
Andreas Fernandez authored
Resolves: #97058 Releases: main, 11.5 Change-Id: Id0871bd2931f5b28c3a8f56471bd15d9aac3fadc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73735 Tested-by:
-
Stefan Bürk authored
doctrine/lexer has released a new minor version with changed method docblocks, which now emits phpstan errors because of incompatible types. This patch raises the minor version for development and core usage and adding phpstan ignore pattern to the baseline file until doctrine/lexer has fixed the incompatible state. This is a dedicated preparation to raise other dev dependencies. Issue has been reported to the corresponding github repository: https://github.com/doctrine/lexer/issues/62 used commands: > composer req doctrine/lexer:"^1.2.2" > composer req doctrine/lexer:"^1.2.2" \ --no-update -d typo3/sysext/core > Build/Scripts/runTests.sh \ -s phpstanGenerateBaseline Resolves: #97055 Releases: main, 11.5 Change-Id: Ib5c04202bdc6a4b5787a191e4bf1e175982fb217 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73736 Tested-by:
-
Oliver Klee authored
GeneralUtility::getIndpEnv can also return values other than string, e.g., PATH_INFO might return null, and TYPO3_SSL will return a bool. Also, _ARRAY will return an array of all possible scalar values. The return type annotation needs to correctly reflect that in order for static type analysis to be able to work correctly when this function is called. Resolves: #97020 Releases: main, 11.5 Change-Id: Ibb24f1a3451c6598452402fc7a7b0a96c66bbd01 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73734 Tested-by:
-
Benjamin Franzke authored
The private container now provides access to non-public services that have been at least once injected (and thus be considered as service during DI compilation phase). This may be used to provide dependencies to functional test setups where some dependencies needs to be mocked while other should receive the vanilla dependency the container would normally inject. A functional test case does implement the ContainerInterface now, allowing tests to access both public and private services. $this->getContainer() may still be used if the default container (delivering public services only) needs to be injected into a service. Related testing-framework pull request: https://github.com/TYPO3/testing-framework/pull/331 Commands executed: composer req --dev typo3/testing-framework:^6.16.0 git grep -l "this->getContainer()->get(" | xargs sed -i 's/this->getContainer()->get(/this->get(/g' Resolves: #97032 Releases: main, 11.5 Change-Id: I5987d5244270a3e190c8721f6a8971c7fd1309ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73732 Tested-by:
-
Christian Kuhn authored
Running bin/typo3 upgrade:run now encapsulates the wizard in question in double ticks. Before: > bin/typo3 upgrade:run Running Wizard Sanitize existing SVG files in fileadmin folder After: > bin/typo3 upgrade:run Running Wizard "Sanitize existing SVG files in fileadmin folder" Change-Id: I0739f836eb2b9cade517563a135f0333ecb6e055 Resolves: #97054 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73665 Reviewed-by:
-
- Feb 26, 2022
-
-
colin_44 authored
Add documentation for editors about validators. Add to sitetree. Resolves: #97025 Releases: main, 11.5 Change-Id: If250bae9acf265574f20bcef801d2c1fd66ceeb2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73664 Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
-
colin.findeisen@tritum.de authored
This patch adds a documentation regarding form elements for editors. As a drive-by change the site trees for integrators and editors have been fixed. Resolves: #82357 Releases: main, 11.5 Change-Id: I06548dd0f51cdbd814067f1c44e49629fd56b68e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73663 Tested-by:
-
Oliver Hader authored
DefaultSanitizerBuilder for HTML sanitizer creates a new behavior for each invocation which is superfluous and can be cached in memory. Resolves: #96862 Releases: main, 11.5, 10.4 Change-Id: I4a6710524a1f2f1256c8aa7694ceaa56a627a07f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73462 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Feb 25, 2022
-
-
Björn Jacob authored
The documentation now includes an overview of the used validation messages and their error codes. While being on it, the DateRange validator has been documented as well. Resolves: #87393 Releases: main, 11.5 Change-Id: I5e91131d5464fde370609310a2a5a5a3b64941c7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73662 Tested-by:
-
Elias Häußler authored
The localization of error with code 1521293686 in DateRangeValidator is missing. This patch adds the missing localization. Resolves: #97044 Releases: main, 11.5 Change-Id: I18c05c17d34f85b897c796cb987a94151d6da1ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73661 Tested-by:
-
Ralf Zimmermann authored
To make the form manager and form plugins load faster, the patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/58054/ optimized the parsing of form definitions. Instead of using the YAML parser, a very rudimentary "parser" was introduced. This works fine, except for the fact that YAML escapes in form labels are not unescaped when displayed. This patch partially reintroduces the parsing of YAML, but only for the label. The performance drops only slightly. 10000x "loadMetaData()" (status quo) = 0.41 seconds 10000x "loadMetaData()" + parse label with yaml parser = 0.57 seconds 10000x parse the whole form definition with yaml parser = 7.57 seconds Resolves: #95733 Releases: main, 11.5 Change-Id: I742b18313af4c8fe90d2899848518d90f543f86e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73712 Tested-by:
-
Björn Jacob authored
This patch adds a new FAQ entry. It explains how to handle duplicate form submissions. Resolves: #95074 Releases: main, 11.5 Change-Id: Ide89f57dc296ab629b9bb50d76d7896cb998c008 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73660 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Elias Häußler authored
If section containers are changed (i.e. new containers are added or existing ones are deleted), the change is now recognized by adding a class `has-change` to the appropriate container. This assures the modal on exit is shown to the backend user to avoid discarding onsaved changes. Resolves: #95290 Releases: main, 11.5 Change-Id: Iff85a98f5f93876d1151909d28641ac6cca70874 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73706 Tested-by:
-
- Feb 24, 2022
-
-
Christian Kuhn authored
Scenario: * Create a page in live * Create a default language content element in live * Localize live page * Select a workspace * Localize the content element in workspaces, translate mode * Select live workspace * Delete default content element in live When deleting the default language content element in live, usually all translated content elements are deleted, too. This does not work for content element translations that have been created in workspaces (t3ver_state=1). Those elements *should* be discarded, but are not. The patch adds a method to DataHandler to take care of discarding t3ver_state=1 translations in workspaces when a live record is set to deleted, and adds two functional tests to verify behavior. Resolves: #97018 Releases: main, 11.5 Change-Id: I1bba5de52447cdfb9e80feca27aebf9855dccd28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73659 Tested-by:
-
checkmaldierethorik authored
With deprecating 3rd party usage of getTreeList() in QueryGenerator and QueryView with #92080 a comma has been missed as element list separator for a list merge with array_merge(...) in WorkspaceService. This emits a corresponding native PHP warning or error. Missing comma is added to avoid the warning and merge the elements properly. Resolves: #97011 Related: #92080 Releases: main, 11.5 Change-Id: I612eecac4ff1222191d6310e8996268e8746de69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73653 Tested-by:
Markus Gerdes <markus@madaxel.de> Tested-by:
-
Elias Häußler authored
Since form renderable validators are stored as SplObjectStorage instances, it is currently impossible to properly reset those validators, e.g. within a configured variant in the form configuration. This is because detaching during a foreach over SplObjectStorage instances updates the internal pointer. This leads to inconsistent behavior in the foreach loop. To come around this issue, a cloned SplObjectStorage is now used to remove all currently registered validators, properly resetting all validators for the form renderable. Additionally, this edge case is now covered by a functional test case. Resolves: #96424 Releases: main, 11.5 Change-Id: I91268e28a2c08fa21d655373e272204fbb9b84f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73657 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Björn Jacob authored
Integrators have to be aware of a problem when sending emails to BCC recipients. This patch documents the problem and offers a solution as well as links to the TYPO3 Core API as well as Symfony Docs. Resolves: #92354 Releases: main, 11.5 Change-Id: Ia1594d8f8c93dfa5c4d58e12d13e61aa350ea9d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73656 Tested-by:
-
Elias Häußler authored
Resolves: #97024 Releases: main, 11.5 Change-Id: If4b85ca494226fdd793af169c1e389e529e785b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73655 Tested-by:
-
Georg Ringer authored
With #86196 the condition for `contentObject` has been accidentally removed. Resolves: #92471 Related: #86196 Releases: main, 11.5 Change-Id: I2c6ca4668141639650e3b4b1b58da2270f827f76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73654 Tested-by:
-
Stefan Bürk authored
This patch raises styleguide to the recently released version to test against a more actual codebase, including backports and the one or other bugfix (postgres install etc). used command: > composer req typo3/cms-styleguide:"~11.5.4" --dev > cd Build/composer ; \ rm -rf composer.json ; \ mv composer.dist.json composer.json ; \ composer req typo3/cms-styleguide:"~11.5.4" \ --dev --no-update ; \ mv composer.json composer.dist.json ; \ cd ../../ Resolves: #97012 Releases: 11.5 Change-Id: Ic03b13ac3737d29a8d90e4957806a2f6dd173ab5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73674 Tested-by:
-
- Feb 23, 2022
-
-
Jan Delius authored
LanguageService state has been moved into runtime cache for further reducing the need to keep the LanguageService in a global state. Failing to predict the need to translate into multiple languages in the same context and process, $cacheIdentifier had not be included the language. This patch adds the current language to the $cacheIndentifier to support multiple language translation while keeping the LanguageService state clean. Resolves: #97009 Related: #94415 Releases: main, 11.5 Change-Id: If1eaa3d2724ccdd12979a974c30d722878eb55d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73685 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
- Feb 22, 2022
-
-
Stefan Bürk authored
Acceptance tests are the most likely tests to recover properly when automaticly retrying on test execution failure. CGL, integration, unit and functional tests on the other hand are more likely to fail with real issues and retry won't fix these issues, thus wasting CI execution time and job slots. The patch changes the default retry back to zero retries, except for 'acceptance' tests, including 'acceptanceInstall' tests. Resolves: #96999 Releases: main, 11.5 Change-Id: I570c7fc6c61fe55ab5f60b51c04161f935876d24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73648 Tested-by:
-
Oliver Hader authored
Change-Id: I132fa89c4523a1571b5088774523050430f18961 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73642 Tested-by:
-
Oliver Hader authored
Change-Id: I62fdb4ee41b85c87291ad38c28e4c4ecdaa7dc36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73641 Tested-by:
-
Stefan Bürk authored
In early stage of TYPO3v11 the storage format for data in the TCA ctrl transOrigDiffSourceField database field, often called l18n_diffsource changed from PHP serialized data to JSON encoded storage format with #91906, mainly to mitigate general security risks. doctrine/dbal enquotes json data provided as string with backslashes if not the correct field type is provided, which emits a postgres sql error exception when inserting or updating these fields, which are of type 'bytea' when dbms Postgres is used. Various parts of the core deal with arbitrary tables and don't know if a column is int, text or lob, or whatever. Those are blindly updated/inserted, resulting in Postgres saying "no". MSSQL has been named pickier than postgres in the past on that for similar issues with these fields. To solve this for MSSQL a expensive workaround on several places through the core with #81498 to get a working state and leaving it open to find a better way with a eventual cache-layer for these database field schema informations, thus unsolved yet. As core suffers now from the same issue for Postgres since the changed storage format, this patch adopts the choosen MSSQL solution for Postgres. This is a first bugfix solution with the tradeoff to be more expensive but working. Additionally one test case is added to cover this issue basicly but should be extended and further tightend in a dedicated patch. Improving the schema handling should be picked up and proper engineered in a another dedicated patch. Resolves: #96940 Related: #91906 Related: #81498 Releases: main, 11.5 Change-Id: I250fa10c9c7e06ddd330f7ab64f7680f21f3b4cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73551 Tested-by:
-
Christian Kuhn authored
With #92238, it has been postulated that Extbase validators should not be dependency injection aware. Further places following this idea have been done in v11 with #94451 and #94384. A final breaking ReST file has been added with #95026. All of that is pretty unfortunate and there is simply no reason that Extbase validators can not get dependencies injected, no matter if they're not singletons. This patch specifically targets v11 to allow dependency injection in Extbase validators again if extension authors really need this, and don't want to stick to manual dependency retrieval as outlined in #95026. This patch should basically mitigate issues for extension upgrades and paves the way for a more solid general solution in v12. Extension authors have a more smooth upgrade path, especially when supporting two core versions at the same time. The v12 version of this patch is identical with v11 for now - The breaking interface change, adapting all core validators, and declaring core validators 'final' in v12 will be done with a dedicated v12 patch as soon as this v11 tailored version has been aligned on. Note all of this is pretty hairy and the solution outlined with the patch for v11 hopefully gives the maximum amount of compatibility without being breaking again, with giving extension authors additional options, and having v12 options to further mitigate this complex mess. Resolves: #96332 Related: #92238 Related: #95026 Related: #94451 Related: #94384 Releases: main, 11.5 Change-Id: I5fea15c9b73c59e5d7c3212a0842bc9a3413d2a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73630 Tested-by:
-
Nikita Hovratov authored
When using the option "references" as an array, it is possible to provide table and uid with stdWrap functionality. The return type can be mixed so proper casting is necessary. Also, empty values like an empty string for table or "0" for uid should not trigger $pageRepository->getRawRecord and the fallback values should be used instead. Another potential bug was found while adding test cases, where an empty table would result in nothing. In such a case, the current table should be used for relation fetching. Resolves: #96809 Releases: main, 11.5 Change-Id: Ieb90f846bbdafb50190c1d30008aa65e1dbb9e43 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73550 Tested-by:
-
