- Aug 28, 2018
-
-
Benni Mack authored
Instantiating TypoScriptFrontendController with the fourth parameter set (except null) will now trigger a deprecation message, as it is recommended to use the method `set_no_cache` instead. Resolves: #86002 Releases: master Change-Id: I6d8bbdd79d6b6169d358b5d17b036006d3c3205e Reviewed-on: https://review.typo3.org/58034 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Benni Mack authored
The previously available scheduler tasks for auto-publishing and cleaning up preview links have been moved to a symfony/command, allowing them to be scheduled, but also triggered manually on the command line without having to create a task record in scheduler. The old tasks have been deprecated, as there is the possibility to create tasks out of symfony commands as well. The AutoPublishService, which only acted as a wrapper, but had a major design flaw has been deprecated as well. The scheduler tasks will be removed in TYPO3 v10. For TYPO3 v9, their labels have been updated, and they will trigger a deprecation notice. Resolves: #86001 Releases: master Change-Id: I9c1f1e31b6ff59d02b20ffc2df805e645bb3f675 Reviewed-on: https://review.typo3.org/58056 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Aug 27, 2018
-
-
Tymoteusz Motylewski authored
The last place which was missed when porting the extension to namespaces, is now fixed. Also slash sign has to be escaped in SQL. Resolves: #85999 Releases: master, 8.7 Change-Id: I844b59b209ef1434298575b57fc7dc861ecab643 Reviewed-on: https://review.typo3.org/58052 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Christian Kuhn authored
The patch fixes a fatal php scenario if a page is created on root level. The data handler now flushes site caches if that happens and unsets the SiteMatcher singleton so it is forced to be recalculated if re-used in current request. Change-Id: Ie54f70b1bbfaaf1f6302f4e6b14abcf6af4c310f Resolves: #85985 Releases: master Reviewed-on: https://review.typo3.org/58017 Tested-by:
-
Paweł Rogowicz authored
Remove toggle function from root node and set expanded on true if there is only one node on depth 0. If there is more then 1 (e.g. when using DB Mounts) then keep toggle option. Releases: master Resolves: #85809 Change-Id: I94f9e20d048760e3a35ba1e8ed170521406a92d3 Reviewed-on: https://review.typo3.org/57911 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Christian Kuhn authored
A series of unused and dead code places are fixed with the patch: * Switch + return + break -> the break is obsolete * A couple of 'too many arguments' when calling methods * Various assignments of variables that are never used Change-Id: I8472597f73a739bce053cf6de772c111ae7044d7 Resolves: #85993 Releases: master Reviewed-on: https://review.typo3.org/58047 Reviewed-by:
-
Benni Mack authored
When registering a Symfony Command, it is now possible to define a new option `schedulable` which can explicitly set to false, in order to have e.g. EXT:scheduler not show some. This implements the functionality previously only available for Extbase's CommandControllers. Resolves: #85991 Releases: master Change-Id: Ie2d8d3cc71d04263984a928debd257ecb88184e8 Reviewed-on: https://review.typo3.org/58046 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Benni Mack authored
This is a pre-cursor for unifying URL generation with slugs / based on sites, in order to group things that belong together in the mass-method of generating links in the frontend. Tasks done: - $linkText is moved to the very end, as it has no dependency. - $targetDomain/$currentDomain handling is grouped together. - absRefPrefix is now always taken from $tsfe->absRefPrefix, as this is the resolved path (not set to "auto") - minor un-needed calls simplified (unneessary checks etc) Resolves: #85964 Releases: master Change-Id: Iba84cd98fa614ef7131c03a093c9cfa0a0056575 Reviewed-on: https://review.typo3.org/58022 Tested-by:
-
Benni Mack authored
A new upgrade wizard is introduced, which sets page URLs based on the page title and rootline, if they are empty. All root pages will get "/", all others will have a "/path-to/my/page/" pagepath. On top, if RealURL generated pagepaths already (works with v1 and v2 by checking for the database table), they will be used instead of generated slugs. Pages with an alias field take priority over "regular" pages and values from RealURL, whereas alias fields will result in a slug like "/my-alias-value". Resolves: #85928 Releases: master Change-Id: Ie0cfbfb9e8472e15717ea39cb1af65896743f293 Reviewed-on: https://review.typo3.org/57991 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Daniel Goerz authored
Resolves: #85979 Related: #81200 Releases: master Change-Id: Ibab30517c6380d1a7fda59656e12700d4193170a Reviewed-on: https://review.typo3.org/58038 Tested-by:
-
Mathias Brodala authored
We do not have a replacement for TYPO3v9 so we cannot deprecate this annotation yet. This reverts commit c7791b01. Change-Id: Ie7228d6e13a5647698f2a5c26ebe9fd56de80aac Resolves: #85988 Related: #85977 Reviewed-on: https://review.typo3.org/58044 Tested-by:
-
- Aug 26, 2018
-
-
Łukasz Uznański authored
Add language configuratin for model tag in EXT:blog_example, reformat TCA files, unify sys_language_uid field configuration across all TCA files in extension Resolves: #85983 Releases: master Change-Id: I8e32f389216e279d59ed92a3af7e870d076b35a8 Reviewed-on: https://review.typo3.org/58041 Tested-by:
-
- Aug 25, 2018
-
-
Alexander Schnitzler authored
Back then, the PHPDoc annotation `@cli` was added to indicate Extbase CommandController commands to be usable on CLI only instead of also be usable as a scheduler task. The scheduler implementation will be refactored in TYPO3 10 and the execution of commands from the backend will vanish. Therefore it will not be necessary any more to define if commands can only be used on the command line or not. In the future, all commands will only be executable from the command line. Releases: master Resolves: #85977 Change-Id: I52330517b51c5c747177cab55e34a721a0df5f67 Reviewed-on: https://review.typo3.org/58037 Tested-by:
-
Benni Mack authored
The class ContentObjectRenderer expects $typoScriptFrontendController as first argument inside the constructor. When creating cObj from within TypoScriptFrontendController, it is very valuable to actually use the actual current object instead of doing the regular fallback to $GLOBALS['TSFE'], to use this in proper recursions. Resolves: #85968 Releases: master Change-Id: I2238c8fc4d4d76f177b02630ed5627a3c9a7a060 Reviewed-on: https://review.typo3.org/58026 Tested-by:
-
Benni Mack authored
The method PageRepository->getFirstWebPage() is only used when no "?id" parameter is given, and no rootpage was resolved. As this is the only use-case, a more generic "getMenu" method can be used, which does the same except for not "limiting" the query to one result, so there is a minimal memory penalty when doing so, however due to Pseudo-Site functionality this drawback is only in use for rare cases. Resolves: #85971 Releases: master Change-Id: I42fec4251963a0ab2baa038defde39cf0eac4bbf Reviewed-on: https://review.typo3.org/58029 Reviewed-by:
-
Benni Mack authored
The init method of GraphicalFunctions/Gifbuilder was used instead of a constructor to set up various internal properties, and is now shifted into a new constructor, making the extra call to init() superfluous. Resolves: #85978 Releases: master Change-Id: I71ee3bc8045f48b1636e46681dddd742ba1f56c4 Reviewed-on: https://review.typo3.org/58023 Tested-by:
-
Benni Mack authored
The protected method TimeTracker->fixContent() has an argument $first which is always set to "0", so the functionality can be removed. Resolves: #85967 Releases: master Change-Id: I4fbe73bd6d15b892dcc21b1cdd4456af4f80eeb3 Reviewed-on: https://review.typo3.org/58025 Tested-by:
-
Oliver Hader authored
GeneralUtility::getFileAbsFileName($logFile) never results in `null`, but in some empty string in case the $logFile is invalid. Resolves: #85973 Releases: master, 8.7 Change-Id: I2890bbf172c8f540dd2fa2775a9479d5c644b172 Reviewed-on: https://review.typo3.org/58031 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Benni Mack authored
Return types in phpDoc method annotations are wrong and should be adapted to the actual return value in the PHP code. Resolves: #85969 Releases: master Change-Id: I10f31957db1c863510a1bff97293c0bad336568d Reviewed-on: https://review.typo3.org/58027 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Benni Mack authored
The public property "TimeTracker->$LR" is declared as boolean, but used with integer. Let's have TYPO3 use it that way it was documented. Resolves: #85966 Releases: master Change-Id: I19faa67425440cb35b00924baee760b919a42ef3 Reviewed-on: https://review.typo3.org/58024 Tested-by:
-
Benni Mack authored
With the introduction of the environment API, composer-based installations have the configuration folder outside of "public-webroot"/typo3conf/, but in the project paths folder config/. All checks on PATH_typo3conf/ - LocalConfiguration.php - AdditionalConfiguration.php - AdditionalFactoryConfiguration.php are now done against Environment::getConfigPath(), resulting in different locations for projects having the environment variable "TYPO3_PATH_APP" set to something else than the "PATH_site" constant, the configuration is now found in "TYPO3_PATH_APP" . /config/. A migration to move all config files into the new directory is done when accessing the Install Tool automatically. Resolves: #84623 Releases: master Change-Id: I94020b1df4c9ffaec66310a4e1564927dbd8cb67 Reviewed-on: https://review.typo3.org/56517 Reviewed-by:
Richard Haeser <richard@maxserv.com> Tested-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
Markus Klein authored
Resolves: #85976 Releases: master, 8.7 Change-Id: I0f6588aa58be317da51cff59a5eb915831fc0774 Reviewed-on: https://review.typo3.org/58033 Tested-by:
-
- Aug 24, 2018
-
-
Benni Mack authored
When a new Uri('//newpage.com/') is added, TYPO3's PSR-7 implementation lacks the functionality to render that properly to a string, as - like the specs - say, when there is an authority, the implementation HAS to prefix the authority with '//', regardless if there is a scheme or not. Resolves: #85956 Releases: master Change-Id: Id888c4425ac2f4a3d9bc9f2a1a3213a872bc55b4 Reviewed-on: https://review.typo3.org/58014 Reviewed-by:Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Christian Kuhn authored
The infamous $GLOBALS['SOBE'] object is still used at various places is the core. This "talk to the hand" object registered as runtime global to make itself available as "parent object" is an even worse anti pattern than the also infamous $pObj. The patch removes a series of "$GLOBALS['SOBE'] = $this" assignments in some controllers that have no further dependency to this global anymore for a while, are easy to review and b/w compatible. Resolves: #85958 Releases: master Change-Id: Ia961289c344c96eab250fa7f206c677cb65e047c Reviewed-on: https://review.typo3.org/58018 Tested-by:
-
Christian Kuhn authored
The patch deprecates the unused compareUident() from AbstractAuthenticationService that calls the also unused method with the same name from AbstractUserAuthentication. The code is dead left over stuff from pre password hashing era and can be safely deprecated now. Resolves: #85960 Releases: master Change-Id: I5f02562e35abb27a4126998193edf827edb168ac Reviewed-on: https://review.typo3.org/58020 Tested-by:
-
Christian Kuhn authored
Fixes two broken namespaces that went wrong when moving and aliasing the salted password classes. The patch only affects the deprecated and unused SaltedPasswordService. Resolves: #85959 Related: #85833 Releases: master Change-Id: Iad8c95a3b9bef60fe240a2010e9910df40c75825 Reviewed-on: https://review.typo3.org/58019 Tested-by:
-
- Aug 23, 2018
-
-
Christian Kuhn authored
If a slug is generated for a nested translated page that has a not translated page up in its rootline, the slug generator now considers the default language page instead of not including the upper tree pages at all. Change-Id: Id5b4d3b1b815124413919bc8b48e03f2785573d9 Resolves: #85952 Releases: master Reviewed-on: https://review.typo3.org/58010 Reviewed-by:
-
Christian Kuhn authored
Add the new slug "URL Segment" field to the Info Pagetree overview directly after "Alias". Resolves: #85953 Releases: master Change-Id: I1d5706dfe7098f9f3983d222f4344f42d1bc197c Reviewed-on: https://review.typo3.org/58011 Reviewed-by:
-
Benni Mack authored
This feature adds a new database field "pages.slug" which allows to fill the database with URL segments which can then be resolved and built with for URLs for a specific page. On top, when a site is found with a proper "slug", the PageRouter of a site now resolves a /home/my-products/ to the correct page ID. Next steps: - Add URL enhancers API to allow to further resolve more parts. Resolves: #85947 Releases: master Change-Id: Ic64a758e847520b9a8dfc8b484c7613c9ba1f869 Reviewed-on: https://review.typo3.org/57994 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
-
Benni Mack authored
The setting of the domainStartPage has been simplified with the PseudoSite introduction, and, as it belongs to the enriching of the PageResolver, the functionality is moved from the SiteResolver to the PageResolver. Resolves: #85951 Releases: master Change-Id: I67f88c1b6369450f63b582be1205a8639217304e Reviewed-on: https://review.typo3.org/58009 Reviewed-by:
-
Helmut Hummel authored
Deprecations that trigger an error in early bootstrap lead to the situation that code that is using this (mostly declared) internal API will likely fail due to these errors, as they are not caught by the regular error handling, which is initialized later on. Userland code using this API will notice the depreaction even without those errors triggered. Therefore remove those deprecations errors in most places again so that tools like TYPO3 Console will be able to stay compatible with older TYPO3 versions as well. Also protect some methods straight away and add a deprecation layer for them. Resolves: #85944 Releases: master Change-Id: I97485dfd947028cf02ff62b17b453d2f174a531a Reviewed-on: https://review.typo3.org/58003 Reviewed-by:
-
andypa authored
Fixed a typo and added an example for EXT:indexed_search. Releases: master, 8.7 Resolves: #85942 Change-Id: Iffcecd753843733ef96c9e41da808a47b943405e Reviewed-on: https://review.typo3.org/58002 Tested-by:
-
Oliver Hader authored
Resolves: #85941 Releases: master Change-Id: Icbbeb31e8c905fc52523ee1c0267ac219e19c15f Reviewed-on: https://review.typo3.org/58001 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Susanne Moog authored
To better debug websites SQL logging has been added to the admin panel. SQL queries will be logged whenever the admin panel is installed and activated for the current user and request. Queries using query parameters are displayed with all occuring parameter values (grouped by the main query). To find where queries came from a short backtrace has additionally been added to the query logging. The logging itself has been implemented using the doctrine query logging functionality. Resolves: #84609 Releases: master Change-Id: I84eebc8a23d6fa15c20dc48781409d4ab03f1bb1 Reviewed-on: https://review.typo3.org/57889 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Willi Wehmeier <wwwehmeier@gmail.com> Tested-by:
-
Benni Mack authored
A new TCA type "slug" is added, which allows to generate a part of a URL which can later be used for adding URL segments to any kind of record. The new slug TCA type will be added to the pages database table separately to fill a page with the rootline "Home => Products => My Product" with "/products/my-product/details/" into the slug field when creating a subpage "Details" under "My Product". Once the slug field is added when persisting the record, changing a title (like the page title) will not modify the slug anymore, but instead this has to be modified separately. Next steps: - Add the TCA type "slug" to pages table - Introduce an upgrade wizard for that pages table - Improve FormEngine via AJAX validation of "uniqueInSite" for slugs - Implement slug resolving for pages. Resolves: #84729 Releases: master Change-Id: I079267f42308f40da71ab4765ba7e0251e79f736 Reviewed-on: https://review.typo3.org/56889 Tested-by:
-
Gerald Aistleitner authored
Changed the default value of linkText to '' instead of null to prevent strict_type throwing an error. Resolves: #85933 Releases: master, 8.7 Change-Id: I0a7567cd784360654649c11e686784ad3867858d Reviewed-on: https://review.typo3.org/57995 Tested-by:
Joerg Kummer <typo3@enobe.de> Tested-by:
-
Stefan Froemken authored
Add a white-space in front of default CSS class for buttons in field control wizards. Resolves: #85935 Releases: master, 8.7 Change-Id: Ie4889b20ba95cf96f6895d5fc2e5375c70c48cc9 Reviewed-on: https://review.typo3.org/57996 Tested-by:
-
- Aug 22, 2018
-
-
Benni Mack authored
In order to avoid usages of using PseudoSite objects directly, the following changes have been made: The main entrypoint for finding sites is now encapsulated the SiteMatcher class. * SiteMatcher->matchByPageId($pageId) which consistently checks for Sites and Pseudo Sites. This is now a singleton as it factors PseudoSiteFinder directly. * NullSite for PID=0 (which is a slim version of a PseudoSite and will stay around for longer than the PseudoSite). This marks the last part of the Site API functionality, as TYPO3 is now ready to work with the Site API in all places throughout Frontend and Backend. Resolves: #85930 Releases: master Change-Id: I5e75da22337e126a39b459388e21d7f9fe05e556 Reviewed-on: https://review.typo3.org/57992 Reviewed-by:
-
Christian Kuhn authored
With pseudo sites we now always have a site object in backend. The site object is needed multiple times in FormEngine, the upcoming slug handling adds another usage. The patch adds a FormEngine data provider to resolve the site object for any given page or record and adds it as 'site' to the result array. Resolves: #85927 Releases: master Change-Id: I7ebbd2e6591b54a54b6a5b56f95161b4ba6e5cee Reviewed-on: https://review.typo3.org/57990 Tested-by:
-
Daniel Goerz authored
Resolves: #85926 Releases: master,8.7 Change-Id: Iaa36ce61de922d367d285ad5f98bfef8f2ee4714 Reviewed-on: https://review.typo3.org/57988 Tested-by:
Achim Fritz <af@achimfritz.de> Reviewed-by:
-
