- May 02, 2014
-
-
Christian Kuhn authored
Optimize functional test bootstrap to improve performance: * Database schema for single tests of a test case are always identical by design. So a database can be re-used between single tests to save the table creation overhead. Database tables are truncated instead which is quicker. * Load less extensions by default, so less tables are created. * Enable class loader caches. Typically, tests instances with mysql on a ramdisk, tests are ~25% quicker, for native mysql on hdd the performance impact is ~50%. Change-Id: Ife1ea755c5336f7d4362b2affe7bba9e94862e92 Resolves: #58433 Releases: 6.2 Reviewed-on: https://review.typo3.org/29575 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Sascha Wilking authored
XmlParser has an issue with PHP < 5.4.28 leading to unexpected empty arrays raising warnings. If development preset is activated, warnings are turned into exceptions, so the extension list parser stops importing. Resolves: #58418 Releases: 6.2, 6.1 Change-Id: Idc6453bd8dcc46a933a1d6d72361ffff5842e39d Reviewed-on: https://review.typo3.org/29783 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Benjamin Mack authored
The ExtJS functionality for adding active classes can be done via CSS hover pseudo classes. This is faster (native browser functionality) and also removes some ExtJS code. With this change however, the hovering is not disabled anymore when dragging. Releases: 6.2 Resolves: #58359 Change-Id: Ifcc0307b436cf68dfcfe561444e779410978d576 Reviewed-on: https://review.typo3.org/29744 Tested-by: Stefan Neufeind Reviewed-by: Nadir S. Tested-by: Nadir S. Reviewed-by: Nico Schober Tested-by: Nico Schober Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes
-
Oliver Hader authored
If comparing localization of regular tables (like tt_content) to pages and its specific overlay table pages_language_overlay, the main difference is, that regular tables are copied directly and page translation are shown in the edit view first - without persisting to the database and thus not having a proper uid at this time, yet. This means, that "localizeChildrenAtParentLocalization" in the TCA field configuration won't have any effect. This change brings back the IRRE localization icons for children and "localize all" link for the media field. However, those are only displayed if the new page overlay has been saved once. Resolves: #57488 Releases: 6.2 Change-Id: I29886776b40accce48ce5cd10937ff65b20430fb Reviewed-on: https://review.typo3.org/29719 Reviewed-by: Markus Klein Reviewed-by: Wouter Wolters Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Tested-by: Nadir S. Reviewed-by: Frans Saris Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Stanislas Rolland authored
When inserting an image in the RTE, the default image title should be the image file title, not the image file name. Resolves: #58373 Releases: 6.1, 6.2 Change-Id: I5aa3aae4db83cbd36244b89cc37c78184b290228 Reviewed-on: https://review.typo3.org/29759 Reviewed-by: Stanislas Rolland Tested-by: Stanislas Rolland Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Nadir S. Tested-by: Nadir S. Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Benjamin Mack authored
The headline in the backend login screen that contains the sys_news information has a bottom margin and does not have the right size. Releases: 6.2 Resolves: #58362 Change-Id: I0977a3be627a469b902fb39b14417dc9feb738da Reviewed-on: https://review.typo3.org/29745 Reviewed-by: Nico Schober Tested-by: Nico Schober Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Anja Leichsenring authored
Category API was changed to silently fail instead of throwing an exception, but the corresponding tests were not removed. Releases: 6.2 Resolves: #58416 Relates: #58384 Change-Id: I52c0fac32c7f4385868ef5f28c6f94b583948e75 Reviewed-on: https://review.typo3.org/29772 Reviewed-by: Frans Saris Tested-by: Frans Saris Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Helmut Hummel authored
The idea was to fail when the category registry is used in a wrong way. This however causes troubles when the core itself reloads extension tables during extension installation process. Remove the exceptions, fail silently on wrong usage and let the installation work again. Resolves: #58384 Releases: 6.2 Change-Id: Icd6ec77fea9d95c9a58e75a85546c0ecc2a5c6d7 Reviewed-on: https://review.typo3.org/29765 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Markus Klein authored
Database compare does not work with DBAL in native mode as the ALTER TABLE statement is not processed correctly. The SQL statement is wrongly interpreted as array, but is of type string. Fix this by extending the check which determines the type. Resolves: #58147 Releases: 6.2 Change-Id: I467494c633b8af9e5a17dce64f071667dd985177 Reviewed-on: https://review.typo3.org/29631 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
- Apr 30, 2014
-
-
Torben Hansen authored
This patch sets [MAIL][defaultMailFromAddress] as a sender for successful and failed login mails for the install tool. If no defaultMailFromAddress is set, the fallback sender address is set to no-reply@example.com Resolves: #57401 Releases: 6.2 Change-Id: Ie4e7700fff9858772688486e5efb4a068d2fe7ff Reviewed-on: https://review.typo3.org/28926 Reviewed-by: Oliver Klee Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Stefan Neufeind Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Markus Klein authored
Improve the Install Tool system environment check for PHP maximum upload size. Resolves: #58260 Releases: 6.2 Change-Id: I9f0c0694298faa817d9ac827e2f0e7f589cd0611 Reviewed-on: https://review.typo3.org/29696 Reviewed-by: Jost Baron Tested-by: Jost Baron Reviewed-by: Stefan Froemken Tested-by: Stefan Froemken Reviewed-by: Stefan Neufeind Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Steffen Müller authored
The core uses values of environment variables for disabling the core updater and to determine the application context. When setting the variable with mod_rewrite, certain server environments prefix the variable name with REDIRECT_. To ensure compatibility for this case, REDIRECT_ prefix is prepended as a fallback if the regular variable is not set. Resolves: #53188 Resolves: #58358 Resolves: #53974 Releases: 6.2 Change-Id: Iaba7f936ff1362d1f70426ec8ad1b1821e4e0d3c Reviewed-on: https://review.typo3.org/25123 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Steffen Müller Tested-by: Steffen Müller
-
Markus Klein authored
* Add missing annotations * Shorten unnecessary namespace annotations Resolves: #57861 Releases: 6.2 Change-Id: Ic8e24e76e3ccc09122dc0a288f1e0b538685c478 Reviewed-on: https://review.typo3.org/29431 Reviewed-by: Oliver Klee Reviewed-by: Alexander Opitz Tested-by: Alexander Opitz Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Helmut Hummel authored
This change makes it again possible to call makeCategorizable from ext_tables.php files. This is done by directly applying additions to the TCA if the default TCA has already been applied. For details read the comparison matrix in the referenced bug report. Resolves: #58004 Releases: 6.2 Change-Id: I0cb69d0421a0df3f930cc9cac1b1811108572530 Reviewed-on: https://review.typo3.org/29560 Reviewed-by: Wouter Wolters Reviewed-by: Frans Saris Tested-by: Frans Saris Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Stefan Froemken authored
remove additional enableFields from where clause in ProcessedFileRepository as long as sys_file_processedfile is not part of TCA Resolves: #57906 Releases: 6.2 Change-Id: I393f7f952a59ca2f79bf35c8653375a54fec4170 Reviewed-on: https://review.typo3.org/29461 Reviewed-by: Oliver Klee Reviewed-by: Stefan Neufeind Reviewed-by: Frans Saris Tested-by: Frans Saris Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Philipp Gampe authored
The extension manager fails to show any error message if an extension update fails. Convert exceptions (e.g. dependency fails, TER download fails) into a nice flashmessage. Convert any server errors (uncatchable PHP errors) into a flashmessage. Resolves: #56823 Releases: 6.2, 6.1 Change-Id: Ife3c6d3dcd23177ba22192dd6ae720352931b538 Reviewed-on: https://review.typo3.org/28738 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Jost Baron Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Nico de Haen authored
The container ViewHelper does not provide a configuration attribute for includeCsh (Context sensitive help). As consequence ExtJS and ExtDirect code is always loaded in Backend Modules. Resolves: #58075 Releases: 6.2 Change-Id: I1978bdc0bf3fca40f78cdae9b214a808f58abe49 Reviewed-on: https://review.typo3.org/29590 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- Apr 29, 2014
-
-
Markus Klein authored
ActionMenuViewHelper contains a wrong example for the usage of the viewhelper. It uses a '=' where a ':' would be correct. Resolves: #58166 Releases: 6.2, 6.1 Change-Id: I135310be0ac2e8df59f81dfbf694a0febbcde99a Reviewed-on: https://review.typo3.org/29646 Reviewed-by: Kay Strobach Tested-by: Kay Strobach Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Markus Klein authored
Some extensions need page TSconfig in FE. This was restricted to BE only with #55593. Undo this change. Resolves: #58338 Releases: 6.2 Change-Id: Ia14d7d36c659598415f86f8fabf515879776d148 Reviewed-on: https://review.typo3.org/29729 Reviewed-by: Gerrit Mohrmann Tested-by: Gerrit Mohrmann Reviewed-by: Fabien Udriot Reviewed-by: Stefan Neufeind Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Stefan Froemken authored
We have removed startRange and endRange too early in NumberRangeValidator. As long as TYPO3 6.3 is not reached we have to reimplement these options again. Resolves: #58313 Releases: 6.2 Change-Id: Id012da11227230890b27aa24e1dba1787210f931 Reviewed-on: https://review.typo3.org/29722 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Apr 28, 2014
-
-
Jigal van Hemert authored
The reason for this behaviour is the combination of prototype.js and ExtJS. The ExtJS defer() method takes precedence. Calling the defer() method without any arguments would have resulted in using a default value of "0.01" seconds in standalone prototype.js, but results in directly calling the submitted function. The stack overflow is caused by not delaying the function call and thus ending in a recursive endless loop. Resolves: #58187 Releases: 6.2, 6.1, 6.0, 4.7, 4.5 Change-Id: I6db191ff67a3e869072877936d949fc733cda74f Reviewed-on: https://review.typo3.org/29655 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Markus Klein authored
In case login data is submitted and there is an existing cookie/session the current session is discarded and the current cookie is unset. Subsequently the login data is processed and login succeeds and a new session is established, but the new cookie is not set. Fix this be correctly remembering that we need to set a new cookie, after we disposed the current one. Resolves: #57751 Releases: 6.2 Change-Id: I2e4b4a381b4e557aeb95c4186c6e5365dbea442a Reviewed-on: https://review.typo3.org/29626 Reviewed-by: Fabien Udriot Reviewed-by: Stefan Neufeind Reviewed-by: Robbert V Tested-by: Robbert V Reviewed-by: Frans Saris Tested-by: Frans Saris Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Markus Klein authored
DatabaseRecordList (List module) generates returnUrls for localization links. These must not contain the 'justLocalized' parameter, as this would cause redirects to edit form over and over again. This fix removes the inclusion of all the GET parameters - introduced with #55314 - again. Only the module parameter is used from GET/POST. Additional API enables extbase plugins to add necessary parameters. The TableListViewHelper does not need any more parameters besides the module name and hence still works after this patch. Resolves: #58257 Related: #55314 Releases: 6.2 Change-Id: I641e4ce37e48c9ea4f9aabce41b11d8f824bf64d Reviewed-on: https://review.typo3.org/29701 Reviewed-by: Marc Bastian Heinrichs Reviewed-by: Oliver Hader Tested-by: Oliver Hader Reviewed-by: Wouter Wolters
-
- Apr 25, 2014
-
-
Oliver Hader authored
In frontend rendering mode PageRepository::versionOL() is called frequently to overlay workspace data. A further method call then creates a query with required t3ver_* fields. This query fails if a table is not considered to support workspaces/versioning at all. This behaviour is regression that has been introduced with issue #30604 during TYPO3 4.7 development. Resolves: #58180 Releases: 6.2, 6.1, 6.0 Change-Id: I81d24ea16116563f4f0d75fafd06496a9c4e993d Reviewed-on: https://review.typo3.org/29657 Reviewed-by: Wouter Wolters Reviewed-by: Markus Klein Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
- Apr 23, 2014
-
-
Jigal van Hemert authored
Reverted per request of the RM because: - there is a merge freeze for regressions - 6.2 is now a stable branch (no new features) Besides: - no documentation issue - not enough votes This reverts commit 8f520011 Change-Id: Ia1ffee069f825b678748808d756a2c04fd8edb18 Reviewed-on: https://review.typo3.org/29616 Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
Georg Ringer authored
The width of the element browser is sadly hardcoded to 600 and 650. In many situations the element browser would need more place and with this tiny change it would be easily possible to change that behaviour without overloading the whole file. Resolves: #58031 Releases: 6.2 Change-Id: I8a7df0e1c8f2c977af309fe5917c38ec6de99759 Reviewed-on: https://review.typo3.org/29555 Reviewed-by: Laurent Cherpit Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
Alexander Stehlik authored
The uid and pid parameters will now be passed on in the jumpToUrl() function of the element browser. This makes sure that Page TSConfig can still be retrieved when the user clicks on a tab. Resolves: #58005 Releases: 6.2 Change-Id: I04cecb0aade417254ed5b0320bbc398f44850617 Reviewed-on: https://review.typo3.org/29536 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
- Apr 22, 2014
-
-
Helmut Hummel authored
The page renderer is not designed to work with a second rendering pass without resetting to its initial state. Not resetting will cause double compression of files and creating wrong version numbered file names. Reverting this again means: ->addFooter* calls are ignored when being called before first rendering pass and only work when done after first rendering pass. Although this behavior is highly intransparent it cannot easily be fixed without heavy refactoring of the page renderer which most likely will break hooks. Introduced regression by this change: #57919 and #58010 This reverts commit c67e8ebb Change-Id: I9e489e49f65bb69e2f3c3b997cc14465d6a08d80 Reviewed-on: https://review.typo3.org/29580 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Markus Klein authored
GeneralUtility::getFileAbsFileName() returns a blank string for invalid paths. TypoScriptParser::includeDirectory() does not check the return value, but passes it on to TypoScriptParser::getAllFilesAndFoldersInPath(). This causes the method to enumerate all entries of /. Fix this by properly checking the return value of getFileAbsFileName(). Resolves: #58102 Releases: 6.2 Change-Id: I778ad6bfc9d4a6a08f36fdd6ae00ccb9a8d2c03e Reviewed-on: https://review.typo3.org/29607 Reviewed-by: Johannes Kasberger Tested-by: Johannes Kasberger Reviewed-by: Stefan Neufeind Tested-by: Wouter Wolters Reviewed-by: Wouter Wolters Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Helmut Hummel authored
Due to an oddity in page renderer, we cannot add the required JavaScript to the footer as it would not be rendered. Clean up the JavaScript to correctly work even when included in the header and change the hook to add the JS files to the header. Resolves: #58010 Related: #57294 Releases: 6.2 Change-Id: I354de3b0aeaf2b163b5df5301de6f0a0aaae34a6 Reviewed-on: https://review.typo3.org/29581 Reviewed-by: Oliver Klee Tested-by: Dirk Klimpel Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Apr 19, 2014
-
-
Christian Kuhn authored
The patch uses composer based dependency handling and other stuff pushing travis-ci tests to the next level: - phpunit registered as "dev" requirement in composer.json - vfsStream registered as "dev" requirement in composer.json - cms-composer-installers is not released stable and adapted in composer.json for successful dependency resolving via composer - cloning travis-integration repository is obsolete by inlining scripts in .travis.yml - cloning ext:phpunit is obsolete, native phpunit by composer is used now - it is possible to set functional test suite database credentials with environment variables, used in .travis.yml - redis cache backend tests are enabled on travis-ci again - use existing php modules of travis-ci environment speeds up build With phpunit from composer, the command to run tests is ./bin/phpunit -c typo3/sysext/core/Build/UnitTests.xml More documentation about that can be found at http://wiki.typo3.org/Unit_Testing_TYPO3 Change-Id: I4d524e8e0249ca22f34fc48b7209d60d72e5e921 Resolves: #57971 Related: #51436 Releases: 6.2 Reviewed-on: https://review.typo3.org/29495 Reviewed-by: Wouter Wolters Reviewed-by: Tymoteusz Motylewski Tested-by: Tymoteusz Motylewski Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
- Apr 18, 2014
-
-
Helmut Hummel authored
The TCA overrides are only parsed when the cache is built. But they also need to be parsed if the bootstrap requests an uncached load. Move the signal to loadBaseTca to accomplish this. Resolves: #58039 Releases: 6.2 Change-Id: I17b871060ec11ce044d8e09b5acfe8d20a36a5e8 Reviewed-on: https://review.typo3.org/29561 Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter Reviewed-by: Jigal van Hemert Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Christian Kuhn authored
Not using --keep-order in parallel gives output as soon as a job is finished and thus reduces the risk for travis-ci timeouts. Change-Id: If33087fbf4fc2b927ce52d153625140d89c2603a Releases: 6.2 Reviewed-on: https://review.typo3.org/29553 Reviewed-by: Wouter Wolters Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe Reviewed-by: Stefan Neufeind Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
- Apr 16, 2014
-
-
TYPO3 Release Team authored
Change-Id: I6e25181228d9c65bc4eee0b2309aed54ce24d181 Reviewed-on: https://review.typo3.org/29524 Reviewed-by: TYPO3 Release Team Tested-by: TYPO3 Release Team
-
TYPO3 Release Team authored
Change-Id: I43e62cf514ffc35d05163fee8bf0f222f3a18df7 Reviewed-on: https://review.typo3.org/29523 Reviewed-by: TYPO3 Release Team Tested-by: TYPO3 Release Team
-
Markus Hoelzle authored
This patch changes the warnings to a notices if files or folders are readable for anyone. This improves usability for users on non-restrictive systems as 1und1 servers. Resolves: #57354 Releases: 6.2 Change-Id: Ic9eba030647e837694331d394d45dc1553c0cdf5 Reviewed-on: https://review.typo3.org/28917 Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny
-
Frans Saris authored
On multiple places the new folder or filename is not sanitized before the checks are done to see if the a folder of file with that name already exists. This patch makes sure the new names gets sanitized first and also takes care that the name of the resultObject is passed to the PostFolderMove, PostFolderCopy and PostFolderRename signals. Resolves: #57681 Releases: 6.2 Change-Id: Id951ded531c9979e7cb4bdcd319f56a8f810fa96 Reviewed-on: https://review.typo3.org/29202 Reviewed-by: Stefan Froemken Tested-by: Stefan Froemken Reviewed-by: Stefan Neufeind Reviewed-by: Alexander Opitz Tested-by: Alexander Opitz Reviewed-by: Francois Suter Tested-by: Francois Suter
-
Jigal van Hemert authored
If the end of a result set is reached some drivers produce NULL. This must be changed into FALSE to be compatible with the non-DBAL version of these functions. Resolves: #57957 Releases: 6.2, 6.1 Change-Id: I664dd10735f88754c74e20ecd5c07fad5ef2b78d Reviewed-on: https://review.typo3.org/29502 Reviewed-by: Mathias Schreiber Tested-by: Mathias Schreiber Reviewed-by: Markus Klein Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
Xavier Perseguers authored
The TCA tree element fail to load inside IRRE, in some condition (when the record is not loaded/opened) Change-Id: Id077a71e2191b0cf91003611e11dc5aefafab0c9 Resolves: #39035 Releases: 6.2, 6.1 Reviewed-on: https://review.typo3.org/12850 Reviewed-by: Markus Klein Reviewed-by: Laurent Cherpit Reviewed-by: Dominique Feyer Tested-by: Dominique Feyer Reviewed-by: Fabien Udriot Reviewed-by: Frans Saris Tested-by: Frans Saris
-
Frans Saris authored
The maxLevels in the TCA tree configuration is not set by the CategoryRegistry. As a result only 4 levels are shown. This patch sets the maxLevels to 99 and also updates the appearance settings of the sys_category:parent field so these are inline with the other category tree fields. Resolves: #57750 Releases: 6.2 Change-Id: I7c33b71d2af214cf1b2027e4769c1cc43a3c43d6 Reviewed-on: https://review.typo3.org/29297 Reviewed-by: Alexander Opitz Reviewed-by: Francois Suter Tested-by: Francois Suter Reviewed-by: Stefan Neufeind Reviewed-by: Fabien Udriot Tested-by: Fabien Udriot Reviewed-by: Frans Saris Tested-by: Frans Saris
-