- Sep 20, 2017
-
-
Markus Hoelzle authored
Disallow backend users to edit pages which doktypes are not allowed via backend usergroup permissions. Resolves: #79954 Releases: master, 8.7, 7.6 Change-Id: I527602e71c62bc8e33b0886a5758c7c8040b4720 Reviewed-on: https://review.typo3.org/53715 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Tested-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org>
-
Oliver Hader authored
Change-Id: I2ac58940eef04059791b3ef8b76f7c2223e15b28 Reviewed-on: https://review.typo3.org/54169 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org>
-
- Sep 19, 2017
-
-
Oliver Hader authored
Change-Id: I8ec14f6fd21ec2757988c13f1612348998d198c5 Reviewed-on: https://review.typo3.org/54168 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org>
-
Oliver Hader authored
On creating child records for an inline field, the values of TCA['ctrl']['languageField'] configuration of parent and child records are used without checking if they are set at all. This patch adds appropriate guards. Resolves: #82330 Releases: 7.6 Change-Id: I6383e55820239b0363ff890855430ac32e2cdf62 Reviewed-on: https://review.typo3.org/53944 Reviewed-by:
Tobias Liebig <tobias.liebig@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org>
-
Markus Klein authored
Providing a non-existing entry-level to the getPageUids() method now returns an empty array instead of an array with key zero and a null value. This way we can correctly stop processing in the viewhelpers using the MenuViewHelperTrait. Resolves: #82507 Releases: 7.6 Change-Id: I99a610e612545648d7637e4a441dcdd1b1e51adc Reviewed-on: https://review.typo3.org/54167 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Johannes Kasberger <johannes.kasberger@reelworx.at> Tested-by:
Johannes Kasberger <johannes.kasberger@reelworx.at> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org>
-
- Sep 11, 2017
-
-
Philipp Gampe authored
Make sure root level excludes are prefix with a forward slash (/). Sort the .gitignore into logical groups. Releases: 7.6, 8.7, master Resolves: #81992 Change-Id: If1cb4105e57fb7ab3c28448abc3eaeb898da60e3 Reviewed-on: https://review.typo3.org/54113 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Sep 09, 2017
-
-
Tymoteusz Motylewski authored
addTypoScriptToTemplateRecord method was added to FunctionalTestCase.php in Testing Framework. So we can remove it from test cases. Fix two other gremlins also (unneeded comment and unused variable). Resolves: #82401 Releases: master, 8.7, 7.6 Change-Id: I8144bae5a807d60123ef5228a44eba579a7705c7 Reviewed-on: https://review.typo3.org/54060 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com>
-
- Sep 08, 2017
-
-
Alexander Opitz authored
Resolves: #82275 Releases: master, 8.7, 7.6 Change-Id: I77dc811456f4bbd759e28c27284c4652ad09dd23 Reviewed-on: https://review.typo3.org/54042 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Andreas Fernandez authored
If any callback is registered by `SplitButtons.addPreSubmitCallback()` and requests to stop the event by `stopPropagation()`, the event must be aborted and not only possibly stacked events. Additionally, the `preventExec` flag gets reset. Resolves: #82355 Related: #77942 Releases: master, 8.7, 7.6 Change-Id: Ib8478ef4c51915365c804c1c408b3fc16a13da0b Reviewed-on: https://review.typo3.org/54033 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
Andreas Fernandez <typo3@scripting-base.de>
-
Alexander Opitz authored
Resolves: #82322 Releases: master, 8.7, 7.6 Change-Id: I31f7bc2db61337e10be7ffd44ac294b77c44d07b Reviewed-on: https://review.typo3.org/53986 Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Sep 07, 2017
-
-
Tymoteusz Motylewski authored
Functional tests checking Extbase rendering of tt_content records with FAL images. Also fixes two typos in fixture data. Resolves: #82298 Releases: master, 8.7, 7.6 Change-Id: I2cddf81a99b08df46a7fd03dc0e54b41b10452e5 Reviewed-on: https://review.typo3.org/53921 Reviewed-on: https://review.typo3.org/53952 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com>
-
Tymoteusz Motylewski authored
Cover getContentObject related methods of ContentObjectRenderer by unit tests. Resolves: #80737 Releases: master, 8.7, 7.6 Change-Id: Ida957cd18c35d10cfc41f954ffdc15e0a04c03a8 Reviewed-on: https://review.typo3.org/53943 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com>
-
- Sep 06, 2017
-
-
Tymoteusz Motylewski authored
Functional tests checking TypoScript rendering of tt_content records with FAL images. It also backports small change to testing-framework, required for this patch to work. https://github.com/TYPO3/testing-framework/pull/30 Releases: master, 8.7, 7.6 Resolves: #82187 Change-Id: I5889ab13183b28dc2ff1ccc2c00c18f01ceacc76 Reviewed-on: https://review.typo3.org/53919 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com>
-
- Sep 05, 2017
-
-
Benni Mack authored
Change-Id: I20e4b22c6447b6c83d6c3850217f4c005f073861 Reviewed-on: https://review.typo3.org/53910 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
Change-Id: Iaed11281eaa6ba0be86396a7dd9b412873cbfe49 Reviewed-on: https://review.typo3.org/53909 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org>
-
Oliver Hader authored
Releases: master, 8.7, 7.6 Change-Id: I167c68d7d04dd4b8c876b1f6f8f939cf3d933478 Reviewed-on: https://review.typo3.org/53907 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org>
-
Susanne Moog authored
Some web servers allow and accept pht files as PHP files and execute them. Thus, pht should be part of the default file deny pattern and PHP file extensions. Resolves: #82078 Releases: master, 8.7, 7.6 Security-Commit: 548472d3d9dde59c6f9736666184b3853b734e0a Security-Bulletin: TYPO3-CORE-SA-2017-007 Change-Id: Idcd7b13383c10935469f23826297f59a7362f693 Reviewed-on: https://review.typo3.org/53896 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org>
-
Susanne Moog authored
TYPO3 does no longer send the concrete TYPO3 version as part of the default User-Agent header when doing requests. Resolves: #82072 Releases: master, 8.7, 7.6 Security-Commit: 5c4ded6108c4cb6c94ac11c58a4a9b9a1437ff25 Security-Bulletin: TYPO3-CORE-SA-2017-006 Change-Id: Icd6eb811ef96110d9c2636b5910a46186d248372 Reviewed-on: https://review.typo3.org/53895 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org>
-
Georg Ringer authored
If a user creates a sys_file_collection record, only those storage records must be shown which are allowed for the user. Resolves: #82029 Releases: master, 8.7, 7.6 Security-Commit: 3434e003fe61229e099fb80328ceda58e52c2eb0 Security-Bulletin: TYPO3-CORE-SA-2017-005 Change-Id: I41ea240e36b2a2834d385836477958652b3116a8 Reviewed-on: https://review.typo3.org/53894 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org>
-
Susanne Moog authored
Change-Id: I23d48a3afa20c8511b867abcf54cafbeaa86bf0c Resolves: #80735 Releases: 7.6 Reviewed-on: https://review.typo3.org/53893 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org>
-
Susanne Moog authored
For more information see https://github.com/jquery/jquery/issues/2432 Change-Id: I3fbd8d957ffe4a12163b6d5a3425a85f99951d09 Resolves: #80736 Releases: 7.6 Reviewed-on: https://review.typo3.org/53892 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org>
-
Benni Mack authored
In TYPO3 v8, the ConfigurationManager only checks if LocalConfiguration.php is writaeble and not if typo3conf itself is writable. Optimizing this check removes a warning in an environment where typo3conf/ is hardened to only have LocalConfiguration.php be modified and nothing else. This change helps running TYPO3 v7 on platform.sh with fewer error messages. You can compare this line of code with the same line in TYPO3 v8/master. Resolves: #82289 Releases: 7.6 Change-Id: I7adca89eaa0d9f5b28e3f034f9452d97591a0d80 Reviewed-on: https://review.typo3.org/53878 Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org>
-
- Aug 31, 2017
-
-
Oliver Eglseder authored
If a command throws an exception the exception code will be used as exit code of the CLI command. This will result in an integer overflow since exit codes are limited to 255, whereas 255 is reserved for PHP. (See PHP exit documentation) This commit checks if the return code will result in a 0 and change it to 1 instead. In TYPO3 v9 the exit code is limited by Symfony Console so no change in master is needed. Resolves: #82246 Releases: 8.7, 7.6 Change-Id: Id85fcbb61d6f0b4dd7f5ee9a1aaf55e648819b9c Reviewed-on: https://review.typo3.org/53842 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Aug 28, 2017
-
-
Tymoteusz Motylewski authored
Introduce and Extbase version of the LocalizedContentRenderingTest. It tests how language related TS settings influences content rendering. Also changes exception code in ContentController, to make bamboo happy. This test suite is documenting current behaviour, which is in fact inconsistent with TypoScript tt_content rendering. The next step is to provide a fix for extbase with a feature switch, so this test suite will become a version with feature swich being disabled. Resolves: #81823 Releases: master, 8.7, 7.6 Change-Id: Ia616e5089b0209cfb895216726f7192f39c88a45 Reviewed-on: https://review.typo3.org/53758 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com>
-
- Aug 22, 2017
-
-
Helmut Hummel authored
The encryption key is a vital part to ensure security of TYPO3. Not having it set (by accident) can lead to severe security issues. Therefore enforce it to be set and throw an exception in case it isn't, instead of just reporting a warning. Releases: master, 8.7, 7.6 Resolves: #82169 Change-Id: I79c73558d0968ae89a2867d6d5264530f434e1a3 Reviewed-on: https://review.typo3.org/53785 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
travis-ci still chockes on functional tests, even if splitting them among lots of single tasks. Run less tests in parallel and split to ever more jobs to have a higher chance for 10 minute output with given cpu constraints. Change-Id: Iafc984aaef96ec59422f9c48a74b7308dd7cd7d7 Resolves: #82170 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/53779 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Aug 21, 2017
-
-
Christian Kuhn authored
With the ever growing number of functional tests, we split the suite into more parts to prevent "No output has been received in the last 10 mins". Change-Id: I55665c723f91f77347b376992f7a7a28da67b0fd Resolves: #82145 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/53754 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Wouter Wolters authored
The type field contains a non existing field. Do not select this field in the query. Resolves: #82105 Releases: master, 8.7, 7.6 Change-Id: I9840712f4f87135740512ddf91a2b921b2515612 Reviewed-on: https://review.typo3.org/53747 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Aug 18, 2017
-
-
Wouter Wolters authored
Releases: master,8.7,7.6 Resolves: #82079 Change-Id: I21a6ebcff4ebd0c6f2d2c83e0aa6d9e2c03d32d9 Reviewed-on: https://review.typo3.org/53737 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com>
-
Wouter Wolters authored
Correctly use htmlspecialchars for the link. Resolves: #82077 Releases: master,8.7,7.6 Change-Id: I87ea4010aa187f5f601c31423fb1a0fc05a23107 Reviewed-on: https://review.typo3.org/53734 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
Andreas Fernandez <typo3@scripting-base.de>
-
Franz Koch authored
FAL drivers are not obligated to extend the AbstractDriver but only to implement the DriverInterface. Having custom drivers that are not based on AbstractDriver (because they are f.e. non hierarchical) currently causes an Exception because PreviewProcessing expects an instance of AbstractDriver as method argument. This patch changes te signature from AbstractDriver to DriverInterface. Resolves: #82114 Releases: master, 8.7, 7.6 Change-Id: Ia27c6c1c7510ecfe5afd0f7d8bedf81bf3d31c84 Reviewed-on: https://review.typo3.org/53684 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org>
-
Thomas Löffler authored
On a page without subpages the indentation for creating a new page below this page was wrong. This fix changes the indentation in this special case. Resolves: #72011 Releases: master, 8.7, 7.6 Change-Id: I505a96126ab8cf69ebae32c5a84aa9dbfa59c87f Reviewed-on: https://review.typo3.org/53726 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org>
-
- Aug 17, 2017
-
-
Susanne Moog authored
On creating child records for an inline field, currently no language is set and the children are stored with sys_language_uid 0. This patch adds the proper configuration to ensure a default children language according to its parent language. Resolves: #48883 Resolves: #76048 Resolves: #73609 Releases: master, 7.6 Change-Id: Id9e449dbb06fed11670eedec45a92529fb4acb6f Reviewed-on: https://review.typo3.org/53206 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com>
-
- Aug 15, 2017
-
-
Česlav Przywara authored
The "controls" parameter appended to YouTube embed URL is either set to value provided in $options array or to default backwards-compatible value (controls=2). Specifically, if controls option is set to 0, the controls parameter must be present in URL, because default value for it is 1. Fix is applied to related unit test too. Resolves: #82044 Releases: master, 8.7, 7.6 Change-Id: I1519b5f515f85eb473f590762171b250d26f32c4 Reviewed-on: https://review.typo3.org/53708 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Reviewed-on: https://review.typo3.org/53709
-
Tymoteusz Motylewski authored
Two new cases are covered in LocalizedContentRenderingTest: - when record is hidden in default language but its translation is not hidden - when visible default language record has hidden translation Resolves: #82012 Releases: master, 8.7, 7.6 Change-Id: I924c0082f010bf9d9de642111cc3d65844f00f1f Reviewed-on: https://review.typo3.org/53703 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org>
-
- Aug 11, 2017
-
-
Nicole Cordes authored
These fields were removed from EXT:frontend and moved to compatibility6. But both fields are still used by csc and should be provided by the extension itself. Resolves: #80609 Releases: 7.6 Change-Id: I07db632ab851dac94749924dd3d2fbadd8016802 Reviewed-on: https://review.typo3.org/53666 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org>
-
- Aug 08, 2017
-
-
Johannes Kasberger authored
Make sure the meta data is updated whenever a file is added to a storage with DuplicationBehavior::REPLACE. This is important as otherwise the internally stored file size is wrong! Resolves: #78009 Releases: master, 8.7, 7.6 Change-Id: I93b0700afc62268f8c7a61eea7183f86a87a075e Reviewed-on: https://review.typo3.org/53654 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org>
-
- Aug 02, 2017
-
-
Tymoteusz Motylewski authored
Add functional tests for tt_content rendering with different combinations of TypoScript language settings sys_language_overlay and sys_language_mode. It also backports a change from testing framework which is required by this patch https://github.com/TYPO3/testing-framework/pull/23 Resolves: #81185 Releases: master, 8.7, 7.6 Change-Id: I7df5b48a2baa3a52f8c6103b0657b21226c6ea5c Reviewed-on: https://review.typo3.org/53633 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com>
-
- Jul 31, 2017
-
-
Wolfgang Klinger authored
TCA type=group/internal_type=folder Resolves: #81728 Releases: 7.6 Change-Id: I0c527c13a3632635870e4451a4e7d61eb7bf4443 Reviewed-on: https://review.typo3.org/53497 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
DANIEL Rémy <dogawaf@no-log.org> Tested-by:
DANIEL Rémy <dogawaf@no-log.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Martin Bless authored
Change-Id: Ife6b1e33dd4cd37f122a65a5bb36df3a67f2f796 Resolves: #82011 Releases: 7.6 Reviewed-on: https://review.typo3.org/53631 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-