- Oct 26, 2023
-
-
Oliver Hader authored
To identify whether a nonce values was actually used (consumed), `ConsumableNonce` instances are used, instead of `Nonce` objects. The new `ConsumableNonce` inherits from `ConsumableString`. As a result, the `<f:security.nonce>` view helper would increase the consumption counter. This is important for additional cache handling in the frontend rendering context. Resolves: #101751 Releases: main, 12.4 Change-Id: Iea147b0130e3d350f5913dc75f33af61c18e8af3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80235 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Soren Malling authored
See if a object is a instance of \Stringable aswell as a TypeInterface. TypeInterface implements the __toString method but objects coming from extension can rely on either implements \Stringable or have the __toString method Resolves: #102263 Releases: main, 12.4 Change-Id: I840492b0011b60abc3754f215695154c90b7e707 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81576 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Garvin Hicking authored
See the issue for an example snippet and original bug report on StackOverflow. Also updates the documentation to reflect dealing with issues like these. Resolves: #102130 Releases: main Change-Id: Ia682af40dfce4df1f259e7c7f688096d6de4d0f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81389 Tested-by:
-
Anja Leichsenring authored
Tables with TCA columns set to type="number" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema and removes own ext_tables.sql definitions having type=number. Resolves: #102237 Related: #101553 Releases: main Change-Id: I810ce11f731f1423aed82bd303565244525c94e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81532 Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Oliver Hader authored
The new section "Content Security Policy Mutations" in the "Configuration" backend module shows the all available CSP scopes, the compiled CSP header value and all involved mutations in the order they are applied with their origins (static package configuration or dynamic resolution item). Resolves: #102017 Releases: main, 12.4 Change-Id: Id6d5f769400b340698fb463ad21f5e8af29a784a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81180 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Oliver Hader authored
MutationMode::Extend has some ambiguity when being invoked multiple times on modified ancestor source collections. This change introduces the new MutationMode::InheritOnce, MutationMode::InheritAgain and MutationMode::Append. The implicit behavior of MutationMode::Extend changes from the combination of MutationMode::InheritAgain + MutationMode::Append to MutationMode::InheritOnce + MutationMode::Append to avoid side effects with more configurations modifying the policy. Static mutations loaded from ContentSecurityPolicies.php are ordered accordoring to the packages dependency hierarchy. That is the reason, the configuration from ext:core had to be moved to both ext:backend and ext:frontend. Resolves: #101797 Releases: main, 12.4 Change-Id: I7ab8e9d3f5635783d026f585f15c27ff62189959 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80756 Tested-by:
-
- Oct 25, 2023
-
-
Christian Kuhn authored
The "notify" soft reference parser fits no apparent use case. It is removed. Resolves: #102260 Releases: main Change-Id: Ibfee513389da421f64e0f8de087513f19997a7d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81572 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christian Kuhn authored
A rewrite of the internal handling: * The class is now practically a stateless service, the two left over properties are 'stable' until TCA changes within an instance usage, which is not the case in current usages. * Extraction of setReferenceValue() and it's detail methods to CLI command 'cleanup:missingrelations'. That command needs an overhaul with another patch, but it's not more broken than before. * Public methods at the start of the file. * Clean method signature types. * Disentanglement of code details, removing various detail methods to simplify reading. A method with eleven arguments has been inlined. * Happy phpstan along the way. The entire thing should be much easier to grasp and follow now. Note getRelations() still returns a rather opaque array of weird entries which can't be resolved without additionally touching MissingRelationsCommand and ext:impexp. This should be streamlined with further patches. Resolves: #102258 Releases: main Change-Id: I77c78714c074cfed7d16bcb22347e62d9e9a4355 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81543 Reviewed-by:
-
Andreas Kienast authored
FormEngine UI has a rather inconsistent markup. Fields within Flexforms may appear within another `div` container, causing issues when trying to mark an erroneous field as such. To solve this short-termed, additional CSS rules are added to cover such cases. In the long run, the FormEngine markup must get consolidated. Resolves: #102252 Releases: main, 12.4 Change-Id: I671fd8fe2edbd2b3592e7f4e1f205544a074ec51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81545 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Thomas Hohn <tho@gyldendal.dk>
-
Andreas Kienast authored
The module `@typo3/core/ajax/input-transformer` is used to automatically prepare payload to be sent via AJAX. One sub-routine converts nested objects into a flat list recursively. However, the check for objects was not sufficient as, in JavaScript, `null` is also of type `object`. This patch hardens the check to consider non-null values only. Resolves: #102256 Releases: main, 12.4 Change-Id: I6cf902f6a4fa045a4f8304059607f8a359a97186 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81550 Tested-by:
Francois Suter <sutfra@gmail.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Andreas Kienast authored
The `SuggestWizardController` makes use of constructor DI. However, necessary configuration was missing, breaking the controller. This patch adds the necessary `#[Controller]` attribute, preparing the controller for the dependency container. Resolves: #102259 Releases: main Change-Id: If88475d5b719c9c747d74d47f35b9afd6fe1068f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81551 Tested-by:
-
Benjamin Franzke authored
And therefore maps into a JSON array instead of an object, preventing errors when CKEditor5 operated on the resulting confguration. Resolves: #102230 Resolves: #102245 Related: #102099 Releases: main, 12.4 Change-Id: Ia20e5927b10bbb56763e3fc01cc30c8c4d0252c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81552 Reviewed-by:
-
Christian Kuhn authored
ReferenceIndex no longer returns arrays having 'type=file' set for a relation type, nor arrays having 'file' set for 'flexFormRels' since the removal of internal_type=file with #87428. Only softref parsers can still return 'file' type soft references. The patch removes obsolete code from ext:impexp. Resolves: #102253 Related: #87428 Releases: main Change-Id: I1d8e48e36363ab4985347d1da91de5e30bc86d97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81546 Tested-by:
-
Benjamin Franzke authored
Enable all current PER-CS2.0 rules in order to reflect our current state of coding style. This was missed in #102240 because pre merge didn't perform a full CGL run when @PER was switched to @PER-CS1.0. Resolves: #102247 Related: #102240 Releases: main, 12.4, 11.5 Change-Id: I0e1c833ad99c4e06767dee8a2c4bcb2bdee6eb68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81541 Tested-by:
-
- Oct 24, 2023
-
-
Benjamin Franzke authored
PER-CS2.0 was added as clone of PER-CS1.0 in php-cs-fixer v3.27 in order to implement the new rules that are defined in PER Coding Style 2.0 [1]. The alias PER already points to PER-CS2.0 although the current set of rules are not implemented yet. [2] There is only one rule (single_line_empty_body) that is done by now and more will follow, so we rather pin to PER-CS1.0 for now (and enable single_line_empty_body which we already migrated to) in order to prevent having coding style changes with every php-cs-fixer raise. We rather wait until the 2.0 preset has been finished and is on par with the upstream php-fig definitions and then switch with one change. [1] https://www.php-fig.org/per/coding-style/ [2] https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/7247 Resolves: #102240 Related: #102236 Releases: main, 12.4, 11.5 Change-Id: I33377e4e5016f1e5cc8ab08a9e71a933dcd41d93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81534 Reviewed-by:
-
Till Hörner authored
Since #99739 the foreign record selector for type select no longer shows the record labels but the uids. Change it to show the label again. Resolves: #102244 Related: #99739 Releases: main, 12.4 Change-Id: I91640769eb76cdba42e781588a68aa449cca70c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81536 Tested-by:
-
Anja Leichsenring authored
The test showcased an outdated concept of custom eval implementation. The showcase has been removed to promote more modern approaches, now the test fails and is removed, too. This reveals a cross dependency between acceptance tests, which is fixed along the way by combining two test files. Resolves: #102238 Releases: main Change-Id: I91c437f31399a26f9ce052024a004f55dc6348dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81533 Tested-by:
-
Christian Kuhn authored
It's time to update to latest changes of php-cs-fixer to align with current community rules. This brings a rather huge series of changes, main changes due to single_line_empty_body rule which now formats empty class and method body curly braces into a single line, plus changes from function_declaration rule which tends to avoid more whitespaces. The change has a slight impact on phpstan, we regenerate baseline. To reduce backport headaches, this change is backported to v12 and v11. > composer req --dev friendsofphp/php-cs-fixer:^3.35.1 > Build/Scripts/runTests.sh -s cgl > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #102236 Releases: main, 12.4, 11.5 Change-Id: Iea45b10667951672b2194033216c49f580799f55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81512 Tested-by:
-
- Oct 23, 2023
-
-
Jasmina Ließmann authored
The "Limit history to this record" link in the record history module is broken and always uses the same link value. With this patch the correct value will be used. Resolves: #102234 Releases: main, 12.4 Change-Id: Iaf013b82746b03892d295ed8b8a67c3f8c63fbc6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81510 Tested-by:
-
Christian Kuhn authored
When a page with a content element that has images assigned is copied in workspaces, a PHP array access error is raised since sys_file_reference TCA has no sortby ctrl. Add an appropriate null fallback. Resolves: #102231 Releases: main, 12.4, 11.5 Change-Id: I453a612a62a359156c8be2e087d1d121f1b9c3ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81509 Tested-by:
-
Christian Kuhn authored
With various pre-patches being done, the ugly traverser method FlexFormTools->traverseFlexFormXMLData() is obsolete. This final patch to FlexFormTools removes that method and its helper from the codebase. We're actively removing the method and skip a deprecation phase in this case: First, the method is low level and usually not used by extension developers. Extensions like the TemplaVoila forks have their own implementations of FlexFormTools already, their migration is straight forward. Secondly, we probably want to further simplify FlexForm related details, maintaining the old traverser would be a hindrance since it's so hard to follow. FlexFormTools is now a stateless service. The patch comes with a .rst file mentioning the changes, and documents some details from previous patches. Resolves: #102229 Related: #102218 Related: #102212 Releases: main Change-Id: I866e8c92c07753b8c53ae3d8233c55d35614cb85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81504 Tested-by:
-
Uwe Trotzek authored
This change transforms the processed record of FlexForms into a human-readable format. This is especially useful when comparing changes in the history module or the workspaces diff view. The diff needs to be formatted with line breaks and tabs as the output is passed through "htmlspecialchars" before it will be displayed. The white-space css setting needs to be changed to "pre-wrap", because this is the only setting where line breaks and tabs are kept and the text will still be word-wrapped. Resolves: #91148 Releases: main, 12.4 Change-Id: I189555f459a3a96594e9c708b4ee71c908efd970 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75117 Tested-by:
-
Christoph Lehmann authored
The PreviewSimulator might turn on the includeHiddenPages flag in VisibilityAspect due to hidden pages in current the rootline. The flag is now taken into account when generating the rootline cache identifier and thus the rootline cache doesn't need to get flushed. Resolves: #102205 Related: #17599 Releases: main, 12.4 Change-Id: If5246c9297d00071852968d48801d35f4060d110 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81484 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Benni Mack authored
The introduction of the ImageProcessing object made it possible to refactor and clean up further code within TYPO3's Image processing lowlevel code. This change removes some previously added arguments and options such as the file extension, which needs to go into a separate resolver functionality. In the same effort, the logic and usage of the infamous $info array is reduced, and a drive-by fix for adding the quality parameter multiple times (happened in one of the previous refactorings) is added. Resolves: #102228 Releases: main Change-Id: Ifd7855236e73a225af402a359292f1256d591a5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81507 Reviewed-by:
-
Josef Glatz authored
This patch improves the readability of the record history view of an element which was edited in switchTo mode by showing the original user always on a new line. div tags are used instead of span tags, to reduce any dependency on bootstrap classes for displaying an element as display:block. Resolves: #102200 Related: #102091 Releases: main, 12.4 Change-Id: I873711d4be6651ff15ae82e0bd7cbc4c6bf16e26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81473 Reviewed-by:
-
Anja Leichsenring authored
After only records of table `sys_workspace_stage` can serve as entries for the `sys_workspace -> custom_stages` field, no dedicated definition of foreign_table_field is necessary in TCA. Removing it deletes one field in the database without other side effects. Resolves: #102227 Releases: main Change-Id: I3393a62f8d913760416bc5f06ae02aaf025cf863 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81506 Reviewed-by:
-
- Oct 22, 2023
-
-
Christian Kuhn authored
A simple TCA flex form definition in extensions simply uses the TCA 'ds' 'default' key to declare its data structure. tt_content is a bit more complex here, it uses 'ds' with a comma separated match list of two fields (ctype,list_type), defined by a 'ds_pointerField' combination to look up 'ds' keys. This is typically shadowed away for extension developers using EMU::addPiFlexFormValue(). But there is more: 'ds_pointerField_searchParent', 'ds_pointerField_searchParent_subField' and 'ds_tableField': Those allow looking up the specific data structure of a flex form field by having the data structure stored in a different table, including tree traversal functionality. These three config options have been implemented for TemplaVoila back in the old days. In practice *nobody* uses these core features, even the templavoila extension forks don't use the core implementation since they come with xclass'es of FlexFormTools, or implement the events. To reduce complexity, this patch now removes handling of these three TCA options. Note we don't migrate the TCA definitions away to not add not needed headaches for extensions implementing functionality on top of it. They are just not handled in core anymore, handling can be continued by implementing the data structure related events. Resolves: #102224 Releases: main Change-Id: Idd896a6bca179393c32360952f88bafd63de4898 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81503 Tested-by:
-
Christian Kuhn authored
The main worker query of `bin/typo3 cleanup:missingrelations` includes a "ref_table !== _FILE" where clause. This detail is obsolete since #87428: sys_refindex does not add such rows anymore. Resolves: #102222 Related: #87428 Releases: main Change-Id: I003117aca4e6afc21897532d6a70a8fabb5de803 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81501 Tested-by:
-
Nikita Hovratov authored
RuntimeException is never thrown in the executed code of ImageViewHelper. Reason is, that the image either is inside the fallback storage "0" or it was already caught by InvalidArgumentException catch block. For reference: There is no way to find out, which RuntimeException the author meant to catch. I assume it was the one in AbstractFile->getStorage (code: 1381570091). Resolves: #102223 Related: #71686 Releases: main, 12.4 Change-Id: Ia08c085a13c29b4188f955887dcaa0410c2f47b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81502 Reviewed-by:
-
Anja Leichsenring authored
Tables with TCA columns set to type="inline" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema and removes own ext_tables.sql definitions having type=inline. If the child side definition is set as any of * foreign_table_field * foreign_field and TCA of those fields is absent or set to type="passthrough", also those child relation SQL definition is autogenerated and can be removed from ext_tables.sql file. Resolves: #102210 Related: #101553 Releases: main Change-Id: I073dbbfc507fb9225924002ddf704239865f4ec3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81488 Reviewed-by:
-
Nikita Hovratov authored
This is a follow-up patch for #102220. A dedicated fileadmin path has been added for ImageViewHelperTest and unnecessary fixtures are removed. In addition, error message checks are added for the invalidArgument test cases in order to clarify, what exactly is supposed to go wrong. Resolves: #102221 Related: #102220 Releases: main, 12.4 Change-Id: I03404c5f15f1a67032fce01febc4a9a5214373f6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81500 Tested-by:
-
Nikita Hovratov authored
- Remove duplicate test case for src="" and image="null" - Avoid instantiating ImageViewHelper with "new" -> use TemplateView - Add missing scenarios for possible exceptions Resolves: #102220 Releases: main, 12.4 Change-Id: I18b5cdbe7471a53ebb57bbe5521fecc051a24d26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81498 Tested-by:
-
Christian Kuhn authored
Similar to the works done for CLI cleanup:flexforms, ReferenceIndex no longer uses the FlexFormTools traverser. The rewritten implementation is a bit lengthy but will shrink again with further refactorings that are possible when this patch is merged. The patch also extends the 'softref' related tests a bit to check some more field types. The changes in ext:impexp tests are the result of a slightly optimized return value handling. Resolves: #102218 Related: #102212 Related: #65464 Releases: main Change-Id: I3c6affabd581fbbe243770f6d50f7a4b0f218a36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81496 Tested-by:
-
- Oct 21, 2023
-
-
Oliver Klee authored
This is a pre-patch for adding more specific type annotations to the methods in this class. Resolves: #102156 Releases: main Change-Id: Ic078983d9a81656a82a75487e87a5eba679abedc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81422 Tested-by:
-
- Oct 20, 2023
-
-
Christian Kuhn authored
The TCA "softref" logic in ReferenceIndex has close to no functional test coverage. The patch adds some tests using a new test extension to verify basic TCA 'softref' entries for simple DB fields, as well as simple TCA FlexForm fields, as well as FlexForm section containers. Resolves: #65464 Releases: main Change-Id: Idb33e40517f3b24bc314f24b40783f53d521d791 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81495 Tested-by:
-
Christian Kuhn authored
The event dispatcher should always be injected via DI, either directly or through makeInstance(). It should not be nullable. Switch a couple of service consumers to get an instance injected. Note further patches will remove left over state properties from FlexFormTools ensuring the service is fully stateless in the end, which is pretty much the case already, but not obvious. Resolves: #102213 Releases: main Change-Id: I9c6dc87156ce1cfd69b8fdbb636364c456e91b60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81491 Tested-by:
-
Christian Kuhn authored
FlexFormTools->cleanFlexFormXML() is only used by CLI cleanup:flexforms. traverseFlexFormXMLData() is used as recursive worker method. FlexForms are not recursive anymore since v7/v8: The data structure allows sheets with elements. An element is either a single field, or a section that can have containers, which can have single field elements again. Section containers can not be nested. This allows us to transform cleanFlexFormXML() into some nested foreachs handling single field and section container data directly, avoiding a recursion. This avoids a usage of the traverseFlexFormXMLData() method, which is very hard to understand and suffers from an ugly API with its callback approach. The rewritten implementation of cleanFlexFormXML() is now covered with tests and takes care of some other details like the '_TOGGLE' expand/collapse UI artefact in flex form data. Also, the "renumber" strategy for section containers has been dropped since it fits no practical purpose and just increases the number of records cleanup:flexforms wants to "fix". Resolves: #102212 Releases: main Change-Id: I30635e822e46e21b914623fca4ba54411b35ee34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81472 Tested-by:
-
Nikita Hovratov authored
In order to align with the current specification of .editorconfig, all xml files inside typo3/sysext and Build have their tabs replaced with 4 spaces. Executed commands: find ./typo3/sysext/ -type f -name "*.xml" \ -exec sed -i 's/\t/ /g' {} \; find ./Build -name "*.xml" -not -path "./Build/node_modules/*" \ -exec sed -i 's/\t/ /g' {} \; Note: Manual adjustment in some impexp fixtures have been done to keep tabs as there is a database version of FlexForm stored. Resolves: #102199 Releases: main, 12.4 Change-Id: I146e3ad53b1b6afdd5a7f5f725a409c301ecead1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81451 Reviewed-by: -
Simon Schaufelberger authored
Most fixes relate to indefinite article usage "an vs a" and some typos. Resolves: #102074 Releases: main, 12.4, 11.5 Change-Id: Ief07759697828d94edde8902a912719f82b2b798 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81305 Tested-by:
-
- Oct 19, 2023
-
-
Simon Praetorius authored
It is already possible to use the "value" argument together with "property" in form ViewHelpers. This should be reflected in the ViewHelper documentation. One possible use case is a form to edit a user. For the password field you would want to define property="password", but also value="" to not expose the current password hash to the form. Resolves: #102206 Releases: main, 12.4, 11.5 Change-Id: I3c7b1a201e38ccef84efcc863075043cf461dd20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81478 Tested-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
-
