The method is protected and is not called in the container then

Change-Id: I03ab47aa1030e782d14304d9371fc62b9c5aed18
Fixes: #35915
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10356
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

If the popup window with the login information is rendered,
an additional class can help to style the output a bit better

Change-Id: I606760e46f2af457aae025014002030d16a12763
Resolves: #38471
Releases: 6.0
Reviewed-on: http://review.typo3.org/12433
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The saltedpassword password conversion task for the schedular features
two configuration option:
 * canDeactivateSelf to disable the task after all records are processed
 * numberOfRecords to define how many records should be processed at
   once
Make those two options configurable via the schedular task edit
interface.

Change-Id: I9b090fa534b14c0051cda51fa3faf4e610b3948d
Resolves: #33703
Releases: 6.0
Reviewed-on: http://review.typo3.org/9139
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I75f1a27b4ef1a94831d6d80f8d0d8d649fc8d1ca
Fixes: #37618
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11840
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Complete redesign of the sys_notes

Resolves: #26796
Releases: 6.0
Change-Id: I7b8748c7142a1ab6615edb4567aa748d21c54a84
Reviewed-on: http://review.typo3.org/11789
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I33d8840390deba3e8a2ac5a188fd6fb089b91b5f
Fixes: #36290
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10660
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This happens because an object is handed over as
$arr[$key].
In this case convert $arr[$key] to a real array.

Change-Id: I128de2da656a3d4782bcb9b8b2a9519aade6ce9f
Fixes: #33444
Releases: 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/8693
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Fix CGL violations against InlineControlStructure

Change-Id: I2935a11c27c22070e9a3f08306c2cf69e3c83dd5
Resolves: #38494
Releases: 6.0
Reviewed-on: http://review.typo3.org/12456
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Fix CGL violations against InlineControlStructure

Change-Id: I296c5f8cc847c4d7d80ab64703834902d65aa8e2
Resolves: #38492
Releases: 6.0
Reviewed-on: http://review.typo3.org/12454
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Fix CGL violations against InlineControlStructure

Change-Id: I4fcde4f6d0b5d0252154f254799b9cef8fedc775
Resolves: #38493
Releases: 6.0
Reviewed-on: http://review.typo3.org/12455
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

TSFE->additionalFooterData was introduced with TYPO3 4.3, but
only for the purpose of t3lib_PageRenderer. The definition of
this property is e.g. missing at all in tslib_fe and besides
that, the handling for USER_INT/COA_INT objects is not there
at all.

Change-Id: I86372e332503d6907e5ff2d28c893bfd127bdcdc
Fixes: #29254
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11859
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Add missing calls to sql_free_result in t3lib classes.

Change-Id: Iac695e8e9644b068771947e03deef1062e0dd822
Resolves: #36762
Releases: 6.0
Reviewed-on: http://review.typo3.org/10920
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The flag showHiddenPage is set if the requested uid is a hidden page.
The original code always looked at the original uid and not to version
in the active workspace. This is fixed.

Change-Id: I6b1be8e459d499578ca30e13d1cc50e9b2ace415
Fixes: #33392
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8720
Reviewed-by: Stefan Neufeind
Reviewed-by: Bart Dubelaar
Tested-by: Bart Dubelaar
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Adding multiple images using the "import elements" link within
the record picker fails, since it calls a request to collapse
all already existing images of the element, without handing the
needed parameters.

As the needed parameters are not available at this point, just ommit
the request to close collapse the IRRE entries.

Change-Id: Ibc870cdcac32b4f5867ae12ca1020a20a5905310
Releases: 6.0
Resolves: #38383
Reviewed-on: http://review.typo3.org/12367
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

After the basic bootstrap refactoring that moved the loading of
ext_tables.php and ext_localconf.php to class context, it is now easily
possible to put the former temp_CACHED_* files to the caching framework
as cached PHP code, next to the autoloader registry cache entry.

This patch introduces a new API to t3lib_extMgm to handle the
loading of ext_localconf, ext_tables and the global TYPO3_LOADED_EXT
array and removes the current handling that was cluttered throughout
the core.

The setting of TYPO3_CONF_VARS['SYS']['extCache'] is now deprecated and
unused. The bootstrap now decides based on its context, whether caching
of those files is used. This way we can for example run the install tool
in a fully uncached environment and can get rid of the nasty side effects
we had in this area in the past.

With a simple call to t3lib_extMgm::removeCacheFiles() all cache entries
in PHP code cache that are tagged with 'core' can be removed at once.
This currently affects the autoloader registry, the TYPO3_LOADED_EXT
entry, and the concatenated ext_localconf and ext_tables files.

The patch furthermore gets rid of the _CACHEFILE array key in
$GLOBALS['TYPO3_LOADED_EXT'] that worked as a kind of API to the calling
method to indicate if a concatenated ext_tables and ext_localconf file
is available.

Change-Id: Id00be5f24ec1698ed9126e61b229a718d6ca6741
Resolves: #38414
Releases: 6.0
Reviewed-on: http://review.typo3.org/12383
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

In case there is no page (except the root page) within TYPO3, you can't
use the drag and drop functionality in the page tree to create the first
page.

Change-Id: I4f4aed78916f1ab0ebf9bbc1baad2b2743e9d1b2
Fixes: #24626
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10428
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

The media folder in the TYPO3 core is duplicated: It resides once
in tslib/media and once in statictemplates/media. It is only used
in statictemplates.

This patch moves the already "cglfixed" files from tslib/media to
statictemplates and removes the superfluous media folder.

Change-Id: I4c740849fd0d147590cf28efd6ae0680fc66b779
Resolves: #28024
Releases: 6.0
Reviewed-on: http://review.typo3.org/12334
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Solution: First parameter should be defined as reference so as to be
compatible with the definition of t3lib_rteapi::drawRTE().

Change-Id: I11a24893f9fb1020fb194c7d2cff2731f7ce52f0
Releases: 4.5, 4.6, 4.7, 6.0
Resolves: #37541
Reviewed-on: http://review.typo3.org/12426
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

Fix CGL violations against DoubleQuoteUsage

Change-Id: I6e97a8f02130b246c4eeaa9493722a53974c0a21
Resolves: #38358
Releases: 6.0
Reviewed-on: http://review.typo3.org/12338
Reviewed-by: Oliver Klee
Reviewed-by: Andy Grunwald
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The internal cleanup feature for the table sys_history
kept the entries only for 30 days by default. This behaviour
can lead to lost information if the history is needed and
the feature wasn't known and changed.

As a replacement, the users can use the table garbage
collection scheduler task that exists for some time now.

Change-Id: Iede559e0ece282c16a54e6659c26737c8bf86d90
Resolves: #38436
Releases: 6.0
Reviewed-on: http://review.typo3.org/12404
Reviewed-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Problem: inRange method not supported by standard range object used
with IE9.
Solution: Use standards-based method with IE9

Note: Thanks to Johannes Pfeiffer

Change-Id: Iccf230e6103e72953e49eb1a4dde967f3e65a5b7
Releases: 4.7, 6.0
Resolve: #38300
Reviewed-on: http://review.typo3.org/12422
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

The change improves the general spacing and CGL of the code,
removes some unused variables, tailores some very long lines
for better readability, adds the creation date, creation user
and last modified timestamp of the record and adds some general
actions to the references which improve the usability of the
feature a lot.

Change-Id: Iad2ec3ca01707a1486e2785115e3c5c25f6e1c57
Resolves: #38469
Releases: 6.0
Reviewed-on: http://review.typo3.org/12420
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I8474d3400245e47c817ca1a2c63116a410d03747
Resolves: #38453
Releases: 6.0
Reviewed-on: http://review.typo3.org/12419
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Changes the labels to be a bit more general since this CType can
be used for more than just sitemaps. Also changes the default
menu type.

Change-Id: Ibed4a9aa6d67059c9f8d6a517248ae33ed2a301b
Resolves: #17969
Release: 6.0
Reviewed-on: http://review.typo3.org/6743
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I26ba2f65f6b55c03adf3fa77cc9c12e3cf8132b0
Reviewed-on: http://review.typo3.org/12413
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

Change-Id: I91407bb8bd36d96ce19935eaa3c314dfda7ad09a
Reviewed-on: http://review.typo3.org/12412
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

Change-Id: Ic305bb1a44273833f53df88330b8f6ec3cf5f0da
Reviewed-on: http://review.typo3.org/12408
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

The method Typo3_Bootstrap_BaseSetup::getPathThisScript()
should be static but isn't

Change-Id: I96ce32ba5980f5a3612685bfe51c028eb23e2699
Resolves: #38428
Releases: 6.0
Reviewed-on: http://review.typo3.org/12394
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

For details read the ticket description.

Change-Id: Ibc22c62e7bb490e1871db92bbc09cd7e56581fa3
Resolves: #38357
Releases: 6.0
Reviewed-on: http://review.typo3.org/12339
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The DriverRegistryTest pollutes the global variable space,
which leads to failures in other tests if they are executed
after this test.

Backup and restore the global variables for this test.

Change-Id: I1abacbb8a49a771c64356215749c96ae02700cc2
Resolves: #38350
Releases: 6.0
Reviewed-on: http://review.typo3.org/12333
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Two tests still use a hardcoded path to the fixture files.
This fails if no typo3_src folder is present which is not
the case in some TYPO3 installations.

For this change it is necessary to also allow tests/ as prefix
for language files.

Change-Id: I89de174c8a80ea162ec3b0c3eef4817e7c8be475
Releases: 6.0
Resolves: #38349
Reviewed-on: http://review.typo3.org/12332
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

This patch merges all bootstrap code that is independent from the local
instance and configuration into one class. A wrapper method in
Typo3_Bootsrap is introduced to call the only public method of this
class. This reduces the number of public bootstrap methods and
creates a clear definition what code must be run until instance
specific configuration comes into the game.

Some code fragments like the time initialization is now done more early
in bootstrap, the according methods are merged in the class.

The basic error_reporting setup is moved to the very end of the class,
which forced some called t3lib_div methods to be notice free.

All code that can be easily tested in this class now has unit tests.

Change-Id: I90d48f8f4ff4a59b5507becb6102c90b39d9eebd
Resolves: #38344
Releases: 6.0
Reviewed-on: http://review.typo3.org/12319
Reviewed-by: Steffen Ritter
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Issue #37110 that aimed to allow case sensitive class name in
ext_autoload files has a bug that any class registered with CamelCased
class name is only found if the autoload entries are read from cache.

The patch now creates a lower cased entry as soon as the core_autoload
and ext_autoload files are read. There is an additional test that fails
if the changes in the autoload class are not applied. The naming of the
existing camelCase test was adapted to show that it is handling the
answer of an successful cache fetch only.

Additionally the current strtolower is changed to t3lib_div::strtolower
to make the whole thing multibyte safe.

Change-Id: I94f7ca5b3e60234f08433c747c00639d8dd219cd
Fixes: #38331
Related: #37110
Releases: 6.0
Reviewed-on: http://review.typo3.org/12310
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The new module menu classes have some CGL issues left.

Patch fixes missing comments and some wrong object
annotations.

Change-Id: I7b8e810fe732977e9efbd56075683601658971f4
Resolves: #38347
Releases: 6.0
Reviewed-on: http://review.typo3.org/12329
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This patch fixes a wrong calculation of margins for Text/Image
items with the properties "Beside text, left" and "Beside
text, right".

Change-Id: Ie484685aa2839123c42338862c241403614e7f7a
Fixes: #36541
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/10995
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Change-Id: I9e1a9af81ec767475911c48772ae60e754c29384
Reviewed-on: http://review.typo3.org/12327
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The backend at the moment uses a combination of the
GLOBAL variables TBE_MODULES and TBE_MODULES_EXT to
build the main menus of the backend (the module menu
on the left and the submodule menus of the backend
modules - look at info for an example).

To be able to easily change the representation of
these menus and to offer a clean API for rendering
menus the menu is refactored into an object structure
with n levels. This patch migrates the old GLOBALS
to a 3 level menu object. This means that you can use
the module menu object in your backend modules to
render your submenu.

This patch just adds the object structure and
transformation. It does not change any handling of
menus in the core itself. These changes can be done
piece by piece after this patch.

Change-Id: I1f7f9f5fcf83274840acef6cbeb267ea4ca460c3
Resolves: #38138
Releases: 6.0
Reviewed-on: http://review.typo3.org/12146
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

In EXT:tsconfig_help the method init() just call his parent.

This is not needed, because parent method are always called,
even if an extending class does not specify this explicitly.

Change-Id: I69d7aa47af7f6d90b8c3fb78c2f00d088e8a0597
Fixes: #38336
Releases: 6.0
Reviewed-on: http://review.typo3.org/12315
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

An empty constructor just calling parent is not needed, because parent
constructors are always called automatically.

Change-Id: I89384aa584048108fab444e3ee0d50e661c7d014
Fixes: #38335
Releases: 6.0
Reviewed-on: http://review.typo3.org/12314
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

In t3lib_file_Repository_FileCollectionRepository the method findByType
just call his parent.

Change-Id: Ia82ec630fdb8a54d77b413b98423c81f23a76941
Fixes: #38332
Releases: 6.0
Reviewed-on: http://review.typo3.org/12311
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn