- Mar 01, 2018
-
-
Claus Due authored
This patch improves the TranslateViewHelper by letting it be compiled to a single line of null-coalescing code in the Fluidtemplate. Since the ViewHelper is one of the most frequently used, saving method calls and condition checks here gives a nice result. Removes the need to load the VH class if all templates are compiled, further saving some calls and checks. Change-Id: Ifd3b051305d3cb631d3e8413bac40b4766136aef Resolves: #82454 Releases: master Reviewed-on: https://review.typo3.org/54119 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Frans Saris authored
To be sure the image (especialy gif format) is correctly repaged after cropping it the +repage option needs to be added to the full command. This patch adds the option for the LocalCropScaleMaskHelper and the ImageBuilder cropscaling `crs` option. Resolves: #83407 Releases: master, 8.7 Change-Id: I27b471d33acdc76c7af28ca0f114be72de91fcb9 Reviewed-on: https://review.typo3.org/55269 Tested-by:
-
Paul Golmann authored
Remove the ###SkipStripProfile### flag from command parameters added by e.g. stripProfile in TypoScript if GFX[processor_stripColorProfileByDefault] is disabled in global configuration to prevent erroneous imagemagick commands. Resolves: #80208 Releases: master, 8.7 Change-Id: I0860744ad4b27e44f1d9f7bb6da5dd646f4a1fc4 Reviewed-on: https://review.typo3.org/51990 Tested-by:
-
Mathias Brodala authored
For relations the internal field value contains a list of UIDs instead of full related records. Resolves: #82461 Releases: master, 8.7 Change-Id: Iec2a74fbc8d17636dd8751911984c337d4e99b63 Reviewed-on: https://review.typo3.org/55826 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Kevin Ditscheid <kevinditscheid@gmail.com> Tested-by:
-
Benjamin Franzke authored
Instead of creating the cacheManager and then disabling all cache confiurations afterwards, the desired state is enforced inside the CacheManager now (controlled through a constructor parameter). Releases: master Resolves: #84107 Change-Id: Ia3623a96246d97b74ee48eb2022ba35d5bcfcc04 Reviewed-on: https://review.typo3.org/55971 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Sybille Peters authored
* commit-msg hook: change wiki link to link to official contribution guide * commit-msg hook: rebase with original source * commit-msg hook: add Change-Id on last line after footer * pre-commit hook: check if staged php files conform to coding guidelines * Build/Scripts/cglFixMyCommit.sh: extended parameters to be used by new pre-commit hook Resolves: #83891 Releases: master, 8.7, 7.6 Change-Id: I6d00aa32ef3f9517d88e90c40059c7f73d7f6cfe Reviewed-on: https://review.typo3.org/55712 Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
Markus Klein authored
- Allows any protocol or wrapper for template sources - Ignores empty path specifications composer command used: composer update typo3fluid/fluid Resolves: #84095 Releases: master, 8.7 Change-Id: I52380fe465b112df73ab86c570f6a12d2eedf4d3 Reviewed-on: https://review.typo3.org/55956 Tested-by:
-
Christian Kuhn authored
Change-Id: Iddf30ed9c58bf94fe24021fd5b08ef2aed366eec Resolves: #84106 Related: #84086 Releases: master Reviewed-on: https://review.typo3.org/55970 Tested-by:
-
Markus Klein authored
The fix for #80991 introduced new data in the data structure returned by the SoftReferenceIndex class' methods. This new data stems from LinkHandlers, which may provide arbitrary data. This causes side effects for consumers of the SoftReferenceIndex like the reference index and the export functionality. By removing this extra data - which is not used anywhere at all - the returned data is again conforming to what is documented and keeps the interface to the SoftReferenceIndex clean. Resolves: #84080 Releases: master, 8.7 Change-Id: Ic39a8b593cb239aca698e857d1ee602bdeaf229f Reviewed-on: https://review.typo3.org/55939 Tested-by:
-
Benni Mack authored
The next PSR-15 middleware is introduced that was previously part of the Frontend Request Handler. It defines the actual (current) implementation to determine the Page ID and GET/POST parameters handled in TSFE. A possible alternative could be a Router doing the same process at this very position currently. Resolves: #84096 Releases: master Change-Id: I6aa9b5f35183034a8ebb93258d085acafb93862a Reviewed-on: https://review.typo3.org/55961 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
Sybille Peters authored
* handle uninitialized values * do not show all results in report if no linktypes checked Resolves: #84010 Releases: master, 8.7 Change-Id: Id04d2eed1b1390f2cbf67fd971d7cc4d61539f15 Reviewed-on: https://review.typo3.org/55872 Reviewed-by:
-
Benjamin Franzke authored
Do not rely on defined constants or methods from Bootstrap to be usable on it own (later). This is a preparatory refactoring to make the Application/Bootstrap unaware of the entryPointLevel handling. Releases: master Resolves: #84099 Change-Id: Ia2b3b47062db87139e446c928faee75890ffec08 Reviewed-on: https://review.typo3.org/55963 Reviewed-by:
-
Benjamin Franzke authored
Methods that do not use $this but mainly act as utility may be used statically. The previous non-static chainable behaviour is preserved by returning static::$instance. (Invoking a static method non statically does not trigger E_NOTICE or alike.) The motivation for this change is to deprecate the Bootstrap instanciated usage at some (later) point in order to reduce global state. The following methods are affected: * initializeLanguageObject * initializeBackendAuthentication * initializeBackendUser * initializeBackendRouter * loadExtTables * loadBaseTca * loadTypo3LoadedExtAndExtLocalconf * unsetReservedGlobalVariables * startOutputBuffering * disableCoreCache Releases: master Resolves: #83952 Change-Id: I59d3027c5d10326d7bab2ae02e6ff0eb836f23e4 Reviewed-on: https://review.typo3.org/55775 Tested-by:
-
Wouter Wolters authored
Resolves: #84091 Releases: master Change-Id: I61c24937b919ec54c6547c07d1c4460186725c96 Reviewed-on: https://review.typo3.org/55950 Reviewed-by:
-
Wouter Wolters authored
Resolves: #84094 Releases: master Change-Id: I0fff99f75287fd5a43093b5df540cea040420d21 Reviewed-on: https://review.typo3.org/55955 Reviewed-by:
-
Wouter Wolters authored
Resolves: #84090 Releases: master Change-Id: Ia2a34856b3b8066906125d7efed593e9291f476c Reviewed-on: https://review.typo3.org/55949 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Andreas Fernandez authored
Resolves: #82600 Releases: master Change-Id: Ie7b86399f0a75706b1072a3c41e162ab2992a8b0 Reviewed-on: https://review.typo3.org/55954 Tested-by:
-
Andreas Fernandez authored
Change-Id: If8a9b89295256491eb8bcc0e9afb1f37849050fc Resolves: #82581 Releases: master Reviewed-on: https://review.typo3.org/55874 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Andreas Fernandez authored
Change-Id: I151598e90487811217dfa685dcb83081848f2bb6 Resolves: #82578 Releases: master Reviewed-on: https://review.typo3.org/55908 Tested-by:
-
Benni Mack authored
The preview controller is now not attached to the backend module anymore, as the Preview functionality ("Split Bar on top") is technically a completely separate backend preview and completely unrelated to the workspaces Backend Module. This change also removes several hacks to generate Backend URLs. Resolves: #84074 Releases: master Change-Id: Id0ce7093f6d3ac94c8e4a9cfecd78027d26d45df Reviewed-on: https://review.typo3.org/55931 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Josef Glatz authored
Add missing TCA configuration for descriptionColumn in sys_file_collection records. The database column already exists in ext_tables.sql. Change-Id: I696e982145604114181240bef321683569187bcd Resolves: #84093 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55953 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Feb 28, 2018
-
-
Georg Ringer authored
Avoid using a prepared statement to return the final query part. Resolves: #84022 Releases: master, 8.7 Change-Id: I31c44172221962c1dbb3d97d02f6cfa61449d20a Reviewed-on: https://review.typo3.org/55914 Tested-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Sven Juergens <typo3@blue-side.de> Tested-by:
-
Josef Glatz authored
The space between the time amount and time unit must be added directly in the code, as it's not possible to add a leading space character in a localized string on our translation server. - use GeneralUtility::trimExplode() for localized label parameter - add space directly in the code instead of the LLL string Already translated strings must not be adopted. Change-Id: Iefeb1a4ed202a4110535fe62d13ce8691a10a80d Resolves: #84088 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55948 Tested-by:
-
Christian Kuhn authored
Patch for issue #83971 is only an Important change, not a breaking change and belongs to the 8.7.x documentation folder to stay in sync with v8 Change-Id: I1314eda5dbf90af5e61b940ad1431b82bd28b0de Resolves: #84086 Related: #83971 Releases: master Reviewed-on: https://review.typo3.org/55945 Reviewed-by:
-
Benjamin Franzke authored
As documented in Bootstrap code, GeneralUtility should be used instead of Bootstrap to retrieve the ApplicationContext. Therefore ClassLoadingInformation is adapted to read the ApplicationContext from GeneralUtility. Bootstrap now pushes the ApplicationContext early to GeneralUtility to be available for ClassLoadingInformation during bootstrap. Change-Id: I119ac944dd49c7d063b0f1e05f23e48f664ce2bc Releases: master Resolves: #84083 Reviewed-on: https://review.typo3.org/55940 Tested-by:
-
Frank Naegler authored
Google Chrome deprecated the browser notification API for unencrypted origins. For this reason we now use an additional check to prevent deprecation warnings in the console and disable this feature for instances without SSL/TLS. Resolves: #83971 Releases: master, 8.7 Change-Id: I9721842159e7ad3da9e5f4ee93a9bce3eaf5d0eb Reviewed-on: https://review.typo3.org/55916 Tested-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
-
Benjamin Franzke authored
Do not use global state from Bootstrap::getInstance(), rather pass the requestId from LogManager through the Logger to the LogRecord. We do not have a core object container yet, therefore Bootstrap now creates a LogManager, injects the requestId and stores that instance as singleton in the GeneralUtility singleton storage. Change-Id: Ia9af3c3a0e029a3748045fcf73e92f874f4a37ba Releases: master Resolves: #84082 Reviewed-on: https://review.typo3.org/55938 Tested-by:
-
Benjamin Franzke authored
As all request type specific initialization has been refactored to the Application classes, request type specific code in Bootstrap is unused [1] and can be removed. [1] redirectToInstallTool() is actually still in use, but moved into the frontend and backend Application classes with this change. (Also make their parent class abstract as drive-by change.) Change-Id: Ieded3603c2936d83d3d4701abef6c3884b558e31 Releases: master Resolves: #83869 Reviewed-on: https://review.typo3.org/55692 Tested-by:
-
Helmut Hummel authored
Renumbering array keys, even if all keys are integer is a destructive operation. Doing so at least breaks our logging configuration, which uses LogLevel constants as array keys and these constants are defined as integer. Therefore this pure visual optimization is removed when writing LocalConfiguration.php At a later point we might consider deprecating this method, which at least has a wrong method name (mentions "numeric", while it meanwhile uses "int" checks). As this method performs a destructive operation, its usefulness is limited. Resolves: #82304 Releases: master, 8.7, 7.6 Change-Id: I8d252428f3e27379e4377d30af0fdfd5e5d8719d Reviewed-on: https://review.typo3.org/55936 Tested-by:
-
Markus Klein authored
For Apache HTTP versions 2.3+ there is a better way to avoid conflicts in priority of sections. Since the `if` condition has been introduced it is ranked the highest priority, hence it is most suitable for rules to protect sensitive data. Resolves: #81849 Releases: master, 8.7 Change-Id: I3f6edf1e3af55dc3ce901080045c8d353eb89ef9 Reviewed-on: https://review.typo3.org/55937 Tested-by:
Nicole Cordes <typo3@cordes.co> Reviewed-by:
-
Georg Ringer authored
Simplify the sys_note handling by removing extbase from it Resolves: #84055 Releases: master Change-Id: Ib41d5e88c7ec9d79ee23dc913c3dc1ee0184c372 Reviewed-on: https://review.typo3.org/55804 Reviewed-by:
-
Tobias Kretschmann authored
Log a warning message if the configured TYPO3 backend login - logo or - background image can't get resolved. Change-Id: I782a9b08650d9b2f9cfb3cefb9c4ba18577d5a7d Resolves: #84050 Releases: master Reviewed-on: https://review.typo3.org/55911 Reviewed-by:
Wolfgang Klinger <wolfgang@wazum.com> Tested-by:
-
Georg Ringer authored
Provide a ViewHelper to render the markup to show an icon for files and folders. Resolves: #83942 Releases: master Change-Id: I44a99f3e06dc35b98b3e29f509432a8575c29807 Reviewed-on: https://review.typo3.org/55759 Reviewed-by:
-
Frans Saris authored
Releases: master, 8.7 Resolves: #84069 Change-Id: Idd642770341ddd5513c650e5ae230bcb5e7e6824 Reviewed-on: https://review.typo3.org/55927 Reviewed-by:
-
Benedikt Huß authored
Evaluate number of total items and trigger subsequent requests to process the remaining items, so that all changes are actually processed. Resolves: #84037 Releases: master, 8.7 Change-Id: I92f388b50328320973abcc290de52083f05655dd Reviewed-on: https://review.typo3.org/55933 Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Tested-by:
-
Benni Mack authored
The unused BE_USER method setWorkspacePreview() updates a DB field called "workspace_preview_id" which just does not exist at all. It would lead to an SQL error if called. However, since this method is never called, nor evaluated since TYPO3 6.2, all functionality should be removed. Previewing a workspace is handled via `be_users.workspace_id` anyway. Resolves: #84021 Releases: master Change-Id: I706e893aef1faaccf6e43f0e66ac28bff79190d8 Reviewed-on: https://review.typo3.org/55871 Reviewed-by:
-
Andreas Fernandez authored
Change-Id: Iafb5d62329d70704aac0dc73f8a6254e2745ffea Resolves: #82611 Releases: master Reviewed-on: https://review.typo3.org/55894 Tested-by:
-
Frank Naegler authored
Needs a typo3/testing-framework raise, too. Commands: yarn upgrade jquery composer update typo3/testing-framework Updates: - jquery@3.3.1 Resolves: #84063 Releases: master Change-Id: Iec4e821ebeb42c46da7d379ea081f3c0f25cc112 Reviewed-on: https://review.typo3.org/55921 Reviewed-by:
-
Claus Due authored
This patch adds a try/catch around the call in TSFE to get page and rootline with domain and makes getPageShortcut function set $this->pageNotFound code, then throw error. Change-Id: Id6aae04d7b4c2a8b267b0d949c056471c3a6b01b Releases: master Resolves: #78831 Reviewed-on: https://review.typo3.org/50805 Tested-by:
Christer V <cvi@systime.dk> Reviewed-by:
-
Andreas Fernandez authored
Commands: yarn upgrade grunt-contrib-uglify --latest Upgrades: uglify-js 2.7.5 > 3.3.12 Change-Id: I082a92d87ef1616488c0d8ddcf3801617a37eb50 Resolves: #84075 Releases: master Reviewed-on: https://review.typo3.org/55932 Tested-by:
-
