Skip to content
Snippets Groups Projects
  1. Nov 04, 2012
  2. Nov 03, 2012
    • Helmut Hummel's avatar
      [!!!][TASK] Rename ExtensionManager class · 133c1a9c
      Helmut Hummel authored
      The class ExtensionManager is actually a utility
      to manage extensions. Rename it to better reflect
      it's purpose.
      
      This is the final commit, which removes the old
      namespaced class name from the alias map and
      raises the submodule pointers.
      
      If you used ExtensionManager calls in your TYPO3 6.0
      extensions, you have to adapt your code and use the
      new class name.
      
      Resolves: #42661
      Releases: 6.0
      
      Change-Id: I371a64b276a93f25fabf6728bae8906fbc0e2c42
      Reviewed-on: http://review.typo3.org/16176
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      133c1a9c
    • Helmut Hummel's avatar
      [TASK] Rename ExtensionManager class Part 2 · 2171bf88
      Helmut Hummel authored
      The class ExtensionManager is actually a utility
      to manage extensions. Rename it to better reflect
      it's purpose.
      
      Renaming in submodules will be done seperately.
      The third step will then be to remove the old
      namespaced class name from the class alias map
      and raise the submodule pointers
      
      Related: #42661
      Releases: 6.0
      
      Change-Id: I0be22f117e9e4121001b6a14118d289834438066
      Reviewed-on: http://review.typo3.org/16163
      Reviewed-by: Anja Leichsenring
      Reviewed-by: Wouter Wolters
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      2171bf88
    • Helmut Hummel's avatar
      [TASK] Move ExtensionManager Class part 1 · 143d8b34
      Helmut Hummel authored
      Only move the class to keep track of history
      
      Related: #42661
      Releases: 6.0
      
      Change-Id: I9118c41c78493369ccc12ff5443c3faf2261fad4
      Reviewed-on: http://review.typo3.org/16162
      Reviewed-by: Wouter Wolters
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      143d8b34
    • Christian Kuhn's avatar
      [TASK] Re-implement update TER extension list task · 0d6d053c
      Christian Kuhn authored
      The scheduler task to update the TER extension list on a regular basis
      was removed with the implementation of the new extension manager.
      The patch adds an updated version of it and takes care that
      existing registered tasks of this type still work.
      
      Change-Id: Ic770ed78f23413b589352c25998eaee7863ec64f
      Resolves: #39915
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/16168
      Reviewed-by: Felix Kopp
      Tested-by: Felix Kopp
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Anja Leichsenring
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      0d6d053c
  3. Nov 02, 2012
    • Nicole Cordes's avatar
      [BUGFIX] Missing pid field in ext_tables_static+adt.sql · 998119f1
      Nicole Cordes authored
      In the ext_tables.sql there is a pid field which is left in the
      ext_tables_static+adt.sql file. This causes unnecessary ALTER queries in
      database comparison.
      
      Change-Id: Ia380f731c985a1739a88caf7c7f47fa3ec5a95cf
      Fixes: #42655
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/16152
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      998119f1
    • Christian Kuhn's avatar
      [TASK] Regression test for issue #39677 · 9aaa2f7a
      Christian Kuhn authored
      Add simple regression test for issue #39677 checking
      the generated string contains 'value="1"'
      
      Change-Id: I3bb51be68c22878d519d2176ab358777780b34d6
      Resolves: #42652
      Related: #39677
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/16151
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      9aaa2f7a
    • Oliver Hader's avatar
      [BUGFIX] Failure in AbstractRepository::findByUid on deleted record · d40ddbc9
      Oliver Hader authored
      Resource\AbstractRepository::findByUid fails if the record to
      be fetched has been deleted or simply does not exist. The
      condition whether something was fetched from database is wrong.
      
      count(FALSE) is TRUE, thus it needs to be ensure that there is
      a non-empty array.
      
      Change-Id: I9fbdb2ed79ceef9ed0782eeed3db15af73636731
      Releases: 6.0
      Fixes: #42593
      Reviewed-on: http://review.typo3.org/16102
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      d40ddbc9
    • Nicole Cordes's avatar
      [BUGFIX] Update LocalConfiguration fails · d6c90bbe
      Nicole Cordes authored
      Due to changes in function
      TYPO3\CMS\Core\Configuration\ConfigurationManager::writeLocalConfiguration
      an error is thrown when the configuration file isn't accessable.
      
      Of course when updating the system from a lower version it is not
      available. So the installation process has to create the file on its own
      to be able to write the settings.
      
      Change-Id: I89553390ebd9f1f576311535e02ec73da6618cd6
      Fixes: #42271
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/16088
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      Reviewed-by: Wouter Wolters
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      d6c90bbe
    • Nicole Cordes's avatar
      [BUGFIX] No sorting in TypoScript Object Browser when browsing · 451dcf95
      Nicole Cordes authored
      If you enable "Sort alphabetically" the correct value (1) is submitted to
      extension settings. But when you use any other functionality of the page
      (e.g. setting some conditions or use search filter) the value is set to
      "on" which disables the sorting.
      
      Change-Id: I88233f94edba032c9b23072fb5e9132b276c8f1e
      Fixes: #39677
      Releases: 6.0, 4.7, 4.6, 4.5
      Reviewed-on: http://review.typo3.org/13567
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      451dcf95
    • Steffen Müller's avatar
      [TASK] Add Test for namespaces in Logger names · dca21aa4
      Steffen Müller authored
      Resolves: #42582
      Releases: 6.0
      
      Change-Id: I5cf8c01ce1749be92e5e073b5812106ba08dc025
      Reviewed-on: http://review.typo3.org/16100
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      dca21aa4
    • Oliver Hader's avatar
      [BUGFIX] Enable extenisions with BE modules don't refresh the module list · 07477c96
      Oliver Hader authored
      When installing an extension with BE modules through the new
      extension manager, the left frame with modules is not
      refreshed. An accordant call to the module menu widget needs
      to be triggered in those cases.
      
      Change-Id: Ibead3b1a0da99be300c16ae3237986387294a74f
      Releases: 6.0
      Fixes: #42009
      Reviewed-on: http://review.typo3.org/16129
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      07477c96
    • Christian Kuhn's avatar
      [TASK] Require green PHP 5.4 build on travis again · f20f134f
      Christian Kuhn authored
      Change-Id: Ifd13543b1b3b337171214f70087bc7010b3c0898
      Reviewed-on: http://review.typo3.org/16146
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      f20f134f
    • Jigal van Hemert's avatar
      [TASK] Use BE paginate widget in EM 6.0 · bd78435b
      Jigal van Hemert authored
      The backend paginate widget provides the familiar paginator
      that is known from other parts of the backend.
      
      Change-Id: I8bbf5851ca099e2219fefa777a26feba101eeaba
      Fixes: #42583
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/16133
      Reviewed-by: Nicole Cordes
      Tested-by: Nicole Cordes
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      bd78435b
    • Christian Kuhn's avatar
      [BUGFIX] PHP 5.4 unit test warnings · 2b8bc0d7
      Christian Kuhn authored
      Incomplete mocking in some tests triggers
      string offset PHP 5.4 warnings.
      
      Fixes: #42644
      Releases: 6.0
      
      Change-Id: I261a7652909db21ee4839882a8360016cc854b2b
      Reviewed-on: http://review.typo3.org/16144
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      2b8bc0d7
    • Christian Kuhn's avatar
      [TASK] Speed up salted password unit test · d9f01d64
      Christian Kuhn authored
      The patch removes tests in blowfish and phpass salting classes that
      test maximum iteration count returns a valid salt. The underlying
      salt code is slow by design, so the tests also take ages. The
      functionality itself is already covered by the minimum salt count
      test as well, thus - after speaking with Marcus Krause - we decided
      to remove them without substitution to reduce the unit test suite
      runtime.
      
      Resolves: #42639
      Releases: 6.0
      
      Change-Id: I4bf94dc8ae4726fa131f6113546442fb00718753
      Reviewed-on: http://review.typo3.org/16141
      Reviewed-by: Wouter Wolters
      Tested-by: Marcus Krause
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      d9f01d64
    • Oliver Hader's avatar
      [BUGFIX] Translated non-published page in workspace breaks live workspace · 11a52d7c
      Oliver Hader authored
      Translation of pages are stored in pages_language_overlay and
      can be managed in workspaces as well. If a new translation is
      created in the workspace only, the page module is broken in
      the live workspace.
      
      The reason for that is, that workspaces placeholders need to
      be ignored if not working on a real workspace.
      
      Change-Id: Ied52a985c3cb1c0796f616679414799d956024d8
      Releases: 6.0, 4.7, 4.6, 4.5
      Fixes: #42281
      Reviewed-on: http://review.typo3.org/15958
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      11a52d7c
    • Wouter Wolters's avatar
      [BUGFIX] Illegal string offsets in t3lib_stdgraphic · 13fe75df
      Wouter Wolters authored
      Illegal string offsets in t3lib_stdgraphic
      
      Change-Id: I8be45d59b780595e25d6d7f5371300b6506baa2f
      Fixes: #38024
      Releases: 6.0, 4.7, 4.6, 4.5
      Reviewed-on: http://review.typo3.org/12543
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      13fe75df
    • Christian Kuhn's avatar
      Revert "[BUGFIX] Hook to modify t3lib_div::getIndpEnv return value" · cf36fd43
      Christian Kuhn authored
      This reverts commit 33e72f56
      
      Related: #39016
      Releases: 6.0
      
      Change-Id: I33ffcb206b2d4cac3cd7b683aec8df962c22d593
      Reviewed-on: http://review.typo3.org/16127
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      cf36fd43
    • Christian Kuhn's avatar
      [BUGFIX] PHP 5.4 unit test warnings · 2c1fd689
      Christian Kuhn authored
      PHP 5.4 throws warnings "Creating default object from empty value"
      warnings if $foo->bar is accessed and $foo is not an object. The patch
      fixes ConditionMatcherTest in this regard and does some other minor
      cleanups within the test class.
      
      Fixes: #42622
      Releases: 6.0
      
      Change-Id: I9d04618d88127b07d460be8dbd81c64633991bd6
      Reviewed-on: http://review.typo3.org/16124
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      2c1fd689
    • Michael Klapper's avatar
      [BUGFIX] Hook to modify t3lib_div::getIndpEnv return value · 52f1f35f
      Michael Klapper authored
      This hook makes it possible to modify the calculated return
      value for custom environments.
      
      Change-Id: I49a98565f8878cde44093ee2331d70b281e91f4f
      Fixes: #39016
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/12842
      Reviewed-by: Dmitry Dulepov
      Tested-by: Dmitry Dulepov
      52f1f35f
    • Mattias Nilsson's avatar
      [BUGFIX] "Upgrade Wizard" screen goes blank · 038b1e00
      Mattias Nilsson authored
      When using the "Upgrade Wizard" in install tool the screen goes blank.
      
      Change-Id: I3a9c6bb2c86bbeb2c0fa17fd547e626eebfc2749
      Resolves: #42569
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/16083
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      038b1e00
    • Felix Kopp's avatar
      [TASK] Use new Be.Widget.Paginate in EXT: beuser · 237a2e61
      Felix Kopp authored
      Use the new ViewHelper be.widget.paginate for backend
      user listing in EXT: beuser.
      
      The ViewHelper was introduced in #42428.
      
      Change-Id: Ic31d4a5aa1d6041d3fa5d610dffad02a3b5f87a3
      Resolves: #42576
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/16093
      Reviewed-by: Mattias Nilsson
      Reviewed-by: Oliver Klee
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      237a2e61
    • Christian Kuhn's avatar
      [TASK] Raise submodule pointer · 29f85451
      Christian Kuhn authored
      Change-Id: I48a5498e10da7b1a1185324a35381f3bf4cd1815
      Reviewed-on: http://review.typo3.org/16119
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      29f85451
    • Helmut Hummel's avatar
      [TASK] Cleanup DebugUtility · 519d48fa
      Helmut Hummel authored
      The debug utility outputs JavaScript, even when in CLI mode.
      Additionally all strings are not correctly encoded for
      JavaScript.
      
      Additionally deprecate the method which does incomplete encoding.
      
      Releases: 6.0
      Resolves: #42611
      
      Change-Id: I68fadc5d8f10e967913d1b79bc7758a5a18d77f6
      Reviewed-on: http://review.typo3.org/16117
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      519d48fa
  4. Nov 01, 2012
    • Christian Kuhn's avatar
      [BUGFIX] PHP 5.4 warning in CLI context in switch back user · 4882e9c4
      Christian Kuhn authored
      PHP 5.4 raises warnings of type "Illegal string offset" if you access
      $foo['bar'] and $foo is no array. This is the case in hook
      SwitchBackUser, if in cli context.
      
      Furthermore, the class is cleaned up a bit in 6.0 version and the
      compatibility layer is removed, since the hook file was moved around
      together with the beuser refactoring anyway.
      
      Change-Id: I5ed32e054b156c9fbc64e99ff33ba5c4637ce266
      Fixes: #37578
      Releases: 6.0, 4.7, 4.6, 4.5
      Reviewed-on: http://review.typo3.org/16108
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      4882e9c4
    • Helmut Hummel's avatar
      [TASK] Don't let PHP 5.4 failure fail the build on travis · 07d76b5a
      Helmut Hummel authored
      Change-Id: I21277f1f59a9055503414ae94f9dee626e1cd70d
      Reviewed-on: http://review.typo3.org/16109
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      07d76b5a
    • Christian Kuhn's avatar
      [BUGFIX] Warning in FAL LocalDriverTest · aca154c4
      Christian Kuhn authored
      A subfolder without write permissions makes the tearDown in FAL
      LocalDriverTest throw a permission denied warning. This is fixed
      by resetting the folder to be writable after gathering result
      information in the test case.
      
      Change-Id: I1eb9829b39af7ea67076252385e11701d4be3818
      Fixes: #42604
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/16107
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      aca154c4
    • Christian Kuhn's avatar
      [BUGFIX] Failing Unit test in FAL LocalDriver · 863e3660
      Christian Kuhn authored
      Issue #42603 changed the default behavior of the Driver systems
      to also show hidden directories by default. This should be
      reflected in the unit test with flipping the logic of one test
      that actually tested the opposite and fails now.
      
      Change-Id: I93492f2ec213423ffa06339f6a63de494d544534
      Fixes: #42230
      Related: #42603
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/16105
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      863e3660
    • Steffen Ritter's avatar
      [BUGFIX] FILES ContentObject ignores language handling · 75acaa90
      Steffen Ritter authored
      The FILES TypoScript ContentObject, which is responsible
      for rendering content element type "uploads" does not take
      care of languages and pages_language_overlay table.
      
      Change-Id: Ic311cf2162253bb1a382985df63999142b780555
      Releases: 6.0
      Resolves: #42357
      Reviewed-on: http://review.typo3.org/16098
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      75acaa90
    • Steffen Ritter's avatar
      [BUGFIX] Media field relation not resolved in translated pages · 2230137c
      Steffen Ritter authored
      Since the media field now is using IRRE relations and pages are
      translated to an foreign table, the relation of translated media
      images has to be resolved against the foreign_translation_table.
      
      Change-Id: Iceb62704a6b694945c37bfacdb29e45cc3cf2b6c
      Releases: 6.0
      Resolves: #42249
      Reviewed-on: http://review.typo3.org/16097
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      2230137c
    • Andreas Wolf's avatar
      [BUGFIX] Folder: File list filtering does not work · d4a90959
      Andreas Wolf authored
      To filter a file list for certain file extensions, the
      FileExtensionFilter class should be used. However, the element browser
      currently tries to directly call getFiles() with a file extension list.
      
      This commit adds filter handling methods to Folder and changes the EBs
      behaviour to use them. The public interface of Folder::getFiles() and
      Folder::getSubfolders() is extended, but in a backwards-compatible way,
      so this is no breaking change.
      
      Change-Id: Ib45d5f0a99c038841193ed568d7ebf8289f629d3
      Resolves: #41725
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/15405
      Reviewed-by: Dominik Mathern
      Tested-by: Dominik Mathern
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      d4a90959
    • Andreas Wolf's avatar
      [BUGFIX] Hidden files/folders are always filtered · 3c95e7f3
      Andreas Wolf authored
      The local driver has a hardcoded filter for dot-files, i.e. files whose
      name starts with a dot. However, we (or the user) might need these files
      in some situations. Therefore, the filter should be added by default,
      but should be removable, which is the case if we use the extensible
      filter mechanisms provided by FAL. This is done with this commit.
      
      Resolves: #42230
      Releases: 6.0
      Change-Id: I69ff38d35f75e2a7f4bbb7574caf6a261638512d
      Reviewed-on: http://review.typo3.org/15859
      Reviewed-by: Dominik Mathern
      Tested-by: Dominik Mathern
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      3c95e7f3
    • Jigal van Hemert's avatar
      [BUGFIX] EM 6.0 parse configuration type 'options' correctly · 04e8456a
      Jigal van Hemert authored
      The labels for the options are in the options= part, not in the
      label= part. Parsing the options correctly renders the select
      box as intended.
      
      Change-Id: I5a3c9e888f248a91c1c79f7a69f82a6a87880a3e
      Fixes: #42252
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/16090
      Reviewed-by: Dmitry Dulepov
      Tested-by: Dmitry Dulepov
      04e8456a
    • Helmut Hummel's avatar
      [TASK] Create uploads folder on travis · b02b2a27
      Helmut Hummel authored
      Upload folder is missing, leading to test failures
      after activation of warning to error conversion.
      Create the folder during setup.
      
      Additionally fix a warning in the FAL tests.
      
      Releases: 6.0
      
      Change-Id: I8762a7f2db07edf84294dccb0d9570434040534a
      Reviewed-on: http://review.typo3.org/16096
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      b02b2a27
    • Andreas Wolf's avatar
      [BUGFIX] Info link in file context menu broken · 660c8e89
      Andreas Wolf authored
      The link for file info in the context menu of the file list module does
      not work, as it missed the special identifier '_FILE'.
      
      Change-Id: Ie9990e3800b0d4e8b49c2594b4ad96d9ffe9839b
      Resolves: #41396
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/15295
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      660c8e89
    • Steffen Ritter's avatar
      [TASK] Prevent multiple processing ContentAdapter · c0fcf6be
      Steffen Ritter authored
      The FrontendContentAdapter is triggered everytime a record
      is passed to an ContentObject instance. Therefore it may
      happen, that the same record is processed by the
      FrontendContentAdapter multiple times.
      
      Prevent multiple processing by setting a flag for finished
      processing.
      
      Change-Id: Ia9d5ea6db684097c33008f8ec6273abd2a6deb8d
      Releases: 6.0
      Resolves: #42244
      Reviewed-on: http://review.typo3.org/15861
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      c0fcf6be
    • Steffen Ritter's avatar
      [BUGFIX] Rootline must not include references to deleted records · 03050f9b
      Steffen Ritter authored
      The rootline resolval includes deleted records. Deleted
      records should never be used in frontend. Add the missing
      deleteClause to the request.
      
      Change-Id: I2039d3343479ca080c747b1c39961d03efb34e0f
      Fixes: #39960
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/14302
      Reviewed-by: Mario Rimann
      Tested-by: Marcel Burkhalter
      Reviewed-by: Georg Ringer
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      03050f9b
    • Steffen Ritter's avatar
      [BUGFIX] ContentAdapter for FAL not capable of translations · 523a67e6
      Steffen Ritter authored
      The ContentAdapter, which rewrites FAL references to old
      style database formats, is not capable of dealing with
      relations - images and files so to speak - to translated
      tt_content record.
      
      IRRE Records always are related to the UID of the actual
      translated record - not to the uid of tt_content record.
      
      As in TSFE and/or CSS Styled Content Rendering the UID of
      translated records is stored within the property
      _LOCALIZED_UID this is what the ContentAdapater has to
      hand over.
      
      Change-Id: I5887511bcf1dd8fb481e45762e302e0908791bdd
      Fixes: #40609
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/14337
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      523a67e6