- Aug 27, 2024
-
-
Christian Kuhn authored
Some setUp() code is not triggered and thus obsolete. Resolves: #104747 Releases: main Change-Id: I72099d5d09bf36f83c381f3e12415a73e4190e56 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85791 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Lina Wolf authored
The module "TypoScript Record Overview" also contains site sets since #103439. The module labels are therefore generalized into "TypoScript Overview". Also show which entries are site sets and which are records. Resolves: #104730 Releases: main Change-Id: I83877d0a1ef5efdf6f1a82caedaed542bceb68d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85776 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Christian Kuhn authored
Logout should run through LogoutController. Avoid this widely unknown code in LoginController since it does not belong there and does not log. Resolves: #104744 Related: #104742 Releases: main Change-Id: Id535d620d4e72daf48ff05da6253de296df9f752 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85789 Reviewed-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Lina Wolf authored
When TypoScript is provided by a site set, not a sys_template record and the site has no "website title" it is currently listed without any label in the "TypoScript records overview". However, the "website title" is not a mandatory field. Fall back to the site identifier if there is not website title. The identifier is mandatory and unique. Resolves: #104731 Releases: main Change-Id: I7727fb966443fe55e525bdc6fa6b44a67ecbefc4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85777 Reviewed-by:
-
Christian Kuhn authored
There is ancient BE login related server side code to detect if cookies can be set. This never kicks in and is removed with the patch. When 'setting cookies' is disallowed in a browser (see instructions for firefox in issue), JS showCookieWarning() detects this and enables an info box. If JS is disabled as well, a default enabled info box "Please enable JavaScript" is shown. We're safe client side and can remove the server side check that triggers a fishy reload for detection. Resolves: #104742 Releases: main Change-Id: Id2585f77f097fd538766053d2b79cc40497737f6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85787 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
Benjamin Franzke authored
Executed commands: npm --prefix overrides/ckeditor5 version 43.0.0 npm install --save ./overrides/ckeditor5 $( grep @ckeditor/ package.json | \ grep -v @ckeditor/ckeditor5-dev-utils | \ grep -v @ckeditor/ckeditor5-inspector | \ sed 's/^[^"]*"\([^"]*\)".*/\1@43.0.0/' \ ) npm install --save-dev @ckeditor/ckeditor5-dev-utils@42.0.1 npm run build Releases: main, 12.4 Resolves: #104715 Change-Id: I6b954046451c53a49374459dbf18359fd9b346bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85745 Reviewed-by:Benni Mack <benni@typo3.org> Tested-by:
-
Lina Wolf authored
This patch adds a description on how to utilize site sets from `EXT:fluid_styled_content` and the supported configuration directives, autogenerated from the settings.definitions.yaml file. Resolves: #104596 Releases: main Change-Id: Ie4215c70f24d579be06d086f19deae4c277e633f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85590 Reviewed-by:
Chris Müller <typo3@brotkrueml.dev> Reviewed-by:
-
Benni Mack authored
What does it do? When creating a record object out of a database row (via the RecordFactory), the Record object now holds enriched values for fields where the content is "known" based on TCA / Schema API. This is especially relevant for records with possible relations, for field types such as "type=group", "type=select" with foreign_table set and "type=inline" as an example. The main purpose for this relation enriching is rendering of the backend page module and content in frontend, but it can be used for any kind of TCA-based record. It also works recursively and with circular dependencies thanks to the RecordIdentityMap. In order to avoid any problems with large amounts of data, an approach of "Lazy+Greedy Fetching" was chosen. How does this approach work under the hood? As an example, we load 10 content elements on a page (1 DB query) so we can render them. Step 1: Lazy Collections / RecordPropertyClosure RecordFactory filters out only the relevant fields and their values from a record's type. Now, the RecordFactory also checks for fields with their meaning and uses a different value for a field. Example: For a type=inline value, there was the number "5" as value (= 5 relations) available, now we know we need the relation records (as a collection) properly sorted resolved there as well. For this to work, the new RecordFieldTransformer creates LazyCollection objects or RecordPropertyClosure objects (for a 1:1/n:1 relation) which means that the DB query is not made (yet) but only called when the value is accessed for the first time ("lazy loading"). Step 2: Getting the related UID/Table Pairs The RecordIdentityMap now knows about the 10 Records from tt_content, as they have been created completely before handing it to the output rendering. There comes the fun part. As soon as the value (with a lazy closure) is accessed for the first time, the RelationResolver checks the RelationHandler to find the table / uids that we should resolve. In our case, we now know that our first content element has 5 relations to a DB table e.g. "tx_mycarousel_item" with UIDs 12,13,14,15,16. Thanks to the RelationHandler, we also have the proper sorting of these items. Step 3: A greedy database query to get the full DB rows So, for the first content element, we want the 5 complete, related DB rows. The RelationResolver now sends this query to the "GreedyDatabaseBackend" which uses a subquery to not only fetch the 5 DB rows, but ALL rows of this DB table that are on the same PID with 1 DB query (using subselects). It however only returns the 5 items, and keeps the other items in a runtime cache. At this point we have made 3 DB queries. Currently, we then do the language + workspace overlays. Step 4: The long way back The RelationResolver now has the full DB rows and sorts them. The RecordFieldTransformer builds Record / Collection objects out of it, checks if an object has been created already (via the IdentityMap) or creates new ones, utilizing again the Lazy approach from step 1 to ensure we only resolve the records when we need them. Responsibilities: - RecordFieldTransformer - knows what to do based on the Field Type - returns objects, never raw DB records - initializes the lazy collections / closure objects - RelationResolver - uses RelationHandler to resolve uids - knows and applies the sorting - GreedyDatabaseBackend - does overlays / enableFields The design decisions behind this approach: - We only build Record objects when they are requested explicitly - We distinguish the cardinality (1:1 / n:1 vs. 1:n) - We do overlays on a very end of the chain Kudos to Nikita Hovratov for creating the first draft of this approach here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83725 along with comprehensive tests. PS: In the mid-term, the RelationResolver could be based on the sys_refindex and minimize queries. Resolves: #103581 Related: #103783 Related: #104002 Releases: main Change-Id: I73d1f017c5f98115f7ad4ddd2634b7acf66d183c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85046 Tested-by:Oliver Bartsch <bo@cedev.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- Aug 26, 2024
-
-
Lina Wolf authored
This patch adds a description on how to utilize site sets from `EXT:felogin` and lists the supported configuration directives, autogenerated from the settings.definitions.yaml file. Also some wording changes and typo-fixes in the settings definitions file are applied, and fe-login special notices are added. Resolves: #104597 Releases: main Change-Id: I14ccef4c2ac5e6d93a39c8a2d41301dd1ab99a3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85594 Reviewed-by:
-
Philipp Kuhlmay authored
This sets the correct code-block caption definitions for the YAML and PHP code blocks so they will be rendered correctly. Resolves: #104716 Releases: main, 12.4, 11.5 Change-Id: Ic1ecc908c5e84f0c72180e4402296a78211263b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85749 Tested-by:
-
Simon Praetorius authored
Fixes typo in BackendUserController Resolves: #104739 Related: #104635 Releases: main Change-Id: Ia28ff567214fe0f50afd1d616e0c5fc047eaa9f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85784 Tested-by:
-
Lina Wolf authored
- Use unified header markers - Remove multiple empty lines - convert indentation to 4 spaces - drive-by fixes of "da" vs. "dk" (#102607) This is a preparation for working on the content of the manual. No text changes, no change in the rendered output Resolves: #104713 Releases: main, 12.4 Change-Id: Ied00566b877aa9af4e201c57296a78061e754064 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85743 Reviewed-by:
-
Lina Wolf authored
See also: https://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/349 Related: #99552 Resolves: #104720 Releases: main, 12.4 Change-Id: Idc427fa6fddca5cf2f6ce6703a74d0a0675261a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85774 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Reviewed-by:
-
Sébastien Delcroix authored
Since #96998, there's no more __construct() method more in extbase validators, thus they can't be instanciated with options anymore, they have to implement setOptions(). The form extension documentation contained a code example on how to build forms programmatically which has been updated to respect this by using createValidator() instead of addValidator() when setting options. Resolves: #104733 Related: #96998 Releases: main, 12.4 Change-Id: I50387ead78f650a975363ad57a93fdcf84efd2fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85779 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
- Aug 25, 2024
-
-
Christian Kuhn authored
Fluid variable {hookObjectModuleContent} is never assigned. This is dead template code. Remove along with a label. It looks as if this is dead since main admin panel rewrite in v9. Resolves: #104722 Related: #84584 Releases: main Change-Id: I0f0416367ccaabc733daf3b00bde71111f230c60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85751 Tested-by:
-
- Aug 24, 2024
-
-
Jasmina Ließmann authored
Resolves: #104666 Releases: main Change-Id: I4bcd8cfd82c9aa4837c2eb9e683d9626180077da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85682 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
- Aug 23, 2024
-
-
Andreas Kienast authored
TYPO3 still uses the infamous position maps (lists with arrow icons) to allow an user to re-arrange content elements. The position maps are used in two places: * "New Page Content" wizard in record list * "Re-position content element" in record list This commit aims to improve the styling of position maps and streamline them with the page module, without the need of major refactorings. Theoretically, TYPO3 has API to render a "page module"-alike grid anywhere, but it is currently coupled too tight to page module behavior and its needs. Resolves: #104618 Releases: main Change-Id: I6aa25e60e8ae95a88f6e73a86a910442bda722f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85624 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Ayke Halder <mail@ayke-halder.de> Tested-by:
-
Benni Mack authored
With #104309 in place, TYPO3 is finally prepared to allow any date configuration, as long it is supported in PHP. This commit adjusts the last missing bits: the date format configured in `TYPO3_CONF_VARS/SYS/ddmmyy` is now respected at every place that configures a date time format for the JavaScript date picker component. To achieve this, an internal method is introduced that converts the PHP date format to a fomat that luxon understands, which appears to be "inspired" by ICU date format tokens. Resolves: #104192 Related: #103496 Related: #104309 Releases: main, 12.4 Change-Id: Ie5a103dc2bf455ec29616f6ae4b0a06063cc6937 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84880 Reviewed-by:
-
Andreas Kienast authored
This commit updates `luxon` to version 3.5.0, along with the related development package `@types/luxon`. Executed commands: npm install --save-dev @types/luxon@^3.4.2 npm install --save luxon@^3.5.0 npm run build Resolves: #104701 Releases: main, 12.4 Change-Id: Ia11a6d017fae9a91541923cc62198c9b20312dd2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85729 Reviewed-by: -
Andreas Kienast authored
The Install Tool sections "Remove Temporary Assets" and "Clear Persistent Database Tables" have been re-structured a bit to have a cleaner look. Resolves: #104704 Releases: main Change-Id: I12b85b072e8b0675acbe624d1a036d12f0d061bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85709 Tested-by:
-
Garvin Hicking authored
With #101128 a few more RTE plugins for CKEditor have been added, now supporting the "mark" HTML tag. This tag is now also allowed in the default parseFunc_RTE definitions for EXT:fluid_styled_content and the RteHtmlParser default. Also the missing "s" tag was treated similarly. Please note that custom sitepackages or themes like the Bootstrap package may need adoption like the following, if `denyTags` might otherwise remove the definition: lib.parseFunc_RTE { allowTags := addToList(mark,s) } The HTML frontend styling of the `<mark>` classes needs to be done by integrators, no CSS definitions are provided by default. Resolves: #104617 Related: #101128 Releases: main, 12.4 Change-Id: I9118274e9908dcb3fef44ec271973dde46a6d01c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85639 Tested-by: -
Christian Kuhn authored
There is little reason to use ext:fluid TemplateView instead of fluid standalone TemplateView in functional tests. ext:fluid TemplateView is about to be phased out. The test switches existing test usages to use fluid standalone TemplateView. Resolves: #104711 Related: #104708 Related: #104710 Releases: main Change-Id: Ie50c908b4b69cbd691cd7957fc0793d1ddaa9050 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85741 Reviewed-by:
-
Christian Kuhn authored
`EscapeChildrenRenderingTest` and `EscapeChildrenRenderingStandaloneTest` are identical, except that the 'standalone' variant does not actively use StandaloneView, but fluid standalone TemplateView, and the other one use ext:fluid TemplateView, which is identical in this use case. Combine the tests and let it work on fluid standalone TemplateView only. Resolves: #104710 Releases: main Change-Id: I71e9f8438dc016a55e1cb99c268b69c5bcebc791 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85740 Tested-by:
-
Simon Praetorius authored
FluidViewAdapter->setRenderingContext() sets itself as view for inner renderings. This was thought to be a good solution to trigger deprecations for methods of different view implementions (StandaloneView & friends). However, custom fluid views are being phased out, which will then trigger their own deprecations. We can thus remove this quirk. Also, renderPartial() and renderSection() may return mixed. This was wrong in fluid standalone as well, and is fixed in there, too. Resolves: #104709 Related: #101559 Releases: main Change-Id: I381e6a26ce8b6757fc59068742cf6a09d64f8f71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85738 Tested-by:
-
- Aug 22, 2024
-
-
Christian Kuhn authored
We're starting with patches to phase out ext:fluid StandaloneView to introduce a general core view factory. A straight preparation is to reduce StandaloneView usages in functional fluid view helper tests with the native fluid standalone TemplateView as is used in most other functional view helper tests already. Resolves: #104708 Releases: main Change-Id: I6361f901af5372ee76cf948c3725a297aadc261b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85739 Tested-by:
-
Ayke Halder authored
The FileClipboardCest waits for a button to become 'enabled' before clicking it. Disabled buttons use `class="disabled"` with CSS `pointer-events: none`. This might not be handled properly by `$I->waitForElementClickable()`. Resolves: #104702 Related: #104585 Releases: main, 12.4, 11.5 Change-Id: If0677eb445207612f43b624c2889d7ef6651ae71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85732 Tested-by:
-
Andreas Kienast authored
This commit updates `lit` to version 3.2, along with some friend libraries. Executed commands: npm install --save \ @lit/task@^1.0.1 \ lit@^3.2.0 \ lit-element@^4.1.0 \ lit-html@^3.2.0 npm run build Resolves: #104700 Releases: main, 12.4 Change-Id: Ic0e37dc306955be8f4b495838c30c1440fe207fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85728 Tested-by: -
Benjamin Kott authored
Resolves: #104698 Releases: main Change-Id: I62cf1f89cd980cb453b990435223a45a90b1e0df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85726 Reviewed-by:
-
Benjamin Kott authored
Resolves: #104523 Releases: main Change-Id: Ia331af805a4837f227289319b44f4f911463299a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85724 Tested-by:
-
Benjamin Kott authored
Resolves: #104696 Releases: main Change-Id: If3de4c3aa0bed97ad7cb5886ca9b464cb077f720 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85723 Tested-by:
-
Andreas Kienast authored
Previously, the content of the table header in the backend user/group comparison view was misaligned, the title was moved below the action buttons. This commit changes the alignment to have the title and the action buttons next to each other. Additionally, the items are vertically centered. Resolves: #104691 Related: #104635 Releases: main Change-Id: I577ee142ab6efade51810b3f72d1b2ae8d346a97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85720 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Benjamin Kott authored
We are dropping the Bootstrap CSS definitions for all table to have more control about the styling of the table elements. From now on we are shipping custom css adapted to our needs. The new table element styling is context aware and adapts to light and dark color schemes. Resolves: #104688 Releases: main Change-Id: I9e74a98d575460c00fd55045f990e32a134658d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85717 Tested-by:
-
Christian Kuhn authored
fix() is annotated to return an array of FlashMessages, the test setup returns an array of strings instead. Adapt the tests. Resolves: #104689 Releases: main Change-Id: I352d111e76e782ca4a6f05a6025d054343f11c8c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85718 Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Andreas Kienast authored
The Install Tool templates now incorporate `<template>` tags that replace the previously used hidden `<div>` elements that served the same purpose: have re-usable templates. Using `<template>` allows us to remove some more quirks in the code, e.g. removing the template identifier classes (which wasn't done everywhere) and the requirement for valid markup within the templates, as `<template>.content` resolves to a `DocumentFragment` in JavaScript. Resolves: #104678 Releases: main Change-Id: Id35bc52c7a317402b1ad52a7ed64675b50e748a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85707 Tested-by:
-
Andreas Kienast authored
In early development, the max value of a progress bar was limited to being `100`, which changed later on. This was not respected when clamping the actual value, the value was limited to being `100`. This commit fixes the issue by taking the actual `max` value into account. Resolves: #104685 Releases: main Change-Id: I20ebeb217990ed59eada397d312ceb1d937a3296 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85713 Reviewed-by:
-
- Aug 21, 2024
-
-
Karsten Nowak authored
Fix not cklickable `+` sign for the nested properties in debugger tree in frontend. The css selector for input fields of type checkbox are not strong enough if the website css defines own css rules and select checkboxes with input[type="checkbox"] the selector in DebuggerUtility loses and properties are overriden. Height, width, z-index and other properties were used to hide the default appearance of checkboxes and make those form elements looking nice. Therefore, DebuggerUtilitys selector should be a bit more stronger. Resolves: #104681 Releases: main, 12.4 Change-Id: Id6964e0dbf19b83318f1e5de5f3763c6be6652a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85710 Tested-by:
-
Oliver Bartsch authored
Renaming resources via the ResourceController, called via AJAX, does now also properly log the performed action to be consistent with the use of the ExtendedFileUtiltiy. Resolves: #104569 Releases: main, 12.4 Change-Id: Icc2a5effcfa06269c2ad2f96cfa844206232ac60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85696 Tested-by:
-
Christian Kuhn authored
ext:fluid RenderingContext is in the bad habit of extending fluid standalone RenderingContext with the two methods setRequest() and getRequest() that are not part of fluid standalone RenderingContextInterface. This is ugly with type hinting and can't be changed in a good way due to liskov collisions on method signatures in view helpers. Fluid standalone also does not want to add these methods itself since it - as a view - wants to avoid dependencies to PSR-7. Fluid standalone instead added setAttribute(), hasAttribute() and getAttribute() to RenderingContextInterface. This allows adding "arbitrary" objects. The patch makes use of this: On the setter side, the RenderingContextFactory->create() is extended to accept the request and set it as attribute, on the has/getter side all consumers are adapted. This deprecates setRequest() and getRequest(), which are changed to transparently work with the attribute instead. Resolves: #104684 Releases: main Change-Id: Id096073765c00e06e0437539f963f59a69e3fba0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85708 Tested-by:
-
Christian Kuhn authored
Various ext:extbase functional tests set $GLOBALS['TYPO3_REQUEST']. The extbase codebase still has various places that access the global. We can still reduce some usages in tests which are obsolete meanwhile, or can be improved by setting the request on ConfigurationManager instead, which is one of the main callers to the $GLOBALS['TYPO3_REQUEST'] fallback in tests. Resolves: #104677 Related: #104675 Releases: main Change-Id: I8672cad869e64545c482664e5d995bc1ef02bd64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85706 Tested-by:
-
Benjamin Kott authored
We are dropping the Bootstrap CSS definitions for all form stylings to have more control about the styling of the form elements. From now on we are shipping custom css adapted to our needs. The new form element styling is context aware and adapts to light and dark color schemes. Resolves: #104676 Releases: main Change-Id: I0da5017c961e9712c027f09a34f4cf91a7b11a45 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83047 Tested-by:
-
