- Oct 19, 2017
-
-
Andreas Fernandez authored
If a user who appears in the "Recently switched to" list became unavailable for some reason, only the placeholder avatar was rendered, giving a slight hint of life in the past. Such users are now deleted from UC and do not appear in the list anymore. Furthermore, the section label was slightly modified to be more understandable. For performance reasons, only one query is triggered now and sorting is done based on the array of UIDs stored in UC. Resolves: #82796 Related: #80581 Releases: master Change-Id: Ieff8a779639f277de1c0cb7feaa0fe2b82bd97c5 Reviewed-on: https://review.typo3.org/54433 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Benni Mack authored
The global option "content_doktypes" is 1. outdated (still contains doktypes 2 which was removed in 4.x) 2. only in use for Workspace Preview Links and Frontend Editing to query page trees However, the idea was to disallow content editing (QuickEdit) and skip search of other doktypes for simple DB search (removed in TYPO3 v7) This is not the case anymore and nowadays a hidden feature which is only 10% implemented, and just another tedious option bloating the system. The option has been removed and also cleaned via SilentConfigurationUpgradeService. Resolves: #82803 Releases: master Change-Id: I4ca868f721142d2ac9f1de0c1a7bccc33086989b Reviewed-on: https://review.typo3.org/54438 Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Benni Mack authored
The AjaxLoginHandler which does AJAX logic for login timeouts is be moved to the proper location, as it is a controller. A class alias is in place. Resolves: #82805 Releases: master Change-Id: I6a9fed6236d6d82150dec2ac7c2ce61bd194b8ec Reviewed-on: https://review.typo3.org/54441 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
- Oct 18, 2017
-
-
Andreas Fernandez authored
Currently, `beforeRender` removes some inline CSS so adjust the layout of the suggest list. If the first search has no result, the layout is broken because `beforeRender` is not called in case there are no results. This patch removes the style attribute as early as possible. Resolves: #82757 Releases: master, 8.7 Change-Id: I844b81aca43bd469dfdbb46516366f4786d0935f Reviewed-on: https://review.typo3.org/54439 Reviewed-by:
-
Christoph Lehmann authored
Fixes the TypeError htmlspecialchars() expects parameter 1 to be string, null given Resolves: #82787 Releases: master,8.7 Change-Id: I38a689022ed45c34a8ae78c046abe51803eb0f4c Reviewed-on: https://review.typo3.org/54415 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Henrik Elsner <helsner@dfau.de> Tested-by:
-
Susanne Moog authored
Unsetting TCEMAIN.translateToMessage was not possible due to a default fallback to a hardcoded string in data handler. This patch sets the default via PageTSConfig and simplifies the condition / fallback logic. Change-Id: Ie06410126a83de0e158c43cbfd6ee3d45176c363 Resolves: #82523 Releases: master Reviewed-on: https://review.typo3.org/54429 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Daniel Goerz authored
Resolves: #81786 Releases: master, 8.7 Change-Id: I1bc5e93fdfb3a1068a09ae37c47e51b1811d58b5 Reviewed-on: https://review.typo3.org/53396 Tested-by:
Sascha Rademacher <s.rademacher@neusta.de> Reviewed-by:
-
Susanne Moog authored
If in a record with an inline relation a new relation is added and nothing else is changed the timestamp was not updated. The logic to update the timestamp has now been added to the remapStack processing. Change-Id: I2eae7d1fb54b21dddc6e3609b1585ba484980b06 Resolves: #82576 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54423 Reviewed-by:
-
Oliver Hader authored
The Localization State object has an incomplete assignment in the constructor - sanitize processing is overridden by enrich processing, however both should be combined instead. The current side-effects were, that * localization state could contain fields that were not defined in TCA having support for the `allowLanguageSynchronization` setting * state values different than `custom`, `source` or `parent` have not been overridden by the default `parent` value Resolves: #82793 Releases: 8.7, master Change-Id: I25e794736df216b17a5b8de3bc5203bd18ee9694 Reviewed-on: https://review.typo3.org/54422 Tested-by:
-
- Oct 17, 2017
-
-
Ralf Zimmermann authored
Set the "label" property for the root form element TYPO3\CMS\Form\Domain\Model\FormDefinition Resolves: #82573 Releases: master,8.7 Change-Id: I57c45765e4af91da6094f8f7a469a1df2f6da1f5 Reviewed-on: https://review.typo3.org/54227 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
Sonja Großewinkelmann <s.grossewinkelmann@neusta.de> Reviewed-by:
-
Benni Mack authored
The runtime caches used in the ReferenceIndex class added in TYPO3 8.7.2 should not be added by default but included on a per-runtime basis when extensions would use the ReferenceIndex. Otherwise this issue might lead to side-effects. For master/9.0 the caches are enabled by default. Relates: #78634 Resolves: #81771 Releases: master, 8.7 Change-Id: If7ca173d93c05658bce5f57c38842555a439d2ea Reviewed-on: https://review.typo3.org/53384 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Susanne Moog authored
Pre tags are currently not passed through parseFunc resulting in non-parsed t3:// links in the frontend. As <pre> tags allow links (and other tags) inside, we should parse them, too. Change-Id: I5647f02b0d93b05ecaed8297c794b91255ea6d54 Resolves: #82789 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54419 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Nikita Hovratov authored
The variable iconElement refers now correctly to the original jQuery object and is really reverted to the old class as the comment implies. Resolves: #82624 Releases: master, 8.7 Change-Id: I13615bbee6d5148fe940bac49b72c2766c0a1de7 Reviewed-on: https://review.typo3.org/53258 Tested-by:
-
Alexander Schnitzler authored
Extbase came along with two main caches for reflection data. extbase_reflection and extbase_object. The latter mostly stored information that were relevant to the dependency injection, like inject methods and properties and constructor parameters. The information was gathered by actual reflection and by analysing doc blocks of properties and methods. extbase_reflection stored similar reflection and doc block data about objects but mainly for the parts outside dependency injection. For example, the validation resolver used it to identify @validate tags, the ActionController used it to identity which properties not to validate. The ORM also used it a lot to find annotated types via @var and so on. There were a few issues with these two approaches: - A lot of redundant data was fetched - Data was fetched multiple times at different locations - The extbase_reflection cache was stored each plugin seperately, resulting in a lot of redundant cache data for each plugin cache - At a lot of places, the reflection service was used to reflect objects, but the data wasn't cached or taken from a cache resulting in performance drawbacks This patch solves these issues with several approaches: - The extbase_object cache has been removed completely and all necessary information about objects, mainly @inject stuff, is now fetched from the ReflectionService as well. - The ReflectionService does still create ClassSchema instances but these were improved a lot. All necessary information is now gathered during the instantiation of ClassSchema instances. That means that all necessary data is fetched once and then it can be used everywhere making any further reflection superfluous. - As runtime reflection has been removed completey, along with it several reflection classes, that analyzed doc blocks, have been removed as well. These are no longer necessary. - The extbase_reflection cache is no longer plugin based and will no longer be stored in the database in the first place. Serialized ClassSchema instances will stored in typo3temp. Releases: master Resolves: #57594 Resolves: #55654 Change-Id: I93b905c85c4f28775f014ca8b585347bf6f1e7d3 Reviewed-on: https://review.typo3.org/54381 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benni Mack authored
TYPO3 Core does not use isAdmin() API of BackendUsers consistently, as there are some places where a direct access to $BE_USER->[admin]. Resolves: #82783 Releases: master Change-Id: I5ae42a79826a3512be8755aabb32b910f4f6c826 Reviewed-on: https://review.typo3.org/54414 Reviewed-by:
-
Tymoteusz Motylewski authored
Move calls to addInlineSettings out of the foreach loop, and place them together with other similar calls. Resolves: #82781 Releases: master Change-Id: Ia2269833f7649559a1552a9290773984bebcc102 Reviewed-on: https://review.typo3.org/54413 Reviewed-by:
-
- Oct 16, 2017
-
-
Benni Mack authored
TSFE does the same logic as $GLOBALS['LANG'] (= LanguageService) for fetching labels and language files, but with a different language key. However, LanguageService is not a singleton, so it _can_ be used multiple times at the same request, so why not use the LanguageService for labels based on config.sys_language, and the $GLOBALS['LANG'] record based on the current backend user. So, TSFE only acts as a wrapper for LanguageService instead of having duplicate code. A few now useless internal properties are dropped, some other methods are deprecated: - TSFE->LL_files_cache - TSFE->LL_labels_cache - TSFE->readLLfile() - TSFE->getLLL() - TSFE->initLLvars() Resolves: #81217 Releases: master Change-Id: Iae85ac2eda4d7f77960de2d66b9069f6017c31d8 Reviewed-on: https://review.typo3.org/52799 Tested-by:
-
Benni Mack authored
This patch straightens several areas to use proper API calls, and separates bigger methods into smaller methods. Resolves: #82778 Releases: master Change-Id: Ibfa80589a026966f4cbd0f2e6e7e4062033b3ab8 Reviewed-on: https://review.typo3.org/54408 Tested-by:
-
Tymoteusz Motylewski authored
Adds some JS doc and renames few properties to make code more readable. Resolves: #82775 Releases: master Change-Id: I8cb66ee1d52be00ea6e556d369607aecc7e4e2fb Reviewed-on: https://review.typo3.org/54406 Tested-by:
Sebastian Fischer <typo3@evoweb.de> Reviewed-by:
-
Riccardo De Contardi authored
Adds to page with doktype=199 (spacer) the tab "Appereance" with palette "backend layout" and the tab "Resources" with palette "TSConfig". Resolves: #77892 Releases: master Change-Id: I3c5a47fcc551858bc889a7fe127d241b0f961faf Reviewed-on: https://review.typo3.org/53810 Reviewed-by:
-
Benni Mack authored
ConditionMatcher has a log method which is never used. Resolves: #82770 Releases: master Change-Id: I8554f253260601a8511dacdbca3ddfc894be80bd Reviewed-on: https://review.typo3.org/54402 Tested-by:
-
Benni Mack authored
Properties which are only accessed inside of GraphicalFunctions and should remain inside are marked as protected, are migrated to arrays (to avoid inList calls instead of in_array()), removed or renamed to remove classic kasper's-style double negation namings. Resolves: #82768 Releases: master Change-Id: If45a9198c3a2979a6fe0a1619a9841bd37a2708e Reviewed-on: https://review.typo3.org/54318 Tested-by:
-
Gianluigi Martino authored
This patch enable the "Today" button on the bottom of the DateTimePicker. Clicking the "Today" button will set the date and time to now. Resolves: #82723 Releases: master, 8.7 Change-Id: I262e0206754b2a9e785a6f1184712ba8cc26ad12 Reviewed-on: https://review.typo3.org/54396 Reviewed-by:
Henning Liebe <h.liebe@neusta.de> Tested-by:
-
Benni Mack authored
The goal is to minimize TYPO3_MODE usage in ext_localconf and ext_tables and provide a clear process for extension developers where to put what. This extension streamlines the whole usage within all system extensions, and documents the expected behaviour of all third-party extensions, which will also be included in docs.typo3.org. Resolves: #82692 Releases: master Change-Id: Id83ff0dfc6198564443f2f42e273bcd4f6f25e3e Reviewed-on: https://review.typo3.org/52533 Reviewed-by:
-
Benni Mack authored
The following changes were made: 1. enableLogging is now only checked within the log methods (if no extra CPU / DB requests were made in the if statements). 2. Introduce a getter for $GLOBALS['LANG'] instead of using the hard-coded object (and using IF statements, although the comment on top of the PHP class states that LanguageService MUST be initialized). 3. Simplify switch-cases / nested-if statement to a regular IF condition 4. Use Logger API instead of plain debug() calls Resolves: #82769 Releases: master Change-Id: Icd74057ac64ec8fc219c55b7996f766020fd5ad8 Reviewed-on: https://review.typo3.org/54401 Tested-by:
-
Andreas Fernandez authored
The RequireJS module `TYPO3/CMS/Backend/Utility` is migrated to TypeScript. This patch marks the global object `TYPO3.Utility` as deprecated. Any occurrence is migrated to properly use the module instead. Resolves: #82609 Releases: master Change-Id: Ic0deaa29074080edd71928891fd09c3fb2af63fd Reviewed-on: https://review.typo3.org/54251 Tested-by:
-
Georg Ringer authored
Add the user who deleted a record to the recycler information and also show the avatar of the user. Resolves: #69340 Releases: master Change-Id: Id7d86d737b2759c6746baefa4b60659b6e9527eb Reviewed-on: https://review.typo3.org/54379 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
- Oct 15, 2017
-
-
Georg Ringer authored
When using FLUIDTEMPLATE with Typoscript "template.file = filename", it will fail silently if filename does not point to a file. Also check for template source when using Typoscript "file = filename" in FLUIDTEMPLATE object. Resolves: #65340 Releases: master Change-Id: Id6aa148408cad14e49b65c0a9f4c7887cfb3fa16 Reviewed-on: https://review.typo3.org/37273 Tested-by:
-
- Oct 13, 2017
-
-
Nicole Cordes authored
This patch adds missing functional tests for \TYPO3\CMS\Backend\Controller\FormInlineAjaxController::createAction Related: #82330 Releases: master, 8.7, 7.6 Change-Id: I61c8c07dd0d2c6a92bb445d7f2b6baee23251f5d Reviewed-on: https://review.typo3.org/54171 Tested-by:
-
Gianluigi Martino authored
If the foldertree in filelist is to long, the rightclick context menu on the bottom of the window is not completly visible. With this patch the position of the menu is calculated based on the windows width and height and so completly visible. Resolves: #82732 Releases: master, 8.7 Change-Id: Ied9204371491059efda61143e9ca9c2f3c8a9b9d Reviewed-on: https://review.typo3.org/54390 Tested-by:
Wittkiel Gruppe <ts@wittkiel-gruppe.com> Tested-by:
-
Frank Naegler authored
Resolves: #82751 Releases: master Change-Id: Ie87cccc2d890ffaf93fe8558f2a67da82ee8c495 Reviewed-on: https://review.typo3.org/54383 Reviewed-by:
-
Loek Hilgersom authored
Resolves: #82749 Releases: master, 8.7 Change-Id: I1de1157ca8e28da3a9fd3ffb3783bb73b1f8e845 Reviewed-on: https://review.typo3.org/54382 Tested-by:
Gianluigi Martino <gmartino27@gmail.com> Tested-by:
-
Christian Kuhn authored
Modernize the code base of the lowlevel ConfigurationController: * No more _GP usages * Get rid of MOD_SETTINGS and friends * Don't use BackendUtility::funcModule and other crude helpers * Get and apply changes to be_user->uc directly * Move last html pieces to view Change-Id: I24af6c53b9c55c82e0e1fc1ee79de97768fd9b2c Resolves: #82754 Releases: master Reviewed-on: https://review.typo3.org/54389 Tested-by:
-
Frank Naegler authored
Resolves: #82604 Releases: master Change-Id: I9b9ff38c635902f2713602955ad9a3d04734ec88 Reviewed-on: https://review.typo3.org/54367 Tested-by:
-
- Oct 12, 2017
-
-
Georg Ringer authored
To avoid exceptions with complex structures, the strict flag must be used in the in_array check. Resolves: #82736 Releases: master, 8.7, 7.6 Change-Id: I3ecf859e3e3cc70ab40b10ef9052d46e8b486957 Reviewed-on: https://review.typo3.org/54372 Reviewed-by:
-
Christian Kuhn authored
Setting / unsetting the checkbox "Use regular expression" fails with JavaScript error "jumpToUrl is not defined". Add that to the document body. Change-Id: I0a5928e008972493d070a35d1219a0acca579ce8 Resolves: #82746 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/54377 Reviewed-by:
-
Christian Kuhn authored
The two "view" classes are clearly controllers and are renamed with this patch accordingly. Change-Id: Ic1cdc405ae24b87aa6224cda79b7226ce5eeec64 Resolves: #82744 Releases: master Reviewed-on: https://review.typo3.org/54375 Tested-by:
-
Christian Kuhn authored
To further phase out BaseScriptTask "SOBE", the scheduler controller class no longer extends it and copies left over usages to itself. A general cleanup is applied along with this patch: * Hard code some general variables like "moduleName" * Remove some duplicate class attributes * Additional namespace usages Change-Id: I937b66e0b59d65591547144763026dbbd2d6c5f0 Resolves: #82727 Releases: master Reviewed-on: https://review.typo3.org/54364 Tested-by:
-
Christian Kuhn authored
To reduce BaseScriptClass "SOBE" usages, the lowlevel controller "ConfigurationView" no longer extends this class and inlines some of the detail methods into routing target "mainAction". Change-Id: Icc284f5a3b4f0f9d50482a9f8865b0d7d1c16f4f Resolves: #82728 Releases: master Reviewed-on: https://review.typo3.org/54365 Reviewed-by:
-
Christian Kuhn authored
To reduce BaseScriptClass "SOBE" usages, the lowlevel controller "DatabaseIntegrityView" no longer extends this class and inlines some of the detail methods into routing target "mainAction". Change-Id: I67b0bae5848607166d19988cb005c91301754413 Resolves: #82729 Releases: master Reviewed-on: https://review.typo3.org/54366 Tested-by:
-
