In the Developer Logs there are complaints about the missing destructor.
Fix: add it.

Change-Id: I42595a7ebbc3c941bf64bc0699ff908059c107bb
Resolves: #25278
Reviewed-on: http://review.typo3.org/1092
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

class.t3lib_tstemplate.php uses if (is_object($GLOBALS['TSFE'])) to check
for the frontend environment, this should be if (TYPO3_MODE == 'FE')

This patch already has a +1 on the core list. Made this changeset to get
it into gerrit.

Change-Id: I57fbbc9258b6db4af20a983791b38087f71ed31d
Resolves: #M17725
Reviewed-on: http://review.typo3.org/1174
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

logoutHeader_stdWrap and logoutMessage_stdWrap do exist, but are not
used.

Change-Id: I8f12b10ec8f4fd0165904a38d7be913b97242a8d
Resolves: #26758
Reviewed-on: http://review.typo3.org/2547
Reviewed-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

When creating a menu with showAccessRestrictedPages set to any PID, links to pages
that inherit an access restriction ("include subpages" set on a parent page)
won't be substituted.

Change-Id: I98ea123ccdf1e370f28103546191b0a7234076f4
Resolves: #15984
Reviewed-on: http://review.typo3.org/1186
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Christian Mueller
Reviewed-by: Georg Ringer
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

There's a bug in the PHP time zone implementation - set in
t3lib/config_default.php and overridden in localconf.php.

The timeZone variable used to set the default timezone takes the value
from TYPO3_CONF_VARS[phpTimeZone], which does not exist. It needs to be
corrected to TYPO3_CONF_VARS[SYS][phpTimeZone].

The effect is that the time zone for TYPO3 is always set to the server
time zone and is not set by the localconf.php / Install Tool value of
phpTimeZone.

This looks like it may have been an issue since phpTimeZone was added.

Thanks to Todd Hossack for the patch

Resolves: #26779
Releases: 4.6, 4.5
Change-Id: I599e06c63747a089aefebc4d5745452383dfd8af
Reviewed-on: http://review.typo3.org/2301
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

This patch fixes the handling of relative paths of pageNotFound_handling.
Due to a missing check, the relative path is prefixed with http_host only,
causing a wrong Location header.

Change-Id: I664250d34b05a26bdaf1e2a839027b80c1e4f607
Resolves: #25725
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/1712
Reviewed-by: Kurt Kunig
Tested-by: Kurt Kunig
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

Add another stdWrap case option "capitalize"

Change-Id: I05e4c8850a80b302a9789415e4fe15a3127692b4
Resolves: #17896
Reviewed-on: http://review.typo3.org/2381
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Stefan Neufeind
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Andy Grunwald
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

Due to a JavaScript error the corresponding radio button in Step 2 of
the 1-2-3 wizard is not automatically checked, when the dropdown menu
to select an existing database changes.

Change-Id: Idc7c65a268bd7dd67004a88a4c49457f11c022de
Resolves: #11765
Reviewed-on: http://review.typo3.org/2505
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

Flexform sheet description, short description and language meta settings are now editable via TSConfig.

Change-Id: Ib60c96eb74494444aff14a80d677e52895102f84
Resolves: #26771
Reviewed-on: http://review.typo3.org/2086
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

* Some spaces where missing
* The session handling had been buried inside the
update classes.

Change-Id: I73fe6f24bc6dae1fb926259acae07984f92cb9c2
Resolves: #27235
Releases: 4.6
Reviewed-on: http://review.typo3.org/2537
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

The language selector in the top of BE forms is intended to show (and
switch between) all translations of a certain record. All records in
non-default languages, that are not bound to a record in the default
language are shown as translations of each other.
The patch adds a distinction between translated records and records in
a non-default language to render the dropdowns labels and functions.
Additionally fixes PHPDoc and indentation of SC_alt_doc::languageSwitch().

Change-Id: Iec7ee3dffbeab2e1fce45cd96c17ceffcc75f7aa
Resolves: #24958
Reviewed-on: http://review.typo3.org/1141
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

Android system is not properly detected by
t3lib_utility_Client::getBrowserInfo() because it currently detects
Android devices as variants of a Linux system. However some browsers
don't send "Linux" in the User-Agent, so Android does not get detected
at all. This patch moves Android detection outside of the Linux
detection block. It also comes before Linux detection, so that
Android devices don't get rolled up into Linux computers.

Change-Id: I0d870a0b8e7a00bce0dbbf964338f1e83ca821cc
Resolves: #26734
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2000
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Fedir RYKHTIK
Tested-by: Fedir RYKHTIK
Reviewed-by: Georg Ringer
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Cleanup the NEWS.txt for TYPO3 4.6 and add accordant information.

Change-Id: I2f4bd78feaf2e29e064562f7a9181a081ae9e39c
Reviewed-on: http://review.typo3.org/2071
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

If a content element has a starttime/endtime or a tt_news item has such
dates, they are not taken into account when cached.

This change adds an automatism for tt_content records. Records in other
tables can be defined as tablename:pid in TypoScript, to be taken into
account while calculating the page's cache lifetime.

Change-Id: I75479d193772905093f53fcd24299df849478fba
Resolves: #20473
Releases: 4.6
Reviewed-on: http://review.typo3.org/2393
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

Replaced "Create" with "Created". Date refers to when the record was "created".

Change-Id: I68d991af19acbb87a132cb2706841e4f4cbb6a51
Resolves: #5539
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/2522
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

An extension that provides static data shows up in the extension manager
with a list of checkboxes for each table to import.
The table names are not clickable, one has to target the tiny checkbox.

This fix adds the missing <label> tags around the table names.

Thanks to Christian Weiske for providing this patch.

Change-Id: Icba748674a854cb3bda032cdfc797c4ad5584639
Resolves: #26926
Releases: 4.6
Reviewed-on: http://review.typo3.org/2322
Reviewed-by: Christian Weiske
Tested-by: Christian Weiske
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

This is to make the media field of the pages_language_overlay
table behave the same as the media field in the pages table (TCA for both
are identical)

Change-Id: I05298e8429384da7af6ffdef78587198532030f0
Resolves: #26142
Reviewed-on: http://review.typo3.org/2513
Reviewed-by: Björn Pedersen
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Change-Id: I317234a5d90d41785f9f9338459fc39a64e85663
Resolves: #26360
Reviewed-on: http://review.typo3.org/2512
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Change-Id: Ie76570ebce5ea227a947132180e8555c79fbcc48
Resolves: #27173
Reviewed-on: http://review.typo3.org/2494
Reviewed-by: Mario Rimann
Tested-by: Mario Rimann
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

In case of parse errors in an ext_emconf.php file, the error message
has been suppressed because of an @include(). Nevertheless, the EM
stops working with a blank page (without any error log entry).

Removing the @ shows the warning so that it easier for the user to
identify the erroneous extension.

Change-Id: I971da980ace41d91dc99f466f1eb137bb0a46add
Resolves: #17506
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/2503
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Steffen Kamper
Tested-by: Steffen Kamper
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

This fix changes the used compare function for
t3lib_div::naturalKeySortRecursive() from strcasecmp to strnatcasecmp.
This ensures >natural< sorting especially in conjunction with
numbers in strings.

Change-Id: Ia9cd9a36da2bc0b6111a025e73b5bf8d26319c08
Resolves: #26485
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1787
Reviewed-by: Markus Klein
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

Show correct record title in backend module using t3lib_BEfunc::getRecordTitle()
in template.php and beuser module.

Change-Id: I07bb88509f37a3218d89149a71705054ed75985d
Resolves: #27100
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2409
Reviewed-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Andy Grunwald
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

When creating multiple new pages through the functions => wizard, and you'll create the pages you always get a JS question if you really want to do this. This is poor usability and stops the workflow because by that time, everyone should know what he's/she's doing. Additionally, this behaviour is very-"Windows"-like and is not really done in the same way on many other spots of the CMS.

Change-Id: I3990af110785f06b431ad1bdb8d93147397fbf4a
Resolves: #27104
Reviewed-on: http://review.typo3.org/2415
Reviewed-by: Patrick Rodacker
Tested-by: Patrick Rodacker
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Reviewed-by: Björn Pedersen
Reviewed-by: Andy Grunwald
Tested-by: Andy Grunwald
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Layout configuration of FORM fields with type LABEL is taken from type
CHECK when no stdWrap options are defined.
Thanks to Alexander Claes for this fix.

Change-Id: I260afc718acaa027a8b2c2636d6c366459e55691
Resolves: #26867
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2191
Reviewed-by: Christopher 
Tested-by: Christopher 
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Change-Id: I0de40afe0c1253bef8194ce99675a6cd3895e5de
Resolves: #26914
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/2299
Reviewed-by: Oliver Klee
Reviewed-by: Björn Pedersen
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Andy Grunwald
Tested-by: Andy Grunwald
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

After moving from PHP4 to PHP5 constructors fatal PHP error occurs because core still calling PHP4 constructors.

Change-Id: I5633413553431d85955282b2e1b9ef869aa8b7c2
Resolves: #27001
Related: #26505
Releases: 4.6
Reviewed-on: http://review.typo3.org/2331
Reviewed-by: Oliver Klee
Reviewed-by: Patrick Rodacker
Tested-by: Patrick Rodacker
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Change-Id: I6472d853b71aff2bde27ce054fec275f7c68fa95
Resolves: #27152
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/2488
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

The 'Status Legend' in the Scheduler backend module does not use
<img title="" /> tags. Only <img alt=""> tags.
This patch writes the value from alt=""-Tag to title="" tag.

Thanks to Qitec for the original patch.

Change-Id: I401e3a129d8ef1dd7ea8c9d1130d1ed5ed1f6339
Resolves: #25661
Releases: 4.6
Reviewed-on: http://review.typo3.org/2446
Reviewed-by: Andy Grunwald
Tested-by: Andy Grunwald
Reviewed-by: Francois Suter
Tested-by: Francois Suter

Except to a database structure change of the experimental PDO backend all
changes are backwards compatible for existing extensions usages if the
current API is not misused.

Notable changes:
- A new "context" variable for backends constructors was introduced. In v4 it
  is always set to "production" in production environment and to "Testing" for
  unit tests. Other than that it is unused and was ported to keep v4 and
  FLOW3 in sync.
- File backend now uses different directories for a code and data caches.
- Files created by the file backend have a .php suffix for code caches.
- In file backend, FLOW3 removed the cacheDirectory() method. It is kept
  for v4 to enable us to have cache directories outside of the document root.
- File backend unit tests use vfs (virtual file system). This way no more
  files are created by unit tests in the file system that must be cleaned up.
- t3lib_cache_Manager has a new method injectCacheFactory(), used by
  t3lib_cache_Factory. t3lib_cache, tslib_fe and init.php reflect this change.
- t3lib_cache_Factory calls initializeObject() of frontends and backends if the
  method exists. Some __construct() calls are moved to this method.
- Some code and unit tests now use name spacing for global objects.
- t3lib_cache_Manager has new protected methods to call all configured caches
  on flushCaches() and flushCachesByTag().
- Pdo backend changed its database structure and uses a "context" field instead
  of "scope" now.
- Lots of minor variable renamings, comment changes and annotation fixes.

Change-Id: Ib1be85fbbe0cb198201fb09bbdb9f9e42c097d35
Resolves: #26263
Reviewed-on: http://review.typo3.org/1722
Reviewed-by: Björn Pedersen
Tested-by: Björn Pedersen
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

t3lib_sqlparser::compileWhereClause iterates over the where subparts. It is called from
DBAL when running DBAL in native (MySQL) mode.

It does however resets its output string whenever the subpart is either FIND_IN_SET or
IFNULL. This causes the queries built by Extbase to fail.

Change-Id: Iea3d6f02cc9b8151f9fd6454f393ff6089567a03
Fixes: #25488
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1458
Reviewed-by: Stefan Neufeind
Reviewed-by: Georg Schönweger
Tested-by: Georg Schönweger
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Change-Id: I10a9814366e69dfdbf87e8ab404ab4d2ce02f4c3
Resolves: #26483
Reviewed-on: http://review.typo3.org/1813
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Reviewed-by: Christopher 
Tested-by: Christopher 
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

The meta charset tag is not fully compatible with html5.
Remove the namespace to avoid the validator warning.

Change-Id: I8275b677e5394f59dbd1efc65ced93f57149ebae
Resolves: #24212
Reviewed-on: http://review.typo3.org/2280
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

t3lib_extFileFunc has a lot of deeply nested conditions. These
conditions make understanding the code really hard.

Most of the else-branches only contain a log call, so it helps a lot to
invert the conditions, move the log call inside the if-branch and add a
break statement afterwards. The else branch can then be removed to
streamline the code.

Change-Id: Ic900fe3294142ebc89be4c3d420bb729a24d5452
Resolves: #24218
Reviewed-on: http://review.typo3.org/1087
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Stefan Neufeind

Class tslib_feUserAuth contains TER specific code. This issue is about
to remove this piece of code.

In specific this is EXT:commerce related code which has been
introduced with the TYPO3 Core Session Fixation Security Fix.

Whether fixed or not in commerce, Core should not fix code for
TER listed extensions. However, as commerce list currently very active
it should be possible for the contributors to fix problems if still
existing.

Change-Id: I2dae9c6f5fa24ce11f43ebd612523a00101e2990
Resolves: #27027
Reviewed-on: http://review.typo3.org/2364
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

PHP_SCRIPT, PHP_SCRIPT_INT and PHP_SCRIPT_EXT objects are old
TypoScript content objects which really shouldn't be used anymore.
Mark them as deprecated.

Change-Id: I6f17728e6202291ba5594fa9e1af8d05112acfe8
Resolves: #26936
Releases: 4.6
Reviewed-on: http://review.typo3.org/2269
Reviewed-by: Xavier Perseguers
Reviewed-by: Christopher 
Tested-by: Christopher 
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Francois Suter
Tested-by: Francois Suter

Although extbase urges to use Tx_ as prefix for class name, this prefix
is not accepted in all places of the core.

Change-Id: Icb46d875fdf66eaf6f51367cf3ef5030c07a4128
Resolves: #22594
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/1609
Tested-by: Philipp Gampe
Reviewed-by: Kay Strobach
Tested-by: Kay Strobach
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Jigal van Hemert

Thanks to Christian Hennecke.

Change-Id: Ie3a6b285e3a1d79f71baa975e836a447c3449681
Resolves: #26724
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2220
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

The global TCA definition is empty in some upgrade wizards.
This was caused by a general clean-up to remove PHP global
statements that did not seem to be required anymore. However,
if PHP files get included inside a method or function accessing
$TCA did not happen in a global context.

Change-Id: I17df6b3caeda0ff2b5a7399c457ccebc57627882
Resolves: #26515
Reviewed-on: http://review.typo3.org/1809
Reviewed-by: Steffen Gebert
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Change-Id: Ib9458084608ef938ab28a961d24a69cc29b7c45b
Reviewed-on: http://review.typo3.org/2111
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Constant TYPO3_URL_DONATE is defined twice. Once with
the old, simulate static URL, and once with the new, current
URL.

Change-Id: If7d2ead0e86ac93d18251db38a7c226af5903355
Resolves: #26781
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2094
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers