- May 03, 2023
-
-
Oliver Hader authored
The fix for issue #100695 reorganized the logic for setting new cookies. However, the assumption - to only set a cookie when the class property `$dontSetCookie` is disabled or a permanent cookie is used - is wrong. Previous TYPO3 versions were issuing new cookies, when `AbstractUserAuthentication::setSessionCookie()` was invoked. This change restores the previous behavior. Resolves: #100787 Releases: main Change-Id: I661a64546b99459eb81e466fdd5b03e56aeb6e93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78923 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Daniel Haupt <mail@danielhaupt.de> Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- May 02, 2023
-
-
Oliver Bartsch authored
Since #100623, the content object might be NULL as it is no longer set up when initializing the UriBuilder, but instead when handing in the current PSR-7 request. This patch adds a fallback for v12 to ensure having the content object available when generating frontend urls. Resolves: #100788 Related: #100623 Releases: main Change-Id: I733b0019a974889970d63845e3afcff5113570d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78920 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Helmut Hummel authored
When defining a default value in column overrides e.g. for tt_content TCA field sys_language_uid this value from TCA will override the value that will be set via the page module when adding a content element for a different language, because the change introduced in #86876 does not respect default values that are set via defVals (which are passed to form engine as defaultValues) A check if such values are set is now added, so that the fix for #86876 will still work, but default values set via editing forms are also respected Resolves: #99381 Releases: main, 11.5 Change-Id: Ib4270665b396bbe520afb21a7f145d0d549305ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77172 Tested-by:
-
Andreas Fernandez authored
Clicking the "Remove all" button in the CSP backend module now closes any open report. Resolves: #100757 Releases: main Change-Id: Ie6b4b5d581c2b44385f40c9db8d3b5bcbd1b8a2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78879 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Oliver Bartsch authored
Properly check for the given value being an object before passing it to corresponding method, which is type-hinted since #100068. Resolves: #100774 Related: #100068 Releases: main, 11.5 Change-Id: I704ef93ebbbfd1f161bf56dd7ef0058bd2b4875d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78889 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Torben Hansen authored
With #96874, the timestamp example plugin for CKEditor has been added to `ext:rte_ckeditor`. The plugin is however not used or referenced anywhere, so it can safely be removed. Resolves: #100781 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I2fe97a260f5ca0703684fbc324fad172eedf6d08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78912 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Oliver Bartsch authored
The PageLayoutResolver, which is used for "tree.pagelayout" TypoScript conditions requires the passed page record to contain the "backend_layout" field value. Since this field is by default not a rootline field, the TSFE->page array is now passed again instead of the shrinked record from the rootline. Resolves: #100764 Related: #100047 Releases: main Change-Id: I28ea56fb70b026e6d88b1cb00838490b35c2d5d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78891 Tested-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
-
Oliver Klee authored
This helps static analysis of projects using this class. Resolves: #100778 Releases: main, 11.5 Change-Id: I41cbf38477fb6743e5039dd9905ed38be81e96fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78888 Tested-by:
Nikita Hovratov <nikita.h@live.de>
-
- May 01, 2023
-
-
Georg Ringer authored
If files are used given like `news.setup.typoscript` and the TypoScript inclusion is used with `extension="setup.typoscript"`, the proper files must be allowed. Resolves: #100763 Related: #97816 Releases: main Change-Id: If161821d97bece80f272f6a3d94934e6d712024f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78878 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Apr 29, 2023
-
-
Stephan Großberndt authored
Further improvements, most of them as proposed by Michael Schams Releases: main Resolves: #100755 Related: #100747 Related: #100740 Change-Id: I4111a8e1025eb7c2e5e5c3273e320505c153e4ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78875 Reviewed-by:
Michael Schams <typo3.mschams@2023.schams.net> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Apr 28, 2023
-
-
Andreas Fernandez authored
The "Webhooks" view in the "Configuration" module now shows the Symfony Messenger transport configured per webhook. Resolves: #100752 Releases: main Change-Id: I809cb376a24591249697c828b9454e4168e7bbd2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78841 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #100776 Releases: main Change-Id: I1c602d05fb36d147a484755f4107f68c554c7ba1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78887 Tested-by:
-
Andreas Fernandez authored
With #100688, the module `es-module-shims` was updated. Unfortunately, with 1.5.3 an incompatibility with Firefox < 108 was introduced, affecting current Firefox ESR releases (currently at 102, at the time of writing this patch). To workaround this issue, the init scripts used in the Install Tool now use `importShim()` for the time being, until Firefox ESR hits version 108. Resolves: #100756 Related: #100688 Releases: main Change-Id: I1337ebbf1f01db287a53ff7ccad50cb4631250d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78881 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Anja Leichsenring authored
In preparation of composer based test setups, all fixture extensions require fully functional `composer.json` files. For starters, the minimal required `composer.json` is added. We will adjust as we go. Extensions without classes don't receive PSR-4 class loading definitions as those are not needed. As a convention, all fixture extensions have their composer name use the vendor `typo3tests`. Classes will have the vendor `TYPO3Tests`. This way, fixture extensions are easy to identify, both by providing tests that use the extensions, as well as in development to not accidentally use such an extension or class. Resolves: #100773 Releases: main Change-Id: Ibc1788031e39113dc1efda4ca7e4400e9cda444d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78886 Tested-by:
-
- Apr 27, 2023
-
-
Oliver Bartsch authored
Resolves: #100770 Releases: main, 11.5 Change-Id: I549371e78de399195d6810858d337528f39ce0ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78882 Tested-by:
-
Andreas Fernandez authored
The list of ids generated by `getSearchableWebmounts()` may contain duplicated values being passed into an `IN()` criteria, causing additional load to the database server. The values are now de-duplicated by applying `array_unique()` onto the list before passing the list around. Resolves: #100750 Releases: main, 11.5 Change-Id: Ib49bf1a5903cca2fbaa12ea240050caa7908f69c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78873 Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
-
Christian Eßl authored
In a list of backend users, using the avatar viewhelper, the instantiated Avatar class would always be the same instance. Each time, getImage() is called, the avatar providers would be initiated again, flooding the $avatarProviders variable with superfluous providers. - Which meant, when rendering a list of just 50 backend users, we suddenly have 1275 calls to the avatar provider class, instead of just the expected 50. Resolves: #100366 Releases: main Change-Id: I8b2eed49b47853c52a4350eb06e671081e90e373 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78339 Tested-by:
-
Anja Leichsenring authored
In preparation of composer based test setups, all fixture extensions require fully functional `composer.json` files. For starters, the minimal required `composer.json` is added. We will adjust as we go. Extensions without classes don't receive PSR-4 class loading definitions as those are not needed. As a convention, all fixture extensions have their extension name start with `test_`, and their composer name will use the vendor `typo3tests`. Classes will have the vendor `TYPO3Tests`. This way, fixture extensions are easy to identify, both by providing tests that use the extensions, as well as in development to not accidentally use such an extension or class. Resolves: #100737 Releases: main Change-Id: I312c2dd2f906d3299dae3a1d54a977cde3ce0b5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78815 Reviewed-by:
-
- Apr 26, 2023
-
-
Andreas Fernandez authored
`text-overflow: ellipsis` only works in Firefox if the parent element has an explicit width. Therefore, `button` and `a` elements are now set to a width of 100%. This also fixes an issue where images appear to be squeezed in Firefox. Resolves: #100743 Resolves: #100761 Releases: main Change-Id: I750f553b0fbdc0a05652074b785ec5028d3937bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78876 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
-
Chris Müller authored
Resolves: #100753 Releases: main Change-Id: Ia3d98fad1be54ad3056b746c436556f33d2a7818 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78842 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Benjamin Kott authored
The clearable javascript was never included or initialized. Wrappers handled by the clearable implementation have been dropped from the templates. Resolves: #100754 Releases: main Change-Id: I39f6f995821bfbda549e088b51d8d63865fb478c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78872 Reviewed-by:
-
Frank Naegler authored
Resolves: #100726 Releases: main Change-Id: I49384e7bbf3f199504ee7a978a816df1285474ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78805 Tested-by:
-
- Apr 25, 2023
-
-
Stefan Bürk authored
Used command(s): > composer u typo3/testing-framework > composer u typo3/cms-styleguide Resolves: #100751 Releases: main Change-Id: Ie5983bc76593e088190b1c81f0d33b23e98e4759 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77624 Reviewed-by:
-
Gilbertsoft authored
This patch avoids undefined key warning and properly casts the haystack argument of the `InArrayViewHelper` to an array. Resolves: #100748 Releases: main Change-Id: Ifc7d3597374eb98441aa29ac3af4e1dd8eb24409 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78840 Reviewed-by:
-
Andreas Fernandez authored
The docs for configuration message routing mention the non-existent array `$GLOBALS['TYPO3_CONF_VARS']['SYS']['queue']`. This is now fixed to be `$GLOBALS['TYPO3_CONF_VARS']['SYS']['messenger']` instead. Resolves: #100744 Related: #97700 Releases: main Change-Id: Iad8b40d9e0ba2695a60cee60379316bafed7adf2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78838 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Stephan Großberndt authored
Releases: main Resolves: #100747 Change-Id: Ifd39f0813996674620fe1b89aef29ca87351e5b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78839 Reviewed-by:
-
Daniel Siepmann authored
Resolves: #100742 Releases: main, 11.5 Change-Id: Ibff1f2da48192a23d3fe6e5404c95f3b7e6c8ae8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78837 Reviewed-by:
-
Andreas Fernandez authored
Resolves: #100741 Releases: main Change-Id: I0f65275282c85ce005eac85a081da7139606ceda Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78836 Reviewed-by:
-
Oliver Hader authored
* TYPO3 v12.4.x LTS is supported * TYPO3 v11.5.x LTS is supported * previous sprint releases of TYPO3 v12 are not covered * anything else prior to TYPO3 v11.5.0 is not covered Resolves: #100740 Releases: main Change-Id: I577569cd9794cafb2efb74bb92ef2b5d21c0a846 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78835 Tested-by:
-
Benni Mack authored
Change-Id: If17fbd8d45edd9c7685217342ad330de84ae471d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78834 Tested-by:
-
Benni Mack authored
Change-Id: I158409abb3555504ae6fa1a619794a44ab307c25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78833 Tested-by:
-
- Apr 24, 2023
-
-
Andreas Fernandez authored
There are currently two ways to configure link classes in ckeditor: * `config.stylesSet` * `buttons.link.properties.class.allowedClasses` The latter configuration is required for use in the Link Browser. If the configured classes are missing in `config.stylesSet`, CKEditor's behavior is undefined. In most cases, the class is dropped upon save. Since this is a common misconfiguration, `CKEditor5Migrator` now registers said Link Browser classes as styles in CKEditor. To achieve this, `CKEditor5Migrator` now receives the *full* RTE configuration, as Link Browser configuration happens outside CKEditor domain `editor.config`. Resolves: #100679 Releases: main Change-Id: Iabc2da29afc703508c24db76db130ea3d5f8eebc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78762 Reviewed-by:
-
Benni Mack authored
With #100720 the AbstractExceptionHandlers const IGNORED_EXCEPTION_CODES was set from private to public in order to allow to use it in subclasses. However, public is making this a full public API, which should be within the ExceptionHandler logic in general. For this reason, the constant is now changed from public to protected. Resolves: #100736 Relates: #100720 Releases: main, 11.5 Change-Id: I58427977c2217792ae854738f59527bdb2e8339e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78814 Reviewed-by:
-
Jasmina Ließmann authored
With #100663 the overall spacings were adjusted. With this patch we align the spacing between scheduler group panels with the spacing between record list items. Also, a margin above the 'Unused task groups' section has been reduced. Resolves: #100735 Related: #100663 Change-Id: I618350f1bfa79cf67f781766a2a647c05b619cfb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78813 Tested-by:
-
Markus Klein authored
Body content generation may be triggered by calling some getter or indirectly when the mail is sent (via `ensureValidity`). This changes ensures that multiple tries to generate the body are only executed if the state of the view has actually changed. This enables extensions to manipulate the content of an e-mail via events without getting their changes overridden again when the mail is sent. Resolves: #99944 Releases: main, 11.5 Change-Id: I5eced5710feeb66e6f1e32f10f710d388bc43a62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77845 Tested-by:
-
Jasmina Ließmann authored
Previously, the form fields in user settings form were displayed in their entirety, filling the screen. With this patch, the width of the input mask is now reduced to create a uniform appearance with forms of the form engine. Some individual spacing between the form fields has also been adjusted to match those of the form engine. The buttons for adding or removing an avatar image now each contain speaking labels that were previously only aria-labels. Additionally, the form fields markup in the user settings has been updated to fully match the FormEngine form field markup. With this we create the prerequisite that rollouts of global style adjustments for form fields also work on this form. Mid-term, this module should be using FormEngine for rendering anyway, so this is kind of a pre-patch. Resolves: #100605 Releases: main Change-Id: Ia83c9d42bcdb2faa12e1c1918d19e66a43f7ad66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78661 Reviewed-by:
-
Jasmina Ließmann authored
With #100042 the markup of the form fields in the add/edit form of a task has been updated. With this patch the markup was updated again to fully match the FormEngine's form field markup. With this we create the prerequisite that rollouts of global style adjustments for form fields also work on this form. Mid-term, this module should use FormEngine for rendering anyway, so this is kind of another pre-patch. Resolves: #100601 Related: #100042 Related: #100726 Releases: main Change-Id: I4ec2f7a1607bfb5005610cf2ab3cd5c2a2aac851 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78643 Tested-by:
-
Oliver Bartsch authored
With #98488, the typolink option "addQueryString" changed the behaviour to only add mapped query arguments by default. To add all - even "untrusted" - arguments to the generated URL, the new "untrusted" keyword has to be used. This now adds the possibility to set the new keyword in all related ViewHelpers. Therefore, the "addQueryString" property of the extbase UriBuilder is adjusted as well. Resolves: #100583 Related: #98488 Releases: main Change-Id: I3a4b62ec734b13e6f3cd721f4a6acefe9877b72b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78804 Tested-by:
-
Thomas Hohn authored
The variable $row['url_response']['errorParams'] should always contain a value. Either the actual error message array or an empty array to avoid a PHP 8 warning. The corresponding getErrorMessage methods now have a guard clause to check if the array is empty to avoid further propagated warnings. In TYPO3 v13 that signature of the getErrorMessage should be changed to be array. The array $errorParams is always initialized to an empty array instead of null. IN TYPO3 v13 the default value of $errorParams should be [] instead of null. Resolves: #99988 Releases: main, 11.5 Change-Id: I0f7e10f45e0f5ec7e80b79d705b38fda9a3f1410 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77898 Tested-by:
-
Oliver Hader authored
Adds new boolean `useNonce` attribute to asset view helpers, e.g. `<f:asset.css useNonce="1">` or `<f:asset.script useNonce="1">`. This way the `AssetRenderer` is instructed to apply the global dynamic nonce value. Resolves: #100732 Releases: main Change-Id: Id19c78f5f75bd3497a5bd102ae2d35606a8bacd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78810 Tested-by:
-
