- Jun 02, 2017
-
-
Benjamin Kott authored
Resolves: #81411 Releases: master, 8.7 Change-Id: I2b0f848ee6db870e78d8d102ef48ba2b417f91d7 Reviewed-on: https://review.typo3.org/53013 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Jun 01, 2017
-
-
Oliver Hader authored
If loading the backend using a slow internet connection an early click on any item in the module menu on the left side causes the link to be opened directly. The reason is, that JavaScript and thus click handlers are not completely loaded yet. Thus, the regular DOM behavior of anchor tags is executed. To circumvent this behavior, href-arguments have to be disabled and the module URL moved to a dedicated new data-attribute. As a result all items that trigger a module change have to be adjusted as well. Resolves: #80565 Releases: master, 8.7 Change-Id: I4687e6594eb539acc0d299dc8fc02e6820019911 Reviewed-on: https://review.typo3.org/53010 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
-
Christian Kuhn authored
In preperation of a scss linter and typescript linter we require bower as root dev dependency and register some happy little scripts. Change-Id: I425fd848a4012065fc7d955be0ae961f0f2ee8c4 Resolves: #81410 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53005 Tested-by:
-
Christian Kuhn authored
The file describes the exact tree that was generated, such that subsequent installs are able to generate identical trees, regardless of intermediate dependency updates. https://docs.npmjs.com/files/package-lock.json Resolves: #81406 Releases: master, 8.7 Change-Id: I8c2f0d7a8d6a1d0cd7434d8e753a32d387b32f8f Reviewed-on: https://review.typo3.org/53004 Tested-by:
-
Johannes Goslar authored
Resolves: #78464 Releases: master, 8.7 Change-Id: I8d861df1e047213a355d145e05a9131386c7439f Reviewed-on: https://review.typo3.org/52991 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
- May 31, 2017
-
-
Christian Kuhn authored
Functional tests annotated with "@group mysql" are currently ignored if running tests on postgres via "--exclude-group mysql" argument. With mssql we have some tests that run fine with mysql and postgres, but not with mssql. To improve handling, "@group mysql" annotation is renamed to "@group not-postgres". Tests not available on postgres and mssql will then later have a second annotation "@group not-mssql". This way its easier to keep track which tests go red on which DBMS. Change-Id: I2522b00352f1a7d61479588a22cdd9ea5d454ca3 Resolves: #81394 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52985 Tested-by:
-
Claus Due authored
Multiple calls to get() from cache can be condensed to one. Change-Id: I1d949fcbc0c91afdbfb2d0e2bc3d9c1b4dfd475a Resolves: #81385 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52982 Tested-by:
-
Christian Kuhn authored
The ext:impexp functional tests are rather hard to read and follow. The patch untangles them to make them better maintainable: * Combine the two different import / export abstract classes into 1 class * Don't inherit from AbstractDataHandlerActionTestCase anymore * Give single test cases better file names and do not hide them in sub dirs * Move all fixtures to Fixtures/ dir * Use less helper methods to import and test things * File paths are more straight and with less helper magic Change-Id: Iae36771b94045f99444f394129cbcf183168b584 Resolves: #81393 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52981 Tested-by:
-
Georg Ringer authored
Use the term "Upgrade wizard" instead of "Update wizard" for the buttons of the single steps as the main menu item is also called "Upgrade wizard". Resolves: #81383 Releases: master, 8.7 Change-Id: I8047ae45101533a67fa4488af7040acc49af563f Reviewed-on: https://review.typo3.org/52979 Tested-by:
-
- May 29, 2017
-
-
Elmar Hinz authored
Support case sensitve file systems again. Releases: master, 8.7 Resolves: #80814 Change-Id: I82274b328e9cfa75fb35360145d7a668d1270dc3 Reviewed-on: https://review.typo3.org/52965 Tested-by:
-
Daniel Goerz authored
Resolves: #81272 Releases: master, 8.7 Change-Id: Iac3d486697b8c52fbace185ab1a55c514847db07 Reviewed-on: https://review.typo3.org/52962 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Markus Klein authored
http_build_query() internally uses the PHP setting arg-separator.output to identify the URL parameter separator. This does not seem appropriate for URLs generated by TYPO3. Use the optional parameters of http_build_query() to get the desired functionality. Releases: master, 8.7, 7.6 Resolves: #81366 Change-Id: Ie2df9207b1967257d6327ff1103503e6a58d5cdf Reviewed-on: https://review.typo3.org/52964 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- May 26, 2017
-
-
Georg Ringer authored
Escape the < > in the check of the Windows Apache ThreadStackSize. Resolves: #81134 Releases: master, 8.7 Change-Id: Iaa73e61438766f413ba7aeeaebac0fcbf41f1a99 Reviewed-on: https://review.typo3.org/52944 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- May 24, 2017
-
-
Markus Klein authored
http_build_query() internally uses the PHP setting arg-separator.output to identify the URL parameter separator. Our code relies on having a simple ampersand as this character. If the PHP is set to a different configuration the code will fail. This is fixed by enforcing the ampersand. Moreover we force RFC3986 encoding to ensure that decoding with rawurldecode() does the right thing. Change-Id: I92f9b877201c634303a2e387d9aad49106151f63 Releases: master, 8.7 Resolves: #81293 Reviewed-on: https://review.typo3.org/52923 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- May 23, 2017
-
-
Christian Kuhn authored
Some DB drivers are picky on their arguments not being objects. Add an explicit cast to string for a VersionState object just before it's fed to a query as argument. Change-Id: I81c8f9dded7068ad7bf817e034aa67a29f28290c Resolves: #81309 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52917 Tested-by:
-
- May 22, 2017
-
-
Stephan Großberndt authored
Using the correct datatype "string" instead of a \Doctrine\DBAL\Schema\Identifier as TableDiff->name prevents exceptions if another SchemaEventSubscriber is registered. Releases: master, 8.7 Resolves: #81276 Change-Id: If273a165604ff3149d8e5aba2c0b5ccbdef8102d Reviewed-on: https://review.typo3.org/52908 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Stephan Großberndt authored
Using $connection->getSchemaManager()->listTableNames() instead of ->listTables() in Install Tool prevents a DBAL\Exception as the table details are not requested - which are not used anyway, so this is faster too. Releases: master, 8.7 Resolves: #81264 Change-Id: I35db1b6fa743ad4869bf2ba24717320f0f009995 Reviewed-on: https://review.typo3.org/52907 Tested-by:
-
Stephan Großberndt authored
Re-enable the tests passing tests changeExistingColumn() and installDoesNotAddIndexOnChangedColumn() in SchemaMigratorTest. Resolves: #81302 Releases: master, 8.7 Change-Id: Idaf9d87c16d58864c6de3353ec68be46ae93024f Reviewed-on: https://review.typo3.org/52906 Tested-by:
-
Claus Due authored
This patch reduces the amount of time required to check CGL to less than 3% of what it was before when xdebug is loaded and the script is asked to check ~100 files. Time before: 17m Time after: 23.3s Change-Id: I533ac3bfd03922362ccd6180caf6df2bfecd5bac Releases: master, 8.7 Resolves: #80814 Reviewed-on: https://review.typo3.org/52904 Tested-by:
-
Anja Leichsenring authored
Ext:core comes with a little testing framework for functional tests, that is pretty useful for all kind of DataHandler related tests. Those classes are better located in the testing-framework package to be available. Change-Id: I429e801b7318fda3a96acb4f5f63bb75050fb3e3 Resolves: #81154 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52898 Tested-by:
-
Anja Leichsenring authored
Resolves: #81284 Releases: master, 8.7 Change-Id: I59730f5807d27bbc7eb232917763daa89f41315a Reviewed-on: https://review.typo3.org/52897 Tested-by:
-
Christian Kuhn authored
A basic acceptance tests clicking through installer using a mysql db connection, checking backend login and "blank" site frontend output works. Change-Id: Ie14d9c6fd8280d382b4041f98fa04ed00ef8386c Resolves: #81285 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52894 Tested-by:
-
Christer Vindberg authored
Use quoted/escaped values embedded in the SQL fragment instead of named parameters in QueryGenerator::getSelectQuery. The values of named parameters get lost when the SQL fragment is returned and subsequently used in a query. Resolves: #80872 Releases: master, 8.7 Change-Id: If22bf24b75d2aa0efe36e587e38e7c590f3ec34a Reviewed-on: https://review.typo3.org/52893 Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
- May 21, 2017
-
-
Christian Kuhn authored
Change-Id: I4ce5bae6d200bbd7eba6679136375c71cfb6e268 Resolves: #81289 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52890 Tested-by:
-
Christian Kuhn authored
A couple of bug fixes and a setup for acceptance tests of the installation procedure. Change-Id: I97c211acb6f65a48ee90a45885887f8d16f800b9 Resolves: #81287 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52886 Tested-by:
-
Elmar Hinz authored
Releases: master, 8.7 Resolves: #81280 Change-Id: I8689827c9e33202e7659a39bb55e7a9bfd792aa2 Reviewed-on: https://review.typo3.org/52884 Tested-by:
-
- May 20, 2017
-
-
Christian Kuhn authored
The components/ directory has been a temporary directory in v8 phase, does not exist anymore and can be removed from .gitignore. Change-Id: I0f690c8fb38733dc8d168a7e43078dffc60450ea Resolves: #81286 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52882 Tested-by:
-
- May 19, 2017
-
-
Anja Leichsenring authored
If the code given for PageNotFound_handling is a relative URL, the host determination gets skipped, resulting in a redirect of the markup of the page instead a proper redirect. Resolves: #81267 Relates: #81031 Releases: master, 8.7 Change-Id: Id9c26cba813c212438368cee031673dc59db360b Reviewed-on: https://review.typo3.org/52862 Reviewed-by:
-
- May 18, 2017
-
-
Thomas Schur authored
Prevent duplicated special char conversion of page title in TYPO3 backend breadcrumb and fix title cropping Resolves: #81242 Releases: master, 8.7 Change-Id: Id7710d8d8f79e20b20f43569558833d3d3f68f16 Reviewed-on: https://review.typo3.org/52856 Reviewed-by:
-
Benni Mack authored
The method PageRepository->checkWorkspaceAccess() does a SQL query to fetch the workspace record, then hands it over to BE_USER->checkWorkspace which has the same functionality - to fetch the full workspace record. As this is redundant code, the PageRepository code can be simplified a lot by just leaving the workspaceCache property. Resolves: #81187 Releases: master, 8.7 Change-Id: Ia82febb2269084ea9101acfc36a1c9aa20950290 Reviewed-on: https://review.typo3.org/52854 Tested-by:
-
Oliver Hader authored
Tryign to determine workspace versions for a particular database table results in a very long process execution time and possible timeout due to the following reasons: * in general a bug was introduced during the Doctrine DBAL migration which leads to misbehaviors in resolving versions for pages * the SQL query implicitly creates an INNER JOIN with a huge result set that takes a long query time * invalid types leading to possible flaws when using prepared statements The SQL query has been split into using sub-queries now. Change-Id: I4e4f69815bd73f0562f7ffbd6d411b417be7a18a Resolves: #80898 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52853 Tested-by:
-
Daniel Windloff authored
In order to be consistent, change the button order and styling (according to the list module) in the InlineRecordContainer. Resolves: #78174 Releases: master, 8.7 Change-Id: I2f4498f1e822785c2b26dab697ec4fe26aae5ef0 Reviewed-on: https://review.typo3.org/52852 Tested-by:
-
Jochen Greiner authored
The comment was wrong because the TSFE-Controller takes care of setting this option internally. Resolves: #81219 Releases: master, 8.7 Change-Id: If4af5b5aefa2758063e595e9e3e0b55892c7df27 Reviewed-on: https://review.typo3.org/52851 Tested-by:
-
Marcus Schwemer authored
Currently the prepend option is rendered together with the options argument from select viewhelper. Using the option "optionsAfterContent" renders also the prepend option after the children. The preprend option is now rendered always in the first place. Resolves: #79584 Releases: master, 8.7 Change-Id: Ia58c3b7d9b26d00cbda4d7ebce2a881a7129b331 Reviewed-on: https://review.typo3.org/52848 Tested-by:
-
Thomas Maroschik authored
When the Typo3DBQueryParser converts Extbase queries to Doctrine queries, it creates subselects for certain relation constraints. It fails to wrap the subselect in braces for has-many relations which leads to sql exceptions. This patch introduces braces around those subselects. Change-Id: Ie9721a01bf166391770c7a1471272af0e15f9ccb Fixes: #81240 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52847 Tested-by:
-
Claus Due authored
Several ViewHelpers were not yet converted to use the renderStatic method and CompileWith* traits from Fluid. This patch converts those. Change-Id: I17773d4014969c5ad5a3b87bffd34c14871a2958 Releases: 8.7,master Resolves: #81143 Reviewed-on: https://review.typo3.org/52775 Tested-by:
Daniel Goerz <ervaude@gmail.com> Reviewed-by:
-
Georg Ringer authored
The public method Scheduler::log accepts an optional $code as 3rd parameter. Add this information to the parameter $details of BackendUserAuthentication::writelog as otherwise it will be casted to an integer and its information will be lost. Resolves: #80592 Releases: master, 8.7 Change-Id: Iab5f1d285976e9e88795ebbe75faff9f689b1a8c Reviewed-on: https://review.typo3.org/52846 Tested-by:
-
Elmar Hinz authored
Update the comment of the mehtod PageRepository::getMountPointInfo(). Add hint addressing to the usage of recursive mount points. Change-Id: I095563cb940e25f8c5f004497d407733faf4cbcc Releases: master, 8.7 Resolves: #81254 Reviewed-on: https://review.typo3.org/52845 Tested-by:
-
Fabian Thommen authored
Releases: master, 8.7 Resolves: #81253 Change-Id: I9920ba02349d51925610c2bd04fd8c3ea668e3a6 Reviewed-on: https://review.typo3.org/52834 Tested-by:
-
Helmut Hummel authored
DataHandler does a lookup in sys_log table after it performed its operations to find relevant error entries for the current request. It determines relevance by looking for entries with the same timestamp as $GLOBALS['EXEC_TIME']. However error log entries are written using time(). Now if the DataHandler operations take longer than one second, or the log entry is written directly before a next tick, it can happen, that errors will not be detected during the lookup process. Since such errors are exposed to the user, it can happen that an operation fails, but the users will not be notified. Fix this by using $GLOBALS['EXEC_TIME'] when writing the log entries. Resolves: #81244 Releases: master, 8.7, 7.6 Change-Id: Ic22b5f51ba4e10991be4a59ae28cb1f77a91c71e Reviewed-on: https://review.typo3.org/52833 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
