To allow running of all functional tests, instead of
relying on travis.yml, we want to clean up broken and
abandoned tests.

So we remove the tests that fatal because they are not
meant to be used in the functional testing framework.

Resolves: #58445
Releases: 6.2
Change-Id: I8fd021a9814dec43f71200641c9ba1ebbc0e32d0
Reviewed-on: https://review.typo3.org/29848
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jan Helke
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The CommandLineBackend using exec "openssl genrsa" outputs its key
generation to standard error. If SAPI is cli (eg. in unit tests),
this is is shown to the user. The patch silences openssl by
redirecting stderr to /dev/null (NUL on Windows systems).

Resolves: #58530
Related: #51436
Releases: 6.2
Change-Id: I702d2d3180bc2e32e5548a4402d4eefb02dd2523
Reviewed-on: https://review.typo3.org/29877
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes

The var pageNotFound is set, if the called page has access
restrictions. Afterwards starts a searching for an accessible page
in the rootline upwards.

If that page is a short link which also isn't accessible we stop
instead of searching again in this new rootline. Limiting this to a
maximum of 20 iterations to prevent endless loops.

If an accessible page is found we do not reset the pageNotFound var.
The PageNotFound handler reacts on this var and redirects to the 404
page instead of presenting the accessible page we found later on.

You can reproduce this with the introduction package, for example
change the access to the Example/Tables page to "Customer".
Afterwards go to http://yourdomain/?id=38 and you will see the 404
page. If you disable the pageNotFound_handling you will see the
content of the Example page.

Resolves: #16472
Releases: 6.2, 6.1
Change-Id: I1e58ec1f96422c6bf3e5c9c74f1b1c1666b68762
Reviewed-on: https://review.typo3.org/21390
Reviewed-by: Sascha Wilking
Tested-by: Sascha Wilking
Reviewed-by: Markus Klein
Tested-by: Markus Klein

As saltedpasswords is required for backend and can't be uninstalled, we
can remove the implicit dependency on extension "setup" by adjusting
the default settings there.

Resolves: #58192
Releases: 6.2
Change-Id: I6490b9962924c0e384243f663f3e5057c947749e
Reviewed-on: https://review.typo3.org/29656
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This patch adds the conversion from Windows styled to unix styled path.

Resolves: #58559
Releases: 6.2
Change-Id: I2b5b431fe60531ab1ad1c75bf9fd7749414c4df2
Reviewed-on: https://review.typo3.org/29893
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The flexform converter in ContentObjectRenderer tries to access
an array element on a non-array.

Check existence with isset() first.

Resolves: #57809
Releases: 6.2, 6.1
Change-Id: I8e6111afee3a639b3077dc59bc2e32b72fa12f5c
Reviewed-on: https://review.typo3.org/29343
Reviewed-by: Oliver Klee
Tested-by: Jost Baron
Reviewed-by: Wouter Wolters
Reviewed-by: Julian Wundrak
Tested-by: Julian Wundrak
Reviewed-by: Stefan Neufeind
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Remove the superfluous count() call.

Resolves: #58529
Releases: 6.2, 6.1, 6.0
Change-Id: I0933650b52063009de52268034480f6e06af56ac
Reviewed-on: https://review.typo3.org/29876
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Resolves: #58029
Releases: 6.2
Change-Id: If2a5f41e8524c457a20dec810f711f546d4fbb8c
Reviewed-on: https://review.typo3.org/29554
Reviewed-by: Stefan Neufeind
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Since introducing FAL the internalUploadMap array in
ExtendedFileUtility was not set on uploading files.

Resolves: #58463
Releases: 6.2, 6.1, 6.0
Change-Id: I4a537a57f1b688c26c20b9f68356a4be67bc5851
Reviewed-on: https://review.typo3.org/29820
Reviewed-by: Sascha Wilking
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

This is a regression to #54085 which accidentally converted a !strcmp()
to !==.

Resolves: #56393
Releases: 6.2
Change-Id: Ie0b2e169916e6b0ea848510e615b05d68be02199
Reviewed-on: https://review.typo3.org/29875
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Loek Hilgersom
Tested-by: Loek Hilgersom
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

All regular unit tests are located at
typo3/sysext/"extension"/Tests/Unit. The patch substitutes the single
suite registration in UnitTests.xml with a wildcard, only "Legacy"
and "Integration" tests are still registered as special locations.

Following this schema, tests located at default locations within
extensions will be found automatically without explicit registration.

Resolves: #58533
Related: #51436
Releases: 6.2
Change-Id: Ic822a68f60060437d2e3aabea7754f5b1e72af50
Reviewed-on: https://review.typo3.org/29879
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The test suite of ext:rsaauth is missing in UnitTests.xml, add it.

Resolves: #58531
Related: #58530
Related: #51436
Releases: 6.2
Change-Id: I5c1c8bbf415ed53270a09bdf68df300e28eb5f09
Reviewed-on: https://review.typo3.org/29878
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The search box at the bottom of the BE List module
disappears when you search for something and there
are no records found.

This patch makes sure the search box is also shown
when a search was done.

Resolves: #58526
Releases: 6.2
Change-Id: I95385bbdd988c4fb036d8bdc0c6b30638020a1cc
Reviewed-on: https://review.typo3.org/29873
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Our unit test environment is finally ready to execute existing dbal
unit tests, even if no database connection exists.

The patch refactors unit tests of ext:dbal, modernizes their codebase
and adds them to the build.

Resolves: #52527
Related: #51436
Releases: 6.2
Change-Id: I70507591dc89331d658d50196dfcaea002caa7d5
Reviewed-on: https://review.typo3.org/29874
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

This patch adds the loading check of rsaauth before trying to access the
BackendFactory of rsaauth. Otherwise the extension manager gets broken
on entering extension configuration.

Resolves: #58504
Releases: 6.2, 6.1
Change-Id: I197fb5e032b31e6add388269f77e6fc834e45b54
Reviewed-on: https://review.typo3.org/29859
Reviewed-by: Markus Klein
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Issue #58484 fixed the inclusion of CSS class
attributes in typolinks, but did not adjust the
impexp tests. Update the affected fixture data.

Resolves: #58503
Releases: 6.2
Change-Id: Ib71d50d03d045db37cd411523b54f8c6a1837833
Reviewed-on: https://review.typo3.org/29857
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs

Doesn't fix the tests completely.

This reverts commit 8ae7a4b9

Change-Id: Ifadcc61d2bf159c5d70f4f1b5b8d436471a79f76
Reviewed-on: https://review.typo3.org/29856
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs

Issue #58484 fixed the inclusion of CSS classes
in typolinks, but did not adjust the tests.
Update the affected fixture data.

Resolves: #58503
Releases: 6.2
Change-Id: I511847bda3e393f104f1f141fb3a0bed4a97c1b1
Reviewed-on: https://review.typo3.org/29854
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs

The SoftReferenceIndex parses and rebuilds typolink tags, but the
support for more than one value in class attribute is missing, because
the values don't get enclosed with quotes on rebuilding.
This leads to lost classes in typolinks in exports from impexp.

Resolves: #58484
Releases: 6.2, 6.1, 4.5
Change-Id: I12ed3be7f5be36254bcee57fcb24bf2a10f92f46
Reviewed-on: https://review.typo3.org/29846
Reviewed-by: Wouter Wolters
Reviewed-by: Sascha Wilking
Tested-by: Sascha Wilking
Reviewed-by: Markus Klein
Tested-by: Markus Klein

The file handling (downloading/storing or uploading/fetching
existing T3D/XML files) is currently not full FAL compatible in the
import/export module of the TYPO3 CMS backend. Also saving
export file to folder on server shows an error, but the file is saved.

In further TYPO3 version the .htaccess protected folder
fileadmin/_temp_/ was used to store the export files. This was lately
changed to the public accessible users default upload folder,
normally fileadmin/user_upload/. This patch changes this
back to a .htaccess protected folder, namely _temp_/importexport/
below users default upload folder.

Resolves: #53552
Releases: 6.2
Change-Id: I250e08188d9e9aac011c759fccf7e831fea037fb
Reviewed-on: https://review.typo3.org/25294
Reviewed-by: Sascha Wilking
Tested-by: Sascha Wilking
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs

With issue #57488 the pages.media field became localizable again,
however the selective approach turns out to be problematic in
terms of overlaying data in the frontend (the "mergeIfNotBlank"
settings and the like).
Thus, instead of letting the editor localize the references after
persisting the parent and having to overlay/fallback in the
frontend, now the references are already shown in the edit view
during the localization (still before being persisted).

Resolves: #58476
Releases: 6.2
Change-Id: Id6980f2a5cfea109375afce27f62cad8c101c58e
Reviewed-on: https://review.typo3.org/29839
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs

This patch removes the deletion possibility for installed extension in
the list view of the extension manager. Furthermore the javascript can
be adopted as the check for installed extensions can be removed as well.

Resolves: #58493
Related: #53459
Releases: 6.2
Change-Id: I713bbb93230108db144044be9184e77f484931c9
Reviewed-on: https://review.typo3.org/29849
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Sascha Wilking
Tested-by: Sascha Wilking
Reviewed-by: Nadir S.
Tested-by: Nadir S.
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs

If the database field does not exist it may be that we have an
installation before 6.0 or after 6.1 so we do not need to migrate
the data to sys_file_metadata. This prevents empty metadata
information which may lead to other issues.
(width/height=0 for images)

Resolves: #57492
Related: #46020
Releases: 6.2
Change-Id: Id5826ea480d4139f2e232587fc2b119928b28bc8
Reviewed-on: https://review.typo3.org/29024
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Nicole Cordes
Reviewed-by: Anja Leichsenring
Reviewed-by: Jan Runte
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs

When dragging content elements in the page module, the element gets
overlayed by TCEform elements. It loses its hover state, when dragged
outside the viewport or very rapidly.

* Set z-index higher than 4000
* Add a css class to stabilize active drag state
* Remove duplicated javascript code in page module

Resolves: #58473
Releases: 6.2, 6.1
Change-Id: I87577d30e5d6bb16f6999d466bef92da95b2add3
Reviewed-on: https://review.typo3.org/29837
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Wouter Wolters

If a not existent cache group is specified
to the flushCachesInGroup methods, there is no
indication that actually nothing happened.

Throw an exception instead, so that calling code
can easily be fixed.

Resolves: #58465
Releases: 6.2
Change-Id: I9617fcee9abfa27a9cb76a3fd12543c62420e719
Reviewed-on: https://review.typo3.org/26981
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel

Since making userHomePath and groupHomePath FAL compatible
the descriptions in DefaultConfiguration don't fit anymore.

Resolves: #56986
Releases: 6.2, 6.1
Change-Id: Ia27193b967137dd3744c2fdcf5b5b0d3366c0080
Reviewed-on: https://review.typo3.org/29838
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

If open_basedir is restricted to files, eg. /usr/bin/gm, detection
fails in install tool. The additional is_dir() check may fail then.
The patch removes it since @is_file() covers the same checks.

Resolves: #58466
Releases: 6.2
Change-Id: I5ab6a36ccd3d283a1dc1e672f7deddc2f0ea37c4
Reviewed-on: https://review.typo3.org/29822
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

This patch changes the file permissions, so we need to work
some more on it.

This reverts commit 03cf03b2

Change-Id: I21343c8273db1e5173d6b8211cc2fed510e9810e
Reviewed-on: https://review.typo3.org/29828
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Fixed two small glitches which escaped us in the review of
https://review.typo3.org/#/c/29713/.

Resolves: #10487
Releases: 6.2
Change-Id: I6425835a3aa349ac47ab0a01cf1241be2df6d187
Reviewed-on: https://review.typo3.org/29821
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

As the page.media in most cases is for images it makes
sense to enable the alt and link fields just like
tt_content.images.

This patch changes the default TCA for table pages so
the alt and link fields are enabled for the media
file_references.

Resolves: #56884
Releases: 6.2
Change-Id: I4496644d340a6fab9be18bf4942ea96a22b1b4ce
Reviewed-on: https://review.typo3.org/29816
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Nadir S.
Tested-by: Nadir S.
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

During drag and drop the dragged content element was
overlayed from the next content scope (headline element).

The "z-index" must be fixed here. Just added a hover effect
for the whole draggable content element. The correct value
for the "z-index" may between the z-index values of "topbar"
and "toolbar" (under "structure" stylesheets).

Resolves: #58413
Releases: 6.2, 6.1
Change-Id: I8fa83cec793b5deb7dbbc13553a043b706510904
Reviewed-on: https://review.typo3.org/29824
Reviewed-by: Sascha Wilking
Tested-by: Sascha Wilking
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Reduce the file size without losing quality.
This reduces total typo3 directory size by ~2 MB.

Resolves: #58110
Releases: 6.2
Change-Id: I2062cead3939d93b847f1be741ef8a26bfb0edd8
Reviewed-on: https://review.typo3.org/29617
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Tested-by: Nadir S.
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Properly initialize _cleanProperties to array to prevent warnings.

Resolves: #57244
Releases: 6.2
Change-Id: I64f62cbcaf7268740af0e3c51303c49fc343136b
Reviewed-on: https://review.typo3.org/29814
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Oliver Klee
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs

Solve some issues running function tests on windows OS

* Disable colors, this is hardly supported in windows CLI,
  enable in .travis.yml explicitly
* Convert the web root path into a unix styled one to prevent a
  mix between backslashes and forward slashes
* Improve finding the PHP binary as the system constants PHP_BINDIR
  is defined with "C:\php" even if PHP is installed in a different folder
* Improves command line argument escaping for special windows
  requirements.

Resolves: #57524
Releases: 6.2
Change-Id: I80b1652e35b816f8ca93929950d014c45b9535d1
Reviewed-on: https://review.typo3.org/29057
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Deleting an extension in the Extension Manager doesn't delete
the entry in PackageStates file.

Use the package manager to delete the extension. This will take care of
linked extensions (just remove the link) too.
The package manager will take care to remove the entry from the
PackageStates file.

If an extension is not listed in the PackageStates file (e.g. because
we uploaded it via FTP and forgot to clear the system caches),
directly remove the folder.

Resolves: #53459
Releases: 6.2
Change-Id: I10d5ef33ccf6438fece512478408c57d5d7486de
Reviewed-on: https://review.typo3.org/26921
Reviewed-by: Jan Runte
Tested-by: Jan Runte
Reviewed-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Resolves: #58344
Releases: 6.2
Change-Id: Ic2cbc0a9d8a27c67e145ea9fef55c60d13466c33
Reviewed-on: https://review.typo3.org/29731
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Resolves: #58459
Related: #50248
Releases: 6.2
Change-Id: I3b72ecd65dff934a4eff10be7cb3c46ded948a34
Reviewed-on: https://review.typo3.org/29815
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

reinitializeClassLoaderAndCachesAndPackageManagement
not only reloads the class loader and package management
but also reloads LocalConfiguratzion and
AdditionalConfiguration. This can lead to errors if
AdditionalConfiguration contains require_once calls.
The method is only used by ClearCacheService which
does not need the configuration reload.

Solution is to remove the method and introduce a new
one to unregister only the class loader. The other
bootstrap methods are now called directly in clear
cache of install tool.

Resolves: #58337
Releases: 6.2
Change-Id: I59cec5f3fc7dacbf83854c0559b4a8b3f143707d
Reviewed-on: https://review.typo3.org/29811
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Jan Runte
Tested-by: Jan Runte
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

This patch changes the default configuration to prevent any redirect
loops during the first installation process.

Resolves: #58380
Releases: 6.2
Change-Id: I8c0cbb779ee40b3310d2cb7ad6600d3bcaf4ec41
Reviewed-on: https://review.typo3.org/29802
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

The Extbase help command controller has the calling
script hardcoded in several places. This may cause
confusion if the calling script was different.

Use the real script from argv[0] instead.

Resolves: #58456
Releases: 6.2
Change-Id: I622484cb75ad87078ed8b5f923f1f3b972c64124
Reviewed-on: https://review.typo3.org/29809
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring