- Apr 30, 2015
-
-
Wouter Wolters authored
Extension backend is done with this patch except FormEngine classes. Resolves: #66115 Releases: master Change-Id: I0dc335b0193566b9d14e4b8fdafc116a81e0f5cc Reviewed-on: http://review.typo3.org/38324 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christian Kuhn authored
Naming prefixes in flex form section container handling is changed to successfully save them again. Resolves: #66663 Releases: master Change-Id: I8268a4cd9860c4b17a54e05ba2aa86190fa7eda2 Reviewed-on: http://review.typo3.org/39110 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Wouter Wolters authored
This is a backport from the new introduced feature in Flow https://review.typo3.org/#/c/30653/ with upstream patches. This extends the base ``CommandController`` by some convenience helpers from the ``symfony/console`` package: easy output coloring through "<error>Warning!</error>" TableHelper to render values to a grid ProgressHelper to render and advance and progress bars DialogHelper with numerous types of questions like: select, ask, confirm, askHidden, etc Additionally this change improves the ``mapRequestArgumentsToControllerArguments()`` method to ask for missing required arguments instead of quitting with an exception. You can make use of the new features by calling the introduced ConsoleOutput object with its respective methods: outputTable() select() ask() askConfirmation() askHiddenResponse() askAndValidate() askHiddenResponseAndValidate() progressStart() progressSet() progressAdvance() progressFinish() This change does not alter the public API so it is not breaking in the strict sense. But it introduces a new behavior: Previously all outputs where collected in the ``Cli\Response`` and only rendered to the console at the end of a CLI request. Now all methods producing output (inluding ``output()`` and ``outputLine()``) render the result directly to the console. If you use ``$this->response`` directly or let the command method return a string, the rendering is still deferred until the end of the CLI request. Resolves: #59606 Releases: master Change-Id: I33e051f698f5cc1e204f609734280bbed69610c9 Reviewed-on: http://review.typo3.org/30743 Tested-by:
Helmut Hummel <helmut.hummel@typo3.org> Tested-by:
-
Christian Kuhn authored
It is possible to add custom JS as eval function for type input. This is no longer called after FormEngine refactoring due to an additional quoteJSvalue() that is missing in the reference. Resolves: #66689 Releases: master Change-Id: I31c7b1f01e37e21aa4bf6d27f324cb522be74fe5 Reviewed-on: http://review.typo3.org/39091 Reviewed-by:
Andreas Fernandez <andreas.fernandez@aspedia.de> Tested-by:
-
Xavier Perseguers authored
MSSQL does not allow a column of type "text" to be compared with an equal operator. It fails with: The data types text and varchar are incompatible in the equal to operator Change-Id: I59e955e53127854fb44ec1af9d81388801438222 Releases: master, 6.2 Resolves: #66686 Reviewed-on: http://review.typo3.org/39086 Reviewed-by:Xavier Perseguers <xavier@typo3.org> Tested-by:
-
Xavier Perseguers authored
A sequence table should not be used when the underlying ADOdb driver is capable of properly using and retrieving auto-incremented fields. Change-Id: I8d474e253c927d2dcb4d6ebc9ad6eb5bb4d06f2d Releases: master, 6.2 Resolves: #66680 Reviewed-on: http://review.typo3.org/39079 Reviewed-by:
-
Xavier Perseguers authored
Change-Id: Ie251d2b9776be4d7c8d3a450cfa1252a57ce07a3 Resolves: #66678 Releases: master, 6.2 Reviewed-on: http://review.typo3.org/39075 Reviewed-by:
-
Markus Klein authored
If plain images from local storages are rendered to FE, absRefPrefix will now be applied correctly. Resolves: #66496 Releases: master, 6.2 Change-Id: I9c7c4590d5ca53bb4669da383462dfa63f7ab3ab Reviewed-on: http://review.typo3.org/38889 Reviewed-by:
Benjamin Mack <benni@typo3.org> Tested-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
-
Xavier Perseguers authored
When using DBAL, the where clause of database query must not be left empty. exec_SELECTcountRows() defaults to an empty string and causes the Install Tool to fail to create the tables for the extension manager. Change-Id: I9fd66147bf662bbf7e527860756d83ca247a2260 Resolves: #66675 Releases: master, 6.2 Reviewed-on: http://review.typo3.org/39070 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de> Reviewed-by:
-
Christian Kuhn authored
With mysql 5.6 we still see various mysql issues that come from travis infrastructure. We're currently unable to fix this. To have a green build for now, functional tests are separated and marked as allowed_failure until stuff is sorted out on travis side. Patch is for master only at the moment, 6.2 may get an own change if problems persist. Releases: master Change-Id: I9513c8894d7737c09a47588dc9efddd4e9e140e3 Reviewed-on: http://review.typo3.org/39073 Reviewed-by:
-
Xavier Perseguers authored
When no errors are found in a query, the MSSQL native driver for ADOdb returns an invalid error message "No errors found" instead of an empty string. This causes TYPO3 to take the non-empty string as an actual error. Change-Id: I09474747cd4733576464792d5d59212e87778e8a Resolves: #66674 Releases: master, 6.2 Reviewed-on: http://review.typo3.org/39069 Reviewed-by:
-
- Apr 29, 2015
-
-
Christian Kuhn authored
Some extensions like ext:news use ';;;;2-2-2' in TCA showItem which is actually an invalid syntax. FormEngine detects this and throws an exception. To mitigate the issue, the exception is commented out for now and a @todo is added on how this case could be handled later. Another warning in flex form container / section handling is fixed with the patch by sanitizing the given row data to an array, which is not always the case, for example if adding a new record. Resolves: #66628 Related: #63846 Releases: master Change-Id: Ib6dcba0c5e2c1dad8c842e99994ab97e456deb41 Reviewed-on: http://review.typo3.org/39017 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Markus Klein authored
Releases: master Resolves: #66375 Change-Id: Ic61889d6fadd3ec8196ccf96ad97e5247e804ab5 Reviewed-on: http://review.typo3.org/38631 Reviewed-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Michael Oehlhof authored
Fixes an issue mentioned by http://scrutinizer-ci.com/g/DFAU/TYPO3.CMS Resolves: #66638 Releases: master Change-Id: Ifad658b07fe5024b8cdaeae657a3ce637af8af80 Reviewed-on: http://review.typo3.org/39051 Reviewed-by:
-
Benjamin Serfhos authored
Simulating the admin function when saving their own account failed when TCA is modified. The backend user is now simulated as admin, instead of the DataHandler class only. Now it validates all possible checks when updating the user records as admin. Note: This will keep the same functionality and therefor has no impact on the Core itself. Releases: master, 6.2 Resolves: #66412 Change-Id: Ib17ac99d9e7a4aaf1e807b41b30f7310ad8da655 Reviewed-on: http://review.typo3.org/38684 Reviewed-by:
Benjamin Serfhos <serfhos@gmail.com> Tested-by:
Jesper Paardekooper <jesper.paardekooper@gmail.com> Tested-by:
-
- Apr 28, 2015
-
-
Christian Kuhn authored
This patch introduces a structural code refactoring to the FormEngine class and its related friend classes. FormEngine used to call itself over and over again with itself and sub classes writing to public properties of FormEngine keeping a global state that is then magically merged to sometimes working output. The patch introduces a tree approach with lots of small containers doing an encapsulated part of the rendering process and calling sub containers for inner details. As main construct a "globalOptions" array is modified in containers and given down to sub containers (tree knots) or elements (leaves), while sub structures always return a defined array that is merged by the parent and accumulates the full result. Goal is to have a better encapsulated code structure with better visible impact on changes done to this system. The patch creates this main structure. There is still a lot of mess around and additional patches can further improve the overall situation with smaller changes. Change-Id: I56b898dc0eaae8de4d31016997cfefe8d14ec53e Releases: master Resolves: #63846 Resolves: #63854 Resolves: #63856 Resolves: #63858 Resolves: #63859 Resolves: #63860 Resolves: #63861 Resolves: #63862 Resolves: #63863 Resolves: #63865 Resolves: #63876 Resolves: #63881 Resolves: #63882 Resolves: #63883 Resolves: #63893 Reviewed-on: http://review.typo3.org/38433 Reviewed-by:
-
Benjamin Mack authored
Change-Id: Ie9edd14d2d55c1731f69d6f6b15e04e9528efc28 Reviewed-on: http://review.typo3.org/38993 Reviewed-by:
-
Georg Ringer authored
To improve the usability of the backend, filters should be provided where it makes sense, especially where it is likely to have more records. - FE Groups: Subgroup selection - FE User: Group selection - BE User: Group selection Resolves: #66621 Releases: master Change-Id: I483c22487f89f79f313bd72e0bb6fce49efab3fa Reviewed-on: http://review.typo3.org/38982 Reviewed-by:
-
Wouter Wolters authored
Resolves: #66585 Releases: master Change-Id: If8c79dcab8553848a276691b7e20ce1d38ca107f Reviewed-on: http://review.typo3.org/38911 Reviewed-by:
-
Wouter Wolters authored
Resolves: #66583 Releases: master Change-Id: I9e28156562bf56612eebd91dba0d61616f8170ea Reviewed-on: http://review.typo3.org/38909 Reviewed-by:
Mathias Schreiber <mathias.schreiber@wmdb.de> Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Tested-by:
-
Mathias Brodala authored
This allows for conversion of formatted dates to timestamp and complements the existing date/strftime properties. Resolves: #63561 Releases: master Change-Id: I4e41cabc70979da5746f5b119ab2096bdd9e0c6e Reviewed-on: http://review.typo3.org/35029 Reviewed-by:
Jo Hasenau <info@cybercraft.de> Tested-by:
-
TYPO3 Release Team authored
Change-Id: I794e721bd23246fd2eed923d3a88d2334de62394 Reviewed-on: http://review.typo3.org/38986 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
-
TYPO3 Release Team authored
Change-Id: I90e56b8dbfffc46b40700fed333b03496847cc98 Reviewed-on: http://review.typo3.org/38985 Reviewed-by:
-
TYPO3 Release Team authored
Change-Id: I61d66ccd2f4bb031b0a98b45dbfbdfcc3e6c0a1b Reviewed-on: http://review.typo3.org/38984 Reviewed-by:
-
Markus Klein authored
Resolves: #66615 Releases: master Change-Id: Ia8497f963b8e4189df1e43b93624db57bedf0e54 Reviewed-on: http://review.typo3.org/38973 Reviewed-by:
Frank Nägler <typo3@naegler.net> Tested-by:
-
- Apr 27, 2015
-
-
Xavier Perseguers authored
There are still a few inconsistencies in the way titles are written. This patch also corrects some errors which happen upon rendering to HTML (wrong code blocks). Change-Id: I09105c94eaed6e8d96d0ae489f95b4e7a19ffd82 Releases: master Resolves: #66613 Reviewed-on: http://review.typo3.org/38967 Reviewed-by:
-
Andreas Allacher authored
"time" and "timesec" fields currently do not store time as UTC in database, however, in the FormEngine modifications time was also handled as being stored in UTC which results in time fields being stored and then being modified with +/- x hours, depending on server time. This patch reverts the behaviour back to store times as server-time. However, in the future it would be good to store those values as UTC too, but that will require more changes and would also be a breaking change. Change-Id: I6c299bfa3d0387081f00c6cba7723e10236fabf0 Resolves: #65976 Releases: master Reviewed-on: http://review.typo3.org/38112 Reviewed-by:
-
Markus Klein authored
* Retrieve correct LockingStrategy for requested capabilities * Prefix lock filenames to make them better visible in the folder * Make all LockStrategies destroyable * Semaphore locking now uses ftok() to generate a unique id * Make the Mbox lock independent of the target file * Introduce an access lock for each of the TSFE cache locks We decrease the priority of Semaphore locking since this can be pretty dangerous for the average user. If something goes really wrong in the webserver (which is out of our control), we might leave behind stale semaphores, which might cause a permanent deadlock for an instance, which can only be resolved by a server admin. We might raise the priority again at a later point in time, when we can provide better means of cleanup. The new access locks protects the access to the cache locks in TSFE now, which allows us to safely remove those cache locks after using them. This way we don't spam the system with loads of locks. Releases: master Resolves: #66503 Change-Id: Ia19e6e7d47d7941e01785f5a6b67746a6c0fa368 Reviewed-on: http://review.typo3.org/38840 Reviewed-by:
Andreas Allacher <andreas.allacher@gmx.at> Tested-by:
-
Francois Suter authored
An index file is missing in the 7.2 change log to have a TOC for navigating in 7.2 documentation. This patch also corrects some errors which happen upon rendering to HTML (wrong code blocks, missing lexer argument, missing Intersphinx references for cross-links). Resolves: #66612 Releases: master Change-Id: If53632fc50694b330253fdab9cf9a81ba7bf13ec Reviewed-on: http://review.typo3.org/38964 Reviewed-by:
Francois Suter <francois@typo3.org> Tested-by:
-
Helmut Hummel authored
The class alias loader package was changed to be a composer plugin. By that, the script section can be removed again. In addition we change the requirement to the minimum version which contains the plugin conversion. Releases: 6.2, master Resolves: #65688 Change-Id: I2ca1eee56e9a3f9e1f538ab95d9a01544ea98c95 Reviewed-on: http://review.typo3.org/38955 Reviewed-by:
-
Andreas Allacher authored
Currently BackendUtility::getProcessedValue method ignores the foreign_table field. This is basically a follow-up to commit: c47c3574 Change-Id: Ia08878a7a3cdcf7e1a0743c7ce84251a0b82fd82 Resolves: #63557 Related: #62755 Releases: master, 6.2 Reviewed-on: http://review.typo3.org/37035 Reviewed-by:
Stephan Jorek <stephan.jorek@gmail.com> Reviewed-by:
-
Markus Klein authored
Store page title information in page cache as well, so we have a proper state when rendering partially cached pages. On those pages *_INT objects might be present, which modify the title and this has to be handled correctly. Releases: master, 6.2 Resolves: #66499 Change-Id: If03568d36bd847c9a4ca41881a1723f6f1de7671 Reviewed-on: http://review.typo3.org/38852 Reviewed-by:
-
Felix Kopp authored
Explains the accepted login logo and background image paths "EXT:…" or "fileadmin/…" or "/fileadmin/…". Resolves: #66476 Releases: master Change-Id: I68824eca21601ed69e96fe5ee9fc5472b889f314 Reviewed-on: http://review.typo3.org/38923 Reviewed-by:
-
Jan Kiesewetter authored
Similar to protecting the private resources, the configuration of an extension should be protected as well. Change-Id: Ib68cb77ea21e8ec192927d1c9c62a30c1bb7103f Releases: master, 6.2 Resolves: #66573 Reviewed-on: http://review.typo3.org/38921 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Jan Kiesewetter <jan@t3easy.de> Tested-by:
-
Benjamin Kott authored
- Resolve image paths equally without fal compat layer - Remove border if background image is set - Increase border radius Releases: master Resolves: #66431 Change-Id: Icf5217c46467268f67d4e7fd91903e916535ebfa Reviewed-on: http://review.typo3.org/38926 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- Apr 26, 2015
-
-
Andreas Fernandez authored
It's not required to limit the maxlength of datetime fields by TCA anymore, as the used DateTimePicker already validates the values. Releases: master Resolves: #66593 Change-Id: Ib2ab070c907e790c7b23a4cacf3cd11aa5e219fc Reviewed-on: http://review.typo3.org/38925 Reviewed-by:
-
Benjamin Kott authored
Fixed wrong LESS path. Releases: master Resolves: #65055 Change-Id: I2d95775e2796e8b1fdff67430b287230699690de Reviewed-on: http://review.typo3.org/38922 Reviewed-by:
-
Mathias Schreiber authored
Proofread breaking, deprecations and features. Releases: master Resolves: #66553 Change-Id: I08c497e53bd90845940fb536ca17e90a9fde20c9 Reviewed-on: http://review.typo3.org/38872 Reviewed-by:
-
Wouter Wolters authored
Path to image does not exists, rename it to the existing png file. Furthermore this patch shortens a few namespaces and uses GeneralUtility::quoteJSvalue for the url in openInNewWindow function. Resolves: #66584 Releases: master Change-Id: I9b17aafae6a4f94ddefa5d012c447b8eacc0495d Reviewed-on: http://review.typo3.org/38910 Reviewed-by:
-
- Apr 24, 2015
-
-
Benjamin Kott authored
Releases: master Resolves: #66563 Change-Id: I23be4cab776252afff25f3f23c8fee2f4c09fad5 Reviewed-on: http://review.typo3.org/38887 Reviewed-by:
-
