- Feb 10, 2021
-
-
Christian Eßl authored
When a shortcut page is used for a translated page, but its parent is not of type shortcut, the generated link would always use the current language of the frontend context instead of the actual required language set in _PAGES_OVERLAY_REQUESTEDLANGUAGE. Resolves: #89871 Related: #81657 Related: #86595 Related: #19114 Releases: master, 10.4 Change-Id: Iaa4e682e2bd79852b5e586b1764fd42ae8676644 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Georg Ringer authored
By fixing a typo, the field quoting also works for `leftjoin` and `rightjoin`. Resolves: #93449 Releases: master, 10.4, 9.5 Change-Id: I65c08d17f7f41a505fc4e23fbafd775469e9a13a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67672 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Ayke Halder <mail@ayke-halder.de> Reviewed-by:
-
- Feb 09, 2021
-
-
Benjamin Franzke authored
Align the search input to the toolbar icons. Releases: master Resolves: #93476 Related: #93474 Change-Id: I50c8344f2370c32980db247e63fadd3a2f67287c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67679 Tested-by:
-
Benni Mack authored
The PageTree toolbar now displays both menu areas ("main menu" and "submenu") all the time and removes the submenu toggles / buttons. This is a request from various UX developers to: * remove buttons for toggling if there is enough space * decouple buttons from the click / drag functionality (some had borders, some did not) * not hide the filter in a submenu (unclear that the left buttons are menu toggles) In itself, the loading area is now clearer (via simpler CSS), and the TypeScript/JS code gains simplicity for building the menu. Resolves: #93474 Releases: master Change-Id: Ie3767e247f28418af949b39b39919e50f13cc48f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67677 Tested-by:Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Benni Mack authored
This change migrates all left-over components of * SvgTree * SelectTree (a.k.a. CategoryTree) * and PageTree to TypeScript adding types in various places to make the code less error-prone. Resolves: #87678 Resolves: #85400 Releases: master Change-Id: Ibb4024d365857c44018a7a201c1cf75baa48179a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67662 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Ute Flierl authored
SVG with inline styles are not loaded when the Content-Security-Policy header contains the widely used setting "style-src 'self';" because the browser has to reject interpreting the style attribute. In this case a black rectangle is displayed. Using attributes instead of styles is compliant with CSP "style-src 'self';" and the svgs can be displayed. Releases: master, 10.4 Resolves: #91216 Change-Id: I1679a2004f1fc868231318249a267cbba62c540f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64331 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
Richard Haeser authored
Make sure that the first root node is selected before the tests are executed. Resolves: #93471 Releases: master, 10.4 Change-Id: I8d2b973a8d7e0a6f94db39967b8710474502335b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67673 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Benjamin Franzke authored
Based on the configuration syntax of the Symfony Console feature https://github.com/symfony/symfony/pull/39851 …but implemented differently, using a registry pattern rather then a lazy-object pattern (like symfony does). Main motiviation for the registry pattern is following: Symfony LazyCommand wrappers add quite some complexity only for the sake of the list command, we already got lazy commands (in terms of execution) as our CommandRegistry implements the ConfigurationLoaderInterface that has been introduced by 2017 to add support for lazy commands. Now, that means we already got a registry for lazy commands, so it is logical to add lazy description handling there as well. We want to assure that the command list will never instantiate any commands. This is in constrast to the Symfony core LazyCommand approach, where legacy commands, that do not provide a compile time description, would still be instantiated during console command list. Also commands that return false in `isEnabled()` are now listed. That means enabled state is only evaluated during runtime. Therefore the special `dumpautoload` command is transformed into a lowlevel command in order to be hidden dependending on being run in composer-mode or not. Releases: master Resolves: #93174 Change-Id: Ifa68404cc81c64a335be30f2263a7eb17de0624d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67635 Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
- Feb 08, 2021
-
-
Benni Mack authored
Because TYPO3 Backend is based on the symfony/routing components, it is now possible to also limit a route to only e.g. a POST request by defining allowed methods in the route registration. This allows for more secure route behaviour, e.g. routes that update the system, should semantically using POST requests. Similarly this way, future non-HTML-routes in the TYPO3 Backend could be set up (e.g. for REST APIs), utilizing the BE routing directly. For the time being, the password-forgot form is now only allowed for POST methods, effectively hardening this feature. Resolves: #93455 Releases: master Change-Id: I1c89f592ce17dfcd8a7e7674945c97c7c39969ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67655 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benjamin Franzke <bfr@...>
-
Benjamin Franzke authored
renderElement() was added in patchset 2 of #93446. The code was then refactored to use renderHTML, but the method was forgotten to be removed in the final patchset. Now, the intention of the mentioned patchset 2 was to render nodes directly to the DOM in PageTreeDragHandler, instead of rendering to a temporary element, just to export and re-import as HTML string with jQuery/innerHTML. Therefore PageTreeDragHandler is now refactored to a new, (internal) method renderNodes() which allows the returned nodes to be directly attached to the document. Also, while at it, all other lit-helper methods are marked as internal as well, as they are still subject to change: * `renderHTML()` is only needed when mixing traditional jQuery rendering and lit-html (same as for the new `renderNodes()`.) * The `icon()` method could likely be replaced by a custom <typo3-backend-icon> component * `lll()` is only of use for globally available language identifiers (w...
-
Anja Leichsenring authored
* Acceptance tests in nightly run can use just one out of our supported databases, that should be enough. * Some reorderings to reflect order in gitlab-ci better * Minor issues and cleanups Releases: master Resolves: #93456 Change-Id: I67355f139e24ec9c287ab3b753059a342b387700 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67660 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Benjamin Franzke authored
This wizard-backendlayout icon has been added in #72853 as icon for the backend layout wizard, but was later forgotten to be removed when the backend layout wizard was rewritten into an own renderType in TYPO3 v8 (#75497). The rewrite dropped usage of the icon. Resolves: #93465 Related: #75497 Releases: master Change-Id: I51593a4915fdaa0b5aa06bc663e6dc46e9ec9a6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67664 Tested-by:
-
Benni Mack authored
The Backend LoginRefresh password field now also contains "autocomplete=current-password" just like the login-form. Sidenote: The attribute (also for the username) must be added manually via jQuery as there is a strange bug not allowing "autocomplete". In addition, it fixes a typo for the rsa-encryption to be proper english, and not needing a special handling for LoginRefresh.js anymore. Resolves: #93448 Releases: master Change-Id: Iedf306380a4dbfb5ec31c37f932f8d3b64daf366 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67654 Tested-by:
-
Benni Mack authored
The PageTree components for the navigation area consists of: * PageTreeElement (container for rendering the navigation area w. toolbar + dragdrop + tree) * PageTreeToolbar (uses DnD for creating new items) * PageTree (JS, subclass of SvgTree) * PageTreeDragDrop This patch aims to rework the "PageTreeDragDrop" javascript file by moving separate logic into separate classes (as much as possible) and into a more stable API, being a first part. PageTreeDragDrop is a mixed code class currently, and is now split up in various separate classes: * DragDropHandler (interface) * ToolbarDragHandler -> used as the Toolbar Draggable Handler for new pages * PageTreeNodeDragHandler => used for moving/copying and deleting existing pages/nodes * PageTreeDragDrop now acts as a simple wrapper for d3-drag but still has some shared state For Future Reference: It is still up to decide on how to further decouple the code. Idea 1: Putting the d3-drag initialization into the right place and avoiding cross-dependencies. In general "initializeDragForNode" would also be handled via events, and all options / settings would be moved into the PageTreeDragDrop class. Ideally the PageTreeDragDrop contains the status of the current drag+drop action (position, node etc), so the PageTree would not know of anything itself. Idea 2: Another possibility is to use the current "PageTreeDragDrop" as a generic "TreeDragDropManager" because it does not contain any Page-Tree specific code anymore, but could be carried on later-on. The current change is already a good step as it moves all code to TypeScript and minimizes injection via constructors (except for the Tree itself). Resolves: #93446 Releases: master Change-Id: Ibd7a067c1e6a821b138a8cc2971ec8133392b600 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67650 Tested-by:
-
- Feb 06, 2021
-
-
Oliver Bartsch authored
BackendController::generateJavascript() creates the top.fsMod object to provide frameset modules an easy way of storing their state. The FileList module e.g. stores the current folder identifier. Therefore, after switching back to the FileList module, the previously selected folder is used. This behaviour is now restored by replacing the "instanceof" check, which always evaluated to FALSE, with a typeof check. It's furthermore now ensured that the id will always be set, even if recentIds is not yet an object. Resolves: #92811 Releases: master, 10.4 Change-Id: I36227775bfadfca4d43a719b1508f78976b6e342 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67628 Tested-by:
-
Richard Haeser authored
Updated styling and javascript to restore styling of the localization wizard after the update to bootstrap 5. Resolves: #93408 Releases: master Change-Id: I6f3dc03af943e3eae240c84a218e8b72dcb8d276 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67627 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Andreas Fernandez authored
This patch adds the TypeScript declaration for the sortablejs library. Since the imported module has a different naming, the PageRenderer needs both the new module name ("sortablejs") and the old name ("Sortable") as this would be a breaking change, otherwise. In the master patch, the old module name has been declared deprecated. Resolves: #93454 Releases: master, 10.4 Change-Id: Ia8cc7bb4fb57bc7d55aa3601d6ccd1bfe6e0b54d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67658 Tested-by: -
Ralf Zimmermann authored
While updating bootstrap to 5.0.0-beta1 (https://review.typo3.org/c/Packages/TYPO3.CMS/+/67215) The 'a) Carousel "item" to "carousel-item" class migration' was done for the ext:backend 'Wizard' component but not for the 'MultiStepWizard' component. Therefore the 'new form' wizard will not work properly. This patch migrates the usage of 'item' classes to 'carousel-item' within the 'MultiStepWizard' component. Resolves: #93168 Releases: master Change-Id: I4c2a47147b668694c84ccda1dd01b7fe3e3d7808 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67579 Tested-by:
-
- Feb 05, 2021
-
-
Christian Kuhn authored
Change-Id: Ic60be2582afee8c8fe45e25cafb853285343265f Resolves: #93447 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67653 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Christian Kuhn authored
When a patch is pushed to gerrit, the gerrit-adapter middleware also synchronizes the master branch. This triggers two pipelines if patches have been merged meanwhile. Suppress the master pipeline run: All patches should have been tested already and a run for current master is done with the nightly tasks anyway. Change-Id: I78e9070588027d5fa10f11e63ab3e2677a225094 Resolves: #93438 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67646 Tested-by:
-
- Feb 04, 2021
-
-
Simon Gilli authored
This patch removes usages of mbstring functions which are missing in the fallback package symfony/polyfill-mbstring. Resolves: #93324 Releases: master, 10.4 Change-Id: I08c02e79caca4e9a253c1ac89b2ac0aa199e51a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67471 Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Jonas Eberle authored
Earlier, documentation erroneously stated that CSS could be moved to the bottom of <body>. This is not the case (and also not advisable). Instead, the documentation now reflects that CSS is always output in the <head>, with "priority"-assets in front of non-"priority". This also rephrases HTTP/2 information and adds cross-references to the ViewHelper documentation. Rendered output: https://docs.typo3.org/other/typo3/view-helper-reference/master/ en-us/typo3/fluid/latest/Asset/Css.html#priority Resolves: #91769 Releases: master, 10.4 Change-Id: I899e39eb1a85c23cc756d413ff8962c98564cee8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67512 Reviewed-by:
Julian Mair <julian.mair94@gmail.com> Reviewed-by:
André Kraus <info@andrekraus.com> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
-
Christian Kuhn authored
Resolves: #93434 Releases: master Change-Id: I9d6918f5bbfc6f12d09b1459405e6749f04b2c0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67641 Tested-by:
-
Benni Mack authored
This change aims to reduce the overhead by using jQuery in favor of Vanilla JS in various Tree-related JS files in preparation for a TypeScript migration. * SvgTree.js * SelectTree.js * PageTree.js * PageTreeToolbar.ts * PageTreeElement.ts * TreeToolbar.ts Resolves: #93427 Releases: master Change-Id: I57fc8e66415ea4ab6eaf690d925fbf7670d74284 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67583 Tested-by:
-
Benni Mack authored
This change migrate the TreeToolbar (used in FormEngine Category Tree for example) to TypeScript, removing effectively one RequireJS call and replacing it with a native TypeScript component. Removing the rest of the jQuery will be part of a separate effort. Resolves: #93432 Releases: master Change-Id: I3df66cd1c28d096c0f32982347dbd37c58834e4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67640 Tested-by:
-
Oliver Bartsch authored
When changing the stage of workspace records, e.g. "Publish to live", it's possible to send notification emails to inform further participants about the changes made. In case the mailer configuration is invalid, the whole process previously failed due to uncaught exceptions. These exceptions are now properly caught and logged as it's already done at other places in core. See #93297. Resolves: #93420 Releases: master, 10.4 Change-Id: I606b0459a34c0287b65d23a5a9f376866688cf95 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67636 Tested-by:
-
Benjamin Franzke authored
With the Symfony PR https://github.com/symfony/symfony/pull/39851 new depndency injection console.command tag properties are supported, which allow to inject the description and the hidden state into console commands. In order to maintain a consistent console.command DI tag syntax between Symfony and TYPO3 core, we now add forward compatibility for this change. Releases: master, 10.4 Resolves: #93425 Related: #93174 Change-Id: Ie5dac65deaede2099f2d337466295bd2815ce918 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67639 Tested-by:
-
- Feb 03, 2021
-
-
Georg Ringer authored
The help button belongs to the toolbar and not within the content area. Resolves: #93416 Releases: master Change-Id: Ie28f3f3fcedc53d4addbfcff8bd83576be8a4200 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67634 Tested-by:
-
Christian Kuhn authored
A first Build/gitlab-ci.yml for master. Core v10 and v9 will have dedicated patches. This specifies jobs executed via gitlab CI for master pre-merge "a patch has been pushed" and nightly builds. This uses a new testing infrastructure defined by https://gitlab.typo3.org/core-testing/testing-infrastructure to execute test suites. Resolves: #93406 Releases: master Change-Id: I377ac59478925b789f63871c8fa6c3b2d5b2a839 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67626 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
Oliver Bartsch authored
PageRenderer now omits empty type attributes also for scripts added through includeJSLibs or includeJSFooterlibs. Resolves: #93391 Releases: master, 10.4 Change-Id: Ic0b06b5ba6f7001c29dd3b1904e7bc0ed48b07d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67630 Tested-by:
-
Benni Mack authored
In previous TYPO3 versions (until the Workspace module was refactored in TYPO3 v8) it was possible to manipulate the collapse / expand toggle via Signals (now PSR-14 event), for third-party records with a lot of IRRE records. This change re-introduces the toggle for PSR-14 event listeners to respond to the JavaScript toggle / flag. Resolves: #93404 Releases: master, 10.4 Change-Id: I56408ac52b6491fe7ac79175ff0ab5017905d45d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67585 Tested-by:
-
- Feb 02, 2021
-
-
Benni Mack authored
With #89496 the ContextMenu got keyboard support added. However, the underlying code does still use only a click event to trigger the ContextMenu, which is now also manually triggered for keypress events. It was therefore not possible to differ between the three possible ways, the ContextMenu can be used: 1. Mouse click only 2. Mixed 2.1 Click on ContextMenu and navigate via keyboard 2.2 Access ContextMenu via keyboard and navigate via click 3. Keyboard only Therefore, we now check the mouse position. If it's NULL, the ContextMenu was openend via keyboard. Furthermore, we use a boolean flag, which helps the getPosition method to determine the correct position in mixed mode. Using mouse click will now behave like before. Using the keyboard will now always use the boundingRect for positioning. Resolves: #93362 Releases: master Change-Id: I1e2be756b85d0a2286524f0bdc9cca76208935d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67510 Tested-by:
-
Benjamin Franzke authored
In order to avoid loading an unnecessarily large complete d3 bundle, we now only pull in the small amount of modules we actually need. d3.transition() is replaced by the native web animation api, as d3-transition would pull in 4 more libraries (d3-color, d3-ease, d3-interpolate and d3-timer). d3-dispatch could easily be replaced by native CustomEvents, but it is a dependency of d3-drag and therefore shipped right now. This change reduces load size from 262K to 19K. yarn remove d3 yarn add d3-dispatch d3-drag d3-selection grunt build Releases: master Resolves: #93396 Change-Id: I1f4b58b967e2dcc57484863faafab3c2ec5d469a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67622 Tested-by:
-
- Feb 01, 2021
-
-
Christian Kuhn authored
Allow mysql & postgres for acceptance tests in addition to default mariadb: * Build/Script/runTests.sh -s acceptance -d mysql * Build/Script/runTests.sh -s acceptance -d postgres Change-Id: If65f1d8d8b4443107d655948ce87af4390d9681f Resolves: #93405 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67623 Tested-by:
-
Chris Müller authored
As the output of the widgets in the Dashboard is processed by htmlspecialchars(), the tags need to be stripped before to prevent showing the full tags as text. Resolves: #91289 Releases: master, 10.4 Change-Id: I0fc24ac6f3ceb298dd6acb8151c04e333bc1ec41 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64399 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Christian Kuhn authored
New images are to be found on official TYPO3 https://hub.docker.com/u/typo3 account. Most images are based on alpine instead of ubuntu and are thus significantly smaller than the old ones. For example, the php 7.4 image is now ~170MB instead of ~500MB. Image definitions are found and maintained at https://gitlab.typo3.org/core-testing/testing-infrastructure/ * typo3/core-testing-phpXY: Images based on the official PHP alpine builds, extended with commands and modules we need. * typo3/core-testing-js: Image based on official node image, with current yarn. * typo3/core-testing-js-chrome: As above, but with chrome for javascript unit testing. * typo3/core-testing-mssql2019: Image for microsoft sql server that includes a brutal hack to force sql server is fine if databases are located on a tmpfs (CI does that). * postgres/XY-alpine: Drop-in replacement using the -alpine version that is ~1/3 in size. Change-Id: I3dc57056052d3364ee925ba3a3216d95afe55f57 Resolves: #93403 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67619 Tested-by:
-
Benjamin Franzke authored
During the migration to d3 v6 in #93394 one event listener was forgotten to be updated for the changes callback signature in d3 v6. The caused the event coordinates, instead of the node coordinates to be used for drag-end calculation. Resolves: #93402 Related: #93394 Releases: master Change-Id: If39ac05d93ef34911a3ae6202e9cfdc8c9ab5ba3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67618 Tested-by:
-
Benni Mack authored
When a TYPO3 installation has `warning_email_addr` set, but the mailer configuration is wrong (e.g. cannot connect to mail server), then no login to backend or install tool is possible anymore. This change gracefully catches any exceptions, and logs the information that an email could not be sent anymore. Resolves: #93297 Releases: master, 10.4 Change-Id: I1b658740a64cf1d29b7842f0e2b49d69ce4d5e25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67453 Tested-by:
-
Christian Kuhn authored
* The file permission related LocalDriverTest basically test getPermissions() that is a set of native PHP methods that are hard to mock properly and don't need to be tested in our application. * The DateViewHelperTest relies on a working locale which fails on some environments and gives no error output if it fails. Resolves: #93400 Releases: master, 10.4, 9.5 Change-Id: I9521e8275d6a6461a902f07caee0444a73da8927 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67614 Tested-by:
-
Christian Kuhn authored
Some documentation related files contain a UTF-8 BOM while they shouldn't. Usually, script Build/Scripts/checkUtf8Bom.sh tests for this in CI. The script however fails in CI currently, since the PHP test container doesn't have gnu file shell command installed. Seems nobody saw the according error message and due to the xargs construct the test does not fail. Change-Id: I557c7ec84b61badfcd74a20063baf29eaf9f0959 Resolves: #93397 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67586 Tested-by:
-
