- Apr 14, 2023
-
-
Benjamin Kott authored
- Drop default override styling for <hr> without classes - Drop unused/obsolete scss variables - Drop variable `$text-color` in favor of `$body-color`. - Drop class `.text-muted` in favor of `.text-body-secondary` - Drop class `.form-inline` from usage in the backend - Icons are now displayed correctly next to text for login provider Note: Some spacings were hotfixed for now. It is planned to clean the `mb-*` classes up at a later point. Resolves: #100437 Releases: main Change-Id: I88f1d891a18acaba6a82ca498fef45b37117758e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78448 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com>
-
Christian Kuhn authored
This deprecates GeneralUtility::_GET() as last member of the get/post related family, next to GU::_POST(), GU::_GP() and GU::_GPmerged(): The request object has to be used instead. This patch is the end of a journey that took us various years. The last main one left is GeneralUtility::getIndpEnv(), but that's a story for TYPO3 v13. Resolves: #100596 Related: #99633 Related: #99615 Related: #100053 Related: #100584 Releases: main Change-Id: I591dd289289f5e4d7d35b74f853b067fbe975624 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78639 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benjamin Kott authored
There is no need to add a non-breaking space as a fallback if the label is empty for checkboxes. This results in unnecessary occupied space. We prefer just an empty string. To ensure we only occupy the space we need to, we are trimming unnecessary whitespaces from the final label. Resolves: #100594 Releases: main Change-Id: I941a197dc9e756c978b19dc8275449fcb1874c31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78637 Tested-by:
-
Oliver Hader authored
Deprecates form engine result property `additionalJavaScriptPost`, which was used by custom evaluation that provided inline JavaScript (`$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tce']['formevals']`). Resolves: #100587 Releases: main Change-Id: Ic68583a9cbd898acfd219c2848013d4442f9ab9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78636 Reviewed-by:
-
Christian Kuhn authored
ServerRequestFactory is essentially the only place with a legit access to $_GET super global. Avoid using GeneralUtility::_GET() here. Resolves: #100593 Releases: main Change-Id: I04bbf6f278a1581d667120aceeda94b9e1935ac4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78638 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Benjamin Kott authored
The special handling for a.disabled is obsolete, is was introduced to prevent the default link handling for the new content element wizard links while the component was not loaded. The wizard button is now a webcomponent and then handling and special styling is already handled through the boostrap css framework. The styling can be dropped. Resolves: #100592 Releases: main Change-Id: Icca02cc9f1cc84c19681149e764854fe426d103f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78635 Tested-by:
-
Benjamin Kott authored
The class .text-normal is not used at all and can be dropped. The class .text-pre-wrap was only used on .alert-message since it is make sense here to unify the behaviour the applied styles were moved to .alert-message directly. The class .text-wrap-allowed provided no benefits for the context it was rendered in and can be dropped. Resolves: #100591 Releases: main Change-Id: Ibf6562265da3010d24b5096a00eb1611d6f77279 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78634 Reviewed-by:
-
Christian Kuhn authored
The ext:install uri.action ViewHelper is - after various previous refactorings - only used within standalone install tool to create the main module links. The code can be simplified nowadays, avoiding the view helper entirely. The patch takes care of this and simplifies the templates by removing one partial entirely. Change-Id: I2d5a5f535973a1bac90362fa741795edf1ff0673 Resolves: #100590 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78632 Tested-by:
-
Benjamin Kott authored
This patch cleans up the a workaround for the Bootstrap CSS Framework 5.1 update where `.text-monospace` was dropped and replaced with `.font-monospace`. Resolves: #100589 Releases: main Change-Id: I8fbc01af2b6d6fe7c84a2e60e2a692ce62df0f8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78633 Tested-by:
-
Benjamin Kott authored
The Bootstrap CSS Framework changed the handling of media queries with version 4.6 but the core never adapted to this. We are now finishing the migration and dropping all `$screen-` variables. All media queries that are bound to bootstrap breakpoints are now using the provided mixins. In addition the unused `.dl-horizontal` was dropped. Resolves: #100588 Releases: main Change-Id: I2d47d62f4d110a290607708ebb496dc23249ee17 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78630 Reviewed-by:
-
Benjamin Kott authored
- Migrate checkboxes to form-check - Rebuild indention of rows - Add icons to buttons - Add sections to tabs - Add missing input classes Resolves: #100561 Releases: main Change-Id: If1c7fbb62b9541404090ad5cf849e3eba9da9643 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78596 Tested-by:
-
Andreas Fernandez authored
The multi selection actions available in the file list are wrapped by `.multi-record-selection-actions-wrapper` now to reserve their necessary space and to avoid layout shifts when using multi selection. Resolves: #100579 Releases: main Change-Id: I91cf6f50a06adff3f3227543c5cec5a44fa7529a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78618 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Oliver Bartsch authored
With the upgrade of symfony/expression-language 6.2 in TYPO3 v12.1, a new user-facing feature for TypoScript conditions was added, which only popped up recently. It is now possible to use [getTSFE()?.id == 13] which is handy, and should be documented. Resolves: #100586 Related: #99239 Releases: main Change-Id: Icba26809497684036a253130f56a022cc1a11166 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78629 Tested-by:
-
Christian Kuhn authored
GeneralUtility::linkThisScript() is one of the last usages that access $_GET() from globals. The patch removes a last usage and marks the method @deprecated. Resolves: #100584 Releases: main Change-Id: I9555ef7345fc001bcada367e32eeec1b7d00782a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78625 Tested-by:
-
Christian Kuhn authored
FormDataCompiler pollutes __construct(), making it impossible to be injected. The patch changes compile() to receive the FormDataGroup, which will free the constructor of this class in v13. Change-Id: If591a8785534318b60a1846559c86444ea7bf1e9 Resolves: #100581 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78619 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
André Buchmann authored
Resolves: #100580 Releases: main, 11.5 Change-Id: I10e4b21908a1b4649d7ab4b02c467af381017b2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78620 Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
In case the "getTSFE()" expression function is called in backend context - having no TSFE available-, the function returned "FALSE" since #100237. This however prevents to properly check such state in the expression itself. This is now fixed by returning "NULL" instead, as it's the case for similar functions, e.g. "site()" or "siteLanguage()"). This allows to properly use the null-safe operator ("?"). Example usage: `[getTSFE()?.id = 123]` Resolves: #100563 Related: #100237 Releases: main Change-Id: I9fbf4950df65dcd17be21a4c312b34e2548be698 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78622 Reviewed-by: -
Oliver Bartsch authored
Since it's valid to use a digit-only subject or title, those options are now properly cast to a string, preventing TypeError exceptions when passing them to type-hinted functions. This happened due to PHP converting digit-only strings to integers. Resolves: #100582 Releases: main, 11.5 Change-Id: I30c543b64f41b91ed64edabdb4bd2d9720f24e51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78624 Tested-by:
-
Christian Kuhn authored
The CI currently runs phpunit ^10 parallel to default ^9. phpunit 10.1 has just been released, bringing further cleanups and deprecations. Tests are green with 10.0, but fail with 10.1. We'll have to finish the transition to 10.0 until we can switch to 10.1. The patch adapts CI to stay with 10.0 for now. Resolves: #100585 Related: #100249 Releases: main Change-Id: Ic3b3b26108758ae15c0d8a7070677b454675a6ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78626 Tested-by:
-
- Apr 13, 2023
-
-
Benjamin Kott authored
Templates were streamlined to provide the same experience across the available modules. That means, record counter headlines, and icons, are now placed the same way. Template names were consolidated and are now sorting according to their responsibility, regardless that everything is pushed into the backend user controller. BackendUser -> BackendUser BackendUserGroup -> BackendUserGroup Filemount -> Filemount This structure was already present in the partials folder and was adapted also for the templates. Partials that would just move information around without a greater benefit was removed and information was moved to the main template. Bloating the amount partials only makes it harder to get an overview of the current structure and the template. Resolves: #100536 Releases: main Change-Id: I9f37831ff6ad4623151c162049bf2f1fdfd0a6a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78545 Tested-by:
-
Christian Kuhn authored
Some details of FormEngine still directly or indirectly access request data from globals. To change this, controllers should hand over the current request to FormEngine. The patch establishes this for all controllers and adds a (deprecated) fallback to $GLOBALS['TYPO3_REQUEST']. Change-Id: Ia7876a043cfa9cfa7a746433d927c5b29fd84561 Resolves: #100577 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78609 Reviewed-by:
-
Oliver Klee authored
- add parameter and return type declarations - use the same parameter names as in the mocked methods - use first-class callables - replace `isType()` calls with parameter type declarations … in the `willReturnCallback` callbacks in the unit tests of these extensions: - fluid - form - frontend - impexp - install - seo This improves code readability and type safety. Resolves: #100317 Releases: main Change-Id: Ib7a7e4786e1d6c18a6deb0917b4a1ef9d0dae7fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78272 Reviewed-by:
-
Christian Kuhn authored
The method is already indirectly tested with a class instance by other tests based on LocalDriverFilenameFilter fixture. Change-Id: Ie9ab46411e2485615f2733e73c51096dd65eff32 Resolves: #100578 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78617 Tested-by:
-
Benjamin Kott authored
In order to streamline the spacing it is necessary that all modules in the TYPO3 backend share the same base stylings. The page layout grid currently adds unintentional vertical spacing that is not present in any other component. This space is now removed and the margin added to the bottom is streamlined. Resolves: #100575 Releases: main Change-Id: I5a29bdbaf6f24c9ebc6957ac25025943f5490d74 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78614 Tested-by:
-
Jochen Roth authored
Currently, if a task was changed in the edit/add view the close button goes back to list view without letting the user know about potentially lost changes. This has been changed, by adding a confirmation modal when the close button was clicked but changes are not yet saved. Resolves: #100524 Releases: main Change-Id: I623a53047605bc85046cbd35a3e9a61c2e21b508 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78532 Tested-by:
-
Oliver Bartsch authored
To set a different navigation component for a sub module, "inheritNavigationComponentFromMainModule" must be disabled (setting it to FALSE in the configuration). Previously setting this property skipped the navigation component evaluation. This is now fixed. Resolves: #100572 Releases: main Change-Id: I3a9e753ba86c2bba2ba3c315caa0e2237b5f8ed7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78616 Tested-by:
-
Andreas Fernandez authored
Resolves: #100574 Related: #99739 Releases: main Change-Id: Ide714744621f9298d7d37d52421fb690ba2387c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78613 Tested-by:
-
Benni Mack authored
When using a formField with a property name that only consists of a number (e.g. a UID), Fluid will now allow this. Resolves: #100281 Releases: main, 11.5 Change-Id: Ief95b87af1025f65ac0db1ed0c64b6fcf9c40bbe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78294 Tested-by:
Marcus Schwemer <marcus@schwemer.de> Tested-by:
-
Benjamin Kott authored
There is not need for a special styling here, the components are fine as is. We are now preferring the defaults over the custom adjustments. In rare cases the alignment needed to be adjusted for the not missing default margin top of h2 and h3. These are now hotfixed with manual adjustments until we managed to solve the root problem with custom grids not providing enough space for the next element. Resolves: #100516 Releases: main Change-Id: Ib7354524a3487247cbb27064e50c38d2099b886e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78523 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Andreas Fernandez authored
With the migration to CKEditor 5, `config.contentsCss` was degraded to allow a single file only in CKEditor itself. This patch introduces a migration, converting `config.contentsCss` to an array. Documentation and examples are adjusted accordingly. Resolves: #99327 Releases: main Change-Id: I78f2cdc62d67daa714c483ac162edf27651d7dc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78592 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Christian Kuhn authored
A new patch level forces us to regenerate baseline. > composer req --dev phpstan/phpstan:^1.10.13 > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Change-Id: I7e616c60e448332ed10183665b772d892670480f Resolves: #100573 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78611 Reviewed-by:
-
- Apr 12, 2023
-
-
Benni Mack authored
When upgrading a project to TYPO3 v12, the new email link validator now checks for other properties than the email address such as "to" etc. However, in previous TYPO3 v11 installations, it was possible to enter a link like " benni@typo3.org" and it worked, the new link handler now fatals due a stricter parsing, which is now relaxed, as the value is now trimmed. Once editors modify all their links, it would work, however, that's not in scope for the LTS, and would require a Upgrade Wizard which also checks for HTML links. This way, it is much easier to overcome the problem by trimming the values. Resolves: #100568 Releases: main Change-Id: I65156826aa7944a7d4af9ae3c830012d228b12c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78603 Reviewed-by:
-
Oliver Bartsch authored
In case TypoScript conditions are evaluated in the backend, e.g. in extbase modules, usage of `getPageArguments()` might led to exceptions, because in backend context, no PageArguments object is available. This is now fixed and a corresponding example is adjusted. Resolves: #100567 Related: #100405 Releases: main Change-Id: Ibee0fa8b509b1552bdcf003ff154e70229215d08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78602 Reviewed-by:
-
Christian Kuhn authored
Protected property $removeKeysFromFinalResultArray is unused and can be removed. Also use constructor property promotion, private methods, and proper return types for this factory class. Resolves: #100570 Related: #70552 Related: #70585 Releases: main Change-Id: I4c91a360d783c69bf8e298282189026c650da85a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78608 Tested-by:
-
Benni Mack authored
This change splits up moving of a page into a "move_page" route / controller, and the "move_element" for tt_content elements, allowing to further adjust each of the views separately. Some link handling is fixed along the way, avoiding further broken uses of GU::linkThisScript(). Resolves: #100566 Releases: main Change-Id: Ie1caa655fb0f5adef0e759fb089f4416a8d672b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78601 Tested-by:
-
Oliver Hader authored
Resolves: #100558 Releases: main Change-Id: Icd5beb7c31e473494d8d91f76d7440a1c1724e09 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78605 Reviewed-by:
-
Christian Kuhn authored
Repositioning a content element to a different page using the list module "Re-position content element" view fails with a broken "backend-in-backend" link. The patch avoids linkThisScript() by handing the request around and creates the url using the UriBuilder instead. Note the construct is one of the few left over controllers that have not been refactored yet. This should happen in v13, together with re-thinking the view along the way. Resolves: #100564 Releases: main Change-Id: Ib912e878647ea778ecc941a185f73d9e835059a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78598 Reviewed-by:
-
Oliver Bartsch authored
Adding necessary typecast to prevent TypeError in DatabaseIntegrityController. Resolves: #100562 Related: #100521 Releases: main Change-Id: I0fc8a2afc13d338cd007231e37ca0b5df28eaa14 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78597 Reviewed-by:
-
Christian Kuhn authored
The "DB check" -> "Full search" module allows to show soft-deleted records. Such result rows have a button to "undelete" the record, and to undelete and then edit the record. Both links have a link back to the module which is broken ("backend-in-backend"). The patch removes the second button entirely: It should be enough for this seldom used functionality, to first undelete, re-render the search result, and then edit. The undelete button return url is fixed with the patch, even though it is questionable if "undelete" should be part of this module in the first place. Redefining and refactoring the module is however a task of further patches. Resolves: #100559 Releases: main Change-Id: Id5fe415eeb4ff26361d69fa7ecfd45c1878ca635 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78594 Tested-by: -
Andreas Fernandez authored
The change in #99669 introduced an update of the source element bound to the ckeditor instance. Unfortunately, this leads to a recursion loop when the "Source view" is active and the save action in FormEngine is invoked. Apparently, updating the source element is not required and is therefore removed again. Resolves: #100557 Related: #99669 Releases: main Change-Id: I84434bade2a2512f41a19dd56eda99ac5e8f41b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78593 Tested-by:
-
