- Jun 01, 2015
-
-
Andreas Allacher authored
In order to include ViewHelper namespaces with xmlns:*-attributes it is currently required to use e.g. a HTML tag to allow code-completion by an IDE. The tag itself will also be rendered. To avoid rending the tag, workarounds are necessary. One is to use sections, but this approach is counter-intuitive and has rendering overhead due to extra sections being used. Additionally it is not possible to use this workaround in layouts. This patch introduces new functionality to remove all xmlns-attributes which match ViewHelper namespaces. For HTML output, we introduce a new attribute, which will cause Fluid to remove the HTML-tag as well. The attributes is called >data-namespace-typo3-fluid="true"< Change-Id: I709d17da86cd79b7b3ba5c83b3f2bd6df8e2bd98 Releases: master Resolves: #66269 Reviewed-on: http://review.typo3.org/38472 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Daniel Schmidt <daniel@netz-basis.com> Tested-by:
Frank Nägler <typo3@naegler.net> Tested-by:
-
Sascha Egerer authored
In the TYPO3\CMS\Core\Resource\File object the logic to load metaDataProperties was implemented at multiple places but there is also a method _getMetaData() that handles this logic. The method _getMetaData() should be used instead of duplicating the logic at multiple places. Additionally some code is removed, which checks the metaDataProperties member for NULL values, which can never be the case. Resolves: #66878 Releases: master Change-Id: I01939a66aa58629f2c6dc08656647375460cc4e9 Reviewed-on: http://review.typo3.org/39429 Reviewed-by:
Michael Oehlhof <typo3@oehlhof.de> Tested-by:
-
Andreas Fernandez authored
Restructure the nested condition for the sake of readability. Releases: master, 6.2 Resolves: #67224 Change-Id: I25161348509245dee56b61f3a1f15d9bc778500b Reviewed-on: http://review.typo3.org/39863 Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Reviewed-by:
Mathias Schreiber <mathias.schreiber@wmdb.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Peter Niederlag authored
The workspace preview adds the GET parameter ADMCMD_noBeUser when requesting the frame for live preview. $GLOBALS[BE_USER] is unset in index_ts.php when seeing ADMCMD_noBeUser. In TypoScriptFrontendController fePreview=2 must not be set when ADMCMD_noBeUser parameter is present to prevent fatal errors on calling methods on a non-existent $GLOBALS[BE_USER] Releases: master, 6.2 Resolves: #30643 Change-Id: Idff7febcaaa8b87bd65a993b1860ad378e09b22f Reviewed-on: http://review.typo3.org/27834 Reviewed-by:
Lorenz Ulrich <lorenz.ulrich@visol.ch> Tested-by:
Markus Bucher <markusbucher@gmx.de> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
Andreas Fernandez authored
It wasn't possible to remove the search term used in the search in the Page and List module below the docheader, because it was checked for an empty submit button. The checks are removed now. Resolves: #66552 Releases: master Change-Id: I7113f5a00903326f9d12ee06b3510a376ff0f772 Reviewed-on: http://review.typo3.org/39743 Reviewed-by:
Philipp Gampe <philipp.gampe@typo3.org> Tested-by:
-
- May 30, 2015
-
-
Frans Saris authored
When a processed file already exists but the sys_file_processedfile record is deleted the whole processing task is executed again even if the file already exists. This change first checks if `targetFile` already exists and if so uses that file and marks the task as done. Currently this only works for `Local` file storages as the FAL API misses proper methods get a file by folder identifier and file name. When https://review.typo3.org/38479/ is merged a follow up is needed for master #67126. Resolves: #67095 Releases: master Change-Id: I352428ddaf1d2afe4bbf031992b484ade3635e4a Reviewed-on: http://review.typo3.org/39709 Reviewed-by:
-
Frank Nägler authored
Resolves: #67213 Releases: master Change-Id: I8ed7802f4e4e3d95ecb946231d11b46956ea4477 Reviewed-on: http://review.typo3.org/39835 Reviewed-by:
-
Frank Nägler authored
This patch remove the usage of self::class and make use of __CLASS__ in context of methods like makeInstance. As array key, we use the full qualified namespace followed by ::class. Resolves: #67211 Releases: master Change-Id: I60e5b33313a19cdef4705b04af892916923cc97c Reviewed-on: http://review.typo3.org/39825 Reviewed-by:
Helmut Hummel <helmut.hummel@typo3.org> Tested-by:
Susanne Moog <typo3@susannemoog.de> Tested-by:
-
Frans Saris authored
Due to multiple reasons (for instance target folder is not writable) the processing of a file can fail. This change prevents wrong data being saved in sys_file_processedfile when processing failed. Resolves: #67094 Releases: master, 6.2 Change-Id: I6051d503ba74629dc6493b7bac9f28bf320aeb66 Reviewed-on: http://review.typo3.org/39696 Reviewed-by:
-
Helmut Hummel authored
With #65528 t3skin was made a protected extension, but it was forgotten to add the extension to the class loading information array in composer.json Do this now, so that composer class loading is active for all protected core extensions. Releases: master Resolves: #67207 Change-Id: I9138d84f715c4e372763a5f17ef40f2a176cae10 Reviewed-on: http://review.typo3.org/39817 Reviewed-by:
-
- May 29, 2015
-
-
Daniel Goerz authored
The option showLogoutFormAfterLogin in the FeLogin FlexForm actually disables all redirect configuration on login. This patch reflects that behavior by adjusting its label to better describe what it actually does. Since the redirect is turned off if showLogoutFormAfterLogin is set the FrontendLoginController is also prevented from gathering redirect URLs in the first place. Change-Id: I0be9d166e67dd055d6057e841d9fd5509ed1e8a7 Resolves: #67115 Releases: master Reviewed-on: http://review.typo3.org/39671 Reviewed-by:
-
Francois Suter authored
Since the refactoring of typolink, one wrong parameter is passed to registered linkhandler hooks. This patch restores the right parameter. Resolves: #67199 Releases: master Change-Id: I781c00abc015cc38c0c51fbb84d5063b887c72cc Reviewed-on: http://review.typo3.org/39797 Reviewed-by:
Benjamin Mack <benni@typo3.org> Reviewed-by:
-
Frans Saris authored
In old situation the full path to of the folder was shown. With #64759 only the accessible part is shown. The logic to determine what the root is of the 'current' filemount is not suitable for this and will always return the root path of the first filemount within the storage. This could result in a wrong root identifier. This patch fixes the output of the readable path to the full path by using the real storage root instead of the storage root defined by the filemount. Resolves: #67148 Related: #64759 Releases: master, 6.2 Change-Id: Ie00fa2dc7d3833f798c5a2913bb9674b2b15b6e7 Reviewed-on: http://review.typo3.org/39767 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
-
Markus Klein authored
Resolves: #67071 Releases: master, 6.2 Change-Id: I1320833f0f7cfd852ca8ba458fa9367cb3b16ea0 Reviewed-on: http://review.typo3.org/39656 Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
Alexander Opitz authored
With PHP 7 the string 0x0 isn't any longer a numeric, so the test fails. But the test itself makes no sense and is removed. Resolves: #65320 Releases: master, 6.2 Change-Id: Id7569dfb859ecee7c85c595640515781b1423614 Reviewed-on: http://review.typo3.org/39745 Reviewed-by:
-
- May 28, 2015
-
-
Christian Kuhn authored
Method isEnabled() always returns TRUE since the checked property is protected and never reset to something else. It is unlikely that an extending class changes this method. isEnabled() is deprecated now. Resolves: #67171 Releases: master Change-Id: Ia23163a3d36f797ea9e776663057592ce12f6a1f Reviewed-on: http://review.typo3.org/39762 Reviewed-by:
-
- May 27, 2015
-
-
Frank Nägler authored
Resolves: #67159 Releases: master Change-Id: Ia17a3a52914b7acaab47b0d1bb84395a7d3fa917 Reviewed-on: http://review.typo3.org/39760 Reviewed-by:
-
Andreas Fernandez authored
Re-add the "select all" toggle to select all records on a page. The action buttons are moved to the right to match the common style of the backend. Resolves: #66941 Releases: master Change-Id: I17cf35bcc9a0c48a4df26d9c0753a80a07a11f83 Reviewed-on: http://review.typo3.org/39742 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Morton Jonuschat authored
This is a follow up fix for #66801 which hides too many users as an underscore (_) is a wildcard for a single char in SQL LIKE queries. It also ensures proper quoting of the string value to be compatible with databases that enforce proper query syntax. Resolves: #67154 Resolves: #67093 Related: #66801 Releases: master Change-Id: If0b78cd4e66c3420c832ad98aa5717034f619639 Reviewed-on: http://review.typo3.org/39754 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de> Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- May 26, 2015
-
-
Andreas Fernandez authored
Extend the exception message to hint to the action of the controller that misses a required argument. Resolves: #67139 Releases: master, 6.2 Change-Id: I70a256d73545ad90852fd1165f2fde127ac12441 Reviewed-on: http://review.typo3.org/39737 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Markus Klein authored
The change #24250 introduced a strict comparison without ensuring proper data types on both sides of the comparison. Add the missing int-cast in \TYPO3\CMS\Backend\Tree\Pagetree\Commands Resolves: #67138 Releases: master,6.2 Change-Id: I51dc33fd64a6d42963237ac49e0385c2abf66b71 Reviewed-on: http://review.typo3.org/39727 Reviewed-by:
-
- May 25, 2015
-
-
Markus Klein authored
The issue #58701 introduced the functionality to fetch suggestions defined in composer.json or ext_emconf.php into the Package class. A copy and paste error causes the loading of the suggestions to actually fail, so those never reach the DependencyResolver. This patch fixes the tiny mistake and thus ensures that suggestions really influence the loading order of extensions. Resolves: #51069 Releases: master, 6.2 Change-Id: Ib12e7f91f49c0b2bda56fdb4394a604e322b741c Reviewed-on: http://review.typo3.org/39692 Reviewed-by:
-
Morton Jonuschat authored
Without calling initialize() on the DatabaseConnection object the DBAL the resulting connection configuration will default to the "native" driver type (MySQL) which results in an error as there is no MySQL server to contact with the given connection parameters. Resolves: #67066 Releases: master, 6.2 Change-Id: Id5d70a122dcca806ee1122cecacad0c8aef27547 Reviewed-on: http://review.typo3.org/39636 Reviewed-by:
-
- May 24, 2015
-
-
Markus Klein authored
Calling the addTypoScript() method with last parameter set to 'defaultContentRendering' must not add the TypoScript twice. Resolves: #67116 Releases: master, 6.2 Change-Id: I3161c62ac0ab25369fabc3f8163e5d92356aa0ca Reviewed-on: http://review.typo3.org/39680 Reviewed-by:
-
- May 22, 2015
-
-
Christian Kuhn authored
* Extract the AccessibleProxy to an own file to get rid of an evil eval() and make the class smarter for IDE's * Greenify as much as possible for PhpStorm Change-Id: I851e5e9832633bf2308e50d9d8bce13f6657119d Resolves: #67113 Releases: master Reviewed-on: http://review.typo3.org/39665 Reviewed-by:
-
Christian Kuhn authored
Using typo3conf/extTables.php for TCA overrides is bad practice. Nowadays, stuff like that should reside in an extension that uses Configuration/TCA/Overrides. The patch deprecates the according parameters and logs if an instance still has an typo3conf/extTables.php file. The functionality within lowlevel "Configuration" backend module to write overrides to this file is removed. Change-Id: I648b985de4636c6af2cfb50bf8e106c472cb0fee Releases: master Resolves: #65344 Reviewed-on: http://review.typo3.org/37235 Reviewed-by:
-
Christian Kuhn authored
Use Configuration/TCA instead of TCA registration in ext_tables.php Resolves: #67110 Releases: master Change-Id: I86545f3adcc58c54d74c2ae15cb7a5e1fda043ce Reviewed-on: http://review.typo3.org/39663 Reviewed-by:
-
Sebastian Michaelsen authored
The field name is read from the wrong array key, resulting in a broken flexform. Resolves: #67105 Releases: master Change-Id: I64c7d1f2dfc6bf2338eaa1f1e4195dd5f139dbc8 Reviewed-on: http://review.typo3.org/39658 Reviewed-by:
-
- May 21, 2015
-
-
Benjamin Mack authored
Fix a bug in the recent Package Management refactoring resulting in Package instances only allowed if they contain an ext_emconf.php file. This basically disallows any third-party code installed inside Packages/ due to checking if an ext_emconf.php is present before checking for a composer file. Resolves: #67060 Releases: master Change-Id: I1bec43faafc0c073da52c3bbb1945f47f6864930 Reviewed-on: http://review.typo3.org/39632 Reviewed-by:
-
Markus Klösges authored
Thumbnails should not upscale images, therefore we check for the original size against thumbnail size. If original size is 0 (as for pdf-Files) this leads to not generating thumbnails for those files. Now checking original width/height against 0 to prevent this and generate thumbs for those files again. Resolves: #66679 Related: #66270 Releases: master, 6.2 Change-Id: I5823142a6be19e6068fea358027dc808f5fd3185 Reviewed-on: http://review.typo3.org/39077 Tested-by:
Markus Klösges <mkloesges@gmx.de> Reviewed-by:
Frans Saris <franssaris@gmail.com> Tested-by:
-
Nicole Cordes authored
If you register a module in main module "file" an error is thrown because the ModuleRunner checks page access for the variable "id". In any file module the id is a FAL identifier which can't be converted to an integer value and the check fails. This patch adds a limitation to the ModuleRunner to check page access only if the id can be interpreted as integer value. Releases: master, 6.2 Resolves: #67079 Change-Id: Iba44499b9b13172818aee48aefb01d102f810285 Reviewed-on: http://review.typo3.org/39648 Reviewed-by:
Markus Sommer <markussom@posteo.de> Tested-by:
-
Patrick Broens authored
The content object FLUIDTEMPLATE is extended with `dataProcessing`. With this setting you can add full namespace class references, which can manipulate the $data variable of the current rendered content object, like tt_content or page, before assigning this variable to the view. Change-Id: I757db37d86e1cf907de0116c3c63effc5270a3c1 Resolves: #66907 Releases: master Reviewed-on: http://review.typo3.org/39519 Reviewed-by:
-
Benjamin Mack authored
Due to strict warnings it is not possible to use media content elements anymore and add a simple youtube video, as a fatal is thrown here. The change modifies the array check to be stricter. Resolves: #67074 Releases: master Change-Id: Ib2dfe78b39e00863b3995b7412333b0260064873 Reviewed-on: http://review.typo3.org/39645 Reviewed-by:
Sebastian Michaelsen <michaelsen@t3seo.de> Tested-by:
Cedric Ziel <cedric@cedric-ziel.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Kuhn authored
The change does not play well with a symlinked core and is reverted for now. This reverts commit e6474fe5. Change-Id: I74ddc970a20d34a4d105a91cbdd5f12486c9568b Releases: master Reverts: #67076 Reviewed-on: http://review.typo3.org/39649 Reviewed-by:
-
Christian Kuhn authored
With the grunt integration a Build/ directory on repository root level was introduced. Out test infrastructure currently relies on a second Build/ folder located in typo3/sysext/core/. The patch moves all files from the core Build directory to the new global one and adapts paths. As benefit, paths are shorter and easier to find and remember now. This patch is breaking for test environments and extensions that rely on the recommended core test infrastructure for unit and functional tests. A typical test run now should look like: bin/phpunit -c Build/UnitTests.xml Change-Id: I9d87a566835f5849ce1e0e22d922d24c4b46ff31 Releases: master Resolves: #67076 Reviewed-on: http://review.typo3.org/39647 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Benjamin Mack authored
There is some leftover, never-called code in a regular TYPO3 instance regarding the old uc->classicPageEditMode option and its companion functionality in EditDocumentController->editRegularContentFromId which has been marked for deprecation. Resolves: #66905 Releases: master Change-Id: I0a428e411b9d7a0a646c7356d773a369c9397dde Reviewed-on: http://review.typo3.org/39474 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- May 20, 2015
-
-
Wouter Wolters authored
Resolves: #67065 Releases: master Change-Id: Iff8ece078dc612c362b3e291da466b29250c8cb1 Reviewed-on: http://review.typo3.org/39634 Reviewed-by:
-
Christian Weiske authored
We have to use the name and cannot rely on the identifier, since they can be random UUID values. This also fixes a wrong folder name in the paste confirm message. Change-Id: I092efdc5b666c9010717136bc063b155479eadab Resolves: #64759 Releases: master, 6.2 Reviewed-on: http://review.typo3.org/38763 Reviewed-by:
Christian Weiske <typo3@cweiske.de> Tested-by:
-
Andreas Allacher authored
The current behaviour for maxLevels with treeConfig is incorrect. Currently if one uses maxLevels 0, instead of only seeing the root category, one actually is presented of nodes up to level 2 (if one would specify the levels in nonSelectableLevels). With maxLevels 1 it is already up to level 3. Of course, maxLevels 0 should only display the root level, maxLevels 1 only the first child nodes. Also increased default levelMaximum to 4, in order to ensure old non configured trees are still behaving as intended. Change-Id: Ic1565e39abad01599dd67bbb05b0ce9fa7161af4 Resolves: #65304 Releases: master Reviewed-on: http://review.typo3.org/37196 Reviewed-by:
-
Benjamin Mack authored
Increase the maxitems value to 50 to allow more values for bigger sites. Releases: master Resolves: #59523 Change-Id: Ie25974844bf7ce9f0b7995169964748872eb3f1a Reviewed-on: http://review.typo3.org/39532 Reviewed-by:
-
