- Oct 30, 2023
-
-
Christian Kuhn authored
Minor CGL streamlinings from latest php-cs-fixer. > composer req --dev friendsofphp/php-cs-fixer:^3.37.1 > Build/Scripts/runTests.sh -s cgl Resolves: #102285 Releases: main, 12.4, 11.5 Change-Id: I0cc1fe3c0f81f62a49df00d62d57ef3c593c57df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81609 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Torben Hansen authored
Several classes in ext:install do not use constructor property promotion. This change introduces constructor property promotion where suitable. Resolves: #102281 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: Icf857a65d8562bcab4ebff8638e47dbf2031d72a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81606 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
- Oct 27, 2023
-
-
Christian Kuhn authored
The patch moves the two internal classes into the same namespace TYPO3\CMS\Core\Configuration\Tca. A factory is being prepared with another patch and will become a third class in this namespace. Resolves: #102276 Releases: main Change-Id: I6fda4ce0cd65b3664a28c7a35c48f6a973da8433 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81601 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Christian Kuhn authored
Having the TCA migration & preparation of single FlexForm fields within resolveFileDirectives() which is supposed to only resolve sheet sub files is confusing. It should be an own method. Resolves: #102266 Releases: main Change-Id: I7337d1454824a96ef71f2d14185fcfb48ae22547 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81591 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Christian Kuhn authored
With #99756, migrating DS in FlexForms has (indirectly) been added to parseDataStructureByIdentifier(), so any DS is "clean" afterwards. FormEngine related ajax controllers trigger this when a data structure identifier is supplied. Calling this a second time in FormEngine TcaFlexPrepare does not make sense and is removed now. This allows us to protect that internal method. Resolves: #102265 Related: #99756 Releases: main Change-Id: I4097cf350457212a4551634cc10d314091f3fe7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81590 Tested-by:
-
Thomas Hohn authored
Deprecate DuplicationBehavior class and add a new native backed enum TYPO3\CMS\Core\Resource\Enum\DuplicationBehavior as a replacement. Resolves: #101151 Related: #101294 Releases: main Change-Id: I05386f7558a4a18cee05ca3b145f9b39fb2e300d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79568 Reviewed-by:
-
Chris Müller authored
The colors configuration defines "darkgray". However, the palettes definition used "darkgrey". Additionally, use "page TSconfig" instead of PageTS and add a caption to the code block. Resolves: #102127 Related: #101843 Releases: main Change-Id: I5421dc21905869efcb662e806b554357d6ce4ca4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81384 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Andreas Fernandez authored
* Removed referencing potentially hidden fields as "main field", lowering congnitive load * Dropped most usage of jQuery * Deprecated remaining jQuery usages, potentially used by 3rd party extensions * Removed copying validator configuration in "human readable field" * Event `t3-formengine-postfieldvalidation` is dispatched on the form, but bubbles up to `document` * Try to avoid double dispatching the `change` event Resolves: #101912 Releases: main Change-Id: Ia4b8e4b2189525cd2c3dc0acb36bbee0e3665d11 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80925 Tested-by:
-
Garvin Hicking authored
The `EXT:felogin/Classes/Service/RecoveryService.php` makes use of the local $uriBuilder instance building links, however it does not `reset()` it's state before building a URL. It seems this only creates an issue when used in conjunction with `EXT:vhs` (possibly due to adapted fluid/object caching behavior?). Fixing this by resetting the instance as recommended via https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ExtensionArchitecture/Extbase/Reference/UriBuilder.html should take care of this, even though uriBuilder should be a singleton only operating within the scope of a single ActionController. Resolves: #102203 Releases: main, 12.4, 11.5 Change-Id: Idb6089c4b43b6d3352fbbbbeedfa63770959def0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81578 Tested-by:
-
- Oct 26, 2023
-
-
Bastien Lutz authored
CLI commands had to be registered in the extensions `Services.yaml` file with the `console.command` tag. This change enables automatic cli command registration with the tag `console.command` by using the existing `\Symfony\Component\Console\Attribute\AsCommand` symfony PHP attribute. Thus providing an additional and simpler way, without deprecating or enforcing to change already existing registrations. Resolves: #101567 Releases: main, 12.4 Change-Id: I24edf5ad2291ab5b26e3023f13ef490b88dcc98c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80404 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
-
Christian Kuhn authored
Resolves: #101543 Related: #71723 Releases: main, 12.4 Change-Id: If8bc3523b0f3ca1e589baf51f222c2ae476c0376 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81582 Tested-by:
-
Nikita Hovratov authored
EXT:form automatically generates FlexForm for form finisher overrides based on YAML configuration in the `finishersDefinition.FormEngine` sub-array. Since the removal of `TCEforms` for FlexForm (#97126), the regex to match valid FlexForm fields did a "too good" job and also added fields from section containers. These were guarded by a negative lookbehind `(?>!\.TCEforms)`. Note the dot. This basically means ignore anything, which has something else before TCEforms (=sections). This was mostly fixed with #101050 by ignoring anything with a dot before `config.type`. Sadly, this also ignored FlexForm identifiers with dots in their name. In this case `translation.language.config.type`. This whole regex thing is a mess and partially was the reason these issues started as soon as something changed in the FlexForm syntax. Now, in order to fix this, section containers are kicked from the array with plain old PHP logic. This way we don't need to come up with a super smart regex like "anything that ends with `config.type` but not preceded by `_arrayContainer`". I tried and I failed. Resolves: #102250 Related: #101050 Related: #97126 Releases: main, 12.4 Change-Id: I5549bdcfcda1b8dc014c11933b140d5c671c36e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81581 Reviewed-by:
-
Christian Kuhn authored
This may be triggered by invalid FlexForm values that does not contain a 'data' key for whatever reason. Resolves: #100733 Releases: main, 12.4, 11.5 Change-Id: I96924d65af56fd7cf2bb2a97fd4591b3c81f934f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81584 Tested-by:
-
Oliver Hader authored
To identify whether a nonce values was actually used (consumed), `ConsumableNonce` instances are used, instead of `Nonce` objects. The new `ConsumableNonce` inherits from `ConsumableString`. As a result, the `<f:security.nonce>` view helper would increase the consumption counter. This is important for additional cache handling in the frontend rendering context. Resolves: #101751 Releases: main, 12.4 Change-Id: Iea147b0130e3d350f5913dc75f33af61c18e8af3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80235 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Soren Malling authored
See if a object is a instance of \Stringable aswell as a TypeInterface. TypeInterface implements the __toString method but objects coming from extension can rely on either implements \Stringable or have the __toString method Resolves: #102263 Releases: main, 12.4 Change-Id: I840492b0011b60abc3754f215695154c90b7e707 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81576 Reviewed-by:
-
Garvin Hicking authored
See the issue for an example snippet and original bug report on StackOverflow. Also updates the documentation to reflect dealing with issues like these. Resolves: #102130 Releases: main Change-Id: Ia682af40dfce4df1f259e7c7f688096d6de4d0f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81389 Tested-by:
-
Anja Leichsenring authored
Tables with TCA columns set to type="number" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema and removes own ext_tables.sql definitions having type=number. Resolves: #102237 Related: #101553 Releases: main Change-Id: I810ce11f731f1423aed82bd303565244525c94e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81532 Tested-by:
-
Oliver Hader authored
The new section "Content Security Policy Mutations" in the "Configuration" backend module shows the all available CSP scopes, the compiled CSP header value and all involved mutations in the order they are applied with their origins (static package configuration or dynamic resolution item). Resolves: #102017 Releases: main, 12.4 Change-Id: Id6d5f769400b340698fb463ad21f5e8af29a784a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81180 Tested-by:
-
Oliver Hader authored
MutationMode::Extend has some ambiguity when being invoked multiple times on modified ancestor source collections. This change introduces the new MutationMode::InheritOnce, MutationMode::InheritAgain and MutationMode::Append. The implicit behavior of MutationMode::Extend changes from the combination of MutationMode::InheritAgain + MutationMode::Append to MutationMode::InheritOnce + MutationMode::Append to avoid side effects with more configurations modifying the policy. Static mutations loaded from ContentSecurityPolicies.php are ordered accordoring to the packages dependency hierarchy. That is the reason, the configuration from ext:core had to be moved to both ext:backend and ext:frontend. Resolves: #101797 Releases: main, 12.4 Change-Id: I7ab8e9d3f5635783d026f585f15c27ff62189959 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80756 Tested-by:
-
- Oct 25, 2023
-
-
Christian Kuhn authored
The "notify" soft reference parser fits no apparent use case. It is removed. Resolves: #102260 Releases: main Change-Id: Ibfee513389da421f64e0f8de087513f19997a7d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81572 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christian Kuhn authored
A rewrite of the internal handling: * The class is now practically a stateless service, the two left over properties are 'stable' until TCA changes within an instance usage, which is not the case in current usages. * Extraction of setReferenceValue() and it's detail methods to CLI command 'cleanup:missingrelations'. That command needs an overhaul with another patch, but it's not more broken than before. * Public methods at the start of the file. * Clean method signature types. * Disentanglement of code details, removing various detail methods to simplify reading. A method with eleven arguments has been inlined. * Happy phpstan along the way. The entire thing should be much easier to grasp and follow now. Note getRelations() still returns a rather opaque array of weird entries which can't be resolved without additionally touching MissingRelationsCommand and ext:impexp. This should be streamlined with further patches. Resolves: #102258 Releases: main Change-Id: I77c78714c074cfed7d16bcb22347e62d9e9a4355 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81543 Reviewed-by:
-
Andreas Kienast authored
FormEngine UI has a rather inconsistent markup. Fields within Flexforms may appear within another `div` container, causing issues when trying to mark an erroneous field as such. To solve this short-termed, additional CSS rules are added to cover such cases. In the long run, the FormEngine markup must get consolidated. Resolves: #102252 Releases: main, 12.4 Change-Id: I671fd8fe2edbd2b3592e7f4e1f205544a074ec51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81545 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Thomas Hohn <tho@gyldendal.dk>
-
Andreas Kienast authored
The module `@typo3/core/ajax/input-transformer` is used to automatically prepare payload to be sent via AJAX. One sub-routine converts nested objects into a flat list recursively. However, the check for objects was not sufficient as, in JavaScript, `null` is also of type `object`. This patch hardens the check to consider non-null values only. Resolves: #102256 Releases: main, 12.4 Change-Id: I6cf902f6a4fa045a4f8304059607f8a359a97186 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81550 Tested-by:
Francois Suter <sutfra@gmail.com> Reviewed-by:
-
Andreas Kienast authored
The `SuggestWizardController` makes use of constructor DI. However, necessary configuration was missing, breaking the controller. This patch adds the necessary `#[Controller]` attribute, preparing the controller for the dependency container. Resolves: #102259 Releases: main Change-Id: If88475d5b719c9c747d74d47f35b9afd6fe1068f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81551 Tested-by:
-
Benjamin Franzke authored
And therefore maps into a JSON array instead of an object, preventing errors when CKEditor5 operated on the resulting confguration. Resolves: #102230 Resolves: #102245 Related: #102099 Releases: main, 12.4 Change-Id: Ia20e5927b10bbb56763e3fc01cc30c8c4d0252c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81552 Reviewed-by:
-
Christian Kuhn authored
ReferenceIndex no longer returns arrays having 'type=file' set for a relation type, nor arrays having 'file' set for 'flexFormRels' since the removal of internal_type=file with #87428. Only softref parsers can still return 'file' type soft references. The patch removes obsolete code from ext:impexp. Resolves: #102253 Related: #87428 Releases: main Change-Id: I1d8e48e36363ab4985347d1da91de5e30bc86d97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81546 Tested-by:
-
Benjamin Franzke authored
Enable all current PER-CS2.0 rules in order to reflect our current state of coding style. This was missed in #102240 because pre merge didn't perform a full CGL run when @PER was switched to @PER-CS1.0. Resolves: #102247 Related: #102240 Releases: main, 12.4, 11.5 Change-Id: I0e1c833ad99c4e06767dee8a2c4bcb2bdee6eb68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81541 Tested-by:
-
- Oct 24, 2023
-
-
Benjamin Franzke authored
PER-CS2.0 was added as clone of PER-CS1.0 in php-cs-fixer v3.27 in order to implement the new rules that are defined in PER Coding Style 2.0 [1]. The alias PER already points to PER-CS2.0 although the current set of rules are not implemented yet. [2] There is only one rule (single_line_empty_body) that is done by now and more will follow, so we rather pin to PER-CS1.0 for now (and enable single_line_empty_body which we already migrated to) in order to prevent having coding style changes with every php-cs-fixer raise. We rather wait until the 2.0 preset has been finished and is on par with the upstream php-fig definitions and then switch with one change. [1] https://www.php-fig.org/per/coding-style/ [2] https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/7247 Resolves: #102240 Related: #102236 Releases: main, 12.4, 11.5 Change-Id: I33377e4e5016f1e5cc8ab08a9e71a933dcd41d93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81534 Reviewed-by:
-
Till Hörner authored
Since #99739 the foreign record selector for type select no longer shows the record labels but the uids. Change it to show the label again. Resolves: #102244 Related: #99739 Releases: main, 12.4 Change-Id: I91640769eb76cdba42e781588a68aa449cca70c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81536 Tested-by:
-
Anja Leichsenring authored
The test showcased an outdated concept of custom eval implementation. The showcase has been removed to promote more modern approaches, now the test fails and is removed, too. This reveals a cross dependency between acceptance tests, which is fixed along the way by combining two test files. Resolves: #102238 Releases: main Change-Id: I91c437f31399a26f9ce052024a004f55dc6348dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81533 Tested-by:
-
Christian Kuhn authored
It's time to update to latest changes of php-cs-fixer to align with current community rules. This brings a rather huge series of changes, main changes due to single_line_empty_body rule which now formats empty class and method body curly braces into a single line, plus changes from function_declaration rule which tends to avoid more whitespaces. The change has a slight impact on phpstan, we regenerate baseline. To reduce backport headaches, this change is backported to v12 and v11. > composer req --dev friendsofphp/php-cs-fixer:^3.35.1 > Build/Scripts/runTests.sh -s cgl > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #102236 Releases: main, 12.4, 11.5 Change-Id: Iea45b10667951672b2194033216c49f580799f55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81512 Tested-by:
-
- Oct 23, 2023
-
-
Jasmina Ließmann authored
The "Limit history to this record" link in the record history module is broken and always uses the same link value. With this patch the correct value will be used. Resolves: #102234 Releases: main, 12.4 Change-Id: Iaf013b82746b03892d295ed8b8a67c3f8c63fbc6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81510 Tested-by:
-
Christian Kuhn authored
When a page with a content element that has images assigned is copied in workspaces, a PHP array access error is raised since sys_file_reference TCA has no sortby ctrl. Add an appropriate null fallback. Resolves: #102231 Releases: main, 12.4, 11.5 Change-Id: I453a612a62a359156c8be2e087d1d121f1b9c3ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81509 Tested-by:
-
Christian Kuhn authored
With various pre-patches being done, the ugly traverser method FlexFormTools->traverseFlexFormXMLData() is obsolete. This final patch to FlexFormTools removes that method and its helper from the codebase. We're actively removing the method and skip a deprecation phase in this case: First, the method is low level and usually not used by extension developers. Extensions like the TemplaVoila forks have their own implementations of FlexFormTools already, their migration is straight forward. Secondly, we probably want to further simplify FlexForm related details, maintaining the old traverser would be a hindrance since it's so hard to follow. FlexFormTools is now a stateless service. The patch comes with a .rst file mentioning the changes, and documents some details from previous patches. Resolves: #102229 Related: #102218 Related: #102212 Releases: main Change-Id: I866e8c92c07753b8c53ae3d8233c55d35614cb85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81504 Tested-by:
-
Uwe Trotzek authored
This change transforms the processed record of FlexForms into a human-readable format. This is especially useful when comparing changes in the history module or the workspaces diff view. The diff needs to be formatted with line breaks and tabs as the output is passed through "htmlspecialchars" before it will be displayed. The white-space css setting needs to be changed to "pre-wrap", because this is the only setting where line breaks and tabs are kept and the text will still be word-wrapped. Resolves: #91148 Releases: main, 12.4 Change-Id: I189555f459a3a96594e9c708b4ee71c908efd970 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75117 Tested-by:
-
Christoph Lehmann authored
The PreviewSimulator might turn on the includeHiddenPages flag in VisibilityAspect due to hidden pages in current the rootline. The flag is now taken into account when generating the rootline cache identifier and thus the rootline cache doesn't need to get flushed. Resolves: #102205 Related: #17599 Releases: main, 12.4 Change-Id: If5246c9297d00071852968d48801d35f4060d110 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81484 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Benni Mack authored
The introduction of the ImageProcessing object made it possible to refactor and clean up further code within TYPO3's Image processing lowlevel code. This change removes some previously added arguments and options such as the file extension, which needs to go into a separate resolver functionality. In the same effort, the logic and usage of the infamous $info array is reduced, and a drive-by fix for adding the quality parameter multiple times (happened in one of the previous refactorings) is added. Resolves: #102228 Releases: main Change-Id: Ifd7855236e73a225af402a359292f1256d591a5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81507 Reviewed-by:
-
Josef Glatz authored
This patch improves the readability of the record history view of an element which was edited in switchTo mode by showing the original user always on a new line. div tags are used instead of span tags, to reduce any dependency on bootstrap classes for displaying an element as display:block. Resolves: #102200 Related: #102091 Releases: main, 12.4 Change-Id: I873711d4be6651ff15ae82e0bd7cbc4c6bf16e26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81473 Reviewed-by:
-
Anja Leichsenring authored
After only records of table `sys_workspace_stage` can serve as entries for the `sys_workspace -> custom_stages` field, no dedicated definition of foreign_table_field is necessary in TCA. Removing it deletes one field in the database without other side effects. Resolves: #102227 Releases: main Change-Id: I3393a62f8d913760416bc5f06ae02aaf025cf863 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81506 Reviewed-by:
-
- Oct 22, 2023
-
-
Christian Kuhn authored
A simple TCA flex form definition in extensions simply uses the TCA 'ds' 'default' key to declare its data structure. tt_content is a bit more complex here, it uses 'ds' with a comma separated match list of two fields (ctype,list_type), defined by a 'ds_pointerField' combination to look up 'ds' keys. This is typically shadowed away for extension developers using EMU::addPiFlexFormValue(). But there is more: 'ds_pointerField_searchParent', 'ds_pointerField_searchParent_subField' and 'ds_tableField': Those allow looking up the specific data structure of a flex form field by having the data structure stored in a different table, including tree traversal functionality. These three config options have been implemented for TemplaVoila back in the old days. In practice *nobody* uses these core features, even the templavoila extension forks don't use the core implementation since they come with xclass'es of FlexFormTools, or implement the events. To reduce complexity, this patch now removes handling of these three TCA options. Note we don't migrate the TCA definitions away to not add not needed headaches for extensions implementing functionality on top of it. They are just not handled in core anymore, handling can be continued by implementing the data structure related events. Resolves: #102224 Releases: main Change-Id: Idd896a6bca179393c32360952f88bafd63de4898 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81503 Tested-by:
-
