- Aug 16, 2024
-
-
Frank Naegler authored
playwright/axe iterates over a list of web pages and highlights accessibility issues. This tool is now applied as a CI job to the TYPO3 Backend where the main backend layout and modules are being tested. Usage: # CI mode Build/Scripts/runTests.sh -s accessibility # Run against local instance ACCESSIBILITY_BASE_URL=https://t3main.devbox.local/typo3 \ npm --prefix=Build run accessibility # Prepare CI mode, run locally (repeatable command will be printed) Build/Scripts/runTests.sh -s accessibility-prepare Commands executed: npm --prefix=Build install --save-dev \ @axe-core/playwright@4.9.1 \ @playwright/test@1.45.3 Resolves: #103283 Releases: main, 12.4 Change-Id: Ib1c74027eaacd2a225decd59406d79528f14635e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80557 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Chris Müller authored
First, breaking the <f:uri.resource> example into multiple lines makes it easier for users on small screens/browser width (or with larger font size) to get the relevant attribute without horizontal scrolling. Second, the relevant parts are now highlighted to spot the significant part faster. Resolves: #104640 Related: #99203 Releases: main Change-Id: Ia7719b9a59a7920bf88e7add37a433ec41c856c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85655 Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Aug 15, 2024
-
-
Christian Kuhn authored
Move FormPersistenceManager::FORM_DEFINITION_FILE_EXTENSION to FormPersistenceManagerInterface::FORM_DEFINITION_FILE_EXTENSION and use it. Resolves: #104637 Releases: main Change-Id: I96dc9aeeee396bc50a1fd70a2fbd002bffd05408 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85653 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Andreas Kienast authored
The package `devbridge-autocomplete` was removed in TYPO3 v12 (#98455), but it is still referenced in "External Libraries" in the "About" module. The reference is now removed. Resolves: #104632 Related: #98455 Releases: main, 12.4 Change-Id: I8032933f59f1fcf0acccc6baf30ac0515b441faa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85645 Reviewed-by:
-
Christian Kuhn authored
AbstractBackendController of ext:form does not do much, except it gets DI wrong and relies on the global initializeObject method, which is kinda ugly for stuff like this. The patch merges AbstractBackendController into the two ext:form backend controllers, which now extend extbase ActionController directly. The patch finishes DI of the two controllers and cleans up minor things like the usual "use less properties by handing over stuff directly" stuff. The existing tests receive a rewrite and are changed from unit to functional tests: This reduces mocking significantly and makes much more clear what is actually tested. The should be much more easy to maintain now. Resolves: #104634 Releases: main Change-Id: I2610a25023a3a1762d3ba6cabd116e1adfcca96b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85641 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Stefan Bürk authored
The Doctrine Team recently released minor version release `4.1.0` including a couple of bugfixes, internal changes and also new features [1]. The aforementioned internal changes introduces breaking stuff within internal implementation, for example the TYPO3 Database Analyzer stack enforcing adoption [2][3][4]. Sadly, it's not possible to provide backwards compatible code and thus minimum version raise is "absolutly" required. Doctrine DBAL 4.1.0 also includes new platform implementation for some database platforms and this change adds them as extend replacements to ensure working state with TYPO3 DB Analyzer. Note that previous TYPO3 v13.x composer instances needs to limit doctrine/dbal to 4.0.x on their own to avoid breaking behaviour. Used command(s): \ composer require --no-update --no-install \ -d typo3/sysext/redirects \ "doctrine/dbal":"^4.1" \ && composer require --no-update --no-install \ -d typo3/sysext/core \ "doctrine/dbal":"^4.1" \ && composer require --no-update --no-install \ -d typo3/sysext/install \ "doctrine/dbal":"^4.1" \ && composer require "doctrine/dbal":"^4.1" [1] https://github.com/doctrine/dbal/releases/tag/4.1.0 [2] https://github.com/doctrine/dbal/pull/6280 [3] https://github.com/doctrine/dbal/pull/6482 [4] https://github.com/doctrine/dbal/pull/6490 Resolves: #104628 Releases: main Change-Id: I53c86feed17abc6a90625e27fb135f606a57fc9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85620 Reviewed-by: -
Oliver Hader authored
Aims to combine disabling site-specific CSP with report-only mode later. This reverts commit acf70306. Reverts: #104549 Resolves: #104633 Releases: main, 12.4 Change-Id: I651f60d7b5cc24133801412c8f09b1efba98d3f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85646 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
The previous patch introduced ambiguities for allowed attributes for multiple HTML elements that were reliable and hard-coded in previous versions. This reverts commit cb5f8bb4. Resolves: #104622 Reverts: #104520 Releases: main, 12.4 Change-Id: Ib63cc4733944ad98830ee269baf13f1b15076ef5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85642 Tested-by:
-
- Aug 14, 2024
-
-
Christian Kuhn authored
Inject ext:form ConfigurationManagerInterface, not the implementation ConfigurationManager in the ext:form "Show Configuration" ProviderInterface feature for ext:lowlevel. Resolves: #104626 Releases: main Change-Id: I777e24e5aeb6a9738c207b0c0462f0ff71374703 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85637 Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
Christian Kuhn authored
* Slightly refactor YamlFileLoader to make it obvious it is a stateless service. Declare it readonly. * Inject YamlFileLoader in a couple of places and adapt tests to deal with this. * Refactor ext:form YamlSource to a readonly stateless serice as well, add some type hints and clean up some details. Adapt tests. Resolves: #104625 Releases: main Change-Id: Ib08c5f688df6bf6aae76f04ca88ef05fe23cb10e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85633 Tested-by:
-
Andreas Kienast authored
The page module rendered a lot excess CSS classes that are not used (anymore) and therefore are now removed. Resolves: #104620 Releases: main Change-Id: Ia836c7e330803952a2ae5923dd57df966cc0a28f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85626 Tested-by:
Thomas Hohn <tho@gyldendal.dk> Tested-by:
-
Christian Kuhn authored
Brings an internal change for better doctrine/dbal handling, and a feature to support readonly classes in getAccessibleMock(). > composer u typo3/testing-framework Resolves: #104623 Releases: main Change-Id: I6c3fe18c9de5de643a82e615cc0e5be9a0f7e5a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85635 Tested-by:
-
Lina Wolf authored
This patch adds a description on how to utilize site sets from `EXT:form` to the Integrator Quick start. Resolves: #104598 Releases: main Change-Id: Ia62620f5a911ef11092eb4699ed0c57acc863892 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85597 Tested-by:
Stefan Froemken <froemken@gmail.com>
-
Thomas Hohn authored
TYPO3 has a method to retrieve webmounts `BackendUserAuthentication::returnWebmounts()`. The method returns the uid's of the webmounts as an array of strings. A more suitable representation is an array of integers. A new method `BackendUserAuthentication::getWebmounts()` has been introduced with #104591 that returns a list of integers. With #104614 it is additionally ensured that the call to the method BackendUserAuthentication::getWebmounts() returns an unique list of webmounts. Superfluous calls to array_unique() can be removed. The patch deprecates `BackendUserAuthentication::returnWebmounts()`. Resolves: #104607 Related: #104591 Related: #104614 Releases: main Change-Id: Id9b870a85538a9aeb74de3034136c4e3076480ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85618 Reviewed-by:
-
Mathias Brodala authored
This is a mitigation of an issue introduced with #102291, where f:for now tends to iterate an empty string and crashes. Resolves: #104612 Related: #102291 Releases: main, 12.4 Change-Id: Id462532e732e421eac04c09b267b0f80ca522ea6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85616 Tested-by:
Tung Ngo <ngo@freyhauer.de> Reviewed-by:
-
Thomas Hohn authored
The method BackendUserAuthentication::getWebmounts() now returns an unique list of webmounts. Before the list could contain duplicates and it was the callers responsibility to remove these. Superfluous calls to array_unique() were removed since the uniquess is now guaranteed by BackendUserAuthentication::getWebmounts(). Resolves: #104614 Related: #104591 Related: #104607 Releases: main Change-Id: I9e4179378de9f0709e0dc100c30e7153f211ccb7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85623 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Nikita Hovratov authored
Since #102825 the table is available in the GridItem object. This can now be used to replace the string "tt_content" with "{item.table}" where possible. This way other record types can be rendered as grids and will automatically function the same as content elements. Resolves: #104593 Related: #102825 Releases: main, 12.4 Change-Id: I00b36327e9417532afdad8089ec28c802f0b448b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85587 Reviewed-by:Daniel Siepmann <coding@daniel-siepmann.de>
-
Andreas Kienast authored
When a user wants to move a content element via the Record List, the UI now respects the selected mode ("move" or "copy") by rendering a proper language label in the tooltip on the action button. Resolves: #104619 Releases: main, 12.4 Change-Id: Ib9334d86d4f268fc20f54111c90a21ed0f1194ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85625 Tested-by: -
Oliver Bartsch authored
This adds a new value object, containing the resolved parameters of a typolink. The object will be used as enriched value for TCA type "link" properties in the Record object. The enrichment will be added with #103581. Since this value is then passed to the view instead of the plain typolink string, the TypoLink ViewHelpers do also support the new object. Resolves: #104615 Related: #103581 Releases: main Change-Id: Ifbac6d44ed05d5d793b951b38229891d6b219eb4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85619 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
-
Chris Müller authored
Resolves: #104616 Related: #104114 Releases: main Change-Id: Ia2731c55d14e7d0912caa9724239eb041fa2a58e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85621 Tested-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
-
Oliver Hader authored
This change allows to disable CSP headers for a particular site configured in `sites/<my-site>/csp.yaml` by using the assignment `enable: false`. Resolves: #104549 Releases: main, 12.4 Change-Id: I9e17b5658610e5d47915a5e45ca6a33a870e8d76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85591 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Aug 13, 2024
-
-
Christian Kuhn authored
As last step for PHP 8.4 in CI, the "integration" tests switch from 8.3 to 8.4 in nightlies, while pre-merge are kept with 8.2. Resolves: #104613 Releases: main Change-Id: I8eeda8b5a24250f0776e52a889c8d1166ceb4f24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85617 Tested-by:
-
Christian Kuhn authored
The hack from #100607 is obsolete with latest versions and can be removed, the patch for 8.4 compat is kept. > composer req enshrined/svg-sanitize:^0.19.0 > composer req 'enshrined/svg-sanitize:^0.19.0' -d typo3/sysext/core --no-update Resolves: #104611 Related: #104604 Related: #103722 Related: #100607 Releases: main Change-Id: I6c9d7f38c86f8d4fdcc3bc6e534b8d4f241e974f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85615 Tested-by:
-
Thomas Hohn authored
The method BackendUserAuthentication::returnWebmounts() returns an array of strings. This triggers a type error when calling DatabaseIntegrityController::getTreeList() since this method now requires the mountpoint as an integer. In order to keep backwards compatibility a new method BackendUserAuthentication::getWebmounts() has been introduced, which returns an array of integers. Existing calls to returnWebmounts() have been replaced by calls to getWebmounts() and fixes by applying array_map(intval(...) on the result is now superfluous. A follow up issue has been created #104607 to deprecate method returnWebmounts() and to investigate if succesive calls to array_unique can be done in getWebmounts() and removed. Resolves: #104591 Related: #104607 Releases: main, 12.4 Change-Id: I78b2ac3ca891b4144c3b68fd44afb645b875fa6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85586 Reviewed-by:
-
Andreas Kienast authored
The `PreviewController` of EXT:workspaces registers some inline settings for use in JavaScript that are actually not used at all and are therefore removed now. Resolves: #104351 Releases: main Change-Id: I15c1343b95f4fd31f5c8e209bf15bfc23c199a0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85214 Tested-by:
-
Andreas Kienast authored
The JavaScript linter `eslint` is upgraded from v8 to v9. This also requires an upgrade of all `@typescript-eslint` packages. With these, some breaking changes were introduced: * `@typescript-eslint/indent` rule is migrated to `@stylistic` The formating rule `@typescript-eslint/indent` has been extracted to a new package, as `@typescript-eslint` does not want to provide rules for code asthetics anymore [1]. * `@typescript-eslint/no-unused-expressions` is enabled by default eslint detects and reports unused expressions, which is a great thing. Some of our code misused this for shortcut if/else clauses. However, chai.js (the deep down framework used for JavaScript tests) uses this syntax for assertions, therefore the lint rules have been disabled for test files. * `grunt-eslint` requires the newer "flat config" for eslint. The existing configuration has been migrated invoking the command `npx @eslint/migrate-config .eslintrc.js`. Executed commands: npm install --save-dev \ @stylistic/eslint-plugin \ @typescript-eslint/eslint-plugin@^8.0.1 \ @typescript-eslint/parser@^8.0.1 \ @typescript-eslint/typescript-estree@^8.0.1 \ eslint@^9.9.0 \ eslint-plugin-lit@^1.14.0 \ grunt-eslint@^25.0.0 npm run build [1] https://eslint.style/guide/why Resolves: #104601 Releases: main, 12.4 Change-Id: Ic492d0d1dca31b1878c0de97191edf6c33015a2c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85593 Tested-by: -
Andreas Kienast authored
The package `symfony/polyfill-php83` can be upgraded to version 1.30.0, solving deprecations regarding nullable types in PHP 8.4 environments [1]. Executed command: composer update symfony/polyfill-php83 [1] https://github.com/symfony/polyfill-php83/compare/v1.29.0...v1.30.0 Resolves: #104609 Releases: main, 12.4 Change-Id: I0c82a74cde2920d382cbdd8348978786c815c6d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85609 Reviewed-by: -
Andreas Kienast authored
The package `psy/psysh` can be upgraded to version 0.12.4, solving deprecations regarding nullable types in PHP 8.4 environments [1]. Executed command: composer update psy/psysh [1] https://github.com/bobthecow/psysh/commit/2b731c82c0e5b9b36450ce1d4a17f3010c343d91 Resolves: #104610 Releases: main, 12.4 Change-Id: I20a54c5761162f07c4019325a3d02ba09238a8af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85610 Tested-by: -
Andreas Kienast authored
This commit introduces a new component to render progress trackers. Progress trackers are bascially segmented or chunked progress bars, suitable for a chain of tasks, e.g. wizards. Important note: this component is rather experimental by now and may change in a few details. Until further notice, this component is strictly for internal use only. Resolves: #104565 Releases: main Change-Id: I4f3e588033618c178320b36f0a0ff1976718e02f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85499 Reviewed-by:
-
- Aug 12, 2024
-
-
Christian Kuhn authored
Raise a few dependencies and adapt CI matrix. > composer req --dev codeception/codeception:^5.1.2 > composer req --dev codeception/module-webdriver:^4.0.2 Resolves: #104606 Releases: main Change-Id: Ic99135b7387782871686a95a645146a3496dcd20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85602 Reviewed-by:
-
Christian Kuhn authored
Activate PHP 8.4 functional tests in pre-merge and a nightly combination. Similar to unit tests with #104578, we patch another library: enshrined/svg-sanitize. A patch is pending [1], but not yet merged nor released. Codewise its trivial. Some tests need a minor adaption since XML files are created slightly differently with PHP 8.4, the change aligns the fixtures to deal with this. [1] https://github.com/darylldoyle/svg-sanitizer/pull/110 Resolves: #104604 Related: #104578 Releases: main Change-Id: I5d99275aa14d56c35894b270a7f111a50fd56ab7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85592 Reviewed-by:
-
Lina Wolf authored
Also apply formatting for the guides.xml Resolves: #104602 Releases: main Change-Id: I880b6f052014ec03771370dbeae0da52536018c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85596 Tested-by:
Chris Müller <typo3@brotkrueml.dev> Reviewed-by:
-
Christian Kuhn authored
sebastian/comparator:6.0.2 got a minor bugfix release changing a detail of assertEqualsCanonicalizing(). Two tests fail when this transitive dependency is raised. We slightly refactor the tests to deal with this. > composer u sebastian/comparator Resolves: #104605 Releases: main, 12.4 Change-Id: I1c7b88d438a9f0a2b596e13e960eed78f484d8bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85600 Tested-by:
-
Andreas Kienast authored
Exeucted commands: npm install --save-dev \ filesize@^10.1.4 \ flag-icons@^7.2.3 \ sharp@^0.33.4 npm run build Resolves: #104595 Releases: main, 12.4 Change-Id: Idad1107f63ec150851574d124125d5ada42d03b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85589 Reviewed-by: -
Andreas Kienast authored
Executed commands: npm install --save \ @codemirror/autocomplete@^6.18.0 \ @codemirror/commands@^6.6.0 \ @codemirror/lang-html@^6.4.9 \ @codemirror/lang-javascript@^6.2.2 \ @codemirror/lang-sql@^6.7.0 \ @codemirror/lang-xml@^6.1.0 \ @codemirror/language@^6.10.2 \ @codemirror/lint@^6.8.1 \ @codemirror/search@^6.5.6 \ @codemirror/state@^6.4.1 \ @codemirror/view@^6.32.0 \ @lezer/lr@^1.4.2 npm run build Resolves: #104594 Releases: main, 12.4 Change-Id: Ie8133aa2093513052051a63af52b3cc92424d08a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85588 Tested-by: -
Benni Mack authored
Resolves: #104584 Releases: main Change-Id: I843974be0360a7a4b610c50abc08f3f396ab8024 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85398 Reviewed-by:
-
- Aug 10, 2024
-
-
Christian Kuhn authored
idn_to_ascii() must not be called with empty string in PHP 8.4. Resolves: #104587 Related: #104513 Releases: main, 12.4, 11.5 Change-Id: I649d157cca3dadbe237e20eb440b071a1885db71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85581 Reviewed-by:
-
Christian Kuhn authored
Brings PHP 8.4 compatibility. Other branches will receive dedicated patches. > composer u typo3/testing-framework Resolves: #104586 Releases: main Change-Id: I7486847df1e9c3f054552f5705be3ebb2aa719da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85580 Tested-by:
-
Christian Kuhn authored
Wait for the drop down to be ready before clicking around on it. Resolves: #104585 Releases: main, 12.4, 11.5 Change-Id: I9fa86d99b02c74bcc0f9efebce8fc4c2f8e54af5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85576 Reviewed-by:
-
Christian Kuhn authored
Similar to UnitDeprecated merge into Unit in issue #104582, we merge FunctionalDeprecated into Functional. Resolves: #104583 Related: #104582 Releases: main Change-Id: Ida2943cba0d301b8b30b019c08d49fd98aba3557 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85575 Reviewed-by:
-
