- Oct 02, 2018
-
-
Oliver Hader authored
Change-Id: If916407e7a7d9d54777ecee641bee5a604885ce2 Reviewed-on: https://review.typo3.org/58556 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Oliver Hader authored
Change-Id: Ibacf4ce5d6c2a2e3f7aafb2c17536ab89dff1c15 Reviewed-on: https://review.typo3.org/58555 Reviewed-by:
-
Benni Mack authored
Resolves: #86539 Releases: master Change-Id: Ia0a53b713382ae5cbbc9f5b57c82a532ba8f601b Reviewed-on: https://review.typo3.org/58554 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Oliver Hader authored
* uses '&type=xyz' argument value of query in case no PageType decorator has been configured or if no value could be resolved (not defined in 'map' nor as 'default' value) * allows using 'default' value without having it defined in 'map' (values always should be explicit, however this is a fallback handling) Resolves: #86538 Releases: master Change-Id: I32ddbaebba916f875f6cd76609fce6b4172eee4d Reviewed-on: https://review.typo3.org/58553 Reviewed-by:
Richard Haeser <richard@maxserv.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Benni Mack authored
When importing from page_path of RealURL, a slash is appended for all imported URLs, however TYPO3 Core does not add slashes at the end for new pages - which leads to a bad UX, having mixed values. However, with route enhancers, it is possible to add slashes to the very end of a link, so it's useful to NOT have them anymore inside the database. Resolves: #86536 Releases: master Change-Id: I50e941ec97a70654d9974757a6191b416aa40c29 Reviewed-on: https://review.typo3.org/58552 Reviewed-by:
Kevin Appelt <kevin.appelt@icloud.com> Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Tested-by:
-
Daniel Siepmann authored
* Fix wrong indentation level in example. * Adjust sorting of paragraphs for explanation to match order of configuration options in example above. * Keep example consistent. Remove single quotes around two keys in a single line, not used in other lines. * Add syntax highlighting to SiteConfiguration syntax for environment variables. Releases: master Resolves: #86365, #86409 Change-Id: Ic7923bf7a3215f86637d3a8e20776f74666daf3f Reviewed-on: https://review.typo3.org/58551 Reviewed-by:
-
Benni Mack authored
During deprecation of TYPO3_LOADED_EXT, ext_tables.php is not loaded in "Check TCA in ext_tables.php" anymore. The fix loads the file correctly. Resolves: #86534 Releases: master Change-Id: If4ab1183704862bed7e2c6f657f8d80d9338d9f4 Reviewed-on: https://review.typo3.org/58550 Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Georg Ringer authored
Reduce amount of false positives introduced with #86366 as methods like 'getTitle()' are used too often. Resolves: #86533 Releases: master Change-Id: I97e7406cb5f134042fabf96ea3435c5c2f7ad665 Reviewed-on: https://review.typo3.org/58549 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
- Oct 01, 2018
-
-
Andreas Fernandez authored
This patch removes the unnecessary `width: 100%` definition. This fixes the glitch in the image cropper. Resolves: #86530 Related: #86445 Releases: master Change-Id: Iaaf6e7f2f69bc526e245ec4b79ece00977c5c5d6 Reviewed-on: https://review.typo3.org/58547 Reviewed-by:
-
Anja authored
Change-Id: Ic2ad05680c072f901c200b05810be958204825db Releases: master Resolves: #86434 Reviewed-on: https://review.typo3.org/58545 Reviewed-by:
-
Andreas Fernandez authored
The queueing of AJAX requests in the extension scanner has some flaws which causes the scanner to refuse another scan request. The counter of pending requests is now always decremented, not only if the amount of requests equals the threshold. Also, it's now checked if there is any item in the request queue before shifting. Instead of overriding the `success` and `error` callback, only `complete` is now overridden, as this callback is executed on any return state. To make the queueing part better maintainable and reusable, the code has been moved into a separate module. Resolves: #86523 Related: #86436 Releases: master Change-Id: Ifa26ad7ce3bd81497c43b8606b902d467bdd1dda Reviewed-on: https://review.typo3.org/58539 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Stefan Neufeind authored
When the new PageTypeEnhancer resolved type from a URL it is not part of getQueryParams() but needs to be fetched from TSFE. Resolves: #86527 Releases: master Change-Id: I5041b042f1246f2ecc8adc8fa6cba123abfccf5b Reviewed-on: https://review.typo3.org/58540 Tested-by:
-
Josef Glatz authored
The main goal of this patch is to update the neglected INSTALL.md and README.md to represent the current state of the requirements and to improve the overall content of the two "entry" documentation files. The install.md has been massively shortened and links to the official guides were added to finally be able to have one source of truth. Resolves: #86487 Releases: master Change-Id: Id61abf86a4113d25c940c63f1423fa341aa7e702 Reviewed-on: https://review.typo3.org/58388 Reviewed-by:
-
Benjamin Franzke authored
typo3/sysext/core/bin/typo3 does not work in composer mode currently. Composer-based installations need to use the binary from the composer "bin-dir", which is fine from a composer-usage point of view – but hard for documentation. Additionally the path to "typo3/sysext/core/bin/typo3" is hardcoded in some places (e.g. scheduler). We now make sure this binary works in composer mode as well, using the same entry point strategy as for "typo3/index.php" and "typo3/install.php". Change-Id: I400ccd3a2bba4496c5d4ec9482e624cf8270a462 Releases: master Resolves: #86513 Reviewed-on: https://review.typo3.org/58531 Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
Markus Klein authored
Make sure that in most places any site related exception is handled in a graceful way to avoid negative UX. Resolves: #86522 Releases: master Change-Id: I3b0d7f9ce63351f8dd7bb6b4988704fc8a3d0a9f Reviewed-on: https://review.typo3.org/58537 Reviewed-by:
Jurian Janssen <jurian.janssen@gmail.com> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
Oliver Hader authored
* slashed values are not resolved correctly concerning their dynamic '/' prefix in route paths * adjusting route path and parameters might cause side effects when dealing with multiple decorating enhancers * test cases for resolving and generating URIs using new PageTypeDecorator enhancer are added Resolves: #86506 Releases: master Change-Id: I3757933c47ea0f06d88bb27a635c2077e8f673b1 Reviewed-on: https://review.typo3.org/58512 Reviewed-by:
-
Daniel Goerz authored
Resolves: #86503 Releases: master Change-Id: Iaf924b9f851bd25cb2d16ab5e5656703603a669b Reviewed-on: https://review.typo3.org/58522 Tested-by:
-
Benni Mack authored
EXT:extbase uses @api and @internal phpDoc annotations. Going with a cleaner approach with marking code as just @internal, and everything not annotated as @internal is public, is the way to go, also the way PSR-5 is heading. For EXT:extbase: Every PHP class that had nothing marked, is now @internal, everything that was @api is now implicitly part of TYPO3 Core API. On top, all license headers and @license annotations have been streamlined. This means: - TYPO3 Core's PHP classes area all public API by default unless marked as @internal or an extension class - @api is not allowed anymore and will be restricted in the future from adding. - @internal should be used for everything that should not be explicitly exposed as public API in the future. - Everything under Tests/ is not part of TYPO3's Public API Resolves: #86521 Releases: master Change-Id: I83c5a27d9af001929142d2620600668ad0a84c92 Reviewed-on: https://review.typo3.org/58535 Tested-by:
-
Daniel Goerz authored
As stated in the Interface: If no query string is present, this method MUST return an empty string. Resolves: #86520 Releases: master, 8.7 Change-Id: I9869af08c84262443e503c34a2c608fbc5ba4bc2 Reviewed-on: https://review.typo3.org/58534 Reviewed-by:
-
Susanne Moog authored
As extensions might contain data to import the activate extension command needs to initialize the user authentication so the data handler may import data. The backend user authentication initialization has been added to the activate extension command. Resolves: #86161 Releases: master Change-Id: Id25c45bdfc8ac1cb930c9ed6adb49c39c17d7952 Reviewed-on: https://review.typo3.org/58536 Reviewed-by:
-
Benni Mack authored
All specific controllers for specific Backend actions, Backend-module related modules, all hook implementations (where the core uses hooks by itself), and module-specific ViewHelpers are now marked as @internal to ensure developers what is part of the public TYPO3 Core API. within - EXT:core - EXT:extensionmanager - EXT:install All @api annotations have been removed. Resolves: #86517 Releases: master Change-Id: I7869d8e3b6e8a4365529cc7c98b99cde7ca1495f Reviewed-on: https://review.typo3.org/58532 Reviewed-by:
-
Daniel Goerz authored
Resolves: #86504 Releases: master Change-Id: I115d1fcce00142b5e0eb34dbb840c785cf1b59f4 Reviewed-on: https://review.typo3.org/58523 Reviewed-by:
-
Benni Mack authored
All specific controllers for specific Backend actions, Backend-module related modules, all hook implementations (where the core uses hooks by itself), and module-specific ViewHelpers are now marked as @internal to ensure developers what is part of the public TYPO3 Core API. within - EXT:indexed_search - EXT:info - EXT:linkvalidator - EXT:lowlevel - EXT:opendocs - EXT:recordlist - EXT:recycler - EXT:redirects - EXT:reports - EXT:scheduler All @api annotations have been removed. Resolves: #86511 Releases: master Change-Id: I80de460142266305c1af3ad437f939b7e4448676 Reviewed-on: https://review.typo3.org/58530 Reviewed-by:
-
Benni Mack authored
EXT:fluid uses @api and @internal phpDoc annotations. Going with a cleaner approach with marking code as just @internal, and everything not annotated as @internal is public, is the way to go, also the way PSR-5 is heading. For EXT:fluid: Every PHP class that had nothing marked, is now @internal, everything that was @api is now implicitly part of TYPO3 Core API. Other areas will follow so the API for TYPO3 v9 LTS is clearer than ever. Resolves: #86507 Releases: master Change-Id: I5deba0ba2b868743e7eda8f0e32cda40ef008046 Reviewed-on: https://review.typo3.org/58525 Tested-by:
-
Susanne Moog authored
Resolves: #86498 Releases: master Change-Id: I8605215706406a0a7826a1fe401ccd11d46ead73 Reviewed-on: https://review.typo3.org/58516 Tested-by:
-
Benni Mack authored
All specific controllers for specific Backend actions, Backend-module related modules, all hook implementations (where the core uses hooks by itself), and module-specific ViewHelpers are now marked as @internal to ensure developers what is part of the public TYPO3 Core API. within - EXT:seo - EXT:setup - EXT:rte_ckeditor - EXT:workspaces - EXT:viewpage - EXT:tstemplate - EXT:taskcenter - EXT:t3editor - EXT:sys_action - EXT:sys_note All leftover @api methods have been removed. Resolves: #86509 Releases: master Change-Id: I6e5ee2302055de9ea4c124ca913e4677d62721fe Reviewed-on: https://review.typo3.org/58529 Tested-by:
-
Benni Mack authored
Two new Exceptions are now thrown when routing does not work, one being thrown when a URL is generated but could not be generated, and one when a URL could not be resolved. This is much cleaner than the distinction of a nullable return type, so the new interface is adapted as well. As a drive-by fix, the Backend routing exception now inherits from this new exception. Resolves: #86500 Releases: master Change-Id: Ifaf7b61422dfd49df18399c3bcbdf735bc522cba Reviewed-on: https://review.typo3.org/58519 Tested-by:
-
Markus Klein authored
Releases: master Resolves: #86481 Change-Id: I87b9a07b6cc10c4379a6bf3e1c0e1695354b574a Reviewed-on: https://review.typo3.org/58505 Tested-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
Jan Stockfisch <typo3@jan-stockfisch.de> Reviewed-by:
-
Markus Klein authored
This reverts commit 2124bba4. The feature is reverted as the functionality can't be provided in a fully working manner to work in all possible cases the FE may be called. Change-Id: Ia7caf3770b12737fd195da9d9f66bdc179981de8 Resolves: #86492 Reverts: #23494 Releases: master Reviewed-on: https://review.typo3.org/58517 Reviewed-by:
-
Benjamin Kott authored
Resolves: #86510 Releases: master Change-Id: I80692b806c3a7b51de3fad4947102e34956114a2 Reviewed-on: https://review.typo3.org/58528 Reviewed-by:
-
Benni Mack authored
All specific controllers for specific Backend actions, Backend-module related modules, all hook implementations (where the core uses hooks by itself), and module-specific ViewHelpers are now marked as @internal to ensure developers what is part of the public TYPO3 Core API. within - EXT:felogin - EXT:feedit - EXT:filelist - EXT:frontend - EXT:fluid_styled_content - EXT:impexp All leftover @api methods have been removed. Resolves: #86508 Releases: master Change-Id: I97a6964a5f77dc9ee3d90365e9fda3d7d7be6266 Reviewed-on: https://review.typo3.org/58527 Tested-by:
-
Benni Mack authored
All specific controllers for specific Backend actions, Backend-module related modules, all hook implementations (where the core uses hooks by itself), and module-specific ViewHelpers are now marked as @internal to ensure developers what is part of the public TYPO3 Core API. within - EXT:backend (except ViewHelpers) - EXT:beuser - EXT:about - EXT:belog All @api methods have been removed. Resolves: #86505 Releases: master Change-Id: I1fd1e16f7885e81fb994999e5873a1a3a1aa6c3b Reviewed-on: https://review.typo3.org/58524 Reviewed-by:
-
Josef Glatz authored
This patch adds the newly added CKEditor v4 icon (via #86499) to ext:rte_ckeditor as new extension icon. `yarn && yarn build` was used to copy the file to the final location. Releases: master Resolves: #86501 Change-Id: I5225805f195eb2efe29a5deac6bb5426c313b604 Reviewed-on: https://review.typo3.org/58520 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Benni Mack authored
EXT:form uses @api and @internal phpDoc annotations. Going with a cleaner approach with marking code as just @internal, and everything not annotated as @internal is public, is the way to go, also the way PSR-5 is heading. For EXT:form: Every PHP class that had nothing marked, is now @internal, everything that was @api is now implicitly part of TYPO3 Core API. Other areas will follow so the API for TYPO3 v9 LTS is clearer than ever. Resolves: #86502 Releases: master Change-Id: I2c1efdd11f0fbaa992315a90049eb109e2620c76 Reviewed-on: https://review.typo3.org/58521 Reviewed-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Tested-by:
-
Benjamin Kott authored
Following commands were used to update the external package and copy the files/folders to the final location: `yarn upgrade @typo3/icons@1.8.0 && yarn build` Resolves: #86499 Releases: master Change-Id: I87b571234257d82b1f2f09f523817c2eea2b26d2 Reviewed-on: https://review.typo3.org/58518 Reviewed-by:
-
Daniel Siepmann authored
Use proper code highlighting syntax for yaml and typoscript within 86160 changelog entry. Resolves: #86160 Releases: master Change-Id: I791956413885cabdfdf5693e9d0ad6c4be41a29d Reviewed-on: https://review.typo3.org/58515 Reviewed-by:
-
Daniel Siepmann authored
Define default highlighting for 86365 changelog entry to be yaml. Adjust all yaml occurrences within this entry to use default highlighting. Releases: master Resolves: #86365 Change-Id: I9063311830330d55ae051c8a0d38da78a2a91831 Reviewed-on: https://review.typo3.org/58514 Reviewed-by:
-
Frank Naegler authored
This patch adds a request queue for the massive amount of AJAX calls in the extension scanner. This patch mitigates the problem of massive server load in case the amount of files to be scanned is very high. This patch mitigates the problem by allowing a maximum of 10 concurrent requests. After the release of TYPO3 v9 LTS, this scanner module should be refactored further. Resolves: #86436 Releases: master Change-Id: I824dfb74aae46d6b00690e7ca6553305c4221f0f Reviewed-on: https://review.typo3.org/58510 Tested-by:
-
Benni Mack authored
A new PageTypeEnhancer is added to map the internal TYPO3 GET parameter `type` to a speaking URL suffix. The PageTypeEnhancer only does suffixes, if other You can configure it like this: routeEnhancers: PageType: type: PageType default: '' map: '.html': 1 'menu.json': 13 Resolves: #86160 Releases: master Change-Id: Ie4b387963012946272568a69c9581e8d345dbe4c Reviewed-on: https://review.typo3.org/58478 Reviewed-by: -
Benni Mack authored
Resolves: #86489 Releases: master Change-Id: I721c89b8afdc248b040a5e82cfd8c209dc84dbab Reviewed-on: https://review.typo3.org/58511 Reviewed-by:
-
