Skip to content
Snippets Groups Projects
  1. Mar 14, 2013
  2. Mar 13, 2013
    • Christian Kuhn's avatar
      [TASK] Raise submodule pointer · ad0a8b0e
      Christian Kuhn authored
      Change-Id: I04d40a3796937182603c7b85e16227f18f51c002
      Reviewed-on: https://review.typo3.org/18889
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      ad0a8b0e
    • Christian Kuhn's avatar
      [FEATURE] Central system environment check · 009f307b
      Christian Kuhn authored
      This patch adds a new structure to the install tool to centralize
      all system and especially PHP related system checks cluttered in
      various modules and parts of the core at the moment.
      
      The idea is to have a basic, standalone script to test for all
      requirements TYPO3 CMS has in order to run smoothly. The script does
      not use any TYPO3 core code and has no further dependencies. With
      a later patch, the check will be integrated as the very first
      step during install, to give a good indicator if the final
      installed system will work well or if any system constraints are
      not met.
      
      Currently, the script is included as a new section in the install
      tool, called "System environment", where all checks are performed
      and each gives a status back. This will already help to support
      questions on mailing lists and should be the first step every user
      is guided to: "Do you have warnings or errors in the system
      environment?". The install tool implementation should also help
      already if moving an instance to a different server.
      
      Furthermore, there is a simple integration in the reports module
      that points to the install tool if issues are found.
      
      The class structure is as simple as possible, it is very easy to
      adapt single checks later on, the API is a single getStatus() method
      that returns all check object of the specific tests. Due to the
      nature of the script and the later usage in the installation
      process, things like localization and so on are not done and
      should also not be implemented later on.
      
      Most current check code is fetched from existing install tool,
      reports module and bootstrap code. This also make the main
      Installer.php class of the install tool already a bit better
      maintainable since 600 lines of code are removed from it.
      
      Change-Id: I64387ca9aaa4b429ee4a909cdab4386180af0d45
      Resolves: #46219
      Releases: 6.1
      Reviewed-on: https://review.typo3.org/18870
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      Reviewed-by: Jigal van Hemert
      Tested-by: Jigal van Hemert
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      009f307b
    • Mario Rimann's avatar
      [BUGFIX] Translation of a form makes the form wizard unusable · 338cf5b6
      Mario Rimann authored
      As soon as the form-configuration for the form wizard gets
      loaded, the leading "[Translate to XYZ:] " is stripped off to get the
      wizard working (with the leading text, the form config could not
      be serialized as needed and the wizard didn't show a single field).
      
      The stripping is only done on localized records.
      
      Change-Id: I0cab1d371abf5ae01b524c39acedcd1a3a5db9c4
      Fixes: #39127
      Releases: 4.7, 6.0, 6.1
      Reviewed-on: https://review.typo3.org/12996
      Tested-by: Mario Rimann
      Reviewed-by: Stefan Galinski
      Tested-by: Stefan Galinski
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      338cf5b6
    • Dmitry Dulepov's avatar
      [TASK] Improve FAL performance · 76ec3573
      Dmitry Dulepov authored
      FAL performance in BE and FE can be improved by using certain database
      indexes. One set of indexes improves performance in BE by adding a
      "deleted" column, which is used by List module. Without this column
      in the 'pid' index, List module will do a full scan, which is much
      slower. Another set of indexes improves performance when getting files
      from storage.
      
      Change-Id: I1f8577453ed917db95d680ca74fefc4691ba53b0
      Resolves: #45532
      Releases: 6.1
      Reviewed-on: https://review.typo3.org/18316
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      76ec3573
    • Georg Ringer's avatar
      [TASK] Improve rootline cache handling · 688d341c
      Georg Ringer authored
      The method get() checks if there is an entry by using
      has() and does then an additional get(). This can
      be simplified which saves a query for every hit
      
      Change-Id: I0ebfd8c7622a5e673d3f34aa685f18a9878116ef
      Resolves: #45530
      Releases: 6.1
      Reviewed-on: https://review.typo3.org/18314
      Reviewed-by: Oliver Hader
      Reviewed-by: Philipp Gampe
      Reviewed-by: Steffen Ritter
      Reviewed-by: Oliver Klee
      Reviewed-by: Wouter Wolters
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      688d341c
    • Andreas Wolf's avatar
      [BUGFIX] Exception when deleted file is in clipboard · 75ee5d8f
      Andreas Wolf authored
      When a file is deleted while it is part of a clipboard, an exception is
      thrown when the clipboard is reconstituted. This exception has to be
      catched, otherwise the file module will be unusable.
      
      Change-Id: I8849644ffa7b78559c1797d85ce3cc6e01d03a74
      Resolves: #43906
      Releases: 6.1, 6.0
      Reviewed-on: https://review.typo3.org/18191
      Reviewed-by: Thomas Scheibitz
      Tested-by: Thomas Scheibitz
      Reviewed-by: Wouter Wolters
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      75ee5d8f
    • Andreas Wolf's avatar
      [BUGFIX] inject* methods in FAL inhibit use of Extbase object manager · dbc89f7c
      Andreas Wolf authored
      The ResourceStorage class of FAL has two inject* methods which are seen
      as dependency injectors by the Extbase object manager. Thus an exception
      is thrown when a ResourceStorage object is created via Extbase.
      
      This commit changes the two method's names and adjust all usages within
      the core. These methods are internal and I don't expect them to be used
      anywhere else, so we don't need a backwards compatibility layer.
      
      Change-Id: I4b73445708cf8041b505b5ea8923dc595ddaadb0
      Resolves: #45319
      Releases: 6.1, 6.0
      Reviewed-on: https://review.typo3.org/18159
      Reviewed-by: Alexander Opitz
      Tested-by: Alexander Opitz
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      dbc89f7c
  3. Mar 12, 2013
  4. Mar 11, 2013
    • Wouter Wolters's avatar
      [TASK] Cleanup filelist · 4b0c8c63
      Wouter Wolters authored
      Change-Id: If107bd20db15d1881c12097adecd342b8e1979aa
      Resolves: #45143
      Releases: 6.1
      Reviewed-on: https://review.typo3.org/18005
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Philipp Gampe
      Tested-by: Philipp Gampe
      Reviewed-by: Oliver Klee
      Reviewed-by: Felix Kopp
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      4b0c8c63
    • Wouter Wolters's avatar
      [TASK] Cleanup sysext "taskcenter" and "tsconfig_help" · b70403a1
      Wouter Wolters authored
      Change-Id: I2658e5d0a7ae979f93b60713294adcbe8e41db09
      Resolves: #46145
      Releases: 6.1
      Reviewed-on: https://review.typo3.org/18822
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      b70403a1
    • Jost Baron's avatar
      [TASK] Show better error messages on failed TER update · e564ba71
      Jost Baron authored
      This patch shows error messages in a flash message if the ajax request
      for a TER-update fails, and resets the extension manager into a sane
      state, instead of showing an ever spinning wheel.
      
      Resolves: #46030
      Releases: 6.1
      Change-Id: I1cc67460a11feb206c53c12a38ad0f6db482e04a
      Reviewed-on: https://review.typo3.org/18688
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      e564ba71
    • Stefan Neufeind's avatar
      [FEATURE] sys_note: Display/functionality for hover/context menu · d952d1dd
      Stefan Neufeind authored
      In page-module content-elements only show icons when hovered
      and they have a contextmenu on the icon.
      
      Add same functionality for sys_note
      
      Change-Id: I170309ac5ffe8b9cfa25ba1c9933d69ddcbcbca8
      Resolves: #43496
      Releases: 6.1
      Reviewed-on: https://review.typo3.org/16911
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      d952d1dd
    • Jost Baron's avatar
      [TASK] Make the update-from-TER link more visible · 41ed02c9
      Jost Baron authored
      Make the "update from TER"-action in the extension manager more
      visible by showing a button for it, instead of a text link.
      
      Also moved the rendering functionality of the update link from
      a viewhelper to a partial, as partials tend to be more readable
      and bug free.
      
      Resolves: #46029
      Releases: 6.1
      Change-Id: If447bba28bc0dee3e7de286e1a93e062ef59843c
      Reviewed-on: https://review.typo3.org/18687
      Reviewed-by: Philipp Gampe
      Tested-by: Philipp Gampe
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      41ed02c9
    • Philipp Gampe's avatar
      [BUGFIX] Handle symlink on extension update · 69391120
      Philipp Gampe authored
      If an extension is updated and the extension in the file
      system is a symlink to a different directory, all
      target directory contents is removed and the update fails.
      
      Introduce a check for symlink and just remove the
      symlink in this case.
      
      Resolves: #46158
      Releases: 6.1, 6.0
      Change-Id: I112ae7192fb0edf77ebd703a61804dc09ca506a4
      Reviewed-on: https://review.typo3.org/18826
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      69391120
    • Philipp Gampe's avatar
      [TASK] More descriptive error message on file upload failure · f5401a11
      Philipp Gampe authored
      Provide the user with more accurate information about what might have
      gone wrong.
      
      Resolves: #46160
      Releases: 6.0,6.1
      Change-Id: I86123b904f36ff7f6db77f2dd13f97c0a01957c3
      Reviewed-on: https://review.typo3.org/18827
      Reviewed-by: Alexander Opitz
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      f5401a11
  5. Mar 10, 2013
    • Francois Suter's avatar
      [BUGFIX] Correct check for extTables script · 0f7fe6be
      Francois Suter authored
      Existence of the script defined in TYPO3_extTableDef_script is
      currently achieved by using file_exists(). This is insufficient
      if TYPO3_extTableDef_script is defined, but empty, as
      file_exists() will match "typo3conf/" and try to include it.
      
      Resolves: #46161
      Releases: 6.0, 6.1
      Change-Id: I2e72e86bc583bf4a1ca7e570e679d8297963383d
      Reviewed-on: https://review.typo3.org/18828
      Reviewed-by: Francois Suter
      Tested-by: Francois Suter
      0f7fe6be
  6. Mar 08, 2013
    • Christian Kuhn's avatar
      [BUGFIX] Typo in sys_log TCA · 9be1dcb9
      Christian Kuhn authored
      Wrong table field name in sys_log TCA "detail_nr" instead of
      "details_nr" triggers SQL errors in DB check -> Full search module.
      
      Change-Id: I02298019ef29f38def0b6c204236fd6987b92bce
      Releases: 6.1, 6.0
      Fixes: #45887
      Reviewed-on: https://review.typo3.org/18811
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      9be1dcb9
    • Christian Kuhn's avatar
      [TASK] Raise submodule pointer · 929a2c83
      Christian Kuhn authored
      Change-Id: I886c3e9cb3212d958b405e0ac9264c2ef9860171
      Reviewed-on: https://review.typo3.org/18810
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      929a2c83
    • Georg Ringer's avatar
      [TASK] Don't render table header if no files given · fffe917e
      Georg Ringer authored
      It doesn't make sense to render the table header in
      the filelist module if no files are given.
      
      Change-Id: I81870bca94e63643e3f27c90efa370b0a9964337
      Resolves: #45579
      Releases: 6.1
      Reviewed-on: https://review.typo3.org/18362
      Reviewed-by: Felix Kopp
      Tested-by: Felix Kopp
      Reviewed-by: Soren Malling
      Tested-by: Soren Malling
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      fffe917e
    • Markus Klein's avatar
      [BUGFIX] Wrong cmd example in INSTALL.txt · f54d1efb
      Markus Klein authored
      The INSTALL.txt file has an example on how to create a link
      in Windows using the MKLINK command.
      
      Unfortunately the parameters in the example have the wrong order.
      
      Resolves: #46119
      Releases: 6.1, 6.0, 4.7, 4.5
      Change-Id: Ida960d79e0144c15afdd7c21a9cd35466ec24545
      Reviewed-on: https://review.typo3.org/18806
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      f54d1efb
    • Michael Stucki's avatar
      [BUGFIX] Fix SQL syntax · 3eda95d2
      Michael Stucki authored
      Use single quotes to retain compatibility with PostgreSQL.
      
      Change-Id: If3b900d08330bb96ce37fcbefcd110ccfd9b24b5
      Resolves: #45826
      Releases: 6.1, 6.0
      Reviewed-on: https://review.typo3.org/18475
      Reviewed-by: Felix Kopp
      Reviewed-by: Rico Sonntag
      Reviewed-by: Alexander Opitz
      Tested-by: Alexander Opitz
      Reviewed-by: Xavier Perseguers
      Tested-by: Xavier Perseguers
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      3eda95d2
    • Anja Leichsenring's avatar
      [BUGFIX] Allow Setting colorspace in the Install Tool. · be4887e7
      Anja Leichsenring authored
      Some versions of Imagemagick (6.7.0 and above) use the sRGB colorspace
      instead RGB as before. This results in darker images after processing,
      because TYPO3 hardcoded the RGB colorspace in graphical functions.
      
      This patch introduces a setting in the GFX part of the Install Tool,
      lets the user choose the sufficient colorspace.
      This selection is used in graphical functions.
      
      Additionaly a hint on the setting was added to the Image Processing Test
      'Read Images' in the Install Tool.
      
      Fixes: #36597
      Releases: 6.1, 6.0, 4.7, 4.5
      Change-Id: I50a26c414705afa3177a2f12fc3bb4532c2d0f7f
      Reviewed-on: https://review.typo3.org/17474
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      be4887e7
  7. Mar 07, 2013
    • Wouter Wolters's avatar
      [BUGFIX] Deactivating "install" extension leads to exceptions · 6c543d0c
      Wouter Wolters authored
      Uninstalling the "install" extension leads to exceptions in
      required system extensions like extensionmanager or lang.
      
      The solution is to make "install" a required extension too.
      
      Change-Id: Id5a0ebd9400648cd7c453d98b58e8cad1d155bd8
      Fixes: #43361
      Releases: 6.1, 6.0
      Reviewed-on: https://review.typo3.org/16824
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Sebastian Michaelsen
      Tested-by: Sebastian Michaelsen
      Reviewed-by: Oliver Klee
      Reviewed-by: Felix Kopp
      Tested-by: Felix Kopp
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      6c543d0c