- Aug 10, 2024
-
-
Christian Kuhn authored
idn_to_ascii() must not be called with empty string in PHP 8.4. Resolves: #104587 Related: #104513 Releases: main, 12.4, 11.5 Change-Id: I649d157cca3dadbe237e20eb440b071a1885db71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85581 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
Christian Kuhn authored
Wait for the drop down to be ready before clicking around on it. Resolves: #104585 Releases: main, 12.4, 11.5 Change-Id: I9fa86d99b02c74bcc0f9efebce8fc4c2f8e54af5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85579 Tested-by:
-
- Aug 09, 2024
-
-
Christian Kuhn authored
Wait for the modal body iframe being there before switching to it. This is mainly an issue in v11 where the modal takes more time server side and webdriver is 'too quick' switching to it. We still sanitize all branches. Resolves: #104577 Releases: main, 12.4, 11.5 Change-Id: Ida09f1945daae3d0fb396f1e495e91ed5042454a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85565 Tested-by:
-
- Aug 07, 2024
-
-
Garvin Hicking authored
If an invalid record in `sys_be_shortcuts` is stored like this: ``` INSERT INTO sys_be_shortcuts (userid,route,arguments) VALUES (1,'record_edit','[]'); ``` then the backend cannot be accessed anymore due to PHP errors due to unguarded array key access of the "arguments" contents. This patch guards the array key access to prevent such a situation, so an invalid shortcut can be deleted from the menu. Database records like this might happen for migrated older installations. Resolves: #104496 Releases: main, 12.4, 11.5 Change-Id: I350e620eb403e53d1828cf5dedaab633ba00db55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85464 Tested-by:
-
- Aug 06, 2024
-
-
Oliver Hader authored
composer/composer as dev dependency got a security release relevant for monorepo. We should raise to it. > composer req --dev composer/composer:^2.2.24 Resolves: #104556 Releases: main, 12.4, 11.5 Change-Id: Ib9b81a942456f1ac78445f27b4b0b198ff204e2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85541 Tested-by:
-
Christian Kuhn authored
Resolves: #104557 Releases: main, 12.4, 11.5 Change-Id: I1bea6d74fc444007c8787e0a642c86b35a7ccb90 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85538 Reviewed-by:
-
Stefan Bürk authored
Doctrine DBAL retrieves for MariaDB `ENUM()` and `SET()` field default values quotes with single quotes, which leads to an endless field change reporting recursion in the database analyzer. The default value is now trimmed to ensure a working field compare within the extending `TYPO3\CMS\Core\Database\Schema\Comparator` class. Note that TYPO3 v13 (main) may reveal the same issue but is shadowed due to the general `ENUM()` and `SET()` type field issue since Doctrine DBAL 4, reported in #104413. That needs a change on its own for main only. Resolves: #97498 Related: #104413 Releases: 12.4, 11.5 Change-Id: I51b79a7f63db43cca2724958b0355a496a49fd33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85460 Tested-by:
-
- Aug 03, 2024
-
-
Mathias Bolt Lesniak authored
SiteResolving will now correctly interpret a temporary ID of a new page (e.g., "NEW12345678ABCDEF") as an invalid ID and try to infer the site using `$result['effectivePid']`. This makes it possible to access site configuration properties within the TCA also on pages that have yet to be created. Resolves: #103573 Releases: main, 12.4, 11.5 Change-Id: I174e71e084e96b24ebe721ad0336a3dd1a8115d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85458 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
- Jul 31, 2024
-
-
Markus Sommer authored
Resolves: #104513 Releases: main, 12.4, 11.5 Change-Id: I73d4d5eac80e3bd637fa2fabd7b1d1948daf357c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85430 Tested-by:
-
- Jul 29, 2024
-
-
Thomas Hohn authored
In the RestoreRegisterContentObject::render method a call to array_pop is performed. The result is assigned to the variable $frontendController->register which has type array. However array_pop can return null, this patch add's a null coalesce operator to ensure that correct type. Resolves: #104495 Releases: main, 12.4, 11.5 Change-Id: I46efce10e4322ff3cd39b5a0eeafd1f768644e38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85359 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Jul 26, 2024
-
-
Christian Kuhn authored
PHP 8.4 support requires new guzzle versions. v13 sets requirements to PHP 8.4 compatible guzzle libraries versions, so v13 can not ship with libraries lower than that. This drops guzzle/promises v1 support, which has been re-added to v12 for backwards compatible reasons, and v13 inherited this. It should be fair to drop guzzle/promises v1 in v13 now. v12 and v11 will only "composer u" to the versions below, but not require them, so non-composer releases will package compatible library versions, while composer instances have the option to update when needed. > composer u guzzlehttp/guzzle guzzlehttp/promises guzzlehttp/psr7 Resolves: #104488 Releases: main, 12.4, 11.5 Change-Id: I43a4e56f9fbb3bb00d77eb198161350e72a51da4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85395 Tested-by:
-
Christian Kuhn authored
Brings PHP 8.4 fixes. "composer req" in v13, "composer u" in v12 and v11. > composer u typo3/html-sanitizer Resolves: #104483 Releases: main, 12.4, 11.5 Change-Id: I3c5dfb7eb1b76bc13ef0d784e87138360bfbdd61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85392 Tested-by:
-
- Jul 25, 2024
-
-
Stefan Bürk authored
This change raises the core-testing-php84 image version to use PHP 8.4.0 alpha2. [1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/abd0b88dd70d0053359b08584d66df17540f177d Resolves: #104480 Releases: main, 12.4, 11.5 Change-Id: Ife69d5fdb82f4243547fab5998b4a1ba0123bafc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85357 Tested-by:
-
Christian Kuhn authored
phpstan "bleeding edge config" enables a feature that reduces memory usage significantly. We don't switch to "bleeding edge" per se, but enable that single toggle for now. phpstan does not do this by default since it may be breaking for existing rules, which is not a problem in our case. > rm -rf .cache/phpstan/; Build/Scripts/runTests.sh -s phpstan Before locally: 10.99 GB After locally: 5.82 GB Before CI: 15.15 GB After CI: 9.49 GB Numbers vary depending mainly on available number of CPUs: My local machine has less CPUs than CI - we *may* tune phpstan a bit further in this area, later. Resolves: #104476 Related: #104475 Releases: main, 12.4, 11.5 Change-Id: I32ca9a36b752ad52e8ac5fd433c3f929f86843af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85378 Tested-by:
-
Christian Kuhn authored
phpstan can be very memory hungry. Option --verbose adds a line about 'peak memory' usage to the output. Add this to get a better feeling of the memory usage. Resolves: #104475 Releases: main, 12.4, 11.5 Change-Id: I3fdaf7ddee7e003e7a8e75a508dd69161c804c8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85354 Tested-by:
-
- Jul 24, 2024
-
-
Andreas Kienast authored
This commit updates the package `requirejs` to version 2.3.7 to fix a prototype pollution vulnerability [1]. [1] https://github.com/requirejs/requirejs/compare/2.3.6...2.3.7 Resolves: #104459 Releases: 12.4, 11.5 Change-Id: I73a62c7e4e715954db5802d0a46d5758c407ac7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85335 Reviewed-by:
-
- Jul 19, 2024
-
-
Stefan Bürk authored
Resolves: #104435 Releases: main, 12.4, 11.5 Change-Id: I5ff37f97f0d0a71420839c4d2b1bf8bde70afa7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85206 Tested-by:
-
Stefan Bürk authored
This change adds the predefined GitLab CI/CD variable `CI_JOB_ID` value to the suffix, used for containerized network and container names, with the goal to increase uniqueness in CI runs. Additionally, the value is now displayed in execution and the container cleanup notes at least the network name further information source to investage unusually container shutdowns. [1] https://docs.gitlab.com/ee/ci/variables/predefined_variables.html Resolves: #103928 Releases: main, 12.4, 11.5 Change-Id: I6cf8dddefd2b45ed6f5c8cca8aa5521319cc8c4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85302 Tested-by:
-
Oliver Hader authored
Fixes an array key warning in $backendUser->groupData['webmounts']. Resolves: #104430 Releases: main, 12.4, 11.5 Change-Id: I077c59c67067f6221288ca4a73589dcc9c69bd07 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85298 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Jul 15, 2024
-
-
Benjamin Franzke authored
Do not listen on the livereload port, as we do not ship the client-side[1] livereload integration anyway. This allows multiple grunt-watch (e.g. main and 12.4) to run in parallel instead of blocking each other because they try to allocate the same port. [1] https://github.com/gruntjs/grunt-contrib-watch/blob/main/docs/watch-examples.md#enabling-live-reload-in-your-html Resolves: #104390 Releases: main, 12.4, 11.5 Change-Id: I36f37178e1752015033d5b0f2746c49b2477c1a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85201 Reviewed-by:
-
- Jul 12, 2024
-
-
Christian Kuhn authored
PHP 8.4 linting is fine already. Let's add it to CI jobs. Resolves: #104386 Releases: main, 12.4, 11.5 Change-Id: Ie64f602aace5d816ae80ce502bdf054dde7b787a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85253 Reviewed-by:
-
Christian Kuhn authored
Brings PHP 8.4 fixes. Hard raise in v13, "composer u" in v12 and v11. > compser u psr/http-factory Resolves: #104384 Releases: main, 12.4, 11.5 Change-Id: I65b5955379e30c4f889ed76d0b211ae25c83057d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85249 Reviewed-by:
-
Christian Kuhn authored
BcryptPasswordHash has an option to set a cost value. The lower barrier used to be identical to PHP constant PASSWORD_BCRYPT_DEFAULT_COST. Tests use the lower barrier to speed up tests. With PHP <8.4, PASSWORD_BCRYPT_DEFAULT_COST is 10, it has been raised to 12 with PHP 8.4. The patch frees our code from access to this constant and hard codes 10 as lower barrier check. This keeps the API as is, and this hash is by default set to 12 already in default options if none are provided. Resolves: #104373 Releases: main, 12.4, 11.5 Change-Id: I4c1e94fdc50aa3075570549ccdd3b81a2de2e98a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85237 Tested-by:
-
Christian Kuhn authored
As a PHP 8.4 preparation, phpunit is raised to latest version of current major version. Note 11.5 needs a raise of nikic/php-parser as well, which we do not require, but raise within lock files only. > composer u nikic/php-parser > composer req --dev phpunit/phpunit:^9.6.20 -w Resolves: #104372 Releases: main, 12.4, 11.5 Change-Id: I395b8487bc3aca2dc34d4b7fe86c03d58a7a8709 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85234 Tested-by:
-
- Jul 09, 2024
-
-
Christian Kuhn authored
Bump dependency to latest 1.0 patch level to gain PHP 8.4 support. Do not raise in composer.json to not disturb existing instances. > composer u lolli42/finediff Resolves: #104340 Related: #104339 Releases: 12.4, 11.5 Change-Id: I8017bc89186ed1496bcaa509978163582857a285 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85185 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Stefan Bürk authored
This change adds PHP8.4 as allowed version to the `Build/Scripts/runTests.sh` script as preparation to validate and check the Core and 3rd party libs with PHP8.4 locally. Note that unit tests already revealing deprecation and errors for 3rd party extension which can now be reported and for checked upstream updates. Resolves: #104337 Releases: main, 12.4, 11.5 Change-Id: I76d3e37b393c347173fcdbe874d6a0737fb76d33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85180 Tested-by:
-
- Jul 08, 2024
-
-
Loek Hilgersom authored
Fixes exception in impexp when an extension does not have a value for TCA[tableName][ctrl][rootLevel] Resolves: #104308 Releases: main, 12.4, 11.5 Change-Id: Ia2b8095c35ba6b07827525a65e0dcbb6fa1d060e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85153 Tested-by:
-
- Jul 02, 2024
-
-
Stefan Bürk authored
This change modifies the `php-cs-fixer` ruleset and activate two rules related to nullable types. Following options are added: 'nullable_type_declaration' => [ 'syntax' => 'question_mark', ], 'nullable_type_declaration_for_default_null_value' => true, `nullable_type_declaration` ensures to use `?<type>` declaration instead of union type `<type>|null` as a convention for properties, method and return types. For already union types the nullable is added as additional null union type `ObjectOne|ObjectInterface|null`. `nullable_type_declaration_for_default_null_value` ensures to use nullable type declarations to mitigate implicitly nullable method arguments [1] which has been already fixed with a series of dedicated changes. Used command(s): Build/Scripts/runTests.sh -s cgl [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #103751 Releases: main, 12.4, 11.5 Change-Id: Ia790a6757c5fbe92da45298333037c5b5d36575d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85090 Tested-by: -
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104284 Releases: main, 12.4, 11.5 Change-Id: Iadea4cde1d3b80962a47ffa4c183a885504bef6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85054 Reviewed-by:
-
- Jul 01, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104278 Releases: main, 12.4, 11.5 Change-Id: Ia3a4bc344b369b8697c88ed14ac06354dd988dce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85042 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104270 Releases: 11.5 Change-Id: I107a89d5f2a2e3d4c1f16c9d2551d8be6ec74b33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85029 Reviewed-by:
Mogens Fiebrandt <mogens.fiebrandt@googlemail.com> Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104271 Releases: 11.5 Change-Id: I133a94663f4513cd842dce44505dca25c87853d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85030 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104272 Releases: 11.5 Change-Id: I27212e50528bc42e2dfd33493f8794707dda1304 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85031 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104269 Releases: 11.5 Change-Id: I3df96a00df084060989bb7e5a01566ee29dc709b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85028 Tested-by:
-
Stefan Bürk authored
Apply the latest rules of php-cs-fixer for both fixer (code and header-comment) also in the `Build/Scripts` folder. The Build folder is now added to the usual php-cs-fixer execution for code and header fixer scripts to avoid code style drifitng in this folder for the future. Used command(s): Build/Scripts/runTests.sh -s cgl ; \ Build/Scripts/runTests.sh -s cglHeader Resolves: #104274 Releases: main, 12.4, 11.5 Change-Id: I7977e2254b9e271c45b840c6696cd7600ab0b1aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85036 Reviewed-by:
-
- Jun 30, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104263 Releases: main, 12.4, 11.5 Change-Id: I7f132b2d3f7df9ba620b26656bbfca7fd038f32a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85015 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104265 Releases: main, 12.4, 11.5 Change-Id: Ifb6887a9fc77bc74c2d287b34a6876cc5da477da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85021 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104266 Releases: main, 12.4, 11.5 Change-Id: I731d63dbbb13df6b3e0b6f40641ac0a98e92519f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85024 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104264 Releases: main, 12.4, 11.5 Change-Id: I64badf36faf69bc84f622cc9e7d5c1949c928ff1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85018 Reviewed-by:
-
- Jun 29, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104250 Releases: main, 12.4, 11.5 Change-Id: Ic0842784b1a647fbde6e0472a8efef934ce03663 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85006 Reviewed-by:
-
