- Sep 03, 2014
-
-
Markus Klein authored
The error handling code for PHP errors needs some cleanup. So does the description of the related settings in the Install Tool. Resolves: #61235 Releases: 6.3, 6.2 Change-Id: Ibd95fcdaa6a50a870035037a2332b95d2c5e1266 Reviewed-on: http://review.typo3.org/32464 Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
Viktor Livakivskyi <invisible.kinder@gmail.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Wouter Wolters authored
Class is unused and contains code that is deprecated and marked for removal in TYPO3 CMS 6.3 Resolves: #61231 Releases: 6.3 Change-Id: Ia0ec7aa95d54b0372edc340a8986a1d15c43d3e5 Reviewed-on: http://review.typo3.org/32458 Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
-
Markus Klein authored
Using the recursive stdWrap will work on the stdWrap twice, although the output is created only once. Fix this by preventing the recursive call to stdWrap() if the current function name is "stdWrap" as this will trigger a call to stdWrap_stdWrap() later on anyway. This will change rendering if LOAD_REGISTER or something similar is used in a recursive stdWrap context. Resolves: #60135 Releases: 6.3 Change-Id: I728f637b4e34f26b9cf6951f04667c8195638b3d Reviewed-on: http://review.typo3.org/32466 Reviewed-by:
Helmut Hummel <helmut.hummel@typo3.org> Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
- Sep 02, 2014
-
-
Wouter Wolters authored
Remove tx_cms_webinfo and tx_cms_webinfo_lang and use their namespaced variant for registration into web_info module. Resolves: #61218 Releases: 6.3 Change-Id: I66c25241197d0b3898aee3e126f0b5b212e38a45 Reviewed-on: http://review.typo3.org/32409 Tested-by:
-
- Sep 01, 2014
-
-
Felix Kopp authored
Bring common html structure for EXT: beuser table. The other table (above in code) has already been changed before. Resolves: #61267 Releases: 6.3 Change-Id: I88f688ed421dcf8b2984fe3a1e0204b3ed6e19cf Reviewed-on: http://review.typo3.org/32504 Reviewed-by:
-
- Aug 29, 2014
-
-
Georg Kühnberger authored
Added previewDomain in order to have Web-View functioning in the same way like Page-Preview does. Fixes: #61226 Related: #30889 Releases: 6.3, 6.2 Change-Id: I872651aeac1bda27f7a8a034fc30a21ff7162df0 Reviewed-on: http://review.typo3.org/32510 Reviewed-by:
Oliver Gassner <og@plan2.net> Tested-by:
-
- Aug 27, 2014
-
-
Jacob Rasmussen authored
When using prepared statements for inserts and updates, the execute method currently fails due to a missing check on the return value from $this->statement->result_metadata(); Resolves: #61229 Releases: 6.3, 6.2 Change-Id: Ida17f617915c36a0c2e91663eee64b4c358090e2 Reviewed-on: http://review.typo3.org/32452 Reviewed-by:
Mattias Nilsson <tollepjaer@gmail.com> Tested-by:
-
- Aug 26, 2014
-
-
Benjamin Mack authored
The current solution to add HTML5 placeholder attribute support for unsupported browsers (which are IE9 and lower) is using a combination of ExtJS and Prototype, which both need to be loaded for that. Currently this is used in FormEngine and the backend login form. However, there are better ways of creating these fallbacks, one being Placeholder.JS (see http://jamesallardice.github.io/Placeholders.js/) which can seamlessly be integrated, and only be loaded for IE9 and less. Resolves: #60578 Releases: 6.3 Change-Id: If8443276b85d15222c4fc0954e3f79b50ce6a4c9 Reviewed-on: http://review.typo3.org/31830 Reviewed-by:
Felix Kopp <felix-source@phorax.com> Tested-by:
-
Stefan Neufeind authored
For create-table "tableType" was still used while an alter-table used "engine". Change-Id: Idee0e569e331ec66084484f1e8d55d9cab03ff9f Resolves: #61129 Releases: 6.3, 6.2 Reviewed-on: http://review.typo3.org/32304 Reviewed-by:
-
- Aug 25, 2014
-
-
Helmut Hummel authored
To make it possible to use the module dispatcher with a click menu item, it is necessary to add the CSRF token to the URL of the called click menu functionality. Resolves: #60635 Releases: 6.3, 6.2 Change-Id: I0b378c3ba4c22f25b10e39950d08568f608decdb Reviewed-on: http://review.typo3.org/31987 Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- Aug 23, 2014
-
-
Stefan Froemken authored
The extensionmanager uses bad indexes. It is better to move col repository to the the end of the indexes. Resolves: #59809 Releases: 6.3,6.2 Change-Id: I0bb8d5cdfc8591bb35485b204ad5e8dafd1b4d16 Reviewed-on: http://review.typo3.org/31080 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Marcin Sągol <marcin@soee.pl> Reviewed-by:
-
Kay Strobach authored
This patch enables the browse menu to skip inaccessible items for prev and next links. It makes use of the filterMenuPages method, which is already applied to any kind of menu. Since it has not been applied to the sections of the browse menu type, which are actually menus themselves, inaccessible pages made browsing unusable. This applies to missing translations as well. Change-Id: I8779731139785dea72b078567912c96e3ad5c7ca Resolves: #58792 Releases: 6.3, 6.2 Reviewed-on: http://review.typo3.org/30098 Reviewed-by:
Jo Hasenau <info@cybercraft.de> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
-
René Bigler authored
When importing a t3x file that contains files the function "getFiles" of the object TYPO3\CMS\Core\Resource\Folder is called which does not exist. Resolves: #60474 Releases: 6.3, 6.2 Change-Id: Ibc392bced57a85ad6eae333406ff507af7faefd4 Reviewed-on: http://review.typo3.org/31744 Reviewed-by:
-
Klaas Johan Kooistra authored
When persistence.recursive is configured when using a command controller no records can be retrieved because the storagePid is negated in the AbstractConfigurationManager, while claiming all implementations of getTreeList support negative ids. Using abs() on the id when it is negative fixes this. Also see the ContentObjectRenderer implementation of getTreeList Change-Id: I7732290126a83a79204b8224d52a3cd878360e64 Resolves: #60697 Releases: 6.3, 6.2 Reviewed-on: http://review.typo3.org/31919 Reviewed-by:
Peter Beernink <p.beernink@youwe.nl> Tested-by:
-
Jigal van Hemert authored
In the page module information on neighboring content elements is collected while building the page layout. This information must be remembered for other elements on the page instead of generated new when rendering each element. This makes sure the move buttons and edit buttons have the correct URLs. Resolves: #60199 Releases: 6.3, 6.2, 6.1, 6.0, 4.7, 4.5 Change-Id: I9fec256b145fe8aba229d8b026fba73871942347 Reviewed-on: http://review.typo3.org/31929 Reviewed-by:
Robert Heinig <robert.heinig@3m5.de> Tested-by:
Gerwin Kramer <gerwinkramer@gmail.com> Tested-by:
Stefan Holz <sh@atlantismedia.de> Tested-by:
Christian Hernmarck <ch_t3@hernmarck.ch> Reviewed-by:
-
- Aug 20, 2014
-
-
Andreas Fernandez authored
Currently, the method fetchMaximalVersionsForAllExtensions uses a subselect to determine the highest available version. This solution is rather inefficient and incomptabile to DBAL. The query is replaced by a LEFT JOIN. Resolves: #60857 Releases: 6.2, 6.3 Change-Id: I7ae3c523259bf260c41080aee269f6df33edb408 Reviewed-on: http://review.typo3.org/32062 Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Reviewed-by:
-
Wouter Wolters authored
Unexpected behaviour. Default of maxitems in now 1 by default which doesn't work if you need more items. Previously this was possible. Revert this to have the old working behaviour again. Releases: 6.3,6.2 Resolves: #60263 Reverts: #55731 This reverts commit c578d476. Change-Id: Ice5357aecb1969f11c6821cb81824d2d68200717 Reviewed-on: http://review.typo3.org/31818 Reviewed-by:
-
Frans Saris authored
If the FAL indexer scheduler task finds a index record with same content hash as a new found file the file isn't added to the index if it isn't marked as missing. This patch changes the indexer so that new files with same content hash are added when no index record is found for a missing file with same content hash. Resolves: #60764 Releases: 6.3, 6.2 Change-Id: Ifb7f9e6f48ba327c958a7aa0e0b71f0575cabdf7 Reviewed-on: http://review.typo3.org/32000 Reviewed-by:
Frank Nägler <typo3@naegler.net> Tested-by:
-
Markus Klein authored
The writeLog() function of the ErrorHandler tries to log the IP that caused the error. On CLI there is no IP hence a NULL value is being tried to insert into the DB, where the DB field is NOT NULL. Fix this by casting the IP to a string. Resolves: #61051 Releases: 6.3, 6.2 Change-Id: Id46e97468bf825307258e907811d5f2c77c62161 Reviewed-on: http://review.typo3.org/32247 Reviewed-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
Daniel Hürtgen <daniel@higidi.de> Reviewed-by:
-
- Aug 17, 2014
-
-
Matthias Kappenberg authored
Processing stdWrap for the select.recursive TypoScript property has just been forgotten in the original issue #18822 during the development of TYPO3 4.6. Change-Id: I34f2ac45e5112fbcc2becf7936f486f0b53d361a Resolves: #55707 Releases: 6.3, 6.2, 6.1 Reviewed-on: http://review.typo3.org/30043 Reviewed-by:
-
- Aug 15, 2014
-
-
Lars Trebing authored
When directly comparing CAST(... AS CHAR) with a CHAR field (including VARCHAR and TEXT) whose collation isn't the same as that of the database connection, MySQL gives an error like this: > Illegal mix of collations (utf8_general_ci,IMPLICIT) and > (utf8_unicode_ci,IMPLICIT) for operation '<>' Wrapping the right side of the comparison in CAST(... AS CHAR) as well keeps the data unchanged while ensuring that both sides have the same collation. Change-Id: Icaec66412d6b6441ae30065ffb92565991e9a1e4 Resolves: #36754 Releases: 6.3, 6.2 Reviewed-on: http://review.typo3.org/32117 Reviewed-by:
-
- Aug 14, 2014
-
-
Oliver Hader authored
Remove new-line at end of file that has been introduced by accident in commit:7ef6d2c8 Releases: master Change-Id: I0a18755d16aaef4496b21183f870dffbd86ee2c1 Reviewed-on: http://review.typo3.org/32158 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Oliver Hader authored
The retrieval of file references in BackendUtility is currently bound to the thumbCode() method but is useful for other components as well. Resolves: #60054 Releases: master, 6.2 Change-Id: Id92bdeaed24d8924285a640f905ffd55db21da4d Reviewed-on: http://review.typo3.org/31287 Reviewed-by:
-
Oliver Hader authored
The record details view renders record icons for both live and versioned record. However, this representation is shown rather stand-alone and can be combined with the accordant headers. Resolves: #60015 Releases: master, 6.2 Change-Id: I2f468a06271f335c491d90d825f7bcef7a9db9f6 Reviewed-on: http://review.typo3.org/31254 Reviewed-by:
-
- Aug 13, 2014
-
-
Andy Grunwald authored
Resolves: #60878 Releases: 6.3 Change-Id: I2cc8ec067adcc66bdd589104d03f20c385e52e99 Reviewed-on: http://review.typo3.org/32071 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Benjamin Mack authored
On every Frontend request, the original media wizard provider of EXT:cms is loaded, by fetching the MediaWizardProviderManager and then an object of MediaWizardProvider is loaded and held in memory, as this is not needed, but only on pages where a media is used. This change moves the instantiation of the providers to the time when it is needed. Further modification would be to add the registered wizards to TYPO3_CONF_VARS[FE][mediaProviders] and use them directly in the MEDIA object, so the MediaWizardProviderManager class could be deprecated. Releases: 6.3 Resolves: #56336 Change-Id: Id466d41fef019449d820b6faec3946ec1c951488 Reviewed-on: http://review.typo3.org/28046 Reviewed-by:
-
Oliver Hader authored
Extend install tool suhosin checks by * suhosin.get.max_name_length=200 * suhosin.post.max_name_length=200 * suhosin.request.max_varname_length=200 Resolves: #60356 Releases: 6.2, 6.3 Change-Id: I382e44832918799df58a912e95cd4b0c3f0b81a3 Reviewed-on: http://review.typo3.org/31637 Reviewed-by:
-
Oliver Hader authored
The defaultMailFromName setting is not used for sending the test mails in the install tool. Resolves: #60758 Releases: master, 6.2 Change-Id: I35e1b887de6b06bb5f301e037d6d412c18ac0b37 Reviewed-on: http://review.typo3.org/31966 Reviewed-by:
-
Christian Weiske authored
Using fluid's <f:debug> to get dumps of json_decode()d objects does not work currently. The DebuggerUtility shows only properties obtainable via ReflectionClass, which does not work for stdClass objects. The patch introduces special handling of stdClass objects, using the properties that actually exist in the object. Change-Id: I3845178f6defdbceae4b867f45e5080f23443766 Fixes: #60912 Releases: master, 6.2 Reviewed-on: http://review.typo3.org/32108 Reviewed-by:
-
Andreas Fernandez authored
Updating the field "current_version" fails with some DMBS because $uidsOfCurrentVersion has too many elements. This patch chunks the array into multiple parts and updates the uids in each part. Resolves: #60859 Releases: 6.2, 6.3 Change-Id: If63f855b250bf7c9b6cd7112f60392cfc8ccfd67 Reviewed-on: http://review.typo3.org/32065 Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
-
Markus Klein authored
The system environment check does not properly parse the suhosin configuration option for whitelist. Fix this by changing the code to be less strict about the actual syntax of this option. Resolves: #60925 Releases: 6.3, 6.2 Change-Id: I6797a313cedaaf1895cf7b4fddaae9811341006b Reviewed-on: http://review.typo3.org/32122 Reviewed-by:
Daniel <typo3dev@outlook.com> Tested-by:
-
Oliver Hader authored
On publishing a delete placeholder all other versions shall be deleted as well, since the original record will be deleted after that action. However, this is only valid for the live workspace and using the legacy version behavior there. DataHandler::deleteVersionsForRecord() calls BackendUtility::selectVersionsOfRecord(), but without the additional, but required, $workspace argument. Thus, all other versions in other workspaces are deleted as well. The SQL query to determine versions needs to be limited to either the live workspace (for legacy versions) and the current workspace. Resolves: #60249 Releases: master, 6.2 Change-Id: If90511dc4ac2bc3dde6e58570e6bf10e4ac949db Reviewed-on: http://review.typo3.org/31589 Reviewed-by:
-
Oliver Hader authored
If deleting an IRRE child reference, the nesting leving in the workspace module is not shown correctly. The reason for that is, that the sys_refindex entry points to the live id of the deleted child record. This change takes care of correct visualization only, but does not touch the sys_refindex behavior in this case. Resolves: #59853 Releases: master, 6.2 Change-Id: I09970d12ba10e528c150275952ec4c9ff8333a0a Reviewed-on: http://review.typo3.org/31591 Reviewed-by:
-
Oliver Hader authored
Having a record in live workspace with an accordant localization leads to the fact that actions to the default language also have an impact to all localizations. In a workspace, first deleting the localization, then deleting the record of the default language, ends up in actually having reverted the previous deletion of the localization. The solution is to check for delete placeholders in DataHandler::deleteL10nOverlayRecords(). Resolves: #59113 Releases: master, 6.2 Change-Id: I888c83a58d591f57bc2ea75a49fa603a56a7f722 Reviewed-on: http://review.typo3.org/31142 Reviewed-by:
-
Oliver Hader authored
After some workspace actions being performed in the workspaces module in the TYPO3 Backend, the page tree does not get updated: * discarding a single workspace version * performing mass actions which output warnings Resolves: #59828 Releases: 6.2, master Change-Id: Ic9fb6613e8647ed351246ea18fcb3696e60ef7b2 Reviewed-on: http://review.typo3.org/31091 Reviewed-by:
-
- Aug 12, 2014
-
-
Christian Kuhn authored
composer.json is configured to fetch latest phpunit 4.x branch. Since 4.2 was just released stable, it will be used now. phpunit 4.2 now relies on Ocramius/Instantiator to create mocks that do not call a constructor during instantiation. This project was created to cope with a recent security fix in PHP unserialize() that rendered the old way of creating those mocks invalid. The instantiator project however has issues with PHP versions 5.3 and 5.6 that lead to some failing tests and need further investigation. To not run into this during our next merges, the patch nails phpunit to 4.1.x for now. Change-Id: I5feb8346e0713fefe6c8fa899c76d3e040dd1973 Resolves: #60923 Releases: master, 6.2 Reviewed-on: http://review.typo3.org/32115 Reviewed-by:
-
Wouter Wolters authored
When using toggleButton in "Test setup" a JavaScript error is thrown because the scrolling handler can only be used if the fixed footer is available. Add a check to prevent this JavaScript error. Resolves: #60577 Releases: 6.3,6.2 Change-Id: Ie7628e83280f6af032b364586cdfb6b386663d9d Reviewed-on: http://review.typo3.org/31828 Reviewed-by:
-
- Aug 06, 2014
-
-
Benjamin Mack authored
As IE6 is not supported for the TYPO3 backend anymore, the IE6-specific styles for HTMLarea can be safely removed. Resolves: #60770 Releases: 6.3 Change-Id: I11e91f705c49be9f2ead48c0d741242acda6cbb6 Reviewed-on: http://review.typo3.org/31978 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Aug 04, 2014
-
-
Anja Leichsenring authored
Usage of $TYPO3_CONF_VARS is discouraged, instead $GLOBALS['TYPO3_CONF_VARS'] should be used. The hint in next to the install tool login mask spells the discouraged version, which is corrected with this patch. Change-Id: Ia7ded107a9b5670c0bc35da92993e84ad45c167e Releases: master, 6.2 Resolves: #60639 Reviewed-on: http://review.typo3.org/31882 Reviewed-by:
-
- Aug 02, 2014
-
-
Jo Hasenau authored
Before fetching related records from a foreign table, we must ensure that there is a uid to be considered, since otherwise we will fetch any record having a 0 value for that field. There are method calls in the core, that don't provide a uid, so the default value 0 is used, i.e. when fetching children of translated gridelements, causing memory outage when tt_content is > 10000 records. Resolves: #60494 Releases: 6.3, 6.2 Change-Id: I1105964f98f79074bb37dc1921180b493fac4bc6 Reviewed-on: http://review.typo3.org/31781 Reviewed-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
-
