- Jul 07, 2023
-
-
Susanne Moog authored
When `open_basedir` is set (often the case on shared hosting), TYPO3 fails to find executables as it does a check for file existence first, which fails due to the restriction. Instead of checking file existence in all cases, a fallback has been added on *nix systems that will try execution of a given command and use the return code to decide whether the path is valid. This itself uses the command `which` which is not available on Windows. As nowadays `open_basedir` is mostly used on shared hosting environments based on *nix, this will not be fixed for Windows. Resolves: #70869 Resolves: #85174 Releases: main, 12.4 Change-Id: Ic01e822ae16b9ef1fa80be745a9de51e527ba059 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79865 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Jochen Roth authored
Currently, when the selected db has already tables an exception is thrown This has been changed by showing a nicely formatted error message like done for any other error in this command. Resolves: #101172 Releases: main, 12.4 Change-Id: I09fe21a5cce71ff860f965244bee86474ee5c398 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79854 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com>
-
- Jul 06, 2023
-
-
Johannes Nielsen authored
So far the setup command did not consider default values in non-interactive mode. This led to unexpected errors when not passing in parameters, which should have default values, as either CLI parameters or ENV variables. Resolves: #100945 Releases: main, 12.4 Change-Id: If811c5c1ef9b7d8a5c776af407fac7d2ced4e654 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79831 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Jul 05, 2023
-
-
Susanne Moog authored
With the refactoring to attributes, RowUpdaters failed to be fetched from the UpgradeWizardService, as they present upgrade wizards in the registry but are not registered via the UgradeWizard service locator. To fix this gracefully, we avoid using the service locator for row updaters, falling back to the identifier. A next step (feature) would be the introduction of a dedicated attribute and service locator for RowUpdaters. Resolves: #100539 Related: #99586 Releases: main, 12.4 Change-Id: I2be4400b51f1ecef8059c3c22cf5da01090883dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79653 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Jul 04, 2023
-
-
Daniel Siepmann authored
Some checks might return a message why images can't be generated. Those checks didn't return success which prevents processing by JavaScript, leading to endless "Loading" state within UI. All responses now properly return success = true in order to be processed by JavaScript. Resolves: #100893 Releases: main, 12.4 Change-Id: I720893a0b01a26a7b77bdcb16c02295eed3ae595 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79680 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Jul 03, 2023
-
-
Benni Mack authored
The site language's configuration setting "hreflang" was deprecated with #99908, however, it still serves a valid purpose. If working with EXT:seo and the <link rel="alternate"> tags, it is still valid and possible to set a specific "hreflang" attribute. Example setups: * You have "German (Germany)" (which is using de-DE as locale) and "German (Austria)" (which is using de-AT as locale). here you want to set "de" as generic fallback in the "de-DE" locale when using hreflang attributes. * You want to explicitly set "x-default" for a specific language, which is clearly not a valid language key. This change does the following: * It re-adds the hreflang property to be managed by the UI, however it is empty by default and will fallback to the $locale->getName(). * It is not used within the <html lang="..."> attribute anymore as this was a mis-use in the first place (and now properly using just the language key, see https://www.w3.org/International/questions/qa-html-language-declarations.en.html#attributes * The method "SiteLanguage->getHrefLang()" is not deprecated anymore. * The RST is adapted accordingly Still, the relevant information is: The site language configuration option "hreflang" is not relevant anymore for regular websites without rendering hreflang tags, but is now customizable, and has a proper fallback. Resolves: #101160 Resolves: #95798 Related: #99908 Releases: main, 12.4 Change-Id: Ifc5b5b10ba46b4da4abd5c504d4d69f240f2fd02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79545 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org>
-
- Jun 28, 2023
-
-
Dennis Prinse authored
The update to only allow guzzlehttp/promises has been breaking to external extensions and their dependencies. Only allowing guzzlehttp/promises v2 caused projects to refuse updating TYPO3 from v12.4.1 to v12.4.2 > composer require guzzlehttp/promises:"^1.5.2 || ^2.0" > composer require --no-update guzzlehttp/promises:"^1.5.2 || ^2.0" \ -d typo3/sysext/install/ Resolves: #101184 Related: #100919 Releases: main, 12.4 Change-Id: I173ca51ed03e3d1522d3dfa2e0db46a9141b6e13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79527 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de>
-
- Jun 26, 2023
-
-
Jasmina Ließmann authored
In order to ensure the readability of the progress bar, the previous content has been split up. Only the percentages are now displayed in the progress bar. Information about which installation step the user is currently at is now displayed above the progress bar. In addition, an undefined variable and icon were removed and the form buttons of the first step are now aligned in a row. Resolves: #100987 Releases: main, 12.4 Change-Id: Idc43d11a5f4b9988c51cf97482dee1f48d8e21b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79425 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com>
-
- Jun 15, 2023
-
-
Stefan Bürk authored
With #100407 the `SilentConfigurationUpgradeServiceTest` has been promoted from a unit test to a functional test to avoid a mocking party. Tests in this test cases write "test configuration" to the test instances `LocalConfiguration.php` file. For this the update method `ConfigurationManager->updateLocalConfiguration` is used to set the test configuration upon the generated test-instance config. Secondly, the `SilentConfigurationUpgradeService` is used to check for changed configurations. This service also updates the config, even if not reloading it. Reload would be done for the next test. These two facts together leads to dirty LocalConfiguration.php for a test. Deterministic setup per test is not guaranteed, because the configuration is not properly cleaned up after a test. This change stores the functional test instances configuration in `setUp()` and restores it in `tearDown()`, using the write method `ConfigurationManager->writeLocalConfiguration()`. This resets `LocalConfiguration.php` to the state which has been created by the testing-framework. The correct expectation, that no change happened, is set for `versionNumberInFilenameSetToTrueStaysUntouched`. Resolves: #101075 Related: #100407 Releases: main, 12.4 Change-Id: I18dd80fee04cc27cbb709cfb1c7494dc975edc42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79412 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
- Jun 14, 2023
-
-
Alexander Opitz authored
The `ensure` method must return true, if all operations were successful. This is the case if all database operations succeeded without returning an error message. The error messages are now checked correctly and the corresponding state is returned. Resolves: #100428 Releases: main, 12.4, 11.5 Change-Id: I95911b065f8796d1eedf73438efde82ba01a07db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79354 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com>
-
- Jun 13, 2023
-
-
Benni Mack authored
Change-Id: I9986b69d722f7267443be79deaac6650e84cec78 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79296 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
Change-Id: I5776002d773ecaf3cb25e3fed990c2cd4e8f984c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79295 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Jun 11, 2023
-
-
Thomas Hohn authored
Speed up the SysLogSerializationUpdate migration wizard for trivial cases like a:0:{} and a:1:{i:0;s:0:"";}. Resolves: #100932 Releases: main, 12.4 Change-Id: I6dd35036f18778a1dac012362dbf6ee4fa614703 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79255 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Jun 10, 2023
-
-
Helmut Hummel authored
Using the core cache for schema information comes with various drawbacks: 1. There is no way to flush single core cache entries, thus the complete core cache needs to be flushed when changing the database schema. 2. The PHP Frontend provides no benefit, when the to be cached information has to be serialized anyway. Therefore, a new cache is introduced that can be flushed individually after schema updates. Flushing the cache is now also moved altogether to SchemaMigrator, in order to avoid flushing the cache multiple times for multiple connections. For flushing the individual cache, the internal Bootstrap::createCache factory is used, which ensures a cache backend, which is not set to null backend, which happens with late boot methodology in install tool and replaces the previously used ClearCacheService, which is only meant to be used to flush all caches and boots the system for that. With doing so, the previously introduced argument to not boot the system can be removed again. As drive by change the SysLogChannel update is renovated a bit to not use deprecated Doctrine DBAL API. Releases: main, 12.4 Resolves: #100925 Change-Id: I0193501fec5d41edfcb65f07faefe30985629818 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79220 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
- Jun 01, 2023
-
-
Nikita Hovratov authored
The update brings PHP 7 typehints to guzzlehttp/promises. guzzlehttp/guzzle mainly raised for guzzlehttp/promises v2 compatibility, but also contains a bugfix for SetCookie::fromString. > composer require -W guzzlehttp/guzzle:^7.7.0 > composer require guzzlehttp/promises:^2.0 > composer require --no-update guzzlehttp/promises:^2.0 \ -d typo3/sysext/install/ > composer require --no-update guzzlehttp/guzzle:^7.7.0 \ -d typo3/sysext/core/ - Upgrading guzzlehttp/guzzle (7.5.1 => 7.7.0) - Upgrading guzzlehttp/promises (1.5.3 => 2.0.0) Resolves: #100919 Releases: main, 12.4, 11.5 Change-Id: I3183f2619a060ec768646b1c4a97fdf937312514 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79142 Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79156
-
- May 26, 2023
-
-
Nikita Hovratov authored
This is a preparation patch for a guzzlehttp/guzzle and guzzlehttp/promises raise. Resolves: #100918 Releases: main, 12.4, 11.5 Change-Id: I9a2731ade87de8f54b2e3c0e375dde1609e35e2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79121 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Nikita Hovratov <nikita.h@live.de>
-
- May 17, 2023
-
-
Chris Müller authored
Resolves: #100856 Releases: main, 12.4 Change-Id: Ibd7fb6e28e66763a34b599cb68524bf855d8ccba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79075 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
- May 15, 2023
-
-
Oliver Hader authored
Issue #93884 provided and adjusted CSP header for SVG inline styles: | default-src 'self'; script-src 'none'; | style-src 'unsafe-inline'; object-src 'none'; For SVG files, having 'unsafe-inline' for style-src is fine, since it only applies to the very same file and cannot include other local or remote resources. Resolves: #100041 Releases: main, 12.4, 11.5 Change-Id: I198e0a8225ef6c0e729a3ae78981581b2d2b2205 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78927 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
core-ci <typo3@b13.com>
-
- May 11, 2023
-
-
Sybille Peters authored
It is possible to send a test email in the Environment section of the Install Tool / Admin Tools. Previously, if the sender email was not configured via $GLOBALS['TYPO3_CONF_VARS']['MAIL']['defaultMailFromAddress'] a default no-reply email address was used. Also, the sender email was not checked with GeneralUtility::validEmail. We now display a message in the dialog if the defaultMailFromAddress is not configured or is configured with an invalid email address. In this case, the form with input field and button is also not displayed. Sending with an invalid sender address is no longer possible in Test Mail Setup. The problem with the previous behavior was: - Not setting the value or setting it incorrectly is incomplete configuration. We should make the user aware of this. The point of sending a test mail is to test the configuration as well. - Emails with a sender address which does not exist or is not registered for the mail account might get rejected by the email server but the user gets no error message, so is kept in the dark. - Notifications from the mail server cannot be sent back if a no-reply email is used. If someone configures it that way, that is their responsibility, but we should not fall back to it. Resolves: #100084 Releases: main, 12.4 Change-Id: Ie9ad6eda320791ac27d81f109c4d253da63ace20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78978 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Benni Mack authored
SchemaMigrator / ConnectionMigrator calls ClearCacheService->clearAll(), which in turn just re-applies ext_localconf.php and ext_tables.php, which in turn could re-apply hooks which have been registered via $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_tcemain.php']['processDatamapClass'][] = MyHook::class; Thus, for such cases, it is important the ext_localconf.php is not loaded again. clearAll() now has an optional argument, to flush caches (due to configuration changes, or with DB upgrade in place) so they are completely emptied This is less "brutal" than the original "clearAll" method, as it does not re-load TYPO3_CONF_VARS. This problem comes from https://review.typo3.org/c/Packages/TYPO3.CMS/+/76553/20/typo3/sysext/core/Classes/Database/Schema/SchemaMigrator.php The solution can be found in the now corrected test in EXT:webhooks, which actually registers a hook like this. Resolves: #100840 Related: #99062 Releases: main, 12.4 Change-Id: I9d53df80b119cfec37a5d8d40d5fbd881b14307f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78976 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
- May 09, 2023
-
-
Benni Mack authored
Change-Id: I6af51677e7d4ce391631245619d85636df6dce09 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79001 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
Change-Id: I2252ff54b07112362c669a1f37f5592f4bfac45d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79000 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Torben Hansen authored
After saving the state of the feature toggles in ext:install, the save button remains disabled. This change fixes the problem. Resolves: #100839 Releases: main, 12.4 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I12607ada13646c8eb54df107cef6082d43cb5b9c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78972 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- May 08, 2023
-
-
Nikita Hovratov authored
This cleans up some PHPStan reports. Resolves: #100836 Releases: main, 12.4 Change-Id: I909d361a3b4b0b6f535b4f25de9ce832b9e4e205 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78901 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Nikita Hovratov <nikita.h@live.de>
-
- Apr 28, 2023
-
-
Andreas Fernandez authored
With #100688, the module `es-module-shims` was updated. Unfortunately, with 1.5.3 an incompatibility with Firefox < 108 was introduced, affecting current Firefox ESR releases (currently at 102, at the time of writing this patch). To workaround this issue, the init scripts used in the Install Tool now use `importShim()` for the time being, until Firefox ESR hits version 108. Resolves: #100756 Related: #100688 Releases: main Change-Id: I1337ebbf1f01db287a53ff7ccad50cb4631250d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78881 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- Apr 26, 2023
-
-
Frank Naegler authored
Resolves: #100726 Releases: main Change-Id: I49384e7bbf3f199504ee7a978a816df1285474ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78805 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com>
-
- Apr 25, 2023
-
-
Benni Mack authored
Change-Id: If17fbd8d45edd9c7685217342ad330de84ae471d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78834 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
Change-Id: I158409abb3555504ae6fa1a619794a44ab307c25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78833 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Apr 24, 2023
-
-
Benni Mack authored
The following methods and properties have been deprecated: * Argument $alternativeLanguageKeys in LocalizationUtility::translate() * <f:translate> ViewHelper argument "alternativeLanguageKeys" * LanguageService->getLL() The method "LanguageService->includeLLFile()" is marked as internal. This is done in order to streamline future development in label-related areas. Resolves: #100721 Releases: main Change-Id: I1a0bc2eab61ec807cb43082dfef2361dbe6b185f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78799 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Benjamin Kott authored
Resolves: #100717 Releases: main Change-Id: I0641cb3c82119441727853f5580c3b98db43d6ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78797 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Oliver Hader authored
Issue #92836 introduced the "sudo mode" to all admin tool modules, but with using the session storage of the install tool (based on PHP native `$_SESSION` handling) - which is different to the usual behavior and session handling in the TYPO3 backend. This change changes the session handling to backend user sessions, add a generic way to configure "sudo mode" per backend routes (not hardcoding its invocation in the admin tool controller anymore). In addition, "sudo mode" is now enabled for the extension manager module as well - this was not possible before, due to the hardwired implementation to `ext:install`. In developer context, "sudo mode" is granted automatically (#93160). Resolves: #94246 Releases: main Change-Id: I4fee2b7da3da25c8c6479eab7478b38cdc3b5a4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78546 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Benni Mack authored
This change moves some logic out of AbstractUserAuth classes related to setting a cookie, and only adds a Instruction (the behavior) so a cookie is added only during the response. This allows to further extract everything related to cookie handling into a middleware in v13. Resolves: #100695 Releases: main Change-Id: I5c53c8f287eda0b161e979fe9372b403097ba062 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76846 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- Apr 20, 2023
-
-
Christian Kuhn authored
Last round of dependency bumps raise min versions. There is little reason to allow lower verisons for those not-too-common ones with first LTS realease, so we declare them as minimum. We skip enshrined/svg-sanitize due to it's broken sec release, though. firebase/php-jwt: new features, no reasons to stay low guzzlehttp/guzzle: improved version constraints nikic/php-parser: PHP fixes, no reason to stay low phpdocumentor/type-resolver: minor raise, internal rewrite, have it to find issues early typo3fluid/fluid: minor bump, no reason to stay low > composer req firebase/php-jwt:^6.4.0 > composer req --no-update firebase/php-jwt:^6.4.0 -d typo3/sysext/core > composer req guzzlehttp/guzzle:^7.5.1 > composer req --no-update guzzlehttp/guzzle:^7.5.1 -d typo3/sysext/core > composer req nikic/php-parser:^4.15.4 > composer req --no-update nikic/php-parser:^4.15.4 -d typo3/sysext/install > composer req phpdocumentor/type-resolver:^1.7.1 > composer req --no-update phpdocumentor/type-resolver:^1.7.1 -d typo3/sysext/extbase > composer req typo3fluid/fluid:^2.7.4 > composer req --no-update typo3fluid/fluid:^2.7.4 -d typo3/sysext/adminpanel > composer req --no-update typo3fluid/fluid:^2.7.4 -d typo3/sysext/core > composer req --no-update typo3fluid/fluid:^2.7.4 -d typo3/sysext/fluid > composer req --no-update typo3fluid/fluid:^2.7.4 -d typo3/sysext/redirects Resolves: #100693 Releases: main Change-Id: I0f0312ca2e820c442fa3bb81b43f36e233c00be3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78777 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Oliver Klee authored
Also add casts to callers that are not type-safe (yet). Also convert one call to use a first-class callable to improve static analysis. Resolves: #100686 Releases: main Change-Id: I0193a10238b9296c570268355480316e8ddfa4db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78772 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benjamin Kott authored
General spacings have been streamlined that are most relevant for CSS declarations that add `margin-bottom` to ensure there is space available to the next element. Headlines h1, h2, and h3 will not add additional space to the top if they are used in a document flow and are not the first element, and have no classes assigned. This provides a visual divider when a new content section is opened while keeping existing styles untouched. There are edge cases where it can be necessary to add the space manually because some additional necessary nesting is in place. For this case, the class `.headline-spaced` was introduced. This class is limited to h1, h2, and h3 and should be used with care. The code styling for <pre> and <code> has been adjusted when `[class*="language-"]` is matching. While we have no automatic syntax highlighting for this kind of area yet, this indicates that a user wants to highlight a section of code. Dropping row and col implementations for inline forms. We are introducing `.form-row` and respective variants to different viewports `.form-row-*` to have more control over spacing for inline forms. Each input element will consume the necessary space it needs and wrap if not enough space is available. The spacing for clearable elements is now applied to `.form-control-clearable`. This allows the spacing adjustments to be present before the JavaScript is invoked. The class will be added through js if not already present on the element. This avoids additional layout shifts. Resolves: #100663 Releases: main Change-Id: If9757d9dc04d9dca83cb1e89c5bbced1b20b5850 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78682 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Torben Hansen authored
This change removes several unused imports, which are not detected by php-cs-fixer, since the NoUnusedImportsFixer does not ignore references used in php doc comments. Resolves: #100673 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: Ibab8cf846eba748ea08b3254415921fd268a2021 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78757 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Benni Mack authored
Using sL() instead of getLL() shows direct dependencies on labels and their label files within the code. This change replaces all usages in * extensionmanager * form * impexp * install * reports * setup * filelist with sL() calls. Resolves: #100668 Releases: main Change-Id: Ic3cb1e307c9312a2fc2e0b21b3149c4baddebfe3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78755 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- Apr 18, 2023
-
-
Christian Kuhn authored
As feedback from translators: Setting BE/languageDebug=true clutters the backend so heavily, that the feature is of little use nowadays. The patch deprecates the toggle. Resolves: #100657 Releases: main Change-Id: I8283a780375b05630aa7050a8e2415ea1bdbc860 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78727 Tested-by:
Josef Glatz <typo3@josefglatz.at> Reviewed-by:
Josef Glatz <typo3@josefglatz.at> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Andreas Fernandez authored
This commit deprecates some methods in `DebugUtility`. `debugRows()` and :php:`printArray()` both have a duplicated method and `debugInPopUpWindow()` is discouraged with the same reasonings as with the removed of the Debug Console in #98069. Resolves: #100653 Releases: main Change-Id: I3bd986901435f4aa7a4e33fea5a614fe7a238264 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78719 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- Apr 17, 2023
-
-
Christian Kuhn authored
In addition to #98281 in TYPO3 v12.0, "pibase" AbstractPlugin now actively logs a deprecation message. Resolves: #100639 Related: #98281 Releases: main Change-Id: Ib8d17f745c9cefa7bfb76a9acfeac96c8a20234f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78686 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-