- Apr 05, 2019
-
-
Andreas Fernandez authored
This commit fixes a usage of the null coalesce operator within a condition. Resolves: #88092 Related: #84375 Releases: master, 9.5 Change-Id: Ic34fb492e66eb224d0e617405e8ae2be69a16aa4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60400 Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by:
André Schließer <andy.schliesser@gmail.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
-
Benni Mack authored
Although not used in TYPO3 Core directly, the identify command by ImageMagick now delivers the file extension from IM plus the file type identified by IM as well. This saves some regexp magic, and a foreach() loop, as the "-format" output delivers proper IM results. As this functionality is not actually fixing a core bug, but rather a small improvement and correction in the identified usage, the change is targeted to master-only. Resolves: #23348 Releases: master Change-Id: Ia380ee34dbbef7f9f763ecc088ee0c9b83167ce6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60311 Tested-by:
Sebastian Rosskopf <sebastian.rosskopf@gmx.de> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Henrik Elsner authored
Exception is thrown when changing the operator from an array handling one to a string handling. ("is in list" to "equals") Also the selection is not set properly after changing. Resolves: #88010 Releases: master, 9.5 Change-Id: Ibf7f607a51ac92d2c45dbfe16384f71c959e6c1f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60342 Tested-by: -
Markus Klein authored
Resolves: #88091 Releases: master, 9.5 Change-Id: I3261190c1214dece4dce5d208a54af2b14b3aa0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60399 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Georg Ringer authored
The SiteFinder must be used instead of only fetching all languages from sys_language. Resolves: #87999 Releases: master, 9.5 Change-Id: I95432c6221a8ee06d1fbb45a6780b0ec7c80ddf4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60337 Tested-by:
-
Christoph Lehmann authored
Currently there is no way to determine the error level of a previously registered error handler. The commit helps chaining error handlers and prevents unnecessary extra work. Resolves: #87281 Releases: master, 9.5 Change-Id: Ib6cc32eeb4714cae1dd16aa5382683c374615d38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59287 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Georg Ringer authored
EXT:viewpage must use the SiteMatcher to get the available languages. The join functionality has been removed as well to let users view a page in a fallback language. Resolves: #88001 Releaes: master, 9.5 Change-Id: Ibd0be7b2d169a7e8fb029905e3221fdd3ee5d69c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60338 Tested-by:
-
Guido Schmechel authored
With this change, there are no more restrictions in TCA within the be_groups. Resolves: #87967 Releases: master, 9.5 Change-Id: Ifc1cf2b41c15c43dd5a1e314c0cb0a418753455a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60301 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Kevin Meckl authored
Correct example TYPO3_CONF_VARS configuration for custom route enhancers registration. Releases: master, 9.5 Resolves: #88067 Change-Id: I0870498781f496d9c00331af126b96fd77eee70d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60369 Tested-by:
-
Chau kar authored
Removed the absolute positioning of the error page to avoid unexpected behavior when rendered in an encapsulated component, e.g. panels in the Install Tool. Resolves: #88064 Resolves: #87382 Releases: master, 9.5 Change-Id: I5cefeacc0f753ab57c8c1e95dffa39eb55f5950e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60377 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Helmut Hummel authored
Instead of hard coding the path, the ConfigurationManager API ist now used. Resolves: #88089 Releases: master, 9.5 Change-Id: I51b6c75583e54f00535538d6afdcb617d86f6079 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60374 Tested-by:
Wolf-Peter Utz <wpu@hotmail.de> Tested-by:
Xavier Perseguers <xavier@typo3.org> Reviewed-by:
-
Manuel Selbach authored
The property lastModifiedDate was remove by some browsers, thus with this change if will be checked and the proper property is used to parse the timestamp in the replace dialog. Resolves: #88081 Releases: master, 9.5, 8.7 Change-Id: I4ae812267ef81c4db5c86d2d6dd814f83bebeb00 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60373 Tested-by:
Felix Herrmann <herrmann@riconet.de> Tested-by:
-
- Apr 03, 2019
-
-
Markus Klein authored
The fifth parameter to Datahandler::insertDB() is used in one place without properly checking for the existence of the array element. In general this parameter is only used for imp/exp extension and works for admins only. Resolves: #88025 Releases: master, 9.5 Change-Id: Iba5656857b1b16fb601a3c6af424a6477edc6956 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60348 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benni Mack authored
Some test functionality regarding Site Handling is now sorted out in order to add more tests. - SiteConfiguration setup for tests is moved into a separate Trait. - Code which is also used (in the future) for EXT:core and not just frontend is moved to EXT:core - LocalizedFrontendPages now have a slug field as well. - Regular Frontend JsonRenderer now also renders values from SiteLanguage config + context aspect Resolves: #88060 Releases: master, 9.5 Change-Id: If859da89e4fcec16e3d1c2abb934eef040d4f386 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60363 Tested-by:
-
Daniel Goerz authored
TSFE->determineIdIsHiddenPage() now takes the current site language into account when fetching the page record. When rendering a page translation the mehtod does no longer reflect the hidden status of the default language but the status of the translated page instead. This enables previewing a hidden page translation even if the language parent is active. Resolves: #85471 Releases: master, 9.5 Change-Id: I1b0ead8eaf4c707583e24babbbca49870a31cdaa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60331 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
- Apr 02, 2019
-
-
Riny van Tiggelen authored
If you want to use a PDF inside the GalleryProcessor, the mediaWidth is always 0, because there are no dimensions in the metadata. This fix will use the maxMediaWidth if the dimension is not greater than 0. Resolves: #88047 Releases: master, 9.5 Change-Id: I56a2dc2a946385931172c86e54711ba8aa3f6637 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60357 Tested-by:
Koen Wouters <koen.wouters@maxserv.com> Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
-
Daniel Huf authored
The link must be prefixed with www, else the request will just show an error. Releases: master, 9.5, 8.7 Resolves: #88044 Change-Id: I2a7e5f34a741e92fdc1174d8be73204c19c197eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60355 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
- Mar 29, 2019
-
-
Georg Ringer authored
The TranslationConfigurationProvider must use the SiteMatcher to find the proper languages and must not depend only on fetching from sys_language. Resolves: #87942 Releases: master, 9.5 Change-Id: Ib8b8a980d7997effa38a6c2dcfbe8a3e7e3eb1a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60336 Tested-by:
-
Frank Naegler authored
Resolves: #87922 Releases: master Change-Id: I77f1973c656b3b2538a37cd2f4dc2b04358a7198 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60257 Tested-by:
-
- Mar 26, 2019
-
-
Sybille Peters authored
- Use different Changelog entry in extension scanner for AbstractAuthenticationService and AuthenticationService - Add links to Changelog - Change title in Changelog Resolves: #88005 Releases: master, 9.5 Change-Id: I6852a7511bda74bee398ef86b8ca59f7d7454e5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60340 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Filipe DA COSTA authored
Force ColorPicker to use the formatted/cleaned value jQuery's minicolors produces instead of just displaying it but still saving the raw value the user inputs. Resolves: #87031 Releases: master, 9.5 Change-Id: I49d9f094961137ae50561475d5421f536b705c70 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59052 Tested-by:
Henrik Elsner <helsner@dfau.de> Tested-by:
-
Andreas Fernandez authored
Querying the database for the placeholder `--div--` is rather pointless, thus this possibility is removed. Instead, the placeholder is converted into an optgroup. Resolves: #87976 Releases: master, 9.5 Change-Id: I60729a3fae1bc37c12612fccf0f8491ad27d8908 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60305 Tested-by:
-
Sybille Peters authored
Resolves: #88006 Releases: master Change-Id: I02cacfe4829b975411026acd4bfd0bb700a38153 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60339 Tested-by:
-
- Mar 25, 2019
-
-
Stefan Neufeind authored
Default is utf8 for the database-charset meanwhile. Resolves: #87052 Releases: master Change-Id: I4ec21f979a2b3e95ba30e10b94c538cde378b75d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59012 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Benni Mack authored
Due to removal of functionality and code in recent TYPO3 versions, internal code can now be removed: - PermissionAjaxController->getBackendUser() - RteHtmlParser->TS_AtagToAbs (never called) - PageRenderer->extOnReadyCode property - SetupModuleController - used several properties from the now removed "simulateUser" code which is not part of this module anymore. - At the same time, various "init" and "main" methods which are now protected are reordered to reflect the set up request workflow better. Resolves: #87991 Releases: master Change-Id: I197a13ff64b3cb006730d09120d0bd8d5c5c65f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60320 Tested-by: -
Christian Weiske authored
When editing a record in a workspace in the Backend, the "preview" button needs to use the live record uid and not the uid of the workspace version. Change-Id: I690c11e50b6275290175397cc9f28e1532b1d61d Releases: master, 9.5 Resolves: #81271 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/55070 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Benni Mack authored
When a page (slug) is modified in a preview workspace, links to that page need to be changed to the new slug, as the preview (PageRouter) should evaluate this as well. 1) The PageRouter should include records with "-1" to find them as well, but then fix the "pid" again to find the pid of the online version. 2) The PageLink Builder now uses the SiteFinder nstead of SiteMatcher to detect whether the linked page uid is part of a configured site. We do not need to create/detect a PseudoSite here, only instances of Site are of interest. Resolves: #87871 Releases: master, 9.5 Change-Id: Ifd6add71bec1616049f8c6a50a42bc9f573395e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59955 Tested-by:
-
Oliver Hader authored
In order to avoid cHash mismatches URL parameter 'ADMCMD_prev' is not being used for cHash calculation anymore. Resolves: #87995 Releases: master, 9.5 Change-Id: Ifefefc873478759a15aed786e16b062e28c739f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60327 Tested-by:
-
Benjamin Franzke authored
Some of the previous todos were failing because the test context contained a workspace id, but missed a backend user id. In that case the workspace id was ignored by the test framework (see TYPO3\JsonResponse\Middleware\BackendUserMiddleware). This patch also adapts the SlugLinkGeneratorTest to check link generation to versioned record both with and without a backend user authentication. Releases: master, 9.5 Resolves: #87973 Change-Id: I0a2ec41234963fd8af0ed3adf951f139f1e85215 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60302 Tested-by:
-
Benni Mack authored
This special setting resets a certain field to its default value when copying. This option was only there for resetting some sys_action values to default, which can easily be achieved by a hook if needed. The option is removed to reduce the amount of checks and the amount of available options for edge-cases in TCA, as this option was not widely used - as identified by the Persistence Initiative. Resolves: #87989 Releases: master Change-Id: Iae05d958ff31f0f0c4618486445baad7e624b73b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60276 Tested-by:
-
- Mar 24, 2019
-
-
Benni Mack authored
If a user switched his language settings in his preference, the top bar is now also refreshed reflecting the language change. Resolves: #18117 Releases: master, 9.5 Change-Id: Ifdcd08c65f12ce1083521e93205964a2f77ca811 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60321 Reviewed-by:
-
Wolfgang Klinger authored
The register SYS_LASTCHANGED needs to reflect the value of the translated page as well. This is now done properly in a separate method. Releases: master, 9.5 Resolves: #86963 Change-Id: Ieebd4207df03f3064c6e01d392a03ee253311f9b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58944 Tested-by:
-
- Mar 23, 2019
-
-
Oliver Hader authored
composer require --dev typo3/testing-framework:~5.0.7 Resolves: #87990 Releases: master Change-Id: I15a44b7cc0db267f3e7e004feeee9cbe18061dc6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60319 Tested-by:
Alexander Schnitzler <typo3@alexanderschnitzler.de> Tested-by:
-
Benni Mack authored
HMENU was hardened during v9 via deprecations of GMENU and making most of the properties protected. Therefore, code can now refactored more easily. - The method signatures for HMENU / TMENU are streamlined. - All leftover "RO" (RollOver) functionality is removed (Breaking RST is already done but left-over code was forgotten). - Several GeneralUtility::inList() checks are replaced with in_array() - Some minor strict types for some internal obvious methods - use json_encode() instead of serialize() for cache identifiers - resolve some very very nested if() statements - internal methods with "optional arguments" which are always called with all arguments, are built in a way that they are now non-optional. Resolves: #87907 Releases: master Change-Id: I80536b9b4dbc4609d38476c9ce48532fe71b73d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60244 Tested-by:
-
Helmut Hummel authored
The ErrorController must not modify the received response from the configured handler, to allow the handler to change it to a suitable value. Resolves: #87846 Releases: master, 9.5 Change-Id: I91d3ab0a78d383e5a0c9ee47ea21dc8634ddd3c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59873 Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
-
Benni Mack authored
The TCA[ctrl][selicon_field_path] option is not necessary anymore, as support for "internal_type=file" was dropped for v10.0. Resolves: #87937 Releases: master Change-Id: Iae3493c3fe829feb5fff889f274dbab5f0049717 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60274 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
-
Markus Klein authored
Resolves: #87986 Releases: master, 9.5 Change-Id: I9ccdbcae0c06a00fcd2904a203d1f3072b6e28ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60310 Tested-by:
-
- Mar 22, 2019
-
-
Christoph Lehmann authored
The index reduces the sql query time and thus is a performance improvement. On a table with 5 million rows the query time is ~ 38s without and less than 0.5s with the index Resolves: #87723 Releases: master Change-Id: I53b24ad0d09a2627a77720ec151dea30a14f5011 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59707 Tested-by:
Fabien Udriot <fabien.udriot@ecodev.ch> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Bernhard Sirlinger authored
The method ConnectionPool::resetConnections() is no longer annotated as @internal. This reflects that it is necessary to reset connections in a scheduler task spawning new child processes. This circumvents errors on accessing a connection that has already been closed. Resolves: #87111 Releases: master, 9.5 Change-Id: I3803073491766831e863635031c29a08585e7bf8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60252 Reviewed-by:
-
Benni Mack authored
The new pagelink builder does not set the lastTypoLinkLD options which is used in HMENUs. The patch properly sets the lastTypoLink* properties of ContentObjectRenderer in typolink again, making target overrides in menus work again. Resolves: #87130 Releases: master, 9.5 Change-Id: Ia284e546179dfaec8ec8ecb86a36d38f3b81aad8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60292 Tested-by:
-
